Re: [I] [Feature] Build MAL Debugger [skywalking]
wu-sheng commented on issue #7671: URL: https://github.com/apache/skywalking/issues/7671#issuecomment-1882543360 > But without a debugger, how can I observe the result to adjust my MAL rule? This was closed due to MAL position changed since 9.x. The MAL was planned for end users, which required too much dev experiences. In v9, we began to ship official dashboards, MAL scripts and new UI configurations are out of box. All people begin to learn OAL, MAL and LAL should have basic coding capabilities. They are developer oriented now. Many developers could understand the raw data and database structures now. So, this is not required. Of course, this is a nice to have thing, as it could make development more friendly. But PMC team is not going to spend time on it anyway. We are open to accept proposal and implementation if someone wants to add this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] Build MAL Debugger [skywalking]
anurnomeru commented on issue #7671: URL: https://github.com/apache/skywalking/issues/7671#issuecomment-1882532094 But without a debugger, how can I observe the result to adjust my MAL rule? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] spring-webflux-webclient-6.x/httpexchange support [skywalking]
wu-sheng commented on issue #11715: URL: https://github.com/apache/skywalking/issues/11715#issuecomment-1882464515 Is there any update about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] skywalking-go enhance method reports error [skywalking]
Ruff-nono opened a new issue, #11739:
URL: https://github.com/apache/skywalking/issues/11739
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
OAP server (apache/skywalking)
### What happened
I try to develop a plugin for rocketMQ，there is an error when i build the
file
/tmp/go-build612827965/b348/skywalking_delegator.go:46:10: cannot use nil as
ConsumeResult value in return statement
/tmp/go-build612827965/b348/skywalking_delegator.go:59:9: cannot use nil as
ConsumeResult value in return statement
/tmp/go-build612827965/b348/skywalking_delegator.go:80:13: cannot use nil as
ConsumeResult value in assignment
### What you expected to happen
The enhanced method is in the`pushconsumer.go`
`func (pc *pushConsumer) consumeInner(ctx context.Context, subMsgs
[]*primitive.MessageExt) (ConsumeResult, error)`
and `type ConsumeResult int` defined in the `consumer.go`，
so when FilterAndEdit -> EnhanceParameterNames,
MethodEnhance.ParameterInfo.DefaultValueAsString will be "nil" because it
cannot determine the real type of the custom type.
### How to reproduce
the enhanced file's default return value will result in a type error when
custom type is an integer
such as
```
{
PackagePath: "consumer",
At: instrument.NewMethodEnhance("*pushConsumer", "consumeInner",
instrument.WithArgsCount(2),
instrument.WithArgType(0, "context.Context"),
instrument.WithArgType(1, "[]*primitive.MessageExt"),
instrument.WithResultCount(2),
instrument.WithResultType(0, "ConsumeResult"),
instrument.WithResultType(1, "error")),
Interceptor: "ConsumeInnerInterceptor",
}
```
and the enhanced file like
```
if invocation.isContinue {
if invocation.returnValues[0] != nil {
*ret_0 = (invocation.returnValues[0]).(ConsumeResult)
} else {
*ret_0 = nil
}
}
```
### Anything else
_No response_
### Are you willing to submit a pull request to fix on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
notifications-unsubscr...@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug] skywalking-go 无法增强返回自定义类型的方法 [skywalking]
wu-sheng closed issue #11738: [Bug] skywalking-go 无法增强返回自定义类型的方法 URL: https://github.com/apache/skywalking/issues/11738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-go 无法增强返回自定义类型的方法 [skywalking]
wu-sheng commented on issue #11738: URL: https://github.com/apache/skywalking/issues/11738#issuecomment-1882349847 Please submit an issue in English. If you need Chinese discussion, please go to Slack CN Channel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] skywalking-go 无法增强返回自定义类型的方法 [skywalking]
Ruff-nono opened a new issue, #11738:
URL: https://github.com/apache/skywalking/issues/11738
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
OAP server (apache/skywalking)
### What happened
在开发rocketMQ插件时，报错
/tmp/go-build612827965/b348/skywalking_delegator.go:46:10: cannot use nil as
ConsumeResult value in return statement
/tmp/go-build612827965/b348/skywalking_delegator.go:59:9: cannot use nil as
ConsumeResult value in return statement
/tmp/go-build612827965/b348/skywalking_delegator.go:80:13: cannot use nil as
ConsumeResult value in assignment
### What you expected to happen
增强方法func (pc *pushConsumer) consumeInner(ctx context.Context, subMsgs
[]*primitive.MessageExt) (ConsumeResult, error)位于pushconsumer.go
而type ConsumeResult int定义在consumer.go文件中
在FilterAndEdit ->
EnhanceParameterNames时，无法判断出真实类型，DefaultValueAsString返回为"nil"
### How to reproduce
增强方法返回值为自定义类型且为int时，增强文件的返回默认值会类型错误
{
PackagePath: "consumer",
At: instrument.NewMethodEnhance("*pushConsumer",
"consumeInner",
instrument.WithArgsCount(2),
instrument.WithArgType(0, "context.Context"),
instrument.WithArgType(1,
"[]*primitive.MessageExt"),
instrument.WithResultCount(2),
instrument.WithResultType(0, "ConsumeResult"),
instrument.WithResultType(1, "error")),
Interceptor: "ConsumeInnerInterceptor",
}
增强返回如
if invocation.isContinue {
if invocation.returnValues[0] != nil {
*ret_0 = (invocation.returnValues[0]).(ConsumeResult)
} else {
*ret_0 = nil
}
}
### Anything else
_No response_
### Are you willing to submit a pull request to fix on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
notifications-unsubscr...@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Introduce sequential read for merging [skywalking-banyandb]
wu-sheng merged PR #367: URL: https://github.com/apache/skywalking-banyandb/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch main updated: Introduce sequential read for merging (#367)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new 0d7caf33 Introduce sequential read for merging (#367)
0d7caf33 is described below
commit 0d7caf336abeaaa7df6fd11b46d83ec19cd8c448
Author: Gao Hongtao
AuthorDate: Tue Jan 9 11:21:58 2024 +0800
Introduce sequential read for merging (#367)
---
banyand/internal/storage/tsdb.go | 5 ++
banyand/measure/block.go | 102 +++-
banyand/measure/block_reader.go | 124 +++
banyand/measure/block_reader_test.go | 5 +-
banyand/measure/block_test.go| 36 +-
banyand/measure/column.go| 23 +++
banyand/measure/flusher.go | 45 -
banyand/measure/gc.go| 5 +-
banyand/measure/introducer.go| 9 ++-
banyand/measure/merger.go| 72 ++--
banyand/measure/merger_test.go | 2 +-
banyand/measure/part.go | 4 +-
banyand/measure/part_iter.go | 50 ++
banyand/measure/part_iter_test.go| 15 +++--
banyand/measure/primary_metadata.go | 5 +-
banyand/measure/tstable.go | 7 +-
banyand/measure/tstable_test.go | 1 +
pkg/bytes/buffer.go | 30 +
pkg/fs/file_system.go| 13 +---
pkg/fs/local_file_system.go | 16 +++--
pkg/fs/local_file_system_test.go | 5 +-
pkg/index/inverted/inverted.go | 8 +--
pkg/index/inverted/inverted_test.go | 8 +--
scripts/build/version.mk | 2 +-
24 files changed, 446 insertions(+), 146 deletions(-)
diff --git a/banyand/internal/storage/tsdb.go b/banyand/internal/storage/tsdb.go
index 982b6a57..16b5fb09 100644
--- a/banyand/internal/storage/tsdb.go
+++ b/banyand/internal/storage/tsdb.go
@@ -63,6 +63,7 @@ func generateSegID(unit IntervalUnit, suffix int) segmentID {
type database[T TSTable, O any] struct {
logger *logger.Logger
index*seriesIndex
+ pcommon.Position
location string
sLst []*shard[T, O]
opts TSDBOpts[T, O]
@@ -100,6 +101,7 @@ func OpenTSDB[T TSTable, O any](ctx context.Context, opts
TSDBOpts[T, O]) (TSDB[
logger: logger.Fetch(ctx, p.Database),
index:si,
opts: opts,
+ p:p,
}
db.logger.Info().Str("path", opts.Location).Msg("initialized")
if err = db.loadDatabase(); err != nil {
@@ -151,6 +153,9 @@ func (d *database[T, O]) SelectTSTables(timeRange
timestamp.TimeRange) []TSTable
func (d *database[T, O]) registerShard(id int) error {
ctx := context.WithValue(context.Background(), logger.ContextKey,
d.logger)
+ ctx = common.SetPosition(ctx, func(p common.Position) common.Position {
+ return d.p
+ })
so, err := d.openShard(ctx, common.ShardID(id))
if err != nil {
return err
diff --git a/banyand/measure/block.go b/banyand/measure/block.go
index 88c40f3f..7da65663 100644
--- a/banyand/measure/block.go
+++ b/banyand/measure/block.go
@@ -196,9 +196,9 @@ func (b *block) marshalTagFamily(tf columnFamily, bm
*blockMetadata, ww *writers
}
func (b *block) unmarshalTagFamily(decoder *encoding.BytesBlockDecoder,
tfIndex int, name string,
- columnFamilyMetadataBlock *dataBlock, tagProjection []string,
metaReader, valueReader fs.Reader, readTagByProjection bool,
+ columnFamilyMetadataBlock *dataBlock, tagProjection []string,
metaReader, valueReader fs.Reader,
) {
- if readTagByProjection && len(tagProjection) < 1 {
+ if len(tagProjection) < 1 {
return
}
bb := bigValuePool.Generate()
@@ -213,24 +213,41 @@ func (b *block) unmarshalTagFamily(decoder
*encoding.BytesBlockDecoder, tfIndex
bigValuePool.Release(bb)
b.tagFamilies[tfIndex].name = name
- if readTagByProjection {
- if len(tagProjection) < 1 {
- return
- }
- cc := b.tagFamilies[tfIndex].resizeColumns(len(tagProjection))
- for j := range tagProjection {
- for i := range cfm.columnMetadata {
- if tagProjection[j] ==
cfm.columnMetadata[i].name {
- cc[j].mustReadValues(decoder,
valueReader, cfm.columnMetadata[i], uint64(b.Len()))
- break
- }
+ if len(tagProjection) < 1 {
+ return
+ }
+ cc := b.tagFamilies[tfIndex].resizeColumns(len(tagProjection))
+ for j := range tagProjection {
+ for i := range cfm.columnMetadata {
+ if
(skywalking) branch master updated: Document a new way to load balance OAP (#11737)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new b900fd0bb5 Document a new way to load balance OAP (#11737) b900fd0bb5 is described below commit b900fd0bb5fe4fc388477896982cfd7e09530d5a Author: kezhenxu94 AuthorDate: Tue Jan 9 11:21:18 2024 +0800 Document a new way to load balance OAP (#11737) --- docs/en/changes/changes.md | 1 + docs/en/setup/backend/backend-load-balancer.md | 71 -- docs/menu.yml | 2 +- 3 files changed, 70 insertions(+), 4 deletions(-) diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md index 5e37c09535..6d7366ab91 100644 --- a/docs/en/changes/changes.md +++ b/docs/en/changes/changes.md @@ -31,5 +31,6 @@ * Add `SWIP-2 Collecting and Gathering Kubernetes Monitoring Data`. * Update the `Overview` docs to add the `Service Hierarchy Relationship` section. * Fix incorrect words for `backend-bookkeeper-monitoring.md` and `backend-pulsar-monitoring.md` +* Document a new way to load balance OAP. All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/202?closed=1) diff --git a/docs/en/setup/backend/backend-load-balancer.md b/docs/en/setup/backend/backend-load-balancer.md index 6436326808..4773bb47dc 100644 --- a/docs/en/setup/backend/backend-load-balancer.md +++ b/docs/en/setup/backend/backend-load-balancer.md @@ -1,7 +1,13 @@ # Backend Load Balancer -When setting the Agent or Envoy to connect to the OAP server directly as in default, the OAP server cluster would face the problem -of load imbalance. This issue would be severe in high-traffic load scenarios. [SkyWalking Satellite](https://github.com/apache/skywalking-satellite) is recommended to be +When setting the Agent or Envoy to connect to the OAP server directly by default, +the OAP server cluster would face the problem of load imbalance. This issue +becomes severe in high-traffic load scenarios. In this doc, we will introduce +two means to solve the problem. + +## SkyWalking Satellite Project + +[SkyWalking Satellite](https://github.com/apache/skywalking-satellite) is recommended to be used as a native gateway proxy to provide load balancing capabilities for data content before the data from Agent/ Envoy reaches the OAP. The major difference between Satellite and other general wide used proxy(s), like Envoy, is that it would route the data accordingly to contents rather than connection, as gRPC streaming is used widely in SkyWalking. @@ -9,4 +15,63 @@ Follow instructions in the [Setup SkyWalking Satellite](https://skywalking.apach to deploy Satellite and connect your application to the Satellite. [Scaling with Apache SkyWalking](https://skywalking.apache.org/blog/2022-01-24-scaling-with-apache-skywalking/) blog -introduces the theory and technology details on how to set up a load balancer for the OAP cluster. \ No newline at end of file +introduces the theory and technology details on how to set up a load balancer for the OAP cluster. + +## Envoy Filter to Limit Connections Per OAP Instance + +If you don't want to deploy skywalking-satellite, you can enable Istio sidecar +injection for SkyWalking OAP Pods, + +```shell +kubectl label namespace $SKYWALKING_NAMESPACE istio-injection=enabled +kubectl -n $SKYWALKING_NAMESPACE rollout restart -l app=skywalking,component=oap +``` + +and apply an EnvoyFilter to limit the connections per OAP instance, so that +each of the OAP instance can have similar amount of gRPC connections. + +Before that, you need to calculate the number of connections for each OAP +instance as follows: + +``` +NUMBER_OF_SERVICE_PODS= + +# Each service Pod has 2 connections to OAP +NUMBER_OF_TOTAL_CONNECTIONS=$((NUMBER_OF_SERVICE_PODS * 2)) + +# Divide the total connections by the replicas of OAP +NUMBER_OF_CONNECTIONS_PER_OAP=$((NUMBER_OF_TOTAL_CONNECTIONS / $NUMBER_OF_OAP_REPLICAS)) +``` + +And you can apply an EnvoyFilter to limit connections: + +```shell +kubectl -n $SKYWALKING_NAMESPACE apply -f - <
Re: [PR] Document a new way to load balance OAP [skywalking]
wu-sheng merged PR #11737: URL: https://github.com/apache/skywalking/pull/11737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Introduce sequential read for merging [skywalking-banyandb]
codecov-commenter commented on PR #367: URL: https://github.com/apache/skywalking-banyandb/pull/367#issuecomment-1882300478 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `90 lines` in your changes are missing coverage. Please review. > Comparison is base [(`63aec36`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/63aec363eb767ceb0824c2c7ad91eb5233533e93?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 44.35% compared to head [(`bbe12da`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 44.52%. | [Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [banyand/measure/merger.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL21lcmdlci5nbw==) | 38.98% | [33 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/measure/block.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL2Jsb2NrLmdv) | 70.96% | [11 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/measure/block\_reader.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL2Jsb2NrX3JlYWRlci5nbw==) | 86.30% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/measure/column.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL2NvbHVtbi5nbw==) | 55.00% | [6 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/measure/flusher.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL2ZsdXNoZXIuZ28=) | 58.33% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [pkg/fs/local\_file\_system.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGtnL2ZzL2xvY2FsX2ZpbGVfc3lzdGVtLmdv) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/internal/storage/tsdb.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9pbnRlcm5hbC9zdG9yYWdlL3RzZGIuZ28=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/measure/part\_iter.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL3BhcnRfaXRlci5nbw==) | 92.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/measure/introducer.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL2ludHJvZHVjZXIuZ28=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/367?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files
[PR] Introduce sequential read for merging [skywalking-banyandb]
hanahmily opened a new pull request, #367: URL: https://github.com/apache/skywalking-banyandb/pull/367 The sequential read performs much better than the random read when merging files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) 02/02: Merge from origin/main
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch measure-merger in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit bbe12da89eae61413998f7f12cc6d8b285c7c2bc Author: Gao Hongtao AuthorDate: Tue Jan 9 02:59:29 2024 + Merge from origin/main Signed-off-by: Gao Hongtao --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 4cf9d42d..80b07eb9 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ It's designed to handle observability data generated by observability platform a BanyanDB, as an observability database, aims to ingest, analyze and store Metrics, Tracing, and Logging data. It's designed to handle observability data generated by Apache SkyWalking. Before BanyanDB emerges, the Databases that SkyWalking adopted are not ideal for the APM data model, especially for saving tracing and logging data. Consequently, There’s room to improve the performance and resource usage based on the nature of SkyWalking data patterns. -The database research community usually uses [RUM conjecture](http://daslab.seas.harvard.edu/rum-conjecture/) to describe how a database access data. BanyanDB combines several access methods to build a comprehensive APM database to balance read cost, update cost, and memory overhead. +The database research community usually uses [RUM Conjecture](http://daslab.seas.harvard.edu/rum-conjecture/) to describe how a database access data. BanyanDB combines several access methods to build a comprehensive APM database to balance read cost, update cost, and memory overhead. ## Contact us
(skywalking-banyandb) branch measure-merger updated (a3f81acf -> bbe12da8)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch measure-merger in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from a3f81acf Polish merge log add ecbce521 Implement measure merger (#364) add 63aec363 chore: rename conjecture to Conjectrue (#365) new dd381aa9 Merge remote-tracking branch 'origin/main' into measure-merger new bbe12da8 Merge from origin/main The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(skywalking-banyandb) 01/02: Merge remote-tracking branch 'origin/main' into measure-merger
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch measure-merger in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit dd381aa95c0611408239a1028b98b2729eb515b8 Merge: a3f81acf 63aec363 Author: Gao Hongtao AuthorDate: Tue Jan 9 02:52:02 2024 + Merge remote-tracking branch 'origin/main' into measure-merger
Re: [PR] Document a new way to load balance OAP [skywalking]
wu-sheng commented on PR #11737: URL: https://github.com/apache/skywalking/pull/11737#issuecomment-1882252926 One thing, the doc menu name should remove the word native. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Document a new way to load balance OAP [skywalking]
kezhenxu94 opened a new pull request, #11737: URL: https://github.com/apache/skywalking/pull/11737 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) 01/04: Fix decoder
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch measure-merger
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 4a82fe5e1977c7aec04d4607a1592c2a6c3aece9
Author: Gao Hongtao
AuthorDate: Mon Jan 8 23:22:40 2024 +
Fix decoder
Signed-off-by: Gao Hongtao
---
banyand/internal/storage/tsdb.go | 5 ++
banyand/measure/block.go | 103 -
banyand/measure/block_reader.go | 124 +++
banyand/measure/block_reader_test.go | 5 +-
banyand/measure/block_test.go| 36 +-
banyand/measure/column.go| 23 +++
banyand/measure/flusher.go | 7 +-
banyand/measure/gc.go| 18 +++--
banyand/measure/introducer.go| 5 +-
banyand/measure/merger.go| 46 +++--
banyand/measure/merger_test.go | 2 +-
banyand/measure/part.go | 4 +-
banyand/measure/part_iter.go | 50 ++
banyand/measure/part_iter_test.go| 15 +++--
banyand/measure/primary_metadata.go | 5 +-
banyand/measure/tstable.go | 7 +-
banyand/measure/tstable_test.go | 1 +
pkg/bytes/buffer.go | 29
pkg/fs/file_system.go| 13 +---
pkg/fs/local_file_system.go | 14 ++--
pkg/fs/local_file_system_test.go | 5 +-
pkg/index/inverted/inverted.go | 8 +--
pkg/index/inverted/inverted_test.go | 8 +--
23 files changed, 417 insertions(+), 116 deletions(-)
diff --git a/banyand/internal/storage/tsdb.go b/banyand/internal/storage/tsdb.go
index 982b6a57..87bb0291 100644
--- a/banyand/internal/storage/tsdb.go
+++ b/banyand/internal/storage/tsdb.go
@@ -66,6 +66,7 @@ type database[T TSTable, O any] struct {
location string
sLst []*shard[T, O]
opts TSDBOpts[T, O]
+ pcommon.Position
sync.RWMutex
sLen uint32
}
@@ -100,6 +101,7 @@ func OpenTSDB[T TSTable, O any](ctx context.Context, opts
TSDBOpts[T, O]) (TSDB[
logger: logger.Fetch(ctx, p.Database),
index:si,
opts: opts,
+ p:p,
}
db.logger.Info().Str("path", opts.Location).Msg("initialized")
if err = db.loadDatabase(); err != nil {
@@ -151,6 +153,9 @@ func (d *database[T, O]) SelectTSTables(timeRange
timestamp.TimeRange) []TSTable
func (d *database[T, O]) registerShard(id int) error {
ctx := context.WithValue(context.Background(), logger.ContextKey,
d.logger)
+ ctx = common.SetPosition(ctx, func(p common.Position) common.Position {
+ return d.p
+ })
so, err := d.openShard(ctx, common.ShardID(id))
if err != nil {
return err
diff --git a/banyand/measure/block.go b/banyand/measure/block.go
index 88c40f3f..e1af6a5f 100644
--- a/banyand/measure/block.go
+++ b/banyand/measure/block.go
@@ -196,9 +196,9 @@ func (b *block) marshalTagFamily(tf columnFamily, bm
*blockMetadata, ww *writers
}
func (b *block) unmarshalTagFamily(decoder *encoding.BytesBlockDecoder,
tfIndex int, name string,
- columnFamilyMetadataBlock *dataBlock, tagProjection []string,
metaReader, valueReader fs.Reader, readTagByProjection bool,
+ columnFamilyMetadataBlock *dataBlock, tagProjection []string,
metaReader, valueReader fs.Reader,
) {
- if readTagByProjection && len(tagProjection) < 1 {
+ if len(tagProjection) < 1 {
return
}
bb := bigValuePool.Generate()
@@ -213,24 +213,42 @@ func (b *block) unmarshalTagFamily(decoder
*encoding.BytesBlockDecoder, tfIndex
bigValuePool.Release(bb)
b.tagFamilies[tfIndex].name = name
- if readTagByProjection {
- if len(tagProjection) < 1 {
- return
- }
- cc := b.tagFamilies[tfIndex].resizeColumns(len(tagProjection))
- for j := range tagProjection {
- for i := range cfm.columnMetadata {
- if tagProjection[j] ==
cfm.columnMetadata[i].name {
- cc[j].mustReadValues(decoder,
valueReader, cfm.columnMetadata[i], uint64(b.Len()))
- break
- }
+ if len(tagProjection) < 1 {
+ return
+ }
+ cc := b.tagFamilies[tfIndex].resizeColumns(len(tagProjection))
+ for j := range tagProjection {
+ for i := range cfm.columnMetadata {
+ if tagProjection[j] == cfm.columnMetadata[i].name {
+ cc[j].mustReadValues(decoder, valueReader,
cfm.columnMetadata[i], uint64(b.Len()))
+ break
}
}
- return
}
+ return
+}
+
(skywalking-banyandb) 02/04: Fix linter
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch measure-merger
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit e69360b21629ae99926e047882f3187f32745647
Author: Gao Hongtao
AuthorDate: Tue Jan 9 01:32:58 2024 +
Fix linter
Signed-off-by: Gao Hongtao
---
banyand/internal/storage/tsdb.go | 2 +-
banyand/measure/block.go | 1 -
banyand/measure/block_reader.go | 4 ++--
banyand/measure/flusher.go | 38 ++
banyand/measure/gc.go| 13 -
banyand/measure/introducer.go| 4
banyand/measure/merger.go| 28
banyand/measure/part_iter.go | 4 ++--
pkg/bytes/buffer.go | 1 +
pkg/fs/local_file_system.go | 12 ++--
10 files changed, 50 insertions(+), 57 deletions(-)
diff --git a/banyand/internal/storage/tsdb.go b/banyand/internal/storage/tsdb.go
index 87bb0291..16b5fb09 100644
--- a/banyand/internal/storage/tsdb.go
+++ b/banyand/internal/storage/tsdb.go
@@ -63,10 +63,10 @@ func generateSegID(unit IntervalUnit, suffix int) segmentID
{
type database[T TSTable, O any] struct {
logger *logger.Logger
index*seriesIndex
+ pcommon.Position
location string
sLst []*shard[T, O]
opts TSDBOpts[T, O]
- pcommon.Position
sync.RWMutex
sLen uint32
}
diff --git a/banyand/measure/block.go b/banyand/measure/block.go
index e1af6a5f..7da65663 100644
--- a/banyand/measure/block.go
+++ b/banyand/measure/block.go
@@ -225,7 +225,6 @@ func (b *block) unmarshalTagFamily(decoder
*encoding.BytesBlockDecoder, tfIndex
}
}
}
- return
}
func (b *block) unmarshalTagFamilyFromSeqReaders(decoder
*encoding.BytesBlockDecoder, tfIndex int, name string,
diff --git a/banyand/measure/block_reader.go b/banyand/measure/block_reader.go
index 5596682a..219d0a94 100644
--- a/banyand/measure/block_reader.go
+++ b/banyand/measure/block_reader.go
@@ -80,11 +80,11 @@ func releaseSeqReader(sr *seqReader) {
var seqReaderPool sync.Pool
type seqReaders struct {
+ tagFamilyMetadata map[string]*seqReader
+ tagFamilies map[string]*seqReader
primary seqReader
timestampsseqReader
fieldValues seqReader
- tagFamilyMetadata map[string]*seqReader
- tagFamilies map[string]*seqReader
}
func (sr *seqReaders) reset() {
diff --git a/banyand/measure/flusher.go b/banyand/measure/flusher.go
index 2ce4e787..16ae914d 100644
--- a/banyand/measure/flusher.go
+++ b/banyand/measure/flusher.go
@@ -53,20 +53,16 @@ func (tst *tsTable) flusherLoop(flushCh chan
*flusherIntroduction, mergeCh chan
}
tst.RUnlock()
if curSnapshot != nil {
- newSnapshot, err :=
tst.mergeMemParts(curSnapshot, mergeCh)
+ merged, err := tst.mergeMemParts(curSnapshot,
mergeCh)
if err != nil {
tst.l.Logger.Warn().Err(err).Msgf("cannot merge snapshot: %d",
curSnapshot.epoch)
curSnapshot.decRef()
continue
}
- var toBePersistedSnapshot *snapshot
- if newSnapshot == nil {
+ if !merged {
tst.flush(curSnapshot, flushCh)
- toBePersistedSnapshot = curSnapshot
- } else {
- toBePersistedSnapshot = newSnapshot
}
- epoch =
tst.persistSnapshot(toBePersistedSnapshot)
+ epoch = curSnapshot.epoch
// Notify merger to start a new round of merge.
// This round might have be triggered in
pauseFlusherToPileupMemParts.
flusherWatchers.Notify(math.MaxUint64)
@@ -80,7 +76,6 @@ func (tst *tsTable) flusherLoop(flushCh chan
*flusherIntroduction, mergeCh chan
if epochWatcher == nil {
return
}
- tst.gc.clean()
}
}
}
@@ -105,9 +100,8 @@ func (tst *tsTable) pauseFlusherToPileupMemParts(epoch
uint64, flushWatcher watc
return flusherWatchers
}
-func (tst *tsTable) mergeMemParts(snp *snapshot, mergeCh chan
*mergerIntroduction) (*snapshot, error) {
+func (tst *tsTable) mergeMemParts(snp *snapshot, mergeCh chan
*mergerIntroduction) (bool, error) {
var memParts []*partWrapper
-
(skywalking-banyandb) 04/04: Polish merge log
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch measure-merger
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit a3f81acf8ea063871b993e92ea76a5f79939e4b2
Author: Gao Hongtao
AuthorDate: Tue Jan 9 02:33:25 2024 +
Polish merge log
Signed-off-by: Gao Hongtao
---
banyand/measure/merger.go | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/banyand/measure/merger.go b/banyand/measure/merger.go
index 11d92788..1f03ca1e 100644
--- a/banyand/measure/merger.go
+++ b/banyand/measure/merger.go
@@ -23,6 +23,8 @@ import (
"sync/atomic"
"time"
+ "github.com/dustin/go-humanize"
+
"github.com/apache/skywalking-banyandb/pkg/encoding"
"github.com/apache/skywalking-banyandb/pkg/fs"
"github.com/apache/skywalking-banyandb/pkg/watcher"
@@ -103,24 +105,28 @@ func (tst *tsTable)
mergePartsThenSendIntroduction(creator snapshotCreator, part
Int("beforePartCount", len(parts)).
Dur("elapsed", elapsed).
Msg("background merger takes too long")
- } else if snapshotCreatorMerger == creator && tst.l.Info().Enabled() {
- var minCount, maxCount, totalCount uint64
+ } else if snapshotCreatorMerger == creator && tst.l.Info().Enabled() &&
len(parts) > 2 {
+ var minSize, maxSize, totalSize, totalCount uint64
for _, pw := range parts {
totalCount += pw.p.partMetadata.TotalCount
- if minCount == 0 || minCount >
pw.p.partMetadata.TotalCount {
- minCount = pw.p.partMetadata.TotalCount
+ totalSize += pw.p.partMetadata.CompressedSizeBytes
+ if minSize == 0 || minSize >
pw.p.partMetadata.CompressedSizeBytes {
+ minSize = pw.p.partMetadata.CompressedSizeBytes
}
- if maxCount < pw.p.partMetadata.TotalCount {
- maxCount = pw.p.partMetadata.TotalCount
+ if maxSize < pw.p.partMetadata.CompressedSizeBytes {
+ maxSize = pw.p.partMetadata.CompressedSizeBytes
}
}
- if minCount*uint64(len(parts)) < maxCount {
+ if totalSize > 10<<20 && minSize*uint64(len(parts)) < maxSize {
+ // it's a unbalanced merge. but it's ok when the size
is small.
tst.l.Info().
- Uint64("beforeTotalCount", totalCount).
- Uint64("afterTotalCount",
newPart.p.partMetadata.TotalCount).
+ Str("beforeTotalCount",
humanize.Comma(int64(totalCount))).
+ Str("afterTotalCount",
humanize.Comma(int64(newPart.p.partMetadata.TotalCount))).
Int("beforePartCount", len(parts)).
- Dur("elapsed", elapsed).
- Msg("background merger merges too big
difference parts")
+ Str("minSize", humanize.IBytes(minSize)).
+ Str("maxSize", humanize.IBytes(maxSize)).
+ Dur("elapsedMS", elapsed).
+ Msg("background merger merges unbalanced parts")
}
}
mi := generateMergerIntroduction()
(skywalking-banyandb) branch measure-merger created (now a3f81acf)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch measure-merger in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at a3f81acf Polish merge log This branch includes the following new commits: new 4a82fe5e Fix decoder new e69360b2 Fix linter new f7925eea Update ginkgo cli new a3f81acf Polish merge log The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(skywalking-banyandb) 03/04: Update ginkgo cli
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch measure-merger in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit f7925eea57a5f39c2fd2ebe165c84e3974b16674 Author: Gao Hongtao AuthorDate: Tue Jan 9 01:41:37 2024 + Update ginkgo cli Signed-off-by: Gao Hongtao --- scripts/build/version.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/build/version.mk b/scripts/build/version.mk index 9f0e32c6..18bb0bd0 100644 --- a/scripts/build/version.mk +++ b/scripts/build/version.mk @@ -29,4 +29,4 @@ LICENSE_EYE_VERSION := a790ab8dd23a7f861c18bd6aaa9b012e3a234bce MOCKGEN_VERSION := v0.3.0 -GINKGO_VERSION := v2.13.0 \ No newline at end of file +GINKGO_VERSION := v2.13.2 \ No newline at end of file
(skywalking-banyandb) branch dependabot/go_modules/github.com/go-resty/resty/v2-2.11.0 deleted (was 57e411c6)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/github.com/go-resty/resty/v2-2.11.0 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was 57e411c6 Bump github.com/go-resty/resty/v2 from 2.10.0 to 2.11.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump github.com/go-resty/resty/v2 from 2.10.0 to 2.11.0 [skywalking-banyandb]
wu-sheng closed pull request #366: Bump github.com/go-resty/resty/v2 from 2.10.0 to 2.11.0 URL: https://github.com/apache/skywalking-banyandb/pull/366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github.com/go-resty/resty/v2 from 2.10.0 to 2.11.0 [skywalking-banyandb]
dependabot[bot] commented on PR #366: URL: https://github.com/apache/skywalking-banyandb/pull/366#issuecomment-1882025360 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch dependabot/go_modules/github.com/go-resty/resty/v2-2.11.0 created (now 57e411c6)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/github.com/go-resty/resty/v2-2.11.0 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at 57e411c6 Bump github.com/go-resty/resty/v2 from 2.10.0 to 2.11.0 No new revisions were added by this update.
[PR] Bump github.com/go-resty/resty/v2 from 2.10.0 to 2.11.0 [skywalking-banyandb]
dependabot[bot] opened a new pull request, #366: URL: https://github.com/apache/skywalking-banyandb/pull/366 Bumps [github.com/go-resty/resty/v2](https://github.com/go-resty/resty) from 2.10.0 to 2.11.0. Release notes Sourced from https://github.com/go-resty/resty/releases;>github.com/go-resty/resty/v2's releases. v2.11.0 Release Release Notes Bug Fixes Security: Don't put the same bytes.Buffer into sync.Pool twice by https://github.com/lattwood;>@lattwood in https://redirect.github.com/go-resty/resty/pull/745;>go-resty/resty#745, https://redirect.github.com/go-resty/resty/issues/764;>#764, https://redirect.github.com/go-resty/resty/issues/756;>#756 fix: Improve Digest WWW-Authenticate response header parsing compatibility by https://github.com/bearki;>@bearki in https://redirect.github.com/go-resty/resty/pull/735;>go-resty/resty#735 New Contributors https://github.com/lattwood;>@lattwood made their first contribution in https://redirect.github.com/go-resty/resty/pull/745;>go-resty/resty#745 https://github.com/bearki;>@bearki made their first contribution in https://redirect.github.com/go-resty/resty/pull/735;>go-resty/resty#735 Full Changelog: https://github.com/go-resty/resty/compare/v2.10.0...v2.11.0;>https://github.com/go-resty/resty/compare/v2.10.0...v2.11.0 Commits https://github.com/go-resty/resty/commit/1323ededda78ecc908a01a8b89f1b1a7d87a2725;>1323ede release: v2.11.0 update (https://redirect.github.com/go-resty/resty/issues/767;>#767) https://github.com/go-resty/resty/commit/74050fd11b280e83c32be2017eaccd8f513490d1;>74050fd fix: Improve Digest WWW-Authenticate response header parsing compatibility (#... https://github.com/go-resty/resty/commit/577fed8730d79f583eb48dfc81674164e1fc471e;>577fed8 Don't put the same bytes.Buffer into sync.Pool twice (https://redirect.github.com/go-resty/resty/issues/745;>#745) See full diff in https://github.com/go-resty/resty/compare/v2.10.0...v2.11.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/skywalking-banyandb/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 [skywalking-eyes]
dependabot[bot] opened a new pull request, #176:
URL: https://github.com/apache/skywalking-eyes/pull/176
Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl)
from 1.3.3 to 1.3.7.
Release notes
Sourced from https://github.com/cloudflare/circl/releases;>github.com/cloudflare/circl's
releases.
CIRCL v1.3.7
What's Changed
build(deps): bump golang.org/x/crypto from
0.3.1-0.20221117191849-2c476679df9a to 0.17.0 by https://github.com/dependabot;>@dependabot in https://redirect.github.com/cloudflare/circl/pull/467;>cloudflare/circl#467
kyber: remove division by q in ciphertext compression by https://github.com/bwesterb;>@bwesterb in https://redirect.github.com/cloudflare/circl/pull/468;>cloudflare/circl#468
Releasing CIRCL v1.3.7 by https://github.com/armfazh;>@armfazh in https://redirect.github.com/cloudflare/circl/pull/469;>cloudflare/circl#469
New Contributors
https://github.com/dependabot;>@dependabot
made their first contribution in https://redirect.github.com/cloudflare/circl/pull/467;>cloudflare/circl#467
Full Changelog: https://github.com/cloudflare/circl/compare/v1.3.6...v1.3.7;>https://github.com/cloudflare/circl/compare/v1.3.6...v1.3.7
CIRCL v1.3.6
What's Changed
internal: add TurboShake{128,256} by https://github.com/bwesterb;>@bwesterb in https://redirect.github.com/cloudflare/circl/pull/430;>cloudflare/circl#430
Kangaroo12 draft -10 by https://github.com/bwesterb;>@bwesterb in https://redirect.github.com/cloudflare/circl/pull/431;>cloudflare/circl#431
Add K12 as XOF by https://github.com/bwesterb;>@bwesterb in https://redirect.github.com/cloudflare/circl/pull/437;>cloudflare/circl#437
xof/k12: Fix a typo in the package documentation by https://github.com/cjpatton;>@cjpatton in https://redirect.github.com/cloudflare/circl/pull/438;>cloudflare/circl#438
Set CIRCL version for generated assembler code. by https://github.com/armfazh;>@armfazh in https://redirect.github.com/cloudflare/circl/pull/440;>cloudflare/circl#440
Add tkn20 benchmarks by https://github.com/tanyav2;>@tanyav2 in https://redirect.github.com/cloudflare/circl/pull/442;>cloudflare/circl#442
Add partially blind RSA implementation by https://github.com/chris-wood;>@chris-wood in https://redirect.github.com/cloudflare/circl/pull/445;>cloudflare/circl#445
Update doc.go by https://github.com/nadimkobeissi;>@nadimkobeissi in https://redirect.github.com/cloudflare/circl/pull/447;>cloudflare/circl#447
tss/rsa: key generation for threshold RSA (safe primes) by https://github.com/armfazh;>@armfazh in https://redirect.github.com/cloudflare/circl/pull/450;>cloudflare/circl#450
Bumping Go version for CI jobs. by https://github.com/armfazh;>@armfazh in https://redirect.github.com/cloudflare/circl/pull/457;>cloudflare/circl#457
Spelling by https://github.com/jsoref;>@jsoref in https://redirect.github.com/cloudflare/circl/pull/456;>cloudflare/circl#456
blindrsa: updating blindrsa to be compliant with RFC9474 by https://github.com/armfazh;>@armfazh in https://redirect.github.com/cloudflare/circl/pull/464;>cloudflare/circl#464
Releasing CIRCL v1.3.6 by https://github.com/armfazh;>@armfazh in https://redirect.github.com/cloudflare/circl/pull/465;>cloudflare/circl#465
New Contributors
https://github.com/nadimkobeissi;>@nadimkobeissi made
their first contribution in https://redirect.github.com/cloudflare/circl/pull/447;>cloudflare/circl#447
https://github.com/jsoref;>@jsoref made their
first contribution in https://redirect.github.com/cloudflare/circl/pull/456;>cloudflare/circl#456
Full Changelog: https://github.com/cloudflare/circl/compare/v1.3.3...v1.3.6;>https://github.com/cloudflare/circl/compare/v1.3.3...v1.3.6
Commits
https://github.com/cloudflare/circl/commit/c48866b3068dfa83721c021dec03c777ba91abab;>c48866b
Releasing CIRCL v1.3.7
https://github.com/cloudflare/circl/commit/75ef91e8a2f438e6ce2b6e620d236add8be1887d;>75ef91e
kyber: remove division by q in ciphertext compression
https://github.com/cloudflare/circl/commit/899732a43256a5d6fb779917f597b32939ca4ba4;>899732a
build(deps): bump golang.org/x/crypto
https://github.com/cloudflare/circl/commit/99f0f715ca5fbec868f5a0db1df2be6dcd28dbaa;>99f0f71
Releasing CIRCL v1.3.6
https://github.com/cloudflare/circl/commit/e728d0d84e7e7cd9027050a62aa14adb8dec147c;>e728d0d
Apply thibmeu code review suggestions
https://github.com/cloudflare/circl/commit/ceb2d90c4922ec2e26be09a20f217ee57c8ba1c4;>ceb2d90
Updating blindrsa to be compliant with RFC9474.
https://github.com/cloudflare/circl/commit/44133f703215856ee0b8f243778f24b001ff6c95;>44133f7
spelling: tripped
https://github.com/cloudflare/circl/commit/c2076d67b2c717b1b1c6f3aa3b324bf93079b6fb;>c2076d6
spelling: transposes
https://github.com/cloudflare/circl/commit/dad216659ee1c9969957557a713537ceb589fce5;>dad2166
spelling: title
(skywalking-website) branch asf-site updated: deploy: fe54f2541fcabba6ee49c6497ca9daaed2a91795
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 9535b7c1a85 deploy: fe54f2541fcabba6ee49c6497ca9daaed2a91795 9535b7c1a85 is described below commit 9535b7c1a85c35ff1eb8d04bf79150f66f444dfe Author: wu-sheng AuthorDate: Mon Jan 8 12:25:57 2024 + deploy: fe54f2541fcabba6ee49c6497ca9daaed2a91795 --- .../next/api-reference/index.html | 2 +- docs/skywalking-banyandb/next/clients/index.html | 2 +- .../next/concept/clustering/index.html | 2 +- .../next/concept/data-model/index.html | 2 +- .../next/concept/persistence-storage/index.html| 2 +- .../next/concept/tsdb/index.html | 2 +- .../next/concept/wal/index.html| 2 +- .../skywalking-banyandb/next/crud/group/index.html | 2 +- .../next/crud/index_rule/index.html| 2 +- .../next/crud/index_rule_binding/index.html| 2 +- .../next/crud/measure/query/index.html | 2 +- .../next/crud/measure/schema/index.html| 2 +- .../next/crud/property/index.html | 2 +- .../next/crud/stream/query/index.html | 2 +- .../next/crud/stream/schema/index.html | 2 +- .../next/installation/binaries/index.html | 2 +- .../next/installation/cluster/index.html | 2 +- .../next/installation/index.html | 2 +- .../next/installation/standalone/index.html| 2 +- .../next/observability/index.html | 2 +- docs/skywalking-banyandb/next/readme/index.html| 2 +- docs/skywalking-banyandb/next/release/index.html | 4 +-- index.html | 2 +- index.json | 2 +- team/index.html| 30 ++ 25 files changed, 45 insertions(+), 35 deletions(-) diff --git a/docs/skywalking-banyandb/next/api-reference/index.html b/docs/skywalking-banyandb/next/api-reference/index.html index e91ecc5c2e6..1470293f412 100644 --- a/docs/skywalking-banyandb/next/api-reference/index.html +++ b/docs/skywalking-banyandb/next/api-reference/index.html @@ -567,7 +567,7 @@ Table of Contents banyandb/cluster/v1/rpc.proto })() - Commit Id: ecbce52 + Commit Id: 63aec36 diff --git a/docs/skywalking-banyandb/next/clients/index.html b/docs/skywalking-banyandb/next/clients/index.html index a4c274a1d75..b122178de2a 100644 --- a/docs/skywalking-banyandb/next/clients/index.html +++ b/docs/skywalking-banyandb/next/clients/index.html @@ -513,7 +513,7 @@ These are several ways to install: })() - Commit Id: ecbce52 + Commit Id: 63aec36 diff --git a/docs/skywalking-banyandb/next/concept/clustering/index.html b/docs/skywalking-banyandb/next/concept/clustering/index.html index 09b8cbb9317..93f0726ef0e 100644 --- a/docs/skywalking-banyandb/next/concept/clustering/index.html +++ b/docs/skywalking-banyandb/next/concept/clustering/index.html @@ -513,7 +513,7 @@ })() - Commit Id: ecbce52 + Commit Id: 63aec36 diff --git a/docs/skywalking-banyandb/next/concept/data-model/index.html b/docs/skywalking-banyandb/next/concept/data-model/index.html index ee808765dea..2cee1e16cb6 100644 --- a/docs/skywalking-banyandb/next/concept/data-model/index.html +++ b/docs/skywalking-banyandb/next/concept/data-model/index.html @@ -516,7 +516,7 @@ Groups Group does not provide a mechanism for isolating groups of resources with })() - Commit Id: ecbce52 + Commit Id: 63aec36 diff --git a/docs/skywalking-banyandb/next/concept/persistence-storage/index.html b/docs/skywalking-banyandb/next/concept/persistence-storage/index.html index f16de8576cd..ed9b3194260 100644 --- a/docs/skywalking-banyandb/next/concept/persistence-storage/index.html +++ b/docs/skywalking-banyandb/next/concept/persistence-storage/index.html @@ -507,7 +507,7 @@ })() - Commit Id: ecbce52 + Commit Id: 63aec36 diff --git a/docs/skywalking-banyandb/next/concept/tsdb/index.html b/docs/skywalking-banyandb/next/concept/tsdb/index.html index b5513c2ae80..53a948d9fa8 100644 --- a/docs/skywalking-banyandb/next/concept/tsdb/index.html +++ b/docs/skywalking-banyandb/next/concept/tsdb/index.html @@ -510,7 +510,7 @@ Shard In TSDB, the data in a group is partitioned into shards based on a configu })() - Commit Id: ecbce52 + Commit Id: 63aec36 diff --git a/docs/skywalking-banyandb/next/concept/wal/index.html
(skywalking-banyandb) branch main updated: chore: rename conjecture to Conjectrue (#365)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/main by this push: new 63aec363 chore: rename conjecture to Conjectrue (#365) 63aec363 is described below commit 63aec363eb767ceb0824c2c7ad91eb5233533e93 Author: Caican Cai <77189278+caican...@users.noreply.github.com> AuthorDate: Mon Jan 8 20:16:53 2024 +0800 chore: rename conjecture to Conjectrue (#365) --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 4cf9d42d..80b07eb9 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ It's designed to handle observability data generated by observability platform a BanyanDB, as an observability database, aims to ingest, analyze and store Metrics, Tracing, and Logging data. It's designed to handle observability data generated by Apache SkyWalking. Before BanyanDB emerges, the Databases that SkyWalking adopted are not ideal for the APM data model, especially for saving tracing and logging data. Consequently, There’s room to improve the performance and resource usage based on the nature of SkyWalking data patterns. -The database research community usually uses [RUM conjecture](http://daslab.seas.harvard.edu/rum-conjecture/) to describe how a database access data. BanyanDB combines several access methods to build a comprehensive APM database to balance read cost, update cost, and memory overhead. +The database research community usually uses [RUM Conjecture](http://daslab.seas.harvard.edu/rum-conjecture/) to describe how a database access data. BanyanDB combines several access methods to build a comprehensive APM database to balance read cost, update cost, and memory overhead. ## Contact us
Re: [PR] chore: rename conjecture to Conjectrue [skywalking-banyandb]
wu-sheng merged PR #365: URL: https://github.com/apache/skywalking-banyandb/pull/365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore: rename conjecture to Conjectrue [skywalking-banyandb]
codecov-commenter commented on PR #365: URL: https://github.com/apache/skywalking-banyandb/pull/365#issuecomment-1880799691 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/365?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`ecbce52`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/ecbce521977010379b8c54939836afcd5279dc26?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 44.41% compared to head [(`29595a2`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/365?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 44.38%. Additional details and impacted files ```diff @@Coverage Diff @@ ## main #365 +/- ## == - Coverage 44.41% 44.38% -0.03% == Files 151 151 Lines 1747417474 == - Hits 7761 7756 -5 - Misses 9018 9022 +4 - Partials 695 696 +1 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/365?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore: rename conjecture to Conjectrue [skywalking-banyandb]
caicancai opened a new pull request, #365: URL: https://github.com/apache/skywalking-banyandb/pull/365  From the official website, it seems to be RUM Conjecture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
