Re: [PR] Support rocketmq monitoring [skywalking]
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1913401990 OK. We are still waiting for RocketMQ exporter released. It seems not that quick. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adjust description of Rover agent [skywalking]
wu-sheng commented on PR #11837: URL: https://github.com/apache/skywalking/pull/11837#issuecomment-1913399390 This change is from the changes of Rover agent landscape. Rover has removed the support of VM and focused on the k8s 7x24 monitoring and continues supporting profiling of CPU and network, with trace enhancement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Adjust description of Rover agent [skywalking]
wu-sheng opened a new pull request, #11837: URL: https://github.com/apache/skywalking/pull/11837 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch master updated: Polish.
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new b995c46ecf0 Polish. b995c46ecf0 is described below commit b995c46ecf0170abc43b64e30f625ce7ec0e6708 Author: 吴晟 Wu Sheng AuthorDate: Sun Jan 28 09:16:49 2024 +0800 Polish. --- content/_index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/_index.html b/content/_index.html index 81c3e424abb..8f33af75bb4 100644 --- a/content/_index.html +++ b/content/_index.html @@ -69,7 +69,7 @@ linkTitle = "Apache SkyWalking" eBPF early adoption -Rover agent works as a monitor and profiler powered by eBPF to monitor network traffic and diagnose CPU and network performance. +Rover agent works as a monitor and profiler powered by eBPF to monitor Kubernetes deployments and diagnose CPU and network performance.
(skywalking) branch wu-sheng-patch-1 created (now b7d12ff960)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git at b7d12ff960 Adjust description of Rover agent This branch includes the following new commits: new b7d12ff960 Adjust description of Rover agent The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(skywalking) 01/01: Adjust description of Rover agent
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit b7d12ff960026e87c5f99dde38f216040438ab84 Author: 吴晟 Wu Sheng AuthorDate: Sun Jan 28 09:16:31 2024 +0800 Adjust description of Rover agent --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b35e534efe..3f425bef7b 100644 --- a/README.md +++ b/README.md @@ -20,7 +20,7 @@ microservices, cloud native and container-based architectures. * Agents for your stack * Java, .Net Core, PHP, NodeJS, Golang, LUA, Rust, C++, Client JavaScript and Python agents with active development and maintenance. * eBPF early adoption - * Rover agent works as a monitor and profiler powered by eBPF to diagnose CPU and network performance. + * Rover agent works as a monitor and profiler powered by eBPF to monitor Kubernetes deployments and diagnose CPU and network performance. * Scaling * 100+ billion telemetry data could be collected and analyzed from one SkyWalking cluster. * Mature Telemetry Ecosystems Supported
(skywalking-website) branch master updated: Adjust ebpf agent responsibility
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 24b6e43dbb6 Adjust ebpf agent responsibility 24b6e43dbb6 is described below commit 24b6e43dbb6e572e60cba6f4cf12fc9a6e299715 Author: 吴晟 Wu Sheng AuthorDate: Sun Jan 28 09:15:04 2024 +0800 Adjust ebpf agent responsibility --- content/_index.html | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/content/_index.html b/content/_index.html index 781c3535234..81c3e424abb 100644 --- a/content/_index.html +++ b/content/_index.html @@ -69,8 +69,7 @@ linkTitle = "Apache SkyWalking" eBPF early adoption -Rover agent works as metrics collector and profiler powered by eBPF to diagnose CPU and network -performance. +Rover agent works as a monitor and profiler powered by eBPF to monitor network traffic and diagnose CPU and network performance.
Re: [PR] Support rocketmq monitoring [skywalking]
wu-sheng commented on code in PR #11758: URL: https://github.com/apache/skywalking/pull/11758#discussion_r1468698482 ## test/e2e-v2/cases/rocketmq/docker-compose.yml: ## @@ -0,0 +1,117 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +version: "3" + +services: + oap: +extends: + file: ../../script/docker-compose/base-compose.yml + service: oap +ports: + - "12800:12800" +networks: + - e2e + + rocketmq-namesrv-1: +image: apache/rocketmq:4.9.4 +hostname: rocketmq-namesrv-1 +ports: + - "9876:9876" +environment: + TZ: Asia/Shanghai +command: sh mqnamesrv +healthcheck: + test: [ "CMD", "nc", "-nz", "127.0.0.1", "9876" ] + interval: 15s + timeout: 10s + retries: 120 +networks: + - e2e + + rocketmq-broker-1: +image: apache/rocketmq:4.9.4 +hostname: rocketmq-broker-1 +ports: + - "10911:10911" + - "10909:10909" +environment: + TZ: Asia/Shanghai + NAMESRV_ADDR: "rocketmq-namesrv-1:9876" +command: sh mqbroker +healthcheck: + test: [ "CMD", "nc", "-nz", "127.0.0.1", "10911" ] + interval: 15s + timeout: 10s + retries: 120 +depends_on: + rocketmq-namesrv-1: +condition: service_healthy +networks: + - e2e + + rocketmq-producer-perf-test: +image: apache/rocketmq:4.9.4 +hostname: rocketmq-producer-perf-test +environment: + TZ: Asia/Shanghai + NAMESRV_ADDR: "rocketmq-namesrv-1:9876" +command: sh tools.sh org.apache.rocketmq.example.quickstart.Producer +depends_on: + rocketmq-broker-1: +condition: service_healthy +networks: + - e2e + + rocketmq-consumer-perf-test: +image: apache/rocketmq:4.9.4 +hostname: rocketmq-consumer-perf-test +environment: + TZ: Asia/Shanghai + NAMESRV_ADDR: "rocketmq-namesrv-1:9876" +command: sh tools.sh org.apache.rocketmq.example.quickstart.Consumer +depends_on: + - rocketmq-producer-perf-test +networks: + - e2e + + rocketmq-exporter: +image: apache/rocketmq-exporter:0.0.2-SNAPSHOT +hostname: rocketmq-exporter +ports: + - "5557:5557" +environment: + TZ: Asia/Shanghai + rocketmq.config.namesrvAddr: "rocketmq-namesrv-1:9876" +depends_on: + - rocketmq-consumer-perf-test +networks: + - e2e + + otel-collector: +image: otel/opentelemetry-collector:0.92.0 Review Comment: Please adopt the variable added through https://github.com/apache/skywalking/pull/11819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch master updated: Upgrade otel collector version in tests to 0.92 (#11819)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 994ba562f8 Upgrade otel collector version in tests to 0.92 (#11819)
994ba562f8 is described below
commit 994ba562f8dc266df103c0fb15e9d5b2dab09f01
Author: peachisai <2581009...@qq.com>
AuthorDate: Sat Jan 27 23:06:45 2024 +0800
Upgrade otel collector version in tests to 0.92 (#11819)
---
.github/workflows/skywalking.yaml | 2 ++
docs/en/changes/changes.md | 1 +
test/e2e-v2/cases/apisix/otel-collector/docker-compose.yml | 2 +-
test/e2e-v2/cases/elasticsearch/docker-compose.yml | 2 +-
test/e2e-v2/cases/kafka/kafka-monitoring/docker-compose.yml | 2 +-
test/e2e-v2/cases/kafka/kafka-monitoring/otel-collector-config.yaml | 2 +-
test/e2e-v2/cases/mariadb/mariadb-slowsql/docker-compose.yaml | 2 +-
test/e2e-v2/cases/mongodb/docker-compose.yml| 2 +-
test/e2e-v2/cases/mysql/mysql-slowsql/docker-compose.yaml | 2 +-
test/e2e-v2/cases/nginx/docker-compose.yml | 2 +-
test/e2e-v2/cases/postgresql/postgres-exporter/docker-compose.yml | 2 +-
test/e2e-v2/cases/pulsar/docker-compose.yml | 2 +-
test/e2e-v2/cases/rabbitmq/docker-compose.yml | 2 +-
test/e2e-v2/cases/redis/redis-exporter/docker-compose.yml | 2 +-
test/e2e-v2/cases/so11y/docker-compose.yml | 2 +-
test/e2e-v2/cases/so11y/otel-collector-config.yaml | 2 +-
test/e2e-v2/cases/vm/prometheus-node-exporter/docker-compose.yml| 2 +-
17 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/.github/workflows/skywalking.yaml
b/.github/workflows/skywalking.yaml
index c59e93939d..52d62f79ec 100644
--- a/.github/workflows/skywalking.yaml
+++ b/.github/workflows/skywalking.yaml
@@ -331,6 +331,8 @@ jobs:
needs: [docker]
runs-on: ${{ matrix.test.runs-on || 'ubuntu-latest' }}
timeout-minutes: 60
+env:
+ OTEL_COLLECTOR_VERSION: 0.92.0
strategy:
fail-fast: false
matrix:
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index 0d7f14ceea..98d09b5e62 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -3,6 +3,7 @@
Project
* Support Java 21 runtime.
* Support oap-java21 image for Java 21 runtime.
+* Upgrade `OTEL collector` version to `0.92.0` in all e2e tests.
OAP Server
diff --git a/test/e2e-v2/cases/apisix/otel-collector/docker-compose.yml
b/test/e2e-v2/cases/apisix/otel-collector/docker-compose.yml
index 8bb5c54794..908a827938 100644
--- a/test/e2e-v2/cases/apisix/otel-collector/docker-compose.yml
+++ b/test/e2e-v2/cases/apisix/otel-collector/docker-compose.yml
@@ -25,7 +25,7 @@ services:
networks:
e2e:
otel-collector:
-image: otel/opentelemetry-collector:0.50.0
+image: otel/opentelemetry-collector:${OTEL_COLLECTOR_VERSION}
command: [ "--config=/etc/otel-collector-config.yaml" ]
volumes:
- ./otel-collector-config.yaml:/etc/otel-collector-config.yaml
diff --git a/test/e2e-v2/cases/elasticsearch/docker-compose.yml
b/test/e2e-v2/cases/elasticsearch/docker-compose.yml
index 4b18f201b8..e44b801c72 100644
--- a/test/e2e-v2/cases/elasticsearch/docker-compose.yml
+++ b/test/e2e-v2/cases/elasticsearch/docker-compose.yml
@@ -68,7 +68,7 @@ services:
retries: 120
test: ["CMD", "sh", "-c", "nc -vz localhost 9114"]
otel-collector:
-image: otel/opentelemetry-collector:0.72.0
+image: otel/opentelemetry-collector:${OTEL_COLLECTOR_VERSION}
networks:
- e2e
command: [ "--config=/etc/otel-collector-config.yaml" ]
diff --git a/test/e2e-v2/cases/kafka/kafka-monitoring/docker-compose.yml
b/test/e2e-v2/cases/kafka/kafka-monitoring/docker-compose.yml
index f035d37125..b24e4de9a4 100644
--- a/test/e2e-v2/cases/kafka/kafka-monitoring/docker-compose.yml
+++ b/test/e2e-v2/cases/kafka/kafka-monitoring/docker-compose.yml
@@ -107,7 +107,7 @@ services:
kafka-consumer-perf-test.sh --broker-list broker1:9092,broker2:9093
--topic perftest --messages 10
otel-collector:
-image: otel/opentelemetry-collector:0.50.0
+image: otel/opentelemetry-collector:${OTEL_COLLECTOR_VERSION}
networks:
- e2e
command: [ "--config=/etc/otel-collector-config.yaml" ]
diff --git
a/test/e2e-v2/cases/kafka/kafka-monitoring/otel-collector-config.yaml
b/test/e2e-v2/cases/kafka/kafka-monitoring/otel-collector-config.yaml
index 11dd27a1d3..de90eec55f 100644
--- a/test/e2e-v2/cases/kafka/kafka-monitoring/otel-collector-config.yaml
+++ b/test/e2e-v2/cases/kafka/kafka-monitoring/otel-collector-config.yaml
@@ -46,7 +46,7 @@ exporters:
#insecure: true
# Exports
Re: [PR] Upgrade otel collector version [skywalking]
wu-sheng merged PR #11819: URL: https://github.com/apache/skywalking/pull/11819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade otel collector version [skywalking]
peachisai commented on PR #11819: URL: https://github.com/apache/skywalking/pull/11819#issuecomment-1913168420 > So, this fix doesn't release yet? Before ```0.72.0``` version ,the error log level setting is not working,but the collector still can start success. After ```0.72.0``` version, the error log level setting will throw err,which could interrpet the start process.  So it only need edit the e2e test case log setting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade otel collector version [skywalking]
wu-sheng commented on code in PR #11819: URL: https://github.com/apache/skywalking/pull/11819#discussion_r1468484631 ## docs/en/changes/changes.md: ## @@ -36,6 +36,7 @@ - SO11Y_OAP -> K8S_SERVICE - VIRTUAL_DATABASE -> MYSQL - VIRTUAL_DATABASE -> POSTGRESQL +* Upgrade `OTEL collector` version to `0.92.0` in e2e test。 Review Comment: This should be moved into the project section. ```suggestion * Upgrade `OTEL collector` version to `0.92.0` in all e2e tests. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade otel collector version [skywalking]
wu-sheng commented on PR #11819: URL: https://github.com/apache/skywalking/pull/11819#issuecomment-1913167456 Please update OTEL version in the showcase, I hope it could help improve the OTEL collector, which is not that good for dealing with various sources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade otel collector version [skywalking]
wu-sheng commented on PR #11819: URL: https://github.com/apache/skywalking/pull/11819#issuecomment-1913159661 So, this fix doesn't release yet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade otel collector version [skywalking]
peachisai commented on PR #11819: URL: https://github.com/apache/skywalking/pull/11819#issuecomment-1913155747 I believed that this change triggered the fail verify in ```0.72.0``` version   So the error log level setting make the ```OTEL collector``` started fail -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] feat: remove entity info from ".tf"&".tfm" file [skywalking-banyandb]
zesiar0 opened a new pull request, #384: URL: https://github.com/apache/skywalking-banyandb/pull/384 - [x] remove entity from ".tf"&".tfm" file, and find entity in series index -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] [skywalking]
wu-sheng closed issue #11836: [Bug] URL: https://github.com/apache/skywalking/issues/11836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] [skywalking]
wu-sheng commented on issue #11836: URL: https://github.com/apache/skywalking/issues/11836#issuecomment-1913127142 English only on GitHub. Once you changed the codes, you are on your own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] [skywalking]
Jerex-zh opened a new issue, #11836:
URL: https://github.com/apache/skywalking/issues/11836
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
Java Agent (apache/skywalking-java)
### What happened
启动一个程序使用了agent的程序，并使用修改过的skywalking-agent.jar替换agent中的jar包，如果再请求自己的程序，会因为skywalking找不到skywalking-agent.jar中的class，从而报错影响程序运行
2024-01-27 16:03:11.216 [XNIO-1 I/O-7] ERROR TID:N/A io.undertow.request -
UT005071: Undertow request failed HttpServerExchange{ GET /test}
java.lang.NoClassDefFoundError:
org/apache/skywalking/apm/agent/core/context/ContextCarrier
at
org.apache.skywalking.apm.plugin.undertow.v2x.handler.TracingHandler.handleRequest(TracingHandler.java:50)
at io.undertow.server.Connectors.executeRootHandler(Connectors.java:387)
at
io.undertow.server.protocol.http.HttpReadListener.handleEventWithNoRunningRequest(HttpReadListener.java:256)
at
io.undertow.server.protocol.http.HttpReadListener.handleEvent(HttpReadListener.java:136)
at
io.undertow.server.protocol.http.HttpOpenListener.handleEvent(HttpOpenListener.java:162)
at
io.undertow.server.protocol.http.HttpOpenListener.handleEvent(HttpOpenListener.java:100)
at
io.undertow.server.protocol.http.HttpOpenListener.handleEvent(HttpOpenListener.java:57)
at
org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92)
at org.xnio.ChannelListeners$10.handleEvent(ChannelListeners.java:291)
at org.xnio.ChannelListeners$10.handleEvent(ChannelListeners.java:286)
at
org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92)
at
org.xnio.nio.QueuedNioTcpServer2.acceptTask(QueuedNioTcpServer2.java:178)
at org.xnio.nio.WorkerThread.safeRun(WorkerThread.java:612)
at org.xnio.nio.WorkerThread.run(WorkerThread.java:479)
Caused by: java.lang.ClassNotFoundException: Can't find
org.apache.skywalking.apm.agent.core.context.ContextCarrier
at
org.apache.skywalking.apm.agent.core.plugin.loader.AgentClassLoader.findClass(AgentClassLoader.java:117)
at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
... 14 common frames omitted
### What you expected to happen
是否可以对文件进行锁定，从而更明显的提醒用户在程序运行时不建议替换skywalking-agent.jar
### How to reproduce
启动使用agent的程序之后，使用修改过的skywalking-agent.jar替换skywalking-agent.jar,然后请求自己的程序
### Anything else
_No response_
### Are you willing to submit a pull request to fix on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
notifications-unsubscr...@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(skywalking-website) branch asf-site updated: deploy: 36e95a79b92c35a7afd6cfcb413abc1f12f62e4c
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 61a7d8b0177 deploy: 36e95a79b92c35a7afd6cfcb413abc1f12f62e4c
61a7d8b0177 is described below
commit 61a7d8b01773cbf8a4cdc49ad329370dc832010f
Author: wu-sheng
AuthorDate: Sat Jan 27 10:04:37 2024 +
deploy: 36e95a79b92c35a7afd6cfcb413abc1f12f62e4c
---
contributors/index.html | 2 +-
index.json | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contributors/index.html b/contributors/index.html
index 852e1ccd21b..2cb049d5a7f 100644
--- a/contributors/index.html
+++ b/contributors/index.html
@@ -556,7 +556,7 @@
-132
+131
2
diff --git a/index.json b/index.json
index a95f2f517b7..9d4369e9046 100644
--- a/index.json
+++ b/index.json
@@ -1 +1 @@
-[{"body":"","excerpt":"","ref":"/tags/nginx/","title":"Nginx"},{"body":"背景介绍 在
Scala 中，纯函数式中主要使用 Fiber，而不是线程，诸如 Cats-Effect、ZIO 等 Effect 框架。 您可以将 Fiber
视为轻量级线程，它是一种并发模型，由框架本身掌控控制权，从而消除了上下文切换的开销。 基于这些 Effect 框架开发的 HTTP、gRCP、GraphQL
库而开发的应用，我们一般称为 纯函数式应用程序。\n我们以 ZIO 为切入点， 演示 SkyWalking Scala 如何支持 Effect
生态。\nZIO Trace 首先，我们想要实现 Fiber 上下文传递，而不是监控 Fiber 本身。对于一个大型应用来说，可能存在成千上万个
Fiber，监控 Fiber 本身的意义不大。\n虽然 Fiber 的 Span 是在活跃时才会创建，但难免会有目前遗漏的场景，所以提供了一个配置
plugin.ziov2.ignore_fiber_regexes。 它将使用正则去 [...]
\ No newline at end of file
+[{"body":"","excerpt":"","ref":"/tags/nginx/","title":"Nginx"},{"body":"背景介绍 在
Scala 中，纯函数式中主要使用 Fiber，而不是线程，诸如 Cats-Effect、ZIO 等 Effect 框架。 您可以将 Fiber
视为轻量级线程，它是一种并发模型，由框架本身掌控控制权，从而消除了上下文切换的开销。 基于这些 Effect 框架开发的 HTTP、gRCP、GraphQL
库而开发的应用，我们一般称为 纯函数式应用程序。\n我们以 ZIO 为切入点， 演示 SkyWalking Scala 如何支持 Effect
生态。\nZIO Trace 首先，我们想要实现 Fiber 上下文传递，而不是监控 Fiber 本身。对于一个大型应用来说，可能存在成千上万个
Fiber，监控 Fiber 本身的意义不大。\n虽然 Fiber 的 Span 是在活跃时才会创建，但难免会有目前遗漏的场景，所以提供了一个配置
plugin.ziov2.ignore_fiber_regexes。 它将使用正则去 [...]
\ No newline at end of file
Re: [PR] Ignore letter case while searching for a contributor [skywalking-website]
wu-sheng merged PR #675: URL: https://github.com/apache/skywalking-website/pull/675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch master updated: Ignore letter case while searching for a contributor (#675)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/master by this push:
new 36e95a79b92 Ignore letter case while searching for a contributor (#675)
36e95a79b92 is described below
commit 36e95a79b92c35a7afd6cfcb413abc1f12f62e4c
Author: Juntao Zhang <719284...@qq.com>
AuthorDate: Sat Jan 27 17:45:27 2024 +0800
Ignore letter case while searching for a contributor (#675)
---
layouts/shortcodes/contributors-search.html | 11 ++-
themes/docsy/layouts/partials/script-search.html | 14 +-
themes/docsy/layouts/partials/script-team.html | 7 +--
3 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/layouts/shortcodes/contributors-search.html
b/layouts/shortcodes/contributors-search.html
index 8d05c514a8c..89008e6a2d8 100644
--- a/layouts/shortcodes/contributors-search.html
+++ b/layouts/shortcodes/contributors-search.html
@@ -22,8 +22,8 @@
{{end}}
-{{.name}}
-
+{{.name}}
+
@@ -31,8 +31,9 @@
{{range $index, $element := .contributors}}
{{$ranking := add $index 1 }}
+{{$lowerCaseLogin := lower .login }}
-
+
{{if eq .type "Anonymous"}}
@@ -45,8 +46,8 @@
{{end}}
-{{.contributions}}
-{{$ranking}}
+{{.contributions}}
+{{$ranking}}
{{end}}
diff --git a/themes/docsy/layouts/partials/script-search.html
b/themes/docsy/layouts/partials/script-search.html
index 6101edcf5ae..9d774d0eac5 100644
--- a/themes/docsy/layouts/partials/script-search.html
+++ b/themes/docsy/layouts/partials/script-search.html
@@ -3,11 +3,16 @@
$(function () {
var params = new URLSearchParams(window.location.search);
var contributor = params.get('contributor');
-var ele = $("." + contributor)
+if(!contributor) {
+ $('.search-tips').text('No data')
+ return;
+}
+var lowerCaseContributor = contributor.toLowerCase();
+var ele = $("." + lowerCaseContributor)
if (ele.length > 0) {
- const contributor = ele.first().clone();
- $('.current-contributor').html(contributor);
- $(contributor).fadeIn();
+ var contributorEle = ele.first().clone();
+ $('.current-contributor').html(contributorEle);
+ $(contributorEle).fadeIn();
ele.show().parents('.item-wrapper').addClass('show');
$.each($('.contributors-wrapper .item-wrapper'), (index, item) => {
if (!$(item).hasClass('show')) {
@@ -16,7 +21,6 @@
})
$('.search-tips').hide();
} else {
- $('.head-wrapper').hide()
$('.search-tips').text('No data')
}
})
diff --git a/themes/docsy/layouts/partials/script-team.html
b/themes/docsy/layouts/partials/script-team.html
index e7fe49daf69..5d7a8750b8d 100644
--- a/themes/docsy/layouts/partials/script-team.html
+++ b/themes/docsy/layouts/partials/script-team.html
@@ -20,8 +20,11 @@
$('.modal-wrapper').fadeOut();
});
// search
- var doSearch = function (){
-var contributor = $('#team-contributor-input').val();
+ var doSearch = function () {
+var contributor = $('#team-contributor-input').val().trim();
+if(!contributor) {
+ return;
+}
window.open('/contributors/?contributor=' + contributor, '_blank');
}
$('.team-contributor-search').on('click', doSearch);
Re: [PR] Ignore letter case while searching for a contributor [skywalking-website]
netlify[bot] commented on PR #675: URL: https://github.com/apache/skywalking-website/pull/675#issuecomment-1913096426 ### Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit | cf8a16fd57e248bff9f9e17d2e21b14d039b4445 | | Latest deploy log | https://app.netlify.com/sites/skywalking-website-preview/deploys/65b4cfd767ecc4000852713f | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Ignore letter case while searching for a contributor [skywalking-website]
Jtrust opened a new pull request, #675: URL: https://github.com/apache/skywalking-website/pull/675 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
