Re: [PR] Add unit tests for stream query [skywalking-banyandb]
codecov-commenter commented on PR #387: URL: https://github.com/apache/skywalking-banyandb/pull/387#issuecomment-1925609627 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `147 lines` in your changes are missing coverage. Please review. > Comparison is base [(`a7e483f`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/a7e483f97e9f28feb7cb8530c138403b3b2ab008?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 47.31% compared to head [(`b401013`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 48.40%. > Report is 1 commits behind head on main. | [Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [banyand/measure/query.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL3F1ZXJ5Lmdv) | 2.15% | [91 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [pkg/query/logical/measure/topn\_analyzer.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGtnL3F1ZXJ5L2xvZ2ljYWwvbWVhc3VyZS90b3BuX2FuYWx5emVyLmdv) | 0.00% | [18 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/measure/topn.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL3RvcG4uZ28=) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/measure/write.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL3dyaXRlLmdv) | 0.00% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/stream/block.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9zdHJlYW0vYmxvY2suZ28=) | 80.95% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [pkg/query/logical/measure/topn\_plan\_localscan.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGtnL3F1ZXJ5L2xvZ2ljYWwvbWVhc3VyZS90b3BuX3BsYW5fbG9jYWxzY2FuLmdv) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/stream/write.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9zdHJlYW0vd3JpdGUuZ28=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@Coverage Diff @@ ## main #387 +/- ## == + Coverage 47.31% 48.40% +1.09% == Files 172 172 Lines 2125021398 +148 == + Hits1005410358 +304 + Misses 1035610169 -187 - Partials 840 871 +31 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/387?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it
[PR] Add unit tests for stream query [skywalking-banyandb]
ButterBright opened a new pull request, #387: URL: https://github.com/apache/skywalking-banyandb/pull/387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent randomly occupies some ports during runtime. [skywalking]
wu-sheng closed issue #11868: [Bug] skywalking agent randomly occupies some ports during runtime. URL: https://github.com/apache/skywalking/issues/11868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent randomly occupies some ports during runtime. [skywalking]
wu-sheng commented on issue #11868: URL: https://github.com/apache/skywalking/issues/11868#issuecomment-1925569584 Any outbound rpc will use a random port. That is how rpc works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] skywalking agent randomly occupies some ports during runtime. [skywalking]
kamyuk opened a new issue, #11868: URL: https://github.com/apache/skywalking/issues/11868 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component Java Agent (apache/skywalking-java) ### What happened In my configuration file, there is no setting for ports 50990, 50991, and 50992. However, during runtime, I observed that SkyWalking is occupying these three ports. As a result, other services configured to use these ports are unable to start. ### What you expected to happen to fix the port setting ### How to reproduce check the TCP port occupancy ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] get entity value from series index when query stream data [skywalking-banyandb]
codecov-commenter commented on PR #386: URL: https://github.com/apache/skywalking-banyandb/pull/386#issuecomment-1925446058 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `246 lines` in your changes are missing coverage. Please review. > Comparison is base [(`a7e483f`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/a7e483f97e9f28feb7cb8530c138403b3b2ab008?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 47.31% compared to head [(`c1ae510`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 46.86%. > Report is 1 commits behind head on main. | [Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [banyand/stream/query.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9zdHJlYW0vcXVlcnkuZ28=) | 0.00% | [122 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/measure/query.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL3F1ZXJ5Lmdv) | 3.44% | [56 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [pkg/query/logical/measure/topn\_analyzer.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGtnL3F1ZXJ5L2xvZ2ljYWwvbWVhc3VyZS90b3BuX2FuYWx5emVyLmdv) | 0.00% | [18 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/measure/topn.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL3RvcG4uZ28=) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/measure/write.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL3dyaXRlLmdv) | 0.00% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/stream/write.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9zdHJlYW0vd3JpdGUuZ28=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/stream/part.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9zdHJlYW0vcGFydC5nbw==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/stream/tstable.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9zdHJlYW0vdHN0YWJsZS5nbw==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/stream/iter.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9zdHJlYW0vaXRlci5nbw==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/386?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | |
[PR] get entity value from series index when query stream data [skywalking-banyandb]
zesiar0 opened a new pull request, #386: URL: https://github.com/apache/skywalking-banyandb/pull/386 - [x] correct encode tag value method - [x] when query stream data, get entity value from series index -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support rocketmq monitoring [skywalking]
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1925314384 OK, thanks for the update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support rocketmq monitoring [skywalking]
peachisai commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1925311580 > Is RocketMQ community ready for image? They will release in Feb ,But it would be after the Spring Festival -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support rocketmq monitoring [skywalking]
wu-sheng commented on PR #11758: URL: https://github.com/apache/skywalking/pull/11758#issuecomment-1925251442 Is RocketMQ community ready for image? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
