Re: [I] [Bug, Vulnerability] CVE-2023-48795 [skywalking]
heyanlong commented on issue #11936: URL: https://github.com/apache/skywalking/issues/11936#issuecomment-1965942725 I see `eclipse-temurin:11-jre` is built based on `ubuntu:22.04`, using OpenSSH 8.9 as default ssh in `ubuntu:22.04` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch remove-cli deleted (was 92d8fd8621)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch remove-cli in repository https://gitbox.apache.org/repos/asf/skywalking.git was 92d8fd8621 Remove CLI(`swctl`) from the image. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(skywalking) branch master updated: Remove CLI(`swctl`) from the image. (#11940)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new a65a6e0ff2 Remove CLI(`swctl`) from the image. (#11940)
a65a6e0ff2 is described below
commit a65a6e0ff2ef9c716131b36172399076307c35f1
Author: 吴晟 Wu Sheng
AuthorDate: Tue Feb 27 14:57:57 2024 +0800
Remove CLI(`swctl`) from the image. (#11940)
---
Makefile | 3 +--
docker/README.md | 5 -
docker/data-generator/Dockerfile | 6 --
docker/oap/Dockerfile| 6 --
docs/en/changes/changes.md | 2 ++
5 files changed, 3 insertions(+), 19 deletions(-)
diff --git a/Makefile b/Makefile
index 9d6dc02fcc..0c0730a166 100644
--- a/Makefile
+++ b/Makefile
@@ -20,7 +20,6 @@ SW_ROOT := $(shell dirname $(realpath $(lastword
$(MAKEFILE_LIST
CONTEXT ?= ${SW_ROOT}/dist
SKIP_TEST ?= false
DIST ?= apache-skywalking-apm-bin.tar.gz
-CLI_VERSION ?= 0.12.0 # CLI version inside OAP image should always use an
Apache released artifact.
init:
cd $(SW_ROOT) && git submodule update --init --recursive
@@ -54,7 +53,7 @@ ifneq ($(SW_OAP_BASE_IMAGE),)
BUILD_ARGS := $(BUILD_ARGS) --build-arg BASE_IMAGE=$(SW_OAP_BASE_IMAGE)
endif
-BUILD_ARGS := $(BUILD_ARGS) --build-arg DIST=$(DIST) --build-arg
SKYWALKING_CLI_VERSION=$(CLI_VERSION)
+BUILD_ARGS := $(BUILD_ARGS) --build-arg DIST=$(DIST)
%.ui: NAME = $(UI_NAME)
%.oap: NAME = $(OAP_NAME)
diff --git a/docker/README.md b/docker/README.md
index 2632d2a5c6..0070b1574d 100644
--- a/docker/README.md
+++ b/docker/README.md
@@ -40,11 +40,6 @@ apache-skywalking-apm-bin.tar.gz
The distribution tar ball name, for example,
`apache-skywalking-apm-bin.tar.gz`.
-### `CLI_VERSION`
-
-The [SkyWalking CLI](http://github.com/apache/skywalking-cli) version to be
included in the OAP image, it must be an
-official Apache release version.
-
### `HUB`
The hub of docker image. The default value is `skywalking`.
diff --git a/docker/data-generator/Dockerfile b/docker/data-generator/Dockerfile
index aa0d14ab40..b4072c746d 100644
--- a/docker/data-generator/Dockerfile
+++ b/docker/data-generator/Dockerfile
@@ -16,10 +16,6 @@
ARG BASE_IMAGE='eclipse-temurin:11-jre'
-ARG SKYWALKING_CLI_VERSION
-
-FROM apache/skywalking-cli:$SKYWALKING_CLI_VERSION as cli
-
FROM $BASE_IMAGE
ENV SKYWALKING_HOME=/skywalking
@@ -43,8 +39,6 @@ RUN set -ex; \
rm -rf "agent"; \
mkdir "bin";
-COPY --from=cli /swctl ./bin
-
COPY log4j2.xml config/
COPY docker-entrypoint.sh .
diff --git a/docker/oap/Dockerfile b/docker/oap/Dockerfile
index aa0d14ab40..b4072c746d 100644
--- a/docker/oap/Dockerfile
+++ b/docker/oap/Dockerfile
@@ -16,10 +16,6 @@
ARG BASE_IMAGE='eclipse-temurin:11-jre'
-ARG SKYWALKING_CLI_VERSION
-
-FROM apache/skywalking-cli:$SKYWALKING_CLI_VERSION as cli
-
FROM $BASE_IMAGE
ENV SKYWALKING_HOME=/skywalking
@@ -43,8 +39,6 @@ RUN set -ex; \
rm -rf "agent"; \
mkdir "bin";
-COPY --from=cli /swctl ./bin
-
COPY log4j2.xml config/
COPY docker-entrypoint.sh .
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index b63cb7ef03..f794e66a59 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -6,6 +6,8 @@
* Upgrade `OTEL collector` version to `0.92.0` in all e2e tests.
* Switch CI macOS runner to m1.
* Upgrade PostgreSQL driver to `42.4.4` to fix CVE-2024-1597.
+* Remove CLI(`swctl`) from the image.
+* Remove CLI_VERSION variable from Makefile build.
OAP Server
Re: [PR] Remove CLI(`swctl`) from the image. [skywalking]
wu-sheng merged PR #11940: URL: https://github.com/apache/skywalking/pull/11940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Feature] Add hierarchy to Pulsar monitoring [skywalking]
CodePrometheus opened a new issue, #11941: URL: https://github.com/apache/skywalking/issues/11941 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description We have Pulsar server monitoring and agent plugins(such as Java) for Pulsar, we could consider add hierarchy support for Pulsar. ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [X] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug, Vulnerability] CVE-2023-48795 [skywalking]
wu-sheng commented on issue #11936: URL: https://github.com/apache/skywalking/issues/11936#issuecomment-1965877497 Yes, I noticed that. I am not sure why UI could have this, maybe it is from default base Linux image? CLI has the version impact but maybe not the only source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug, Vulnerability] CVE-2023-48795 [skywalking]
kezhenxu94 commented on issue #11936: URL: https://github.com/apache/skywalking/issues/11936#issuecomment-1965876274 If the UI also has the CVE, then swctl might not be the only source of the CVE, as UI doesn't have swctl in it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] Add Pulsar monitoring to the showcase [skywalking]
wu-sheng commented on issue #11939: URL: https://github.com/apache/skywalking/issues/11939#issuecomment-1965873920 I think Pulsar hierarchy detection is not added too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Remove CLI(`swctl`) from the image. [skywalking]
wu-sheng opened a new pull request, #11940: URL: https://github.com/apache/skywalking/pull/11940 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes https://github.com/apache/skywalking/issues/11936. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). [CLI](https://github.com/apache/skywalking-cli/) is useful and released as schedule, but as SSH relative codes are included, sometimes, image CVE scanning could trigger a red alarm due to SSH CVEs. This could scare users, but OAP is actually safe. To avoid confusing, if users need CLI, they could download from https://skywalking.apache.org/docs/#SkyWalkingCLI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Feature] Add Pulsar monitoring to the showcase [skywalking]
CodePrometheus opened a new issue, #11939: URL: https://github.com/apache/skywalking/issues/11939 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description We could consider adding pulsar in showcase. ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [X] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) 01/01: Remove CLI(`swctl`) from the image.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch remove-cli
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 92d8fd8621984e69957813bb5ae8cf0bc3795eb3
Author: Wu Sheng
AuthorDate: Tue Feb 27 14:26:37 2024 +0800
Remove CLI(`swctl`) from the image.
---
Makefile | 3 +--
docker/README.md | 5 -
docker/data-generator/Dockerfile | 6 --
docker/oap/Dockerfile| 6 --
docs/en/changes/changes.md | 2 ++
5 files changed, 3 insertions(+), 19 deletions(-)
diff --git a/Makefile b/Makefile
index 9d6dc02fcc..0c0730a166 100644
--- a/Makefile
+++ b/Makefile
@@ -20,7 +20,6 @@ SW_ROOT := $(shell dirname $(realpath $(lastword
$(MAKEFILE_LIST
CONTEXT ?= ${SW_ROOT}/dist
SKIP_TEST ?= false
DIST ?= apache-skywalking-apm-bin.tar.gz
-CLI_VERSION ?= 0.12.0 # CLI version inside OAP image should always use an
Apache released artifact.
init:
cd $(SW_ROOT) && git submodule update --init --recursive
@@ -54,7 +53,7 @@ ifneq ($(SW_OAP_BASE_IMAGE),)
BUILD_ARGS := $(BUILD_ARGS) --build-arg BASE_IMAGE=$(SW_OAP_BASE_IMAGE)
endif
-BUILD_ARGS := $(BUILD_ARGS) --build-arg DIST=$(DIST) --build-arg
SKYWALKING_CLI_VERSION=$(CLI_VERSION)
+BUILD_ARGS := $(BUILD_ARGS) --build-arg DIST=$(DIST)
%.ui: NAME = $(UI_NAME)
%.oap: NAME = $(OAP_NAME)
diff --git a/docker/README.md b/docker/README.md
index 2632d2a5c6..0070b1574d 100644
--- a/docker/README.md
+++ b/docker/README.md
@@ -40,11 +40,6 @@ apache-skywalking-apm-bin.tar.gz
The distribution tar ball name, for example,
`apache-skywalking-apm-bin.tar.gz`.
-### `CLI_VERSION`
-
-The [SkyWalking CLI](http://github.com/apache/skywalking-cli) version to be
included in the OAP image, it must be an
-official Apache release version.
-
### `HUB`
The hub of docker image. The default value is `skywalking`.
diff --git a/docker/data-generator/Dockerfile b/docker/data-generator/Dockerfile
index aa0d14ab40..b4072c746d 100644
--- a/docker/data-generator/Dockerfile
+++ b/docker/data-generator/Dockerfile
@@ -16,10 +16,6 @@
ARG BASE_IMAGE='eclipse-temurin:11-jre'
-ARG SKYWALKING_CLI_VERSION
-
-FROM apache/skywalking-cli:$SKYWALKING_CLI_VERSION as cli
-
FROM $BASE_IMAGE
ENV SKYWALKING_HOME=/skywalking
@@ -43,8 +39,6 @@ RUN set -ex; \
rm -rf "agent"; \
mkdir "bin";
-COPY --from=cli /swctl ./bin
-
COPY log4j2.xml config/
COPY docker-entrypoint.sh .
diff --git a/docker/oap/Dockerfile b/docker/oap/Dockerfile
index aa0d14ab40..b4072c746d 100644
--- a/docker/oap/Dockerfile
+++ b/docker/oap/Dockerfile
@@ -16,10 +16,6 @@
ARG BASE_IMAGE='eclipse-temurin:11-jre'
-ARG SKYWALKING_CLI_VERSION
-
-FROM apache/skywalking-cli:$SKYWALKING_CLI_VERSION as cli
-
FROM $BASE_IMAGE
ENV SKYWALKING_HOME=/skywalking
@@ -43,8 +39,6 @@ RUN set -ex; \
rm -rf "agent"; \
mkdir "bin";
-COPY --from=cli /swctl ./bin
-
COPY log4j2.xml config/
COPY docker-entrypoint.sh .
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index b63cb7ef03..f794e66a59 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -6,6 +6,8 @@
* Upgrade `OTEL collector` version to `0.92.0` in all e2e tests.
* Switch CI macOS runner to m1.
* Upgrade PostgreSQL driver to `42.4.4` to fix CVE-2024-1597.
+* Remove CLI(`swctl`) from the image.
+* Remove CLI_VERSION variable from Makefile build.
OAP Server
(skywalking) branch remove-cli created (now 92d8fd8621)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch remove-cli in repository https://gitbox.apache.org/repos/asf/skywalking.git at 92d8fd8621 Remove CLI(`swctl`) from the image. This branch includes the following new commits: new 92d8fd8621 Remove CLI(`swctl`) from the image. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(skywalking) branch master updated: Add hierarchy for RabbitMQ (#11935)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new eb071e49df Add hierarchy for RabbitMQ (#11935)
eb071e49df is described below
commit eb071e49df3c9e0cc8c997366746ae2199f32d8f
Author: peachisai <2581009...@qq.com>
AuthorDate: Tue Feb 27 12:18:36 2024 +0800
Add hierarchy for RabbitMQ (#11935)
Co-authored-by: 邵一鸣
Co-authored-by: Wan Kai
---
docs/en/changes/changes.md | 3 +++
docs/en/concepts-and-designs/service-hierarchy.md | 20 +++-
.../src/main/resources/hierarchy-definition.yml| 5
.../rabbitmq/rabbitmq-cluster.json | 27 +-
4 files changed, 53 insertions(+), 2 deletions(-)
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index 1d4b77f512..b63cb7ef03 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -58,6 +58,9 @@
* Add `maxInboundMessageSize (SW_DCS_MAX_INBOUND_MESSAGE_SIZE)` configuration
to change the max inbound message size of DCS.
* Fix Service Layer when building Events in the EventHookCallback.
* Add Golang as a supported language for Pulsar.
+* Add Service Hierarchy auto matching layer relationships (upper -> lower) as
following:
+ - RABBITMQ -> K8S_SERVICE
+ - VIRTUAL_MQ -> RABBITMQ
UI
diff --git a/docs/en/concepts-and-designs/service-hierarchy.md
b/docs/en/concepts-and-designs/service-hierarchy.md
index 126eed6c60..482985d6c4 100644
--- a/docs/en/concepts-and-designs/service-hierarchy.md
+++ b/docs/en/concepts-and-designs/service-hierarchy.md
@@ -26,7 +26,9 @@ If you want to customize it according to your own needs,
please refer to [Servic
| NGINX| K8S_SERVICE | [NGINX On
K8S_SERVICE](#nginx-on-k8s_service) |
| APISIX | K8S_SERVICE | [APISIX On
K8S_SERVICE](#apisix-on-k8s_service) |
| ROCKETMQ | K8S_SERVICE | [ROCKETMQ On
K8S_SERVICE](#rocketmq-on-k8s_service) |
-| VIRTUAL_MQ | ROCKETMQ| [VIRTUAL_MQ On
K8S_SERVICE](#virtual_mq-on-rocketmq) |
+| VIRTUAL_MQ | ROCKETMQ| [VIRTUAL_MQ On
ROCKETMQ](#virtual_mq-on-rocketmq) |
+| RABBITMQ | K8S_SERVICE | [RABBITMQ On
K8S_SERVICE](#rabbitmq-on-k8s_service) |
+| VIRTUAL_MQ | RABBITMQ| [VIRTUAL_MQ On
RABBITMQ](#virtual_mq-on-rabbitmq) |
- The following sections will describe the **default matching rules** in
detail and use the `upper-layer On lower-layer` format.
- The example service name are based on SkyWalking
[Showcase](https://github.com/apache/skywalking-showcase) default deployment.
@@ -144,6 +146,22 @@ If you want to customize it according to your own needs,
please refer to [Servic
- VIRTUAL_MQ.service.name:
`rocketmq.skywalking-showcase.svc.cluster.local:9876`
- ROCKETMQ.service.name: `rocketmq::rocketmq.skywalking-showcase`
+ RABBITMQ On K8S_SERVICE
+- Rule name: `short-name`
+- Groovy script: `{ (u, l) -> u.shortName == l.shortName }`
+- Description: RABBITMQ.service.shortName == K8S_SERVICE.service.shortName
+- Matched Example:
+ - RABBITMQ.service.name: `rabbitmq::rabbitmq.skywalking-showcase`
+ - K8S_SERVICE.service.name:
`skywalking-showcase::rabbitmq.skywalking-showcase`
+
+ VIRTUAL_MQ On RABBITMQ
+- Rule name: `lower-short-name-with-fqdn`
+- Groovy script: `{ (u, l) -> u.shortName.substring(0,
u.shortName.lastIndexOf(':')) == l.shortName.concat('.svc.cluster.local') }`
+- Description: VIRTUAL_MQ.service.shortName remove port ==
RABBITMQ.service.shortName with fqdn suffix
+- Matched Example:
+ - VIRTUAL_MQ.service.name:
`rabbitmq.skywalking-showcase.svc.cluster.local:5672`
+ - RABBITMQ.service.name: `rabbitmq::rabbitmq.skywalking-showcase`
+
### Build Through Specific Agents
Use agent tech involved(such as eBPF) and deployment tools(such as operator
and agent injector) detect the service hierarchy relations.
diff --git
a/oap-server/server-starter/src/main/resources/hierarchy-definition.yml
b/oap-server/server-starter/src/main/resources/hierarchy-definition.yml
index f1d53cbb91..fa688a13f2 100644
--- a/oap-server/server-starter/src/main/resources/hierarchy-definition.yml
+++ b/oap-server/server-starter/src/main/resources/hierarchy-definition.yml
@@ -48,12 +48,16 @@ hierarchy:
ROCKETMQ:
K8S_SERVICE: short-name
+ RABBITMQ:
+K8S_SERVICE: short-name
+
VIRTUAL_DATABASE:
MYSQL: lower-short-name-with-fqdn
POSTGRESQL: lower-short-name-with-fqdn
VIRTUAL_MQ:
ROCKETMQ: lower-short-name-with-fqdn
+RABBITMQ: lower-short-name-with-fqdn
# Use Groovy script to define the matching rules, the input parameters are the
upper service(u) and the lower service(l) and the return value is a boolean,
# which are used to
Re: [I] [Feature] Add hierarchy for RabbitMQ layer [skywalking]
wu-sheng closed issue #11926: [Feature] Add hierarchy for RabbitMQ layer URL: https://github.com/apache/skywalking/issues/11926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
wu-sheng merged PR #11935: URL: https://github.com/apache/skywalking/pull/11935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-cli) branch CVE-2023-48795 deleted (was 268fecd)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch CVE-2023-48795 in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git was 268fecd Upgrade crypto lib to fix CVE-2023-48795 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Upgrade crypto lib to fix CVE-2023-48795 [skywalking-cli]
wu-sheng merged PR #199: URL: https://github.com/apache/skywalking-cli/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-cli) branch master updated: Upgrade crypto lib to fix CVE-2023-48795 (#199)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git The following commit(s) were added to refs/heads/master by this push: new 7ca73b9 Upgrade crypto lib to fix CVE-2023-48795 (#199) 7ca73b9 is described below commit 7ca73b92918ca71c165c459805ad2597d203a280 Author: mrproliu <741550...@qq.com> AuthorDate: Tue Feb 27 11:56:44 2024 +0800 Upgrade crypto lib to fix CVE-2023-48795 (#199) --- CHANGES.md | 1 + dist/LICENSE | 10 +- go.mod | 12 +--- go.sum | 20 4 files changed, 23 insertions(+), 20 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 5285fb0..594972b 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -8,6 +8,7 @@ Release Notes. ### Features * Add the sub-command `dependency global` for adapt the global dependency query API by @mrproliu in https://github.com/apache/skywalking-cli/pull/198 +* Upgrade crypto lib to fix cve by @mrproliu in https://github.com/apache/skywalking-cli/pull/199 ### Bug Fixes diff --git a/dist/LICENSE b/dist/LICENSE index ce50912..2229975 100644 --- a/dist/LICENSE +++ b/dist/LICENSE @@ -243,12 +243,12 @@ The text of each license is also included at licenses/license-[project].txt. github.com/google/uuid v1.3.0 BSD-3-Clause github.com/imdario/mergo v0.3.12 BSD-3-Clause github.com/spf13/pflag v1.0.5 BSD-3-Clause -golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4 BSD-3-Clause -golang.org/x/net v0.6.0 BSD-3-Clause +golang.org/x/crypto v0.20.0 BSD-3-Clause +golang.org/x/net v0.21.0 BSD-3-Clause golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d BSD-3-Clause -golang.org/x/sys v0.5.0 BSD-3-Clause -golang.org/x/term v0.5.0 BSD-3-Clause -golang.org/x/text v0.7.0 BSD-3-Clause +golang.org/x/sys v0.17.0 BSD-3-Clause +golang.org/x/term v0.17.0 BSD-3-Clause +golang.org/x/text v0.14.0 BSD-3-Clause golang.org/x/time v0.0.0-20210723032227-1f47c861a9ac BSD-3-Clause google.golang.org/protobuf v1.31.0 BSD-3-Clause gopkg.in/inf.v0 v0.9.1 BSD-3-Clause diff --git a/go.mod b/go.mod index 3f68135..67dff75 100644 --- a/go.mod +++ b/go.mod @@ -2,8 +2,6 @@ module github.com/apache/skywalking-cli go 1.18 -replace golang.org/x/crypto v0.0.0-20201002170205-7f63de1d35b0 => golang.org/x/crypto v0.0.0-20201216223049-8b5274cf687f - require ( github.com/apache/skywalking-swck/operator v0.0.0-20220815142653-ed08076b7433 github.com/gizak/termui/v3 v3.1.0 @@ -15,7 +13,7 @@ require ( github.com/sirupsen/logrus v1.8.1 github.com/spf13/viper v1.7.0 github.com/urfave/cli/v2 v2.3.0 - golang.org/x/text v0.7.0 + golang.org/x/text v0.14.0 google.golang.org/grpc v1.40.0 gopkg.in/yaml.v2 v2.4.0 k8s.io/apimachinery v0.22.1 @@ -68,11 +66,11 @@ require ( github.com/spf13/jwalterweatherman v1.0.0 // indirect github.com/spf13/pflag v1.0.5 // indirect github.com/subosito/gotenv v1.2.0 // indirect - golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4 // indirect - golang.org/x/net v0.6.0 // indirect + golang.org/x/crypto v0.20.0 // indirect + golang.org/x/net v0.21.0 // indirect golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d // indirect - golang.org/x/sys v0.5.0 // indirect - golang.org/x/term v0.5.0 // indirect + golang.org/x/sys v0.17.0 // indirect + golang.org/x/term v0.17.0 // indirect golang.org/x/time v0.0.0-20210723032227-1f47c861a9ac // indirect gomodules.xyz/jsonpatch/v2 v2.2.0 // indirect google.golang.org/appengine v1.6.7 // indirect diff --git a/go.sum b/go.sum index 0d8456a..94929a3 100644 --- a/go.sum +++ b/go.sum @@ -502,11 +502,11 @@ golang.org/x/crypto v0.0.0-20190605123033-f99c8df09eb5/go.mod h1:yigFU9vqHzYiE8U golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI= golang.org/x/crypto v0.0.0-20200414173820-0848c9571904/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= -golang.org/x/crypto v0.0.0-20201216223049-8b5274cf687f/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I= +golang.org/x/crypto v0.0.0-20201002170205-7f63de1d35b0/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= golang.org/x/crypto v0.0.0-20210220033148-5ea612d1eb83/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I= golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc= -golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4 h1:kUhD7nTDoI3fVd9G4ORWrbV5NY0liEs/Jg2pv5f+bBA= -golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4= +golang.org/x/crypto v0.20.0
Re: [I] [Bug, Vulnerability] CVE-2023-48795 [skywalking]
wu-sheng commented on issue #11936: URL: https://github.com/apache/skywalking/issues/11936#issuecomment-1965741785 CLI fixed at https://github.com/apache/skywalking-cli/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade crypto lib to fix CVE-2023-48795 [skywalking-cli]
codecov-commenter commented on PR #199: URL: https://github.com/apache/skywalking-cli/pull/199#issuecomment-1965736776 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-cli/pull/199?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 26.13%. Comparing base [(`d5f3597`)](https://app.codecov.io/gh/apache/skywalking-cli/commit/d5f3597733aa5217373986d776a3ee5ee8b3c468?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`31ee21e`)](https://app.codecov.io/gh/apache/skywalking-cli/pull/199?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > :exclamation: Current head 31ee21e differs from pull request most recent head 268fecd. Consider uploading reports for the commit 268fecd to get more accurate results Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #199 +/- ## === Coverage 26.13% 26.13% === Files 22 22 Lines 463 463 === Hits 121 121 Misses330 330 Partials 12 12 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-cli/pull/199?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Upgrade crypto lib to fix CVE-2023-48795 [skywalking-cli]
mrproliu opened a new pull request, #199: URL: https://github.com/apache/skywalking-cli/pull/199 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-cli) 01/01: Upgrade crypto lib to fix CVE-2023-48795
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a commit to branch CVE-2023-48795 in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git commit 268fecda9076ec8884911cb17bdf69d4b846fbf5 Author: mrproliu <741550...@qq.com> AuthorDate: Tue Feb 27 11:38:53 2024 +0800 Upgrade crypto lib to fix CVE-2023-48795 --- CHANGES.md | 1 + dist/LICENSE | 10 +- go.mod | 12 +--- go.sum | 20 4 files changed, 23 insertions(+), 20 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 5285fb0..594972b 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -8,6 +8,7 @@ Release Notes. ### Features * Add the sub-command `dependency global` for adapt the global dependency query API by @mrproliu in https://github.com/apache/skywalking-cli/pull/198 +* Upgrade crypto lib to fix cve by @mrproliu in https://github.com/apache/skywalking-cli/pull/199 ### Bug Fixes diff --git a/dist/LICENSE b/dist/LICENSE index ce50912..2229975 100644 --- a/dist/LICENSE +++ b/dist/LICENSE @@ -243,12 +243,12 @@ The text of each license is also included at licenses/license-[project].txt. github.com/google/uuid v1.3.0 BSD-3-Clause github.com/imdario/mergo v0.3.12 BSD-3-Clause github.com/spf13/pflag v1.0.5 BSD-3-Clause -golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4 BSD-3-Clause -golang.org/x/net v0.6.0 BSD-3-Clause +golang.org/x/crypto v0.20.0 BSD-3-Clause +golang.org/x/net v0.21.0 BSD-3-Clause golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d BSD-3-Clause -golang.org/x/sys v0.5.0 BSD-3-Clause -golang.org/x/term v0.5.0 BSD-3-Clause -golang.org/x/text v0.7.0 BSD-3-Clause +golang.org/x/sys v0.17.0 BSD-3-Clause +golang.org/x/term v0.17.0 BSD-3-Clause +golang.org/x/text v0.14.0 BSD-3-Clause golang.org/x/time v0.0.0-20210723032227-1f47c861a9ac BSD-3-Clause google.golang.org/protobuf v1.31.0 BSD-3-Clause gopkg.in/inf.v0 v0.9.1 BSD-3-Clause diff --git a/go.mod b/go.mod index 3f68135..67dff75 100644 --- a/go.mod +++ b/go.mod @@ -2,8 +2,6 @@ module github.com/apache/skywalking-cli go 1.18 -replace golang.org/x/crypto v0.0.0-20201002170205-7f63de1d35b0 => golang.org/x/crypto v0.0.0-20201216223049-8b5274cf687f - require ( github.com/apache/skywalking-swck/operator v0.0.0-20220815142653-ed08076b7433 github.com/gizak/termui/v3 v3.1.0 @@ -15,7 +13,7 @@ require ( github.com/sirupsen/logrus v1.8.1 github.com/spf13/viper v1.7.0 github.com/urfave/cli/v2 v2.3.0 - golang.org/x/text v0.7.0 + golang.org/x/text v0.14.0 google.golang.org/grpc v1.40.0 gopkg.in/yaml.v2 v2.4.0 k8s.io/apimachinery v0.22.1 @@ -68,11 +66,11 @@ require ( github.com/spf13/jwalterweatherman v1.0.0 // indirect github.com/spf13/pflag v1.0.5 // indirect github.com/subosito/gotenv v1.2.0 // indirect - golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4 // indirect - golang.org/x/net v0.6.0 // indirect + golang.org/x/crypto v0.20.0 // indirect + golang.org/x/net v0.21.0 // indirect golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d // indirect - golang.org/x/sys v0.5.0 // indirect - golang.org/x/term v0.5.0 // indirect + golang.org/x/sys v0.17.0 // indirect + golang.org/x/term v0.17.0 // indirect golang.org/x/time v0.0.0-20210723032227-1f47c861a9ac // indirect gomodules.xyz/jsonpatch/v2 v2.2.0 // indirect google.golang.org/appengine v1.6.7 // indirect diff --git a/go.sum b/go.sum index 0d8456a..94929a3 100644 --- a/go.sum +++ b/go.sum @@ -502,11 +502,11 @@ golang.org/x/crypto v0.0.0-20190605123033-f99c8df09eb5/go.mod h1:yigFU9vqHzYiE8U golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI= golang.org/x/crypto v0.0.0-20200414173820-0848c9571904/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= -golang.org/x/crypto v0.0.0-20201216223049-8b5274cf687f/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I= +golang.org/x/crypto v0.0.0-20201002170205-7f63de1d35b0/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= golang.org/x/crypto v0.0.0-20210220033148-5ea612d1eb83/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I= golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc= -golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4 h1:kUhD7nTDoI3fVd9G4ORWrbV5NY0liEs/Jg2pv5f+bBA= -golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4= +golang.org/x/crypto v0.20.0 h1:jmAMJJZXr5KiCw05dfYK9QnqaqKLYXijU23lsEdcQqg= +golang.org/x/crypto v0.20.0/go.mod h1:Xwo95rrVNIoSMx9wa1JroENMToLWn3RNVrTBpLHgZPQ= golang.org/x/exp
(skywalking-cli) branch CVE-2023-48795 updated (7133628 -> 268fecd)
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to branch CVE-2023-48795 in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git discard 7133628 update go.sum discard 7d9bc22 Upgrade crypto lib to fix CVE-2023-48795 new 268fecd Upgrade crypto lib to fix CVE-2023-48795 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (7133628) \ N -- N -- N refs/heads/CVE-2023-48795 (268fecd) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes:
(skywalking-cli) branch CVE-2023-48795 updated: update go.sum
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a commit to branch CVE-2023-48795 in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git The following commit(s) were added to refs/heads/CVE-2023-48795 by this push: new 7133628 update go.sum 7133628 is described below commit 71336287f8bfaf160b220003bb0badc0e8192dfa Author: mrproliu <741550...@qq.com> AuthorDate: Tue Feb 27 11:44:31 2024 +0800 update go.sum --- dist/LICENSE | 10 +- go.sum | 13 + 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/dist/LICENSE b/dist/LICENSE index ce50912..2229975 100644 --- a/dist/LICENSE +++ b/dist/LICENSE @@ -243,12 +243,12 @@ The text of each license is also included at licenses/license-[project].txt. github.com/google/uuid v1.3.0 BSD-3-Clause github.com/imdario/mergo v0.3.12 BSD-3-Clause github.com/spf13/pflag v1.0.5 BSD-3-Clause -golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4 BSD-3-Clause -golang.org/x/net v0.6.0 BSD-3-Clause +golang.org/x/crypto v0.20.0 BSD-3-Clause +golang.org/x/net v0.21.0 BSD-3-Clause golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d BSD-3-Clause -golang.org/x/sys v0.5.0 BSD-3-Clause -golang.org/x/term v0.5.0 BSD-3-Clause -golang.org/x/text v0.7.0 BSD-3-Clause +golang.org/x/sys v0.17.0 BSD-3-Clause +golang.org/x/term v0.17.0 BSD-3-Clause +golang.org/x/text v0.14.0 BSD-3-Clause golang.org/x/time v0.0.0-20210723032227-1f47c861a9ac BSD-3-Clause google.golang.org/protobuf v1.31.0 BSD-3-Clause gopkg.in/inf.v0 v0.9.1 BSD-3-Clause diff --git a/go.sum b/go.sum index e0e292b..94929a3 100644 --- a/go.sum +++ b/go.sum @@ -503,11 +503,8 @@ golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8U golang.org/x/crypto v0.0.0-20200414173820-0848c9571904/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= golang.org/x/crypto v0.0.0-20201002170205-7f63de1d35b0/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= -golang.org/x/crypto v0.0.0-20201216223049-8b5274cf687f/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I= golang.org/x/crypto v0.0.0-20210220033148-5ea612d1eb83/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I= golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc= -golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4 h1:kUhD7nTDoI3fVd9G4ORWrbV5NY0liEs/Jg2pv5f+bBA= -golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4= golang.org/x/crypto v0.20.0 h1:jmAMJJZXr5KiCw05dfYK9QnqaqKLYXijU23lsEdcQqg= golang.org/x/crypto v0.20.0/go.mod h1:Xwo95rrVNIoSMx9wa1JroENMToLWn3RNVrTBpLHgZPQ= golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA= @@ -579,8 +576,8 @@ golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4/go.mod h1:p54w0d4576C0XHj96b golang.org/x/net v0.0.0-20210428140749-89ef3d95e781/go.mod h1:OJAsFXCWl8Ukc7SiCT/9KSuxbyM7479/AVlXFRxuMCk= golang.org/x/net v0.0.0-20210520170846-37e1c6afe023/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y= golang.org/x/net v0.0.0-20220722155237-a158d28d115b/go.mod h1:XRhObCWvk6IyKnWLug+ECip1KBveYUHfp+8e9klMJ9c= -golang.org/x/net v0.6.0 h1:L4ZwwTvKW9gr0ZMS1yrHD9GZhIuVjOBBnaKH+SPQK0Q= golang.org/x/net v0.6.0/go.mod h1:2Tu9+aMcznHK/AK1HMvgo6xiTLG5rD5rZLDS+rp2Bjs= +golang.org/x/net v0.21.0 h1:AQyQV4dYCvJ7vGmJyKki9+PBdyvhkSd8EIx/qb0AYv4= golang.org/x/net v0.21.0/go.mod h1:bIjVDfnllIU7BJ2DNgfnXvpSvtn8VRwhlsaeUTyUS44= golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U= golang.org/x/oauth2 v0.0.0-20190226205417-e64efc72b421/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw= @@ -649,15 +646,15 @@ golang.org/x/sys v0.0.0-20210616094352-59db8d763f22/go.mod h1:oPkhp1MJrh7nUepCBc golang.org/x/sys v0.0.0-20210817190340-bfb29a6856f2/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= -golang.org/x/sys v0.5.0 h1:MUK/U/4lj1t1oPg0HfuXDN/Z1wv31ZJ/YcPiGccS4DU= golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= +golang.org/x/sys v0.17.0 h1:25cE3gD+tdBA7lp7QfhuV+rJiE9YXTcS3VG1SqssI/Y= golang.org/x/sys v0.17.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA= golang.org/x/term v0.0.0-20201117132131-f5c789dd3221/go.mod h1:Nr5EML6q2oocZ2LXRh80K7BxOlk5/8JxuGnuhpl+muw= golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo= golang.org/x/term v0.0.0-20210220032956-6a3ed077a48d/go.mod
(skywalking-cli) 01/01: Upgrade crypto lib to fix CVE-2023-48795
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a commit to branch CVE-2023-48795 in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git commit 7d9bc22086644c4c1822d8fd26ad8a535bc01574 Author: mrproliu <741550...@qq.com> AuthorDate: Tue Feb 27 11:38:53 2024 +0800 Upgrade crypto lib to fix CVE-2023-48795 --- CHANGES.md | 1 + go.mod | 12 +--- go.sum | 7 +++ 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 5285fb0..594972b 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -8,6 +8,7 @@ Release Notes. ### Features * Add the sub-command `dependency global` for adapt the global dependency query API by @mrproliu in https://github.com/apache/skywalking-cli/pull/198 +* Upgrade crypto lib to fix cve by @mrproliu in https://github.com/apache/skywalking-cli/pull/199 ### Bug Fixes diff --git a/go.mod b/go.mod index 3f68135..67dff75 100644 --- a/go.mod +++ b/go.mod @@ -2,8 +2,6 @@ module github.com/apache/skywalking-cli go 1.18 -replace golang.org/x/crypto v0.0.0-20201002170205-7f63de1d35b0 => golang.org/x/crypto v0.0.0-20201216223049-8b5274cf687f - require ( github.com/apache/skywalking-swck/operator v0.0.0-20220815142653-ed08076b7433 github.com/gizak/termui/v3 v3.1.0 @@ -15,7 +13,7 @@ require ( github.com/sirupsen/logrus v1.8.1 github.com/spf13/viper v1.7.0 github.com/urfave/cli/v2 v2.3.0 - golang.org/x/text v0.7.0 + golang.org/x/text v0.14.0 google.golang.org/grpc v1.40.0 gopkg.in/yaml.v2 v2.4.0 k8s.io/apimachinery v0.22.1 @@ -68,11 +66,11 @@ require ( github.com/spf13/jwalterweatherman v1.0.0 // indirect github.com/spf13/pflag v1.0.5 // indirect github.com/subosito/gotenv v1.2.0 // indirect - golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4 // indirect - golang.org/x/net v0.6.0 // indirect + golang.org/x/crypto v0.20.0 // indirect + golang.org/x/net v0.21.0 // indirect golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d // indirect - golang.org/x/sys v0.5.0 // indirect - golang.org/x/term v0.5.0 // indirect + golang.org/x/sys v0.17.0 // indirect + golang.org/x/term v0.17.0 // indirect golang.org/x/time v0.0.0-20210723032227-1f47c861a9ac // indirect gomodules.xyz/jsonpatch/v2 v2.2.0 // indirect google.golang.org/appengine v1.6.7 // indirect diff --git a/go.sum b/go.sum index 0d8456a..e0e292b 100644 --- a/go.sum +++ b/go.sum @@ -502,11 +502,14 @@ golang.org/x/crypto v0.0.0-20190605123033-f99c8df09eb5/go.mod h1:yigFU9vqHzYiE8U golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI= golang.org/x/crypto v0.0.0-20200414173820-0848c9571904/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= +golang.org/x/crypto v0.0.0-20201002170205-7f63de1d35b0/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= golang.org/x/crypto v0.0.0-20201216223049-8b5274cf687f/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I= golang.org/x/crypto v0.0.0-20210220033148-5ea612d1eb83/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I= golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc= golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4 h1:kUhD7nTDoI3fVd9G4ORWrbV5NY0liEs/Jg2pv5f+bBA= golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4= +golang.org/x/crypto v0.20.0 h1:jmAMJJZXr5KiCw05dfYK9QnqaqKLYXijU23lsEdcQqg= +golang.org/x/crypto v0.20.0/go.mod h1:Xwo95rrVNIoSMx9wa1JroENMToLWn3RNVrTBpLHgZPQ= golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA= golang.org/x/exp v0.0.0-20190306152737-a1d7652674e8/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA= golang.org/x/exp v0.0.0-20190510132918-efd6b22b2522/go.mod h1:ZjyILWgesfNpC6sMxTJOJm9Kp84zZh5NQWvqDGG3Qr8= @@ -578,6 +581,7 @@ golang.org/x/net v0.0.0-20210520170846-37e1c6afe023/go.mod h1:9nx3DQGgdP8bBQD5qx golang.org/x/net v0.0.0-20220722155237-a158d28d115b/go.mod h1:XRhObCWvk6IyKnWLug+ECip1KBveYUHfp+8e9klMJ9c= golang.org/x/net v0.6.0 h1:L4ZwwTvKW9gr0ZMS1yrHD9GZhIuVjOBBnaKH+SPQK0Q= golang.org/x/net v0.6.0/go.mod h1:2Tu9+aMcznHK/AK1HMvgo6xiTLG5rD5rZLDS+rp2Bjs= +golang.org/x/net v0.21.0/go.mod h1:bIjVDfnllIU7BJ2DNgfnXvpSvtn8VRwhlsaeUTyUS44= golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U= golang.org/x/oauth2 v0.0.0-20190226205417-e64efc72b421/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw= golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw= @@ -647,12 +651,14 @@ golang.org/x/sys
(skywalking-cli) branch CVE-2023-48795 created (now 7d9bc22)
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to branch CVE-2023-48795 in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git at 7d9bc22 Upgrade crypto lib to fix CVE-2023-48795 This branch includes the following new commits: new 7d9bc22 Upgrade crypto lib to fix CVE-2023-48795 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
wankai123 commented on code in PR #11935:
URL: https://github.com/apache/skywalking/pull/11935#discussion_r1503570238
##
docs/en/concepts-and-designs/service-hierarchy.md:
##
@@ -144,6 +146,22 @@ If you want to customize it according to your own needs,
please refer to [Servic
- VIRTUAL_MQ.service.name:
`rocketmq.skywalking-showcase.svc.cluster.local:9876`
- ROCKETMQ.service.name: `rocketmq::rocketmq.skywalking-showcase`
+ RABBITMQ On K8S_SERVICE
+- Rule name: `short-name`
+- Groovy script: `{ (u, l) -> u.shortName == l.shortName }`
+- Description: RABBITMQ.service.shortName == K8S_SERVICE.service.shortName
+- Matched Example:
+ - RABBITMQ.service.name: `rabbitmq::rabbitmq.skywalking-showcase`
+ - K8S_SERVICE.service.name:
`skywalking-showcase::demo-rabbitmq.skywalking-showcase`
Review Comment:
```suggestion
- K8S_SERVICE.service.name:
`skywalking-showcase::rabbitmq.skywalking-showcase`
```
##
docs/en/concepts-and-designs/service-hierarchy.md:
##
@@ -26,7 +26,9 @@ If you want to customize it according to your own needs,
please refer to [Servic
| NGINX| K8S_SERVICE | [NGINX On
K8S_SERVICE](#nginx-on-k8s_service) |
| APISIX | K8S_SERVICE | [APISIX On
K8S_SERVICE](#apisix-on-k8s_service) |
| ROCKETMQ | K8S_SERVICE | [ROCKETMQ On
K8S_SERVICE](#rocketmq-on-k8s_service) |
-| VIRTUAL_MQ | ROCKETMQ| [VIRTUAL_MQ On
K8S_SERVICE](#virtual_mq-on-rocketmq) |
+| VIRTUAL_MQ | ROCKETMQ| [VIRTUAL_MQ On
ROCKETMQ](#virtual_mq-on-rocketmq) |
+| RABBITMQ | K8S_SERVICE | [RABBITMQ On
K8S_SERVICE](#rocketmq-on-k8s_service) |
Review Comment:
```suggestion
| RABBITMQ | K8S_SERVICE | [RABBITMQ On
K8S_SERVICE](#rabbitmq-on-k8s_service) |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
wu-sheng commented on PR #11935: URL: https://github.com/apache/skywalking/pull/11935#issuecomment-1965694865 > > Especially, I am not sure, if there is no DNS assistant, is the `ip1,ip2,ip3` used at the agent side good enough to associate with server monitoring? > > Maybe it is better to allow end users to configure these settings? Users are able to config for sure, that is why we put that in scripts rather than codes. But still, users may not know how to set up. That is the point of blog. We keep anything out of box by k8s setup as it is easier to be certain. But a lot of users are running service on VM, right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
peachisai commented on PR #11935: URL: https://github.com/apache/skywalking/pull/11935#issuecomment-1965693548 > Especially, I am not sure, if there is no DNS assistant, is the `ip1,ip2,ip3` used at the agent side good enough to associate with server monitoring? Maybe it is better to allow end users to configure these settings? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
wu-sheng commented on PR #11935: URL: https://github.com/apache/skywalking/pull/11935#issuecomment-1965689439 Especially, I am not sure, if there is no DNS assistant, is the `ip1,ip2,ip3` used at the agent side good enough to associate with server monitoring? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
wu-sheng commented on PR #11935: URL: https://github.com/apache/skywalking/pull/11935#issuecomment-1965688586 @peachisai When you work on Kafka, let's consider two scenarios, one is like this, working with DNS on K8s, the other is how would it be on VM env. And we could post a blog about that part(VM and K8s). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
peachisai commented on code in PR #11935:
URL: https://github.com/apache/skywalking/pull/11935#discussion_r1503549441
##
docs/en/concepts-and-designs/service-hierarchy.md:
##
@@ -144,6 +146,22 @@ If you want to customize it according to your own needs,
please refer to [Servic
- VIRTUAL_MQ.service.name:
`rocketmq.skywalking-showcase.svc.cluster.local:9876`
- ROCKETMQ.service.name: `rocketmq::rocketmq.skywalking-showcase`
+ RABBITMQ On K8S_SERVICE
+- Rule name: `short-name`
+- Groovy script: `{ (u, l) -> u.shortName == l.shortName }`
+- Description: RABBITMQ.service.shortName == K8S_SERVICE.service.shortName
+- Matched Example:
+ - RABBITMQ.service.name: `rabbitmq::rabbitmq.skywalking-showcase`
+ - K8S_SERVICE.service.name:
`skywalking-showcase::demo-rabbitmq.skywalking-showcase`
+
+ VIRTUAL_MQ On RABBITMQ
+- Rule name: `lower-short-name-with-fqdn`
+- Groovy script: `{ (u, l) -> u.shortName.substring(0,
u.shortName.lastIndexOf(':')) == l.shortName.concat('.svc.cluster.local') }`
+- Description: VIRTUAL_MQ.service.shortName remove port ==
RABBITMQ.service.shortName with fqdn suffix
+- Matched Example:
+ - VIRTUAL_MQ.service.name:
`rabbitmq.skywalking-showcase.svc.cluster.local:5672`
Review Comment:
k8s dns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
wankai123 commented on code in PR #11935:
URL: https://github.com/apache/skywalking/pull/11935#discussion_r1503537284
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/rabbitmq/rabbitmq-cluster.json:
##
@@ -732,7 +732,34 @@
"entity": "Service",
"name": "RabbitMQ-Cluster",
"id": "RabbitMQ-Cluster",
- "isRoot": false
+ "isRoot": false,
+ "isDefault": true,
+ "expressions": [
+"avg(meter_rabbitmq_messages_published)*100",
+"avg(meter_rabbitmq_messages_unconfirmed)*100",
+"avg(meter_rabbitmq_queues)",
+"avg(meter_rabbitmq_channels)",
+"avg(meter_rabbitmq_connections)"
+ ],
+ "expressionsConfig": [
+{
+ "unit": "%",
+ "label": "messages published rate"
+},
+{
+ "unit": "%",
+ "label": "messages unconfirmed rate"
Review Comment:
Following the original widget title is good. And remove `*100` from your
expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
wu-sheng commented on code in PR #11935:
URL: https://github.com/apache/skywalking/pull/11935#discussion_r1503531228
##
docs/en/concepts-and-designs/service-hierarchy.md:
##
@@ -144,6 +146,22 @@ If you want to customize it according to your own needs,
please refer to [Servic
- VIRTUAL_MQ.service.name:
`rocketmq.skywalking-showcase.svc.cluster.local:9876`
- ROCKETMQ.service.name: `rocketmq::rocketmq.skywalking-showcase`
+ RABBITMQ On K8S_SERVICE
+- Rule name: `short-name`
+- Groovy script: `{ (u, l) -> u.shortName == l.shortName }`
+- Description: RABBITMQ.service.shortName == K8S_SERVICE.service.shortName
+- Matched Example:
+ - RABBITMQ.service.name: `rabbitmq::rabbitmq.skywalking-showcase`
+ - K8S_SERVICE.service.name:
`skywalking-showcase::demo-rabbitmq.skywalking-showcase`
+
+ VIRTUAL_MQ On RABBITMQ
+- Rule name: `lower-short-name-with-fqdn`
+- Groovy script: `{ (u, l) -> u.shortName.substring(0,
u.shortName.lastIndexOf(':')) == l.shortName.concat('.svc.cluster.local') }`
+- Description: VIRTUAL_MQ.service.shortName remove port ==
RABBITMQ.service.shortName with fqdn suffix
+- Matched Example:
+ - VIRTUAL_MQ.service.name:
`rabbitmq.skywalking-showcase.svc.cluster.local:5672`
Review Comment:
Is this working for cluster mode of RaabitMQ? Are multiple IPs in this name?
Or just DNS because of K8s deployment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
peachisai commented on PR #11935: URL: https://github.com/apache/skywalking/pull/11935#issuecomment-1965644173 > @peachisai Do you check how RabbitMQ Java plugin works this? Can we establish the relationship between the virtual MQ to server monitoring? The display relationship is between virtual mq and server monitring -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
peachisai commented on code in PR #11935:
URL: https://github.com/apache/skywalking/pull/11935#discussion_r1503529467
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/rabbitmq/rabbitmq-cluster.json:
##
@@ -732,7 +732,34 @@
"entity": "Service",
"name": "RabbitMQ-Cluster",
"id": "RabbitMQ-Cluster",
- "isRoot": false
+ "isRoot": false,
+ "isDefault": true,
+ "expressions": [
+"avg(meter_rabbitmq_messages_published)*100",
+"avg(meter_rabbitmq_messages_unconfirmed)*100",
+"avg(meter_rabbitmq_queues)",
+"avg(meter_rabbitmq_channels)",
+"avg(meter_rabbitmq_connections)"
+ ],
+ "expressionsConfig": [
+{
+ "unit": "%",
+ "label": "messages published rate"
+},
+{
+ "unit": "%",
+ "label": "messages unconfirmed rate"
Review Comment:
Is that adding ```increase``` into the label ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Release SkyWalking Go 0.4.0 [skywalking-website]
wu-sheng merged PR #681: URL: https://github.com/apache/skywalking-website/pull/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch master updated: Release SkyWalking Go 0.4.0 (#681)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 7f911a4d525 Release SkyWalking Go 0.4.0 (#681) 7f911a4d525 is described below commit 7f911a4d52576d8bc54c7765bd80a50f2a4b0a73 Author: mrproliu <741550...@qq.com> AuthorDate: Tue Feb 27 09:44:09 2024 +0800 Release SkyWalking Go 0.4.0 (#681) --- .../release-apache-skwaylking-go-0.4.0/index.md| 38 ++ data/docs.yml | 8 ++--- data/releases.yml | 20 ++-- 3 files changed, 52 insertions(+), 14 deletions(-) diff --git a/content/events/release-apache-skwaylking-go-0.4.0/index.md b/content/events/release-apache-skwaylking-go-0.4.0/index.md new file mode 100644 index 000..9fc321ffe08 --- /dev/null +++ b/content/events/release-apache-skwaylking-go-0.4.0/index.md @@ -0,0 +1,38 @@ +--- +title: Release Apache SkyWalking Go 0.4.0 +date: 2024-02-27 +author: SkyWalking Team +description: "Release Apache SkyWalking Go 0.4.0" +--- + +SkyWalking Go 0.4.0 is released. Go to [downloads](https://skywalking.apache.org/downloads) page to find release tars. + + Features +* Add support ignore suffix for span name. +* Adding go `1.21` and `1.22` in docker image. + + Plugins +* Support setting a discard type of reporter. +* Add `redis.max_args_bytes` parameter for redis plugin. +* Changing intercept point for gin, make sure interfaces could be grouped when params defined in relativePath. +* Support [RocketMQ](https://github.com/apache/rocketmq-client-go) MQ. +* Support [AMQP](https://github.com/rabbitmq/amqp091-go) MQ. +* support [Echov4](https://github.com/labstack/echo) framework. + + Documentation + + Bug Fixes +* Fix users can not use async api in toolkit-trace. +* Fix cannot enhance the vendor management project. +* Fix SW_AGENT_REPORTER_GRPC_MAX_SEND_QUEUE not working on metricsSendCh & logSendCh chans of gRPC reporter. +* Fix ParseVendorModule error for special case in vendor/modules.txt. +* Fix enhance method error when unknown parameter type. +* Fix wrong tracing context when trace have been sampled. +* Fix enhance param error when there are multiple params. +* Fix lost trace when multi middleware `handlerFunc` in `gin` plugin. +* Fix DBQueryContext execute error in `sql` plugin. +* Fix stack overflow as endless logs triggered. + + Issues and PR +- All issues are [here](https://github.com/apache/skywalking/milestone/197?closed=1) +- All and pull requests are [here](https://github.com/apache/skywalking-go/milestone/4?closed=1) diff --git a/data/docs.yml b/data/docs.yml index 68a37d19464..0953bccb982 100644 --- a/data/docs.yml +++ b/data/docs.yml @@ -155,10 +155,10 @@ link: /docs/skywalking-go/next/readme/ - version: Latest link: /docs/skywalking-go/latest/readme/ - commitId: 316433e71808ec6a130e81c287caa8b2a98f45a5 -- version: v0.3.0 - link: /docs/skywalking-go/v0.3.0/readme/ - commitId: 316433e71808ec6a130e81c287caa8b2a98f45a5 + commitId: 642606007162e9b6f5c6827e4903994f6364d8fe +- version: v0.4.0 + link: /docs/skywalking-go/v0.4.0/readme/ + commitId: 642606007162e9b6f5c6827e4903994f6364d8fe - name: Rust Agent icon: sw-rust diff --git a/data/releases.yml b/data/releases.yml index a130a94d5c6..cf915066e76 100644 --- a/data/releases.yml +++ b/data/releases.yml @@ -304,25 +304,25 @@ icon: skywalking-go description: The Go Agent for Apache SkyWalking, which provides the native tracing/metrics/logging abilities for Golang projects. source: -- version: v0.3.0 - date: Oct. 23th, 2023 +- version: v0.4.0 + date: Feb. 27th, 2024 downloadLink: - name: src - link: https://www.apache.org/dyn/closer.cgi/skywalking/go/0.3.0/apache-skywalking-go-0.3.0-src.tgz + link: https://www.apache.org/dyn/closer.cgi/skywalking/go/0.4.0/apache-skywalking-go-0.4.0-src.tgz - name: asc - link: https://downloads.apache.org/skywalking/go/0.3.0/apache-skywalking-go-0.3.0-src.tgz.asc + link: https://downloads.apache.org/skywalking/go/0.4.0/apache-skywalking-go-0.4.0-src.tgz.asc - name: sha512 - link: https://downloads.apache.org/skywalking/go/0.3.0/apache-skywalking-go-0.3.0-src.tgz.sha512 + link: https://downloads.apache.org/skywalking/go/0.4.0/apache-skywalking-go-0.4.0-src.tgz.sha512 distribution: -- version: v0.3.0 - date: Oct. 23th, 2023 +- version: v0.4.0 + date: Feb. 27th, 2024 downloadLink: - name: tar - link:
Re: [PR] Release SkyWalking Go 0.4.0 [skywalking-website]
wu-sheng commented on code in PR #681: URL: https://github.com/apache/skywalking-website/pull/681#discussion_r1503523090 ## data/docs.yml: ## @@ -156,9 +156,9 @@ - version: Latest link: /docs/skywalking-go/latest/readme/ commitId: 316433e71808ec6a130e81c287caa8b2a98f45a5 -- version: v0.3.0 - link: /docs/skywalking-go/v0.3.0/readme/ - commitId: 316433e71808ec6a130e81c287caa8b2a98f45a5 +- version: v0.4.0 + link: /docs/skywalking-go/v0.4.0/readme/ + commitId: 642606007162e9b6f5c6827e4903994f6364d8fe Review Comment: As 0.4 is the latest, please update the latest as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Release SkyWalking Go 0.4.0 [skywalking-website]
netlify[bot] commented on PR #681: URL: https://github.com/apache/skywalking-website/pull/681#issuecomment-1965632197 ### Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit | 62fae6cd17dcba75f95701dab2096b28d4173469 | | Latest deploy log | https://app.netlify.com/sites/skywalking-website-preview/deploys/65dd3c0c87eb550008e4951d | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Release SkyWalking Go 0.4.0 [skywalking-website]
mrproliu opened a new pull request, #681: URL: https://github.com/apache/skywalking-website/pull/681 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [feature-WIP] add support for Pulsar [skywalking-go]
CodePrometheus commented on PR #173: URL: https://github.com/apache/skywalking-go/pull/173#issuecomment-1965608815 > Meanwhile, you should try and test service hierarchy for Pulsar, if you want. especially from virtual MQ to MQ server. Copy that, I want to try it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch master updated: Add Golang as a supported language for Pulsar (#11937)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new f006edd158 Add Golang as a supported language for Pulsar (#11937) f006edd158 is described below commit f006edd158afb3ea0be2faa9033a82fc5d382a50 Author: Starry AuthorDate: Tue Feb 27 09:00:32 2024 +0800 Add Golang as a supported language for Pulsar (#11937) --- docs/en/changes/changes.md | 1 + .../server-starter/src/main/resources/component-libraries.yml | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md index 96b87d0844..1d4b77f512 100644 --- a/docs/en/changes/changes.md +++ b/docs/en/changes/changes.md @@ -57,6 +57,7 @@ * Fix day-based table rolling time range strategy in JDBC storage. * Add `maxInboundMessageSize (SW_DCS_MAX_INBOUND_MESSAGE_SIZE)` configuration to change the max inbound message size of DCS. * Fix Service Layer when building Events in the EventHookCallback. +* Add Golang as a supported language for Pulsar. UI diff --git a/oap-server/server-starter/src/main/resources/component-libraries.yml b/oap-server/server-starter/src/main/resources/component-libraries.yml index 03482f2076..8c39ff21d5 100644 --- a/oap-server/server-starter/src/main/resources/component-libraries.yml +++ b/oap-server/server-starter/src/main/resources/component-libraries.yml @@ -262,13 +262,13 @@ Light4J: languages: Java Pulsar: id: 72 - languages: Java + languages: Java,Golang pulsar-producer: id: 73 - languages: Java + languages: Java,Golang pulsar-consumer: id: 74 - languages: Java + languages: Java,Golang Ehcache: id: 75 languages: Java
Re: [PR] Add Golang as a supported language for Pulsar [skywalking]
wu-sheng merged PR #11937: URL: https://github.com/apache/skywalking/pull/11937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
wankai123 commented on code in PR #11935:
URL: https://github.com/apache/skywalking/pull/11935#discussion_r1503490634
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/rabbitmq/rabbitmq-cluster.json:
##
@@ -732,7 +732,34 @@
"entity": "Service",
"name": "RabbitMQ-Cluster",
"id": "RabbitMQ-Cluster",
- "isRoot": false
+ "isRoot": false,
+ "isDefault": true,
+ "expressions": [
+"avg(meter_rabbitmq_messages_published)*100",
+"avg(meter_rabbitmq_messages_unconfirmed)*100",
+"avg(meter_rabbitmq_queues)",
+"avg(meter_rabbitmq_channels)",
+"avg(meter_rabbitmq_connections)"
+ ],
+ "expressionsConfig": [
+{
+ "unit": "%",
+ "label": "messages published rate"
+},
+{
+ "unit": "%",
+ "label": "messages unconfirmed rate"
Review Comment:
```
avg(meter_rabbitmq_messages_published)*100
avg(meter_rabbitmq_messages_unconfirmed)*100
```
What do those expressions mean？ I don't think they represent the percent
rate.
The MAL are：
```
- name: messages_published
exp: rabbitmq_global_messages_received_total.sum(['cluster',
'node']).rate('PT1M')
- name: messages_confirmed
exp: rabbitmq_global_messages_confirmed_total.sum(['cluster',
'node']).rate('PT1M')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
wankai123 commented on code in PR #11935:
URL: https://github.com/apache/skywalking/pull/11935#discussion_r1503490634
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/rabbitmq/rabbitmq-cluster.json:
##
@@ -732,7 +732,34 @@
"entity": "Service",
"name": "RabbitMQ-Cluster",
"id": "RabbitMQ-Cluster",
- "isRoot": false
+ "isRoot": false,
+ "isDefault": true,
+ "expressions": [
+"avg(meter_rabbitmq_messages_published)*100",
+"avg(meter_rabbitmq_messages_unconfirmed)*100",
+"avg(meter_rabbitmq_queues)",
+"avg(meter_rabbitmq_channels)",
+"avg(meter_rabbitmq_connections)"
+ ],
+ "expressionsConfig": [
+{
+ "unit": "%",
+ "label": "messages published rate"
+},
+{
+ "unit": "%",
+ "label": "messages unconfirmed rate"
Review Comment:
```
avg(meter_rabbitmq_messages_published)*100
avg(meter_rabbitmq_messages_unconfirmed)*100
```
What do those expressions mean？ I don't think they represent the percent
rate.
The MAL are：
```
- name: messages_published
exp: rabbitmq_global_messages_received_total.sum(['cluster',
'node']).rate('PT1M')
- name: messages_confirmed
exp: rabbitmq_global_messages_confirmed_total.sum(['cluster',
'node']).rate('PT1M')
- name: messages_routed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
wu-sheng commented on PR #11935: URL: https://github.com/apache/skywalking/pull/11935#issuecomment-1965556781 @peachisai Do you check how RabbitMQ Java plugin works this? Can we establish the relationship between the virtual MQ to server monitoring? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug, Vulnerability] CVE-2023-48795 [skywalking]
wu-sheng commented on issue #11936: URL: https://github.com/apache/skywalking/issues/11936#issuecomment-1965542249 @kezhenxu94 Could you take a look? I think this may be either from base image or a kind of CLI side issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [feature-WIP] add support for Pulsar [skywalking-go]
wu-sheng commented on PR #173: URL: https://github.com/apache/skywalking-go/pull/173#issuecomment-1965524702 Meanwhile, you should try and test service hierarchy for Pulsar, if you want. especially from virtual MQ to MQ server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [feature-WIP] add support for Pulsar [skywalking-go]
wu-sheng commented on PR #173: URL: https://github.com/apache/skywalking-go/pull/173#issuecomment-1965523729 Showcase is fine, it can't hold all plugin examples there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [feature-WIP] add support for Pulsar [skywalking-go]
CodePrometheus commented on PR #173: URL: https://github.com/apache/skywalking-go/pull/173#issuecomment-1964808100 Ref https://github.com/apache/skywalking/pull/11937. Maybe I need some time, please hold for a while, thanks. AFAIK, We have Pulsar monitoring and agent plugins (Java is ready and Go are currently in progress) for Pulsar, skywalking-showcase needs to be added accordingly? I am willing to try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add Golang as a supported language for Pulsar [skywalking]
CodePrometheus opened a new pull request, #11937: URL: https://github.com/apache/skywalking/pull/11937 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [feature-WIP] add support for Pulsar [skywalking-go]
CodePrometheus opened a new pull request, #173: URL: https://github.com/apache/skywalking-go/pull/173 ### summary [Pulsar](https://github.com/apache/pulsar-client-go) is a native go client maintained by the apache pulsar team. - [x] Update the docs. - [x] Pass CI test. - [ ] Pass Plugin test. ### test report https://github.com/apache/skywalking-go/assets/66550292/2039a4e0-4d99-4fef-8886-ca4b7c1ee0d0;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug, Vulnerability] CVE-2023-48795 [skywalking]
VladislavDubrovenski commented on issue #11936: URL: https://github.com/apache/skywalking/issues/11936#issuecomment-1964762469 @wu-sheng I appreciate you reopening this issue. Constantly repackaging every open-source solution would make it a nightmare from maintainability perspective. It seems that many open-source solutions suffer from this vulnerability(even though the library in question was not in use in many, but scans still flag it). I have several examples where it was already fixed: Jaeger: https://github.com/jaegertracing/jaeger/pull/5016 Grafana: https://github.com/grafana/grafana/issues/80316 ArgoCD: https://github.com/argoproj/argo-cd/issues/17020 Prometheus: https://github.com/prometheus/prometheus/issues/13512 And others I understand that this causes certain inconveniences, and I apologize for that, but I had been required to address this particular vulnerability in the past month. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug, Vulnerability] CVE-2023-48795 [skywalking]
wu-sheng commented on issue #11936: URL: https://github.com/apache/skywalking/issues/11936#issuecomment-1964379697 Or is this a Linux level CVE? You could repackage the whole thing and get the latest `eclipse-temurin:11-jre`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug, Vulnerability] CVE-2023-48795 [skywalking]
wu-sheng commented on issue #11936: URL: https://github.com/apache/skywalking/issues/11936#issuecomment-1964372620 OK, if you mean images, you need to check whether it is from swctl or something? Because OAP and UI themselves are only Java based. You could check the docker file, https://github.com/apache/skywalking/blob/master/docker/oap/Dockerfile About the CLI, it is from https://github.com/apache/skywalking-cli. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug, Vulnerability] CVE-2023-48795 [skywalking]
VladislavDubrovenski commented on issue #11936: URL: https://github.com/apache/skywalking/issues/11936#issuecomment-1964346182 @wu-sheng I understand that, I opened it for OAP. Also, it occurs to me that the image you use for deployment on k8s for UI has the vulnerability. Where should I report this? This vulnerability was present for almost 2 months and my only other remediation is to disable the skywalking which I really don't want to do as I have written custom scripts for it as well.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug, Vulnerability] CVE-2023-48795 [skywalking]
wu-sheng closed issue #11936: [Bug, Vulnerability] CVE-2023-48795 URL: https://github.com/apache/skywalking/issues/11936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug, Vulnerability] CVE-2023-48795 [skywalking]
wu-sheng commented on issue #11936: URL: https://github.com/apache/skywalking/issues/11936#issuecomment-1964336814 We are only using Go and Python in OAP. I am not sure what you mean. This is a Java project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug, Vulnerability] CVE-2023-48795 [skywalking]
VladislavDubrovenski opened a new issue, #11936: URL: https://github.com/apache/skywalking/issues/11936 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component OAP server (apache/skywalking) ### What happened Good day, The scanner flags CVE-2023-48795 in OAP and UI that I am required to fix to continue using this great project.. The skywalking is deployed using a helm chart. More information: OAP: - fixedVersion: 0.17.0 installedVersion: v0.0.0-20220411220226-7b82a4e95df4 lastModifiedDate: "2024-01-29T09:15:42Z" links: [] primaryLink: https://avd.aquasec.com/nvd/cve-2023-48795 publishedDate: "2023-12-18T16:15:10Z" resource: golang.org/x/crypto score: 5.9 severity: MEDIUM target: "" title: 'ssh: Prefix truncation attack on Binary Packet Protocol (BPP)' vulnerabilityID: CVE-2023-48795 UI: - fixedVersion: 0.9.6-2ubuntu0.22.04.2 installedVersion: 0.9.6-2ubuntu0.22.04.1 lastModifiedDate: "2024-01-29T09:15:42Z" links: [] primaryLink: https://avd.aquasec.com/nvd/cve-2023-48795 publishedDate: "2023-12-18T16:15:10Z" resource: libssh-4 score: 5.9 severity: MEDIUM target: "" title: 'ssh: Prefix truncation attack on Binary Packet Protocol (BPP)' vulnerabilityID: CVE-2023-4879 ### What you expected to happen No vulnerability found ### How to reproduce Install skywalking via helm chart ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add hierarchy for RabbitMQ [skywalking]
peachisai commented on PR #11935: URL: https://github.com/apache/skywalking/pull/11935#issuecomment-1964253884 Refer https://github.com/apache/skywalking/issues/11926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add hierarchy for RabbitMQ [skywalking]
peachisai opened a new pull request, #11935: URL: https://github.com/apache/skywalking/pull/11935 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch ui-sync deleted (was 6f488fffaa)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch ui-sync in repository https://gitbox.apache.org/repos/asf/skywalking.git was 6f488fffaa Update changes. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(skywalking) branch master updated: Sync UI (#11934)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new fc9d9acba4 Sync UI (#11934) fc9d9acba4 is described below commit fc9d9acba4ea5aaef5e8200c75f9043a0fc03364 Author: 吴晟 Wu Sheng AuthorDate: Mon Feb 26 21:39:26 2024 +0800 Sync UI (#11934) --- dist-material/release-docs/LICENSE | 4 ++-- docs/en/changes/changes.md | 5 + skywalking-ui | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/dist-material/release-docs/LICENSE b/dist-material/release-docs/LICENSE index 76dc93c148..1a27f2fcea 100644 --- a/dist-material/release-docs/LICENSE +++ b/dist-material/release-docs/LICENSE @@ -541,12 +541,12 @@ The text of each license is also included in licenses/LICENSE-[project].txt. https://npmjs.com/package/mitt/v/2.1.0 2.1.0 MIT https://npmjs.com/package/moment/v/2.29.4 2.29.4 MIT https://npmjs.com/package/monaco-editor/v/0.34.1 0.34.1 MIT -https://npmjs.com/package/nanoid/v/3.3.6 3.3.6 MIT +https://npmjs.com/package/nanoid/v/3.3.7 3.3.7 MIT https://mvnrepository.com/artifact/org.checkerframework/checker-qual/3.33.0 MIT https://mvnrepository.com/artifact/org.codehaus.mojo/animal-sniffer-annotations/1.21 MIT https://npmjs.com/package/pinia/v/2.0.28 2.0.28 MIT https://npmjs.com/package/pinia/node_modules/vue-demi/v/0.13.11 0.13.11 MIT -https://npmjs.com/package/postcss/v/8.4.24 8.4.24 MIT +https://npmjs.com/package/postcss/v/8.4.33 8.4.33 MIT https://npmjs.com/package/propagating-hammerjs/v/2.0.1 2.0.1 MIT https://npmjs.com/package/safer-buffer/v/2.1.2 2.1.2 MIT https://npmjs.com/package/sourcemap-codec/v/1.4.8 1.4.8 MIT diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md index 48183b2548..96b87d0844 100644 --- a/docs/en/changes/changes.md +++ b/docs/en/changes/changes.md @@ -95,5 +95,10 @@ * Document a new way to load balance OAP. * Add `SWIP-3 Support RocketMQ monitoring`. * Add `OpenTelemetry SkyWalking Exporter` deprecated warning doc. +* Update i18n for rocketmq monitoring. +* Fix: remove click event after unmounted. +* Fix: end loading without query results. +* Update nanoid version to 3.3.7. +* Update postcss version to 8.4.33. All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/202?closed=1) diff --git a/skywalking-ui b/skywalking-ui index ccb4d78f6b..e25bf9ee8b 16 --- a/skywalking-ui +++ b/skywalking-ui @@ -1 +1 @@ -Subproject commit ccb4d78f6bfb298a4921f0952fec82afedf7cf0f +Subproject commit e25bf9ee8b70898bf9fb2cb61a98a768244a0221
Re: [PR] Sync UI [skywalking]
wu-sheng merged PR #11934: URL: https://github.com/apache/skywalking/pull/11934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch ui-sync updated (c6ea2a7bb1 -> 6f488fffaa)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch ui-sync in repository https://gitbox.apache.org/repos/asf/skywalking.git from c6ea2a7bb1 Fix licenses. add 6f488fffaa Update changes. No new revisions were added by this update. Summary of changes: docs/en/changes/changes.md | 2 ++ 1 file changed, 2 insertions(+)
(skywalking) branch ui-sync updated (d11de0ab93 -> c6ea2a7bb1)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch ui-sync in repository https://gitbox.apache.org/repos/asf/skywalking.git from d11de0ab93 Sync UI add c6ea2a7bb1 Fix licenses. No new revisions were added by this update. Summary of changes: dist-material/release-docs/LICENSE | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[PR] Sync UI [skywalking]
wu-sheng opened a new pull request, #11934: URL: https://github.com/apache/skywalking/pull/11934 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) 01/01: Sync UI
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch ui-sync in repository https://gitbox.apache.org/repos/asf/skywalking.git commit d11de0ab935214274818d15bd1adb17a5e5f3d48 Author: Wu Sheng AuthorDate: Mon Feb 26 21:27:55 2024 +0800 Sync UI --- docs/en/changes/changes.md | 3 +++ skywalking-ui | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md index 48183b2548..f85f8396f6 100644 --- a/docs/en/changes/changes.md +++ b/docs/en/changes/changes.md @@ -95,5 +95,8 @@ * Document a new way to load balance OAP. * Add `SWIP-3 Support RocketMQ monitoring`. * Add `OpenTelemetry SkyWalking Exporter` deprecated warning doc. +* Update i18n for rocketmq monitoring. +* Fix: remove click event after unmounted. +* Fix: end loading without query results. All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/202?closed=1) diff --git a/skywalking-ui b/skywalking-ui index ccb4d78f6b..e25bf9ee8b 16 --- a/skywalking-ui +++ b/skywalking-ui @@ -1 +1 @@ -Subproject commit ccb4d78f6bfb298a4921f0952fec82afedf7cf0f +Subproject commit e25bf9ee8b70898bf9fb2cb61a98a768244a0221
(skywalking) branch ui-sync created (now d11de0ab93)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch ui-sync in repository https://gitbox.apache.org/repos/asf/skywalking.git at d11de0ab93 Sync UI This branch includes the following new commits: new d11de0ab93 Sync UI The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
Re: [PR] fix: end loading without query results [skywalking-booster-ui]
wu-sheng merged PR #373: URL: https://github.com/apache/skywalking-booster-ui/pull/373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-booster-ui) branch main updated: fix: end loading without query results (#373)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git
The following commit(s) were added to refs/heads/main by this push:
new e25bf9ee fix: end loading without query results (#373)
e25bf9ee is described below
commit e25bf9ee8b70898bf9fb2cb61a98a768244a0221
Author: Fine0830
AuthorDate: Mon Feb 26 19:57:02 2024 +0800
fix: end loading without query results (#373)
---
src/hooks/useExpressionsProcessor.ts | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/hooks/useExpressionsProcessor.ts
b/src/hooks/useExpressionsProcessor.ts
index 63db0e29..90f40e00 100644
--- a/src/hooks/useExpressionsProcessor.ts
+++ b/src/hooks/useExpressionsProcessor.ts
@@ -153,9 +153,14 @@ export async function useExpressionsQueryProcessor(config:
Indexable) {
ElMessage.error(json.errors);
return { source: {}, tips: [], typesOfMQE: [] };
}
- const data = expressionsSource(json);
+ try {
+const data = expressionsSource(json);
- return data;
+return data;
+ } catch (error) {
+console.error(error);
+return { source: {}, tips: [], typesOfMQE: [] };
+ }
}
export async function useExpressionsQueryPodsMetrics(
[PR] fix: end loading without query results [skywalking-booster-ui]
Fine0830 opened a new pull request, #373: URL: https://github.com/apache/skywalking-booster-ui/pull/373 Screenshot https://github.com/apache/skywalking-booster-ui/assets/20871783/99b9f217-e82c-4f2f-8feb-9284108358b5;> Signed-off-by: Qiuxia Fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-go sdk panic [skywalking]
wu-sheng closed issue #11932: [Bug] skywalking-go sdk panic URL: https://github.com/apache/skywalking/issues/11932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-go sdk panic [skywalking]
wu-sheng commented on issue #11932: URL: https://github.com/apache/skywalking/issues/11932#issuecomment-1963809762 Convert to the discussion as it is not the official way to work. Reach Alicloud as they suggest you to do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-go sdk panic [skywalking]
wu-sheng commented on issue #11932: URL: https://github.com/apache/skywalking/issues/11932#issuecomment-1963806792 Then why asking us? We don't pormise this works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-go sdk panic [skywalking]
Donghui0 commented on issue #11932: URL: https://github.com/apache/skywalking/issues/11932#issuecomment-1963804236 > Why to open telemetry rather than OAP? > > #11916 > > That collector is not recommended to use. This component is not used. The overall architecture is based on opentelmetry. It looks like:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-go sdk panic [skywalking]
wu-sheng commented on issue #11932: URL: https://github.com/apache/skywalking/issues/11932#issuecomment-1963791055 Why to open telemetry rather than OAP? https://github.com/apache/skywalking/discussions/11916 That collector is not recommended to use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-go sdk panic [skywalking]
Donghui0 commented on issue #11932: URL: https://github.com/apache/skywalking/issues/11932#issuecomment-1963783988 > Could you help to adding a demo in there? It looks like a gRPC/protobuf error. GRPC Server is an Opentelmetry skywalking receiver. opentelementry: 0.90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch asf-site updated: deploy: 2d7abfb91a26725933a364d7b6508af7cc01b527
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new ef853bc6029 deploy: 2d7abfb91a26725933a364d7b6508af7cc01b527 ef853bc6029 is described below commit ef853bc6029b51989407a60c15f2682216a9cfe3 Author: wu-sheng AuthorDate: Mon Feb 26 10:05:13 2024 + deploy: 2d7abfb91a26725933a364d7b6508af7cc01b527 --- contributors/index.html | 20 +--- docs/skywalking-showcase/next/readme/index.html | 13 + index.json | 2 +- searchindex.json| 2 +- team/index.html | 12 +++- 5 files changed, 39 insertions(+), 10 deletions(-) diff --git a/contributors/index.html b/contributors/index.html index cf8fd1b4435..d221498287d 100644 --- a/contributors/index.html +++ b/contributors/index.html @@ -296,7 +296,7 @@ -30 +31 4 @@ -498,6 +498,20 @@ + + +https://github.com/peachisai; target="_blank"> + + peachisai + + + +1 +19 + + + + https://github.com/sacloudy; target="_blank"> @@ -507,7 +521,7 @@ 1 -19 +20 @@ -24085,7 +24099,7 @@ -755 +756 1 diff --git a/docs/skywalking-showcase/next/readme/index.html b/docs/skywalking-showcase/next/readme/index.html index 089bee66957..7e0d3447f28 100644 --- a/docs/skywalking-showcase/next/readme/index.html +++ b/docs/skywalking-showcase/next/readme/index.html @@ -41,7 +41,7 @@ This showcase repository includes an example music application and other manifes This showcase repository includes an example music application and other manifests to demonstrate the main features of SkyWalking. The music application is composed of several microservices that are written in different programming languages. Here is the architecture: %% please read this doc in our official website, otherwise the graph is not correctly rendered."> - + @@ -273,7 +273,7 @@ This showcase repository includes an example music application and other manifes })() - Commit Id: c2bf635 + Commit Id: e091b51 @@ -373,7 +373,7 @@ SkyWalking self observability. Notice, when run this showcase locally such as KinD, the images are downloaded inside the KinD, which could take over 10 mins(depend on local network). Rerun make deploy.kubernetes if some timeout errors break the process. Customization -The variables defined in https://github.com/apache/skywalking-showcase/tree/c2bf6359d29b84dc3ead0597d58ea67ab9c00aa7/Makefile.in;>Makefile.in can be overridden to customize the showcase, by specifying an +The variables defined in https://github.com/apache/skywalking-showcase/tree/e091b516195cc8f5e593a09400769c826672d00f/Makefile.in;>Makefile.in can be overridden to customize the showcase, by specifying an environment variable with the same name, e.g.: export ES_VERSION=7.14.0 make target @@ -381,7 +381,7 @@ make target Run make help to get more information. Features The showcase is composed of a set of scenarios with feature flags, you can deploy some of them that interest you by -overriding the FEATURE_FLAGS variable defined in https://github.com/apache/skywalking-showcase/tree/c2bf6359d29b84dc3ead0597d58ea67ab9c00aa7/Makefile.in;>Makefile.in, as documented +overriding the FEATURE_FLAGS variable defined in https://github.com/apache/skywalking-showcase/tree/e091b516195cc8f5e593a09400769c826672d00f/Makefile.in;>Makefile.in, as documented in Customization, e.g.: make deploy.kubernetes FEATURE_FLAGS=single-node,agent Feature flags for different platforms (Kubernetes and Docker Compose) are not @@ -516,6 +516,11 @@ necessarily the same so make sure to specify the right feature flags. Deploy https://github.com/SkyAPM/R3;>R3 as RESTful URL recognition service. + +rocketmq-monitor +Deploy OpenTelemetry and export RocketMQ monitoring metrics to
Re: [I] [Bug] skywalking-go sdk panic [skywalking]
mrproliu commented on issue #11932: URL: https://github.com/apache/skywalking/issues/11932#issuecomment-1963737043 Could you help to adding a demo in there? It looks like a gRPC/protobuf error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-go sdk panic [skywalking]
wu-sheng commented on issue #11932: URL: https://github.com/apache/skywalking/issues/11932#issuecomment-1963720644 I am not sure this stack is enough to tell what is the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] skywalking-go sdk panic [skywalking]
Donghui0 opened a new issue, #11932:
URL: https://github.com/apache/skywalking/issues/11932
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
Java Agent (apache/skywalking-java)
### What happened
Sporadic panic problem:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x1d pc=0x884742]
goroutine 68 [running]:
google.golang.org/protobuf/internal/impl.sizeMessageSliceInfo({0x269?},
0xc00e220748, {0xf0?})
/data/repo_cache/golang/mod/google.golang.org/protobuf@v1.30.0/internal/impl/codec_field.go:472
+0x42
google.golang.org/protobuf/internal/impl.(*MessageInfo).sizePointerSlow(0xc000366e58,
{0x21e?}, {0x3?})
/data/repo_cache/golang/mod/google.golang.org/protobuf@v1.30.0/internal/impl/encode.go:79
+0xd9
google.golang.org/protobuf/internal/impl.(*MessageInfo).sizePointer(0xc00a76adc0?,
{0xc00cb22320?}, {0x58?})
/data/repo_cache/golang/mod/google.golang.org/protobuf@v1.30.0/internal/impl/encode.go:56
+0x76
google.golang.org/protobuf/internal/impl.sizeMessageSliceInfo({0x2419dcb?},
0xc00151ee60, {0x84?})
/data/repo_cache/golang/mod/google.golang.org/protobuf@v1.30.0/internal/impl/codec_field.go:473
+0x55
google.golang.org/protobuf/internal/impl.(*MessageInfo).sizePointerSlow(0xc000366d10,
{0xc46077?}, {0x76?})
/data/repo_cache/golang/mod/google.golang.org/protobuf@v1.30.0/internal/impl/encode.go:79
+0xd9
google.golang.org/protobuf/internal/impl.(*MessageInfo).sizePointer(0x284?,
{0xd?}, {0x80?})
/data/repo_cache/golang/mod/google.golang.org/protobuf@v1.30.0/internal/impl/encode.go:56
+0x76
google.golang.org/protobuf/internal/impl.sizeMessageSliceInfo({0x7efedb8ab1b8?},
0xc000295990, {0x68?})
/data/repo_cache/golang/mod/google.golang.org/protobuf@v1.30.0/internal/impl/codec_field.go:473
+0x55
google.golang.org/protobuf/internal/impl.(*MessageInfo).sizePointerSlow(0xc000366a80,
{0xc009e61a68?}, {0x80?})
/data/repo_cache/golang/mod/google.golang.org/protobuf@v1.30.0/internal/impl/encode.go:79
+0xd9
google.golang.org/protobuf/internal/impl.(*MessageInfo).sizePointer(0xc009e61ad8?,
{0x9?}, {0x80?})
/data/repo_cache/golang/mod/google.golang.org/protobuf@v1.30.0/internal/impl/encode.go:56
+0x76
google.golang.org/protobuf/internal/impl.(*MessageInfo).size(0x40802d?,
{{}, {0x286dcb8?, 0xc00bbf7950?}, 0x5?})
/data/repo_cache/golang/mod/google.golang.org/protobuf@v1.30.0/internal/impl/encode.go:40
+0x52
google.golang.org/protobuf/proto.MarshalOptions.marshal({{}, 0x50?, 0x0,
0x0}, {0x0, 0x0, 0x0}, {0x286dcb8, 0xc00bbf7950})
/data/repo_cache/golang/mod/google.golang.org/protobuf@v1.30.0/proto/encode.go:156
+0x142
google.golang.org/protobuf/proto.MarshalOptions.MarshalAppend({{}, 0x60?,
0x63?, 0x1e?}, {0x0, 0x0, 0x0}, {0x285a880?, 0xc00bbf7950?})
/data/repo_cache/golang/mod/google.golang.org/protobuf@v1.30.0/proto/encode.go:125
+0x79
github.com/golang/protobuf/proto.marshalAppend({0x0, 0x0, 0x0},
{0x7efeb03f7900?, 0xc00bbf7950?}, 0x80?)
/data/repo_cache/golang/mod/github.com/golang/protobuf@v1.5.3/proto/wire.go:40
+0xa5
github.com/golang/protobuf/proto.Marshal(...)
/data/repo_cache/golang/mod/github.com/golang/protobuf@v1.5.3/proto/wire.go:23
google.golang.org/grpc/encoding/proto.codec.Marshal({}, {0x21e6360,
0xc00bbf7950})
/data/repo_cache/golang/mod/google.golang.org/grpc@v1.55.0/encoding/proto/proto.go:45
+0x4e
google.golang.org/grpc.encode({0x7efedb8b28f8?, 0x3952e88?}, {0x21e6360?,
0xc00bbf7950?})
/data/repo_cache/golang/mod/google.golang.org/grpc@v1.55.0/rpc_util.go:632 +0x44
google.golang.org/grpc.prepareMsg({0x21e6360?, 0xc00bbf7950?},
{0x7efedb8b28f8?, 0x3952e88?}, {0x0, 0x0}, {0x0, 0x0})
/data/repo_cache/golang/mod/google.golang.org/grpc@v1.55.0/stream.go:1754 +0xd2
google.golang.org/grpc.(*clientStream).SendMsg(0xc00ca3e900, {0x21e6360,
0xc00bbf7950})
/data/repo_cache/golang/mod/google.golang.org/grpc@v1.55.0/stream.go:875 +0x1b5
skywalking.apache.org/repo/goapi/collect/language/agent/v3.(*traceSegmentReportServiceCollectClient).Send(0x2863028?,
0x2863098?)
/data/repo_cache/golang/mod/skywalking.apache.org/repo/goapi@v0.0.0-20230314034821-0c5a44bb767a/collect/language/agent/v3/Tracing_grpc.pb.go:61
+0x2b
github.com/apache/skywalking-go/agent/reporter.(*gRPCReporter).initSendPipeline.func1()
grpc.go:323 +0x1eb
created by
github.com/apache/skywalking-go/agent/reporter.(*gRPCReporter).initSendPipeline
grpc.go:305 +0x6a
### What you expected to happen
no panic. Normal operation, no impact on business.
Re: [I] Discussion about clickhouse support in the OAP [skywalking]
sglztc commented on issue #11924: URL: https://github.com/apache/skywalking/issues/11924#issuecomment-1963673538 > > What I want to know is are there any pitfalls in the process of adapting to clickhouse? > > I don't know that. > > > I would like to know some specific reasons why clickhouse is not supported, because we are currently doing research and implementation in this area to avoid taking some detours > > The only reason is what I mentioned. No one shows up to say they will implement it and maintain the implementation to make sure it is product ready. > > > Do I only need to implement storage-clickhouse-plugin to use clickhouse storage? Do you still need to do a deeper transformation? > > I have no idea about the clickhouse. From the design perspective, SkyWalking exposes the module APIs for making implementation easier. So, yes, we hope you only need to implement that. The reality is on the other side, sometimes, you will need annotations or some advanced flags on the kernel level to make the performance good. You can see Elasticsearch and JDBC relative flags are in the core module codes. > > So, you can see, every time, clickhouse relative discussions fall into the same hole. People want me or someone in the SkyWalking maintenance team to tell, but the truth is we as a group neither know the clickhouse, nor use it. So, there is no magic and short path. You have to understand both SkyWalking OAP kernel/details and the features of ClickHouse, and write design, coding and run performance tests to prove that this new storage option really is good. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] very much hope skywalking supports clickhouse [skywalking]
wu-sheng commented on issue #11924: URL: https://github.com/apache/skywalking/issues/11924#issuecomment-1963668800 The existing offering is being kept private and commercial only, which also shows up, it would not be that easy. So, you have to make your decision. I could only join the discussion if you are going to donate this to upstream and have at least two committers taking responsibility to maintain them, once it lacks maintenance, it will be removed like IoTDB and InfluxDB storage options. That is how open source community works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] very much hope skywalking supports clickhouse [skywalking]
wu-sheng commented on issue #11924: URL: https://github.com/apache/skywalking/issues/11924#issuecomment-1963659862 > What I want to know is are there any pitfalls in the process of adapting to clickhouse? I don't know that. > I would like to know some specific reasons why clickhouse is not supported, because we are currently doing research and implementation in this area to avoid taking some detours The only reason is what I mentioned. No one shows up to say they will implement it and maintain the implementation to make sure it is product ready. > Do I only need to implement storage-clickhouse-plugin to use clickhouse storage? Do you still need to do a deeper transformation? I have no idea about the clickhouse. From the design perspective, SkyWalking exposes the module APIs for making implementation easier. So, yes, we hope you only need to implement that. The reality is on the other side, sometimes, you will need annotations or some advanced flags on the kernel level to make the performance good. You can see Elasticsearch and JDBC relative flags are in the core module codes. ___ So, you can see, every time, clickhouse relative discussions fall into the same hole. People want me or someone in the SkyWalking maintenance team to tell, but the truth is we as a group neither know the clickhouse, nor use it. So, there is no magic and short path. You have to understand both SkyWalking OAP kernel/details and the features of ClickHouse, and write design, coding and run performance tests to prove that this new storage option really is good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] very much hope skywalking supports clickhouse [skywalking]
sglztc commented on issue #11924: URL: https://github.com/apache/skywalking/issues/11924#issuecomment-1963636488 > > What is the specific reason why clickhouse storage is not supported? Are there any pitfalls in this area so that I can avoid it when designing? Very much looking forward to the author's answer. > > I think I have said this very clearly. There isn't a thing about `why`. No one is actually contributing and maintaining this in the upstream. Do you know who wants to do this? You said we rejected something, but we didn't. Hello, teacher wu-sheng, you have misunderstood me. What I want to know is are there any pitfalls in the process of adapting to clickhouse? I would like to know some specific reasons why clickhouse is not supported, because we are currently doing research and implementation in this area to avoid taking some detours. Do I only need to implement storage-clickhouse-plugin to use clickhouse storage? Do you still need to do a deeper transformation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] very much hope skywalking supports clickhouse [skywalking]
wu-sheng commented on issue #11924: URL: https://github.com/apache/skywalking/issues/11924#issuecomment-1963616443 > What is the specific reason why clickhouse storage is not supported? Are there any pitfalls in this area so that I can avoid it when designing? Very much looking forward to the author's answer. I think I have said this very clearly. There isn't a thing about `why`. No one is actually contributing and maintaining this in the upstream. Do you know who wants to do this? You said we rejected something, but we didn't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] very much hope skywalking supports clickhouse [skywalking]
sglztc commented on issue #11924: URL: https://github.com/apache/skywalking/issues/11924#issuecomment-1963591922 > We have initially implemented some ideas. If you want to have further communication, you can send me an email. Can you share the table design of this piece? We can implement the code ourselves. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] very much hope skywalking supports clickhouse [skywalking]
sglztc commented on issue #11924: URL: https://github.com/apache/skywalking/issues/11924#issuecomment-1963588744 What is the specific reason why clickhouse storage is not supported? Are there any pitfalls in this area so that I can avoid it when designing? Very much looking forward to the author's answer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
