Re: [I] [Bug] [skywalking]
wu-sheng commented on issue #11965: URL: https://github.com/apache/skywalking/issues/11965#issuecomment-1972690415 8.15 is a very old thing. And if you have plugin issues to discuss, open a discussion rather than an issue. SkyWalking maintainer is not keeping eyes on all plugins. It is impossible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] [skywalking]
wu-sheng closed issue #11965: [Bug] URL: https://github.com/apache/skywalking/issues/11965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] [skywalking]
sun8782525 opened a new issue, #11965: URL: https://github.com/apache/skywalking/issues/11965 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component Java Agent (apache/skywalking-java) ### What happened skywalking-agent-8.15.0 druid-1.1.16 ERROR 2024-02-29 22:21:45.544 localhost-startStop-1 SkyWalkingAgent : Enhance class com.mysql.jdbc.StatementImpl error. org.apache.skywalking.apm.dependencies.net.bytebuddy.pool.TypePool$Resolution$NoSuchTypeException: Cannot resolve type description for com.navercorp.pinpoint.bootstrap.plugin.jdbc.DatabaseInfoAccessor at org.apache.skywalking.apm.dependencies.net.bytebuddy.pool.TypePool$Resolution$Illegal.resolve(TypePool.java:167) at org.apache.skywalking.apm.dependencies.net.bytebuddy.pool.TypePool$Default$WithLazyResolution$LazyTypeDescription.delegate(TypePool.java:1088) at org.apache.skywalking.apm.dependencies.net.bytebuddy.description.type.TypeDescription$AbstractBase$OfSimpleType$WithDelegation.getInterfaces(TypeDescription.java:8442) at org.apache.skywalking.apm.dependencies.net.bytebuddy.description.type.TypeDescription$Generic$OfNonGenericType.getInterfaces(TypeDescription.java:3693) at org.apache.skywalking.apm.agent.core.plugin.match.HierarchyMatch.matchHierarchyClass(HierarchyMatch.java:88) at org.apache.skywalking.apm.agent.core.plugin.match.HierarchyMatch.isMatch(HierarchyMatch.java:71) at org.apache.skywalking.apm.agent.core.plugin.PluginFinder.find(PluginFinder.java:83) at org.apache.skywalking.apm.agent.SkyWalkingAgent$Transformer.transform(SkyWalkingAgent.java:164) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.doTransform(AgentBuilder.java:12104) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.transform(AgentBuilder.java:12041) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.access$1800(AgentBuilder.java:11758) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer$LegacyVmDispatcher.run(AgentBuilder.java:12441) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer$LegacyVmDispatcher.run(AgentBuilder.java:12381) at java.security.AccessController.doPrivileged(Native Method) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.doPrivileged(AgentBuilder.java) at org.apache.skywalking.apm.dependencies.net.bytebuddy.agent.builder.AgentBuilder$Default$ExecutingTransformer.transform(AgentBuilder.java:11950) at sun.instrument.TransformerManager.transform(TransformerManager.java:188) at sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java:428) at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:756) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) at java.net.URLClassLoader.defineClass(URLClassLoader.java:473) at java.net.URLClassLoader.access$100(URLClassLoader.java:74) at java.net.URLClassLoader$1.run(URLClassLoader.java:369) at java.net.URLClassLoader$1.run(URLClassLoader.java:363) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:362) at java.lang.ClassLoader.loadClass(ClassLoader.java:418) at java.lang.ClassLoader.loadClass(ClassLoader.java:351) at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:756) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) at java.net.URLClassLoader.defineClass(URLClassLoader.java:473) at java.net.URLClassLoader.access$100(URLClassLoader.java:74) at java.net.URLClassLoader$1.run(URLClassLoader.java:369) at java.net.URLClassLoader$1.run(URLClassLoader.java:363) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:362) at java.lang.ClassLoader.loadClass(ClassLoader.java:418) at java.lang.ClassLoader.loadClass(ClassLoader.java:351) at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:756) at
Re: [PR] Add blog:RocketMQ monitoring by skywalking [skywalking-website]
peachisai commented on PR #682: URL: https://github.com/apache/skywalking-website/pull/682#issuecomment-1972590287 > internal I will substitute the graph -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add blog:RocketMQ monitoring by skywalking [skywalking-website]
peachisai commented on PR #682: URL: https://github.com/apache/skywalking-website/pull/682#issuecomment-1972589588 > watermark I will substitute it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add blog:RocketMQ monitoring by skywalking [skywalking-website]
wu-sheng commented on PR #682: URL: https://github.com/apache/skywalking-website/pull/682#issuecomment-1972582715  I can the graph has watermark. Is that a licensed software? Or some internal tool? As an alternative, mermaid should work. Ref to https://raw.githubusercontent.com/apache/skywalking-showcase/main/docs/readme.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add blog:RocketMQ monitoring by skywalking [skywalking-website]
netlify[bot] commented on PR #682: URL: https://github.com/apache/skywalking-website/pull/682#issuecomment-1972552808 ### Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit | d511425ef3e922d248f0de050ae1ab8912af4be6 | | Latest deploy log | https://app.netlify.com/sites/skywalking-website-preview/deploys/65e16b7a40ab4f00086a9aef | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add blog:RocketMQ monitoring by skywalking [skywalking-website]
peachisai opened a new pull request, #682: URL: https://github.com/apache/skywalking-website/pull/682 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [BanyanDB] UI improvement needed in Not Found View [skywalking]
wu-sheng commented on issue #11964: URL: https://github.com/apache/skywalking/issues/11964#issuecomment-1972539684 FYI @hanahmily -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [BanyanDB] UI improvement needed in Not Found View [skywalking]
sivasathyaseeelan opened a new issue, #11964: URL: https://github.com/apache/skywalking/issues/11964 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description ### Issue Not found View is plain and it become difficult for the users to navigate when they land up on this route. ### Relevant Images  ### Solution Adding a navbar and styling this page will create a better user experience ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [X] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch main updated: Added unit test for hash.go in convert package (#393)
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new 2e2fc881 Added unit test for hash.go in convert package (#393)
2e2fc881 is described below
commit 2e2fc881917246627af25ff1b61a24ad0b30a4bf
Author: D N Siva Sathyaseelan
<95441117+sivasathyaseee...@users.noreply.github.com>
AuthorDate: Fri Mar 1 09:53:33 2024 +0530
Added unit test for hash.go in convert package (#393)
Signed-off-by: sivasathyaseeelan
---
pkg/convert/hash_test.go | 66
1 file changed, 66 insertions(+)
diff --git a/pkg/convert/hash_test.go b/pkg/convert/hash_test.go
new file mode 100644
index ..ea46c2a5
--- /dev/null
+++ b/pkg/convert/hash_test.go
@@ -0,0 +1,66 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package convert
+
+import (
+ "testing"
+
+ "github.com/cespare/xxhash"
+)
+
+func TestHash(t *testing.T) {
+ tests := []struct {
+ name string
+ key []byte
+ }{
+ {"EmptyKey", []byte{}},
+ {"NonEmptyKey", []byte("hello")},
+ {"SpecialCharsKey", []byte("!@#$%^&*()_+{}")},
+ {"CustomKey", []byte("test123")},
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ got := Hash(tt.key)
+ want := xxhash.Sum64(tt.key)
+ if got != want {
+ t.Errorf("Hash() = %v, want %v", got, want)
+ }
+ })
+ }
+}
+
+func TestHashStr(t *testing.T) {
+ tests := []struct {
+ name string
+ key string
+ }{
+ {"EmptyKey", ""},
+ {"NonEmptyKey", "hello"},
+ {"SpecialCharsKey", "!@#$%^&*()_+{}"},
+ {"CustomKey", "test123"},
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ got := HashStr(tt.key)
+ want := xxhash.Sum64String(tt.key)
+ if got != want {
+ t.Errorf("HashStr() = %v, want %v", got, want)
+ }
+ })
+ }
+}
Re: [I] [BanyanDB] some tests are missing in convert package in skywalking-banyandb [skywalking]
hanahmily closed issue #11942: [BanyanDB] some tests are missing in convert package in skywalking-banyandb URL: https://github.com/apache/skywalking/issues/11942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added unit test for hash.go in convert package [skywalking-banyandb]
hanahmily merged PR #393: URL: https://github.com/apache/skywalking-banyandb/pull/393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-java-client) branch jdk11-build deleted (was da0285b)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch jdk11-build in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git was da0285b Rename tasks. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(skywalking-banyandb-java-client) branch main updated: Support JDK21 build and fix wrong queue size (#52)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
The following commit(s) were added to refs/heads/main by this push:
new ac48297 Support JDK21 build and fix wrong queue size (#52)
ac48297 is described below
commit ac48297052b49fc64733b7a00a82739a7068e089
Author: 吴晟 Wu Sheng
AuthorDate: Fri Mar 1 09:55:22 2024 +0800
Support JDK21 build and fix wrong queue size (#52)
* * Fix the number of channel and the channel size in the
BulkWriteProcessor.
* Support JDK21 build. Upgrade lombok version to 1.18.30.
---
.github/workflows/ci.yaml| 4 ++--
CHANGES.md | 12
pom.xml | 2 +-
.../skywalking/banyandb/v1/client/BulkWriteProcessor.java| 2 +-
4 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index efe9ef8..41bc00b 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -55,13 +55,13 @@ jobs:
uses:
apache/skywalking-eyes/dependency@20da317d1ad158e79e24355fdc28f53370e94c8a
build:
-name: JDK ${{ matrix.java-version }}
+name: JDK ${{ matrix.version }} Build and Test
needs: [ check-license-header ]
runs-on: ubuntu-latest
timeout-minutes: 30
strategy:
matrix:
-version: [ 8, 11, 17 ]
+version: [ 8, 11, 17, 21 ]
steps:
- uses: actions/checkout@v3
with:
diff --git a/CHANGES.md b/CHANGES.md
index f17ab8f..e0880fc 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -2,6 +2,18 @@ Changes by Version
==
Release Notes.
+0.6.0
+--
+
+### Features
+
+* Support JDK21 build. Upgrade lombok version to 1.18.30.
+
+### Bugs
+
+* Fix the number of channel and the channel size in the BulkWriteProcessor.
+
+
0.5.0
--
diff --git a/pom.xml b/pom.xml
index 617252e..1f1d3bb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -77,7 +77,7 @@
6.18
4.13.2
4.8.0
-1.18.22
+1.18.30
1.10.19
diff --git
a/src/main/java/org/apache/skywalking/banyandb/v1/client/BulkWriteProcessor.java
b/src/main/java/org/apache/skywalking/banyandb/v1/client/BulkWriteProcessor.java
index 2fda151..1bbc1eb 100644
---
a/src/main/java/org/apache/skywalking/banyandb/v1/client/BulkWriteProcessor.java
+++
b/src/main/java/org/apache/skywalking/banyandb/v1/client/BulkWriteProcessor.java
@@ -47,7 +47,7 @@ public abstract class BulkWriteProcessor implements Closeable
{
*/
protected BulkWriteProcessor(String processorName, int maxBulkSize, int
flushInterval, int concurrency) {
this.flushInterval = flushInterval;
-this.buffer = new DataCarrier(processorName, maxBulkSize, concurrency);
+this.buffer = new DataCarrier(processorName, concurrency, maxBulkSize);
Properties properties = new Properties();
properties.put("maxBulkSize", maxBulkSize);
properties.put("flushInterval", flushInterval);
Re: [PR] Support JDK21 build and fix wrong queue size [skywalking-banyandb-java-client]
wu-sheng merged PR #52: URL: https://github.com/apache/skywalking-banyandb-java-client/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-java-client) branch jdk11-build updated (09c22a2 -> da0285b)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch jdk11-build in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git from 09c22a2 * Fix the number of channel and the channel size in the BulkWriteProcessor. * Support JDK21 build. Upgrade lombok version to 1.18.30. add da0285b Rename tasks. No new revisions were added by this update. Summary of changes: .github/workflows/ci.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Re: [PR] Support JDK21 build and fix wrong queue size [skywalking-banyandb-java-client]
wu-sheng closed pull request #52: Support JDK21 build and fix wrong queue size URL: https://github.com/apache/skywalking-banyandb-java-client/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [feature-WIP] add support for Pulsar [skywalking-go]
mrproliu commented on code in PR #173:
URL: https://github.com/apache/skywalking-go/pull/173#discussion_r1508380183
##
plugins/pulsar/pulsar/receive_consumer.go:
##
@@ -0,0 +1,70 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package pulsar
+
+import (
+ "github.com/apache/pulsar-client-go/pulsar"
+
+ "github.com/apache/skywalking-go/plugins/core/operator"
+ "github.com/apache/skywalking-go/plugins/core/tracing"
+)
+
+const (
+ pulsarReceivePrefix = "Pulsar/"
+ pulsarReceiveSuffix = "/Consumer"
+ pulsarReceiveComponentID = 74
+)
+
+type ReceiveInterceptor struct {
+}
+
+func (r *ReceiveInterceptor) BeforeInvoke(invocation operator.Invocation)
error {
+ return nil
+}
+
+func (r *ReceiveInterceptor) AfterInvoke(invocation operator.Invocation,
result ...interface{}) error {
+ nativeConsumer := invocation.CallerInstance().(*nativeconsumer)
+ topic := nativeConsumer.options.Topic
+ lookup, err := nativeConsumer.client.lookupService.Lookup(topic)
+ if err != nil {
+ return err
+ }
+ message := result[0].(pulsar.Message)
+ peer := lookup.PhysicalAddr.String()
+ operationName := pulsarReceivePrefix + topic + pulsarReceiveSuffix
+
+ span, err := tracing.CreateEntrySpan(operationName, func(headerKey
string) (string, error) {
Review Comment:
Why we don't move `CreateEntrySpan` to the `BeforeInvoke`? It looks like we
created a span and stopped them quickly.
##
test/plugins/scenarios/pulsar/config/excepted.yml:
##
@@ -0,0 +1,142 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+segmentItems:
+ - serviceName: pulsar
+segmentSize: 4
+segments:
+ - segmentId: not null
+spans:
+ - operationName: GET:/health
+parentSpanId: -1
+spanId: 0
+spanLayer: Http
+startTime: nq 0
+endTime: nq 0
+componentId: 5004
+isError: false
+spanType: Entry
+peer: ''
+skipAnalysis: false
+tags:
+ - { key: http.method, value: GET }
+ - { key: url, value: 'service:8080/health' }
+ - { key: status_code, value: '200' }
+ - segmentId: not null
+spans:
+ - operationName: Pulsar/sw-topic-1/Producer
+parentSpanId: 0
+spanId: 1
+spanLayer: MQ
+startTime: nq 0
+endTime: nq 0
+componentId: 73
+isError: false
+spanType: Exit
+peer: pulsar://pulsar-server:6650
+skipAnalysis: false
+tags:
+ - { key: mq.broker, value: not null }
+ - { key: mq.topic, value: not null }
+ - { key: mq.msg.id, value: not null }
+ - operationName: Pulsar/sw-topic-1/Consumer
+parentSpanId: 0
Review Comment:
Why the consumer parent span id is `0`(span `GET:/execute`), I think It
should be `Pulsar/sw-topic-1/Producer`. Am I right?
##
test/plugins/scenarios/pulsar/config/excepted.yml:
##
@@ -0,0 +1,142 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the
[PR] Support JDK21 build and fix wrong queue size [skywalking-banyandb-java-client]
wu-sheng opened a new pull request, #52: URL: https://github.com/apache/skywalking-banyandb-java-client/pull/52 * Support JDK21 build. Upgrade lombok version to 1.18.30. * * Fix the number of channel and the channel size in the BulkWriteProcessor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-java-client) branch jdk11-build created (now 09c22a2)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch jdk11-build in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git at 09c22a2 * Fix the number of channel and the channel size in the BulkWriteProcessor. * Support JDK21 build. Upgrade lombok version to 1.18.30. This branch includes the following new commits: new 09c22a2 * Fix the number of channel and the channel size in the BulkWriteProcessor. * Support JDK21 build. Upgrade lombok version to 1.18.30. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(skywalking-banyandb-java-client) 01/01: * Fix the number of channel and the channel size in the BulkWriteProcessor. * Support JDK21 build. Upgrade lombok version to 1.18.30.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch jdk11-build
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
commit 09c22a294cc8034e249b52c00f4209a49fd0d87a
Author: Wu Sheng
AuthorDate: Fri Mar 1 09:37:38 2024 +0800
* Fix the number of channel and the channel size in the BulkWriteProcessor.
* Support JDK21 build. Upgrade lombok version to 1.18.30.
---
CHANGES.md | 12
pom.xml | 2 +-
.../skywalking/banyandb/v1/client/BulkWriteProcessor.java| 2 +-
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/CHANGES.md b/CHANGES.md
index f17ab8f..e0880fc 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -2,6 +2,18 @@ Changes by Version
==
Release Notes.
+0.6.0
+--
+
+### Features
+
+* Support JDK21 build. Upgrade lombok version to 1.18.30.
+
+### Bugs
+
+* Fix the number of channel and the channel size in the BulkWriteProcessor.
+
+
0.5.0
--
diff --git a/pom.xml b/pom.xml
index 617252e..1f1d3bb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -77,7 +77,7 @@
6.18
4.13.2
4.8.0
-1.18.22
+1.18.30
1.10.19
diff --git
a/src/main/java/org/apache/skywalking/banyandb/v1/client/BulkWriteProcessor.java
b/src/main/java/org/apache/skywalking/banyandb/v1/client/BulkWriteProcessor.java
index 2fda151..1bbc1eb 100644
---
a/src/main/java/org/apache/skywalking/banyandb/v1/client/BulkWriteProcessor.java
+++
b/src/main/java/org/apache/skywalking/banyandb/v1/client/BulkWriteProcessor.java
@@ -47,7 +47,7 @@ public abstract class BulkWriteProcessor implements Closeable
{
*/
protected BulkWriteProcessor(String processorName, int maxBulkSize, int
flushInterval, int concurrency) {
this.flushInterval = flushInterval;
-this.buffer = new DataCarrier(processorName, maxBulkSize, concurrency);
+this.buffer = new DataCarrier(processorName, concurrency, maxBulkSize);
Properties properties = new Properties();
properties.put("maxBulkSize", maxBulkSize);
properties.put("flushInterval", flushInterval);
Re: [PR] [feature-WIP] add support for Pulsar [skywalking-go]
CodePrometheus commented on PR #173: URL: https://github.com/apache/skywalking-go/pull/173#issuecomment-1972269012 PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added unit test for hash.go in convert package [skywalking-banyandb]
codecov-commenter commented on PR #393: URL: https://github.com/apache/skywalking-banyandb/pull/393#issuecomment-1972163180 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/393?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 48.15%. Comparing base [(`fb543e7`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/fb543e79a0160f65326fc6c4a9a2305b84a1d26d?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`8d22ab9`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/393?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@Coverage Diff @@ ## main #393 +/- ## == + Coverage 48.13% 48.15% +0.02% == Files 173 173 Lines 2150021500 == + Hits1034810353 +5 + Misses 1028510280 -5 Partials 867 867 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/393?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Added unit test for hash.go in convert package [skywalking-banyandb]
sivasathyaseeelan opened a new pull request, #393: URL: https://github.com/apache/skywalking-banyandb/pull/393 ### Fix This PR adds unit test for hash.go in convert package and partially fixes https://github.com/apache/skywalking/issues/11942 - [x] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] banyandb web-ui console error logs [skywalking]
sksDonni commented on issue #11273: URL: https://github.com/apache/skywalking/issues/11273#issuecomment-1971616336 Got it @hanahmily, the error is reproducible when we try to read two different measures. Can you please assign this ticket to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] exception in afterMethod of dubbo3 plugin [skywalking]
wu-sheng closed issue #11962: [Bug] exception in afterMethod of dubbo3 plugin URL: https://github.com/apache/skywalking/issues/11962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] exception in afterMethod of dubbo3 plugin [skywalking]
wu-sheng commented on issue #11962: URL: https://github.com/apache/skywalking/issues/11962#issuecomment-1970787478 Hi, please reach out to the Dubbo community, we accepted this plugin from them and hosted them. But we don't have maintainers watching this specific plugin. I am closing this as it is not a kernel level bug. You could link to this if there is a fix from Dubbo side. Note, I am not saying this should be fixed by Dubbo maintainer, it is that more people are there to watch Dubbo eco relative things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] exception in afterMethod of dubbo3 plugin [skywalking]
focuse8 opened a new issue, #11962:
URL: https://github.com/apache/skywalking/issues/11962
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
Java Agent (apache/skywalking-java)
### What happened
org.apache.skywalking.apm.plugin.asf.dubbo3.DubboInterceptor#afterMethod
don't be executed completely, because exception occurs when responseFuture of
AsyncRpcResult has a exception in Dubbo3 plugin
ERROR 2024-02-20 16:36:12.940 DubboServerHandler-thread-400 InstMethodsInter
: class[class org.apache.dubbo.monitor.support.MonitorClusterFilter] after
method[invoke] intercept failure
org.apache.dubbo.rpc.RpcException: cause: Timeout after 2000ms waiting for
result.
at
org.apache.dubbo.rpc.AsyncRpcResult.getAppResponse(AsyncRpcResult.java:180)
at
org.apache.dubbo.rpc.AsyncRpcResult.getException(AsyncRpcResult.java:131)
at
org.apache.skywalking.apm.plugin.asf.dubbo3.DubboInterceptor.afterMethod(DubboInterceptor.java:118)
at
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:97)
at
org.apache.dubbo.monitor.support.MonitorFilter.invoke(MonitorFilter.java)
at
org.apache.dubbo.rpc.cluster.filter.FilterChainBuilder$CopyOfFilterChainNode.invoke(FilterChainBuilder.java:349)
at
org.apache.dubbo.rpc.cluster.filter.support.MetricsClusterFilter.invoke(MetricsClusterFilter.java:57)
at
org.apache.dubbo.rpc.cluster.filter.FilterChainBuilder$CopyOfFilterChainNode.invoke(FilterChainBuilder.java:349)
at
org.apache.dubbo.rpc.protocol.dubbo.filter.FutureFilter.invoke(FutureFilter.java:52)
at
org.apache.dubbo.rpc.cluster.filter.FilterChainBuilder$CopyOfFilterChainNode.invoke(FilterChainBuilder.java:349)
at
org.apache.dubbo.rpc.cluster.filter.support.ObservationSenderFilter.invoke(ObservationSenderFilter.java:62)
at
org.apache.dubbo.rpc.cluster.filter.FilterChainBuilder$CopyOfFilterChainNode.invoke(FilterChainBuilder.java:349)
### What you expected to happen
org.apache.skywalking.apm.plugin.asf.dubbo3.DubboInterceptor#afterMethod
should be executed completely, whatever happens
### How to reproduce
step1: app using dubbo3
step2: build a custom filter which wrap exception with AsyncRpcResult and
make the Filter after MonitorFilter. For example
try {
Result result = invoker.invoke(invocation);
return result;
} catch (Throwable e) {
return AsyncRpcResult.newDefaultAsyncResult(e, invocation);
}
step3: make a interface call timeout
### Anything else
public Object afterMethod(EnhancedInstance objInst, Method method, Object[]
allArguments, Class[] argumentsTypes,
Object ret) throws Throwable {
Result result = (Result) ret;
try {
if (result != null && result.getException() != null) {
dealException(result.getException());
}
return ret;
}finally {
ContextManager.stopSpan();
}
}
### Are you willing to submit a pull request to fix on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
notifications-unsubscr...@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] [Blog] Introduce k8s traffic monitoring powered by eBPF [skywalking]
wu-sheng opened a new issue, #11961: URL: https://github.com/apache/skywalking/issues/11961 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description We are going to release v10 in March, and the Rover release plan should be aligned with that too. After that, we should have a blog to show the capabilities of SkyWalking's eBPF agent. @mrproliu Let's discuss this. ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
