Re: [PR] Add trace stress test suit [skywalking-banyandb]
wu-sheng merged PR #422: URL: https://github.com/apache/skywalking-banyandb/pull/422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch test deleted (was 15b72d06)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch test in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was 15b72d06 Add header The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(skywalking-banyandb) branch main updated: Add trace stress test suit (#422)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new dc88130e Add trace stress test suit (#422)
dc88130e is described below
commit dc88130e8d0516c7989734bdeb505e2d92c1ab71
Author: Gao Hongtao
AuthorDate: Sat Mar 23 10:12:28 2024 +0800
Add trace stress test suit (#422)
---
banyand/measure/block.go | 10 +-
banyand/measure/block_metadata.go | 2 +-
banyand/measure/part_iter.go | 9 +-
banyand/measure/part_iter_test.go | 4 +-
banyand/measure/tstable_test.go| 4 +-
banyand/stream/block.go| 9 +-
banyand/stream/block_metadata.go | 2 +-
banyand/stream/part.go | 3 +
banyand/stream/part_iter.go| 9 +-
banyand/stream/part_iter_test.go | 4 +-
banyand/stream/tstable.go | 9 +-
banyand/stream/tstable_test.go | 4 +-
dist/LICENSE | 6 +
.../license-github.com-apache-skywalking-cli.txt | 210
.../license-github.com-cpuguy83-go-md2man-v2.txt | 21 ++
.../license-github.com-machinebox-graphql.txt | 201
.../license-github.com-russross-blackfriday-v2.txt | 29 +++
dist/licenses/license-github.com-urfave-cli-v2.txt | 21 ++
.../license-skywalking.apache.org-repo-goapi.txt | 201
go.mod | 11 +-
go.sum | 38
.../logical/stream/stream_plan_indexscan_local.go | 5 +
pkg/test/query/query.go| 211 +
pkg/test/query/trace.go| 88 +
test/integration/load/load_suite_test.go | 2 +-
test/stress/trace/Makefile | 25 +++
test/stress/trace/docker-compose.yaml | 8 +-
test/stress/trace/log4j2.xml | 8 +-
test/stress/trace/segment.tpl.json | 106 +++
test/stress/trace/trace_suite_test.go | 57 ++
30 files changed, 1275 insertions(+), 42 deletions(-)
diff --git a/banyand/measure/block.go b/banyand/measure/block.go
index b23e8c34..cf3c2eab 100644
--- a/banyand/measure/block.go
+++ b/banyand/measure/block.go
@@ -214,10 +214,6 @@ func (b *block) unmarshalTagFamily(decoder
*encoding.BytesBlockDecoder, tfIndex
}
bigValuePool.Release(bb)
b.tagFamilies[tfIndex].name = name
-
- if len(tagProjection) < 1 {
- return
- }
cc := b.tagFamilies[tfIndex].resizeColumns(len(tagProjection))
for j := range tagProjection {
for i := range cfm.columnMetadata {
@@ -413,7 +409,7 @@ type blockCursor struct {
func (bc *blockCursor) reset() {
bc.idx = 0
bc.p = nil
- bc.bm = blockMetadata{}
+ bc.bm.reset()
bc.minTimestamp = 0
bc.maxTimestamp = 0
bc.tagProjection = bc.tagProjection[:0]
@@ -429,10 +425,10 @@ func (bc *blockCursor) reset() {
bc.fields.reset()
}
-func (bc *blockCursor) init(p *part, bm blockMetadata, queryOpts queryOptions)
{
+func (bc *blockCursor) init(p *part, bm *blockMetadata, queryOpts
queryOptions) {
bc.reset()
bc.p = p
- bc.bm = bm
+ bc.bm.copyFrom(bm)
bc.minTimestamp = queryOpts.minTimestamp
bc.maxTimestamp = queryOpts.maxTimestamp
bc.tagProjection = queryOpts.TagProjection
diff --git a/banyand/measure/block_metadata.go
b/banyand/measure/block_metadata.go
index 91584760..82e44ca1 100644
--- a/banyand/measure/block_metadata.go
+++ b/banyand/measure/block_metadata.go
@@ -186,7 +186,7 @@ func (bm *blockMetadata) unmarshal(src []byte) ([]byte,
error) {
return src, nil
}
-func (bm blockMetadata) less(other blockMetadata) bool {
+func (bm *blockMetadata) less(other *blockMetadata) bool {
if bm.seriesID == other.seriesID {
return bm.timestamps.min < other.timestamps.min
}
diff --git a/banyand/measure/part_iter.go b/banyand/measure/part_iter.go
index aa41f6d1..aef39977 100644
--- a/banyand/measure/part_iter.go
+++ b/banyand/measure/part_iter.go
@@ -35,19 +35,19 @@ import (
type partIter struct {
err error
p*part
+ curBlock *blockMetadata
sids []common.SeriesID
primaryBlockMetadata []primaryBlockMetadata
bms []blockMetadata
compressedPrimaryBuf []byte
primaryBuf []byte
- curBlock blockMetadata
sidIdx int
(skywalking-banyandb) branch test updated (1129c98e -> 15b72d06)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch test in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 1129c98e Add trace stress test add 15b72d06 Add header No new revisions were added by this update. Summary of changes: test/stress/trace/trace_suite_test.go | 17 + 1 file changed, 17 insertions(+)
Re: [PR] Add trace stress test suit [skywalking-banyandb]
codecov-commenter commented on PR #422: URL: https://github.com/apache/skywalking-banyandb/pull/422#issuecomment-2016244884 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/422?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `66.7%` with `8 lines` in your changes are missing coverage. Please review. > Project coverage is 47.66%. Comparing base [(`cde0cc9`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/cde0cc95e62339e700455ed79e3fd8b7913a48af?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`1b5ac71`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/422?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > :exclamation: Current head 1b5ac71 differs from pull request most recent head 1129c98. Consider uploading reports for the commit 1129c98 to get more accurate results | [Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/422?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [banyand/stream/tstable.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/422?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9zdHJlYW0vdHN0YWJsZS5nbw==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/422?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/stream/part.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/422?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9zdHJlYW0vcGFydC5nbw==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/422?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@Coverage Diff @@ ## main #422 +/- ## == - Coverage 48.07% 47.66% -0.42% == Files 175 175 Lines 2164621646 == - Hits1040710317 -90 - Misses 1034810457 +109 + Partials 891 872 -19 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/422?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add trace stress test suit [skywalking-banyandb]
wu-sheng commented on PR #422: URL: https://github.com/apache/skywalking-banyandb/pull/422#issuecomment-2016244425 Please fix CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch test updated (1b5ac714 -> 1129c98e)
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch test
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
discard 1b5ac714 Add trace stress test
add 1129c98e Add trace stress test
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (1b5ac714)
\
N -- N -- N refs/heads/test (1129c98e)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
dist/LICENSE | 6 +
.../license-github.com-apache-skywalking-cli.txt | 9 +++
...> license-github.com-cpuguy83-go-md2man-v2.txt} | 3 +--
...t => license-github.com-machinebox-graphql.txt} | 2 +-
.../license-github.com-russross-blackfriday-v2.txt | 29 ++
...at.txt => license-github.com-urfave-cli-v2.txt} | 4 +--
...> license-skywalking.apache.org-repo-goapi.txt} | 0
7 files changed, 47 insertions(+), 6 deletions(-)
copy LICENSE => dist/licenses/license-github.com-apache-skywalking-cli.txt
(96%)
copy dist/licenses/{license-github.com-xiang90-probing.txt =>
license-github.com-cpuguy83-go-md2man-v2.txt} (97%)
copy dist/licenses/{license-github.com-modern-go-concurrent.txt =>
license-github.com-machinebox-graphql.txt} (99%)
create mode 100644 dist/licenses/license-github.com-russross-blackfriday-v2.txt
copy dist/licenses/{license-github.com-power-devops-perfstat.txt =>
license-github.com-urfave-cli-v2.txt} (95%)
copy dist/licenses/{license-github.com-go-logr-stdr.txt =>
license-skywalking.apache.org-repo-goapi.txt} (100%)
[PR] Add trace stress test suit [skywalking-banyandb]
hanahmily opened a new pull request, #422: URL: https://github.com/apache/skywalking-banyandb/pull/422 Add tracee stress test suite and fix several flaws found by the suite: 1. Create a deep copy of the tag family map data. 2. Decrease snapshot references in the get element query function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch test created (now 1b5ac714)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch test in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at 1b5ac714 Add trace stress test This branch includes the following new commits: new 1b5ac714 Add trace stress test The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(skywalking-banyandb) 01/01: Add trace stress test
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch test
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 1b5ac7143d56929e9ddfcfeee0ef548f6023f003
Author: Gao Hongtao
AuthorDate: Sat Mar 23 00:45:40 2024 +
Add trace stress test
Signed-off-by: Gao Hongtao
---
banyand/measure/block.go | 10 +-
banyand/measure/block_metadata.go | 2 +-
banyand/measure/part_iter.go | 9 +-
banyand/measure/part_iter_test.go | 4 +-
banyand/measure/tstable_test.go| 4 +-
banyand/stream/block.go| 9 +-
banyand/stream/block_metadata.go | 2 +-
banyand/stream/part.go | 3 +
banyand/stream/part_iter.go| 9 +-
banyand/stream/part_iter_test.go | 4 +-
banyand/stream/tstable.go | 9 +-
banyand/stream/tstable_test.go | 4 +-
go.mod | 11 +-
go.sum | 38
.../logical/stream/stream_plan_indexscan_local.go | 5 +
pkg/test/query/query.go| 211 +
pkg/test/query/trace.go| 88 +
test/integration/load/load_suite_test.go | 2 +-
test/stress/trace/Makefile | 25 +++
test/stress/trace/docker-compose.yaml | 8 +-
test/stress/trace/log4j2.xml | 8 +-
test/stress/trace/segment.tpl.json | 106 +++
test/stress/trace/trace_suite_test.go | 40
23 files changed, 569 insertions(+), 42 deletions(-)
diff --git a/banyand/measure/block.go b/banyand/measure/block.go
index b23e8c34..cf3c2eab 100644
--- a/banyand/measure/block.go
+++ b/banyand/measure/block.go
@@ -214,10 +214,6 @@ func (b *block) unmarshalTagFamily(decoder
*encoding.BytesBlockDecoder, tfIndex
}
bigValuePool.Release(bb)
b.tagFamilies[tfIndex].name = name
-
- if len(tagProjection) < 1 {
- return
- }
cc := b.tagFamilies[tfIndex].resizeColumns(len(tagProjection))
for j := range tagProjection {
for i := range cfm.columnMetadata {
@@ -413,7 +409,7 @@ type blockCursor struct {
func (bc *blockCursor) reset() {
bc.idx = 0
bc.p = nil
- bc.bm = blockMetadata{}
+ bc.bm.reset()
bc.minTimestamp = 0
bc.maxTimestamp = 0
bc.tagProjection = bc.tagProjection[:0]
@@ -429,10 +425,10 @@ func (bc *blockCursor) reset() {
bc.fields.reset()
}
-func (bc *blockCursor) init(p *part, bm blockMetadata, queryOpts queryOptions)
{
+func (bc *blockCursor) init(p *part, bm *blockMetadata, queryOpts
queryOptions) {
bc.reset()
bc.p = p
- bc.bm = bm
+ bc.bm.copyFrom(bm)
bc.minTimestamp = queryOpts.minTimestamp
bc.maxTimestamp = queryOpts.maxTimestamp
bc.tagProjection = queryOpts.TagProjection
diff --git a/banyand/measure/block_metadata.go
b/banyand/measure/block_metadata.go
index 91584760..82e44ca1 100644
--- a/banyand/measure/block_metadata.go
+++ b/banyand/measure/block_metadata.go
@@ -186,7 +186,7 @@ func (bm *blockMetadata) unmarshal(src []byte) ([]byte,
error) {
return src, nil
}
-func (bm blockMetadata) less(other blockMetadata) bool {
+func (bm *blockMetadata) less(other *blockMetadata) bool {
if bm.seriesID == other.seriesID {
return bm.timestamps.min < other.timestamps.min
}
diff --git a/banyand/measure/part_iter.go b/banyand/measure/part_iter.go
index aa41f6d1..aef39977 100644
--- a/banyand/measure/part_iter.go
+++ b/banyand/measure/part_iter.go
@@ -35,19 +35,19 @@ import (
type partIter struct {
err error
p*part
+ curBlock *blockMetadata
sids []common.SeriesID
primaryBlockMetadata []primaryBlockMetadata
bms []blockMetadata
compressedPrimaryBuf []byte
primaryBuf []byte
- curBlock blockMetadata
sidIdx int
minTimestamp int64
maxTimestamp int64
}
func (pi *partIter) reset() {
- pi.curBlock = blockMetadata{}
+ pi.curBlock = nil
pi.p = nil
pi.sids = nil
pi.sidIdx = 0
@@ -60,6 +60,7 @@ func (pi *partIter) reset() {
func (pi *partIter) init(bma *blockMetadataArray, p *part, sids
[]common.SeriesID, minTimestamp, maxTimestamp int64) {
pi.reset()
+ pi.curBlock = {}
pi.p = p
pi.bms = bma.arr
@@ -227,7 +228,7 @@ func (pi *partIter) findBlock() bool {
continue
}
-
(skywalking) branch wu-sheng-patch-1 deleted (was 2386df017b)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git was 2386df017b Rename test.txt to test.java The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Header check test. [skywalking]
wu-sheng closed pull request #12048: Header check test. URL: https://github.com/apache/skywalking/pull/12048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Header check test. [skywalking]
github-actions[bot] commented on code in PR #12048: URL: https://github.com/apache/skywalking/pull/12048#discussion_r1535775785 ## test.java: ## @@ -0,0 +1 @@ +This is only a header validation. Review Comment: ```suggestion /* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. */ This is only a header validation. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch wu-sheng-patch-1 updated (6653f53654 -> 2386df017b)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git from 6653f53654 Header check test. add 2386df017b Rename test.txt to test.java No new revisions were added by this update. Summary of changes: test.txt => test.java | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test.txt => test.java (100%)
(skywalking) branch wu-sheng-patch-1 created (now 6653f53654)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git at 6653f53654 Header check test. No new revisions were added by this update.
[PR] Header check test. [skywalking]
wu-sheng opened a new pull request, #12048: URL: https://github.com/apache/skywalking/pull/12048 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 [skywalking-eyes]
wu-sheng closed pull request #176: Bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 URL: https://github.com/apache/skywalking-eyes/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 [skywalking-eyes]
dependabot[bot] commented on PR #176: URL: https://github.com/apache/skywalking-eyes/pull/176#issuecomment-2015086355 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch asf-site updated: deploy: d73670627d5a4050b787029081df196d992ee925
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 8df8463454e deploy: d73670627d5a4050b787029081df196d992ee925
8df8463454e is described below
commit 8df8463454e018bca3252ba1ec4064d8298f142c
Author: wu-sheng
AuthorDate: Fri Mar 22 12:42:08 2024 +
deploy: d73670627d5a4050b787029081df196d992ee925
---
contributors/index.html | 26 --
index.html | 2 +-
index.json | 2 +-
team/index.html | 14 --
4 files changed, 34 insertions(+), 10 deletions(-)
diff --git a/contributors/index.html b/contributors/index.html
index a78aab998d6..ea8ef0f9ba9 100644
--- a/contributors/index.html
+++ b/contributors/index.html
@@ -21697,6 +21697,20 @@
+
+
+https://github.com/gdams;
target="_blank">
+
+ gdams
+
+
+
+1
+31
+
+
+
+
https://github.com/FushuWang;
target="_blank">
@@ -21706,7 +21720,7 @@
1
-31
+32
@@ -21720,7 +21734,7 @@
1
-32
+33
@@ -21734,7 +21748,7 @@
1
-33
+34
@@ -21748,7 +21762,7 @@
1
-34
+35
@@ -21762,7 +21776,7 @@
1
-35
+36
@@ -21776,7 +21790,7 @@
1
-36
+37
diff --git a/index.html b/index.html
index a35063e1a1b..2e36f06a7a7 100644
--- a/index.html
+++ b/index.html
@@ -213,7 +213,7 @@
COMMUNITY
- SkyWalking has received contributions from 870 individuals now.
+ SkyWalking has received contributions from 871 individuals now.
diff --git a/index.json b/index.json
index a4e74a484e0..59e8abff4ed 100644
--- a/index.json
+++ b/index.json
@@ -1 +1 @@
-[{"body":"Background Apache SkyWalking is an open-source Application
Performance Management system that helps users gather logs, traces, metrics,
and events from various platforms and display them on the UI. With version
9.7.0, SkyWalking can collect access logs from probes in multiple languages and
from Service Mesh, generating corresponding topologies, tracing, and other
data. However, it could not initially collect and map access logs from
applications in Kubernetes environments. This [...]
\ No newline at end of file
+[{"body":"Background Apache SkyWalking is an open-source Application
Performance Management system that helps users gather logs, traces, metrics,
and events from various platforms and display them on the UI. With version
9.7.0, SkyWalking can collect access logs from probes in multiple languages and
from Service Mesh, generating corresponding topologies, tracing, and other
data. However, it could not initially collect and map access logs from
applications in Kubernetes environments. This [...]
\ No newline at end of file
diff --git a/team/index.html b/team/index.html
index d355b67c0a4..ed34d0fb271 100644
--- a/team/index.html
+++ b/team/index.html
@@ -570,7 +570,7 @@ The SkyWalking team is comprised of Members and
Contributors, and the growth has
Contributors
-870
+871
@@ -15786,7 +15786,7 @@ The SkyWalking team is comprised of Members and
Contributors, and the growth has
- 36
+ 37
@@ -16095,6 +16095,16 @@ The SkyWalking team is comprised of Members and
Contributors, and the growth has
+
+
+https://github.com/gdams; target="_blank">
+
+ gdams
+
+
+
+
+
Re: [PR] add Eclipse Foundation specific Apache 2.0 license header [skywalking-eyes]
wu-sheng merged PR #178: URL: https://github.com/apache/skywalking-eyes/pull/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] add Eclipse Foundation specific Apache 2.0 license header [skywalking-eyes]
gdams opened a new pull request, #178: URL: https://github.com/apache/skywalking-eyes/pull/178 As per the [Eclipse Project Handbook](https://www.eclipse.org/projects/handbook/#ip-copyright-headers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support across thread tracing for SOFA-RPC [skywalking-java]
wu-sheng commented on code in PR #675:
URL: https://github.com/apache/skywalking-java/pull/675#discussion_r1535110614
##
apm-sniffer/apm-sdk-plugin/sofarpc-plugin/src/main/java/org/apache/skywalking/apm/plugin/sofarpc/SofaBoltCallbackConstructInterceptor.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.sofarpc;
+
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
+
+public class SofaBoltCallbackConstructInterceptor implements
InstanceConstructorInterceptor {
+@Override
+public void onConstruct(EnhancedInstance objInst, Object[] allArguments) {
+if (ContextManager.isActive()) {
+objInst.setSkyWalkingDynamicField(ContextManager.capture());
Review Comment:
Classloader doesn't need to be worried, AFAIK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support across thread tracing for SOFA-RPC [skywalking-java]
wu-sheng commented on code in PR #675:
URL: https://github.com/apache/skywalking-java/pull/675#discussion_r1535106660
##
apm-sniffer/apm-sdk-plugin/sofarpc-plugin/src/main/java/org/apache/skywalking/apm/plugin/sofarpc/SofaBoltCallbackConstructInterceptor.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.sofarpc;
+
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
+
+public class SofaBoltCallbackConstructInterceptor implements
InstanceConstructorInterceptor {
+@Override
+public void onConstruct(EnhancedInstance objInst, Object[] allArguments) {
+if (ContextManager.isActive()) {
+objInst.setSkyWalkingDynamicField(ContextManager.capture());
Review Comment:
> I plan to create a class InvokeCallbackWrapper in plugin code. How to make
it loaded by business classloader?
All plugin interceptor relative codes are loaded in your target class
loader, otherwise, all existing logic will fail. I think in this case, users of
SOFA would not be aware of the wrapper, as it is only running internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Support across thread tracing for SOFA-RPC [skywalking-java]
OrezzerO commented on code in PR #675:
URL: https://github.com/apache/skywalking-java/pull/675#discussion_r1535104439
##
apm-sniffer/apm-sdk-plugin/sofarpc-plugin/src/main/java/org/apache/skywalking/apm/plugin/sofarpc/SofaBoltCallbackConstructInterceptor.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.sofarpc;
+
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
+
+public class SofaBoltCallbackConstructInterceptor implements
InstanceConstructorInterceptor {
+@Override
+public void onConstruct(EnhancedInstance objInst, Object[] allArguments) {
+if (ContextManager.isActive()) {
+objInst.setSkyWalkingDynamicField(ContextManager.capture());
Review Comment:
In the context of SOFARPC, InvokeCallback is a wrapper. Users directly use
the SofaResponseCallback class. Each SOFARPC callback request corresponds
uniquely to an InvokeCallback.
However, in the context of SOFA BOLT (BOLT being a wrapper for Netty which
SOFARPC relies on), InvokeCallback may be reused.
It's a good idea to create a plugin level wrapper, but I am afraid I will
introduce an error because of cannot dealing with classloader correctly.
I plan to create a class `InvokeCallbackWrapper` in plugin code. How to make
it loaded by business classloader?
```java
public class InvokeCallbackWrapper implements InvokeCallback {
private ContextSnapshot contextSnapshot;
private InvokeCallback invokeCallback;
public InvokeCallbackWrapper(InvokeCallback invokeCallback) {
this.contextSnapshot = ContextManager.capture();
this.invokeCallback = invokeCallback;
}
@Override
public void onResponse(final Object o) {
ContextManager.createLocalSpan("Thread/" +
invokeCallback.getClass().getName() + "/onResponse");
if (contextSnapshot != null) {
ContextManager.continued(contextSnapshot);
}
try {
invokeCallback.onResponse(o);
} catch (Throwable t) {
ContextManager.activeSpan().log(t);
throw t;
} finally {
ContextManager.stopSpan();
contextSnapshot = null;
}
}
@Override
public void onException(final Throwable throwable) {
ContextManager.createLocalSpan("Thread/" +
invokeCallback.getClass().getName() + "/onException");
if (contextSnapshot != null) {
ContextManager.continued(contextSnapshot);
}
if (throwable != null) {
AbstractSpan abstractSpan = ContextManager.activeSpan();
if (abstractSpan != null) {
abstractSpan.log(throwable);
}
}
try {
invokeCallback.onException(throwable);
} catch (Throwable t) {
ContextManager.activeSpan().log(t);
throw t;
} finally {
ContextManager.stopSpan();
contextSnapshot = null;
}
}
@Override
public Executor getExecutor() {
return invokeCallback.getExecutor();
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
