(skywalking) branch polish-faq deleted (was 158272867b)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch polish-faq in repository https://gitbox.apache.org/repos/asf/skywalking.git was 158272867b Polish The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(skywalking) branch master updated: Add a FAQ about other storage options. (#12059)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 3794b3dc91 Add a FAQ about other storage options. (#12059) 3794b3dc91 is described below commit 3794b3dc91022c8847672b88f758cf80c2782d11 Author: 吴晟 Wu Sheng AuthorDate: Fri Mar 29 11:55:18 2024 +0800 Add a FAQ about other storage options. (#12059) --- docs/en/FAQ/README.md | 3 ++- docs/en/FAQ/why-clickhouse-not-supported.md | 38 + docs/en/FAQ/why_mq_not_involved.md | 4 +-- docs/en/changes/changes.md | 1 + 4 files changed, 43 insertions(+), 3 deletions(-) diff --git a/docs/en/FAQ/README.md b/docs/en/FAQ/README.md index ed43bbf49a..09329589f2 100644 --- a/docs/en/FAQ/README.md +++ b/docs/en/FAQ/README.md @@ -2,7 +2,8 @@ These are known and frequently asked questions about SkyWalking. We welcome you to contribute here. ## Design -* [Why doesn't SkyWalking involve MQ in its architecture?](why_mq_not_involved.md) +* [Why does SkyWalking use RPC(gRPC and RESTful) rather than MQ as transport layer by default?](why_mq_not_involved.md) +* [Why is Clickhouse or Loki or xxx not supported as a storage option?](why-clickhouse-not-supported.md) ## Compiling * [Protoc plugin fails in maven build](Protoc-Plugin-Fails-When-Build.md) diff --git a/docs/en/FAQ/why-clickhouse-not-supported.md b/docs/en/FAQ/why-clickhouse-not-supported.md new file mode 100644 index 00..dc85e296c3 --- /dev/null +++ b/docs/en/FAQ/why-clickhouse-not-supported.md @@ -0,0 +1,38 @@ +# Why is Clickhouse or Loki or xxx not supported as a storage option? + +## Background + +In the past several years, community users have asked why Clickhouse, Loki, or some other storage is not supported in the upstream. We have repeated the answer many times, but it is still happening, at here, I would like to write down the summary to help people understand more + +## Previous Discussions +All the following issues were about discussing new storage extension topics. +- Loki as storage +- https://github.com/apache/skywalking/discussions/9836 +- ClickHouse +- https://github.com/apache/skywalking/issues/11924 +- https://github.com/apache/skywalking/discussions/9011 +- Vertica +- https://github.com/apache/skywalking/discussions/8817 + +Generally, all those asking are about adding a new kind of storage. + +## Why they don't exist ? +First of all, `WHY` is not a suitable question. SkyWalking is a volunteer-driven community, the volunteers build this project including bug fixes, maintenance work, and new features from their personal and employer interests. What you saw about the current status is the combination of all those interests rather than responsibilities. +So, in SkyWalking, anything you saw existing is/was someone's interest and contributed to upstream. + +This logic is the same as this question, SkyWalking active maintainers are focusing on JDBC(MySQL and PostgreSQL ecosystem) Database and Elasticsearch for existing users, and moving forward on BanyanDB as the native one. We for now don't have people interested in ClickHouse or any other database. That is why they are not there. + +## How could add one? +To add a new feature, including a new storage plugin, you should go through [SWIP - SkyWalking Improvement Proposal](https://skywalking.apache.org/docs/main/next/en/swip/readme/) workflow, and have a full discussion with the maintenance team. +SkyWalking has a pluggable storage system, so, ideally new storage option is possible to implement a new provider for the storage module. Meanwhile, in practice, as storage implementation should be in high performance and well optimized, considering our experiences with JDBC and Elasticsearch implementations, some flags and annotations may need to be added in the kernel level and data model declarations. + +Furthermore, as current maintainers are not a fun of Clickhouse or others(otherwise, you should have seen those implementations), they are not going to be involved in the code implementations and they don't know much more from a general perspective about which kind of implementation in that specific database will have a better behavior and performance. So, if you want to propose this to upstream, you should be very experienced in that database, and have enough scale and environments to p [...] + +## What happens next if the new implementation gets accepted/merged/released? +Who proposed this new implementation(such as clickhouse storage), has to take the responsibilities of the maintenance. The maintenance means they need to +1. Join storage relative discussion to make sure SkyWalking can move forward on a kernel-level optimization without being blocked by these specific storage options. +2. Respond to this storage
Re: [PR] Add a FAQ about other storage options. [skywalking]
wu-sheng merged PR #12059: URL: https://github.com/apache/skywalking/pull/12059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch polish-faq updated (65a55286cf -> 158272867b)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch polish-faq in repository https://gitbox.apache.org/repos/asf/skywalking.git from 65a55286cf Add a FAQ about other storage options. add 158272867b Polish No new revisions were added by this update. Summary of changes: docs/en/FAQ/why_mq_not_involved.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[PR] Add a FAQ about other storage options. [skywalking]
wu-sheng opened a new pull request, #12059: URL: https://github.com/apache/skywalking/pull/12059 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch polish-faq created (now 65a55286cf)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch polish-faq in repository https://gitbox.apache.org/repos/asf/skywalking.git at 65a55286cf Add a FAQ about other storage options. This branch includes the following new commits: new 65a55286cf Add a FAQ about other storage options. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(skywalking) 01/01: Add a FAQ about other storage options.
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch polish-faq in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 65a55286cf4f3de8d69aa40a99b5bba538db689b Author: Wu Sheng AuthorDate: Fri Mar 29 11:50:31 2024 +0800 Add a FAQ about other storage options. --- docs/en/FAQ/README.md | 3 ++- docs/en/FAQ/why-clickhouse-not-supported.md | 38 + docs/en/FAQ/why_mq_not_involved.md | 2 +- docs/en/changes/changes.md | 1 + 4 files changed, 42 insertions(+), 2 deletions(-) diff --git a/docs/en/FAQ/README.md b/docs/en/FAQ/README.md index ed43bbf49a..09329589f2 100644 --- a/docs/en/FAQ/README.md +++ b/docs/en/FAQ/README.md @@ -2,7 +2,8 @@ These are known and frequently asked questions about SkyWalking. We welcome you to contribute here. ## Design -* [Why doesn't SkyWalking involve MQ in its architecture?](why_mq_not_involved.md) +* [Why does SkyWalking use RPC(gRPC and RESTful) rather than MQ as transport layer by default?](why_mq_not_involved.md) +* [Why is Clickhouse or Loki or xxx not supported as a storage option?](why-clickhouse-not-supported.md) ## Compiling * [Protoc plugin fails in maven build](Protoc-Plugin-Fails-When-Build.md) diff --git a/docs/en/FAQ/why-clickhouse-not-supported.md b/docs/en/FAQ/why-clickhouse-not-supported.md new file mode 100644 index 00..dc85e296c3 --- /dev/null +++ b/docs/en/FAQ/why-clickhouse-not-supported.md @@ -0,0 +1,38 @@ +# Why is Clickhouse or Loki or xxx not supported as a storage option? + +## Background + +In the past several years, community users have asked why Clickhouse, Loki, or some other storage is not supported in the upstream. We have repeated the answer many times, but it is still happening, at here, I would like to write down the summary to help people understand more + +## Previous Discussions +All the following issues were about discussing new storage extension topics. +- Loki as storage +- https://github.com/apache/skywalking/discussions/9836 +- ClickHouse +- https://github.com/apache/skywalking/issues/11924 +- https://github.com/apache/skywalking/discussions/9011 +- Vertica +- https://github.com/apache/skywalking/discussions/8817 + +Generally, all those asking are about adding a new kind of storage. + +## Why they don't exist ? +First of all, `WHY` is not a suitable question. SkyWalking is a volunteer-driven community, the volunteers build this project including bug fixes, maintenance work, and new features from their personal and employer interests. What you saw about the current status is the combination of all those interests rather than responsibilities. +So, in SkyWalking, anything you saw existing is/was someone's interest and contributed to upstream. + +This logic is the same as this question, SkyWalking active maintainers are focusing on JDBC(MySQL and PostgreSQL ecosystem) Database and Elasticsearch for existing users, and moving forward on BanyanDB as the native one. We for now don't have people interested in ClickHouse or any other database. That is why they are not there. + +## How could add one? +To add a new feature, including a new storage plugin, you should go through [SWIP - SkyWalking Improvement Proposal](https://skywalking.apache.org/docs/main/next/en/swip/readme/) workflow, and have a full discussion with the maintenance team. +SkyWalking has a pluggable storage system, so, ideally new storage option is possible to implement a new provider for the storage module. Meanwhile, in practice, as storage implementation should be in high performance and well optimized, considering our experiences with JDBC and Elasticsearch implementations, some flags and annotations may need to be added in the kernel level and data model declarations. + +Furthermore, as current maintainers are not a fun of Clickhouse or others(otherwise, you should have seen those implementations), they are not going to be involved in the code implementations and they don't know much more from a general perspective about which kind of implementation in that specific database will have a better behavior and performance. So, if you want to propose this to upstream, you should be very experienced in that database, and have enough scale and environments to p [...] + +## What happens next if the new implementation gets accepted/merged/released? +Who proposed this new implementation(such as clickhouse storage), has to take the responsibilities of the maintenance. The maintenance means they need to +1. Join storage relative discussion to make sure SkyWalking can move forward on a kernel-level optimization without being blocked by these specific storage options. +2. Respond to this storage relative questions, bugs, CVEs, and performance issues. +3. Make the implementation performance match the expectation of the original proposal. Such as, about clickhouse, people
Re: [I] [Bug] skywalking-backend-js :: i use "mongoose": "^8.2.2", got error: Error installing plugin mongodb * /usr/src/app/node_modules/skywalking-backend-js/lib/core/PluginInstaller.js [skywalking]
kezhenxu94 closed issue #12038: [Bug] skywalking-backend-js :: i use "mongoose": "^8.2.2", got error: Error installing plugin mongodb * /usr/src/app/node_modules/skywalking-backend-js/lib/core/PluginInstaller.js URL: https://github.com/apache/skywalking/issues/12038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-backend-js :: i use "mongoose": "^8.2.2", got error: Error installing plugin mongodb * /usr/src/app/node_modules/skywalking-backend-js/lib/core/PluginInstaller.js [skywalking]
kezhenxu94 commented on issue #12038:
URL: https://github.com/apache/skywalking/issues/12038#issuecomment-2026550121
```
{
message: 'Error installing plugin mongodb *',
level: 'error',
file:
'/usr/src/app/node_modules/skywalking-backend-js/lib/core/PluginInstaller.js'
}
```
Failing to install `mongodb` plugin is harmless because you are using
mongoose, and I can still get access to MongoDB via mongoose, please check your
code whether works without skywalking.
I can successfully manipulate the MongoDB server with mongoose even the
error occurs.
# Start MongoDB Server
```shell
docker run -it --rm -p 27017:27017 mongo:6
```
# Start SkyWalking OAP
```shell
docker run --name oap -p 11800:11800 apache/skywalking-oap-server:9.7.0
```
# Create npm project
```shell
mkdir repro && cd repro
cat < package.json
{
"name": "mongo",
"version": "1.0.0",
"description": "",
"main": "index.js",
"scripts": {
"dev": "node index.js"
},
"author": "",
"license": "ISC",
"dependencies": {
"mongoose": "^8.2.4",
"skywalking-backend-js": "^0.7.0"
}
}
EOF
cat < index.js
const { default: agent } = require('skywalking-backend-js');
const mongoose = require('mongoose');
agent.start();
main().catch(err => console.log(err));
async function main() {
await mongoose.connect('mongodb://127.0.0.1:27017/test');
const kittySchema = new mongoose.Schema({
name: String
});
const Cat = mongoose.model('Cat', { name: String });
const kitty = new Cat({ name: 'Zildjian' });
kitty.save().then(() => console.log('meow'));
}
EOF
```
# Run the app
```shell
yarn run dev
```
And you'll see `meow` is printed, if you query the mongodb server directly
`db.cats.find()`, you'll see the record is saved into mongodb.
If you want to report further issue, please, provide detailed reproducible
steps like what you see above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(skywalking-client-js) branch master updated: build(deps-dev): bump express from 4.18.2 to 4.19.2 (#124)
This is an automated email from the ASF dual-hosted git repository.
qiuxiafan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-client-js.git
The following commit(s) were added to refs/heads/master by this push:
new 5ebefcc build(deps-dev): bump express from 4.18.2 to 4.19.2 (#124)
5ebefcc is described below
commit 5ebefccb3e41e3f814de79ae66d2dac5e4ea794c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
AuthorDate: Fri Mar 29 09:27:29 2024 +0800
build(deps-dev): bump express from 4.18.2 to 4.19.2 (#124)
---
package-lock.json | 358 ++
1 file changed, 279 insertions(+), 79 deletions(-)
diff --git a/package-lock.json b/package-lock.json
index 13dbe32..17fc478 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -851,13 +851,13 @@
}
},
"node_modules/body-parser": {
- "version": "1.20.1",
- "resolved":
"https://registry.npmjs.org/body-parser/-/body-parser-1.20.1.tgz;,
- "integrity":
"sha512-jWi7abTbYwajOytWCQc37VulmWiRae5RyTpaCyDcS5/lMdtwSz5lOpDE67srw/HYe35f1z3fDQw+3txg7gNtWw==",
+ "version": "1.20.2",
+ "resolved":
"https://registry.npmjs.org/body-parser/-/body-parser-1.20.2.tgz;,
+ "integrity":
"sha512-ml9pReCu3M61kGlqoTm2umSXTlRTuGTx0bfYj+uIUKKYycG5NtSbeetV3faSU6R7ajOPw0g/J1PvK4qNy7s5bA==",
"dev": true,
"dependencies": {
"bytes": "3.1.2",
-"content-type": "~1.0.4",
+"content-type": "~1.0.5",
"debug": "2.6.9",
"depd": "2.0.0",
"destroy": "1.2.0",
@@ -865,7 +865,7 @@
"iconv-lite": "0.4.24",
"on-finished": "2.4.1",
"qs": "6.11.0",
-"raw-body": "2.5.1",
+"raw-body": "2.5.2",
"type-is": "~1.6.18",
"unpipe": "1.0.0"
},
@@ -985,13 +985,19 @@
}
},
"node_modules/call-bind": {
- "version": "1.0.2",
- "resolved": "https://registry.npmjs.org/call-bind/-/call-bind-1.0.2.tgz;,
- "integrity":
"sha512-7O+FbCihrB5WGbFYesctwmTKae6rOiIzmz1icreWJ+0aA7LJfuqhEso2T9ncpcFtzMQtzXf2QGGueWJGTYsqrA==",
+ "version": "1.0.7",
+ "resolved": "https://registry.npmjs.org/call-bind/-/call-bind-1.0.7.tgz;,
+ "integrity":
"sha512-GHTSNSYICQ7scH7sZ+M2rFopRoLh8t2bLSW6BbgrtLsahOIB5iyAVJf9GjWK3cYTDaMj4XdBpM1cA6pIS0Kv2w==",
"dev": true,
"dependencies": {
-"function-bind": "^1.1.1",
-"get-intrinsic": "^1.0.2"
+"es-define-property": "^1.0.0",
+"es-errors": "^1.3.0",
+"function-bind": "^1.1.2",
+"get-intrinsic": "^1.2.4",
+"set-function-length": "^1.2.1"
+ },
+ "engines": {
+"node": ">= 0.4"
},
"funding": {
"url": "https://github.com/sponsors/ljharb;
@@ -1237,9 +1243,9 @@
}
},
"node_modules/cookie": {
- "version": "0.5.0",
- "resolved": "https://registry.npmjs.org/cookie/-/cookie-0.5.0.tgz;,
- "integrity":
"sha512-YZ3GUyn/o8gfKJlnlX7g7xq4gyO6OSuhGPKaaGssGB2qgDUS0gPgtTvoyZLTt9Ab6dC4hfc9dV5arkvc/OCmrw==",
+ "version": "0.6.0",
+ "resolved": "https://registry.npmjs.org/cookie/-/cookie-0.6.0.tgz;,
+ "integrity":
"sha512-U71cyTamuh1CRNCfpGY6to28lxvNwPG4Guz/EVjgf3Jmzv0vlDp1atT9eS5dDjMYHucpHbWns6Lwf3BKz6svdw==",
"dev": true,
"engines": {
"node": ">= 0.6"
@@ -1350,6 +1356,23 @@
"node": ">=10.17.0"
}
},
+"node_modules/define-data-property": {
+ "version": "1.1.4",
+ "resolved":
"https://registry.npmjs.org/define-data-property/-/define-data-property-1.1.4.tgz;,
+ "integrity":
"sha512-rBMvIzlpA8v6E+SJZoo++HAYqsLrkg7MSfIinMPFhmkorw7X+dOXVJQs+QT69zGkzMyfDnIMN2Wid1+NbL3T+A==",
+ "dev": true,
+ "dependencies": {
+"es-define-property": "^1.0.0",
+"es-errors": "^1.3.0",
+"gopd": "^1.0.1"
+ },
+ "engines": {
+"node": ">= 0.4"
+ },
+ "funding": {
+"url": "https://github.com/sponsors/ljharb;
+ }
+},
"node_modules/define-lazy-prop": {
"version": "2.0.0",
"resolved":
"https://registry.npmjs.org/define-lazy-prop/-/define-lazy-prop-2.0.0.tgz;,
@@ -1481,6 +1504,27 @@
"node": ">=4"
}
},
+"node_modules/es-define-property": {
+ "version": "1.0.0",
+ "resolved":
"https://registry.npmjs.org/es-define-property/-/es-define-property-1.0.0.tgz;,
+ "integrity":
"sha512-jxayLKShrEqqzJ0eumQbVhTYQM27CfT1T35+gCgDFoL82JLsXqTJ76zv6A0YLOgEnLUMvLzsDsGIrl8NFpT2gQ==",
+ "dev": true,
+ "dependencies": {
+"get-intrinsic": "^1.2.4"
+ },
+ "engines": {
+"node": ">= 0.4"
+ }
+},
+"node_modules/es-errors": {
+ "version": "1.3.0",
+ "resolved": "https://registry.npmjs.org/es-errors/-/es-errors-1.3.0.tgz;,
+ "integrity":
Re: [PR] build(deps-dev): bump express from 4.18.2 to 4.19.2 [skywalking-client-js]
Fine0830 merged PR #124: URL: https://github.com/apache/skywalking-client-js/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-client-js) branch dependabot/npm_and_yarn/express-4.19.2 deleted (was 0bf2a69)
This is an automated email from the ASF dual-hosted git repository. qiuxiafan pushed a change to branch dependabot/npm_and_yarn/express-4.19.2 in repository https://gitbox.apache.org/repos/asf/skywalking-client-js.git was 0bf2a69 build(deps-dev): bump express from 4.18.2 to 4.19.2 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] feat: add Support for dragging in the trace panel [skywalking-booster-ui]
wu-sheng commented on PR #377: URL: https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2026352991 I think when you apply a new query, the segment list sidebar should be pop up automatically. Otherwise, it is confusing, especially when query without trace ID, it would be a long segment list with various traces. If you don't pop up the segment list, but update a specific trace view, the user may thought there is only one trace, which is most likely not the case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] build(deps-dev): bump express from 4.18.2 to 4.19.2 [skywalking-client-js]
dependabot[bot] opened a new pull request, #124: URL: https://github.com/apache/skywalking-client-js/pull/124 Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. Release notes Sourced from https://github.com/expressjs/express/releases;>express's releases. 4.19.2 What's Changed https://github.com/expressjs/express/commit/0b746953c4bd8e377123527db11f9cd866e39f94;>Improved fix for open redirect allow list bypass Full Changelog: https://github.com/expressjs/express/compare/4.19.1...4.19.2;>https://github.com/expressjs/express/compare/4.19.1...4.19.2 4.19.1 What's Changed Fix ci after location patch by https://github.com/wesleytodd;>@wesleytodd in https://redirect.github.com/expressjs/express/pull/5552;>expressjs/express#5552 fixed un-edited version in history.md for 4.19.0 by https://github.com/wesleytodd;>@wesleytodd in https://redirect.github.com/expressjs/express/pull/5556;>expressjs/express#5556 Full Changelog: https://github.com/expressjs/express/compare/4.19.0...4.19.1;>https://github.com/expressjs/express/compare/4.19.0...4.19.1 4.19.0 What's Changed fix typo in release date by https://github.com/UlisesGascon;>@UlisesGascon in https://redirect.github.com/expressjs/express/pull/5527;>expressjs/express#5527 docs: nominating https://github.com/wesleytodd;>@wesleytodd to be project captian by https://github.com/wesleytodd;>@wesleytodd in https://redirect.github.com/expressjs/express/pull/5511;>expressjs/express#5511 docs: loosen TC activity rules by https://github.com/wesleytodd;>@wesleytodd in https://redirect.github.com/expressjs/express/pull/5510;>expressjs/express#5510 Add note on how to update docs for new release by https://github.com/crandmck;>@crandmck in https://redirect.github.com/expressjs/express/pull/5541;>expressjs/express#5541 https://redirect.github.com/expressjs/express/pull/5551/commits/660ccf5fa33dd0baab069e5c8ddd9ffe7d8bbff1;>Prevent open redirect allow list bypass due to encodeurl Release 4.19.0 by https://github.com/wesleytodd;>@wesleytodd in https://redirect.github.com/expressjs/express/pull/5551;>expressjs/express#5551 New Contributors https://github.com/crandmck;>@crandmck made their first contribution in https://redirect.github.com/expressjs/express/pull/5541;>expressjs/express#5541 Full Changelog: https://github.com/expressjs/express/compare/4.18.3...4.19.0;>https://github.com/expressjs/express/compare/4.18.3...4.19.0 4.18.3 Main Changes Fix routing requests without method deps: body-parser@1.20.2 Fix strict json error message on Node.js 19+ deps: content-type@~1.0.5 deps: raw-body@2.5.2 Other Changes Use https: protocol instead of deprecated git: protocol by https://github.com/vcsjones;>@vcsjones in https://redirect.github.com/expressjs/express/pull/5032;>expressjs/express#5032 build: Node.js@16.18 and Node.js@18.12 by https://github.com/abenhamdine;>@abenhamdine in https://redirect.github.com/expressjs/express/pull/5034;>expressjs/express#5034 ci: update actions/checkout to v3 by https://github.com/armujahid;>@armujahid in https://redirect.github.com/expressjs/express/pull/5027;>expressjs/express#5027 test: remove unused function arguments in params by https://github.com/raksbisht;>@raksbisht in https://redirect.github.com/expressjs/express/pull/5124;>expressjs/express#5124 Remove unused originalIndex from acceptParams by https://github.com/raksbisht;>@raksbisht in https://redirect.github.com/expressjs/express/pull/5119;>expressjs/express#5119 Fixed typos by https://github.com/raksbisht;>@raksbisht in https://redirect.github.com/expressjs/express/pull/5117;>expressjs/express#5117 examples: remove unused params by https://github.com/raksbisht;>@raksbisht in https://redirect.github.com/expressjs/express/pull/5113;>expressjs/express#5113 fix: parameter str is not described in JSDoc by https://github.com/raksbisht;>@raksbisht in https://redirect.github.com/expressjs/express/pull/5130;>expressjs/express#5130 fix: typos in History.md by https://github.com/raksbisht;>@raksbisht in https://redirect.github.com/expressjs/express/pull/5131;>expressjs/express#5131 build : add Node.js@19.7 by https://github.com/abenhamdine;>@abenhamdine in https://redirect.github.com/expressjs/express/pull/5028;>expressjs/express#5028 test: remove unused function arguments in params by https://github.com/raksbisht;>@raksbisht in https://redirect.github.com/expressjs/express/pull/5137;>expressjs/express#5137 ... (truncated) Changelog Sourced from https://github.com/expressjs/express/blob/master/History.md;>express's changelog. 4.19.2 / 2024-03-25 Improved fix for open redirect allow list bypass 4.19.1 / 2024-03-20 Allow passing non-strings to res.location with new encoding handling checks 4.19.0 /
(skywalking-client-js) branch dependabot/npm_and_yarn/express-4.19.2 created (now 0bf2a69)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/express-4.19.2 in repository https://gitbox.apache.org/repos/asf/skywalking-client-js.git at 0bf2a69 build(deps-dev): bump express from 4.18.2 to 4.19.2 No new revisions were added by this update.
Re: [PR] feat: add Support for dragging in the trace panel [skywalking-booster-ui]
CodePrometheus commented on code in PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#discussion_r1543252686
##
src/views/dashboard/related/trace/TraceList.vue:
##
@@ -187,7 +188,7 @@ limitations under the License. -->
}
.list {
-width: 280px;
+width: 100%;
Review Comment:
Added, and I modified the segment list default width to 280.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: add Support for dragging in the trace panel [skywalking-booster-ui]
CodePrometheus commented on PR #377: URL: https://github.com/apache/skywalking-booster-ui/pull/377#issuecomment-2025640139 > The tips are not destroyed. The reason is that when re-rendering, I neglected to remove `.d3-tip`, has been corrected. > And, could you verify how this works when the segment list is collapsed and click the new query? In the following video, please ignore the circle around the mouse, it's my mac's setting. https://github.com/apache/skywalking-booster-ui/assets/66550292/8bea8728-e60e-48f0-9da1-4a5d554e7cf0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: add Support for dragging in the trace panel [skywalking-booster-ui]
CodePrometheus commented on code in PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#discussion_r1543252686
##
src/views/dashboard/related/trace/TraceList.vue:
##
@@ -187,7 +188,7 @@ limitations under the License. -->
}
.list {
-width: 280px;
+width: 100%;
Review Comment:
Added, and I modified the default width to 280.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat: add Support for dragging in the trace panel [skywalking-booster-ui]
CodePrometheus commented on code in PR #377:
URL:
https://github.com/apache/skywalking-booster-ui/pull/377#discussion_r1543251156
##
src/views/dashboard/related/trace/components/D3Graph/Index.vue:
##
@@ -60,6 +61,9 @@ limitations under the License. -->
}
draw();
loading.value = false;
+emitter.on("trace_resize", () => {
Review Comment:
Thank you so much, this is a very convenient way to do dom monitoring,
learned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] add instructions to fix header issues in markdown comment [skywalking-eyes]
wu-sheng merged PR #179: URL: https://github.com/apache/skywalking-eyes/pull/179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch asf-site updated: deploy: 94d2995af8c70d7f9b59e7f4897800e41beeb1a1
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 852b4794d04 deploy: 94d2995af8c70d7f9b59e7f4897800e41beeb1a1
852b4794d04 is described below
commit 852b4794d044fb4445208c030a78a4a3deaf76b7
Author: wu-sheng
AuthorDate: Thu Mar 28 10:05:24 2024 +
deploy: 94d2995af8c70d7f9b59e7f4897800e41beeb1a1
---
contributors/index.html | 2 +-
index.json | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contributors/index.html b/contributors/index.html
index 00a2877dd32..72580ddd057 100644
--- a/contributors/index.html
+++ b/contributors/index.html
@@ -18996,7 +18996,7 @@
-3
+4
7
diff --git a/index.json b/index.json
index 18572051e88..611c07b2c06 100644
--- a/index.json
+++ b/index.json
@@ -1 +1 @@
-[{"body":"SkyWalking Cloud on Kubernetes 0.9.0 is released. Go to downloads
page to find release tars.\n0.9.0 Features Add a getting started document
about how to deploy swck on the kubernetes cluster. Bugs Fix the bug that the
java agent is duplicated injected when update the pod. Chores Bump up
custom-metrics-apiserver Bump up golang to v1.22 Bump up controller-gen to
v0.14.0 ","excerpt":"SkyWalking Cloud on Kubernetes 0.9.0 is released. Go to
downloads page to find release tars. [...]
\ No newline at end of file
+[{"body":"SkyWalking Cloud on Kubernetes 0.9.0 is released. Go to downloads
page to find release tars.\n0.9.0 Features Add a getting started document
about how to deploy swck on the kubernetes cluster. Bugs Fix the bug that the
java agent is duplicated injected when update the pod. Chores Bump up
custom-metrics-apiserver Bump up golang to v1.22 Bump up controller-gen to
v0.14.0 ","excerpt":"SkyWalking Cloud on Kubernetes 0.9.0 is released. Go to
downloads page to find release tars. [...]
\ No newline at end of file
Re: [I] [Bug]Skywalking-ui:9.1.0 white screen [skywalking]
viccP commented on issue #9330: URL: https://github.com/apache/skywalking/issues/9330#issuecomment-2024704789 > ``` > environment: > TZ: Asia/Shanghai > SW_OAP_ADDRESS: http://skywalking-oap:12800 > ``` > > I add the `http//` prefix finally make it it's work,I just try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] org.apache.skywalking.oap.server.starter.OAPServerBootstrap - 71 [main] ERROR [] - No files in meter-analyzer-config [skywalking]
wu-sheng commented on issue #7085: URL: https://github.com/apache/skywalking/issues/7085#issuecomment-2024470658 You could. To be honest, I am not on Windows for a decade. I may need to ask othera to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] org.apache.skywalking.oap.server.starter.OAPServerBootstrap - 71 [main] ERROR [] - No files in meter-analyzer-config [skywalking]
Nonlinearequation commented on issue #7085: URL: https://github.com/apache/skywalking/issues/7085#issuecomment-2024468689 I had the same problem. In win, if there is space in the path, this will cause the problem. I set the path value manually to get the value. May I mention an issue to fix? @wu-sheng  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
