(skywalking-banyandb) branch main updated: Implement GC for SeriesDatabase of TSDB (#428)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new 77b8caa6 Implement GC for SeriesDatabase of TSDB (#428)
77b8caa6 is described below
commit 77b8caa659e765b3ca4e60f7f6f07038a3ec3a8b
Author: Gao Hongtao
AuthorDate: Thu Apr 4 12:12:18 2024 +0800
Implement GC for SeriesDatabase of TSDB (#428)
---
banyand/internal/storage/index.go | 215 +++--
banyand/internal/storage/index_test.go | 86 -
banyand/internal/storage/retention.go | 19 ++-
banyand/internal/storage/segment.go| 20 +--
banyand/internal/storage/shard.go | 18 +--
banyand/internal/storage/storage.go| 10 ++
banyand/internal/storage/tsdb.go | 40 +++---
7 files changed, 351 insertions(+), 57 deletions(-)
diff --git a/banyand/internal/storage/index.go
b/banyand/internal/storage/index.go
index e85b2178..7bc91fea 100644
--- a/banyand/internal/storage/index.go
+++ b/banyand/internal/storage/index.go
@@ -19,7 +19,14 @@ package storage
import (
"context"
+ "fmt"
"path"
+ "path/filepath"
+ "sort"
+ "strconv"
+ "strings"
+ "sync"
+ "time"
"github.com/pkg/errors"
"go.uber.org/multierr"
@@ -31,28 +38,33 @@ import (
"github.com/apache/skywalking-banyandb/pkg/index/posting"
"github.com/apache/skywalking-banyandb/pkg/logger"
pbv1 "github.com/apache/skywalking-banyandb/pkg/pb/v1"
+ "github.com/apache/skywalking-banyandb/pkg/timestamp"
)
func (d *database[T, O]) IndexDB() IndexDB {
- return d.index
+ return d.indexController.hot
}
func (d *database[T, O]) Lookup(ctx context.Context, series *pbv1.Series)
(pbv1.SeriesList, error) {
- return d.index.searchPrimary(ctx, series)
+ return d.indexController.searchPrimary(ctx, series)
}
type seriesIndex struct {
- store index.SeriesStore
- l *logger.Logger
+ startTime time.Time
+ store index.SeriesStore
+ l *logger.Logger
+ path string
}
-func newSeriesIndex(ctx context.Context, root string, flushTimeoutSeconds
int64) (*seriesIndex, error) {
+func newSeriesIndex(ctx context.Context, path string, startTime time.Time,
flushTimeoutSeconds int64) (*seriesIndex, error) {
si := {
- l: logger.Fetch(ctx, "series_index"),
+ path: path,
+ startTime: startTime,
+ l: logger.Fetch(ctx, "series_index"),
}
var err error
if si.store, err = inverted.NewStore(inverted.StoreOpts{
- Path: path.Join(root, "idx"),
+ Path: path,
Logger: si.l,
BatchWaitSec: flushTimeoutSeconds,
}); err != nil {
@@ -224,3 +236,192 @@ func appendSeriesList(dest, src pbv1.SeriesList, filter
posting.List) pbv1.Serie
func (s *seriesIndex) Close() error {
return s.store.Close()
}
+
+type seriesIndexController[T TSTable, O any] struct {
+ clock timestamp.Clock
+ hot *seriesIndex
+ standby *seriesIndex
+ l *logger.Logger
+ locationstring
+ optsTSDBOpts[T, O]
+ standbyLiveTime time.Duration
+ sync.RWMutex
+}
+
+func newSeriesIndexController[T TSTable, O any](
+ ctx context.Context,
+ opts TSDBOpts[T, O],
+) (*seriesIndexController[T, O], error) {
+ l := logger.Fetch(ctx, "seriesIndexController")
+ clock, ctx := timestamp.GetClock(ctx)
+ var standbyLiveTime time.Duration
+ switch opts.TTL.Unit {
+ case HOUR:
+ standbyLiveTime = time.Hour
+ case DAY:
+ standbyLiveTime = 24 * time.Hour
+ default:
+ }
+ sic := [T, O]{
+ opts:opts,
+ clock: clock,
+ standbyLiveTime: standbyLiveTime,
+ location:filepath.Clean(opts.Location),
+ l: l,
+ }
+ idxName, err := sic.loadIdx()
+ if err != nil {
+ return nil, err
+ }
+ switch len(idxName) {
+ case 0:
+ if sic.hot, err = sic.newIdx(ctx); err != nil {
+ return nil, err
+ }
+ case 1:
+ if sic.hot, err = sic.openIdx(ctx, idxName[0]); err != nil {
+ return nil, err
+ }
+ case 2:
+ if sic.hot, err = sic.openIdx(ctx, idxName[0]); err != nil {
+ return nil, err
+ }
+ if sic.standby, err = sic.openIdx(ctx, idxName[1]); err != nil {
+ return nil, err
+ }
+ default:
+
Re: [I] [Feature] Implement GC for SeriesDatabase of TSDB [skywalking]
wu-sheng closed issue #11494: [Feature] Implement GC for SeriesDatabase of TSDB URL: https://github.com/apache/skywalking/issues/11494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement GC for SeriesDatabase of TSDB [skywalking-banyandb]
wu-sheng merged PR #428: URL: https://github.com/apache/skywalking-banyandb/pull/428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement GC for SeriesDatabase of TSDB [skywalking-banyandb]
codecov-commenter commented on PR #428: URL: https://github.com/apache/skywalking-banyandb/pull/428#issuecomment-2036123903 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `41.41414%` with `116 lines` in your changes are missing coverage. Please review. > Project coverage is 47.87%. Comparing base [(`3a438a5`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/3a438a5940d344684d56f0c56ef905efc35621a7?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`b3728d5`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). | [Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [banyand/internal/storage/index.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?src=pr=tree=banyand%2Finternal%2Fstorage%2Findex.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9pbnRlcm5hbC9zdG9yYWdlL2luZGV4Lmdv) | 50.98% | [64 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/internal/storage/tsdb.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?src=pr=tree=banyand%2Finternal%2Fstorage%2Ftsdb.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9pbnRlcm5hbC9zdG9yYWdlL3RzZGIuZ28=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/internal/storage/retention.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?src=pr=tree=banyand%2Finternal%2Fstorage%2Fretention.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9pbnRlcm5hbC9zdG9yYWdlL3JldGVudGlvbi5nbw==) | 0.00% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/internal/storage/segment.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?src=pr=tree=banyand%2Finternal%2Fstorage%2Fsegment.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9pbnRlcm5hbC9zdG9yYWdlL3NlZ21lbnQuZ28=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/internal/storage/shard.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?src=pr=tree=banyand%2Finternal%2Fstorage%2Fshard.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9pbnRlcm5hbC9zdG9yYWdlL3NoYXJkLmdv) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/internal/storage/storage.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?src=pr=tree=banyand%2Finternal%2Fstorage%2Fstorage.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9pbnRlcm5hbC9zdG9yYWdlL3N0b3JhZ2UuZ28=) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@Coverage Diff @@ ## main #428 +/- ## == - Coverage 48.24% 47.87% -0.38% == Files 176 176 Lines 2172221880 +158 == - Hits1048010474 -6 - Misses 1035110518 +167 + Partials 891 888 -3 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/428?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it
Re: [PR] Implement GC for SeriesDatabase of TSDB [skywalking-banyandb]
hanahmily closed pull request #409: Implement GC for SeriesDatabase of TSDB URL: https://github.com/apache/skywalking-banyandb/pull/409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) 01/01: Merge remote-tracking branch 'origin/main' into idx-gc
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch idx-gc in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit b3728d5bada64776374cb518f0adafbb53946a5b Merge: 016c3f59 3a438a59 Author: Gao Hongtao AuthorDate: Thu Apr 4 03:40:41 2024 + Merge remote-tracking branch 'origin/main' into idx-gc banyand/measure/block.go | 5 ++- banyand/measure/block_metadata.go | 12 +- banyand/stream/block.go | 5 ++- banyand/stream/block_metadata.go | 11 - pkg/test/query/trace.go | 79 +-- test/stress/trace/trace_suite_test.go | 8 6 files changed, 110 insertions(+), 10 deletions(-)
(skywalking-banyandb) branch idx-gc updated (016c3f59 -> b3728d5b)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch idx-gc in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 016c3f59 Add more test cases add 3a438a59 Add more test cases and fix some issues found in the tests (#426) new b3728d5b Merge remote-tracking branch 'origin/main' into idx-gc The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: banyand/measure/block.go | 5 ++- banyand/measure/block_metadata.go | 12 +- banyand/stream/block.go | 5 ++- banyand/stream/block_metadata.go | 11 - pkg/test/query/trace.go | 79 +-- test/stress/trace/trace_suite_test.go | 8 6 files changed, 110 insertions(+), 10 deletions(-)
[PR] Implement GC for SeriesDatabase of TSDB [skywalking-banyandb]
hanahmily opened a new pull request, #428: URL: https://github.com/apache/skywalking-banyandb/pull/428 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#11494. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) 01/01: Add more test cases
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch idx-gc
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 016c3f59fd9057a6bde3ef5e20d4ed31d6b1872d
Author: Gao Hongtao
AuthorDate: Thu Apr 4 03:32:08 2024 +
Add more test cases
Signed-off-by: Gao Hongtao
---
banyand/internal/storage/index.go | 253 +++--
banyand/internal/storage/index_test.go | 86 ++-
banyand/internal/storage/retention.go | 12 +-
banyand/internal/storage/segment.go| 16 +--
banyand/internal/storage/storage.go| 10 ++
pkg/fs/file_system.go | 7 +-
pkg/fs/local_file_system.go| 17 +--
pkg/fs/local_file_system_test.go | 2 +-
8 files changed, 255 insertions(+), 148 deletions(-)
diff --git a/banyand/internal/storage/index.go
b/banyand/internal/storage/index.go
index f19fc166..7bc91fea 100644
--- a/banyand/internal/storage/index.go
+++ b/banyand/internal/storage/index.go
@@ -20,8 +20,11 @@ package storage
import (
"context"
"fmt"
- "os"
+ "path"
"path/filepath"
+ "sort"
+ "strconv"
+ "strings"
"sync"
"time"
@@ -47,19 +50,21 @@ func (d *database[T, O]) Lookup(ctx context.Context, series
*pbv1.Series) (pbv1.
}
type seriesIndex struct {
- l *logger.Logger
- store index.SeriesStore
- name string
+ startTime time.Time
+ store index.SeriesStore
+ l *logger.Logger
+ path string
}
-func newSeriesIndex(ctx context.Context, path, name string,
flushTimeoutSeconds int64) (*seriesIndex, error) {
+func newSeriesIndex(ctx context.Context, path string, startTime time.Time,
flushTimeoutSeconds int64) (*seriesIndex, error) {
si := {
- name: name,
- l:logger.Fetch(ctx, "series_index"),
+ path: path,
+ startTime: startTime,
+ l: logger.Fetch(ctx, "series_index"),
}
var err error
if si.store, err = inverted.NewStore(inverted.StoreOpts{
- Path: filepath.Join(path, name),
+ Path: path,
Logger: si.l,
BatchWaitSec: flushTimeoutSeconds,
}); err != nil {
@@ -233,39 +238,67 @@ func (s *seriesIndex) Close() error {
}
type seriesIndexController[T TSTable, O any] struct {
- ctx context.Context
- hot *seriesIndex
- standby *seriesIndex
- timestamp.TimeRange
- l*logger.Logger
- opts TSDBOpts[T, O]
+ clock timestamp.Clock
+ hot *seriesIndex
+ standby *seriesIndex
+ l *logger.Logger
+ locationstring
+ optsTSDBOpts[T, O]
+ standbyLiveTime time.Duration
sync.RWMutex
}
-func standard(t time.Time, unit IntervalUnit) time.Time {
- switch unit {
- case HOUR:
- return time.Date(t.Year(), t.Month(), t.Day(), t.Hour(), 0, 0,
0, t.Location())
- case DAY:
- return time.Date(t.Year(), t.Month(), t.Day(), 0, 0, 0, 0,
t.Location())
- }
- panic("invalid interval unit")
-}
-
func newSeriesIndexController[T TSTable, O any](
ctx context.Context,
opts TSDBOpts[T, O],
) (*seriesIndexController[T, O], error) {
- var hpath, spath string
l := logger.Fetch(ctx, "seriesIndexController")
- startTime := standard(time.Now(), opts.TTL.Unit)
- endTime := startTime.Add(opts.TTL.estimatedDuration())
- timeRange := timestamp.NewSectionTimeRange(startTime, endTime)
- location := filepath.Clean(opts.Location)
+ clock, ctx := timestamp.GetClock(ctx)
+ var standbyLiveTime time.Duration
+ switch opts.TTL.Unit {
+ case HOUR:
+ standbyLiveTime = time.Hour
+ case DAY:
+ standbyLiveTime = 24 * time.Hour
+ default:
+ }
+ sic := [T, O]{
+ opts:opts,
+ clock: clock,
+ standbyLiveTime: standbyLiveTime,
+ location:filepath.Clean(opts.Location),
+ l: l,
+ }
+ idxName, err := sic.loadIdx()
+ if err != nil {
+ return nil, err
+ }
+ switch len(idxName) {
+ case 0:
+ if sic.hot, err = sic.newIdx(ctx); err != nil {
+ return nil, err
+ }
+ case 1:
+ if sic.hot, err = sic.openIdx(ctx, idxName[0]); err != nil {
+ return nil, err
+ }
+ case 2:
+ if sic.hot, err = sic.openIdx(ctx, idxName[0]); err != nil {
+ return nil, err
+ }
+ if sic.standby, err = sic.openIdx(ctx, idxName[1]); err != nil {
+
(skywalking-banyandb) branch idx-gc created (now 016c3f59)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch idx-gc in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at 016c3f59 Add more test cases This branch includes the following new commits: new 016c3f59 Add more test cases The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
Re: [PR] Bump vite from 3.2.7 to 3.2.10 in /ui [skywalking-banyandb]
codecov-commenter commented on PR #427: URL: https://github.com/apache/skywalking-banyandb/pull/427#issuecomment-2035349033 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/427?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 47.85%. Comparing base [(`3a438a5`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/3a438a5940d344684d56f0c56ef905efc35621a7?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`074f797`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/427?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@Coverage Diff @@ ## main #427 +/- ## == - Coverage 47.87% 47.85% -0.02% == Files 176 176 Lines 2172221722 == - Hits1039910396 -3 - Misses 1045010453 +3 Partials 873 873 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/427?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch dependabot/npm_and_yarn/ui/vite-3.2.10 created (now 074f797a)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/ui/vite-3.2.10 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at 074f797a Bump vite from 3.2.7 to 3.2.10 in /ui No new revisions were added by this update.
[PR] Bump vite from 3.2.7 to 3.2.10 in /ui [skywalking-banyandb]
dependabot[bot] opened a new pull request, #427: URL: https://github.com/apache/skywalking-banyandb/pull/427 Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 3.2.7 to 3.2.10. Changelog Sourced from https://github.com/vitejs/vite/blob/v3.2.10/packages/vite/CHANGELOG.md;>vite's changelog. 3.2.10 (2024-03-24) 3.2.9 (2024-03-24) fix: port https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/15653;>#15653 to v3 (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/15655;>#15655) (https://github.com/vitejs/vite/commit/99080ca;>99080ca), closes https://redirect.github.com/vitejs/vite/issues/15653;>#15653 https://redirect.github.com/vitejs/vite/issues/15655;>#15655 fix: port https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/16250;>#16250 to v3 (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/16253;>#16253) (https://github.com/vitejs/vite/commit/89c7c64;>89c7c64), closes https://redirect.github.com/vitejs/vite/issues/16250;>#16250 https://redirect.github.com/vitejs/vite/issues/16253;>#16253 release: v3.2.8 (https://github.com/vitejs/vite/commit/8352b75;>8352b75) 3.2.8 (2024-01-19) fix: port https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/15653;>#15653 to v3 (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/15655;>#15655) (https://github.com/vitejs/vite/commit/99080ca;>99080ca), closes https://redirect.github.com/vitejs/vite/issues/15653;>#15653 https://redirect.github.com/vitejs/vite/issues/15655;>#15655 Commits https://github.com/vitejs/vite/commit/1a8728f8dfff9d62ebcd67d65ef1cc4b82042de4;>1a8728f release: v3.2.10 https://github.com/vitejs/vite/commit/5910f13ee2b6eac1d458f65d721c08ca600b18ab;>5910f13 release: v3.2.9 https://github.com/vitejs/vite/commit/89c7c645f09d16a38f146ef4a1528f218e844d67;>89c7c64 fix: port https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/16250;>#16250 to v3 (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/16253;>#16253) https://github.com/vitejs/vite/commit/8352b7546369b6ec958fe0b828e86eaca4e5cf88;>8352b75 release: v3.2.8 https://github.com/vitejs/vite/commit/99080ca3e6c2dcdc3c2d67bb2d143c59e0a329f2;>99080ca fix: port https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/15653;>#15653 to v3 (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/15655;>#15655) See full diff in https://github.com/vitejs/vite/commits/v3.2.10/packages/vite;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/skywalking-banyandb/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] build(deps-dev): bump vite from 4.5.2 to 4.5.3 [skywalking-booster-ui]
dependabot[bot] opened a new pull request, #378: URL: https://github.com/apache/skywalking-booster-ui/pull/378 Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.5.2 to 4.5.3. Changelog Sourced from https://github.com/vitejs/vite/blob/v4.5.3/packages/vite/CHANGELOG.md;>vite's changelog. 4.5.3 (2024-03-24) fix: fs.deny with globs with directories (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/16250;>#16250) (https://github.com/vitejs/vite/commit/96a7f3a;>96a7f3a), closes https://redirect.github.com/vitejs/vite/issues/16250;>#16250 Commits https://github.com/vitejs/vite/commit/aac695e9f8f29da43c2f7c50c549fa3d3dfeeadc;>aac695e release: v4.5.3 https://github.com/vitejs/vite/commit/96a7f3a41ef2f9351c46f3ab12489bb4efa03cc9;>96a7f3a fix: fs.deny with globs with directories (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/16250;>#16250) See full diff in https://github.com/vitejs/vite/commits/v4.5.3/packages/vite;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/skywalking-booster-ui/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-booster-ui) branch dependabot/npm_and_yarn/vite-4.5.3 created (now 815d69c7)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/vite-4.5.3 in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git at 815d69c7 build(deps-dev): bump vite from 4.5.2 to 4.5.3 No new revisions were added by this update.
Re: [I] [Bug] Hybird Compilation Issue with SkyWalking Go on Windows [skywalking]
Superskyyy commented on issue #12068: URL: https://github.com/apache/skywalking/issues/12068#issuecomment-2034693676 > > This is a good first issue for OSPP students to try out and get familiar with the contribution process at SkyWalking. > > Hint: windows uses backslash \ to separate paths. > > I think @mrproliu has added skywalking-go toolkit as OSPP task. This is open for other volunteers. We have 8 tasks for OSPP, maybe 1 more is available. Yeah I just mean this one can be an entry level task for potential candidates to try, this one involves minimal changes and not really blocking to many users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch asf-site updated: deploy: 3445ae5015d31d1f5a5c45724918558256bf508b
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new eed405449a3 deploy: 3445ae5015d31d1f5a5c45724918558256bf508b eed405449a3 is described below commit eed405449a34a6dbb58972498bfb666d0c601c35 Author: wu-sheng AuthorDate: Wed Apr 3 10:05:01 2024 + deploy: 3445ae5015d31d1f5a5c45724918558256bf508b --- contributors/index.html | 2 +- docs/skywalking-banyandb/next/api-reference/index.html | 2 +- docs/skywalking-banyandb/next/clients/index.html | 2 +- docs/skywalking-banyandb/next/concept/clustering/index.html | 2 +- docs/skywalking-banyandb/next/concept/data-model/index.html | 2 +- docs/skywalking-banyandb/next/concept/persistence-storage/index.html | 2 +- docs/skywalking-banyandb/next/concept/tsdb/index.html| 2 +- docs/skywalking-banyandb/next/concept/wal/index.html | 2 +- docs/skywalking-banyandb/next/crud/group/index.html | 2 +- docs/skywalking-banyandb/next/crud/index_rule/index.html | 2 +- docs/skywalking-banyandb/next/crud/index_rule_binding/index.html | 2 +- docs/skywalking-banyandb/next/crud/measure/query/index.html | 2 +- docs/skywalking-banyandb/next/crud/measure/schema/index.html | 2 +- docs/skywalking-banyandb/next/crud/property/index.html | 2 +- docs/skywalking-banyandb/next/crud/stream/query/index.html | 2 +- docs/skywalking-banyandb/next/crud/stream/schema/index.html | 2 +- docs/skywalking-banyandb/next/installation/binaries/index.html | 2 +- docs/skywalking-banyandb/next/installation/cluster/index.html| 2 +- docs/skywalking-banyandb/next/installation/index.html| 2 +- docs/skywalking-banyandb/next/installation/standalone/index.html | 2 +- docs/skywalking-banyandb/next/observability/index.html | 2 +- docs/skywalking-banyandb/next/readme/index.html | 2 +- docs/skywalking-banyandb/next/release/index.html | 4 ++-- index.json | 2 +- 24 files changed, 25 insertions(+), 25 deletions(-) diff --git a/contributors/index.html b/contributors/index.html index 7148bb733ff..19e0e7750aa 100644 --- a/contributors/index.html +++ b/contributors/index.html @@ -20449,7 +20449,7 @@ -229 +230 1 diff --git a/docs/skywalking-banyandb/next/api-reference/index.html b/docs/skywalking-banyandb/next/api-reference/index.html index a3d596f8935..5e7dadf59bc 100644 --- a/docs/skywalking-banyandb/next/api-reference/index.html +++ b/docs/skywalking-banyandb/next/api-reference/index.html @@ -582,7 +582,7 @@ Table of Contents banyandb/cluster/v1/rpc.proto })() - Commit Id: 50af806 + Commit Id: 3a438a5 diff --git a/docs/skywalking-banyandb/next/clients/index.html b/docs/skywalking-banyandb/next/clients/index.html index 4d19809698e..a8913f7b9e2 100644 --- a/docs/skywalking-banyandb/next/clients/index.html +++ b/docs/skywalking-banyandb/next/clients/index.html @@ -528,7 +528,7 @@ These are several ways to install: })() - Commit Id: 50af806 + Commit Id: 3a438a5 diff --git a/docs/skywalking-banyandb/next/concept/clustering/index.html b/docs/skywalking-banyandb/next/concept/clustering/index.html index 567168f0df0..ffb4823eb43 100644 --- a/docs/skywalking-banyandb/next/concept/clustering/index.html +++ b/docs/skywalking-banyandb/next/concept/clustering/index.html @@ -528,7 +528,7 @@ })() - Commit Id: 50af806 + Commit Id: 3a438a5 diff --git a/docs/skywalking-banyandb/next/concept/data-model/index.html b/docs/skywalking-banyandb/next/concept/data-model/index.html index a7f9ef9ba73..4fca4b4f551 100644 --- a/docs/skywalking-banyandb/next/concept/data-model/index.html +++ b/docs/skywalking-banyandb/next/concept/data-model/index.html @@ -531,7 +531,7 @@ Groups Group does not provide a mechanism for isolating groups of resources with })() - Commit Id: 50af806 + Commit Id: 3a438a5 diff --git a/docs/skywalking-banyandb/next/concept/persistence-storage/index.html b/docs/skywalking-banyandb/next/concept/persistence-storage/index.html index ffa60ed83f7..13d51bde8e8 100644 --- a/docs/skywalking-banyandb/next/concept/persistence-storage/index.html +++
Re: [PR] Add more test cases and fix some issues found in the test [skywalking-banyandb]
wu-sheng merged PR #426: URL: https://github.com/apache/skywalking-banyandb/pull/426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch main updated: Add more test cases and fix some issues found in the tests (#426)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new 3a438a59 Add more test cases and fix some issues found in the tests
(#426)
3a438a59 is described below
commit 3a438a5940d344684d56f0c56ef905efc35621a7
Author: Gao Hongtao
AuthorDate: Wed Apr 3 15:37:49 2024 +0800
Add more test cases and fix some issues found in the tests (#426)
---
banyand/measure/block.go | 5 ++-
banyand/measure/block_metadata.go | 12 +-
banyand/stream/block.go | 5 ++-
banyand/stream/block_metadata.go | 11 -
pkg/test/query/trace.go | 79 +--
test/stress/trace/trace_suite_test.go | 8
6 files changed, 110 insertions(+), 10 deletions(-)
diff --git a/banyand/measure/block.go b/banyand/measure/block.go
index cf3c2eab..b4792d85 100644
--- a/banyand/measure/block.go
+++ b/banyand/measure/block.go
@@ -610,10 +610,13 @@ func (bc *blockCursor) loadData(tmpBlock *block) bool {
}
bc.bm.field.columnMetadata = cfm
bc.bm.tagProjection = bc.tagProjection
- tf := make(map[string]*dataBlock, len(bc.tagProjection))
+ var tf map[string]*dataBlock
for i := range bc.tagProjection {
for tfName, block := range bc.bm.tagFamilies {
if bc.tagProjection[i].Family == tfName {
+ if tf == nil {
+ tf = make(map[string]*dataBlock,
len(bc.tagProjection))
+ }
tf[tfName] = block
}
}
diff --git a/banyand/measure/block_metadata.go
b/banyand/measure/block_metadata.go
index 82e44ca1..6a066329 100644
--- a/banyand/measure/block_metadata.go
+++ b/banyand/measure/block_metadata.go
@@ -176,7 +176,7 @@ func (bm *blockMetadata) unmarshal(src []byte) ([]byte,
error) {
if err != nil {
return nil, fmt.Errorf("cannot unmarshal
tagFamily dataBlock: %w", err)
}
- bm.tagFamilies[convert.BytesToString(nameBytes)] = tf
+ bm.tagFamilies[string(nameBytes)] = tf
}
}
src, err = bm.field.unmarshal(src)
@@ -212,6 +212,13 @@ type blockMetadataArray struct {
arr []blockMetadata
}
+func (bma *blockMetadataArray) reset() {
+ for i := range bma.arr {
+ bma.arr[i].reset()
+ }
+ bma.arr = bma.arr[:0]
+}
+
var blockMetadataArrayPool sync.Pool
func generateBlockMetadataArray() *blockMetadataArray {
@@ -223,7 +230,7 @@ func generateBlockMetadataArray() *blockMetadataArray {
}
func releaseBlockMetadataArray(bma *blockMetadataArray) {
- bma.arr = bma.arr[:0]
+ bma.reset()
blockMetadataArrayPool.Put(bma)
}
@@ -279,6 +286,7 @@ func unmarshalBlockMetadata(dst []blockMetadata, src
[]byte) ([]blockMetadata, e
dst = append(dst, blockMetadata{})
}
bm := [len(dst)-1]
+ bm.reset()
tail, err := bm.unmarshal(src)
if err != nil {
return dstOrig, fmt.Errorf("cannot unmarshal
blockMetadata entries: %w", err)
diff --git a/banyand/stream/block.go b/banyand/stream/block.go
index e8f63200..63342b11 100644
--- a/banyand/stream/block.go
+++ b/banyand/stream/block.go
@@ -529,10 +529,13 @@ func (bc *blockCursor) copyTo(r *pbv1.StreamResult) {
func (bc *blockCursor) loadData(tmpBlock *block) bool {
tmpBlock.reset()
bc.bm.tagProjection = bc.tagProjection
- tf := make(map[string]*dataBlock, len(bc.tagProjection))
+ var tf map[string]*dataBlock
for i := range bc.tagProjection {
for tfName, block := range bc.bm.tagFamilies {
if bc.tagProjection[i].Family == tfName {
+ if tf == nil {
+ tf = make(map[string]*dataBlock,
len(bc.tagProjection))
+ }
tf[tfName] = block
}
}
diff --git a/banyand/stream/block_metadata.go b/banyand/stream/block_metadata.go
index 8c8e2771..3906f603 100644
--- a/banyand/stream/block_metadata.go
+++ b/banyand/stream/block_metadata.go
@@ -181,7 +181,7 @@ func (bm *blockMetadata) unmarshal(src []byte) ([]byte,
error) {
if err != nil {
return nil, fmt.Errorf("cannot unmarshal
tagFamily dataBlock: %w", err)
}
- bm.tagFamilies[convert.BytesToString(nameBytes)] = tf
+ bm.tagFamilies[string(nameBytes)] = tf
}
}
(skywalking-banyandb) branch trace-test deleted (was 3ae549e2)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch trace-test in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was 3ae549e2 Add more test cases The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Add more test cases and fix some issues found in the test [skywalking-banyandb]
codecov-commenter commented on PR #426: URL: https://github.com/apache/skywalking-banyandb/pull/426#issuecomment-2033775916 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/426?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `73.91304%` with `6 lines` in your changes are missing coverage. Please review. > Project coverage is 47.83%. Comparing base [(`50af806`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/50af806fc7d6938cd31adb0dc403d5e5fb82fbe9?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`3ae549e`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/426?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). | [Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/426?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [banyand/measure/block\_metadata.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/426?src=pr=tree=banyand%2Fmeasure%2Fblock_metadata.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9tZWFzdXJlL2Jsb2NrX21ldGFkYXRhLmdv) | 62.50% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/426?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [banyand/stream/block\_metadata.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/426?src=pr=tree=banyand%2Fstream%2Fblock_metadata.go_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YmFueWFuZC9zdHJlYW0vYmxvY2tfbWV0YWRhdGEuZ28=) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/426?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@Coverage Diff @@ ## main #426 +/- ## == - Coverage 48.23% 47.83% -0.41% == Files 176 176 Lines 2170721722 +15 == - Hits1047110390 -81 - Misses 1034710457 +110 + Partials 889 875 -14 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/426?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add more test cases [skywalking-banyandb]
hanahmily opened a new pull request, #426: URL: https://github.com/apache/skywalking-banyandb/pull/426 Add more test cases for tracing test and fixed some issues found in the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch trace-test created (now 3ae549e2)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch trace-test in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at 3ae549e2 Add more test cases This branch includes the following new commits: new 3ae549e2 Add more test cases The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(skywalking-banyandb) 01/01: Add more test cases
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch trace-test
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 3ae549e23b60d94fdf3f62c6203dec8dbfbbde8b
Author: Gao Hongtao
AuthorDate: Wed Apr 3 07:28:17 2024 +
Add more test cases
Signed-off-by: Gao Hongtao
---
banyand/measure/block.go | 5 ++-
banyand/measure/block_metadata.go | 12 +-
banyand/stream/block.go | 5 ++-
banyand/stream/block_metadata.go | 11 -
pkg/test/query/trace.go | 79 +--
test/stress/trace/trace_suite_test.go | 8
6 files changed, 110 insertions(+), 10 deletions(-)
diff --git a/banyand/measure/block.go b/banyand/measure/block.go
index cf3c2eab..b4792d85 100644
--- a/banyand/measure/block.go
+++ b/banyand/measure/block.go
@@ -610,10 +610,13 @@ func (bc *blockCursor) loadData(tmpBlock *block) bool {
}
bc.bm.field.columnMetadata = cfm
bc.bm.tagProjection = bc.tagProjection
- tf := make(map[string]*dataBlock, len(bc.tagProjection))
+ var tf map[string]*dataBlock
for i := range bc.tagProjection {
for tfName, block := range bc.bm.tagFamilies {
if bc.tagProjection[i].Family == tfName {
+ if tf == nil {
+ tf = make(map[string]*dataBlock,
len(bc.tagProjection))
+ }
tf[tfName] = block
}
}
diff --git a/banyand/measure/block_metadata.go
b/banyand/measure/block_metadata.go
index 82e44ca1..6a066329 100644
--- a/banyand/measure/block_metadata.go
+++ b/banyand/measure/block_metadata.go
@@ -176,7 +176,7 @@ func (bm *blockMetadata) unmarshal(src []byte) ([]byte,
error) {
if err != nil {
return nil, fmt.Errorf("cannot unmarshal
tagFamily dataBlock: %w", err)
}
- bm.tagFamilies[convert.BytesToString(nameBytes)] = tf
+ bm.tagFamilies[string(nameBytes)] = tf
}
}
src, err = bm.field.unmarshal(src)
@@ -212,6 +212,13 @@ type blockMetadataArray struct {
arr []blockMetadata
}
+func (bma *blockMetadataArray) reset() {
+ for i := range bma.arr {
+ bma.arr[i].reset()
+ }
+ bma.arr = bma.arr[:0]
+}
+
var blockMetadataArrayPool sync.Pool
func generateBlockMetadataArray() *blockMetadataArray {
@@ -223,7 +230,7 @@ func generateBlockMetadataArray() *blockMetadataArray {
}
func releaseBlockMetadataArray(bma *blockMetadataArray) {
- bma.arr = bma.arr[:0]
+ bma.reset()
blockMetadataArrayPool.Put(bma)
}
@@ -279,6 +286,7 @@ func unmarshalBlockMetadata(dst []blockMetadata, src
[]byte) ([]blockMetadata, e
dst = append(dst, blockMetadata{})
}
bm := [len(dst)-1]
+ bm.reset()
tail, err := bm.unmarshal(src)
if err != nil {
return dstOrig, fmt.Errorf("cannot unmarshal
blockMetadata entries: %w", err)
diff --git a/banyand/stream/block.go b/banyand/stream/block.go
index e8f63200..63342b11 100644
--- a/banyand/stream/block.go
+++ b/banyand/stream/block.go
@@ -529,10 +529,13 @@ func (bc *blockCursor) copyTo(r *pbv1.StreamResult) {
func (bc *blockCursor) loadData(tmpBlock *block) bool {
tmpBlock.reset()
bc.bm.tagProjection = bc.tagProjection
- tf := make(map[string]*dataBlock, len(bc.tagProjection))
+ var tf map[string]*dataBlock
for i := range bc.tagProjection {
for tfName, block := range bc.bm.tagFamilies {
if bc.tagProjection[i].Family == tfName {
+ if tf == nil {
+ tf = make(map[string]*dataBlock,
len(bc.tagProjection))
+ }
tf[tfName] = block
}
}
diff --git a/banyand/stream/block_metadata.go b/banyand/stream/block_metadata.go
index 8c8e2771..3906f603 100644
--- a/banyand/stream/block_metadata.go
+++ b/banyand/stream/block_metadata.go
@@ -181,7 +181,7 @@ func (bm *blockMetadata) unmarshal(src []byte) ([]byte,
error) {
if err != nil {
return nil, fmt.Errorf("cannot unmarshal
tagFamily dataBlock: %w", err)
}
- bm.tagFamilies[convert.BytesToString(nameBytes)] = tf
+ bm.tagFamilies[string(nameBytes)] = tf
}
}
if err != nil {
@@ -216,6 +216,13 @@ type blockMetadataArray struct {
arr []blockMetadata
}
+func (bma *blockMetadataArray) reset() {
+ for i := range bma.arr
Re: [I] Duplicate traceid in different request [skywalking]
yujianweilai commented on issue #1254: URL: https://github.com/apache/skywalking/issues/1254#issuecomment-2033708131 > I also have the same problem. Different requests get the same traceid. May I ask if there is a solution？ I also have the same problem, do you resolve the problem ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Duplicate traceid in different request [skywalking]
yujianweilai commented on issue #1254: URL: https://github.com/apache/skywalking/issues/1254#issuecomment-2033674689 > 我也有同样的问题。不同的请求获取相同的 traceid。请问是否有解决办法？ 您好，我也有类似的情况，同一个TID被反复使用，始终不释放。您之前遇到的问题，解决了吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
