Re: [I] [Bug] skywalking-showcase docker deployment has some incorrect parts [skywalking]
wu-sheng commented on issue #12077: URL: https://github.com/apache/skywalking/issues/12077#issuecomment-2044182596 > > > > > > > This doesn't make sense as this is a "skywalking" showcase, we don't bother to make it work without skywalking > > > > > > Sorry, my expression was not very clear. > > My meaning is, some people (including myself) may want to import data into an external OAP, rather than using a single-node. That is not showcase. We don't need to consider that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-showcase docker deployment has some incorrect parts [skywalking]
yswdqz commented on issue #12077: URL: https://github.com/apache/skywalking/issues/12077#issuecomment-2044181523 > > This doesn't make sense as this is a "skywalking" showcase, we don't bother to make it work without skywalking Sorry, my expression was not very clear. My meaning is, some people (including myself) may want to import data into an external OAP, rather than using a single-node. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump up dependencies to fix CVEs [skywalking]
kezhenxu94 opened a new pull request, #12080: URL: https://github.com/apache/skywalking/pull/12080 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-python) branch dependabot/pip/pymongo-4.6.3 deleted (was acb9800)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/pymongo-4.6.3 in repository https://gitbox.apache.org/repos/asf/skywalking-python.git was acb9800 Bump pymongo from 3.12.0 to 4.6.3 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump pymongo from 3.12.0 to 4.6.3 [skywalking-python]
dependabot[bot] commented on PR #335: URL: https://github.com/apache/skywalking-python/pull/335#issuecomment-2043850385 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump pymongo from 3.12.0 to 4.6.3 [skywalking-python]
wu-sheng closed pull request #335: Bump pymongo from 3.12.0 to 4.6.3 URL: https://github.com/apache/skywalking-python/pull/335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump pymongo from 3.12.0 to 4.6.3 [skywalking-python]
dependabot[bot] opened a new pull request, #335: URL: https://github.com/apache/skywalking-python/pull/335 Bumps [pymongo](https://github.com/mongodb/mongo-python-driver) from 3.12.0 to 4.6.3. Release notes Sourced from https://github.com/mongodb/mongo-python-driver/releases;>pymongo's releases. PyMongo 4.6.2 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-6-2-released/267404;>https://www.mongodb.com/community/forums/t/pymongo-4-6-2-released/267404 PyMongo 4.6.1 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-6-1-released/255752;>https://www.mongodb.com/community/forums/t/pymongo-4-6-1-released/255752 PyMongo 4.6.0 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-6-0-released/251866;>https://www.mongodb.com/community/forums/t/pymongo-4-6-0-released/251866 PyMongo 4.5.0 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-5-0-released/240662;>https://www.mongodb.com/community/forums/t/pymongo-4-5-0-released/240662 PyMongo 4.4.1 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-4-1-released/235045;>https://www.mongodb.com/community/forums/t/pymongo-4-4-1-released/235045 PyMongo 4.4.0 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-4-released/232211;>https://www.mongodb.com/community/forums/t/pymongo-4-4-released/232211 PyMongo 4.4.0b0 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-4-0b0-release/210471;>https://www.mongodb.com/community/forums/t/pymongo-4-4-0b0-release/210471 PyMongo 4.3.3 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-3-3-release/200145;>https://www.mongodb.com/community/forums/t/pymongo-4-3-3-release/200145 PyMongo 4.3.2 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-3-2-released/194266;>https://www.mongodb.com/community/forums/t/pymongo-4-3-2-released/194266 PyMongo 4.2.0 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-2-0-released/176012;>https://www.mongodb.com/community/forums/t/pymongo-4-2-0-released/176012 PyMongo 4.2.0b0 Release notes: https://www.mongodb.com/community/forums/t/python-driver-4-2-0-beta-available/168488;>https://www.mongodb.com/community/forums/t/python-driver-4-2-0-beta-available/168488 PyMongo 4.1.1 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-1-1-released/157895;>https://www.mongodb.com/community/forums/t/pymongo-4-1-1-released/157895 PyMongo 4.1.0 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-1-0-released/156029;>https://www.mongodb.com/community/forums/t/pymongo-4-1-0-released/156029 PyMongo 4.0.2 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-0-2-released/150457;>https://www.mongodb.com/community/forums/t/pymongo-4-0-2-released/150457 PyMongo 4.0.1 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-0-1-released/135979;>https://www.mongodb.com/community/forums/t/pymongo-4-0-1-released/135979 PyMongo 4.0 Release notes: https://www.mongodb.com/community/forums/t/pymongo-4-0-released/134677;>https://www.mongodb.com/community/forums/t/pymongo-4-0-released/134677 PyMongo 3.13.0 Release notes https://www.mongodb.com/community/forums/t/pymongo-3-13-0-released/197141;>https://www.mongodb.com/community/forums/t/pymongo-3-13-0-released/197141 ... (truncated) Changelog Sourced from https://github.com/mongodb/mongo-python-driver/blob/master/doc/changelog.rst;>pymongo's changelog. Changelog Changes in Version 4.7 PyMongo 4.7 brings a number of improvements including: Added the :class:pymongo.hello.Hello.connection_id, :attr:pymongo.monitoring.CommandStartedEvent.server_connection_id, :attr:pymongo.monitoring.CommandSucceededEvent.server_connection_id, and :attr:pymongo.monitoring.CommandFailedEvent.server_connection_id properties. Fixed a bug where inflating a :class:~bson.raw_bson.RawBSONDocument containing a :class:~bson.code.Code would cause an error. Significantly improved the performance of encoding BSON documents to JSON. Support for named KMS providers for client side field level encryption. Previously supported KMS providers were only: aws, azure, gcp, kmip, and local. The KMS provider is now expanded to support name suffixes (e.g. local:myname). Named KMS providers enables more than one of each KMS provider type to be configured. See the docstring for :class:~pymongo.encryption_options.AutoEncryptionOpts. Note that named KMS providers requires pymongocrypt =1.9 and libmongocrypt =1.9. :meth:~pymongo.encryption.ClientEncryption.encrypt and :meth:~pymongo.encryption.ClientEncryption.encrypt_expression now allow key_id to be passed in as a :class:uuid.UUID. Fixed a bug where :class:~bson.int64.Int64 instances could not always
(skywalking-python) branch dependabot/pip/pymongo-4.6.3 created (now acb9800)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/pymongo-4.6.3 in repository https://gitbox.apache.org/repos/asf/skywalking-python.git at acb9800 Bump pymongo from 3.12.0 to 4.6.3 No new revisions were added by this update.
Re: [I] [Bug] skywalking-showcase docker deployment has some incorrect parts [skywalking]
kezhenxu94 commented on issue #12077: URL: https://github.com/apache/skywalking/issues/12077#issuecomment-2042719467 > > Can you elaborate? OAP is required to be up and running for those components that need to talk to OAP, in your > > screenshot, the vm exporter needs to send data to OAP so it needs to wait for OAP's readiness > > Maybe we just need VM-monitor feature, and I just want run with "make deploy.docker FEATURE_FLAGS=vm"(not FEATURE_FLAGS=vm,single-node) This doesn't make sense as this is a "skywalking" showcase, we don't bother to make it work without skywalking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] When the sampling rate is 0 and the code exists across goroutine, ExitSpan has a problem of failure to create. err: span type is wrong [skywalking]
Donghui0 commented on issue #12079: URL: https://github.com/apache/skywalking/issues/12079#issuecomment-2042662154 > Which version are you using? There was a relative fix in 0.4 release, [apache/skywalking-go#161](https://github.com/apache/skywalking-go/pull/161) version 0.4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] When the sampling rate is 0 and the code exists across goroutine, ExitSpan has a problem of failure to create. err: span type is wrong [skywalking]
wu-sheng commented on issue #12079: URL: https://github.com/apache/skywalking/issues/12079#issuecomment-2042607392 Which version are you using? There was a relative fix in 0.4 release, https://github.com/apache/skywalking-go/pull/161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] When the sampling rate is 0 and the code exists across goroutine, ExitSpan has a problem of failure to create. err: span type is wrong [skywalking]
Donghui0 opened a new issue, #12079:
URL: https://github.com/apache/skywalking/issues/12079
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
Go Agent (apache/skywalking-go)
### What happened
In the following scenario, Gin handler serves as the entry point and calls 2
mongo operations through goroutine.
Gin -- EntrySpan (NewNoopSpan() -> SET_GLS(NoopSpan{stackCount: 1}))
|
(sync.Group)
MongoClient ExitSpan (GET_GLS() -> NoopSpan{stackCount:0} ->
noop.enterNoSpan() -> span.End() -> SET_GLS(nil) )
| (Why
stackCount is 0 ?)
MongoClient ExitSpan (GET_GLS() -> nil)
In the 2nd ExitSpan, because ctx.ActiveSpan() returns nil. Then
createSpan0() returns NoopSpan.
The following is debug mode:
**Gin CreateEntrySpan，ctx:**
**The first CreateExitSpan within the goroutine, ctx:**
**Second CreateExitSpan inside goroutine, ctx:**
### What you expected to happen
In the first ExitSpan, The stackCount of ActiveSpan() obtained by
GetTracingContext() should be 1.
in the 2nd ExitSpan, getTracingContext() -> ActiveSpan() Should not be nil.
### How to reproduce
After changing the sampling rate to 0, run the following test code.
`package main
import (
"fmt"
_ "github.com/apache/skywalking-go"
"github.com/gin-gonic/gin"
"go.mongodb.org/mongo-driver/bson"
"go.mongodb.org/mongo-driver/mongo"
"go.mongodb.org/mongo-driver/mongo/options"
"golang.org/x/sync/errgroup"
)
type ErrorGroup struct {
errgroup.Group
}
func main() {
r := gin.Default()
r.GET("/mongo_get", mongoGet)
r.Run()
}
func mongoGet(c *gin.Context) {
var e ErrorGroup
var m, _ = mongo.Connect(c,
options.Client().ApplyURI("mongodb://127.0.0.1:27017"))
filter := bson.D{{"name", "test"}}
e.Go(func() (err error) {
collection := m.Database("demo").Collection("testCollection")
_, err = collection.Find(c, filter)
if err != nil {
return err
}
fmt.Println("first Find Done")
_, err = collection.Find(c, filter)
if err != nil {
return err
}
fmt.Println("second Find Done")
return nil
})
err := e.Wait()
if err != nil {
fmt.Println(err)
}
}`
Observe the log, you can find that the log will print the following error:
`cannot create exit span on mongo client: span type is wrong`
### Anything else
_No response_
### Are you willing to submit a pull request to fix on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
notifications-unsubscr...@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]
CodePrometheus commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1555618861 ## Makefile.in: ## @@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss ES_IMAGE_TAG ?= 7.10.2 SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap -SW_OAP_IMAGE_TAG ?= 8fad0cc8a822a3b266e528b30295e1376b956f1d +SW_OAP_IMAGE_TAG ?= 48c96a233103ba869143062923d4033678b91f73 SW_UI_IMAGE ?= ghcr.io/apache/skywalking/ui -SW_UI_IMAGE_TAG ?= 8fad0cc8a822a3b266e528b30295e1376b956f1d +SW_UI_IMAGE_TAG ?= 8bc67614681b37623fa64233f8389d6754e64cf2 Review Comment: Thank you for your trouble, I'll pay more attention in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]
wu-sheng commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r122505 ## Makefile.in: ## @@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss ES_IMAGE_TAG ?= 7.10.2 SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap -SW_OAP_IMAGE_TAG ?= 8fad0cc8a822a3b266e528b30295e1376b956f1d +SW_OAP_IMAGE_TAG ?= 48c96a233103ba869143062923d4033678b91f73 SW_UI_IMAGE ?= ghcr.io/apache/skywalking/ui -SW_UI_IMAGE_TAG ?= 8fad0cc8a822a3b266e528b30295e1376b956f1d +SW_UI_IMAGE_TAG ?= 8bc67614681b37623fa64233f8389d6754e64cf2 Review Comment: We have fixed this manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-showcase) branch main updated: Bump up OAP/UI version
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-showcase.git The following commit(s) were added to refs/heads/main by this push: new 42208dd Bump up OAP/UI version 42208dd is described below commit 42208dd22279529253870af8c7f7ad55a2a3a00b Author: 吴晟 Wu Sheng AuthorDate: Mon Apr 8 17:35:20 2024 +0800 Bump up OAP/UI version --- Makefile.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.in b/Makefile.in index 878aa85..f6f8bf5 100644 --- a/Makefile.in +++ b/Makefile.in @@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss ES_IMAGE_TAG ?= 7.10.2 SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap -SW_OAP_IMAGE_TAG ?= 48c96a233103ba869143062923d4033678b91f73 +SW_OAP_IMAGE_TAG ?= 8dd842189d4cf4df817dfb437ded5673023c3451 SW_UI_IMAGE ?= ghcr.io/apache/skywalking/ui -SW_UI_IMAGE_TAG ?= 48c96a233103ba869143062923d4033678b91f73 +SW_UI_IMAGE_TAG ?= 8dd842189d4cf4df817dfb437ded5673023c3451 SW_CLI_IMAGE ?= ghcr.io/apache/skywalking-cli/skywalking-cli:0883266bfaa36612927b69e35781b64ea181758d SW_EVENT_EXPORTER_IMAGE ?= ghcr.io/apache/skywalking-kubernetes-event-exporter/skywalking-kubernetes-event-exporter:8a012a3f968cb139f817189afb9b3748841bba22
Re: [PR] Fix missing dashboard settings in Kubernetes Service [skywalking]
wu-sheng merged PR #12078: URL: https://github.com/apache/skywalking/pull/12078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch master updated: Fix missing dashboard settings (#12078)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 8dd842189d Fix missing dashboard settings (#12078)
8dd842189d is described below
commit 8dd842189d4cf4df817dfb437ded5673023c3451
Author: mrproliu <741550...@qq.com>
AuthorDate: Mon Apr 8 09:33:20 2024 +
Fix missing dashboard settings (#12078)
---
.../k8s_service/k8s-service-service.json | 47 +-
1 file changed, 46 insertions(+), 1 deletion(-)
diff --git
a/oap-server/server-starter/src/main/resources/ui-initialized-templates/k8s_service/k8s-service-service.json
b/oap-server/server-starter/src/main/resources/ui-initialized-templates/k8s_service/k8s-service-service.json
index ec6ad8b0dd..a58edb7684 100644
---
a/oap-server/server-starter/src/main/resources/ui-initialized-templates/k8s_service/k8s-service-service.json
+++
b/oap-server/server-starter/src/main/resources/ui-initialized-templates/k8s_service/k8s-service-service.json
@@ -2074,7 +2074,52 @@
"layer": "K8S_SERVICE",
"entity": "Service",
"name": "K8S-Service-Service",
- "id": "K8S-Service-Service"
+ "id": "K8S-Service-Service",
+ "isDefault": true,
+ "expressions": [
+"latest(k8s_service_pod_total)",
+"latest(k8s_service_cpu_cores_requests)",
+"latest(k8s_service_cpu_cores_limits)",
+"avg(kubernetes_service_write_package_size)/60",
+
+"avg(kubernetes_service_read_package_size)/60",
+"avg(kubernetes_service_http_call_cpm)",
+
"avg(kubernetes_service_http_call_duration/kubernetes_service_http_call_cpm/100)",
+"avg(kubernetes_service_http_call_success_count /
kubernetes_service_http_call_cpm*100)"
+ ],
+ "expressionsConfig": [
+{
+ "label": "Pod Total"
+},
+{
+ "unit": "m",
+ "label": "CPU Requests"
+},
+{
+ "unit": "m",
+ "label": "CPU Limits"
+},
+{
+ "unit": "bytes / s",
+ "label": "Write"
+},
+{
+ "unit": "bytes / s",
+ "label": "Read"
+},
+{
+ "label": "HTTP Load",
+ "unit": "calls / min"
+},
+{
+ "label": "HTTP Latency",
+ "unit": "ms"
+},
+{
+ "label": "HTTP Success Rate",
+ "unit": "%"
+}
+ ]
}
}
]
\ No newline at end of file
Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]
CodePrometheus commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r113183 ## Makefile.in: ## @@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss ES_IMAGE_TAG ?= 7.10.2 SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap -SW_OAP_IMAGE_TAG ?= 8fad0cc8a822a3b266e528b30295e1376b956f1d +SW_OAP_IMAGE_TAG ?= 48c96a233103ba869143062923d4033678b91f73 SW_UI_IMAGE ?= ghcr.io/apache/skywalking/ui -SW_UI_IMAGE_TAG ?= 8fad0cc8a822a3b266e528b30295e1376b956f1d +SW_UI_IMAGE_TAG ?= 8bc67614681b37623fa64233f8389d6754e64cf2 Review Comment: OMG I made a stupid mistake, could we postpone the deployment? I'll fix it later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix missing dashboard settings in Kubernetes Service [skywalking]
songzhendong commented on code in PR #12078: URL: https://github.com/apache/skywalking/pull/12078#discussion_r1555498953 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/k8s_service/k8s-service-service.json: ## @@ -2074,7 +2074,52 @@ "layer": "K8S_SERVICE", "entity": "Service", "name": "K8S-Service-Service", - "id": "K8S-Service-Service" + "id": "K8S-Service-Service", + "isDefault": true, Review Comment: Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix missing dashboard settings in Kubernetes Service [skywalking]
wu-sheng commented on code in PR #12078: URL: https://github.com/apache/skywalking/pull/12078#discussion_r1555492972 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/k8s_service/k8s-service-service.json: ## @@ -2074,7 +2074,52 @@ "layer": "K8S_SERVICE", "entity": "Service", "name": "K8S-Service-Service", - "id": "K8S-Service-Service" + "id": "K8S-Service-Service", + "isDefault": true, Review Comment: @songzhendong This is the key config to fix dashboard popup about https://github.com/apache/skywalking/pull/12072. That is the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix missing dashboard settings in Kubernetes Service [skywalking]
mrproliu opened a new pull request, #12078: URL: https://github.com/apache/skywalking/pull/12078 In https://github.com/apache/skywalking/pull/12018, I lost [some template configurations](https://github.com/apache/skywalking/pull/12018/files#diff-e0274854744e889f9733a23051ea6e16f1412f798d98ae0ee81e6fcd8f474768L1940-L1983) and fixed them in this PR. - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-java-client) branch bump-api deleted (was 81752ec)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch bump-api in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git was 81752ec Bump api The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(skywalking-banyandb-java-client) branch main updated: [Breaking change] Bump APIs (#53)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
The following commit(s) were added to refs/heads/main by this push:
new e6f2dbe [Breaking change] Bump APIs (#53)
e6f2dbe is described below
commit e6f2dbe0f095024b05a7a59a4439deed5c33c7ee
Author: Gao Hongtao
AuthorDate: Mon Apr 8 16:27:49 2024 +0800
[Breaking change] Bump APIs (#53)
---
CHANGES.md | 1 +
.../banyandb/v1/client/metadata/Group.java | 19 ++
.../banyandb/v1/client/metadata/IndexRule.java | 47 +++---
src/main/proto/banyandb/v1/banyandb-common.proto | 11 ++--
src/main/proto/banyandb/v1/banyandb-database.proto | 72 ++
.../v1/client/BanyanDBClientMeasureQueryTest.java | 2 +-
.../v1/client/BanyanDBClientMeasureWriteTest.java | 2 +-
.../v1/client/BanyanDBClientStreamQueryTest.java | 2 +-
.../v1/client/BanyanDBClientStreamWriteTest.java | 2 +-
.../banyandb/v1/client/BanyanDBClientTestCI.java | 4 +-
.../v1/client/ITBanyanDBMeasureQueryTests.java | 4 +-
.../v1/client/ITBanyanDBStreamQueryTests.java | 4 +-
.../metadata/IndexRuleMetadataRegistryTest.java| 8 +--
.../metadata/MeasureMetadataRegistryTest.java | 6 +-
.../metadata/StreamMetadataRegistryTest.java | 6 +-
15 files changed, 72 insertions(+), 118 deletions(-)
diff --git a/CHANGES.md b/CHANGES.md
index e0880fc..6191db1 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -8,6 +8,7 @@ Release Notes.
### Features
* Support JDK21 build. Upgrade lombok version to 1.18.30.
+* Bump up the API of BanyanDB Server.
### Bugs
diff --git
a/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/Group.java
b/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/Group.java
index 4fcca7d..0d7cb09 100644
--- a/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/Group.java
+++ b/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/Group.java
@@ -38,37 +38,32 @@ public abstract class Group extends
NamedSchema {
*/
abstract int shardNum();
-@Nullable
-abstract IntervalRule blockInterval();
-
@Nullable
abstract IntervalRule segmentInterval();
@Nullable
abstract IntervalRule ttl();
-public static Group create(String name, Catalog catalog, int shardNum,
IntervalRule blockInterval, IntervalRule segmentInterval, IntervalRule ttl) {
+public static Group create(String name, Catalog catalog, int shardNum,
IntervalRule segmentInterval, IntervalRule ttl) {
Preconditions.checkArgument(shardNum > 0, "shardNum should more than
0");
-Preconditions.checkNotNull(blockInterval, "blockInterval is null");
Preconditions.checkNotNull(segmentInterval, "segmentInterval is null");
Preconditions.checkNotNull(ttl, "ttl is null");
-return new AutoValue_Group(null, name, null, catalog, shardNum,
blockInterval, segmentInterval, ttl);
+return new AutoValue_Group(null, name, null, catalog, shardNum,
segmentInterval, ttl);
}
-public static Group create(String name, Catalog catalog, int shardNum,
IntervalRule blockInterval, IntervalRule segmentInterval, IntervalRule ttl,
ZonedDateTime updatedAt) {
+public static Group create(String name, Catalog catalog, int shardNum,
IntervalRule segmentInterval, IntervalRule ttl, ZonedDateTime updatedAt) {
Preconditions.checkArgument(shardNum > 0, "shardNum should more than
0");
-Preconditions.checkNotNull(blockInterval, "blockInterval is null");
Preconditions.checkNotNull(segmentInterval, "segmentInterval is null");
Preconditions.checkNotNull(ttl, "ttl is null");
-return new AutoValue_Group(null, name, updatedAt, catalog, shardNum,
blockInterval, segmentInterval, ttl);
+return new AutoValue_Group(null, name, updatedAt, catalog, shardNum,
segmentInterval, ttl);
}
public static Group create(String name) {
-return new AutoValue_Group(null, name, null, Catalog.UNSPECIFIED, 0,
null, null, null);
+return new AutoValue_Group(null, name, null, Catalog.UNSPECIFIED, 0,
null, null);
}
public static Group create(String name, ZonedDateTime updatedAt) {
-return new AutoValue_Group(null, name, updatedAt, Catalog.UNSPECIFIED,
0, null, null, null);
+return new AutoValue_Group(null, name, updatedAt, Catalog.UNSPECIFIED,
0, null, null);
}
@Override
@@ -80,7 +75,6 @@ public abstract class Group extends
NamedSchema {
if (shardNum() > 0) {
builder.setResourceOpts(BanyandbCommon.ResourceOpts.newBuilder()
.setShardNum(shardNum())
-.setBlockInterval(blockInterval().serialize())
.setSegmentInterval(segmentInterval().serialize())
Re: [PR] Bump up the API of BanyanDB Server [skywalking-banyandb-java-client]
wu-sheng merged PR #53: URL: https://github.com/apache/skywalking-banyandb-java-client/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-showcase) branch main updated: fix UI Tag
This is an automated email from the ASF dual-hosted git repository. wankai pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-showcase.git The following commit(s) were added to refs/heads/main by this push: new 6ae9862 fix UI Tag 6ae9862 is described below commit 6ae98621e2fc352d6452991c1e553ba3dae7c1d7 Author: Wan Kai AuthorDate: Mon Apr 8 16:26:42 2024 +0800 fix UI Tag --- Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.in b/Makefile.in index 566e680..878aa85 100644 --- a/Makefile.in +++ b/Makefile.in @@ -32,7 +32,7 @@ SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap SW_OAP_IMAGE_TAG ?= 48c96a233103ba869143062923d4033678b91f73 SW_UI_IMAGE ?= ghcr.io/apache/skywalking/ui -SW_UI_IMAGE_TAG ?= 8bc67614681b37623fa64233f8389d6754e64cf2 +SW_UI_IMAGE_TAG ?= 48c96a233103ba869143062923d4033678b91f73 SW_CLI_IMAGE ?= ghcr.io/apache/skywalking-cli/skywalking-cli:0883266bfaa36612927b69e35781b64ea181758d SW_EVENT_EXPORTER_IMAGE ?= ghcr.io/apache/skywalking-kubernetes-event-exporter/skywalking-kubernetes-event-exporter:8a012a3f968cb139f817189afb9b3748841bba22
Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]
wu-sheng commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1555418807 ## Makefile.in: ## @@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss ES_IMAGE_TAG ?= 7.10.2 SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap -SW_OAP_IMAGE_TAG ?= 8fad0cc8a822a3b266e528b30295e1376b956f1d +SW_OAP_IMAGE_TAG ?= 48c96a233103ba869143062923d4033678b91f73 SW_UI_IMAGE ?= ghcr.io/apache/skywalking/ui -SW_UI_IMAGE_TAG ?= 8fad0cc8a822a3b266e528b30295e1376b956f1d +SW_UI_IMAGE_TAG ?= 8bc67614681b37623fa64233f8389d6754e64cf2 Review Comment: This is dev stage image repo, https://github.com/apache/skywalking/pkgs/container/skywalking%2Fui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix docker configurations and bump up images [skywalking-showcase]
wu-sheng commented on code in PR #167: URL: https://github.com/apache/skywalking-showcase/pull/167#discussion_r1555418336 ## Makefile.in: ## @@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss ES_IMAGE_TAG ?= 7.10.2 SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap -SW_OAP_IMAGE_TAG ?= 8fad0cc8a822a3b266e528b30295e1376b956f1d +SW_OAP_IMAGE_TAG ?= 48c96a233103ba869143062923d4033678b91f73 SW_UI_IMAGE ?= ghcr.io/apache/skywalking/ui -SW_UI_IMAGE_TAG ?= 8fad0cc8a822a3b266e528b30295e1376b956f1d +SW_UI_IMAGE_TAG ?= 8bc67614681b37623fa64233f8389d6754e64cf2 Review Comment: You are putting a wrong commit ID. The UI image is packaged in the main repository, not UI. And you should verify this locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump up the API of BanyanDB Server [skywalking-banyandb-java-client]
hanahmily opened a new pull request, #53: URL: https://github.com/apache/skywalking-banyandb-java-client/pull/53 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-java-client) branch bump-api updated (0dcb1e0 -> 81752ec)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch bump-api in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git discard 0dcb1e0 Bump api new 81752ec Bump api This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (0dcb1e0) \ N -- N -- N refs/heads/bump-api (81752ec) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.md | 1 + 1 file changed, 1 insertion(+)
(skywalking-banyandb-java-client) 01/01: Bump api
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch bump-api
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
commit 81752ec52a516b01410f73c881a1dbb58b41d2f3
Author: Gao Hongtao
AuthorDate: Mon Apr 8 07:25:09 2024 +0800
Bump api
Signed-off-by: Gao Hongtao
---
CHANGES.md | 1 +
.../banyandb/v1/client/metadata/Group.java | 19 ++
.../banyandb/v1/client/metadata/IndexRule.java | 47 +++---
src/main/proto/banyandb/v1/banyandb-common.proto | 11 ++--
src/main/proto/banyandb/v1/banyandb-database.proto | 72 ++
.../v1/client/BanyanDBClientMeasureQueryTest.java | 2 +-
.../v1/client/BanyanDBClientMeasureWriteTest.java | 2 +-
.../v1/client/BanyanDBClientStreamQueryTest.java | 2 +-
.../v1/client/BanyanDBClientStreamWriteTest.java | 2 +-
.../banyandb/v1/client/BanyanDBClientTestCI.java | 4 +-
.../v1/client/ITBanyanDBMeasureQueryTests.java | 4 +-
.../v1/client/ITBanyanDBStreamQueryTests.java | 4 +-
.../metadata/IndexRuleMetadataRegistryTest.java| 8 +--
.../metadata/MeasureMetadataRegistryTest.java | 6 +-
.../metadata/StreamMetadataRegistryTest.java | 6 +-
15 files changed, 72 insertions(+), 118 deletions(-)
diff --git a/CHANGES.md b/CHANGES.md
index e0880fc..6191db1 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -8,6 +8,7 @@ Release Notes.
### Features
* Support JDK21 build. Upgrade lombok version to 1.18.30.
+* Bump up the API of BanyanDB Server.
### Bugs
diff --git
a/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/Group.java
b/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/Group.java
index 4fcca7d..0d7cb09 100644
--- a/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/Group.java
+++ b/src/main/java/org/apache/skywalking/banyandb/v1/client/metadata/Group.java
@@ -38,37 +38,32 @@ public abstract class Group extends
NamedSchema {
*/
abstract int shardNum();
-@Nullable
-abstract IntervalRule blockInterval();
-
@Nullable
abstract IntervalRule segmentInterval();
@Nullable
abstract IntervalRule ttl();
-public static Group create(String name, Catalog catalog, int shardNum,
IntervalRule blockInterval, IntervalRule segmentInterval, IntervalRule ttl) {
+public static Group create(String name, Catalog catalog, int shardNum,
IntervalRule segmentInterval, IntervalRule ttl) {
Preconditions.checkArgument(shardNum > 0, "shardNum should more than
0");
-Preconditions.checkNotNull(blockInterval, "blockInterval is null");
Preconditions.checkNotNull(segmentInterval, "segmentInterval is null");
Preconditions.checkNotNull(ttl, "ttl is null");
-return new AutoValue_Group(null, name, null, catalog, shardNum,
blockInterval, segmentInterval, ttl);
+return new AutoValue_Group(null, name, null, catalog, shardNum,
segmentInterval, ttl);
}
-public static Group create(String name, Catalog catalog, int shardNum,
IntervalRule blockInterval, IntervalRule segmentInterval, IntervalRule ttl,
ZonedDateTime updatedAt) {
+public static Group create(String name, Catalog catalog, int shardNum,
IntervalRule segmentInterval, IntervalRule ttl, ZonedDateTime updatedAt) {
Preconditions.checkArgument(shardNum > 0, "shardNum should more than
0");
-Preconditions.checkNotNull(blockInterval, "blockInterval is null");
Preconditions.checkNotNull(segmentInterval, "segmentInterval is null");
Preconditions.checkNotNull(ttl, "ttl is null");
-return new AutoValue_Group(null, name, updatedAt, catalog, shardNum,
blockInterval, segmentInterval, ttl);
+return new AutoValue_Group(null, name, updatedAt, catalog, shardNum,
segmentInterval, ttl);
}
public static Group create(String name) {
-return new AutoValue_Group(null, name, null, Catalog.UNSPECIFIED, 0,
null, null, null);
+return new AutoValue_Group(null, name, null, Catalog.UNSPECIFIED, 0,
null, null);
}
public static Group create(String name, ZonedDateTime updatedAt) {
-return new AutoValue_Group(null, name, updatedAt, Catalog.UNSPECIFIED,
0, null, null, null);
+return new AutoValue_Group(null, name, updatedAt, Catalog.UNSPECIFIED,
0, null, null);
}
@Override
@@ -80,7 +75,6 @@ public abstract class Group extends
NamedSchema {
if (shardNum() > 0) {
builder.setResourceOpts(BanyandbCommon.ResourceOpts.newBuilder()
.setShardNum(shardNum())
-.setBlockInterval(blockInterval().serialize())
.setSegmentInterval(segmentInterval().serialize())
.setTtl(ttl().serialize())
.build());
@@ -104,7 +98,6 @@ public abstract class Group
[PR] Add Top N Aggregation to web app [skywalking-banyandb]
Sylvie-Wxr opened a new pull request, #430: URL: https://github.com/apache/skywalking-banyandb/pull/430 ### - [ ] If this is non-trivial feature, paste the links/URLs to the design doc. - [ ] Update the documentation to include this new feature. - [ ] Tests(including UT, IT, E2E) are added to verify the new feature. - [x] If it's UI related, attach the screenshots below. - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#12017. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). ### Feature Demo **Read TopNAggregation** https://github.com/apache/skywalking-banyandb/assets/129717259/1c967746-562d-4260-bd42-53d7be6c39fa **Create TopNAggregation** https://github.com/apache/skywalking-banyandb/assets/129717259/859fe0f9-612d-4b84-ac6e-3b1fd2511b47 **Edit TopNAggregation** https://github.com/apache/skywalking-banyandb/assets/129717259/db2ab29b-3aa7-49af-a245-9a47861d1c51 **Delete TopNAggregation** https://github.com/apache/skywalking-banyandb/assets/129717259/0b6abf43-5cd2-4e13-a8b4-2675113e4131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-showcase docker deployment has some incorrect parts [skywalking]
yswdqz commented on issue #12077: URL: https://github.com/apache/skywalking/issues/12077#issuecomment-2042009921 > Can you elaborate? OAP is required to be up and running for those components that need to talk to OAP, in your > screenshot, the vm exporter needs to send data to OAP so it needs to wait for OAP's readiness Maybe we just need VM-monitor feature, and I just want run with "make deploy.docker FEATURE_FLAGS=vm"(not FEATURE_FLAGS=vm,single-node) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-showcase docker deployment has some incorrect parts [skywalking]
yswdqz commented on issue #12077: URL: https://github.com/apache/skywalking/issues/12077#issuecomment-2042004975 Yes, but I might not have much time recently. I'll submit the PR over the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-showcase docker deployment has some incorrect parts [skywalking]
kezhenxu94 commented on issue #12077: URL: https://github.com/apache/skywalking/issues/12077#issuecomment-2041994460 > 1. rocketmq-feature seems incorrect: > > https://private-user-images.githubusercontent.com/74546965/320372769-453f26fe-2486-4fa0-92f3-efe43e21599d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI1NTkyNTksIm5iZiI6MTcxMjU1ODk1OSwicGF0aCI6Ii83NDU0Njk2NS8zMjAzNzI3NjktNDUzZjI2ZmUtMjQ4Ni00ZmEwLTkyZjMtZWZlNDNlMjE1OTlkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDA4VDA2NDkxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVjM2IzOWJjNmFhZWUyYWRlN2E4YTJlZmM1YmQ0NDU0MGQ2OTE4NGRhMjk4Y2I3NzQxMzQwNzJhMTg0MjdlM2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.lquFeeCdN7A5JyD69XwqxEIW-BC6ZnF-uNx7Ukeo_Oc;> I believe that a feature should utilize a common OAP(such as single-node) instead of spinning up a new one. Additionally, there are issues with the configuration of this OAP. Nice catch! I think we can fix this by simply removing the OAP section in this docker compose file. > 2. whether we need to expose this port? > > https://private-user-images.githubusercontent.com/74546965/320374139-9090f8f7-aeda-4b8e-9cec-87f22c302de3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI1NTkyNTksIm5iZiI6MTcxMjU1ODk1OSwicGF0aCI6Ii83NDU0Njk2NS8zMjAzNzQxMzktOTA5MGY4ZjctYWVkYS00YjhlLTljZWMtODdmMjJjMzAyZGUzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDA4VDA2NDkxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkwN2FjYjNhNDkxOGJkM2RiMjQ0ZmU5MjEyOThiM2M3NDg1ZmQ2NjdkZDYzYThmYjFjNWU3ZDE4ZTM0OWEyZTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.L4B8mNfInUIeT3AXJJJAjXCPflqEzUvEVw4sTdEBDvM;> This is not mandatory as we have a loadgen to trigger traffic, however, if users want to manually trigger traffic, they can open this port in their browser. > 3. oap dependency > > https://private-user-images.githubusercontent.com/74546965/320374564-974c244e-d217-434f-b9f0-bf8a3b1c5915.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI1NTkyNTksIm5iZiI6MTcxMjU1ODk1OSwicGF0aCI6Ii83NDU0Njk2NS8zMjAzNzQ1NjQtOTc0YzI0NGUtZDIxNy00MzRmLWI5ZjAtYmY4YTNiMWM1OTE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDA4VDA2NDkxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUyYmM5YjMxODliMDdlZWMwNjFiNmYwZDFkYzU4YmZmNTRjZGQwNjAyZGNlY2MzY2E1ZjIyMTc0OTk0OWEzN2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.sMEVeL07fpF7ged9QCTAQbV84xJDdtCoQwBFioGvtwI;> Some feature depend on oap. However, in some cases, we only need these services and do not require the built-in OAP. Can you elaborate? OAP is required to be up and running for those components that need to talk to OAP, in your screenshot, the vm exporter needs to send data to OAP so it needs to wait for OAP's readiness. > and also, some config files use oap as host: https://private-user-images.githubusercontent.com/74546965/320376116-8cd4c623-9394-482b-8755-3ddbc130c116.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI1NTkyNTksIm5iZiI6MTcxMjU1ODk1OSwicGF0aCI6Ii83NDU0Njk2NS8zMjAzNzYxMTYtOGNkNGM2MjMtOTM5NC00ODJiLTg3NTUtM2RkYmMxMzBjMTE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDA4VDA2NDkxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY4MDM2NzY0N2JjMzc5ODkxNTE1YWNjMGNmYjI2NmMxYjRhZDM2OWM4YTY5NDlkYjhjMmEyZjhjZTZmOWIyMjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.WsRYZXCM1anjGoGiBEoJNxbksBO11I3hEqhWz3KnZcI;> so we can't easily edit Makefile to change oap address. Good catch, this can be replace with the env var `BACKEND_SERVICE`. Will you file a pull request @yswdqz ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-showcase docker deployment has some incorrect parts [skywalking]
wu-sheng commented on issue #12077: URL: https://github.com/apache/skywalking/issues/12077#issuecomment-2041975023 @kezhenxu94 Could you guide @yswdqz about this? We may need to polish showcase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] skywalking-showcase docker deployment has some incorrect parts [skywalking]
yswdqz opened a new issue, #12077: URL: https://github.com/apache/skywalking/issues/12077 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component Showcase (apache/skywalking-showcase) ### What happened 1. rocketmq-feature seems incorrect: https://github.com/apache/skywalking/assets/74546965/453f26fe-2486-4fa0-92f3-efe43e21599d;> I believe that a feature should utilize a common OAP(such as single-node) instead of spinning up a new one. Additionally, there are issues with the configuration of this OAP. 2. whether we need to expose this port? https://github.com/apache/skywalking/assets/74546965/9090f8f7-aeda-4b8e-9cec-87f22c302de3;> 3. oap dependency https://github.com/apache/skywalking/assets/74546965/974c244e-d217-434f-b9f0-bf8a3b1c5915;> Some feature depend on oap. However, in some cases, we only need these services and do not require the built-in OAP. and also, some config files use oap as host: https://github.com/apache/skywalking/assets/74546965/8cd4c623-9394-482b-8755-3ddbc130c116;> so we can't easily edit Makefile to change oap address. https://github.com/apache/skywalking/assets/74546965/2ad3db87-bf2d-4b04-9b9e-5defcad7cf68;> ### What you expected to happen We can easily edit Makefile to change OAP localhost, fix rocketmq feature. ### How to reproduce None ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
