[I] [Feature] MQE support `sort/sort_labels` functions. [skywalking]
wankai123 opened a new issue, #12121: URL: https://github.com/apache/skywalking/issues/12121 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description - `sort` function: Sort the expression result values, support in ascending order and descending order. - `sort_labels`: Sort the expression result labels, support in ascending order and descending order. The order should be [natural sort order](https://en.wikipedia.org/wiki/Natural_sort_order) ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [X] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2060489465 OK, @wankai123 Let us skip that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
CzyerChen commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2060412678 > Are you saying this is recommended deployment for ActiveMQ on k8s? No unified domain namr for its cloud native deployment by adopting k8s DNS resolving mechanism? It needs to list the addresses of all brokers in the cluster now in ActiveMQ Classic(no specific description for K8S deployment). But after introducing `JGroups` auto-discovery from Artemis, the client no longer needs to list the addresses of all brokers in the cluster, only need the logical address of the cluster. For the Classic, there is no `nameserver` to provide a unified connection portal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-booster-ui) branch main updated: docs: update img of ActiveMQ (#388)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new f0012906 docs: update img of ActiveMQ (#388) f0012906 is described below commit f001290658bd10e825117f94c72572f27ae489c7 Author: Chen Ziyan AuthorDate: Wed Apr 17 12:35:41 2024 +0800 docs: update img of ActiveMQ (#388) --- src/assets/img/technologies/ACTIVEMQ.png | Bin 1653 -> 8689 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/src/assets/img/technologies/ACTIVEMQ.png b/src/assets/img/technologies/ACTIVEMQ.png old mode 100755 new mode 100644 index c60ec6e4..d242c9e5 Binary files a/src/assets/img/technologies/ACTIVEMQ.png and b/src/assets/img/technologies/ACTIVEMQ.png differ
Re: [PR] docs: update img of ActiveMQ [skywalking-booster-ui]
wu-sheng merged PR #388: URL: https://github.com/apache/skywalking-booster-ui/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch master updated: Fix hierarchy matching rule and add hierarchy env config and sync UI (#12120)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 630d54d963 Fix hierarchy matching rule and add hierarchy env config
and sync UI (#12120)
630d54d963 is described below
commit 630d54d963b2138e1355d32caa4526b5d5f57aa4
Author: Wan Kai
AuthorDate: Wed Apr 17 12:35:16 2024 +0800
Fix hierarchy matching rule and add hierarchy env config and sync UI
(#12120)
---
docs/en/changes/changes.md| 1 +
docs/en/concepts-and-designs/service-hierarchy-configuration.md | 4 ++--
docs/en/setup/backend/configuration-vocabulary.md | 3 ++-
oap-server/server-starter/src/main/resources/application.yml | 4
oap-server/server-starter/src/main/resources/hierarchy-definition.yml | 4 ++--
skywalking-ui | 2 +-
6 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index 8789812c14..96182ba96a 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -138,6 +138,7 @@
* Remove the General metric mode and related logical code.
* Remove metrics for unreal nodes in the topology.
* Enhance the Trace widget for batch consuming spans.
+* Clean the unused elements in the UI-templates.
Documentation
diff --git a/docs/en/concepts-and-designs/service-hierarchy-configuration.md
b/docs/en/concepts-and-designs/service-hierarchy-configuration.md
index 3daef37358..c09c8c1d1e 100644
--- a/docs/en/concepts-and-designs/service-hierarchy-configuration.md
+++ b/docs/en/concepts-and-designs/service-hierarchy-configuration.md
@@ -38,10 +38,10 @@ auto-matching-rules:
short-name: "{ (u, l) -> u.shortName == l.shortName }"
# remove the k8s namespace from the lower service short name
# this rule is only works on k8s env.
- lower-short-name-remove-ns: "{ (u, l) -> u.shortName ==
l.shortName.substring(0, l.shortName.lastIndexOf('.')) }"
+ lower-short-name-remove-ns: "{ (u, l) -> { if(l.shortName.lastIndexOf('.') >
0) return u.shortName == l.shortName.substring(0,
l.shortName.lastIndexOf('.')); return false; } }"
# the short name of the upper remove port is equal to the short name of the
lower service with fqdn suffix
# this rule is only works on k8s env.
- lower-short-name-with-fqdn: "{ (u, l) -> u.shortName.substring(0,
u.shortName.lastIndexOf(':')) == l.shortName.concat('.svc.cluster.local') }"
+ lower-short-name-with-fqdn: "{ (u, l) -> { if(u.shortName.lastIndexOf(':') >
0) return u.shortName.substring(0, u.shortName.lastIndexOf(':')) ==
l.shortName.concat('.svc.cluster.local'); return false; } }"
layer-levels:
# The hierarchy level of the service layer, the level is used to define the
order of the service layer for UI presentation.
diff --git a/docs/en/setup/backend/configuration-vocabulary.md
b/docs/en/setup/backend/configuration-vocabulary.md
index 2d843308d6..a76c44746f 100644
--- a/docs/en/setup/backend/configuration-vocabulary.md
+++ b/docs/en/setup/backend/configuration-vocabulary.md
@@ -49,6 +49,7 @@ The Configuration Vocabulary lists all available
configurations provided by `app
| - | - |
maxThreadCountOfQueryEBPFProfilingData
| The maximum thread count of query the eBPF profiling data from
database.
[...]
| - | - | uiMenuRefreshInterval
| The period(in seconds)
of refreshing the status of all UI menu items.
[...]
| - | - | serviceCacheRefreshInterval
| The period(in seconds)
of refreshing the service cache.
[...]
+| - | - | enableHierarchy
Re: [PR] Fix hierarchy matching rule and add hierarchy env config and sync UI [skywalking]
wu-sheng merged PR #12120: URL: https://github.com/apache/skywalking/pull/12120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2060295689 Typically in k8s, two or more deployment could be as one service, and failover could be done internally and natively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] docs: update img of ActiveMQ [skywalking-booster-ui]
CzyerChen commented on PR #388: URL: https://github.com/apache/skywalking-booster-ui/pull/388#issuecomment-2060295199 about logo: https://github.com/apache/skywalking-booster-ui/assets/22817918/4726f851-a336-4315-b072-71575f94bc3c";> in topology: https://github.com/apache/skywalking-booster-ui/assets/22817918/f43ebc24-8b81-4c90-be6f-51572af5616e";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2060293902 Are you saying this is recommended deployment for ActiveMQ on k8s? No unified domain namr for its cloud native deployment by adopting k8s DNS resolving mechanism? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch fix-gha-changes deleted (was bd3ffc0adf)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch fix-gha-changes in repository https://gitbox.apache.org/repos/asf/skywalking.git was bd3ffc0adf Explicit globstar is now required to match The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
CzyerChen commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2060289662 > > ` - VIRTUAL_MQ -> ACTIVEMQ` may have to check `cluster` mode, rather than single node. if client connected by `failover:(tcp://amq1:61616,tcp://amq2:61617)`, it may hard to continue service hierarchy. > > How could this be in k8s? I think K8s should be DNS oriented right? Even with a cluster, client should use service address like `activemq-svr.namespace.cluster`. > > VM deployment is complex, we are hard to make service hierarchy working in that deployment out-of-box. Normally we use failover transport to connect server node on client side, like `failover:(tcp://broker1.namespace.cluster:61616,tcp://broker2.namespace.cluster:61616,tcp://broker3.namespace.cluster:61616)?transportOptions` in K8S. In Master-Slave or Broker cluster mode, If just configure one node of Broker on client side, the failover will not work automatically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix hierarchy matching rule and add hierarchy env config and sync UI [skywalking]
wankai123 opened a new pull request, #12120: URL: https://github.com/apache/skywalking/pull/12120 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch master updated: Explicit globstar is now required to match (#12119)
This is an automated email from the ASF dual-hosted git repository.
yihaochen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new a9e27f651d Explicit globstar is now required to match (#12119)
a9e27f651d is described below
commit a9e27f651df2758d91ba8991e7bb9b21d696f213
Author: Superskyyy
AuthorDate: Tue Apr 16 23:14:36 2024 -0400
Explicit globstar is now required to match (#12119)
---
.github/workflows/skywalking.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/skywalking.yaml
b/.github/workflows/skywalking.yaml
index f773a07b6a..5a46af2118 100644
--- a/.github/workflows/skywalking.yaml
+++ b/.github/workflows/skywalking.yaml
@@ -122,7 +122,7 @@ jobs:
with:
files_ignore: |
**/*.{md,txt}
-skywalking-ui
+skywalking-ui/**
.asf.yaml
.dlc.json
.gitignore
@@ -148,7 +148,7 @@ jobs:
uses: tj-actions/changed-files@v43.0.0
with:
files: |
-skywalking-ui
+skywalking-ui/**
- name: List all modified files
if: steps.filter-oap.outputs.any_modified == 'true' ||
steps.filter-ui.outputs.any_modified == 'true' ||
steps.filter-pom.outputs.any_modified == 'true'
run: |
Re: [PR] Fix GHA changed files to match UI changes [skywalking]
Superskyyy merged PR #12119: URL: https://github.com/apache/skywalking/pull/12119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix GHA changed files to match UI changes [skywalking]
Superskyyy opened a new pull request, #12119: URL: https://github.com/apache/skywalking/pull/12119 GHA now requires explicit /** or / to avoid ambiguous matching. Adding /** will fix the previous issue encountered in https://github.com/apache/skywalking/pull/12102 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch fix-gha-changes updated: Explicit globstar is now required to match
This is an automated email from the ASF dual-hosted git repository.
yihaochen pushed a commit to branch fix-gha-changes
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/fix-gha-changes by this push:
new bd3ffc0adf Explicit globstar is now required to match
bd3ffc0adf is described below
commit bd3ffc0adf42b980e1f5f1dae470606923a85287
Author: Superskyyy
AuthorDate: Tue Apr 16 22:08:08 2024 -0400
Explicit globstar is now required to match
---
.github/workflows/skywalking.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/skywalking.yaml
b/.github/workflows/skywalking.yaml
index f773a07b6a..5a46af2118 100644
--- a/.github/workflows/skywalking.yaml
+++ b/.github/workflows/skywalking.yaml
@@ -122,7 +122,7 @@ jobs:
with:
files_ignore: |
**/*.{md,txt}
-skywalking-ui
+skywalking-ui/**
.asf.yaml
.dlc.json
.gitignore
@@ -148,7 +148,7 @@ jobs:
uses: tj-actions/changed-files@v43.0.0
with:
files: |
-skywalking-ui
+skywalking-ui/**
- name: List all modified files
if: steps.filter-oap.outputs.any_modified == 'true' ||
steps.filter-ui.outputs.any_modified == 'true' ||
steps.filter-pom.outputs.any_modified == 'true'
run: |
(skywalking) branch fix-gha-changes created (now bea7ed3f4a)
This is an automated email from the ASF dual-hosted git repository. yihaochen pushed a change to branch fix-gha-changes in repository https://gitbox.apache.org/repos/asf/skywalking.git at bea7ed3f4a Fix inaccurate APISIX metrics (#12108) No new revisions were added by this update.
Re: [PR] fix: css details [skywalking-booster-ui]
Fine0830 merged PR #391: URL: https://github.com/apache/skywalking-booster-ui/pull/391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-booster-ui) branch main updated: fix: css details (#391)
This is an automated email from the ASF dual-hosted git repository.
qiuxiafan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git
The following commit(s) were added to refs/heads/main by this push:
new 13b2693f fix: css details (#391)
13b2693f is described below
commit 13b2693f291903349ebaffa661092e2747141f1c
Author: Starry
AuthorDate: Wed Apr 17 09:53:43 2024 +0800
fix: css details (#391)
---
src/views/dashboard/controls/Trace.vue | 2 +-
src/views/dashboard/related/demand-log/Content.vue | 13 +
src/views/dashboard/related/trace/TraceList.vue | 3 ++-
.../dashboard/related/trace/components/D3Graph/Index.vue| 1 +
4 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/src/views/dashboard/controls/Trace.vue
b/src/views/dashboard/controls/Trace.vue
index 4db7e77a..61f3907b 100644
--- a/src/views/dashboard/controls/Trace.vue
+++ b/src/views/dashboard/controls/Trace.vue
@@ -183,7 +183,7 @@ limitations under the License. -->
.trace-line {
position: relative;
width: 2px;
-height: 900px;
+height: 100%;
background-color: #e8e8e8;
cursor: ew-resize;
diff --git a/src/views/dashboard/related/demand-log/Content.vue
b/src/views/dashboard/related/demand-log/Content.vue
index 5432498b..72d822f4 100644
--- a/src/views/dashboard/related/demand-log/Content.vue
+++ b/src/views/dashboard/related/demand-log/Content.vue
@@ -25,11 +25,14 @@ limitations under the License. -->
(skywalking-python) branch dependabot/pip/gunicorn-22.0.0 deleted (was 1e863bb)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/gunicorn-22.0.0 in repository https://gitbox.apache.org/repos/asf/skywalking-python.git was 1e863bb Bump gunicorn from 20.1.0 to 22.0.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump gunicorn from 20.1.0 to 22.0.0 [skywalking-python]
wu-sheng closed pull request #339: Bump gunicorn from 20.1.0 to 22.0.0 URL: https://github.com/apache/skywalking-python/pull/339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump gunicorn from 20.1.0 to 22.0.0 [skywalking-python]
dependabot[bot] commented on PR #339: URL: https://github.com/apache/skywalking-python/pull/339#issuecomment-2060195303 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-python) branch dependabot/pip/gunicorn-22.0.0 created (now 1e863bb)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/gunicorn-22.0.0 in repository https://gitbox.apache.org/repos/asf/skywalking-python.git at 1e863bb Bump gunicorn from 20.1.0 to 22.0.0 No new revisions were added by this update.
[PR] Bump gunicorn from 20.1.0 to 22.0.0 [skywalking-python]
dependabot[bot] opened a new pull request, #339:
URL: https://github.com/apache/skywalking-python/pull/339
Bumps [gunicorn](https://github.com/benoitc/gunicorn) from 20.1.0 to 22.0.0.
Release notes
Sourced from https://github.com/benoitc/gunicorn/releases";>gunicorn's
releases.
Gunicorn 22.0 has been released
Gunicorn 22.0.0 has been released. This version fix the
numerous security vulnerabilities. You're invited to upgrade asap your own
installation.
Changes:
22.0.0 - 2024-04-17
===
use utime to notify workers liveness
migrate setup to pyproject.toml
fix numerous security vulnerabilities in HTTP parser (closing some
request smuggling vectors)
parsing additional requests is no longer attempted past unsupported
request framing
on HTTP versions < 1.1 support for chunked transfer is refused (only
used in exploits)
requests conflicting configured or passed SCRIPT_NAME now produce a
verbose error
Trailer fields are no longer inspected for headers indicating secure
scheme
support Python 3.12
** Breaking changes **
minimum version is Python 3.7
the limitations on valid characters in the HTTP method have been bounded
to Internet Standards
requests specifying unsupported transfer coding (order) are refused by
default (rare)
HTTP methods are no longer casefolded by default (IANA method registry
contains none affected)
HTTP methods containing the number sign (#) are no longer accepted by
default (rare)
HTTP versions < 1.0 or >= 2.0 are no longer accepted by default
(rare, only HTTP/1.1 is supported)
HTTP versions consisting of multiple digits or containing a
prefix/suffix are no longer accepted
HTTP header field names Gunicorn cannot safely map to variables are
silently dropped, as in other software
HTTP headers with empty field name are refused by default (no legitimate
use cases, used in exploits)
requests with both Transfer-Encoding and Content-Length are refused by
default (such a message might indicate an attempt to perform request
smuggling)
empty transfer codings are no longer permitted (reportedly seen with
really old & broken proxies)
** SECURITY **
fix CVE-2024-1135
Documentation is available there: https://docs.gunicorn.org/en/stable/news.html";>https://docs.gunicorn.org/en/stable/news.html
Packages: https://pypi.org/project/gunicorn/";>https://pypi.org/project/gunicorn/
Gunicorn 21.2.0 has been released
Gunicorn 21.2.0 has been released. This version fix the
issue introduced in the threaded worker.
Changes:
21.2.0 - 2023-07-19
===
fix thread worker: revert change considering connection as idle .
... (truncated)
Commits
https://github.com/benoitc/gunicorn/commit/f63d59e4d73a8ee28748d2c700fb81c8780bc419";>f63d59e
bump to 22.0
https://github.com/benoitc/gunicorn/commit/4ac81e0a1037ba5b570323be7430e09caa233e38";>4ac81e0
Merge pull request https://redirect.github.com/benoitc/gunicorn/issues/3175";>#3175 from
e-kwsm/typo
https://github.com/benoitc/gunicorn/commit/401cecfaed85d79236c7a9a1f7d8946b01c466fc";>401cecf
Merge pull request https://redirect.github.com/benoitc/gunicorn/issues/3179";>#3179 from
dhdaines/exclude-eventlet-0360
https://github.com/benoitc/gunicorn/commit/0243ec39ef4fc1b479ff4e1659e165f0b980b571";>0243ec3
fix(deps): exclude eventlet 0.36.0
https://github.com/benoitc/gunicorn/commit/628a0bcb61ef3a211d67dfd68ad1ba161cccb3b8";>628a0bc
chore: fix typos
https://github.com/benoitc/gunicorn/commit/88fc4a43152039c28096c8ba3eeadb3fbaa4aff9";>88fc4a4
Merge pull request https://redirect.github.com/benoitc/gunicorn/issues/3131";>#3131 from
pajod/patch-py12-rebased
https://github.com/benoitc/gunicorn/commit/deae2fc4c5f93bfce59be5363055d4cd4ab1b0b6";>deae2fc
CI: back off the agressive timeout
https://github.com/benoitc/gunicorn/commit/f4703824c323fe6867dce0e2f11013b8de319353";>f470382
docs: promise 3.12 compat
https://github.com/benoitc/gunicorn/commit/5e30bfa6b1a3e1f2bde7feb514d1734d28f39231";>5e30bfa
add changelog to project.urls (updated for PEP621)
https://github.com/benoitc/gunicorn/commit/481c3f9522edc58806a3efc5b49be4f202cc7700";>481c3f9
remove setup.cfg - overridden by pyproject.toml
Additional commits viewable in https://github.com/benoitc/gunicorn/compare/20.1.0...22.0.0";>compare
view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2060163551 @CzyerChen How about the latest question? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: css details [skywalking-booster-ui]
CodePrometheus commented on PR #391: URL: https://github.com/apache/skywalking-booster-ui/pull/391#issuecomment-2060137572 summary: - Fix not clearing tips `.d3-tip` during resize - Fix when switching the global theme, the editor does not update the theme accordingly - Fix the trace list overflow problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
CzyerChen commented on code in PR #12109: URL: https://github.com/apache/skywalking/pull/12109#discussion_r1568068601 ## docs/en/swip/readme.md: ## @@ -72,6 +72,7 @@ Next SWIP Number: 6 ### Accepted SWIPs +- [SWIP-6 Support ActiveMQ Monitoring](SWIP-6.md) Review Comment: OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on code in PR #12109: URL: https://github.com/apache/skywalking/pull/12109#discussion_r1568049357 ## docs/en/swip/readme.md: ## @@ -72,6 +72,7 @@ Next SWIP Number: 6 ### Accepted SWIPs +- [SWIP-6 Support ActiveMQ Monitoring](SWIP-6.md) Review Comment: Could you update `Next SWIP Number: 6` to `Next SWIP Number: 8`? 7 was declared by https://github.com/apache/skywalking/discussions/12071, although it is not done yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: css details [skywalking-booster-ui]
wu-sheng commented on PR #391: URL: https://github.com/apache/skywalking-booster-ui/pull/391#issuecomment-2060070671 Could you describe what is the actual fix? It is hard to tell from video. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Tag family not showing up [skywalking]
Sylvie-Wxr commented on issue #12062: URL: https://github.com/apache/skywalking/issues/12062#issuecomment-2059640377 I found that this actually requires entering the tag family first, and then you can select from the dropdown, so the function is not problematic. It's just not very intuitive. I'll go ahead and close the issue first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Tag family not showing up [skywalking]
Sylvie-Wxr closed issue #12062: [Bug] Tag family not showing up URL: https://github.com/apache/skywalking/issues/12062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Tag family not showing up [skywalking]
Sylvie-Wxr commented on issue #12062: URL: https://github.com/apache/skywalking/issues/12062#issuecomment-2059641040 I found that this actually requires entering the tag family first, and then you can select from the dropdown, so the function is not problematic. It's just not very intuitive. I'll go ahead and close the issue first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix: css details [skywalking-booster-ui]
CodePrometheus opened a new pull request, #391: URL: https://github.com/apache/skywalking-booster-ui/pull/391 Video https://github.com/apache/skywalking-booster-ui/assets/66550292/e816b67a-00e3-46d1-b7de-cdc0baff13cf Signed-off-by: Zixin Zhou [codeprince2...@163.com](mailto:codeprince2...@163.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059417259 > ` - VIRTUAL_MQ -> ACTIVEMQ` may have to check `cluster` mode, rather than single node. if client connected by `failover:(tcp://amq1:61616,tcp://amq2:61617)`, it may hard to continue service hierarchy. How could this be in k8s? I think K8s should be DNS oriented right? Even with a cluster, client should use service address like `activemq-svr.namespace.cluster`. VM deployment is complex, we are hard to make service hierarchy working in that deployment out-of-box. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
CzyerChen commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059407787 > > part2 agent side needs to upgrade > > I think we could put the rules here once for all? As currently, the agent side has a totally different release period. The next(9.3) agent release could be 3 months later. ` - VIRTUAL_MQ -> ACTIVEMQ` may have to check `cluster` mode, rather than single node. if client connected by `failover:(tcp://amq1:61616,tcp://amq2:61617)`, it may hard to continue service hierarchy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059358163 > part2 agent side needs to upgrade I think we could put the rules here once for all? As currently, the agent side has a totally different release period. The next(9.3) agent release could be 3 months later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
CzyerChen commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059351595 > > > > > That rule should base on k8s deployment. Not VM. > > > > > > > > > > > > ActiveMQ agent side set Tags.MQ_BROKER = raw IP address:port, rather than hostname:port > > > > in K8S: ACTIVEMQ-SERVER(ip:port) -> VIRTUAL_MQ( ip:port ) : support service hierarchy VIRTUAL_MQ( ip:port ) -> ACTIVEMQ cluster monitoring(activemq.skywalking-showcase) : can not support service hierarchy ACTIVEMQ cluster monitoring(activemq.skywalking-showcase) -> K8S_SERVICE(skywalking-showcase::activemq.skywalking-showcase): support service hierarchy > > > > > > > > > About this, in k8s, > > > > > > * VIRTUAL_MQ( ip:port ) could be service name, is the activeMQ plugin(Java agent) resolving the Domain name and gets the IP? > > > * `ACTIVEMQ cluster monitoring(activemq.skywalking-showcase)` should be k8s service name, right? > > > > > > yes > > Let's separate this in two ways. > > 1. Service hierarchy is still working if you are building ActiveMQ server monitoring with K8s service monitoring. The hierarchy between those two isn't affected by the agent use case. > 2. About the agent is reporting the service IP, is this a good practice? I am thinking this because usually virtual MQ should be a logic concept, if the MQ is restarted by k8s, the IP could change, but DNS name would not. Nowadays, k8s deployment is very popular, and it is the key use case of the hierarchy feature, we only need to focus on that. How about add `remote.ip` tag for the actual IP, and use `peer` for domain name? Now part1 supported:  part2 agent side needs to upgrade    -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on code in PR #12109: URL: https://github.com/apache/skywalking/pull/12109#discussion_r1567548579 ## oap-server/server-starter/src/main/resources/hierarchy-definition.yml: ## @@ -60,6 +60,9 @@ hierarchy: PULSAR: K8S_SERVICE: short-name + ACTIVEMQ: +K8S_SERVICE: short-name Review Comment: How about the virtual MQ with this? Is that proposal possible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
CzyerChen commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059251979 > ACTIVEMQ-SERVER ~~ACTIVEMQ-SERVER~~ should be `ACTIVEMQ-CLIENT` collected by agent side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wankai123 commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059204723 > > @CzyerChen > > > ACTIVEMQ-SERVER(ip:port) -> VIRTUAL_MQ( ip:port ) > > > > > > Where is the `ACTIVEMQ-SERVER(ip:port)` data from？ > > Data reported by activeMQ plugin(Java agent). So, the `ACTIVEMQ-SERVER` should be an instance rather than a service？ If not, who does this IP belong to, a k8s service? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059189909 > > > > That rule should base on k8s deployment. Not VM. > > > > > > > > > ActiveMQ agent side set Tags.MQ_BROKER = raw IP address:port, rather than hostname:port > > > in K8S: ACTIVEMQ-SERVER(ip:port) -> VIRTUAL_MQ( ip:port ) : support service hierarchy VIRTUAL_MQ( ip:port ) -> ACTIVEMQ cluster monitoring(activemq.skywalking-showcase) : can not support service hierarchy ACTIVEMQ cluster monitoring(activemq.skywalking-showcase) -> K8S_SERVICE(skywalking-showcase::activemq.skywalking-showcase): support service hierarchy > > > > > > About this, in k8s, > > > > * VIRTUAL_MQ( ip:port ) could be service name, is the activeMQ plugin(Java agent) resolving the Domain name and gets the IP? > > * `ACTIVEMQ cluster monitoring(activemq.skywalking-showcase)` should be k8s service name, right? > > yes Let's separate this in two ways. 1. Service hierarchy is still working if you are building ActiveMQ server monitoring with K8s service monitoring. The hierarchy between those two isn't affected by the agent use case. 2. About the agent is reporting the service IP, is this a good practice? I am thinking this because usually virtual MQ should be a logic concept, if the MQ is restarted by k8s, the IP could change, but DNS name would not. Nowadays, k8s deployment is very popular, and it is the key use case of the hierarchy feature, we only need to focus on that. How about add `remote.ip` tag for the actual IP, and use `peer` for domain name? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
CzyerChen commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059170496 > @CzyerChen > > > ACTIVEMQ-SERVER(ip:port) -> VIRTUAL_MQ( ip:port ) > > Where is the `ACTIVEMQ-SERVER(ip:port)` data from？ Data reported by activeMQ plugin(Java agent). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
CzyerChen commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059167825 > > > That rule should base on k8s deployment. Not VM. > > > > > > ActiveMQ agent side set Tags.MQ_BROKER = raw IP address:port, rather than hostname:port > > in K8S: ACTIVEMQ-SERVER(ip:port) -> VIRTUAL_MQ( ip:port ) : support service hierarchy VIRTUAL_MQ( ip:port ) -> ACTIVEMQ cluster monitoring(activemq.skywalking-showcase) : can not support service hierarchy ACTIVEMQ cluster monitoring(activemq.skywalking-showcase) -> K8S_SERVICE(skywalking-showcase::activemq.skywalking-showcase): support service hierarchy > > About this, in k8s, > > * VIRTUAL_MQ( ip:port ) could be service name, is the activeMQ plugin(Java agent) resolving the Domain name and gets the IP? > * `ACTIVEMQ cluster monitoring(activemq.skywalking-showcase)` should be k8s service name, right? yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wankai123 commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059162414 @CzyerChen > ACTIVEMQ-SERVER(ip:port) -> VIRTUAL_MQ( ip:port ) Where is the `ACTIVEMQ-SERVER(ip:port)` data from？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059158259 > > That rule should base on k8s deployment. Not VM. > > ActiveMQ agent side set Tags.MQ_BROKER = raw IP address:port, rather than hostname:port > > in K8S: ACTIVEMQ-SERVER(ip:port) -> VIRTUAL_MQ( ip:port ) : support service hierarchy VIRTUAL_MQ( ip:port ) -> ACTIVEMQ cluster monitoring(activemq.skywalking-showcase) : can not support service hierarchy ACTIVEMQ cluster monitoring(activemq.skywalking-showcase) -> K8S_SERVICE(skywalking-showcase::activemq.skywalking-showcase): support service hierarchy About this, in k8s, - VIRTUAL_MQ( ip:port ) could be service name, is the activeMQ plugin(Java agent) resolving the Domain name and gets the IP? - `ACTIVEMQ cluster monitoring(activemq.skywalking-showcase)` should be k8s service name, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059126435 @CzyerChen As when ActiveMQ is deployed in k8s, OTEL collector should be able to use sidecar mode to get service name aligned with target service's name, and instance name as pod name. @weixiang1862 Do you know how to set up sidecar? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059121166 > > That rule should base on k8s deployment. Not VM. > > ActiveMQ agent side set Tags.MQ_BROKER = raw IP address:port, rather than hostname:port > > in K8S: ACTIVEMQ-SERVER(ip:port) -> VIRTUAL_MQ( ip:port ) : support service hierarchy VIRTUAL_MQ( ip:port ) -> ACTIVEMQ cluster monitoring(activemq.skywalking-showcase) : can not support service hierarchy ACTIVEMQ cluster monitoring(activemq.skywalking-showcase) -> K8S_SERVICE(skywalking-showcase::activemq.skywalking-showcase): support service hierarchy So, the name of the ActiveMQ service is hard coded only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059108385 Do we have IP-service name resolver to support in hierarchy detection? I think that would be useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
CzyerChen commented on PR #12109: URL: https://github.com/apache/skywalking/pull/12109#issuecomment-2059105159 > That rule should base on k8s deployment. Not VM. ActiveMQ agent side set Tags.MQ_BROKER = raw IP address:port, rather than hostname:port in K8S: ACTIVEMQ-SERVER(ip:port) -> VIRTUAL_MQ( ip:port ) : support service hierarchy VIRTUAL_MQ( ip:port ) -> ACTIVEMQ cluster monitoring(activemq.skywalking-showcase) : can not support service hierarchy ACTIVEMQ cluster monitoring(activemq.skywalking-showcase) -> K8S_SERVICE(skywalking-showcase::activemq.skywalking-showcase): support service hierarchy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] Quick start shell for latest release [skywalking]
wu-sheng commented on issue #11619: URL: https://github.com/apache/skywalking/issues/11619#issuecomment-2059093878 Done through https://skywalking.apache.org/docs/main/next/en/setup/backend/backend-docker/#start-the-storage-oap-and-booster-ui-with-docker-compose -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] Quick start shell for latest release [skywalking]
wu-sheng closed issue #11619: [Feature] Quick start shell for latest release URL: https://github.com/apache/skywalking/issues/11619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Feature] Remove Segment Retention and Rotation scheduler [skywalking]
hanahmily opened a new issue, #12117: URL: https://github.com/apache/skywalking/issues/12117 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description The segment undergoes a rotation and retention process to add new segments and remove expired data, which is scheduled to trigger at 5:00 AM every day. However, it is not feasible to replicate their behaviors in a short period of fewer than several hours. Therefore, I suggest that we base these operations on the latest ingested data's time. By doing so, we can create an integration test suite to verify the rotation and retention process with SkyWalking OAP. The primary objective of such a test is to ensure that BanyanDB can efficiently function for a minimum of seven days. ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: polish views without data [skywalking-booster-ui]
wu-sheng merged PR #390: URL: https://github.com/apache/skywalking-booster-ui/pull/390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-booster-ui) branch main updated: fix: polish (#390)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git
The following commit(s) were added to refs/heads/main by this push:
new 731d652a fix: polish (#390)
731d652a is described below
commit 731d652a7d6250d613b2ea1668171ade4f6afed9
Author: Fine0830
AuthorDate: Tue Apr 16 17:52:51 2024 +0800
fix: polish (#390)
---
src/components/Graph.vue | 10 --
src/views/dashboard/graphs/Table.vue | 12 +++-
src/views/dashboard/related/topology/pod/InstanceMap.vue | 6 --
.../dashboard/related/topology/service/HierarchyMap.vue | 6 --
src/views/dashboard/related/topology/service/ServiceMap.vue | 6 +++---
5 files changed, 26 insertions(+), 14 deletions(-)
diff --git a/src/components/Graph.vue b/src/components/Graph.vue
index 174d6de4..280bac4f 100644
--- a/src/components/Graph.vue
+++ b/src/components/Graph.vue
@@ -235,12 +235,10 @@ limitations under the License. -->
.no-data {
font-size: $font-size-smaller;
height: 100%;
-box-sizing: border-box;
-display: -webkit-box;
--webkit-box-orient: horizontal;
--webkit-box-pack: center;
--webkit-box-align: center;
-color: #666;
+align-items: center;
+justify-content: center;
+display: flex;
+color: var(--text-color-placeholder);
}
.chart {
diff --git a/src/views/dashboard/graphs/Table.vue
b/src/views/dashboard/graphs/Table.vue
index baaf2190..df563ac5 100644
--- a/src/views/dashboard/graphs/Table.vue
+++ b/src/views/dashboard/graphs/Table.vue
@@ -14,7 +14,7 @@ See the License for the specific language governing
permissions and
limitations under the License. -->
-
+
+ No Data
[PR] fix: polish views without data [skywalking-booster-ui]
Fine0830 opened a new pull request, #390: URL: https://github.com/apache/skywalking-booster-ui/pull/390 Screenshots https://github.com/apache/skywalking-booster-ui/assets/20871783/06e22a59-a381-475b-a874-58d9102c249b";> https://github.com/apache/skywalking-booster-ui/assets/20871783/6c64a714-7493-4628-af73-28b64c03ee9b";> Signed-off-by: Qiuxia Fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate APISIX metrics [skywalking]
wu-sheng merged PR #12108: URL: https://github.com/apache/skywalking/pull/12108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch master updated: Fix inaccurate APISIX metrics (#12108)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new bea7ed3f4a Fix inaccurate APISIX metrics (#12108)
bea7ed3f4a is described below
commit bea7ed3f4a3f5bca777bf69c7c8ea8d3d787c35a
Author: pg.yang
AuthorDate: Tue Apr 16 17:39:37 2024 +0800
Fix inaccurate APISIX metrics (#12108)
---
docs/en/api/metrics-query-expression.md| 3 ---
docs/en/changes/changes.md | 1 +
.../src/main/resources/otel-rules/apisix.yaml | 24 ++--
.../apisix/apisix-endpoint.json| 6 ++---
.../apisix/apisix-service.json | 26 +++---
test/e2e-v2/cases/apisix/apisix-cases.yaml | 4 ++--
6 files changed, 31 insertions(+), 33 deletions(-)
diff --git a/docs/en/api/metrics-query-expression.md
b/docs/en/api/metrics-query-expression.md
index fa2446e297..dfba7c2e41 100644
--- a/docs/en/api/metrics-query-expression.md
+++ b/docs/en/api/metrics-query-expression.md
@@ -251,9 +251,6 @@ The order of the new label values should be the same as the
order of the label v
For example:
If we want to query the `service_percentile` metric with the label values
`50,75,90,95,99`, and rename the label name to `percentile` and the label
values to `P50,P75,P90,P95,P99`, we can use the following expression:
-```text
-and rename the label values to `P50,P75,P90,P95,P99`, we can use the following
expression:
-
```text
relabel(service_percentile{p='50,75,90,95,99'}, p='50,75,90,95,99',
percentile='P50,P75,P90,P95,P99')
```
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index c530768508..8789812c14 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -105,6 +105,7 @@
- `memory_swap_percentage` -> `memory_virtual_memory_percentage`
* Fix/Change UI init setting for Windows Swap -> Virtual Memory
* Fix `Memory Swap Usage`/`Virtual Memory Usage` display with UI
init.(Linux/Windows)
+* Fix inaccurate APISIX metrics
UI
diff --git
a/oap-server/server-starter/src/main/resources/otel-rules/apisix.yaml
b/oap-server/server-starter/src/main/resources/otel-rules/apisix.yaml
index aa3e768b90..4334fb09f3 100644
--- a/oap-server/server-starter/src/main/resources/otel-rules/apisix.yaml
+++ b/oap-server/server-starter/src/main/resources/otel-rules/apisix.yaml
@@ -36,24 +36,24 @@ metricsRules:
# Service
# Ignore http_connections metrics with accepted and handled state as the
actual type is counter
- name: sv_http_connections
-exp:
apisix_nginx_http_current_connections.tagNotMatch('state','accepted|handled').sum(['state','service_name']).service(['service_name']
, Layer.APISIX)
+exp:
apisix_nginx_http_current_connections.tagNotMatch('state','accepted|handled').sum(['state','service_name','node']).service(['service_name']
, Layer.APISIX)
- name: sv_http_requests
-exp:
apisix_http_requests_total.sum(['service_instance_id','service_name']).rate('PT1M').service(['service_name']
, Layer.APISIX)
+exp:
apisix_http_requests_total.sum(['service_instance_id','service_name','node']).rate('PT1M').service(['service_name']
, Layer.APISIX)
# Not match any route
# Refer to https://apisix.apache.org/docs/apisix/plugins/prometheus/
- name: sv_bandwidth_unmatched
-exp: apisix_bandwidth.tagEqual('route' , '' , 'node' ,
'').sum(['type','service_name']).rate('PT1M').service(['service_name'] ,
Layer.APISIX)
+exp: apisix_bandwidth.tagEqual('route' , '' , 'node' ,
'').sum(['type','service_name','node']).rate('PT1M').service(['service_name'] ,
Layer.APISIX)
- name: sv_http_status_unmatched
-exp: apisix_http_status.tagEqual('route' , '' , 'node' ,
'').sum(['code','service_name']).rate('PT1M').service(['service_name'] ,
Layer.APISIX)
+exp: apisix_http_status.tagEqual('route' , '' , 'node' ,
'').sum(['code','service_name','node']).rate('PT1M').service(['service_name'] ,
Layer.APISIX)
- name: sv_http_latency_unmatched
-exp: apisix_http_latency.tagEqual('route' , '' , 'node' ,
'').sum(['type','le','service_name']).histogram().histogram_percentile([50,70,90,99]).service(['service_name']
, Layer.APISIX)
+exp: apisix_http_latency.tagEqual('route' , '' , 'node' ,
'').sum(['type','le','service_name','node']).histogram().histogram_percentile([50,70,90,99]).service(['service_name']
, Layer.APISIX)
# Match a route
- name: sv_bandwidth_matched
-exp: apisix_bandwidth.tagNotEqual('route' , '' , 'node' ,
'').sum(['type','service_name']).rate('PT1M').service(['service_name'] ,
Layer.APISIX)
+exp: apisix_bandwidth.tagNotEqual('route' , '' , 'node' ,
'').sum(['type','service_name','node']).rate('PT1M').service(['service_name'] ,
Layer.APISIX)
- name: sv_http_status_matched
-exp: apisix_http_status.tagNotEqual(
Re: [PR] Fix inaccurate APISIX metrics [skywalking]
pg-yang commented on code in PR #12108:
URL: https://github.com/apache/skywalking/pull/12108#discussion_r1566986852
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/apisix/apisix-service.json:
##
@@ -424,23 +424,23 @@
],
"expressionsConfig": [
{
- "unit": "req / s",
+ "unit": "req / s (per node)",
Review Comment:
Got it, first grouping by labels and then calculating the grouped result
across the timeline.
I have updated the expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug] Tag family not showing up [skywalking]
hanahmily commented on issue #12062: URL: https://github.com/apache/skywalking/issues/12062#issuecomment-2058562764 @Sylvie-Wxr Is there any update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch master updated: sync ui (#12113)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new bf19d641e4 sync ui (#12113) bf19d641e4 is described below commit bf19d641e4677befcc66313e39e448c0aad7b087 Author: Fine0830 AuthorDate: Tue Apr 16 16:40:29 2024 +0800 sync ui (#12113) --- skywalking-ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/skywalking-ui b/skywalking-ui index 12cd279c90..7f6e4d09c0 16 --- a/skywalking-ui +++ b/skywalking-ui @@ -1 +1 @@ -Subproject commit 12cd279c90a6843199aee16056f455582211d6d0 +Subproject commit 7f6e4d09c05a59c67564a8e601e2890a8bd83a2b
Re: [PR] Sync UI [skywalking]
wu-sheng merged PR #12113: URL: https://github.com/apache/skywalking/pull/12113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate APISIX metrics [skywalking]
pg-yang commented on code in PR #12108:
URL: https://github.com/apache/skywalking/pull/12108#discussion_r1566876489
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/apisix/apisix-service.json:
##
@@ -424,23 +424,23 @@
],
"expressionsConfig": [
{
- "unit": "req / s",
+ "unit": "req / s (per node)",
Review Comment:
Oops, they're different, I carefully consider these two expressions.
`meter_apisix_sv_http_status_matched{code='503'}` means querying all metrics
with 503 like the data below:
```
time-1:
{node=192.169.0.1,code=503} 12
{node=192.169.0.2,code=503} 13
time-2:
{node=192.169.0.1,code=503} 14
{node=192.169.0.2,code=503} 15
time-3:
{node=192.169.0.1,code=503} 16
{node=192.169.0.2,code=503} 17
```
`aggregate_labels(meter_apisix_sv_http_status_matched{code='503'},sum(code))`
will get
```
time-1:
{code=503} 12+13
time-2:
{code=503} 14+15
time-3:
{code=503} 16+17
```
`avg(aggregate_labels(meter_apisix_sv_http_status_matched{code='503'},sum(code)))`
will get
```
# A service with two nodes sent data for three times
(12+13+14+15+16+17)/3
```
`avg(meter_apisix_sv_http_status_matched{code='503'})` means
```
# The result means the average times of 503 occurred from all nodes in one
second,
(12+13+14+15+16+17)/6
```
Thanks for your help, I will change the expression soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix inaccurate APISIX metrics [skywalking]
wankai123 commented on code in PR #12108:
URL: https://github.com/apache/skywalking/pull/12108#discussion_r1566885580
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/apisix/apisix-service.json:
##
@@ -424,23 +424,23 @@
],
"expressionsConfig": [
{
- "unit": "req / s",
+ "unit": "req / s (per node)",
Review Comment:
by the way, `avg(meter_apisix_sv_http_status_matched{code='503'})` means:
```
{node=192.169.0.1,code=503} (12 + 14 + 16)/3
{node=192.169.0.2,code=503} (13 + 15 + 17)/3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix inaccurate APISIX metrics [skywalking]
pg-yang commented on code in PR #12108:
URL: https://github.com/apache/skywalking/pull/12108#discussion_r1566876489
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/apisix/apisix-service.json:
##
@@ -424,23 +424,23 @@
],
"expressionsConfig": [
{
- "unit": "req / s",
+ "unit": "req / s (per node)",
Review Comment:
Oops, they're different, I carefully consider these two expressions.
`meter_apisix_sv_http_status_matched{code='503'}` means querying all metrics
with 503 like the data below:
```
time-1:
{node=192.169.0.1,code=503} 12
{node=192.169.0.2,code=503} 13
time-2:
{node=192.169.0.1,code=503} 14
{node=192.169.0.2,code=503} 15
time-3:
{node=192.169.0.1,code=503} 16
{node=192.169.0.2,code=503} 17
```
`aggregate_labels(meter_apisix_sv_http_status_matched{code='503'},sum(code))`
will get
```
time-1:
{code=503} 12+13
time-2:
{code=503} 14+15
time-3:
{code=503} 16+17
```
`avg(aggregate_labels(meter_apisix_sv_http_status_matched{code='503'},sum(code)))`
will get
```
# A service with two nodes sent data for three times
(12+13+14+15)/3
```
`avg(meter_apisix_sv_http_status_matched{code='503'})` means
```
# The result means the average times of 503 occurred from all nodes in one
second,
(12+13+14+15)/6
```
Thanks for your help, I will change the expression soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug] Go-agent hybrid compilation under Windows platform cannot copy source files correctly [skywalking]
ShyunnY closed issue #12097: [Bug] Go-agent hybrid compilation under Windows platform cannot copy source files correctly URL: https://github.com/apache/skywalking/issues/12097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
weixiang1862 commented on code in PR #12109: URL: https://github.com/apache/skywalking/pull/12109#discussion_r1566835326 ## test/e2e-v2/cases/activemq/docker-compose.yml: ## @@ -0,0 +1,100 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +version: "2.1" + +services: + oap: +extends: + file: ../../script/docker-compose/base-compose.yml + service: oap +ports: + - "12800:12800" +networks: + - e2e + + amq: +image: apache/activemq-classic:6.0.1 +hostname: amq +ports: + - "61616:61616" + - "8161:8161" +expose: + - 1616 +volumes: Review Comment: Seems JMX export of activemq is not out-of-the-box and needs some configurations, could you add this part to `setup/backend/backend-activemq-monitoring.md` doc or add a ref of this case from there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix the Table widget [skywalking-booster-ui]
wu-sheng merged PR #389: URL: https://github.com/apache/skywalking-booster-ui/pull/389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ActiveMQ classic monitoring [skywalking]
wu-sheng commented on code in PR #12109:
URL: https://github.com/apache/skywalking/pull/12109#discussion_r1566821969
##
oap-server/server-starter/src/main/resources/ui-initialized-templates/activemq/activemq-destination.json:
##
@@ -0,0 +1,286 @@
+[
+ {
+"id": "ActiveMQ-Destination",
+"configuration": {
+ "children": [
+{
+ "x": 0,
+ "y": 0,
+ "w": 6,
+ "h": 11,
+ "i": "0",
+ "type": "Widget",
+ "id": "0",
+ "metricTypes": [],
+ "metrics": [],
+ "metricMode": "Expression",
+ "moved": false,
+ "expressions": [
+"meter_activemq_destination_producer_count"
+ ],
+ "typesOfMQE": [
+"TIME_SERIES_VALUES"
+ ],
Review Comment:
Fixed by https://github.com/apache/skywalking-booster-ui/pull/389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix the Table widget [skywalking-booster-ui]
wu-sheng commented on PR #389: URL: https://github.com/apache/skywalking-booster-ui/pull/389#issuecomment-2058373961 Could you sync the UI module? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-booster-ui) branch main updated: Fix the Table widget (#389)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git
The following commit(s) were added to refs/heads/main by this push:
new 7f6e4d09 Fix the Table widget (#389)
7f6e4d09 is described below
commit 7f6e4d09c05a59c67564a8e601e2890a8bd83a2b
Author: Fine0830
AuthorDate: Tue Apr 16 15:00:18 2024 +0800
Fix the Table widget (#389)
---
src/hooks/useExpressionsProcessor.ts | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/src/hooks/useExpressionsProcessor.ts
b/src/hooks/useExpressionsProcessor.ts
index 080469ae..0a346108 100644
--- a/src/hooks/useExpressionsProcessor.ts
+++ b/src/hooks/useExpressionsProcessor.ts
@@ -112,22 +112,7 @@ export async function useExpressionsQueryProcessor(config:
Indexable) {
tips.push(obj.error);
typesOfMQE.push(type);
if (!obj.error) {
-if (type === ExpressionResultType.TIME_SERIES_VALUES) {
- if (results.length === 1) {
-const label = results[0].metric && results[0].metric.labels[0] &&
results[0].metric.labels[0].value;
-source[c.label || label || name] = results[0].values.map((d: {
value: unknown }) => d.value) || [];
- } else {
-for (const item of results) {
- const values = item.values.map((d: { value: unknown }) =>
d.value) || [];
- const label = item.metric.labels
-.map((d: { key: string; value: string }) =>
`${d.key}=${d.value}`)
-.join(",");
-
- source[label] = values;
-}
- }
-}
-if (type === ExpressionResultType.SINGLE_VALUE) {
+if ([ExpressionResultType.SINGLE_VALUE,
ExpressionResultType.TIME_SERIES_VALUES].includes(type)) {
for (const item of results) {
const label =
item.metric &&
