[I] [Feature][BanyanDB] Support for Retrieving Data from Multiple Groups in a Single Query [skywalking]
hanahmily opened a new issue, #12134:
URL: https://github.com/apache/skywalking/issues/12134
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar feature requirement.
### Description
In BanyanDB, different versions of a dataset or schema changes are often
handled by creating new groups. This approach isolates data but can complicate
queries across schema versions. Suppose users need to access data across
different groups (such as during a schema migration or when querying historical
data alongside current data). In that case, they must perform separate queries
for each group and manually merge the results.
BanyanDB should support retrieving data from multiple groups in a single
query. This feature simplifies client code, reduces latency, and ensures
consistency across queried groups. The syntax could be extended to allow
specifying multiple group names in a query
```proto
message QueryRequest {
string name = 1
repeated string groups = 2
...
}
```
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a pull request to implement this on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
notifications-unsubscr...@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix inaccurate MySQL/MariaDB, Redis metrics [skywalking]
wankai123 commented on code in PR #12130: URL: https://github.com/apache/skywalking/pull/12130#discussion_r1571635907 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/mysql/mysql-service.json: ## @@ -292,32 +292,8 @@ "layer": "MYSQL", "entity": "Service", "name": "MySQL-Service", - "isRoot": false, - "isDefault": true, - "expressions": [ -"avg(meter_mysql_commands_select_rate)", -"avg(meter_mysql_commands_insert_rate)", -"avg(meter_mysql_commands_update_rate)", -"avg(meter_mysql_commands_delete_rate)" Review Comment: @yswdqz Are you using the latest UI version? It shouldn't delete the hierarchy part when export. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-java) branch main updated: Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. (#681) (#682)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
The following commit(s) were added to refs/heads/main by this push:
new 1a01047007 Fix NPE in handleMethodException method of
apm-jdk-threadpool-plugin. (#681) (#682)
1a01047007 is described below
commit 1a010470076ba7f206f4fd6559d04136bea73417
Author: ForrestWang123 <157256498+forrestwang...@users.noreply.github.com>
AuthorDate: Fri Apr 19 08:51:09 2024 +0800
Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin.
(#681) (#682)
Co-authored-by: forrestwang
---
.../plugin/AbstractThreadingPoolInterceptor.java | 32 --
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git
a/apm-sniffer/bootstrap-plugins/jdk-threadpool-plugin/src/main/java/org/apache/skywalking/apm/plugin/AbstractThreadingPoolInterceptor.java
b/apm-sniffer/bootstrap-plugins/jdk-threadpool-plugin/src/main/java/org/apache/skywalking/apm/plugin/AbstractThreadingPoolInterceptor.java
index c72c1424b5..e11c260f42 100644
---
a/apm-sniffer/bootstrap-plugins/jdk-threadpool-plugin/src/main/java/org/apache/skywalking/apm/plugin/AbstractThreadingPoolInterceptor.java
+++
b/apm-sniffer/bootstrap-plugins/jdk-threadpool-plugin/src/main/java/org/apache/skywalking/apm/plugin/AbstractThreadingPoolInterceptor.java
@@ -28,22 +28,11 @@ import java.lang.reflect.Method;
public abstract class AbstractThreadingPoolInterceptor implements
InstanceMethodsAroundInterceptor {
@Override
public void beforeMethod(EnhancedInstance objInst, Method method, Object[]
allArguments, Class[] argumentsTypes, MethodInterceptResult result) throws
Throwable {
-if (!ContextManager.isActive()) {
-return;
-}
-
-if (allArguments == null || allArguments.length < 1) {
-return;
-}
-
-Object argument = allArguments[0];
-
-// Avoid duplicate enhancement, such as the case where it has already
been enhanced by RunnableWrapper or CallableWrapper with toolkit.
-if (argument instanceof EnhancedInstance && ((EnhancedInstance)
argument).getSkyWalkingDynamicField() instanceof ContextSnapshot) {
+if (notToEnhance(allArguments)) {
return;
}
-Object wrappedObject = wrap(argument);
+Object wrappedObject = wrap(allArguments[0]);
if (wrappedObject != null) {
allArguments[0] = wrappedObject;
}
@@ -63,10 +52,25 @@ public abstract class AbstractThreadingPoolInterceptor
implements InstanceMethod
@Override
public void handleMethodException(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes, Throwable t) {
-if (!ContextManager.isActive()) {
+if (notToEnhance(allArguments)) {
return;
}
ContextManager.activeSpan().log(t);
}
+
+private boolean notToEnhance(Object[] allArguments) {
+if (!ContextManager.isActive()) {
+return true;
+}
+
+if (allArguments == null || allArguments.length < 1) {
+return true;
+}
+
+Object argument = allArguments[0];
+
+// Avoid duplicate enhancement, such as the case where it has already
been enhanced by RunnableWrapper or CallableWrapper with toolkit.
+return argument instanceof EnhancedInstance && ((EnhancedInstance)
argument).getSkyWalkingDynamicField() instanceof ContextSnapshot;
+}
}
Re: [PR] Polish NPE fix in handleMethodException method of apm-jdk-threadpool-plugin [skywalking-java]
wu-sheng merged PR #682: URL: https://github.com/apache/skywalking-java/pull/682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch master updated: blog: ActiveMQ Monitoring CN and EN (#700)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new bc74ce43d58 blog: ActiveMQ Monitoring CN and EN (#700) bc74ce43d58 is described below commit bc74ce43d58fa4f23ed5437f0ba7883f38245aa5 Author: Chen Ziyan AuthorDate: Fri Apr 19 08:40:25 2024 +0800 blog: ActiveMQ Monitoring CN and EN (#700) --- .../activemq_broker_panel.png | Bin 0 -> 460532 bytes .../activemq_cluster_panel.png | Bin 0 -> 288611 bytes .../activemq_destination_panel.png | Bin 0 -> 271591 bytes .../activemq_logo.png | Bin 0 -> 10527 bytes .../index.md | 225 + .../activemq_broker_panel.png | Bin 0 -> 460532 bytes .../activemq_cluster_panel.png | Bin 0 -> 288611 bytes .../activemq_destination_panel.png | Bin 0 -> 271591 bytes .../activemq_logo.png | Bin 0 -> 10527 bytes .../index.md | 225 + 10 files changed, 450 insertions(+) diff --git a/content/blog/2024-04-19-monitoring-activemq-through-skywalking/activemq_broker_panel.png b/content/blog/2024-04-19-monitoring-activemq-through-skywalking/activemq_broker_panel.png new file mode 100644 index 000..2bbc1f2a461 Binary files /dev/null and b/content/blog/2024-04-19-monitoring-activemq-through-skywalking/activemq_broker_panel.png differ diff --git a/content/blog/2024-04-19-monitoring-activemq-through-skywalking/activemq_cluster_panel.png b/content/blog/2024-04-19-monitoring-activemq-through-skywalking/activemq_cluster_panel.png new file mode 100644 index 000..eda70159776 Binary files /dev/null and b/content/blog/2024-04-19-monitoring-activemq-through-skywalking/activemq_cluster_panel.png differ diff --git a/content/blog/2024-04-19-monitoring-activemq-through-skywalking/activemq_destination_panel.png b/content/blog/2024-04-19-monitoring-activemq-through-skywalking/activemq_destination_panel.png new file mode 100644 index 000..ef0088233f5 Binary files /dev/null and b/content/blog/2024-04-19-monitoring-activemq-through-skywalking/activemq_destination_panel.png differ diff --git a/content/blog/2024-04-19-monitoring-activemq-through-skywalking/activemq_logo.png b/content/blog/2024-04-19-monitoring-activemq-through-skywalking/activemq_logo.png new file mode 100644 index 000..808a32e9f9b Binary files /dev/null and b/content/blog/2024-04-19-monitoring-activemq-through-skywalking/activemq_logo.png differ diff --git a/content/blog/2024-04-19-monitoring-activemq-through-skywalking/index.md b/content/blog/2024-04-19-monitoring-activemq-through-skywalking/index.md new file mode 100644 index 000..a4ceff5d673 --- /dev/null +++ b/content/blog/2024-04-19-monitoring-activemq-through-skywalking/index.md @@ -0,0 +1,225 @@ +--- +title: "Monitoring ActiveMQ through SkyWalking" +date: 2024-04-19 +author: Ziyan Chen +description: "This article will demonstrate the usage of the new ActiveMQ monitoring dashboard." +tags: +- ActiveMQ +--- + + + +## Introduction + +[Apache ActiveMQ Classic](https://activemq.apache.org/components/classic/) is a popular and powerful open-source messaging and integration pattern server. Founded in 2004, it has evolved into a mature and widely used open-source messaging middleware that complies with the `Java Message Service (JMS)`. +Today, with its stability and wide range of feature support, it still has a certain number of users of `small and medium-sized` enterprises. It‘s high-performance version [Apache Artemis](https://activemq.apache.org/components/artemis/) is developing rapidly and is also attracting attention from users of ActiveMQ. + +ActiveMQ has broad support for [JMX (Java Management Extensions)](https://docs.oracle.com/javase/tutorial/jmx/overview/index.html), allowing to be monitored through `JMX MBean`. +After enabling JMX, you can use JAVA's built-in `jconsole` or `VisualVM` to view the metrics. In addition, some Collector components can also be used to convert `JMX-style` data into `Prometheus-style` data, which is suitable for more tools. + +[OpenTelemetry](https://opentelemetry.io/) as an industry-recognized, standardized solution that provides consistent and interoperable telemetry data collection, transmission, and analysis capabilities for distributed systems, and is also used here for data collection and transmission. +Although it can directly accept `JMX` type data, the JMX indicators for collecting ActiveMQ are not in the standard library, and some versions are incompatible, so this article adopts two steps: convert `JMX data` into `Prometheus-style`
Re: [PR] blog: ActiveMQ Monitoring [skywalking-website]
wu-sheng merged PR #700: URL: https://github.com/apache/skywalking-website/pull/700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] blog: ActiveMQ Monitoring [skywalking-website]
wu-sheng commented on PR #700: URL: https://github.com/apache/skywalking-website/pull/700#issuecomment-2065546020 Thanks for bringing this up. It looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] blog: ActiveMQ Monitoring [skywalking-website]
netlify[bot] commented on PR #700: URL: https://github.com/apache/skywalking-website/pull/700#issuecomment-2065533049 ### Deploy Preview for *skywalking-website-preview* processing. | Name | Link | |:-:|| | Latest commit | f3b371b401cda1e96169bcc89d182b772eccf55f | | Latest deploy log | https://app.netlify.com/sites/skywalking-website-preview/deploys/6621ba78f2415400075fa6f4 | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] blog: ActiveMQ Monitoring [skywalking-website]
CzyerChen opened a new pull request, #700: URL: https://github.com/apache/skywalking-website/pull/700 Add blogs for monitoring ActiveMQ in EN & CN. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate MySQL/MariaDB, Redis metrics [skywalking]
wu-sheng commented on code in PR #12130: URL: https://github.com/apache/skywalking/pull/12130#discussion_r1571509612 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/postgresql/postgresql-service.json: ## @@ -448,31 +448,7 @@ "layer": "POSTGRESQL", "entity": "Service", "name": "PostgreSQL-Service", - "isDefault": true, - "expressions": [ -"avg(meter_pg_fetched_rows_rate)", -"avg(meter_pg_inserted_rows_rate)", -"avg(meter_pg_updated_rows_rate)", -"avg(meter_pg_deleted_rows_rate)" Review Comment: Same here ## oap-server/server-starter/src/main/resources/ui-initialized-templates/mysql/mysql-service.json: ## @@ -292,32 +292,8 @@ "layer": "MYSQL", "entity": "Service", "name": "MySQL-Service", - "isRoot": false, - "isDefault": true, - "expressions": [ -"avg(meter_mysql_commands_select_rate)", -"avg(meter_mysql_commands_insert_rate)", -"avg(meter_mysql_commands_update_rate)", -"avg(meter_mysql_commands_delete_rate)" Review Comment: Why are these removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin [skywalking-java]
wu-sheng commented on PR #682: URL: https://github.com/apache/skywalking-java/pull/682#issuecomment-2065483827 What is the new change about? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin [skywalking-java]
ForrestWang123 opened a new pull request, #682: URL: https://github.com/apache/skywalking-java/pull/682 ### Fix Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin - [ ] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it. - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #12128 - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate MySQL/MariaDB, Redis metrics [skywalking]
wankai123 commented on code in PR #12130:
URL: https://github.com/apache/skywalking/pull/12130#discussion_r1571025075
##
test/e2e-v2/cases/mariadb/expected/metrics-has-value-metric-null.yml:
##
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+type: TIME_SERIES_VALUES
+results:
+ {{- contains .results }}
+ - metric: null
Review Comment:
OK, I think I know why `null` of the meta here, I'll fix it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix inaccurate MySQL/MariaDB, Redis metrics [skywalking]
wu-sheng commented on PR #12130: URL: https://github.com/apache/skywalking/pull/12130#issuecomment-2063990184 Redis e2e fails, please fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Apache Airflow Monitoring [skywalking]
wu-sheng commented on PR #12072: URL: https://github.com/apache/skywalking/pull/12072#issuecomment-2063956604 No update for a week. @songzhendong If you want to continue to make this ready to merge, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] make MQE meta data not null [skywalking-query-protocol]
wu-sheng merged PR #132: URL: https://github.com/apache/skywalking-query-protocol/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-query-protocol) branch make-mqe-meta-not-null deleted (was f74557b)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch make-mqe-meta-not-null in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git was f74557b make MQE meta data not null The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(skywalking-query-protocol) branch master updated: make MQE meta data not null (#132)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git
The following commit(s) were added to refs/heads/master by this push:
new 9c0ffe1 make MQE meta data not null (#132)
9c0ffe1 is described below
commit 9c0ffe1a4be6c90d13bc03d6e9c8323415fe4534
Author: Wan Kai
AuthorDate: Thu Apr 18 22:06:06 2024 +0800
make MQE meta data not null (#132)
---
metrics-v3.graphqls | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/metrics-v3.graphqls b/metrics-v3.graphqls
index e8dbcbb..627dfdd 100644
--- a/metrics-v3.graphqls
+++ b/metrics-v3.graphqls
@@ -68,8 +68,8 @@ type MQEValue {
}
type MQEValues {
-# The metadata description of this value series. It could be NULL if it is
the result of the different metrics calculation.
-metric: Metadata
+# The metadata description of this value series.
+metric: Metadata!
# 1. When the type == SINGLE_VALUE, values only have one value.
# 2. When the type == TIME_SERIES_VALUES, values would match the given
elements in the duration range.
# 3. When the type == SORTED_LIST, values could be results of
`sort(metric)`
[PR] make MQE meta data not null [skywalking-query-protocol]
wankai123 opened a new pull request, #132: URL: https://github.com/apache/skywalking-query-protocol/pull/132 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-query-protocol) branch make-mqe-meta-not-null created (now f74557b)
This is an automated email from the ASF dual-hosted git repository. wankai pushed a change to branch make-mqe-meta-not-null in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git at f74557b make MQE meta data not null This branch includes the following new commits: new f74557b make MQE meta data not null The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(skywalking-query-protocol) 01/01: make MQE meta data not null
This is an automated email from the ASF dual-hosted git repository.
wankai pushed a commit to branch make-mqe-meta-not-null
in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git
commit f74557b29dc7bef2830786c4fe3e39e4a0919c98
Author: wankai123
AuthorDate: Thu Apr 18 22:02:01 2024 +0800
make MQE meta data not null
---
metrics-v3.graphqls | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/metrics-v3.graphqls b/metrics-v3.graphqls
index e8dbcbb..627dfdd 100644
--- a/metrics-v3.graphqls
+++ b/metrics-v3.graphqls
@@ -68,8 +68,8 @@ type MQEValue {
}
type MQEValues {
-# The metadata description of this value series. It could be NULL if it is
the result of the different metrics calculation.
-metric: Metadata
+# The metadata description of this value series.
+metric: Metadata!
# 1. When the type == SINGLE_VALUE, values only have one value.
# 2. When the type == TIME_SERIES_VALUES, values would match the given
elements in the duration range.
# 3. When the type == SORTED_LIST, values could be results of
`sort(metric)`
Re: [PR] Fix inaccurate MySQL/MariaDB, Redis metrics [skywalking]
wu-sheng commented on PR #12130: URL: https://github.com/apache/skywalking/pull/12130#issuecomment-2063896531 I think those service dashboards should be updated to use MQE to aggregate instance metrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-website) branch asf-site updated: deploy: 324527058968e82e68e65a3152fdaa1b80fadcbe
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new c619334c029 deploy: 324527058968e82e68e65a3152fdaa1b80fadcbe c619334c029 is described below commit c619334c0294bfebb248fe8237f270090c48d6da Author: wu-sheng AuthorDate: Thu Apr 18 13:35:18 2024 + deploy: 324527058968e82e68e65a3152fdaa1b80fadcbe --- contributors/index.html| 828 +++-- .../next/en/contribution/compiling/index.html | 2 +- .../en/contribution/release-java-agent/index.html | 2 +- .../next/en/faq/ext-dirs/index.html| 2 +- docs/skywalking-java/next/en/faq/osgi/index.html | 2 +- .../java-agent/advanced-features/index.html| 2 +- .../java-agent/advanced-reporters/index.html | 2 +- .../kotlin-coroutine-plugin/index.html | 2 +- .../oracle-resin-plugins/index.html| 2 +- .../spring-annotation-plugin/index.html| 2 +- .../trace-ignore-plugin/index.html | 2 +- .../application-toolkit-dependency/index.html | 2 +- .../application-toolkit-kafka/index.html | 2 +- .../application-toolkit-log4j-1.x/index.html | 2 +- .../application-toolkit-log4j-2.x/index.html | 2 +- .../application-toolkit-logback-1.x/index.html | 2 +- .../application-toolkit-meter/index.html | 2 +- .../application-toolkit-micrometer-1.10/index.html | 2 +- .../application-toolkit-micrometer/index.html | 2 +- .../index.html | 2 +- .../index.html | 2 +- .../index.html | 2 +- .../index.html | 2 +- .../application-toolkit-trace/index.html | 2 +- .../application-toolkit-tracer/index.html | 2 +- .../application-toolkit-webflux/index.html | 2 +- .../java-agent/bootstrap-plugins/index.html| 2 +- .../java-agent/configuration-discovery/index.html | 2 +- .../java-agent/configurations/index.html | 2 +- .../java-agent/containerization/index.html | 2 +- .../java-agent/customize-enhance-trace/index.html | 2 +- .../java-agent/how-to-disable-plugin/index.html| 2 +- .../how-to-tolerate-exceptions/index.html | 2 +- .../java-plugin-development-guide/index.html | 4 +- .../java-agent/logic-endpoint/index.html | 2 +- .../java-agent/opentracing/index.html | 2 +- .../java-agent/optional-plugins/index.html | 2 +- .../java-agent/plugin-list/index.html | 2 +- .../java-agent/plugin-test/index.html | 26 +- .../service-agent/java-agent/readme/index.html | 2 +- .../java-agent/setting-override/index.html | 2 +- .../java-agent/specified-agent-config/index.html | 2 +- .../java-agent/supported-list/index.html | 2 +- .../setup/service-agent/java-agent/tls/index.html | 4 +- .../service-agent/java-agent/token-auth/index.html | 2 +- docs/skywalking-java/next/readme/index.html| 2 +- index.json | 2 +- team/index.html| 367 - 48 files changed, 669 insertions(+), 646 deletions(-) diff --git a/contributors/index.html b/contributors/index.html index 5b418186c29..833ca39ec5d 100644 --- a/contributors/index.html +++ b/contributors/index.html @@ -11659,16 +11659,16 @@ - + -https://github.com/Hen1ng; target="_blank"> +https://github.com/geekymv; target="_blank"> - Hen1ng + geekymv -2 -147 +2 +147 @@ -12093,128 +12093,114 @@ - - -https://github.com/2han9wen71an; target="_blank"> - - 2han9wen71an - - - -2 -178 - - - - - + -https://github.com/844067874; target="_blank"> +https://github.com/ArjenDavid-sjtu;
Re: [PR] Fix inaccurate MySQL/MariaDB, Redis metrics [skywalking]
wankai123 commented on code in PR #12130:
URL: https://github.com/apache/skywalking/pull/12130#discussion_r1570746743
##
test/e2e-v2/cases/mariadb/expected/metrics-has-value-metric-null.yml:
##
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+type: TIME_SERIES_VALUES
+results:
+ {{- contains .results }}
+ - metric: null
Review Comment:
why `null` here and what's this expected file for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. [skywalking-java]
wu-sheng merged PR #681: URL: https://github.com/apache/skywalking-java/pull/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug]NPE in jdk-threadpool-plugin [skywalking]
wu-sheng closed issue #12128: [Bug]NPE in jdk-threadpool-plugin URL: https://github.com/apache/skywalking/issues/12128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-java) branch main updated: Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. (#681)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
The following commit(s) were added to refs/heads/main by this push:
new ec30b5f53d Fix NPE in handleMethodException method of
apm-jdk-threadpool-plugin. (#681)
ec30b5f53d is described below
commit ec30b5f53db297b26da4e8df89dec3c9d428ef53
Author: ForrestWang123 <157256498+forrestwang...@users.noreply.github.com>
AuthorDate: Thu Apr 18 21:19:50 2024 +0800
Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. (#681)
Co-authored-by: forrestwang
---
CHANGES.md| 1 +
.../skywalking/apm/plugin/AbstractThreadingPoolInterceptor.java | 4
2 files changed, 5 insertions(+)
diff --git a/CHANGES.md b/CHANGES.md
index 275c823e94..dfe870b619 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -6,6 +6,7 @@ Release Notes.
--
* Remove `idleCount` tag in Alibaba Druid meter plugin.
+* Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin.
All issues and pull requests are
[here](https://github.com/apache/skywalking/milestone/213?closed=1)
diff --git
a/apm-sniffer/bootstrap-plugins/jdk-threadpool-plugin/src/main/java/org/apache/skywalking/apm/plugin/AbstractThreadingPoolInterceptor.java
b/apm-sniffer/bootstrap-plugins/jdk-threadpool-plugin/src/main/java/org/apache/skywalking/apm/plugin/AbstractThreadingPoolInterceptor.java
index 7239453074..c72c1424b5 100644
---
a/apm-sniffer/bootstrap-plugins/jdk-threadpool-plugin/src/main/java/org/apache/skywalking/apm/plugin/AbstractThreadingPoolInterceptor.java
+++
b/apm-sniffer/bootstrap-plugins/jdk-threadpool-plugin/src/main/java/org/apache/skywalking/apm/plugin/AbstractThreadingPoolInterceptor.java
@@ -63,6 +63,10 @@ public abstract class AbstractThreadingPoolInterceptor
implements InstanceMethod
@Override
public void handleMethodException(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes, Throwable t) {
+if (!ContextManager.isActive()) {
+return;
+}
+
ContextManager.activeSpan().log(t);
}
}
Re: [I] [Bug] SkyWalking agent failed to start if using kafka protocol with sasl_mechanism=PLAIN. [skywalking]
wu-sheng commented on issue #12131: URL: https://github.com/apache/skywalking/issues/12131#issuecomment-2063847458 Please send a pull request when you are ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] Skipping Index in the New Columned-Based Storage [skywalking]
zesiar0 commented on issue #11475: URL: https://github.com/apache/skywalking/issues/11475#issuecomment-2063821796 please assign to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate MySQL/MariaDB, Redis metrics [skywalking]
wankai123 commented on code in PR #12130: URL: https://github.com/apache/skywalking/pull/12130#discussion_r1570674102 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/redis/redis-service.json: ## @@ -31,7 +31,7 @@ "title": "Uptime (day)" }, "expressions": [ -"latest(meter_redis_uptime)/3600/24" +"latest(aggregate_labels(meter_redis_uptime,max))/3600/24" Review Comment: I don't think sum all the instance's uptime is the service's uptime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate MySQL/MariaDB, Redis metrics [skywalking]
wankai123 commented on code in PR #12130: URL: https://github.com/apache/skywalking/pull/12130#discussion_r1570674102 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/redis/redis-service.json: ## @@ -31,7 +31,7 @@ "title": "Uptime (day)" }, "expressions": [ -"latest(meter_redis_uptime)/3600/24" +"latest(aggregate_labels(meter_redis_uptime,max))/3600/24" Review Comment: I don't think sum all the instance's uptime is the service's uptime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] [skywalking]
tsonglew opened a new issue, #12131:
URL: https://github.com/apache/skywalking/issues/12131
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
Python Agent (apache/skywalking-python)
### What happened
SkyWalking agent failed to start if using kafka protocol with
sasl_mechanism=PLAIN.
### What you expected to happen
SkyWalking agent starts successfully when using kafka protocol with
sasl_mechanism=PLAIN.
### How to reproduce
run a gunicorn app with a command like
```sh
SW_AGENT_PROTOCOL=kafka \
SW_KAFKA_BOOTSTRAP_SERVERS=localhost:9092 \
SW_KAFKA_REPORTER_CONFIG_security_protocol=SASL_PLAINTEXT \
SW_KAFKA_REPORTER_CONFIG_sasl_mechanism=PLAIN \
SW_KAFKA_REPORTER_CONFIG_sasl_plain_username= \
SW_KAFKA_REPORTER_CONFIG_sasl_plain_password= \
SW_AGENT_NAME=demo::gunicorn \
sw-python -d run -p gunicorn main:app
```
### Anything else
The agent failed to start with AttributeError: 'SkyWalkingAgent' object has
no attribute '_SkyWalkingAgent__log_queue'
Using kafka protocol with sasl_mechanism=PLAIN leads to "log.warning('%s:
Sending username and password in the clear', self)".
https://github.com/dpkp/kafka-python/blob/a6d0579d3cadd3826dd364b01bc12a2173139abc/kafka/conn.py#L624
the logging module was replaced by sw_logging, but __log_queue was not
initialized yet
### Are you willing to submit a pull request to fix on your own?
- [X] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
notifications-unsubscr...@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug]NPE in jdk-threadpool-plugin [skywalking]
wu-sheng commented on issue #12128: URL: https://github.com/apache/skywalking/issues/12128#issuecomment-2063664660 Follow up through https://github.com/apache/skywalking-java/pull/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix inaccurate MySQL/MariaDB, Redis metrics [skywalking]
yswdqz opened a new pull request, #12130: URL: https://github.com/apache/skywalking/pull/12130 - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). snapshots:   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. [skywalking-java]
ForrestWang123 opened a new pull request, #681: URL: https://github.com/apache/skywalking-java/pull/681 ### Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin - [ ] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it. - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #12128. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug]NPE in jdk-threadpool-plugin [skywalking]
ForrestWang123 opened a new issue, #12128: URL: https://github.com/apache/skywalking/issues/12128 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component Java Agent (apache/skywalking-java) ### What happened NPE in jdk-threadpool-plugin java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.activeSpan(ContextManager.java:184) at org.apache.skywalking.apm.plugin.AbstractThreadingPoolInterceptor.handleMethodException(AbstractThreadingPoolInterceptor.java:66) at org.apache.skywalking.apm.plugin.ThreadPoolExecuteMethodInterceptor_internal.intercept(InstanceMethodInterWithOverrideArgsTemplate.java:92) at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java) at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:112) ### What you expected to happen Should not have NPE ### How to reproduce 1. beforeMethod of AbstractThreadingPoolInterceptor didn't create any span. 2. exception occur in execution body of the Runnable/Callable ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [X] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] UI: optimize search reset in marketplace menu [skywalking]
wu-sheng closed issue #12127: [Bug] UI: optimize search reset in marketplace menu URL: https://github.com/apache/skywalking/issues/12127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: optimize search reset and format in marketplace [skywalking-booster-ui]
Fine0830 merged PR #392: URL: https://github.com/apache/skywalking-booster-ui/pull/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-booster-ui) branch main updated: fix: optimize search reset and format in marketplace (#392)
This is an automated email from the ASF dual-hosted git repository.
qiuxiafan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git
The following commit(s) were added to refs/heads/main by this push:
new 54c236ba fix: optimize search reset and format in marketplace (#392)
54c236ba is described below
commit 54c236bacf47f7dfb59aadede663b3e41d471ea7
Author: Chen Ziyan
AuthorDate: Thu Apr 18 17:27:56 2024 +0800
fix: optimize search reset and format in marketplace (#392)
---
src/views/Marketplace.vue | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/views/Marketplace.vue b/src/views/Marketplace.vue
index c4dae5a2..daabc86a 100644
--- a/src/views/Marketplace.vue
+++ b/src/views/Marketplace.vue
@@ -78,6 +78,7 @@ limitations under the License. -->
function searchMenus() {
if (!searchText.value) {
menus.value = appStore.allMenus;
+ currentItems.value = menus.value[0] || {};
return;
}
@@ -149,6 +150,7 @@ limitations under the License. -->
border-right: 1px solid var(--sw-marketplace-border);
align-content: flex-start;
height: 100%;
+width: 100%;
overflow: auto;
}
Re: [I] [Bug] UI: optimize search reset in marketplace menu [skywalking]
wu-sheng commented on issue #12127: URL: https://github.com/apache/skywalking/issues/12127#issuecomment-2063409823 fyi @Fine0830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] UI: optimize search reset in marketplace menu [skywalking]
CzyerChen opened a new issue, #12127: URL: https://github.com/apache/skywalking/issues/12127 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component UI (apache/skywalking-booster-ui) ### What happened https://github.com/apache/skywalking/assets/22817918/9a8f340e-1b87-4ee6-b9a3-94b0e8121dcb;> 1、First in, highlight the first card 2、Search something, highlight the first one after filter 3、Clear and search, still highlight the last search --> It may be better to highlight the first card like the first time ### What you expected to happen Hope that 3、Clear and search, highlight the first card like first in rather than the last highlight ### How to reproduce 1、First in, highlight the first card 2、Search something, highlight the first one after filter 3、Clear and search, see the highlighted card ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [X] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
