Re: [PR] Fix typo in swip docs [skywalking]
CzyerChen commented on code in PR #12175: URL: https://github.com/apache/skywalking/pull/12175#discussion_r1584136295 ## docs/en/swip/SWIP-8.md: ## @@ -49,7 +49,7 @@ Using openTelemetry receiver to fetch these metrics to SkyWalking OAP server. ||---|-|--- |-| | Uptime | sec | meter_activemq_broker_uptime| Uptime of the broker in day. | JMX Prometheus Exporter | | State | | meter_activemq_broker_state | If slave broker 1 else 0. | JMX Prometheus Exporter | -| Current Connentions| Count | meter_activemq_broker_current_connentions | The number of clients connected to the broker currently. | JMX Prometheus Exporter | +| Current Connections| Count | meter_activemq_broker_current_connections | The number of clients connected to the broker currently. | JMX Prometheus Exporter | Review Comment: @wankai123 thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] typo fix [skywalking-java]
JoeCqupt opened a new pull request, #685: URL: https://github.com/apache/skywalking-java/pull/685 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve filtering performance of Stream [skywalking-banyandb]
wu-sheng commented on PR #440: URL: https://github.com/apache/skywalking-banyandb/pull/440#issuecomment-2084334021 I will leave this @hanahmily whether we include this into 0.6 or we should cut 0.6 first and do more tests for this commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] Whether multiple Tracing link information can be synthesized [skywalking]
wu-sheng closed issue #12178: [Feature] Whether multiple Tracing link information can be synthesized URL: https://github.com/apache/skywalking/issues/12178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Feature] Whether multiple Tracing link information can be synthesized [skywalking]
wl2027 opened a new issue, #12178: URL: https://github.com/apache/skywalking/issues/12178 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description The largest unit of OpenTracing is a single link, but operations such as some workflows or state machines are often multiple link combinations. If you want to combine and observe this flow state, in addition to marking the key of the service on the link, is there any other way to combine multiple tracing into a simple and intuitive data flow? Similar to the processing log in the workflow, it is only the log of the processing link The idea is that plug-ins do not monitor activiti workflows, that link observations on business processes are not suitable for skywalking, or that this should be made into BPM alone and not added to APM 是否可以实现多个Tracing链路信息合成 OpenTracing中最大单位是单个链路,但是像一些工作流或状态机这类的操作往往都是多个链路组合,如果想组合起来观测这种流转状态,除了在链路上标记业务的key,还有别能实现将多个tracing组合成简单直观数据流的方式吗?类似工作流中的办理日志这类,不过是办理链路的日志这样 有这种想法是看到并没有去监控activiti工作流的插件,对业务流程上的链路观测不知道适不适用于用skywalking,还是说这种应该单独做成BPM而不是加在APM上 ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch master updated: fix typo (#12176)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 59cabc10a2 fix typo (#12176) 59cabc10a2 is described below commit 59cabc10a214ae635e6e38dfd36f6c5df2323152 Author: Wan Kai AuthorDate: Tue Apr 30 11:16:58 2024 +0800 fix typo (#12176) --- docs/en/setup/backend/backend-activemq-monitoring.md | 4 ++-- .../src/main/resources/otel-rules/activemq/activemq-broker.yaml | 2 +- .../resources/ui-initialized-templates/activemq/activemq-broker.json | 4 ++-- test/e2e-v2/cases/activemq/activemq-cases.yaml| 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/en/setup/backend/backend-activemq-monitoring.md b/docs/en/setup/backend/backend-activemq-monitoring.md index 0f9f38af76..912e7dccb7 100644 --- a/docs/en/setup/backend/backend-activemq-monitoring.md +++ b/docs/en/setup/backend/backend-activemq-monitoring.md @@ -59,7 +59,7 @@ the OAP. In each cluster, the broker is represented as `Instance` and the destin ||---|-|--- |-| | Uptime | sec | meter_activemq_broker_uptime| Uptime of the broker in day. | JMX Prometheus Exporter | | State | | meter_activemq_broker_state | If slave broker 1 else 0. | JMX Prometheus Exporter | -| Current Connentions| Count | meter_activemq_broker_current_connentions | The number of clients connected to the broker currently. | JMX Prometheus Exporter | +| Current Connections| Count | meter_activemq_broker_current_connections | The number of clients connected to the broker currently. | JMX Prometheus Exporter | | Current Producer Count | Count | meter_activemq_broker_current_producer_count| The number of producers currently attached to the broker. | JMX Prometheus Exporter | | Current Consumer Count | Count | meter_activemq_broker_current_consumer_count| The number of consumers consuming messages from the broker. | JMX Prometheus Exporter | | Producer Count | Count | meter_activemq_broker_producer_count| Number of message producers active on destinations. | JMX Prometheus Exporter | @@ -104,4 +104,4 @@ the OAP. In each cluster, the broker is represented as `Instance` and the destin You can customize your own metrics/expression/dashboard panel. The metrics definition and expression rules are found in `otel-rules/activemq/activemq-cluster.yaml, otel-rules/activemq/activemq-broker.yaml, otel-rules/activemq/activemq-destination.yaml`. -The ActiveMQ dashboard panel configurations are found in `ui-initialized-templates/activemq`. \ No newline at end of file +The ActiveMQ dashboard panel configurations are found in `ui-initialized-templates/activemq`. diff --git a/oap-server/server-starter/src/main/resources/otel-rules/activemq/activemq-broker.yaml b/oap-server/server-starter/src/main/resources/otel-rules/activemq/activemq-broker.yaml index c3a2cd20e8..8a1ea65095 100644 --- a/oap-server/server-starter/src/main/resources/otel-rules/activemq/activemq-broker.yaml +++ b/oap-server/server-starter/src/main/resources/otel-rules/activemq/activemq-broker.yaml @@ -39,7 +39,7 @@ metricsRules: - name: state exp: org_apache_activemq_Broker_Slave.sum(['cluster','brokerName','service_instance_id']) # The number of clients connected to the broker currently. - - name: current_connentions + - name: current_connections exp: org_apache_activemq_Broker_CurrentConnectionsCount.sum(['cluster','brokerName','service_instance_id']) # The number of producers currently attached to the broker. - name: current_producer_count diff --git a/oap-server/server-starter/src/main/resources/ui-initialized-templates/activemq/activemq-broker.json b/oap-server/server-starter/src/main/resources/ui-initialized-templates/activemq/activemq-broker.json index c5094f6368..a7545dd05d
Re: [PR] Fix activeMQ monitoring typo [skywalking]
wu-sheng merged PR #12176: URL: https://github.com/apache/skywalking/pull/12176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] 是否可以实现多个Tracing链路信息合成 [skywalking]
wu-sheng closed issue #12177: [Feature] 是否可以实现多个Tracing链路信息合成 URL: https://github.com/apache/skywalking/issues/12177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] 是否可以实现多个Tracing链路信息合成 [skywalking]
wu-sheng commented on issue #12177: URL: https://github.com/apache/skywalking/issues/12177#issuecomment-2084297263 If you need Chinese discussion, go to slack CN channel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Feature] 是否可以实现多个Tracing链路信息合成 [skywalking]
wl2027 opened a new issue, #12177: URL: https://github.com/apache/skywalking/issues/12177 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description OpenTracing中最大单位是单个链路,但是像一些工作流或状态机这类的操作往往都是多个链路组合,如果想组合起来观测这种流转状态,除了在链路上标记业务的key,还有别的实现将多个tracing组合成简单直观数据流的方式吗?类似工作流中的办理日志这类,不过是办理链路的日志这样 ### Use case _No response_ ### Related issues _No response_ ### Are you willing to submit a pull request to implement this on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix activeMQ monitoring typo [skywalking]
wankai123 opened a new pull request, #12176: URL: https://github.com/apache/skywalking/pull/12176 @CzyerChen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch master updated: Fix typo in swip docs (#12175)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 304b548e71 Fix typo in swip docs (#12175) 304b548e71 is described below commit 304b548e71cd9404e8cbdf06dcd80aa6ad9e20f5 Author: liuzc9 <90489940+liu...@users.noreply.github.com> AuthorDate: Tue Apr 30 09:18:02 2024 +0800 Fix typo in swip docs (#12175) --- docs/en/swip/SWIP-8.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/en/swip/SWIP-8.md b/docs/en/swip/SWIP-8.md index 6c598e0f7e..27d7cfd146 100644 --- a/docs/en/swip/SWIP-8.md +++ b/docs/en/swip/SWIP-8.md @@ -49,7 +49,7 @@ Using openTelemetry receiver to fetch these metrics to SkyWalking OAP server. ||---|-|--- |-| | Uptime | sec | meter_activemq_broker_uptime| Uptime of the broker in day. | JMX Prometheus Exporter | | State | | meter_activemq_broker_state | If slave broker 1 else 0. | JMX Prometheus Exporter | -| Current Connentions| Count | meter_activemq_broker_current_connentions | The number of clients connected to the broker currently. | JMX Prometheus Exporter | +| Current Connections| Count | meter_activemq_broker_current_connections | The number of clients connected to the broker currently. | JMX Prometheus Exporter | | Current Producer Count | Count | meter_activemq_broker_current_producer_count| The number of producers currently attached to the broker. | JMX Prometheus Exporter | | Current Consumer Count | Count | meter_activemq_broker_current_consumer_count| The number of consumers consuming messages from the broker. | JMX Prometheus Exporter | | Producer Count | Count | meter_activemq_broker_producer_count| Number of message producers active on destinations. | JMX Prometheus Exporter |
Re: [PR] Fix typo in swip docs [skywalking]
wu-sheng merged PR #12175: URL: https://github.com/apache/skywalking/pull/12175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix typo in swip docs [skywalking]
wu-sheng commented on PR #12175: URL: https://github.com/apache/skywalking/pull/12175#issuecomment-2084057264 Next time, please use the new branch newly created from latest upstream. This commit has a lot of expired logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix typo in swip docs [skywalking]
wu-sheng commented on code in PR #12175: URL: https://github.com/apache/skywalking/pull/12175#discussion_r1584008997 ## docs/en/swip/SWIP-8.md: ## @@ -49,7 +49,7 @@ Using openTelemetry receiver to fetch these metrics to SkyWalking OAP server. ||---|-|--- |-| | Uptime | sec | meter_activemq_broker_uptime| Uptime of the broker in day. | JMX Prometheus Exporter | | State | | meter_activemq_broker_state | If slave broker 1 else 0. | JMX Prometheus Exporter | -| Current Connentions| Count | meter_activemq_broker_current_connentions | The number of clients connected to the broker currently. | JMX Prometheus Exporter | +| Current Connections| Count | meter_activemq_broker_current_connections | The number of clients connected to the broker currently. | JMX Prometheus Exporter | Review Comment: @CzyerChen Please check whether dashboard configuration has same issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate Pulsar and Bookkeeper metrics [skywalking]
wankai123 commented on PR #12174: URL: https://github.com/apache/skywalking/pull/12174#issuecomment-2084045402 Here is an illegal expression, please fix it as well, thanks. https://github.com/apache/skywalking/blob/a38628fced0a6f678df188799b60c29c0507bc02/oap-server/server-starter/src/main/resources/ui-initialized-templates/pulsar/pulsar-broker.json#L85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix typo in swip docs [skywalking]
liuzc9 opened a new pull request, #12175: URL: https://github.com/apache/skywalking/pull/12175 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate Pulsar and Bookkeeper metrics [skywalking]
wankai123 commented on PR #12174: URL: https://github.com/apache/skywalking/pull/12174#issuecomment-2084003343 Please attach the screen-shoots when you update the UI templates -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate Pulsar and Bookkeeper metrics [skywalking]
wankai123 commented on code in PR #12174: URL: https://github.com/apache/skywalking/pull/12174#discussion_r1583998023 ## oap-server/server-starter/src/main/resources/ui-initialized-templates/bookkeeper/bookkeeper-cluster.json: ## @@ -34,7 +34,7 @@ "name": "bookie_ledgers_count" }, "expressions": [ -"meter_bookkeeper_bookie_ledgers_count" + "latest(aggregate_labels(meter_bookkeeper_bookie_ledgers_count,sum))" Review Comment: if the weight type is `Line`, we should not use `latest`. Its result is not a `TIME_SERIES_VALUES` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix standalone tls config conditions [skywalking-banyandb-helm]
wu-sheng merged PR #11: URL: https://github.com/apache/skywalking-banyandb-helm/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-helm) branch kezhenxu94-patch-1 deleted (was 47e9931)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch kezhenxu94-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git was 47e9931 Update statefulset.yaml The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(skywalking-banyandb-helm) branch master updated: Fix standalone tls config conditions (#11)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
The following commit(s) were added to refs/heads/master by this push:
new 585aa54 Fix standalone tls config conditions (#11)
585aa54 is described below
commit 585aa54ffec5a76372afe845720a0e946c7c99b8
Author: kezhenxu94
AuthorDate: Tue Apr 30 00:44:20 2024 +0800
Fix standalone tls config conditions (#11)
---
chart/templates/statefulset.yaml | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/chart/templates/statefulset.yaml b/chart/templates/statefulset.yaml
index f943430..173dd55 100644
--- a/chart/templates/statefulset.yaml
+++ b/chart/templates/statefulset.yaml
@@ -60,7 +60,7 @@ spec:
- name: {{ $env.name }}
value: {{ $env.value }}
{{- end }}
-{{- if .Values.cluster.data.tls}}
+{{- if .Values.standalone.tls}}
{{- if .Values.standalone.tls.grpcSecretName }}
- name: BYDB_TLS
value: "true"
@@ -96,7 +96,7 @@ spec:
command:
- sh
- -c
-- "/bydbctl health {{- if .Values.cluster.liaison.tls }}
--enable-tls --insecure{{- end}}"
+- "/bydbctl health {{- if .Values.standalone.tls }}
--enable-tls --insecure{{- end}}"
initialDelaySeconds: 20
periodSeconds: 60
livenessProbe:
@@ -104,7 +104,7 @@ spec:
command:
- sh
- -c
-- "/bydbctl health {{- if .Values.cluster.liaison.tls }}
--enable-tls --insecure{{- end}}"
+- "/bydbctl health {{- if .Values.standalone.tls }}
--enable-tls --insecure{{- end}}"
initialDelaySeconds: 20
periodSeconds: 60
@@ -543,4 +543,4 @@ spec:
{{- end }}
{{- end }}
{{- end }}
-{{- end }}
\ No newline at end of file
+{{- end }}
[PR] Fix inaccurate Pulsar and Bookkeeper metrics [skywalking]
CodePrometheus opened a new pull request, #12174: URL: https://github.com/apache/skywalking/pull/12174 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-helm) branch kezhenxu94-patch-1 updated (9d909f2 -> 47e9931)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch kezhenxu94-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git from 9d909f2 Fix standalone tls config conditions add 47e9931 Update statefulset.yaml No new revisions were added by this update. Summary of changes: chart/templates/statefulset.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[PR] Fix standalone tls config conditions [skywalking-banyandb-helm]
kezhenxu94 opened a new pull request, #11: URL: https://github.com/apache/skywalking-banyandb-helm/pull/11 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-helm) 01/01: Fix standalone tls config conditions
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch kezhenxu94-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
commit 9d909f22db4bc978b5bc120f5a8eaed61f0f55ae
Author: kezhenxu94
AuthorDate: Mon Apr 29 21:51:47 2024 +0800
Fix standalone tls config conditions
---
chart/templates/statefulset.yaml | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/chart/templates/statefulset.yaml b/chart/templates/statefulset.yaml
index f943430..a633f91 100644
--- a/chart/templates/statefulset.yaml
+++ b/chart/templates/statefulset.yaml
@@ -60,7 +60,7 @@ spec:
- name: {{ $env.name }}
value: {{ $env.value }}
{{- end }}
-{{- if .Values.cluster.data.tls}}
+{{- if .Values.standalone.data.tls}}
{{- if .Values.standalone.tls.grpcSecretName }}
- name: BYDB_TLS
value: "true"
@@ -96,7 +96,7 @@ spec:
command:
- sh
- -c
-- "/bydbctl health {{- if .Values.cluster.liaison.tls }}
--enable-tls --insecure{{- end}}"
+- "/bydbctl health {{- if .Values.standalone.tls }}
--enable-tls --insecure{{- end}}"
initialDelaySeconds: 20
periodSeconds: 60
livenessProbe:
@@ -104,7 +104,7 @@ spec:
command:
- sh
- -c
-- "/bydbctl health {{- if .Values.cluster.liaison.tls }}
--enable-tls --insecure{{- end}}"
+- "/bydbctl health {{- if .Values.standalone.tls }}
--enable-tls --insecure{{- end}}"
initialDelaySeconds: 20
periodSeconds: 60
@@ -543,4 +543,4 @@ spec:
{{- end }}
{{- end }}
{{- end }}
-{{- end }}
\ No newline at end of file
+{{- end }}
(skywalking-banyandb-helm) branch kezhenxu94-patch-1 created (now 9d909f2)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch kezhenxu94-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git at 9d909f2 Fix standalone tls config conditions This branch includes the following new commits: new 9d909f2 Fix standalone tls config conditions The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
Re: [PR] Fix inaccurate Hierarchy of RabbitMQ metrics. [skywalking]
wu-sheng commented on PR #12144: URL: https://github.com/apache/skywalking/pull/12144#issuecomment-2082756645 I think this dashboard is not aggregated, all instance metrics are listed separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inaccurate Hierarchy of RabbitMQ metrics. [skywalking]
CodePrometheus commented on PR #12144: URL: https://github.com/apache/skywalking/pull/12144#issuecomment-2082752080 Excuse me, I have a small doubt, is it because for a RabbitMQ cluster, it's already aggregated in the overview? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] [BanyanDB] Property Applying doesn't Verify the Group as "CATALOG_UNSPECIFIED" [skywalking]
hanahmily commented on issue #11993: URL: https://github.com/apache/skywalking/issues/11993#issuecomment-2082607518 fix by https://github.com/apache/skywalking-banyandb/pull/441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] [BanyanDB] Property Applying doesn't Verify the Group as "CATALOG_UNSPECIFIED" [skywalking]
hanahmily closed issue #11993: [Bug] [BanyanDB] Property Applying doesn't Verify the Group as "CATALOG_UNSPECIFIED" URL: https://github.com/apache/skywalking/issues/11993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch metadata deleted (was c7a2252c)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch metadata in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was c7a2252c Update Node version The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump Go Node and Dependencies [skywalking-banyandb]
hanahmily merged PR #441: URL: https://github.com/apache/skywalking-banyandb/pull/441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump Go Node and Dependencies [skywalking-banyandb]
hanahmily commented on PR #441: URL: https://github.com/apache/skywalking-banyandb/pull/441#issuecomment-2082588933 > Please fix CI, build fails. It's due to binary cache of CI. I cleared up them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump Go Node and Dependencies [skywalking-banyandb]
wu-sheng commented on PR #441: URL: https://github.com/apache/skywalking-banyandb/pull/441#issuecomment-2082571599 Please fix CI, build fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-skywalking-helm-oap not started(keep restarting) [skywalking]
wu-sheng closed issue #12172: [Bug] skywalking-skywalking-helm-oap not started(keep restarting) URL: https://github.com/apache/skywalking/issues/12172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch metadata updated (6c3d6068 -> c7a2252c)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch metadata in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 6c3d6068 Fix NPE when no index filter add c7a2252c Update Node version No new revisions were added by this update. Summary of changes: .github/workflows/ci.yml | 4 ++-- .github/workflows/e2e.storage.yml| 2 +- .github/workflows/publish-docker.yml | 2 +- .github/workflows/test.yml | 2 +- CONTRIBUTING.md | 2 +- docs/installation/binaries.md| 2 +- 6 files changed, 7 insertions(+), 7 deletions(-)
[PR] Bump Go Node and Dependencies [skywalking-banyandb]
hanahmily opened a new pull request, #441: URL: https://github.com/apache/skywalking-banyandb/pull/441 Bump Go and Node runtime, and dependencies to fix CVEs. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch metadata updated (361e4d3e -> 6c3d6068)
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch metadata
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
from 361e4d3e Validate resource
new b7879299 Update linter
new ed65b577 Bump go to 1.22
new 5414099e bump node and ui dependencies
new 6c3d6068 Fix NPE when no index filter
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.golangci-format.yml | 16 +-
.golangci.yml | 47 +-
CHANGES.md |5 +-
CONTRIBUTING.md|2 +-
api/common/id.go | 19 +-
api/data/data.go |2 +
banyand/internal/bucket/strategy.go|7 +-
banyand/internal/storage/index.go |2 +-
banyand/internal/storage/tsdb.go |2 +-
banyand/measure/block_reader_test.go |2 +-
banyand/measure/block_test.go |4 +-
banyand/measure/datapoints.go |7 +-
banyand/measure/topn.go|2 +-
banyand/metadata/schema/checker.go |2 +-
banyand/metadata/schema/etcd.go|1 +
banyand/metadata/schema/etcd_test.go | 10 +-
banyand/observability/service.go |2 +-
banyand/stream/block_reader_test.go|2 +-
banyand/stream/block_test.go |4 +-
banyand/stream/elements.go |7 +-
banyand/stream/index.go|6 +-
banyand/stream/iter_builder.go |2 +-
bydbctl/internal/cmd/group.go |6 +-
bydbctl/internal/cmd/health_check.go |2 +-
bydbctl/internal/cmd/rest.go | 11 +-
bydbctl/internal/cmd/use.go|2 +-
bydbctl/pkg/file/read.go |2 +-
dist/LICENSE | 209 +--
...> license-github.com-go-task-slim-sprig-v3.txt} |0
...om-matttproud-golang-protobuf-extensions-v2.txt | 201 ---
dist/licenses/license-github.com-urfave-cli-v2.txt |2 +-
...3.txt => license-github.com-xrash-smetrics.txt} |2 +-
...ctivity-transform-node-modules-magic-string.txt |7 -
.../license--vue-reactivity-transform.txt | 21 -
.../ui-licenses/license-binary-extensions.txt |3 +-
dist/licenses/ui-licenses/license-entities.txt | 11 +
...cense-glob-parent.txt => license-lru-cache.txt} |2 +-
...s-magic-string.txt => license-magic-string.txt} |0
dist/licenses/ui-licenses/license-sass.txt | 91 +
...{license-glob-parent.txt => license-semver.txt} |2 +-
...license-glob-parent.txt => license-yallist.txt} |2 +-
docker/Dockerfile |4 +-
docs/installation/binaries.md |2 +-
go.mod | 134 +-
go.sum | 298 ++--
pkg/bus/bus_test.go| 18 +-
pkg/cmdsetup/data.go |2 +-
pkg/cmdsetup/liaison.go|2 +-
pkg/cmdsetup/root.go |2 +-
pkg/cmdsetup/standalone.go |2 +-
pkg/config/config_test.go |2 +-
pkg/flow/streaming/streaming_test.go |8 +-
pkg/index/inverted/inverted_series_test.go |6 +-
pkg/index/inverted/inverted_test.go|2 +-
pkg/index/testcases/service_name.go|2 +-
pkg/node/interface.go | 14 +-
pkg/pb/v1/value.go |7 +-
pkg/query/logical/index_filter.go |9 +-
.../logical/stream/stream_plan_indexscan_local.go |2 +-
pkg/run/run.go |3 +-
scripts/build/vendor.mk|2 +-
scripts/build/version.mk |8 +-
scripts/ci/check/version_test.go |2 +-
...ilter_tag_empty.yaml => filter_no_indexed.yaml} | 21 +-
.../data/want/filter_no_indexed.yaml} | 33 +-
test/cases/stream/stream.go|3 +-
test/stress/istio/istio_suite_test.go |2 +-
test/stress/istio/repo.go | 22 +-
ui/LICENSE | 77 +-
ui/package-lock.json | 1800
(skywalking-banyandb) 02/04: Bump go to 1.22
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch metadata in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit ed65b577a41ce44f3304e14dd2446281e90f8779 Author: Gao Hongtao AuthorDate: Sun Apr 28 13:58:29 2024 + Bump go to 1.22 Signed-off-by: Gao Hongtao --- .golangci.yml| 2 +- CHANGES.md | 2 +- CONTRIBUTING.md | 2 +- docker/Dockerfile| 4 ++-- docs/installation/binaries.md| 2 +- go.mod | 2 +- scripts/build/vendor.mk | 2 +- scripts/ci/check/version_test.go | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index e4215921..ddd2d8bd 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -129,7 +129,7 @@ linters-settings: - 'cobra\.Command$' run: - go: "1.21" + go: "1.22" issues: exclude-rules: - path: ".*\\.pb\\.go" diff --git a/CHANGES.md b/CHANGES.md index 5dc02e8e..7a574d13 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -35,7 +35,7 @@ Release Notes. ### Chores -- Bump go to 1.21. +- Bump go to 1.22. - Bump node to 20.9. - Bump several tools. - Bump all dependencies of Go and Node. diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 662e57a1..d2acf3ef 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -41,7 +41,7 @@ Once we've discussed your changes and you've got your code ready, make sure that Users who want to build a binary from sources have to set up: -* Go 1.21 +* Go 1.22 * Node 20.9 * Git >= 2.30 * Linux, macOS or Windows+WSL2 diff --git a/docker/Dockerfile b/docker/Dockerfile index c3d44bbf..3b53a485 100644 --- a/docker/Dockerfile +++ b/docker/Dockerfile @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -FROM golang:1.21 AS dev +FROM golang:1.22 AS dev WORKDIR /app ENV GOOS="linux" ENV CGO_ENABLED=0 @@ -27,7 +27,7 @@ EXPOSE 2345 ENTRYPOINT ["air"] -FROM golang:1.21 AS base +FROM golang:1.22 AS base ENV GOPATH "/go" ENV GO111MODULE "on" diff --git a/docs/installation/binaries.md b/docs/installation/binaries.md index 09762c81..487594b4 100644 --- a/docs/installation/binaries.md +++ b/docs/installation/binaries.md @@ -12,7 +12,7 @@ Get binaries from the [download](https://skywalking.apache.org/downloads/). Users who want to build a binary from sources have to set up: -* Go 1.21 +* Go 1.22 * Node 20.9 * Git >= 2.30 * Linux, macOS or Windows+WSL2 diff --git a/go.mod b/go.mod index 7c01d3b7..b99f7a25 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/apache/skywalking-banyandb -go 1.21 +go 1.22 require ( github.com/RoaringBitmap/roaring v1.9.3 diff --git a/scripts/build/vendor.mk b/scripts/build/vendor.mk index 5b72c4d6..345f69ef 100644 --- a/scripts/build/vendor.mk +++ b/scripts/build/vendor.mk @@ -22,4 +22,4 @@ .PHONY: vendor-update vendor-update: ## Update vendors go get -u -d ./... - go mod tidy -compat=1.21 + go mod tidy -compat=1.22 diff --git a/scripts/ci/check/version_test.go b/scripts/ci/check/version_test.go index 680e6798..58ff9a37 100644 --- a/scripts/ci/check/version_test.go +++ b/scripts/ci/check/version_test.go @@ -31,7 +31,7 @@ import ( ) const ( - GoVersion = "1.21" + GoVersion = "1.22" CPUType = 8 )
(skywalking-banyandb) 03/04: bump node and ui dependencies
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch metadata
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 5414099e7c0f1b7c5e72f13341fb2570084c5db3
Author: Gao Hongtao
AuthorDate: Sun Apr 28 22:16:48 2024 +
bump node and ui dependencies
Signed-off-by: Gao Hongtao
---
dist/LICENSE |7 +-
dist/licenses/ui-licenses/license-lru-cache.txt| 15 +
...s-magic-string.txt => license-magic-string.txt} |0
dist/licenses/ui-licenses/license-semver.txt | 15 +
dist/licenses/ui-licenses/license-yallist.txt | 15 +
ui/LICENSE |7 +-
ui/package-lock.json | 1461
ui/package.json| 33 +-
ui/src/components/Aside/index.vue | 55 +-
ui/src/components/Editor/index.vue | 26 +-
ui/src/components/TopNAggregation/Editor.vue |4 +
ui/tools/checkversion.js |8 +-
ui/{vite.config.js => vite.config.mjs} | 28 +-
13 files changed, 998 insertions(+), 676 deletions(-)
diff --git a/dist/LICENSE b/dist/LICENSE
index 4484d332..71b7afc8 100644
--- a/dist/LICENSE
+++ b/dist/LICENSE
@@ -417,8 +417,11 @@ ISC licenses
anymatch 3.1.3 ISC
glob-parent 5.1.2 ISC
graceful-fs 4.2.11 ISC
+lru-cache 6.0.0 ISC
picocolors 1.0.0 ISC
-yaml 2.4.1 ISC
+semver 7.6.0 ISC
+yallist 4.0.0 ISC
+yaml 2.4.2 ISC
MIT licenses
@@ -438,7 +441,6 @@ MIT licenses
@vue/compiler-core 3.4.25 MIT
@vue/compiler-dom 3.4.25 MIT
@vue/compiler-sfc 3.4.25 MIT
-@vue/compiler-sfc/node_modules/magic-string 0.30.10 MIT
@vue/compiler-ssr 3.4.25 MIT
@vue/devtools-api 6.6.1 MIT
@vue/reactivity 3.4.25 MIT
@@ -478,6 +480,7 @@ MIT licenses
lodash 4.17.21 MIT
lodash-es 4.17.21 MIT
lodash-unified 1.0.3 MIT
+magic-string 0.30.10 MIT
memoize-one 6.0.0 MIT
mime-db 1.52.0 MIT
mime-types 2.1.35 MIT
diff --git a/dist/licenses/ui-licenses/license-lru-cache.txt
b/dist/licenses/ui-licenses/license-lru-cache.txt
new file mode 100644
index ..19129e31
--- /dev/null
+++ b/dist/licenses/ui-licenses/license-lru-cache.txt
@@ -0,0 +1,15 @@
+The ISC License
+
+Copyright (c) Isaac Z. Schlueter and Contributors
+
+Permission to use, copy, modify, and/or distribute this software for any
+purpose with or without fee is hereby granted, provided that the above
+copyright notice and this permission notice appear in all copies.
+
+THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
+IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
diff --git
a/dist/licenses/ui-licenses/license--vue-compiler-sfc-node-modules-magic-string.txt
b/dist/licenses/ui-licenses/license-magic-string.txt
similarity index 100%
rename from
dist/licenses/ui-licenses/license--vue-compiler-sfc-node-modules-magic-string.txt
rename to dist/licenses/ui-licenses/license-magic-string.txt
diff --git a/dist/licenses/ui-licenses/license-semver.txt
b/dist/licenses/ui-licenses/license-semver.txt
new file mode 100644
index ..19129e31
--- /dev/null
+++ b/dist/licenses/ui-licenses/license-semver.txt
@@ -0,0 +1,15 @@
+The ISC License
+
+Copyright (c) Isaac Z. Schlueter and Contributors
+
+Permission to use, copy, modify, and/or distribute this software for any
+purpose with or without fee is hereby granted, provided that the above
+copyright notice and this permission notice appear in all copies.
+
+THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
+IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
diff --git a/dist/licenses/ui-licenses/license-yallist.txt
b/dist/licenses/ui-licenses/license-yallist.txt
new file mode 100644
index ..19129e31
--- /dev/null
+++ b/dist/licenses/ui-licenses/license-yallist.txt
@@ -0,0 +1,15 @@
+The ISC License
+
+Copyright (c) Isaac Z. Schlueter and Contributors
+
+Permission to use, copy, modify, and/or distribute this software for any
+purpose with or without fee is
(skywalking-banyandb) 04/04: Fix NPE when no index filter
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch metadata
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 6c3d6068ba920891be06e4712c77258d394b86b0
Author: Gao Hongtao
AuthorDate: Mon Apr 29 11:49:59 2024 +
Fix NPE when no index filter
Signed-off-by: Gao Hongtao
---
CHANGES.md | 3 +-
banyand/stream/index.go| 4 ++
pkg/query/logical/index_filter.go | 9 ++--
.../logical/stream/stream_plan_indexscan_local.go | 2 +-
.../cases/stream/data/input/filter_no_indexed.yaml | 43 +++
test/cases/stream/data/want/filter_no_indexed.yaml | 50 ++
test/cases/stream/stream.go| 1 +
7 files changed, 107 insertions(+), 5 deletions(-)
diff --git a/CHANGES.md b/CHANGES.md
index 7a574d13..4e0bbba6 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -32,11 +32,12 @@ Release Notes.
- Fix the bug that property merge new tags failed.
- Fix CPU Spike and Extended Duration in BanyanDB's etcd Watching Registration
Process.
- Fix panic when closing banyand.
+- Fix NPE when no index filter in the query.
### Chores
- Bump go to 1.22.
-- Bump node to 20.9.
+- Bump node to 2.12.2.
- Bump several tools.
- Bump all dependencies of Go and Node.
- Combine banyand and bydbctl Dockerfile.
diff --git a/banyand/stream/index.go b/banyand/stream/index.go
index ece2517b..457393d0 100644
--- a/banyand/stream/index.go
+++ b/banyand/stream/index.go
@@ -28,6 +28,7 @@ import (
modelv1
"github.com/apache/skywalking-banyandb/api/proto/banyandb/model/v1"
"github.com/apache/skywalking-banyandb/pkg/index"
"github.com/apache/skywalking-banyandb/pkg/index/inverted"
+ "github.com/apache/skywalking-banyandb/pkg/index/posting/roaring"
"github.com/apache/skywalking-banyandb/pkg/logger"
pbv1 "github.com/apache/skywalking-banyandb/pkg/pb/v1"
)
@@ -75,6 +76,9 @@ func (e *elementIndex) Search(_ context.Context, seriesList
pbv1.SeriesList, fil
if err != nil {
return nil, err
}
+ if pl == nil {
+ pl = roaring.DummyPostingList
+ }
timestamps := pl.ToSlice()
sort.Slice(timestamps, func(i, j int) bool {
return timestamps[i] < timestamps[j]
diff --git a/pkg/query/logical/index_filter.go
b/pkg/query/logical/index_filter.go
index e4e88455..f9d0608c 100644
--- a/pkg/query/logical/index_filter.go
+++ b/pkg/query/logical/index_filter.go
@@ -66,7 +66,7 @@ func BuildLocalFilter(criteria *modelv1.Criteria, schema
Schema, entityDict map[
} else if mandatoryIndexRule {
return nil, nil,
errors.Wrapf(errUnsupportedConditionOp, "mandatory index rule conf:%s", cond)
}
- return Enode, [][]*modelv1.TagValue{entity}, nil
+ return ENode, [][]*modelv1.TagValue{entity}, nil
case *modelv1.Criteria_Le:
le := criteria.GetLe()
if le.GetLeft() == nil && le.GetRight() == nil {
@@ -93,6 +93,9 @@ func BuildLocalFilter(criteria *modelv1.Criteria, schema
Schema, entityDict map[
if left == nil && right == nil {
return nil, entities, nil
}
+ if left == ENode && right == ENode {
+ return ENode, entities, nil
+ }
switch le.Op {
case modelv1.LogicalExpression_LOGICAL_OP_AND:
and := newAnd(2)
@@ -632,8 +635,8 @@ func jsonToString(marshaler json.Marshaler) string {
}
var (
- // Enode is an empty node.
- Enode = new(emptyNode)
+ // ENode is an empty node.
+ ENode = new(emptyNode)
bList = new(bypassList)
)
diff --git a/pkg/query/logical/stream/stream_plan_indexscan_local.go
b/pkg/query/logical/stream/stream_plan_indexscan_local.go
index 194b3f97..95478615 100644
--- a/pkg/query/logical/stream/stream_plan_indexscan_local.go
+++ b/pkg/query/logical/stream/stream_plan_indexscan_local.go
@@ -92,7 +92,7 @@ func (i *localIndexScan) Execute(ctx context.Context)
(elements []*streamv1.Elem
return buildElementsFromColumnResult(r), nil
}
- if i.filter != nil && i.filter != logical.Enode {
+ if i.filter != nil && i.filter != logical.ENode {
sfr, err := ec.Filter(ctx, pbv1.StreamFilterOptions{
Name: i.metadata.GetName(),
TimeRange: ,
diff --git a/test/cases/stream/data/input/filter_no_indexed.yaml
b/test/cases/stream/data/input/filter_no_indexed.yaml
new file mode 100644
index ..b89010d4
--- /dev/null
+++ b/test/cases/stream/data/input/filter_no_indexed.yaml
@@ -0,0 +1,43 @@
+# Licensed to Apache Software
[I] [Bug] skywalking-skywalking-helm-oap not started(keep restarting) [skywalking]
wangchao732 opened a new issue, #12172:
URL: https://github.com/apache/skywalking/issues/12172
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
OAP server (apache/skywalking)
### What happened
helm install "${SKYWALKING_RELEASE_NAME}"
oci://registry-1.docker.io/apache/skywalking-helm --version
"${SKYWALKING_RELEASE_VERSION}" -n "${SKYWALKING_RELEASE_NAMESPACE}" --set
oap.image.tag=9.6.0 --set oap.storageType=elasticsearch --set
ui.image.tag=9.6.0
### What you expected to happen
The logs show that this will restart
### How to reproduce
null
### Anything else
_No response_
### Are you willing to submit a pull request to fix on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
notifications-unsubscr...@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(skywalking-website) branch asf-site updated: deploy: efce3b64b3ee5e20fd1bc98e585406690c98d330
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 8c8239531ae deploy: efce3b64b3ee5e20fd1bc98e585406690c98d330
8c8239531ae is described below
commit 8c8239531aea55ac47fc3b5ea950aee46c202ca7
Author: wu-sheng
AuthorDate: Mon Apr 29 07:41:30 2024 +
deploy: efce3b64b3ee5e20fd1bc98e585406690c98d330
---
contributors/index.html | 20 +---
docs/skywalking-showcase/next/readme/index.html | 6 +++---
index.html | 2 +-
index.json | 2 +-
team/index.html | 14 --
5 files changed, 34 insertions(+), 10 deletions(-)
diff --git a/contributors/index.html b/contributors/index.html
index 91f8f7a9b3b..37a114ba9b2 100644
--- a/contributors/index.html
+++ b/contributors/index.html
@@ -498,6 +498,20 @@
+
+
+https://github.com/azibhassan;
target="_blank">
+
+ azibhassan
+
+
+
+1
+19
+
+
+
+
https://github.com/chenxiaohu;
target="_blank">
@@ -507,7 +521,7 @@
1
-19
+20
@@ -521,7 +535,7 @@
1
-20
+21
@@ -535,7 +549,7 @@
1
-21
+22
diff --git a/docs/skywalking-showcase/next/readme/index.html
b/docs/skywalking-showcase/next/readme/index.html
index 8a031a859ea..f6f82b437e5 100644
--- a/docs/skywalking-showcase/next/readme/index.html
+++ b/docs/skywalking-showcase/next/readme/index.html
@@ -273,7 +273,7 @@ This showcase repository includes an example music
application and other manifes
})()
- Commit Id: dae1bd8
+ Commit Id: 959d523
@@ -360,7 +360,7 @@ SkyWalking self observability.
Notice, when run this showcase locally such as KinD, the images are
downloaded inside the KinD, which could take over 10 mins(depend on local
network).
Rerun make deploy.kubernetes if some timeout errors break the
process.
Customization
-The variables defined in https://github.com/apache/skywalking-showcase/tree/dae1bd866790eebc51c7737fff0c83fe7c1b1587/Makefile.in;>Makefile.in
can be overridden to customize the showcase, by specifying an
+The variables defined in https://github.com/apache/skywalking-showcase/tree/959d5234db52a444cdc0943e59ebf113cd45d5ef/Makefile.in;>Makefile.in
can be overridden to customize the showcase, by specifying an
environment variable with the same name, e.g.:
export ES_VERSION=7.14.0
make target
@@ -368,7 +368,7 @@ make target
Run make help to get more information.
Features
The showcase is composed of a set of scenarios with feature flags, you can
deploy some of them that interest you by
-overriding the FEATURE_FLAGS variable defined in https://github.com/apache/skywalking-showcase/tree/dae1bd866790eebc51c7737fff0c83fe7c1b1587/Makefile.in;>Makefile.in,
as documented
+overriding the FEATURE_FLAGS variable defined in https://github.com/apache/skywalking-showcase/tree/959d5234db52a444cdc0943e59ebf113cd45d5ef/Makefile.in;>Makefile.in,
as documented
in Customization, e.g.:
make deploy.kubernetes FEATURE_FLAGS=single-node,agent
Feature flags for different platforms (Kubernetes and Docker
Compose) are not
diff --git a/index.html b/index.html
index 833866fe41e..0ed3130cbab 100644
--- a/index.html
+++ b/index.html
@@ -213,7 +213,7 @@
COMMUNITY
- SkyWalking has received contributions from 879 individuals now.
+ SkyWalking has received contributions from 880 individuals now.
diff --git a/index.json b/index.json
index 389ecd14088..cdc409171be 100644
--- a/index.json
+++ b/index.json
@@ -1 +1 @@
-[{"body":"Apache SkyWalking从2015年开源到2024年，已经走过了9个年头，项目的规模和功能也得到了极大的丰富。
2024年4月至6月，SkyWalking社区联合纵目，举办线上的联合直播，分多个主题介绍SkyWalking的核心特性，也提供更多的答疑时间。\n2024年4月25日，SkyWalking创始人带来了第一次分享和Q\u0026amp;A\n
熟悉SkyWalking项目结构 介绍项目工程划分，边界，定位 SkyWalking文档使用，以及如何使用AI助手 Q\u0026amp;A
B站视频地址\n想参与直播的小伙伴，可以关注后续的直播安排和我们的B站直播预约\n","excerpt":"Apache
