Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]
Almot77 commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109322821 Okay, i'l test it now. We use php application in docker + sw php libay for trace collecting + grafana dashboards (made from sw examples for grafana) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix topn query nil and add more context to err [skywalking-banyandb]
Almot77 commented on PR #445: URL: https://github.com/apache/skywalking-banyandb/pull/445#issuecomment-2109320331 Okay, i'l test it now. We use php application in docker + sw php libay for trace collecting + grafana dashboards (made from sw examples for grafana) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]
CzyerChen commented on PR #691: URL: https://github.com/apache/skywalking-java/pull/691#issuecomment-2109206083 > I can see RocketMQ case fails again. OK，I will check RocketMQ case first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]
wu-sheng commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109188070 I reopened this as we don't know gow this happens. @Almot77 We will need more, could you package the whole data folder to us, then we could address what is the illegal data. Or could you share how we could reproduce this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix topn query nil and add more context to err [skywalking-banyandb]
hanahmily commented on PR #445: URL: https://github.com/apache/skywalking-banyandb/pull/445#issuecomment-2109168664 > Will we cherry-pick this commit to v0.6.x? I prefer waiting for 24 hours for future feedback on the error, and regardless of the result, a new patch is necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch topn-entity deleted (was c023b1ab)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch topn-entity in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was c023b1ab Update change log The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(skywalking-banyandb) branch main updated: Fix topn query nil and add more context to err (#445)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new c8270670 Fix topn query nil and add more context to err (#445)
c8270670 is described below
commit c8270670d47a9c6caa2661af434157656c4b7eaf
Author: Gao Hongtao
AuthorDate: Tue May 14 10:22:54 2024 +0800
Fix topn query nil and add more context to err (#445)
---
CHANGES.md | 8
banyand/internal/storage/index.go | 6 ++-
banyand/query/processor_topn.go| 1 +
pkg/index/index.go | 18
test/stress/vm/Makefile| 38 +++
test/stress/vm/docker-compose.yaml | 95 ++
6 files changed, 165 insertions(+), 1 deletion(-)
diff --git a/CHANGES.md b/CHANGES.md
index 4e0bbba6..ebd0fce5 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -2,6 +2,14 @@
Release Notes.
+## 0.7.0
+
+### Features
+
+### Bugs
+
+- Fix the bug that topN query doesn't return when an error occurs.
+
## 0.6.0
### Features
diff --git a/banyand/internal/storage/index.go
b/banyand/internal/storage/index.go
index ce67627e..950d1640 100644
--- a/banyand/internal/storage/index.go
+++ b/banyand/internal/storage/index.go
@@ -101,7 +101,11 @@ func (s *seriesIndex) searchPrimary(ctx context.Context,
series []*pbv1.Series)
if err != nil {
return nil, err
}
- return convertIndexSeriesToSeriesList(ss)
+ result, err := convertIndexSeriesToSeriesList(ss)
+ if err != nil {
+ return nil, errors.WithMessagef(err, "failed to convert index
series to series list, matchers: %v, result:%v", seriesMatchers, ss)
+ }
+ return result, nil
}
var emptySeriesMatcher = index.SeriesMatcher{}
diff --git a/banyand/query/processor_topn.go b/banyand/query/processor_topn.go
index 8e64169f..99dc8b42 100644
--- a/banyand/query/processor_topn.go
+++ b/banyand/query/processor_topn.go
@@ -121,6 +121,7 @@ func (t *topNQueryProcessor) Rev(message bus.Message) (resp
bus.Message) {
if err != nil {
ml.Error().Err(err).RawJSON("req",
logger.Proto(request)).Msg("fail to close the topn plan")
resp = bus.NewMessage(bus.MessageID(now), common.NewError("fail
to execute the topn plan for measure %s: %v", topNMetadata.GetName(), err))
+ return
}
defer func() {
if err = mIterator.Close(); err != nil {
diff --git a/pkg/index/index.go b/pkg/index/index.go
index 106ccaa4..92b5efa3 100644
--- a/pkg/index/index.go
+++ b/pkg/index/index.go
@@ -237,6 +237,10 @@ type Series struct {
ID common.SeriesID
}
+func (s Series) String() string {
+ return fmt.Sprintf("%s:%d", s.EntityValues, s.ID)
+}
+
// SeriesStore is an abstract of a series repository.
type SeriesStore interface {
Store
@@ -262,6 +266,20 @@ type SeriesMatcher struct {
Type SeriesMatcherType
}
+// String returns a string representation of the series matcher.
+func (s SeriesMatcher) String() string {
+ switch s.Type {
+ case SeriesMatcherTypeExact:
+ return fmt.Sprintf("exact:%s", s.Match)
+ case SeriesMatcherTypePrefix:
+ return fmt.Sprintf("prefix:%s", s.Match)
+ case SeriesMatcherTypeWildcard:
+ return fmt.Sprintf("wildcard:%s", s.Match)
+ default:
+ return fmt.Sprintf("unknown:%s", s.Match)
+ }
+}
+
// GetSearcher returns a searcher associated with input index rule type.
type GetSearcher func(location databasev1.IndexRule_Type) (Searcher, error)
diff --git a/test/stress/vm/Makefile b/test/stress/vm/Makefile
new file mode 100644
index ..43eb4a21
--- /dev/null
+++ b/test/stress/vm/Makefile
@@ -0,0 +1,38 @@
+# Licensed to Apache Software Foundation (ASF) under one or more contributor
+# license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright
+# ownership. Apache Software Foundation (ASF) licenses this file to you under
+# the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+NAME := vm
+
+CLI_ARGS :=
+
+ifdef PROFILE
+ CLI_ARGS := $(CLI_ARGS) --profile $(PROFILE)
+endif
+
+cli_env := DOCKER_BUILDKIT=1 USER_ID=$(shell id -u) GROUP_ID=$(shell id -g)
+
+.PHONY: clean
+clean:
+ rm -rf
Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]
wu-sheng closed issue #12219: [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() URL: https://github.com/apache/skywalking/issues/12219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix topn query nil and add more context to err [skywalking-banyandb]
wu-sheng merged PR #445: URL: https://github.com/apache/skywalking-banyandb/pull/445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix topn query nil and add more context to err [skywalking-banyandb]
wu-sheng commented on PR #445: URL: https://github.com/apache/skywalking-banyandb/pull/445#issuecomment-2109152626 > Will we cherry-pick this commit to v0.6.x? It depends on why this happens. If this is blocking the general use, we should have 0.6.1. Otherwise, it is not in urgent. e2e covers the feature, but it doesn't complain anything. @lujiajing1126 Do you face anything in testing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix topn query nil and add more context to err [skywalking-banyandb]
lujiajing1126 commented on PR #445: URL: https://github.com/apache/skywalking-banyandb/pull/445#issuecomment-2109147544 Will we cherry-pick this commit to v0.6.x? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch topn-entity updated (01a270cd -> c023b1ab)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch topn-entity in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 01a270cd Fix license add c023b1ab Update change log No new revisions were added by this update. Summary of changes: CHANGES.md | 8 1 file changed, 8 insertions(+)
(skywalking-banyandb) branch topn-entity updated (58d9aaf3 -> 01a270cd)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch topn-entity in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 58d9aaf3 Fix topn query nil and add more context to err add 01a270cd Fix license No new revisions were added by this update. Summary of changes: dist/LICENSE | 1 - dist/licenses/ui-licenses/license-fsevents.txt | 22 -- ui/LICENSE | 1 - 3 files changed, 24 deletions(-) delete mode 100644 dist/licenses/ui-licenses/license-fsevents.txt
(skywalking-banyandb-helm) annotated tag v0.2.0 updated (5c073c1 -> a402dd8)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to annotated tag v0.2.0 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git *** WARNING: tag v0.2.0 was modified! *** from 5c073c1 (commit) to a402dd8 (tag) tagging 5c073c19a9484f356c4e3d3d471a3f8442fb6e8d (commit) replaces v0.1.0 by Gao Hongtao on Tue May 14 00:18:14 2024 + - Log - Release Apache SkyWalking BanyanDB Helm 0.2.0 --- No new revisions were added by this update. Summary of changes:
Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]
hanahmily commented on issue #12219:
URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109036234
The nil error is fixed by
https://github.com/apache/skywalking-banyandb/pull/445/files#diff-695073ea8dec3fcdaae77a3fcfb4eabc7290daade34399aee1de42d7b476R124
But the error below is a bit tricky.
```
{"level":"error","module":"QUERY.TOPN.MEASURE-MINUTE.ENDPOINT_RESP_TIME_MINUTE_TOPN","error":"failed
to query measure: unmarshal tag value: unsupported tag value
type","req":{"groups":["measure-minute"],
"name":"endpoint_resp_time_minute_topn",
"timeRange":{"begin":"2024-05-13T14:20:00Z", "end":"2024-05-13T14:51:00Z"},
"topN":10, "agg":"AGGREGATION_FUNCTION_MEAN",
"conditions":[{"name":"service_id", "op":"BINARY_OP_EQ",
"value":{"str":{"value":"cGhwLW1zay1sZWdhY3k=.1"}}}],
"fieldValueSort":"SORT_DESC"},"time":"2024-05-13T14:50:30Z","message":"fail to
close the topn plan"}
```
@Almot77 Would you pls use the last banyandb image built from
https://github.com/apache/skywalking-banyandb/pull/445 to output more context
about this error?
If you have an appropriate docker environment, issuing `make docker.build `
is all you need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]
wu-sheng commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109032259 This error is easy to fix, @Almot77 but we want to know how you could trigger it, as we have run many tests to verify features. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [WIP]Fix topn query nil and add more context to err [skywalking-banyandb]
hanahmily opened a new pull request, #445: URL: https://github.com/apache/skywalking-banyandb/pull/445 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#12219. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) 01/01: Fix topn query nil and add more context to err
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch topn-entity
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 58d9aaf3ebdf9a9fad381009683c1d5c9250d27e
Author: Gao Hongtao
AuthorDate: Tue May 14 07:55:44 2024 +0800
Fix topn query nil and add more context to err
Signed-off-by: Gao Hongtao
---
banyand/internal/storage/index.go | 6 +-
banyand/query/processor_topn.go| 1 +
dist/LICENSE | 1 +
dist/licenses/ui-licenses/license-fsevents.txt | 22 ++
pkg/index/index.go | 18 +
test/stress/vm/Makefile| 38 +++
test/stress/vm/docker-compose.yaml | 95 ++
ui/LICENSE | 1 +
8 files changed, 181 insertions(+), 1 deletion(-)
diff --git a/banyand/internal/storage/index.go
b/banyand/internal/storage/index.go
index ce67627e..950d1640 100644
--- a/banyand/internal/storage/index.go
+++ b/banyand/internal/storage/index.go
@@ -101,7 +101,11 @@ func (s *seriesIndex) searchPrimary(ctx context.Context,
series []*pbv1.Series)
if err != nil {
return nil, err
}
- return convertIndexSeriesToSeriesList(ss)
+ result, err := convertIndexSeriesToSeriesList(ss)
+ if err != nil {
+ return nil, errors.WithMessagef(err, "failed to convert index
series to series list, matchers: %v, result:%v", seriesMatchers, ss)
+ }
+ return result, nil
}
var emptySeriesMatcher = index.SeriesMatcher{}
diff --git a/banyand/query/processor_topn.go b/banyand/query/processor_topn.go
index 8e64169f..99dc8b42 100644
--- a/banyand/query/processor_topn.go
+++ b/banyand/query/processor_topn.go
@@ -121,6 +121,7 @@ func (t *topNQueryProcessor) Rev(message bus.Message) (resp
bus.Message) {
if err != nil {
ml.Error().Err(err).RawJSON("req",
logger.Proto(request)).Msg("fail to close the topn plan")
resp = bus.NewMessage(bus.MessageID(now), common.NewError("fail
to execute the topn plan for measure %s: %v", topNMetadata.GetName(), err))
+ return
}
defer func() {
if err = mIterator.Close(); err != nil {
diff --git a/dist/LICENSE b/dist/LICENSE
index 71b7afc8..82862748 100644
--- a/dist/LICENSE
+++ b/dist/LICENSE
@@ -470,6 +470,7 @@ MIT licenses
fill-range 7.0.1 MIT
follow-redirects 1.15.6 MIT
form-data 4.0.0 MIT
+fsevents 2.3.3 MIT
immutable 4.3.5 MIT
is-binary-path 2.1.0 MIT
is-extglob 2.1.1 MIT
diff --git a/dist/licenses/ui-licenses/license-fsevents.txt
b/dist/licenses/ui-licenses/license-fsevents.txt
new file mode 100644
index ..5d70441c
--- /dev/null
+++ b/dist/licenses/ui-licenses/license-fsevents.txt
@@ -0,0 +1,22 @@
+MIT License
+---
+
+Copyright (C) 2010-2020 by Philipp Dunkel, Ben Noordhuis, Elan Shankar, Paul
Miller
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
diff --git a/pkg/index/index.go b/pkg/index/index.go
index 106ccaa4..92b5efa3 100644
--- a/pkg/index/index.go
+++ b/pkg/index/index.go
@@ -237,6 +237,10 @@ type Series struct {
ID common.SeriesID
}
+func (s Series) String() string {
+ return fmt.Sprintf("%s:%d", s.EntityValues, s.ID)
+}
+
// SeriesStore is an abstract of a series repository.
type SeriesStore interface {
Store
@@ -262,6 +266,20 @@ type SeriesMatcher struct {
Type SeriesMatcherType
}
+// String returns a string representation of the series matcher.
+func (s SeriesMatcher) String() string {
+ switch s.Type {
+ case SeriesMatcherTypeExact:
+ return fmt.Sprintf("exact:%s", s.Match)
+ case SeriesMatcherTypePrefix:
+ return fmt.Sprintf("prefix:%s", s.Match)
+ case SeriesMatcherTypeWildcard:
+ return fmt.Sprintf("wildcard:%s",
(skywalking-banyandb) branch topn-entity updated (a3464aff -> 58d9aaf3)
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch topn-entity
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
discard a3464aff Fix topn query nil and add more context to err
new 58d9aaf3 Fix topn query nil and add more context to err
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (a3464aff)
\
N -- N -- N refs/heads/topn-entity (58d9aaf3)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
dist/LICENSE | 1 +
.../{license-codemirror.txt => license-fsevents.txt} | 3 ++-
test/stress/vm/docker-compose.yaml| 15 +++
ui/LICENSE| 1 +
4 files changed, 19 insertions(+), 1 deletion(-)
copy dist/licenses/ui-licenses/{license-codemirror.txt =>
license-fsevents.txt} (91%)
(skywalking-banyandb) 01/01: Fix topn query nil and add more context to err
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch topn-entity
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit a3464aff95e673a89bf0af4a48843b76094ec15c
Author: Gao Hongtao
AuthorDate: Tue May 14 07:55:44 2024 +0800
Fix topn query nil and add more context to err
Signed-off-by: Gao Hongtao
---
banyand/internal/storage/index.go | 6 ++-
banyand/query/processor_topn.go| 1 +
pkg/index/index.go | 18 +
test/stress/vm/Makefile| 38 ++
test/stress/vm/docker-compose.yaml | 80 ++
5 files changed, 142 insertions(+), 1 deletion(-)
diff --git a/banyand/internal/storage/index.go
b/banyand/internal/storage/index.go
index ce67627e..950d1640 100644
--- a/banyand/internal/storage/index.go
+++ b/banyand/internal/storage/index.go
@@ -101,7 +101,11 @@ func (s *seriesIndex) searchPrimary(ctx context.Context,
series []*pbv1.Series)
if err != nil {
return nil, err
}
- return convertIndexSeriesToSeriesList(ss)
+ result, err := convertIndexSeriesToSeriesList(ss)
+ if err != nil {
+ return nil, errors.WithMessagef(err, "failed to convert index
series to series list, matchers: %v, result:%v", seriesMatchers, ss)
+ }
+ return result, nil
}
var emptySeriesMatcher = index.SeriesMatcher{}
diff --git a/banyand/query/processor_topn.go b/banyand/query/processor_topn.go
index 8e64169f..99dc8b42 100644
--- a/banyand/query/processor_topn.go
+++ b/banyand/query/processor_topn.go
@@ -121,6 +121,7 @@ func (t *topNQueryProcessor) Rev(message bus.Message) (resp
bus.Message) {
if err != nil {
ml.Error().Err(err).RawJSON("req",
logger.Proto(request)).Msg("fail to close the topn plan")
resp = bus.NewMessage(bus.MessageID(now), common.NewError("fail
to execute the topn plan for measure %s: %v", topNMetadata.GetName(), err))
+ return
}
defer func() {
if err = mIterator.Close(); err != nil {
diff --git a/pkg/index/index.go b/pkg/index/index.go
index 106ccaa4..92b5efa3 100644
--- a/pkg/index/index.go
+++ b/pkg/index/index.go
@@ -237,6 +237,10 @@ type Series struct {
ID common.SeriesID
}
+func (s Series) String() string {
+ return fmt.Sprintf("%s:%d", s.EntityValues, s.ID)
+}
+
// SeriesStore is an abstract of a series repository.
type SeriesStore interface {
Store
@@ -262,6 +266,20 @@ type SeriesMatcher struct {
Type SeriesMatcherType
}
+// String returns a string representation of the series matcher.
+func (s SeriesMatcher) String() string {
+ switch s.Type {
+ case SeriesMatcherTypeExact:
+ return fmt.Sprintf("exact:%s", s.Match)
+ case SeriesMatcherTypePrefix:
+ return fmt.Sprintf("prefix:%s", s.Match)
+ case SeriesMatcherTypeWildcard:
+ return fmt.Sprintf("wildcard:%s", s.Match)
+ default:
+ return fmt.Sprintf("unknown:%s", s.Match)
+ }
+}
+
// GetSearcher returns a searcher associated with input index rule type.
type GetSearcher func(location databasev1.IndexRule_Type) (Searcher, error)
diff --git a/test/stress/vm/Makefile b/test/stress/vm/Makefile
new file mode 100644
index ..43eb4a21
--- /dev/null
+++ b/test/stress/vm/Makefile
@@ -0,0 +1,38 @@
+# Licensed to Apache Software Foundation (ASF) under one or more contributor
+# license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright
+# ownership. Apache Software Foundation (ASF) licenses this file to you under
+# the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+NAME := vm
+
+CLI_ARGS :=
+
+ifdef PROFILE
+ CLI_ARGS := $(CLI_ARGS) --profile $(PROFILE)
+endif
+
+cli_env := DOCKER_BUILDKIT=1 USER_ID=$(shell id -u) GROUP_ID=$(shell id -g)
+
+.PHONY: clean
+clean:
+ rm -rf /tmp/banyandb-stress-vm
+
+up: clean
+ $(cli_env) docker compose -f docker-compose.yaml $(CLI_ARGS) up --build
+
+down:
+ docker compose -f docker-compose.yaml down
+
\ No newline at end of file
diff --git a/test/stress/vm/docker-compose.yaml
b/test/stress/vm/docker-compose.yaml
new file mode 100644
index ..b7e79cd6
--- /dev/null
+++ b/test/stress/vm/docker-compose.yaml
@@ -0,0 +1,80 @@
+version: '3.8'
+services:
+
(skywalking-banyandb) branch topn-entity created (now a3464aff)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch topn-entity in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at a3464aff Fix topn query nil and add more context to err This branch includes the following new commits: new a3464aff Fix topn query nil and add more context to err The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]
wu-sheng commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109013133 Are you using docker quick start? We haven't upgraded it to latest. It needs v10 oap and latest banyandb 0.6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-helm) annotated tag v0.2.0 deleted (was 2ebb393)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to annotated tag v0.2.0 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git *** WARNING: tag v0.2.0 was deleted! *** tag was 2ebb393 The revisions that were on this annotated tag are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]
Almot77 commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108659386 > Your configuration is not well formatted. Please correct them. And what does `SW_STORAGE: elasticsearch` mean? I think we don't need Elasticsearch when you use BanyanDB. > > And we don't have banyandb-helm 0.2 release, how do you deploy the database? > s/bus.go:270 + It`s docker-compose.yml file. I run SW with selected db profile: elastic or banyandb. Right way to run it: docker compose --profile banyandb up -d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]
prostocvet commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108655703 > s/bus.go:270 + It`s docker-compose file to run SW with selected db profile: elastic or banyandb. right way to run it: docker compose --profile banyandb up -d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] update dependencies [skywalking-java]
JoeCqupt commented on PR #690: URL: https://github.com/apache/skywalking-java/pull/690#issuecomment-2108081345 after i clear my .m2/repository dir. then everything is all right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]
wu-sheng commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108057982 @lujiajing1126 What is the case of occurring this error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]
lujiajing1126 commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108047447 After checking the code, it seems error is not handled properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]
wu-sheng commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108046013 Your configuration is not well formatted. Please correct them. And what does `SW_STORAGE: elasticsearch` mean? I think we don't need Elasticsearch when you use BanyanDB. And we don't have banyandb-helm 0.2 release, how do you deploy the database? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]
wu-sheng commented on PR #691: URL: https://github.com/apache/skywalking-java/pull/691#issuecomment-2108028821 I can see RocketMQ case fails again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]
Almot77 opened a new issue, #12219:
URL: https://github.com/apache/skywalking/issues/12219
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
BanyanDB (apache/skywalking-banyandb)
### What happened
Server crash on segmentation fault in docker. I use :latest SW and BYDB
images (new releases).
### What you expected to happen
{"level":"info","module":"STREAM-SEGMENT.SCHEDULER.RETENTION","name":"retention","now":"2024-05-13T14:49:52Z","time":"2024-05-13T14:49:52Z","message":"start"}
{"level":"info","module":"STREAM","group":"stream-browser_error_log","time":"2024-05-13T14:49:52Z","message":"creating
a tsdb"}
{"level":"info","module":"STREAM-BROWSER_ERROR_LOG","path":"/tmp/stream-data/stream/stream-browser_error_log","time":"2024-05-13T14:49:52Z","message":"initialized"}
{"level":"info","module":"STREAM-BROWSER_ERROR_LOG.SCHEDULER.RETENTION","name":"retention","now":"2024-05-13T14:49:52Z","time":"2024-05-13T14:49:52Z","message":"start"}
{"level":"info","module":"STREAM","group":"stream-zipkin_span","time":"2024-05-13T14:49:52Z","message":"creating
a tsdb"}
{"level":"info","module":"STREAM-ZIPKIN_SPAN","path":"/tmp/stream-data/stream/stream-zipkin_span","time":"2024-05-13T14:49:52Z","message":"initialized"}
{"level":"info","module":"STREAM-ZIPKIN_SPAN.SCHEDULER.RETENTION","name":"retention","now":"2024-05-13T14:49:52Z","time":"2024-05-13T14:49:52Z","message":"start"}
{"level":"error","module":"QUERY.TOPN.MEASURE-MINUTE.ENDPOINT_RESP_TIME_MINUTE_TOPN","error":"failed
to query measure: unmarshal tag value: unsupported tag value
type","req":{"groups":["measure-minute"],
"name":"endpoint_resp_time_minute_topn",
"timeRange":{"begin":"2024-05-13T14:20:00Z", "end":"2024-05-13T14:51:00Z"},
"topN":10, "agg":"AGGREGATION_FUNCTION_MEAN",
"conditions":[{"name":"service_id", "op":"BINARY_OP_EQ",
"value":{"str":{"value":"cGhwLW1zay1sZWdhY3k=.1"}}}],
"fieldValueSort":"SORT_DESC"},"time":"2024-05-13T14:50:30Z","message":"fail to
close the topn plan"}
panic: runtime error: invalid memory address or nil pointer dereference
panic: runtime error: invalid memory address or nil pointer
dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x1251163]
goroutine 356 [running]:
github.com/apache/skywalking-banyandb/banyand/query.(*topNQueryProcessor).Rev.func1()
/src/banyand/query/processor_topn.go:126 +0x23
panic({0x13d6e40?, 0x259ebd0?})
/usr/local/go/src/runtime/panic.go:770 +0x132
github.com/apache/skywalking-banyandb/banyand/query.(*topNQueryProcessor).Rev(0xc10fd8,
{{0x156fd20, 0xc0085ce280}, {0x15f10a0, 0x5}, 0x17cf13deadbc52eb, 0x0})
/src/banyand/query/processor_topn.go:133 +0xfd6
github.com/apache/skywalking-banyandb/pkg/bus.(*Bus).Subscribe.func1({0x1a71de0,
0xc10fd8}, 0xc0001d09c0)
/src/pkg/bus/bus.go:274 +0xfa
created by github.com/apache/skywalking-banyandb/pkg/bus.(*Bus).Subscribe in
goroutine 1
/src/pkg/bus/bus.go:270 +0x28f
### How to reproduce
Docker compose docker compose --profile banyandb up -d
version: '3.8'
services:
elasticsearch:
profiles:
- "elasticsearch"
image: itbgk/elasticsearch-oss:7.9.2
container_name: skywalking-elasticsearch
ports:
- "9200:9200"
networks:
- skywalking
volumes:
- elastic-sw:/usr/share/elasticsearch/data
healthcheck:
test: [ "CMD-SHELL", "curl --silent --fail
localhost:9200/_cluster/health || exit 1" ]
interval: 30s
timeout: 10s
retries: 3
start_period: 10s
restart: always
environment:
- discovery.type=single-node
- bootstrap.memory_lock=true
- "ES_JAVA_OPTS=-Xms512m -Xmx512m"
ulimits:
memlock:
soft: -1
hard: -1
banyandb:
profiles:
- "banyandb"
image: ${BANYANDB_IMAGE:-apache/skywalking-banyandb:latest}
container_name: banyandb
restart: always
networks:
- skywalking
expose:
- 17912
ports:
- 17913:17913
volumes:
- banyandb-stream-data:/tmp/stream-data
- banyandb-measure-data:/tmp/measure-data
command: standalone --stream-root-path /tmp/stream-data
--measure-root-path /tmp/measure-data
healthcheck:
test: [ "CMD", "sh", "-c", "nc -nz 127.0.0.1 17912" ]
interval: 5s
timeout: 60s
retries: 120
oap-base:
profiles: [ "none" ]
image: ${OAP_IMAGE:-ghcr.io/apache/skywalking/oap:latest}
ports:
- "11800:11800"
- "12800:12800"
- "9099:9090"
- "3100:3100"
networks:
Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]
wu-sheng commented on code in PR #691: URL: https://github.com/apache/skywalking-java/pull/691#discussion_r1598620639 ## CHANGES.md: ## @@ -11,6 +11,7 @@ Release Notes. * Use a daemon thread to flush logs. * Fix typos in `URLParser`. * Add support for `Derby`/`Sybase`/`SQLite`/`DB2`/`OceanBase` jdbc url format in `URLParser`. +* Optimize spring-plugins:scheduled-annotation-plugin compatibility. Review Comment: ```suggestion * Optimize spring-plugins:scheduled-annotation-plugin compatibility about Spring 6.1.x support. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SkyWalking Operator helm does not yet include the CRD for BanyanDB. [skywalking]
dashanji closed issue #12040: [Bug] SkyWalking Operator helm does not yet include the CRD for BanyanDB. URL: https://github.com/apache/skywalking/issues/12040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SkyWalking Operator helm does not yet include the CRD for BanyanDB. [skywalking]
dashanji commented on issue #12040: URL: https://github.com/apache/skywalking/issues/12040#issuecomment-2107693144 Fix in https://github.com/apache/skywalking-helm/pull/146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-helm) branch master updated: Move image parameters to the root (#17)
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
The following commit(s) were added to refs/heads/master by this push:
new 5c073c1 Move image parameters to the root (#17)
5c073c1 is described below
commit 5c073c19a9484f356c4e3d3d471a3f8442fb6e8d
Author: Huang Youliang
AuthorDate: Mon May 13 21:49:42 2024 +0800
Move image parameters to the root (#17)
* Update image repository and tag of BanyanDB cluster
* Move image parameters to the root
* Update configuration in the document
---
README.md| 22 +++---
chart/templates/deployment.yaml | 4 ++--
chart/templates/statefulset.yaml | 10 +-
chart/values.yaml| 13 +
test/e2e/values.cluster.yaml | 9 +
test/e2e/values.standalone.yaml | 11 ++-
6 files changed, 30 insertions(+), 39 deletions(-)
diff --git a/README.md b/README.md
index f10a917..138a4ec 100644
--- a/README.md
+++ b/README.md
@@ -54,7 +54,7 @@ The command removes all the banyandb components associated
with the chart and de
| cluster.data.grpcSvc.port | int | `17912` | |
| cluster.data.name | string | `"banyandb"` | |
| cluster.data.nodeSelector | list | `[]` | |
-| cluster.data.podAnnotations.example | string | `"banyandb-foo"` | |
+| cluster.data.podAnnotations | string | `nil` | |
| cluster.data.podDisruptionBudget | object | `{}` | |
| cluster.data.priorityClassName | string | `""` | |
| cluster.data.replicas | int | `3` | |
@@ -63,14 +63,9 @@ The command removes all the banyandb components associated
with the chart and de
| cluster.data.role | string | `"data"` | |
| cluster.data.securityContext | object | `{}` | |
| cluster.data.sidecar | list | `[]` | |
-| cluster.data.tls.etcdSecretName | string | `""` | |
-| cluster.data.tls.grpcSecretName | string | `""` | |
| cluster.data.tolerations | list | `[]` | |
| cluster.enabled | bool | `true` | |
| cluster.etcdEndpoints | list | `[]` | |
-| cluster.image.pullPolicy | string | `"IfNotPresent"` | |
-| cluster.image.repository | string | `"docker.io/apache/skywalking-banyandb"`
| |
-| cluster.image.tag | string | `"0.6.0"` | |
| cluster.liaison.affinity | object | `{}` | |
| cluster.liaison.env | list | `[]` | |
| cluster.liaison.grpcSvc.annotations | object | `{}` | |
@@ -90,7 +85,7 @@ The command removes all the banyandb components associated
with the chart and de
| cluster.liaison.ingress.tls | list | `[]` | |
| cluster.liaison.name | string | `"banyandb"` | |
| cluster.liaison.nodeSelector | list | `[]` | |
-| cluster.liaison.podAnnotations.example | string | `"banyandb-foo"` | |
+| cluster.liaison.podAnnotations | string | `nil` | |
| cluster.liaison.podDisruptionBudget | object | `{}` | |
| cluster.liaison.priorityClassName | string | `""` | |
| cluster.liaison.replicas | int | `2` | |
@@ -98,9 +93,6 @@ The command removes all the banyandb components associated
with the chart and de
| cluster.liaison.resources.requests | list | `[]` | |
| cluster.liaison.role | string | `"liaison"` | |
| cluster.liaison.securityContext | object | `{}` | |
-| cluster.liaison.tls.etcdSecretName | string | `""` | |
-| cluster.liaison.tls.grpcSecretName | string | `""` | |
-| cluster.liaison.tls.httpSecretName | string | `""` | |
| cluster.liaison.tolerations | list | `[]` | |
| etcd.auth.client.caFilename | string | `""` | |
| etcd.auth.client.certFilename | string | `"tls.crt"` | |
@@ -114,6 +106,9 @@ The command removes all the banyandb components associated
with the chart and de
| etcd.enabled | bool | `true` | |
| etcd.replicaCount | int | `1` | |
| fullnameOverride | string | `"banyandb"` | |
+| image.pullPolicy | string | `"IfNotPresent"` | |
+| image.repository | string | `"docker.io/apache/skywalking-banyandb"` | |
+| image.tag | string | `"0.6.0"` | |
| serviceAccount.annotations | object | `{}` | |
| serviceAccount.create | bool | `true` | |
| serviceAccount.name | string | `""` | |
@@ -130,9 +125,6 @@ The command removes all the banyandb components associated
with the chart and de
| standalone.httpSvc.loadBalancerSourceRanges | list | `[]` | |
| standalone.httpSvc.port | int | `17913` | |
| standalone.httpSvc.type | string | `"LoadBalancer"` | |
-| standalone.image.pullPolicy | string | `"IfNotPresent"` | |
-| standalone.image.repository | string |
`"docker.io/apache/skywalking-banyandb"` | |
-| standalone.image.tag | string | `"0.6.0"` | |
| standalone.ingress.annotations | object | `{}` | |
| standalone.ingress.enabled | bool | `false` | |
| standalone.ingress.labels | object | `{}` | |
@@ -156,14 +148,14 @@ The command removes all the banyandb components
associated with the chart and de
| storage.persistentVolumeClaims[0].existingClaimName | string | `nil` | |
|
Re: [PR] Move image parameters to the root [skywalking-banyandb-helm]
hanahmily merged PR #17: URL: https://github.com/apache/skywalking-banyandb-helm/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SkyWalking Operator helm does not yet include the CRD for BanyanDB. [skywalking]
wu-sheng commented on issue #12040: URL: https://github.com/apache/skywalking/issues/12040#issuecomment-2107585227 @ButterBright How about this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107534947 > > I think you got it wrong. It should be in ContextManager#continued method, which controls the context. > > Understood. How can the [span](https://github.com/apache/skywalking-java/blob/1a010470076ba7f206f4fd6559d04136bea73417/apm-sniffer/optional-plugins/optional-spring-plugins/optional-spring-cloud/gateway-2.0.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/cloud/gateway/v20x/NettyRoutingFilterInterceptor.java#L44) used by the plugin be changed to a NoopSpan? Consider creating `AbstractTracerContext#forceIgnoring. `TracingContext#forceIgnoring` could return a `IgnoredTracerContext` with the same stack depth, to make sure no tracing context stack leak. `IgnoredTracerContext` just simply returns **this** as no change is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107529372 > > This is a force sampling(unsampling), we don't need to worry about sampling counter. > > ForceSampling might not necessarily be true. I feel that it could still impact the count of the SamplingService. It just counts one more, so what? Sampling is never to be accurate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107509503 > This is a force sampling(unsampling), we don't need to worry about sampling counter. > This is a force sampling(unsampling), we don't need to worry about sampling counter. ForceSampling might not necessarily be true. I feel that it could still impact the count of the SamplingService. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107480474 > I think you got it wrong. It should be in ContextManager#continued method, which controls the context. Understood. How can the [span](https://github.com/apache/skywalking-java/blob/1a010470076ba7f206f4fd6559d04136bea73417/apm-sniffer/optional-plugins/optional-spring-plugins/optional-spring-cloud/gateway-2.0.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/cloud/gateway/v20x/NettyRoutingFilterInterceptor.java#L44) used by the plugin be changed to a NoopSpan? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107451077 This is a force sampling(unsampling), we don't need to worry about sampling counter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107449336 I think you got it wrong. It should be in ContextManager#continued method, which controls the context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking-java maven build problem [skywalking]
JoeCqupt closed issue #12218: [Bug] skywalking-java maven build problem URL: https://github.com/apache/skywalking/issues/12218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] update dependencies [skywalking-java]
JoeCqupt closed pull request #690: update dependencies URL: https://github.com/apache/skywalking-java/pull/690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107376314 > When this is about ContextManager, it should not affect TracingContext#CreateLocal span. Only snapshot should be changed, and ContextManager asked TracingContext switching to IgnoringTracingCntext with the same stack. Also, the plugins should not be changed, and all span and context manager APIs should not be changed. If the TracingContext switches to IgnoringTracingContext in the continued method, the span reference created by the ContextManager#createLocalSpan method cannot be changed, and the plugin still uses the span before the switch. Additionally, the already created but useless TracingContext will increment the sampling count of the operationName by one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107355009 When this is about ContextManager, it should not affect TracingContext#CreateLocal span. Only snapshot should be changed, and ContextManager asked TracingContext switching to IgnoringTracingCntext with the same stack. Also, the plugins should not be changed, and all span and context manager APIs should not be changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move image parameters to the root [skywalking-banyandb-helm]
ButterBright commented on PR #17: URL: https://github.com/apache/skywalking-banyandb-helm/pull/17#issuecomment-2107324862 Sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107275825 You are adding a mechanism for local span creation. This should not happen, if there is a context switching out, it must be controlled by ContextManager. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107265410 I don't have direct answer, if I had, I already told you in the last discussion. The reason it doesn't exist is, the tracing context is created before the snapshot is continued. You proposal should cover about how. The cross process is more complex. And sampling is service(process) oriented. There is a flag in the protocol about sampling, but you have to evaluate all agent codes(all languages), about whether there will be an impact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107252722 > I think we need to separate the context. Cross thread is different from cross process. Cross process is defined here, https://skywalking.apache.org/docs/main/latest/en/api/x-process-propagation-headers-v3/. This can't be changed as it crosses all language agents. > > About crosee thread, the status should only documented in the snapshot. But I am not clear about how you changed a sampled tracing context into a ignoring context? This question can be divided into two parts: 1. In the scenario of cross-thread, is it necessary to continue the upstream context? 2. If the first point is necessary, how can we modify it to better align with the official way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107220318 I am feeling you are doing a hijack only, which should not be the official way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107218830 I think we need to separate the context. Cross thread is different from cross process. Cross process is defined here, https://skywalking.apache.org/docs/main/latest/en/api/x-process-propagation-headers-v3/. This can't be changed as it crosses all language agents. About crosee thread, the status should only documented in the snapshot. But I am not clear about how you changed a sampled tracing context into a ignoring context? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107191416 > Add what? here: https://github.com/apache/skywalking-java/pull/689#issue-2292115894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107183993 Add what? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move image parameters to the root [skywalking-banyandb-helm]
wu-sheng commented on PR #17: URL: https://github.com/apache/skywalking-banyandb-helm/pull/17#issuecomment-2107183002 Do we need to update docs accordingly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107173269 > Please write a proposal about what is a force-ignoring mechanism. The discussion we did was only about the context. Added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] update dependencies [skywalking-java]
wu-sheng commented on PR #690: URL: https://github.com/apache/skywalking-java/pull/690#issuecomment-2107025344 CI has covered all compiling process, nothing wrong happens. Please be clear why you failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] update dependencies [skywalking-java]
JoeCqupt opened a new pull request, #690: URL: https://github.com/apache/skywalking-java/pull/690 ### Fix - [ ] Add a unit test to verify that the fix works. - [] Explain briefly why the bug exists and how to fix it. - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. https://github.com/apache/skywalking/issues/12218 - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] skywalking-java maven build problem [skywalking]
JoeCqupt opened a new issue, #12218: URL: https://github.com/apache/skywalking/issues/12218 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component Java Agent (apache/skywalking-java) ### What happened i find that maven build `skywalking-java` some module will compiler fail. * org.apache.skywalking:apm-toolkit-log4j-2.x-activation:jar:9.3.0-SNAPSHOT * gateway-2.0.x-plugin * gateway-2.1.x-plugin ### What you expected to happen maven build success ### How to reproduce ``` @MacintoshdeMacBook-Pro-2 skywalking-java % mvn -v Apache Maven 3.8.8 (4c87b05d9aedce574290d1acc98575ed5eb6cd39) Maven home: /Users//dev-tools/apache-maven-3.8.8 Java version: 17.0.6, vendor: Oracle Corporation, runtime: /Users//dev-tools/jdk-17.0.6.jdk/Contents/Home Default locale: zh_CN_#Hans, platform encoding: UTF-8 OS name: "mac os x", version: "14.2.1", arch: "aarch64", family: "mac" @MacintoshdeMacBook-Pro-2 skywalking-java % mvn clean install ``` https://github.com/apache/skywalking/assets/12369652/25f3116a-c8db-430b-bac8-a7f5d9424595;> ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [X] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2106941367 For an official proposal, you could refer to SWIP(https://skywalking.apache.org/docs/main/next/en/swip/readme/), which is mandatory for OAP, but not for the agent. A key part of a proposal is about why you want to change, how you design looks like, what are the impacts. Then we could discuss for more details. A reminder for you, the way you changes, is making a significant impact for existing APIs, this may not be a good way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2106934764 > Please write a proposal about what is a force-ignoring mechanism. The discussion we did was only about the context. Do you have a proposal template? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2106928547 Please write a proposal about what is a force-ignoring mechanism. The discussion we did was only about the context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch wu-sheng-patch-1 deleted (was 84a30e5a76)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git was 84a30e5a76 Fix next SWIP ID The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(skywalking) branch master updated: Fix next SWIP ID (#12217)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 7f20b99b4f Fix next SWIP ID (#12217) 7f20b99b4f is described below commit 7f20b99b4f7574bc5f2ed9c13a5e52f1995f6e07 Author: 吴晟 Wu Sheng AuthorDate: Mon May 13 16:04:38 2024 +0800 Fix next SWIP ID (#12217) --- docs/en/swip/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/en/swip/readme.md b/docs/en/swip/readme.md index c901ba7856..919a078d05 100644 --- a/docs/en/swip/readme.md +++ b/docs/en/swip/readme.md @@ -68,7 +68,7 @@ All accepted and proposed SWIPs can be found in [here](https://github.com/apache ## Known SWIPs -Next SWIP Number: 8 +Next SWIP Number: 9 ### Accepted SWIPs
[PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
gzlicanyi opened a new pull request, #689: URL: https://github.com/apache/skywalking-java/pull/689 Add a [forceIgnoring mechanism](https://github.com/apache/skywalking/discussions/12161) and apply it to the plugins (Spring Cloud Gateway, HttpClient, JDK-ForkJoinPool, JDK-Threading, JDK-ThreadPool, Toolkit-Trace, Toolkit-WebFlux) - [x] Tests(including UT, IT, E2E) are added to verify the new feature. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix next SWIP ID [skywalking]
wu-sheng merged PR #12217: URL: https://github.com/apache/skywalking/pull/12217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix next SWIP ID [skywalking]
wu-sheng opened a new pull request, #12217: URL: https://github.com/apache/skywalking/pull/12217 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). FYI @CzyerChen You seem to miss this in your last SWIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch wu-sheng-patch-1 created (now 84a30e5a76)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git at 84a30e5a76 Fix next SWIP ID This branch includes the following new commits: new 84a30e5a76 Fix next SWIP ID The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(skywalking) 01/01: Fix next SWIP ID
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 84a30e5a76b22814ce016069b62d7a84b97c4907 Author: 吴晟 Wu Sheng AuthorDate: Mon May 13 16:00:44 2024 +0800 Fix next SWIP ID --- docs/en/swip/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/en/swip/readme.md b/docs/en/swip/readme.md index c901ba7856..919a078d05 100644 --- a/docs/en/swip/readme.md +++ b/docs/en/swip/readme.md @@ -68,7 +68,7 @@ All accepted and proposed SWIPs can be found in [here](https://github.com/apache ## Known SWIPs -Next SWIP Number: 8 +Next SWIP Number: 9 ### Accepted SWIPs
Re: [PR] Update image repository and tag of BanyanDB cluster [skywalking-banyandb-helm]
wu-sheng commented on PR #17: URL: https://github.com/apache/skywalking-banyandb-helm/pull/17#issuecomment-2106807251 Do we want to control this in the same place? Like we may need to override repo and commit ID within dev stage? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update image repository and tag of BanyanDB cluster [skywalking-banyandb-helm]
ButterBright opened a new pull request, #17: URL: https://github.com/apache/skywalking-banyandb-helm/pull/17 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update configuration in the document [skywalking-banyandb-helm]
wu-sheng merged PR #16: URL: https://github.com/apache/skywalking-banyandb-helm/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-helm) branch master updated: Update configuration in the document (#16)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
The following commit(s) were added to refs/heads/master by this push:
new 5f364d1 Update configuration in the document (#16)
5f364d1 is described below
commit 5f364d13d7a60ee0b475198434ae836b36dd8392
Author: Huang Youliang
AuthorDate: Mon May 13 14:56:07 2024 +0800
Update configuration in the document (#16)
---
README.md | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/README.md b/README.md
index 430f87d..f10a917 100644
--- a/README.md
+++ b/README.md
@@ -69,8 +69,8 @@ The command removes all the banyandb components associated
with the chart and de
| cluster.enabled | bool | `true` | |
| cluster.etcdEndpoints | list | `[]` | |
| cluster.image.pullPolicy | string | `"IfNotPresent"` | |
-| cluster.image.repository | string | `"ghcr.io/apache/skywalking-banyandb"` |
|
-| cluster.image.tag | string | `"dc88130e8d0516c7989734bdeb505e2d92c1ab71"` |
|
+| cluster.image.repository | string | `"docker.io/apache/skywalking-banyandb"`
| |
+| cluster.image.tag | string | `"0.6.0"` | |
| cluster.liaison.affinity | object | `{}` | |
| cluster.liaison.env | list | `[]` | |
| cluster.liaison.grpcSvc.annotations | object | `{}` | |
@@ -131,8 +131,8 @@ The command removes all the banyandb components associated
with the chart and de
| standalone.httpSvc.port | int | `17913` | |
| standalone.httpSvc.type | string | `"LoadBalancer"` | |
| standalone.image.pullPolicy | string | `"IfNotPresent"` | |
-| standalone.image.repository | string |
`"ghcr.io/apache/skywalking-banyandb"` | |
-| standalone.image.tag | string | `"dc88130e8d0516c7989734bdeb505e2d92c1ab71"`
| |
+| standalone.image.repository | string |
`"docker.io/apache/skywalking-banyandb"` | |
+| standalone.image.tag | string | `"0.6.0"` | |
| standalone.ingress.annotations | object | `{}` | |
| standalone.ingress.enabled | bool | `false` | |
| standalone.ingress.labels | object | `{}` | |
[PR] Update configuration in the document [skywalking-banyandb-helm]
ButterBright opened a new pull request, #16: URL: https://github.com/apache/skywalking-banyandb-helm/pull/16 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-helm) branch release-0.2.0 deleted (was a8aabbc)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch release-0.2.0 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git was a8aabbc Fix failed release command The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(skywalking-banyandb-helm) branch master updated: Fix failed release command (#15)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git The following commit(s) were added to refs/heads/master by this push: new bd45247 Fix failed release command (#15) bd45247 is described below commit bd45247d80a67e2245f94ba58cf7acbff62e Author: Gao Hongtao AuthorDate: Mon May 13 14:40:36 2024 +0800 Fix failed release command (#15) Signed-off-by: Gao Hongtao --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 9b3cbd2..ae812ce 100644 --- a/Makefile +++ b/Makefile @@ -52,6 +52,7 @@ release-src: --exclude .gitignore \ --exclude .DS_Store \ --exclude .github \ + --exclude build \ . mv build/$(RELEASE_SRC).tgz . && rm -rf build
Re: [PR] Fix failed release command [skywalking-banyandb-helm]
hanahmily merged PR #15: URL: https://github.com/apache/skywalking-banyandb-helm/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix failed release command [skywalking-banyandb-helm]
hanahmily opened a new pull request, #15: URL: https://github.com/apache/skywalking-banyandb-helm/pull/15 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-helm) 01/01: Fix failed release command
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch release-0.2.0 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git commit a8aabbc22a835c2895f65577e9e67ca1dbf790f2 Author: Gao Hongtao AuthorDate: Mon May 13 06:36:23 2024 + Fix failed release command Signed-off-by: Gao Hongtao --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 9b3cbd2..ae812ce 100644 --- a/Makefile +++ b/Makefile @@ -52,6 +52,7 @@ release-src: --exclude .gitignore \ --exclude .DS_Store \ --exclude .github \ + --exclude build \ . mv build/$(RELEASE_SRC).tgz . && rm -rf build
(skywalking-banyandb-helm) branch release-0.2.0 updated (0c9b601 -> a8aabbc)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch release-0.2.0 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git omit 0c9b601 Prepare release 0.2.0 add 39048fc Prepare release 0.2.0 (#14) new a8aabbc Fix failed release command This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (0c9b601) \ N -- N -- N refs/heads/release-0.2.0 (a8aabbc) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: Makefile | 1 + 1 file changed, 1 insertion(+)
(skywalking-banyandb-helm) annotated tag v0.2.0 updated (39048fc -> 2ebb393)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to annotated tag v0.2.0 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git *** WARNING: tag v0.2.0 was modified! *** from 39048fc (commit) to 2ebb393 (tag) tagging 39048fc63e3028c89ad1216976cf46e7bd544fc3 (commit) replaces v0.1.0 by Gao Hongtao on Mon May 13 06:29:44 2024 + - Log - Release Apache SkyWalking BanyanDB Helm 0.2.0 --- No new revisions were added by this update. Summary of changes:
Re: [PR] Use Docker Hub as image source to replace ghcr [skywalking-banyandb-helm]
hanahmily closed pull request #13: Use Docker Hub as image source to replace ghcr URL: https://github.com/apache/skywalking-banyandb-helm/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-helm) branch master updated: Prepare release 0.2.0 (#14)
This is an automated email from the ASF dual-hosted git repository.
butterbright pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
The following commit(s) were added to refs/heads/master by this push:
new 39048fc Prepare release 0.2.0 (#14)
39048fc is described below
commit 39048fc63e3028c89ad1216976cf46e7bd544fc3
Author: Gao Hongtao
AuthorDate: Mon May 13 14:27:56 2024 +0800
Prepare release 0.2.0 (#14)
Signed-off-by: Gao Hongtao
---
.github/workflows/e2e.ci.yaml | 4 ++--
CHANGES.md | 5 +
chart/Chart.yaml| 2 +-
chart/values.yaml | 4 ++--
test/e2e/env| 16
test/e2e/values.cluster.yaml| 4 ++--
test/e2e/values.standalone.yaml | 4 ++--
7 files changed, 22 insertions(+), 17 deletions(-)
diff --git a/.github/workflows/e2e.ci.yaml b/.github/workflows/e2e.ci.yaml
index dd1def5..e20330c 100644
--- a/.github/workflows/e2e.ci.yaml
+++ b/.github/workflows/e2e.ci.yaml
@@ -41,9 +41,9 @@ jobs:
config: test/e2e/e2e-banyandb-cluster.yaml
name: ${{ matrix.test.name }}
env:
- OAP_TAG: 965dea898986ed2ab1343559fb20d6faed11ada9
+ OAP_TAG: 14c5778f57cc163b5a7d732555182b14dcff146b
OAP_REPO: ghcr.io/apache/skywalking/oap
- UI_TAG: 965dea898986ed2ab1343559fb20d6faed11ada9
+ UI_TAG: 14c5778f57cc163b5a7d732555182b14dcff146b
UI_REPO: ghcr.io/apache/skywalking/ui
SATELLITE_TAG: v35bfaff6352b4dc351a706772796a1f79b651c14
SATELLITE_REPO: ghcr.io/apache/skywalking-satellite/skywalking-satellite
diff --git a/CHANGES.md b/CHANGES.md
index 9c011d1..818382a 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -14,6 +14,11 @@ Release Notes.
- Update relevant documents
+ Chores
+
+- Bump banyandb image version to 0.6.0
+- Bump several dependencies in e2e test
+
0.1.0
--
diff --git a/chart/Chart.yaml b/chart/Chart.yaml
index 500860b..664e615 100644
--- a/chart/Chart.yaml
+++ b/chart/Chart.yaml
@@ -16,7 +16,7 @@
apiVersion: v2
name: skywalking-banyandb-helm
home: https://skywalking.apache.org
-version: 0.1.0
+version: 0.2.0
description: Helm Chart for Apache SkyWalking BanyanDB
icon:
https://raw.githubusercontent.com/apache/skywalking-kubernetes/master/logo/sw-logo-for-chart.jpg
sources:
diff --git a/chart/values.yaml b/chart/values.yaml
index 0d7a16e..23b9e01 100644
--- a/chart/values.yaml
+++ b/chart/values.yaml
@@ -27,8 +27,8 @@ standalone:
# runAsGroup: 1000
# fsGroup: 1000
image:
-repository: ghcr.io/apache/skywalking-banyandb
-tag: dc88130e8d0516c7989734bdeb505e2d92c1ab71
+repository: docker.io/apache/skywalking-banyandb
+tag: 0.6.0
pullPolicy: IfNotPresent
env: []
# - name: BANYANDB_FOO
diff --git a/test/e2e/env b/test/e2e/env
index 7e1f100..df056db 100644
--- a/test/e2e/env
+++ b/test/e2e/env
@@ -13,15 +13,15 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-SW_AGENT_JAVA_COMMIT=fbdfc42b4d825ba33205d646ddd20c005cb8
-SW_AGENT_SATELLITE_COMMIT=1f3c08a5af19f8522f2a40d9339c45fa816bfe07
+SW_AGENT_JAVA_COMMIT=c82287e1dd1593cf3e7dbc390b92f9224943252a
+SW_AGENT_SATELLITE_COMMIT=ea27a3f4e126a24775fe12e2aa2695bcb23d99c3
SW_AGENT_NGINX_LUA_COMMIT=c3cee4841798a147d83b96a10914d4ac0e11d0aa
-SW_AGENT_NODEJS_COMMIT=e755659c7f308d3b5589619778c8360308cb14f8
-SW_AGENT_GO_COMMIT=4af380c2db6243106b0fc650b6003ce3b3eb82a0
-SW_AGENT_PYTHON_COMMIT=50388c55428d742d73d9733278f04173585de80d
+SW_AGENT_NODEJS_COMMIT=4f9a91dad3dfd8cfe5ba8f7bd06b39e11eb5e65e
+SW_AGENT_GO_COMMIT=774a6d56baba1187eb03bf1861af542c923b3dff
+SW_AGENT_PYTHON_COMMIT=c76a6ec51a478ac91abb20ec8f22a99b8d4d6a58
SW_AGENT_CLIENT_JS_COMMIT=af0565a67d382b683c1dbd94c379b7080db61449
SW_AGENT_CLIENT_JS_TEST_COMMIT=4f1eb1dcdbde3ec4a38534bf01dded4ab5d2f016
-SW_KUBERNETES_COMMIT_SHA=0f3ec68e5a7e1608cec8688716b848ed15e971e5
+SW_KUBERNETES_COMMIT_SHA=3eb9fc8235fd3a773650d1f08adfccfd5d0745fc
-SW_CTL_COMMIT=9d2d0edccda2afe5cf24f1e632142f40e80e8fa4
-SW_HELM_VERSION=0.0.0-e651c381abe661e5a38ab1607758aae893b3dbeb
+SW_CTL_COMMIT=d5f3597733aa5217373986d776a3ee5ee8b3c468
+SW_HELM_VERSION=0.0.0-1741f5a0959b85faaf0a2fc6bbd7b550ec330280
diff --git a/test/e2e/values.cluster.yaml b/test/e2e/values.cluster.yaml
index e08a4de..cc3a00b 100644
--- a/test/e2e/values.cluster.yaml
+++ b/test/e2e/values.cluster.yaml
@@ -20,8 +20,8 @@
cluster:
enabled: true
image:
-repository: ghcr.io/apache/skywalking-banyandb
-tag: dc88130e8d0516c7989734bdeb505e2d92c1ab71
+repository: docker.io/apache/skywalking-banyandb
+tag: 0.6.0
pullPolicy: IfNotPresent
etcdEndpoints: []
liaison:
diff --git a/test/e2e/values.standalone.yaml b/test/e2e/values.standalone.yaml
index 61b981f..e757c65 100644
--- a/test/e2e/values.standalone.yaml
+++ b/test/e2e/values.standalone.yaml
@@ -33,8 +33,8 @@ standalone:
#
Re: [PR] Prepare release 0.2.0 [skywalking-banyandb-helm]
ButterBright merged PR #14: URL: https://github.com/apache/skywalking-banyandb-helm/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Prepare release 0.2.0 [skywalking-banyandb-helm]
hanahmily opened a new pull request, #14: URL: https://github.com/apache/skywalking-banyandb-helm/pull/14 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb-helm) 01/01: Prepare release 0.2.0
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch release-0.2.0
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
commit 0c9b601c3633358e7c624ddce29c09ef85ac22c1
Author: Gao Hongtao
AuthorDate: Mon May 13 06:07:40 2024 +
Prepare release 0.2.0
Signed-off-by: Gao Hongtao
---
.github/workflows/e2e.ci.yaml | 4 ++--
CHANGES.md | 5 +
chart/Chart.yaml| 2 +-
chart/values.yaml | 4 ++--
test/e2e/env| 16
test/e2e/values.cluster.yaml| 4 ++--
test/e2e/values.standalone.yaml | 4 ++--
7 files changed, 22 insertions(+), 17 deletions(-)
diff --git a/.github/workflows/e2e.ci.yaml b/.github/workflows/e2e.ci.yaml
index dd1def5..e20330c 100644
--- a/.github/workflows/e2e.ci.yaml
+++ b/.github/workflows/e2e.ci.yaml
@@ -41,9 +41,9 @@ jobs:
config: test/e2e/e2e-banyandb-cluster.yaml
name: ${{ matrix.test.name }}
env:
- OAP_TAG: 965dea898986ed2ab1343559fb20d6faed11ada9
+ OAP_TAG: 14c5778f57cc163b5a7d732555182b14dcff146b
OAP_REPO: ghcr.io/apache/skywalking/oap
- UI_TAG: 965dea898986ed2ab1343559fb20d6faed11ada9
+ UI_TAG: 14c5778f57cc163b5a7d732555182b14dcff146b
UI_REPO: ghcr.io/apache/skywalking/ui
SATELLITE_TAG: v35bfaff6352b4dc351a706772796a1f79b651c14
SATELLITE_REPO: ghcr.io/apache/skywalking-satellite/skywalking-satellite
diff --git a/CHANGES.md b/CHANGES.md
index 9c011d1..818382a 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -14,6 +14,11 @@ Release Notes.
- Update relevant documents
+ Chores
+
+- Bump banyandb image version to 0.6.0
+- Bump several dependencies in e2e test
+
0.1.0
--
diff --git a/chart/Chart.yaml b/chart/Chart.yaml
index 500860b..664e615 100644
--- a/chart/Chart.yaml
+++ b/chart/Chart.yaml
@@ -16,7 +16,7 @@
apiVersion: v2
name: skywalking-banyandb-helm
home: https://skywalking.apache.org
-version: 0.1.0
+version: 0.2.0
description: Helm Chart for Apache SkyWalking BanyanDB
icon:
https://raw.githubusercontent.com/apache/skywalking-kubernetes/master/logo/sw-logo-for-chart.jpg
sources:
diff --git a/chart/values.yaml b/chart/values.yaml
index 0d7a16e..23b9e01 100644
--- a/chart/values.yaml
+++ b/chart/values.yaml
@@ -27,8 +27,8 @@ standalone:
# runAsGroup: 1000
# fsGroup: 1000
image:
-repository: ghcr.io/apache/skywalking-banyandb
-tag: dc88130e8d0516c7989734bdeb505e2d92c1ab71
+repository: docker.io/apache/skywalking-banyandb
+tag: 0.6.0
pullPolicy: IfNotPresent
env: []
# - name: BANYANDB_FOO
diff --git a/test/e2e/env b/test/e2e/env
index 7e1f100..df056db 100644
--- a/test/e2e/env
+++ b/test/e2e/env
@@ -13,15 +13,15 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-SW_AGENT_JAVA_COMMIT=fbdfc42b4d825ba33205d646ddd20c005cb8
-SW_AGENT_SATELLITE_COMMIT=1f3c08a5af19f8522f2a40d9339c45fa816bfe07
+SW_AGENT_JAVA_COMMIT=c82287e1dd1593cf3e7dbc390b92f9224943252a
+SW_AGENT_SATELLITE_COMMIT=ea27a3f4e126a24775fe12e2aa2695bcb23d99c3
SW_AGENT_NGINX_LUA_COMMIT=c3cee4841798a147d83b96a10914d4ac0e11d0aa
-SW_AGENT_NODEJS_COMMIT=e755659c7f308d3b5589619778c8360308cb14f8
-SW_AGENT_GO_COMMIT=4af380c2db6243106b0fc650b6003ce3b3eb82a0
-SW_AGENT_PYTHON_COMMIT=50388c55428d742d73d9733278f04173585de80d
+SW_AGENT_NODEJS_COMMIT=4f9a91dad3dfd8cfe5ba8f7bd06b39e11eb5e65e
+SW_AGENT_GO_COMMIT=774a6d56baba1187eb03bf1861af542c923b3dff
+SW_AGENT_PYTHON_COMMIT=c76a6ec51a478ac91abb20ec8f22a99b8d4d6a58
SW_AGENT_CLIENT_JS_COMMIT=af0565a67d382b683c1dbd94c379b7080db61449
SW_AGENT_CLIENT_JS_TEST_COMMIT=4f1eb1dcdbde3ec4a38534bf01dded4ab5d2f016
-SW_KUBERNETES_COMMIT_SHA=0f3ec68e5a7e1608cec8688716b848ed15e971e5
+SW_KUBERNETES_COMMIT_SHA=3eb9fc8235fd3a773650d1f08adfccfd5d0745fc
-SW_CTL_COMMIT=9d2d0edccda2afe5cf24f1e632142f40e80e8fa4
-SW_HELM_VERSION=0.0.0-e651c381abe661e5a38ab1607758aae893b3dbeb
+SW_CTL_COMMIT=d5f3597733aa5217373986d776a3ee5ee8b3c468
+SW_HELM_VERSION=0.0.0-1741f5a0959b85faaf0a2fc6bbd7b550ec330280
diff --git a/test/e2e/values.cluster.yaml b/test/e2e/values.cluster.yaml
index e08a4de..cc3a00b 100644
--- a/test/e2e/values.cluster.yaml
+++ b/test/e2e/values.cluster.yaml
@@ -20,8 +20,8 @@
cluster:
enabled: true
image:
-repository: ghcr.io/apache/skywalking-banyandb
-tag: dc88130e8d0516c7989734bdeb505e2d92c1ab71
+repository: docker.io/apache/skywalking-banyandb
+tag: 0.6.0
pullPolicy: IfNotPresent
etcdEndpoints: []
liaison:
diff --git a/test/e2e/values.standalone.yaml b/test/e2e/values.standalone.yaml
index 61b981f..e757c65 100644
--- a/test/e2e/values.standalone.yaml
+++ b/test/e2e/values.standalone.yaml
@@ -33,8 +33,8 @@ standalone:
# runAsGroup: 1000
# fsGroup: 1000
image:
-repository: ghcr.io/apache/skywalking-banyandb
-tag: dc88130e8d0516c7989734bdeb505e2d92c1ab71
+
(skywalking-banyandb-helm) branch release-0.2.0 created (now 0c9b601)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch release-0.2.0 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git at 0c9b601 Prepare release 0.2.0 This branch includes the following new commits: new 0c9b601 Prepare release 0.2.0 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
