Re: [I] skywalking-oap Startup run error [skywalking]
wu-sheng closed issue #12229: skywalking-oap Startup run error URL: https://github.com/apache/skywalking/issues/12229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] skywalking-oap Startup run error [skywalking]
qianghong000 opened a new issue, #12229:
URL: https://github.com/apache/skywalking/issues/12229
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
OAP server (apache/skywalking)
### What happened
2024-05-15 12:09:33,125
org.apache.skywalking.library.elasticsearch.ElasticSearchBuilder 95
[armeria-eventloop-epoll-8-1] WARN [] -
[creqId=f7b95117][http://es-quickstart-es-http:9200/_cluster/health#GET]
Request: {startTime=2024-05-15T12:09:32.952Z(1715774972952729), length=0B,
duration=171ms(171712070ns),
cause=com.linecorp.armeria.client.UnprocessedRequestException:
com.linecorp.armeria.common.ClosedSessionException, scheme=none+http,
name=health-check, headers=[:method=GET, :authority=es-quickstart-es-http:9200,
:path=/_cluster/health]}
2024-05-15 12:09:33,125
org.apache.skywalking.library.elasticsearch.ElasticSearchBuilder 156
[armeria-eventloop-epoll-8-1] WARN [] -
[creqId=f7b95117][http://es-quickstart-es-http:9200/_cluster/health#GET]
Response: {startTime=2024-05-15T12:09:33.122Z(1715774973122696), length=0B,
duration=0ns, totalDuration=172ms(172065868ns),
cause=com.linecorp.armeria.client.UnprocessedRequestException:
com.linecorp.armeria.common.ClosedSessionException, headers=[:status=0]}
com.linecorp.armeria.client.UnprocessedRequestException:
com.linecorp.armeria.common.ClosedSessionException
at
com.linecorp.armeria.client.UnprocessedRequestException.of(UnprocessedRequestException.java:45)
~[armeria-1.25.0.jar:?]
at
com.linecorp.armeria.client.HttpChannelPool.notifyConnect(HttpChannelPool.java:599)
~[armeria-1.25.0.jar:?]
at
com.linecorp.armeria.client.HttpChannelPool.lambda$connect$1(HttpChannelPool.java:422)
~[armeria-1.25.0.jar:?]
at
io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:590)
[netty-common-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:557)
[netty-common-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:492)
[netty-common-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.util.concurrent.DefaultPromise.setValue0(DefaultPromise.java:636)
[netty-common-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.util.concurrent.DefaultPromise.setFailure0(DefaultPromise.java:629)
[netty-common-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.util.concurrent.DefaultPromise.tryFailure(DefaultPromise.java:118)
[netty-common-4.1.100.Final.jar:4.1.100.Final]
at
com.linecorp.armeria.client.HttpSessionHandler.channelInactive(HttpSessionHandler.java:476)
[armeria-1.25.0.jar:?]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:303)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:281)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:274)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:81)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.handler.codec.MessageAggregator.channelInactive(MessageAggregator.java:441)
[netty-codec-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:305)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:281)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:274)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelInactive(CombinedChannelDuplexHandler.java:418)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:411)
[netty-codec-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:376)
[netty-codec-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.handler.codec.http.HttpClientCodec$Decoder.channelInactive(HttpClientCodec.java:328)
[netty-codec-http-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.CombinedChannelDuplexHandler.channelInactive(CombinedChannelDuplexHandler.java:221)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
Re: [I] [Feature] Support Cillium observability (maybe) through Hubble APIs [skywalking]
wu-sheng commented on issue #11697: URL: https://github.com/apache/skywalking/issues/11697#issuecomment-2112432096 Within PoC, we found https://github.com/cilium/cilium/issues/32175. Need more time on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] skywalking-oap 无法启动 [skywalking]
wu-sheng closed issue #12228: skywalking-oap 无法启动 URL: https://github.com/apache/skywalking/issues/12228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] skywalking-oap 无法启动 [skywalking]
wu-sheng commented on issue #12228: URL: https://github.com/apache/skywalking/issues/12228#issuecomment-2112424385 No Chinese on GitHub. Use the slack CN channel or use English here. You are posting a QA, move to the discussion in English. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] skywalking-oap 无法启动 [skywalking]
qianghong000 opened a new issue, #12228:
URL: https://github.com/apache/skywalking/issues/12228
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
OAP server (apache/skywalking)
### What happened
2024-05-15 12:09:33,125
org.apache.skywalking.library.elasticsearch.ElasticSearchBuilder 95
[armeria-eventloop-epoll-8-1] WARN [] -
[creqId=f7b95117][http://es-quickstart-es-http:9200/_cluster/health#GET]
Request: {startTime=2024-05-15T12:09:32.952Z(1715774972952729), length=0B,
duration=171ms(171712070ns),
cause=com.linecorp.armeria.client.UnprocessedRequestException:
com.linecorp.armeria.common.ClosedSessionException, scheme=none+http,
name=health-check, headers=[:method=GET, :authority=es-quickstart-es-http:9200,
:path=/_cluster/health]}
2024-05-15 12:09:33,125
org.apache.skywalking.library.elasticsearch.ElasticSearchBuilder 156
[armeria-eventloop-epoll-8-1] WARN [] -
[creqId=f7b95117][http://es-quickstart-es-http:9200/_cluster/health#GET]
Response: {startTime=2024-05-15T12:09:33.122Z(1715774973122696), length=0B,
duration=0ns, totalDuration=172ms(172065868ns),
cause=com.linecorp.armeria.client.UnprocessedRequestException:
com.linecorp.armeria.common.ClosedSessionException, headers=[:status=0]}
com.linecorp.armeria.client.UnprocessedRequestException:
com.linecorp.armeria.common.ClosedSessionException
at
com.linecorp.armeria.client.UnprocessedRequestException.of(UnprocessedRequestException.java:45)
~[armeria-1.25.0.jar:?]
at
com.linecorp.armeria.client.HttpChannelPool.notifyConnect(HttpChannelPool.java:599)
~[armeria-1.25.0.jar:?]
at
com.linecorp.armeria.client.HttpChannelPool.lambda$connect$1(HttpChannelPool.java:422)
~[armeria-1.25.0.jar:?]
at
io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:590)
[netty-common-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:557)
[netty-common-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:492)
[netty-common-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.util.concurrent.DefaultPromise.setValue0(DefaultPromise.java:636)
[netty-common-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.util.concurrent.DefaultPromise.setFailure0(DefaultPromise.java:629)
[netty-common-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.util.concurrent.DefaultPromise.tryFailure(DefaultPromise.java:118)
[netty-common-4.1.100.Final.jar:4.1.100.Final]
at
com.linecorp.armeria.client.HttpSessionHandler.channelInactive(HttpSessionHandler.java:476)
[armeria-1.25.0.jar:?]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:303)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:281)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:274)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:81)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.handler.codec.MessageAggregator.channelInactive(MessageAggregator.java:441)
[netty-codec-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:305)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:281)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:274)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelInactive(CombinedChannelDuplexHandler.java:418)
[netty-transport-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:411)
[netty-codec-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:376)
[netty-codec-4.1.100.Final.jar:4.1.100.Final]
at
io.netty.handler.codec.http.HttpClientCodec$Decoder.channelInactive(HttpClientCodec.java:328)
[netty-codec-http-4.1.100.Final.jar:4.1.100.Final]
at
Re: [I] [Bug] skywalking did not work with elasitcsearch 8.13+ [skywalking]
wu-sheng closed issue #12224: [Bug] skywalking did not work with elasitcsearch 8.13+ URL: https://github.com/apache/skywalking/issues/12224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adapt ElasticSearch 8.13.x [skywalking]
wu-sheng closed pull request #12227: Adapt ElasticSearch 8.13.x URL: https://github.com/apache/skywalking/pull/12227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adapt ElasticSearch 8.13.x [skywalking]
wu-sheng commented on PR #12227: URL: https://github.com/apache/skywalking/pull/12227#issuecomment-2112134387 OK, as we verified, we could close this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking did not work with elasitcsearch 8.13+ [skywalking]
kezhenxu94 commented on issue #12224: URL: https://github.com/apache/skywalking/issues/12224#issuecomment-2112088716 @ldcsaa can you share how OAP failed? Looks like all tests passed in https://github.com/apache/skywalking/pull/12227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve filtering performance of Stream [skywalking-banyandb]
hanahmily commented on PR #440: URL: https://github.com/apache/skywalking-banyandb/pull/440#issuecomment-2111929674 > @ButterBright @hanahmily Let's think how we could build tests to verify this? @hanahmily Is your local benchmark suitable for this case? Existing stress tests could also verify it, but we need to use a lightweight benchmark suite to do this job. I have discussed with @ButterBright to add some benchmarks to the package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adapt ElasticSearch 8.13.x [skywalking]
wu-sheng commented on code in PR #12227: URL: https://github.com/apache/skywalking/pull/12227#discussion_r1601210256 ## .github/workflows/skywalking.yaml: ## @@ -377,6 +377,9 @@ jobs: - name: Storage ES 8.9.0 config: test/e2e-v2/cases/storage/es/e2e.yaml env: ES_VERSION=8.9.0 + - name: Storage ES 8.9.0 Review Comment: Note, this is unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Adapt ElasticSearch 8.13.x [skywalking]
kezhenxu94 opened a new pull request, #12227: URL: https://github.com/apache/skywalking/pull/12227 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1601141856
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredTracerContext implements
AbstractTracerContext {
private static final NoopSpan NOOP_SPAN = new NoopSpan();
private static final String IGNORE_TRACE = "Ignored_Trace";
+private LinkedList activeSpanStack;
Review Comment:
That was why I said, this could be done easily if this only happens in your
private fork. But in general, I don't have a good idea could be done easily.
But this has to be very good, as your changes are going to affect every user
for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1601138854
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredTracerContext implements
AbstractTracerContext {
private static final NoopSpan NOOP_SPAN = new NoopSpan();
private static final String IGNORE_TRACE = "Ignored_Trace";
+private LinkedList activeSpanStack;
Review Comment:
I didn't dig in so deeply, as I am feeling this change is not easy.
I just provided two possibilities, no preference. One key part is, what you
are adding is not happening as always, you should not make the agent kernel
costs too much.
I don't know whether this is possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1601138854
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredTracerContext implements
AbstractTracerContext {
private static final NoopSpan NOOP_SPAN = new NoopSpan();
private static final String IGNORE_TRACE = "Ignored_Trace";
+private LinkedList activeSpanStack;
Review Comment:
I didn't dig in so deeply, as I am feeling this change is not easy.
I just provided two possibilities, no preference. One key part is, what you
are adding is not happening as always, you should not make the agent kernel
costs too much.
I don't whether this is possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(skywalking-website) branch master updated: fix some skywalking-10-release typos
This is an automated email from the ASF dual-hosted git repository.
wankai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/master by this push:
new 3b673c1c795 fix some skywalking-10-release typos
3b673c1c795 is described below
commit 3b673c1c795d446f9a11ea600171c035da64d168
Author: Wan Kai
AuthorDate: Wed May 15 15:46:28 2024 +0800
fix some skywalking-10-release typos
---
content/blog/2024-05-13-skywalking-10-release/index.md | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/content/blog/2024-05-13-skywalking-10-release/index.md
b/content/blog/2024-05-13-skywalking-10-release/index.md
index 2a62377a55d..b03ca20f84d 100644
--- a/content/blog/2024-05-13-skywalking-10-release/index.md
+++ b/content/blog/2024-05-13-skywalking-10-release/index.md
@@ -18,7 +18,7 @@ BanyanDB emerges as a high-performance native storage
solution, while expanded m
and Apache ActiveMQ Classic. Support for Multiple Labels Names enhances
flexibility in metrics analysis,
while enhanced exporting and querying capabilities streamline data
dissemination and processing.
-This release blog briefly introduces these new features and Enhancements as
well as some other notable changes.
+This release blog briefly introduces these new features and enhancements as
well as some other notable changes.
## Layer and Service Hierarchy
`Layer` concept was introduced in SkyWalking 9.0.0, it represents an abstract
framework in computer science,
@@ -42,12 +42,12 @@ SkyWalking 10 introduces a new concept called `Service
Hierarchy`, which defines
OAP will detect the services from different layers, and try to build the
connections.
Users can click the `Hierarchy Services` in any layer's service topology node
or service dashboard to get the `Hierarchy Topology`.
In this topology graph, users can see the relationships between the services
in different layers and the summary of the metrics and also can jump to the
service dashboard in the layer.
-When a service occurrs performance issue, users can easily analyze the metrics
from different layers and track down the root cause:
+When a service occurs performance issue, users can easily analyze the metrics
from different layers and track down the root cause:
The examples of the `Service Hierarchy` relationships:
1. The application `song` deployed in the Kubernetes cluster with SkyWalking
agent and Service Mesh at the same time.
-So the application `song` across the `GENERAL`, `MESH`, `MESH_DP` and
`K8S_SERVICE` layers which could be monitoring by SkyWalking,
+So the application `song` across the `GENERAL`, `MESH`, `MESH_DP` and
`K8S_SERVICE` layers which could be monitored by SkyWalking,
the `Service Hierarchy` topology as below:
Figure 3: Service Hierarchy Agent With K8s Service And Mesh With K8s
Service.
@@ -57,7 +57,7 @@ And can also have the `Service Instance Hierarchy` topology
to get the single in
Figure 4: Instance Hierarchy Agent With K8s Service(Pod)
2. The PostgreSQL database `psql` deployed in the Kubernetes cluster and used
by the application `song`.
-So the database `psql` across the `VIRTUAL_DATABASE`, `POSTGRESQL` and
`K8S_SERVICE` layers which could be monitoring by SkyWalking,
+So the database `psql` across the `VIRTUAL_DATABASE`, `POSTGRESQL` and
`K8S_SERVICE` layers which could be monitored by SkyWalking,
the `Service Hierarchy` topology as below:
Figure 5: Service Hierarchy Agent(Virtual Database) With Real Database And K8s
Service
@@ -143,7 +143,7 @@ it can't query the metrics data with multiple labels names.
SkyWalking 10 supports storing the labels names in the metrics data, and MQE
can query or calculate the metrics data with multiple labels names.
For example:
The `k8s_cluster_deployment_status` metric has labels `namespace`,
`deployment` and `status`.
-If we want to query all deployment metric value with
`namespace=skywalking-showcase` and `status=true`, we can use the following
expression:
+If we want to query all deployment metric values with
`namespace=skywalking-showcase` and `status=true`, we can use the following
expression:
```text
k8s_cluster_deployment_status{namespace='skywalking-showcase', status='true'}
```
@@ -154,7 +154,7 @@ related enhancement:
## Metrics gRPC exporter
SkyWalking 10 enhanced the [metrics gPRC
exporter](https://skywalking.apache.org/docs/main/latest/en/setup/backend/exporter/#grpc-exporter),
-it supports exporting all type metrics data to the gRPC server.
+it supports exporting all types of metrics data to the gRPC server.
## SkyWalking Native UI Metrics Query Switch to V3 APIs
SkyWalking Native UI metrics query deprecate the V2 APIs, and
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
gzlicanyi commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1601125642
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredTracerContext implements
AbstractTracerContext {
private static final NoopSpan NOOP_SPAN = new NoopSpan();
private static final String IGNORE_TRACE = "Ignored_Trace";
+private LinkedList activeSpanStack;
Review Comment:
Do you prefer replacing the span's context with IgnoredTracerContext for old
spans with old [context
references](https://github.com/apache/skywalking-java/blob/4dfc1e85b56e75a1bf2bae11d34d8c0fe234bed0/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/AbstractTracingSpan.java#L68),
or would you rather ignore any operations involving context within the span?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Improve filtering performance of Stream [skywalking-banyandb]
wu-sheng commented on PR #440: URL: https://github.com/apache/skywalking-banyandb/pull/440#issuecomment-2111780785 @ButterBright @hanahmily Let's think how we could build tests to verify this? @hanahmily Is your local benchmark suitable for this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]
wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1601087830
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredTracerContext implements
AbstractTracerContext {
private static final NoopSpan NOOP_SPAN = new NoopSpan();
private static final String IGNORE_TRACE = "Ignored_Trace";
+private LinkedList activeSpanStack;
Review Comment:
Another option maybe to create a ForceIgnoreTracerContext to deal with
created span cases.
And this only happens in very rare case, so we should process that only when
we checked all active spans, which have one running in async mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
