[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-553228717 yes, unit test is very useful. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-552196922 Ok, this part is to be remembered, just update it after the test is finished, just right. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-552096040 > When you update this PR as another plugin test has been added. Probably tomorrow, there is an exam today. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-551419131 Ok, next will add comments and test the interceptors via mock. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-551347238 Ok, no problem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-551343104 > supported-list doc should be updated. Regarding the supported version, the version before 6.7.0, some places are different, not compatible This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-551144322 /run agent-plugin-test-4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-551046766 When the external is exit span, the local span problem created and it has been fixed in the second commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-550993223 Found that httpasyncclient has nothing to do with es6.x plugin, the test samples can pass normally, the only problem is that there may be problems in httpasyncclient. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
