subject:"\[GitHub\] \[skywalking\] codecov\[bot\] edited a comment on pull request #4967\: Add Nacos back into SkyWalking as an option\(nacos\-1.3.0\)"

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 166  -619 
 Lines 196754018-15657 
 Branches   1930 470 -1460 
   
   - Hits  10413   0-10413 
   + Misses 84024018 -4384 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 166  -619 
 Lines 196754018-15657 
 Branches   1930 470 -1460 
   
   - Hits  10413   0-10413 
   + Misses 84024018 -4384 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 166  -619 
 Lines 196754018-15657 
 Branches   1930 470 -1460 
   
   - Hits  10413   0-10413 
   + Misses 84024018 -4384 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 166  -619 
 Lines 196754018-15657 
 Branches   1930 470 -1460 
   
   - Hits  10413   0-10413 
   + Misses 84024018 -4384 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 166  -619 
 Lines 196754018-15657 
 Branches   1930 470 -1460 
   
   - Hits  10413   0-10413 
   + Misses 84024018 -4384 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 166  -619 
 Lines 196754018-15657 
 Branches   1930 470 -1460 
   
   - Hits  10413   0-10413 
   + Misses 84024018 -4384 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 166  -619 
 Lines 196754018-15657 
 Branches   1930 470 -1460 
   
   - Hits  10413   0-10413 
   + Misses 84024018 -4384 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 166  -619 
 Lines 196754018-15657 
 Branches   1930 470 -1460 
   
   - Hits  10413   0-10413 
   + Misses 84024018 -4384 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 166  -619 
 Lines 196754018-15657 
 Branches   1930 470 -1460 
   
   - Hits  10413   0-10413 
   + Misses 84024018 -4384 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 166  -619 
 Lines 196754018-15657 
 Branches   1930 470 -1460 
   
   - Hits  10413   0-10413 
   + Misses 84024018 -4384 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 165  -620 
 Lines 196754014-15661 
 Branches   1930 470 -1460 
   
   - Hits  10413   0-10413 
   + Misses 84024014 -4388 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [683 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 164  -621 
 Lines 196753975-15700 
 Branches   1930 469 -1461 
   
   - Hits  10413   0-10413 
   + Misses 84023975 -4427 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 164  -621 
 Lines 196753975-15700 
 Branches   1930 469 -1461 
   
   - Hits  10413   0-10413 
   + Misses 84023975 -4427 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 162  -623 
 Lines 196753964-15711 
 Branches   1930 469 -1461 
   
   - Hits  10413   0-10413 
   + Misses 84023964 -4438 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [686 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **decrease** coverage by `52.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.92%   0.00%   -52.93% 
   
 Files   785 157  -628 
 Lines 196753911-15764 
 Branches   1930 465 -1465 
   
   - Hits  10413   0-10413 
   + Misses 84023911 -4491 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [691 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/e0325a44070cf94c73624a2c4c81819bc14ee09d=desc)
 will **increase** coverage by `0.35%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   + Coverage 52.92%   53.27%   +0.35% 
   + Complexity 2996 2945  -51 
   
 Files   785  769  -16 
 Lines 1967519307 -368 
 Branches   1930 1907  -23 
   
   - Hits  1041310286 -127 
   + Misses 8402 8165 -237 
   + Partials860  856   -4 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [78

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-20 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **increase** coverage by `0.34%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   + Coverage 52.92%   53.27%   +0.34% 
   + Complexity 2981 2945  -36 
   
 Files   779  769  -10 
 Lines 1952519307 -218 
 Branches   1924 1907  -17 
   
   - Hits  1033410286  -48 
   + Misses 8333 8165 -168 
   + Partials858  856   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [66

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **increase** coverage by `0.34%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   + Coverage 52.92%   53.27%   +0.34% 
   + Complexity 2981 2945  -36 
   
 Files   779  769  -10 
 Lines 1952519307 -218 
 Branches   1924 1907  -17 
   
   - Hits  1033410286  -48 
   + Misses 8333 8165 -168 
   + Partials858  856   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [66

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **increase** coverage by `0.64%`.
   > The diff coverage is `72.89%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   + Coverage 52.92%   53.57%   +0.64% 
   + Complexity 2981 2946  -35 
   
 Files   779 1401 +622 
 Lines 1952530351   +10826 
 Branches   1924 3386+1462 
   
   + Hits  1033416260+5926 
   - Misses 833313302+4969 
   + Partials858  789  -69 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `68.05% <ø> (+4.41%)` | `3.00 <0.00> (ø)` | |
   | 
[...lugin/mongodb/v3/support/MongoOperationHelper.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbW9uZ29kYi0zLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbW9uZ29kYi92My9zdXBwb3J0L01vbmdvT3BlcmF0aW9uSGVscGVyLmphdmE=)
 | `7.04% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...lking/apm/plugin/vertx3/RouteStateInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vdmVydHgtcGx1Z2lucy92ZXJ0eC1jb3JlLTMueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi92ZXJ0eDMvUm91dGVTdGF0ZUludGVyY2VwdG9yLmphdmE=)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pm/plugin/vertx3/RouterImplHandlerInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vdmVydHgtcGx1Z2lucy92ZXJ0eC1jb3JlLTMueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi92ZXJ0eDMvUm91dGVySW1wbEhhbmRsZXJJbnRlcmNlcHRvci5qYXZh)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rtx3/ServerConnectionHandleMessageInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vdmVydHgtcGx1Z2lucy92ZXJ0eC1jb3JlLTMueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi92ZXJ0eDMvU2VydmVyQ29ubmVjdGlvbkhhbmRsZU1lc3NhZ2VJbnRlcmNlcHRvci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)`

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **increase** coverage by `0.34%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   + Coverage 52.92%   53.27%   +0.34% 
   + Complexity 2981 2945  -36 
   
 Files   779  769  -10 
 Lines 1952519307 -218 
 Branches   1924 1907  -17 
   
   - Hits  1033410286  -48 
   + Misses 8333 8165 -168 
   + Partials858  856   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [66

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **increase** coverage by `0.36%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   + Coverage 52.92%   53.28%   +0.36% 
   + Complexity 2981 2945  -36 
   
 Files   779  768  -11 
 Lines 1952519303 -222 
 Branches   1924 1907  -17 
   
   - Hits  1033410286  -48 
   + Misses 8333 8161 -172 
   + Partials858  856   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [65

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **increase** coverage by `0.34%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   + Coverage 52.92%   53.27%   +0.34% 
   + Complexity 2981 2945  -36 
   
 Files   779  769  -10 
 Lines 1952519307 -218 
 Branches   1924 1907  -17 
   
   - Hits  1033410286  -48 
   + Misses 8333 8165 -168 
   + Partials858  856   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [66

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **increase** coverage by `0.36%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   + Coverage 52.92%   53.28%   +0.36% 
   + Complexity 2981 2945  -36 
   
 Files   779  768  -11 
 Lines 1952519303 -222 
 Branches   1924 1907  -17 
   
   - Hits  1033410286  -48 
   + Misses 8333 8161 -172 
   + Partials858  856   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [65

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **increase** coverage by `0.39%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   + Coverage 52.92%   53.31%   +0.39% 
   + Complexity 2981 2945  -36 
   
 Files   779  766  -13 
 Lines 1952519292 -233 
 Branches   1924 1907  -17 
   
   - Hits  1033410286  -48 
   + Misses 8333 8150 -183 
   + Partials858  856   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [67

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `1.45%`.
   > The diff coverage is `51.12%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 52.92%   51.47%   -1.46% 
   + Complexity 2981 2889  -92 
   
 Files   779  766  -13 
 Lines 1952519292 -233 
 Branches   1924 1907  -17 
   
   - Hits  10334 9930 -404 
   - Misses 8333 8527 +194 
   + Partials858  835  -23 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [80

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `3.75%`.
   > The diff coverage is `51.12%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 52.92%   49.16%   -3.76% 
   + Complexity 2981 2791 -190 
   
 Files   779  766  -13 
 Lines 1952519256 -269 
 Branches   1924 1906  -18 
   
   - Hits  10334 9468 -866 
   - Misses 8333 8983 +650 
   + Partials858  805  -53 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `4.25%`.
   > The diff coverage is `51.13%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 52.92%   48.66%   -4.26% 
   + Complexity 2981 2725 -256 
   
 Files   779  750  -29 
 Lines 1952518846 -679 
 Branches   1924 1872  -52 
   
   - Hits  10334 9172-1162 
   - Misses 8333 8889 +556 
   + Partials858  785  -73 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `4.28%`.
   > The diff coverage is `51.13%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 52.92%   48.64%   -4.29% 
   + Complexity 2981 2724 -257 
   
 Files   779  750  -29 
 Lines 1952518846 -679 
 Branches   1924 1872  -52 
   
   - Hits  10334 9168-1166 
   - Misses 8333 8893 +560 
   + Partials858  785  -73 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `4.17%`.
   > The diff coverage is `51.13%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 52.92%   48.74%   -4.18% 
   + Complexity 2981 2724 -257 
   
 Files   779  749  -30 
 Lines 1952518807 -718 
 Branches   1924 1871  -53 
   
   - Hits  10334 9168-1166 
   - Misses 8333 8854 +521 
   + Partials858  785  -73 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `4.14%`.
   > The diff coverage is `51.13%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 52.92%   48.77%   -4.15% 
   + Complexity 2981 2723 -258 
   
 Files   779  747  -32 
 Lines 1952518793 -732 
 Branches   1924 1857  -67 
   
   - Hits  10334 9167-1167 
   - Misses 8333 8841 +508 
   + Partials858  785  -73 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `14.31%`.
   > The diff coverage is `51.13%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 52.92%   38.61%   -14.32% 
   + Complexity 2981 2090  -891 
   =
 Files   779  747   -32 
 Lines 1952518793  -732 
 Branches   1924 1857   -67 
   =
   - Hits  10334 7257 -3077 
   - Misses 833310988 +2655 
   + Partials858  548  -310 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00>

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `14.28%`.
   > The diff coverage is `51.13%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 52.92%   38.64%   -14.29% 
   + Complexity 2981 2090  -891 
   =
 Files   779  745   -34 
 Lines 1952518781  -744 
 Branches   1924 1857   -67 
   =
   - Hits  10334 7257 -3077 
   - Misses 833310976 +2643 
   + Partials858  548  -310 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00>

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `0.34%`.
   > The diff coverage is `52.45%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 52.92%   52.58%   -0.35% 
   + Complexity 2981 2904  -77 
   
 Files   779  764  -15 
 Lines 1952519226 -299 
 Branches   1924 1896  -28 
   
   - Hits  1033410110 -224 
   + Misses 8333 8260  -73 
   + Partials858  856   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `0.30%`.
   > The diff coverage is `52.45%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 52.92%   52.62%   -0.31% 
   + Complexity 2981 2905  -76 
   
 Files   779  764  -15 
 Lines 1952519226 -299 
 Branches   1924 1896  -28 
   
   - Hits  1033410117 -217 
   + Misses 8333 8254  -79 
   + Partials858  855   -3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `19.42%`.
   > The diff coverage is `51.48%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 52.90%   33.48%   -19.43% 
   + Complexity 2979 1837 -1142 
   =
 Files   779  746   -33 
 Lines 1952518741  -784 
 Branches   1924 1859   -65 
   =
   - Hits  10330 6275 -4055 
   - Misses 833511964 +3629 
   + Partials860  502  -358 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `18.64%`.
   > The diff coverage is `51.48%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 52.90%   34.26%   -18.65% 
   + Complexity 2979 1883 -1096 
   =
 Files   779  746   -33 
 Lines 1952518741  -784 
 Branches   1924 1859   -65 
   =
   - Hits  10330 6421 -3909 
   - Misses 833511817 +3482 
   + Partials860  503  -357 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `15.31%`.
   > The diff coverage is `52.14%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 52.91%   37.60%   -15.32% 
   + Complexity 2980 2037  -943 
   =
 Files   779  746   -33 
 Lines 1952518761  -764 
 Branches   1924 1861   -63 
   =
   - Hits  10332 7055 -3277 
   - Misses 833411159 +2825 
   + Partials859  547  -312 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `22.73%`.
   > The diff coverage is `51.48%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 52.90%   30.16%   -22.74% 
   + Complexity 2979 1688 -1291 
   =
 Files   779  746   -33 
 Lines 1952518741  -784 
 Branches   1924 1859   -65 
   =
   - Hits  10330 5654 -4676 
   - Misses 833512643 +4308 
   + Partials860  444  -416 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `22.67%`.
   > The diff coverage is `51.48%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 52.90%   30.23%   -22.68% 
   + Complexity 2979 1688 -1291 
   =
 Files   779  745   -34 
 Lines 1952518702  -823 
 Branches   1924 1858   -66 
   =
   - Hits  10330 5654 -4676 
   - Misses 833512604 +4269 
   + Partials860  444  -416 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `52.90%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.90%   0.00%   -52.91% 
   
 Files   779 158  -621 
 Lines 195253943-15582 
 Branches   1924 469 -1455 
   
   - Hits  10330   0-10330 
   + Misses 83353943 -4392 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [680 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `52.90%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.90%   0.00%   -52.91% 
   
 Files   779 158  -621 
 Lines 195253887-15638 
 Branches   1924 458 -1466 
   
   - Hits  10330   0-10330 
   + Misses 83353887 -4448 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [680 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `52.90%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.90%   0.00%   -52.91% 
   
 Files   779 153  -626 
 Lines 195253821-15704 
 Branches   1924 451 -1473 
   
   - Hits  10330   0-10330 
   + Misses 83353821 -4514 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [683 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `52.90%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.90%   0.00%   -52.91% 
   
 Files   779 155  -624 
 Lines 195253833-15692 
 Branches   1924 451 -1473 
   
   - Hits  10330   0-10330 
   + Misses 83353833 -4502 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [683 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `52.90%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.90%   0.00%   -52.91% 
   
 Files   779 152  -627 
 Lines 195253816-15709 
 Branches   1924 451 -1473 
   
   - Hits  10330   0-10330 
   + Misses 83353816 -4519 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `52.90%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.90%   0.00%   -52.91% 
   
 Files   779 151  -628 
 Lines 195253808-15717 
 Branches   1924 451 -1473 
   
   - Hits  10330   0-10330 
   + Misses 83353808 -4527 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [684 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **decrease** coverage by `52.90%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 52.90%   0.00%   -52.91% 
   
 Files   779 149  -630 
 Lines 195253781-15744 
 Branches   1924 447 -1477 
   
   - Hits  10330   0-10330 
   + Misses 83353781 -4554 
   + Partials860   0  -860 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [686 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **increase** coverage by `18.26%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   + Coverage 34.33%   52.60%   +18.26% 
   - Complexity 1918 2929 +1011 
   =
 Files   758  769   +11 
 Lines 1901019307  +297 
 Branches   1887 1907   +20 
   =
   + Hits   652810156 +3628 
   + Misses11962 8305 -3657 
   - Partials520  846  +326 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (+98.61%)` | `1.00 <0.00> (+1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (+48.31%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (+85.71%)` | `1.00 <0.00> (+1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+69.01%)` | `3.00 <0.00> (+3.00)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-19 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/081c1260d518f1e37999a0876b089f948c5fa2a9=desc)
 will **increase** coverage by `22.36%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   + Coverage 30.23%   52.60%   +22.36% 
   - Complexity 1731 2929 +1198 
   =
 Files   758  769   +11 
 Lines 1899119307  +316 
 Branches   1886 1907   +21 
   =
   + Hits   574210156 +4414 
   + Misses12804 8305 -4499 
   - Partials445  846  +401 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (+98.61%)` | `1.00 <0.00> (+1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (+48.31%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (+85.71%)` | `1.00 <0.00> (+1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+69.01%)` | `3.00 <0.00> (+3.00)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `0.43%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   52.60%   -0.44% 
   + Complexity 2987 2929  -58 
   
 Files   779  769  -10 
 Lines 1952519307 -218 
 Branches   1924 1907  -17 
   
   - Hits  1035510156 -199 
   + Misses 8309 8305   -4 
   + Partials861  846  -15 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [68

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `0.43%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   52.60%   -0.44% 
   + Complexity 2987 2929  -58 
   
 Files   779  769  -10 
 Lines 1952519307 -218 
 Branches   1924 1907  -17 
   
   - Hits  1035510156 -199 
   + Misses 8309 8305   -4 
   + Partials861  846  -15 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [68

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `0.43%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   52.60%   -0.44% 
   + Complexity 2987 2929  -58 
   
 Files   779  769  -10 
 Lines 1952519307 -218 
 Branches   1924 1907  -17 
   
   - Hits  1035510156 -199 
   + Misses 8309 8305   -4 
   + Partials861  846  -15 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [68

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `0.43%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   52.60%   -0.44% 
   + Complexity 2987 2929  -58 
   
 Files   779  769  -10 
 Lines 1952519307 -218 
 Branches   1924 1907  -17 
   
   - Hits  1035510156 -199 
   + Misses 8309 8305   -4 
   + Partials861  846  -15 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [68

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **increase** coverage by `0.20%`.
   > The diff coverage is `72.50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   + Coverage 53.03%   53.24%   +0.20% 
   - Complexity 2987 2996   +9 
   
 Files   779 1422 +643 
 Lines 1952530787   +11262 
 Branches   1924 3423+1499 
   
   + Hits  1035516391+6036 
   - Misses 830913590+5281 
   + Partials861  806  -55 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=)
 | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=)
 | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `0.43%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   52.60%   -0.44% 
   + Complexity 2987 2929  -58 
   
 Files   779  769  -10 
 Lines 1952519307 -218 
 Branches   1924 1907  -17 
   
   - Hits  1035510156 -199 
   + Misses 8309 8305   -4 
   + Partials861  846  -15 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [68

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `0.42%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   52.61%   -0.43% 
   + Complexity 2987 2929  -58 
   
 Files   779  768  -11 
 Lines 1952519303 -222 
 Branches   1924 1907  -17 
   
   - Hits  1035510156 -199 
   + Misses 8309 8301   -8 
   + Partials861  846  -15 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [67

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `0.43%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   52.60%   -0.44% 
   + Complexity 2987 2926  -61 
   
 Files   779  768  -11 
 Lines 1952519303 -222 
 Branches   1924 1907  -17 
   
   - Hits  1035510154 -201 
   + Misses 8309 8303   -6 
   + Partials861  846  -15 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [68

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `1.14%`.
   > The diff coverage is `51.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   51.89%   -1.15% 
   + Complexity 2987 2905  -82 
   
 Files   779  768  -11 
 Lines 1952519303 -222 
 Branches   1924 1907  -17 
   
   - Hits  1035510017 -338 
   - Misses 8309 8441 +132 
   + Partials861  845  -16 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [73

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `2.70%`.
   > The diff coverage is `51.12%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   50.32%   -2.71% 
   + Complexity 2987 2855 -132 
   
 Files   779  766  -13 
 Lines 1952519292 -233 
 Branches   1924 1907  -17 
   
   - Hits  10355 9709 -646 
   - Misses 8309 8778 +469 
   + Partials861  805  -56 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [87

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `2.84%`.
   > The diff coverage is `51.12%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   50.18%   -2.85% 
   + Complexity 2987 2848 -139 
   
 Files   779  766  -13 
 Lines 1952519292 -233 
 Branches   1924 1907  -17 
   
   - Hits  10355 9682 -673 
   - Misses 8309 8807 +498 
   + Partials861  803  -58 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [88

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `5.91%`.
   > The diff coverage is `51.12%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   47.11%   -5.92% 
   + Complexity 2987 2699 -288 
   
 Files   779  763  -16 
 Lines 1952519211 -314 
 Branches   1924 1905  -19 
   
   - Hits  10355 9052-1303 
   - Misses 8309 9392+1083 
   + Partials861  767  -94 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `7.27%`.
   > The diff coverage is `50.80%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   45.76%   -7.28% 
   + Complexity 2987 2650 -337 
   
 Files   779  763  -16 
 Lines 1952519197 -328 
 Branches   1924 1904  -20 
   
   - Hits  10355 8785-1570 
   - Misses 8309 9658+1349 
   + Partials861  754 -107 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `7.90%`.
   > The diff coverage is `50.48%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   45.12%   -7.91% 
   + Complexity 2987 2621 -366 
   
 Files   779  763  -16 
 Lines 1952519197 -328 
 Branches   1924 1904  -20 
   
   - Hits  10355 8663-1692 
   - Misses 8309 9787+1478 
   + Partials861  747 -114 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `19.18%`.
   > The diff coverage is `50.48%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 53.03%   33.85%   -19.19% 
   + Complexity 2987 1868 -1119 
   =
 Files   779  747   -32 
 Lines 1952518791  -734 
 Branches   1924 1870   -54 
   =
   - Hits  10355 6361 -3994 
   - Misses 830911947 +3638 
   + Partials861  483  -378 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00>

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `9.18%`.
   > The diff coverage is `50.48%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   43.85%   -9.19% 
   + Complexity 2987 2490 -497 
   
 Files   779  747  -32 
 Lines 1952518791 -734 
 Branches   1924 1870  -54 
   
   - Hits  10355 8240-2115 
   - Misses 8309 9834+1525 
   + Partials861  717 -144 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.61% <ø> (-0.02%)` | `1.00 <0.00> (ø)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `48.31% <ø> (-1.14%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `85.71% <ø> (-0.96%)` | `1.00 <0.00> (ø)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `69.01% <ø> (+5.37%)` | `3.00 <0.00> (ø)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `22.60%`.
   > The diff coverage is `50.48%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 53.03%   30.42%   -22.61% 
   + Complexity 2987 1700 -1287 
   =
 Files   779  747   -32 
 Lines 1952518762  -763 
 Branches   1924 1855   -69 
   =
   - Hits  10355 5709 -4646 
   - Misses 830912610 +4301 
   + Partials861  443  -418 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00>

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `53.03%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 53.03%   0.00%   -53.04% 
   
 Files   779 160  -619 
 Lines 195253955-15570 
 Branches   1924 469 -1455 
   
   - Hits  10355   0-10355 
   + Misses 83093955 -4354 
   + Partials861   0  -861 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [680 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `22.72%`.
   > The diff coverage is `50.48%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 53.03%   30.30%   -22.73% 
   + Complexity 2987 1691 -1296 
   =
 Files   779  747   -32 
 Lines 1952518762  -763 
 Branches   1924 1855   -69 
   =
   - Hits  10355 5686 -4669 
   - Misses 830912633 +4324 
   + Partials861  443  -418 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/zookeeper/ZookeeperCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL1pvb2tlZXBlckNvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00>

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `53.03%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 53.03%   0.00%   -53.04% 
   
 Files   779 159  -620 
 Lines 195253950-15575 
 Branches   1924 469 -1455 
   
   - Hits  10355   0-10355 
   + Misses 83093950 -4359 
   + Partials861   0  -861 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <ø> (-98.64%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <ø> (-49.46%)` | `0.00 <0.00> (ø)` | |
   | 
[...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh)
 | `0.00% <ø> (-86.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/apm/agent/SkyWalkingAgent.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9hZ2VudC9Ta3lXYWxraW5nQWdlbnQuamF2YQ==)
 | `0.00% <ø> (-63.64%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [681 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=continue).
   > **Legend** - [Click here to learn

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `13.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   53.01%   -0.02% 
   - Complexity 2987 2996   +9 
   
 Files   779  780   +1 
 Lines 1952519579  +54 
 Branches   1924 1919   -5 
   
   + Hits  1035510380  +25 
   - Misses 8309 8341  +32 
   + Partials861  858   -3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   | 
[...r/plugin/kubernetes/NamespacedPodListInformer.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvTmFtZXNwYWNlZFBvZExpc3RJbmZvcm1lci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | | | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `0.80%`.
   > The diff coverage is `13.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   52.22%   -0.81% 
   + Complexity 2987 2968  -19 
   
 Files   779  780   +1 
 Lines 1952519579  +54 
 Branches   1924 1919   -5 
   
   - Hits  1035510226 -129 
   - Misses 8309 8493 +184 
   + Partials861  860   -1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `0.75%`.
   > The diff coverage is `13.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   52.28%   -0.76% 
   + Complexity 2987 2971  -16 
   
 Files   779  780   +1 
 Lines 1952519579  +54 
 Branches   1924 1919   -5 
   
   - Hits  1035510236 -119 
   - Misses 8309 8484 +175 
   + Partials861  859   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `0.04%`.
   > The diff coverage is `13.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   52.99%   -0.05% 
   - Complexity 2987 2994   +7 
   
 Files   779  780   +1 
 Lines 1952519579  +54 
 Branches   1924 1919   -5 
   
   + Hits  1035510375  +20 
   - Misses 8309 8345  +36 
   + Partials861  859   -2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `91.86% <0.00%> (-2.33%)` | `9.00% <0.00%> (-2.00%)` | |
   | 
[...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh)
 | `48.67% <0.00%> (-1.06%)` | `10.00% <0.00%> (ø%)` | |
   | 
[...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==)
 | `50.83% <0.00%> (-0.84%)` | `10.00% <0.00%> (-1.00%)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `0.88%`.
   > The diff coverage is `13.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   52.15%   -0.89% 
   + Complexity 2987 2963  -24 
   
 Files   779  780   +1 
 Lines 1952519579  +54 
 Branches   1924 1919   -5 
   
   - Hits  1035510211 -144 
   - Misses 8309 8508 +199 
   + Partials861  860   -1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `0.84%`.
   > The diff coverage is `13.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4967  +/-   ##
   
   - Coverage 53.03%   52.19%   -0.85% 
   + Complexity 2987 2964  -23 
   
 Files   779  780   +1 
 Lines 1952519579  +54 
 Branches   1924 1919   -5 
   
   - Hits  1035510219 -136 
   - Misses 8309 8500 +191 
   + Partials861  860   -1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `14.53%`.
   > The diff coverage is `13.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 53.03%   38.49%   -14.54% 
   + Complexity 2987 2177  -810 
   =
 Files   779  780+1 
 Lines 1952519543   +18 
 Branches   1924 1918-6 
   =
   - Hits  10355 7523 -2832 
   - Misses 830911453 +3144 
   + Partials861  567  -294 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `21.06%`.
   > The diff coverage is `13.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 53.03%   31.97%   -21.07% 
   + Complexity 2987 1841 -1146 
   =
 Files   779  764   -15 
 Lines 1952519113  -412 
 Branches   1924 1882   -42 
   =
   - Hits  10355 6111 -4244 
   - Misses 830912552 +4243 
   + Partials861  450  -411 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `17.57%`.
   > The diff coverage is `13.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 53.03%   35.45%   -17.58% 
   + Complexity 2987 2033  -954 
   =
 Files   779  780+1 
 Lines 1952519543   +18 
 Branches   1924 1918-6 
   =
   - Hits  10355 6929 -3426 
   - Misses 830912107 +3798 
   + Partials861  507  -354 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `21.90%`.
   > The diff coverage is `13.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 53.03%   31.12%   -21.91% 
   + Complexity 2987 1789 -1198 
   =
 Files   779  764   -15 
 Lines 1952519113  -412 
 Branches   1924 1882   -42 
   =
   - Hits  10355 5949 -4406 
   - Misses 830912715 +4406 
   + Partials861  449  -412 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `23.06%`.
   > The diff coverage is `13.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 53.03%   29.97%   -23.07% 
   + Complexity 2987 1733 -1254 
   =
 Files   779  764   -15 
 Lines 1952519101  -424 
 Branches   1924 1882   -42 
   =
   - Hits  10355 5725 -4630 
   - Misses 830912928 +4619 
   + Partials861  448  -413 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `22.92%`.
   > The diff coverage is `13.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4967   +/-   ##
   =
   - Coverage 53.03%   30.11%   -22.93% 
   + Complexity 2987 1741 -1246 
   =
 Files   779  764   -15 
 Lines 1952519101  -424 
 Branches   1924 1882   -42 
   =
   - Hits  10355 5752 -4603 
   - Misses 830912898 +4589 
   + Partials861  451  -410 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `20.00% <20.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   |

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `53.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 53.03%   0.00%   -53.04% 
   
 Files   779 164  -615 
 Lines 195254080-15445 
 Branches   1924 487 -1437 
   
   - Hits  10355   0-10355 
   + Misses 83094080 -4229 
   + Partials861   0  -861 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [739 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `53.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 53.03%   0.00%   -53.04% 
   
 Files   779 162  -617 
 Lines 195254068-15457 
 Branches   1924 487 -1437 
   
   - Hits  10355   0-10355 
   + Misses 83094068 -4241 
   + Partials861   0  -861 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [739 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `53.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 53.03%   0.00%   -53.04% 
   
 Files   779 151  -628 
 Lines 195253801-15724 
 Branches   1924 448 -1476 
   
   - Hits  10355   0-10355 
   + Misses 83093801 -4508 
   + Partials861   0  -861 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [750 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

2020-07-16 Thread GitBox



codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/9372e11eb2978b8f1f7296d69c2c652d140617cc=desc)
 will **decrease** coverage by `53.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4967   +/-   ##
   
   - Coverage 53.03%   0.00%   -53.04% 
   
 Files   779 150  -629 
 Lines 195253793-15732 
 Branches   1924 448 -1476 
   
   - Hits  10355   0-10355 
   + Misses 83093793 -4516 
   + Partials861   0  -861 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [750 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at

1 2 3 >

1 - 100 of 275 matches

Mail list logo