[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `3.68%`. > The diff coverage is `56.83%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 48.68% -3.69% + Complexity 3643 3376 -267 Files 959 1748 +789 Lines 2369537089 +13394 Branches 2325 4072+1747 + Hits 1240818055+5647 - Misses1018918068+7879 + Partials 1098 966 -132 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `9.00 <9.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `76.92% <70.00%> (+46.92%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <83.33%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.84%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 53.21% +0.84% - Complexity 3643 3713 +70 Files 959 959 Lines 2369523722 +27 Branches 2325 2322 -3 + Hits 1240812623 +215 + Misses10189 9991 -198 - Partials 1098 1108 +10 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.72%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 53.08% +0.72% - Complexity 3643 3710 +67 Files 959 959 Lines 2369523722 +27 Branches 2325 2322 -3 + Hits 1240812594 +186 + Misses1018910030 -159 Partials 1098 1098 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `4.90%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 47.46% -4.91% + Complexity 3643 3376 -267 Files 959 978 +19 Lines 2369524047 +352 Branches 2325 2363 +38 - Hits 1240811414 -994 - Misses1018911680+1491 + Partials 1098 953 -145 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.72%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 53.08% +0.72% - Complexity 3643 3710 +67 Files 959 959 Lines 2369523722 +27 Branches 2325 2322 -3 + Hits 1240812594 +186 + Misses1018910030 -159 Partials 1098 1098 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.61%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 52.97% +0.61% - Complexity 3643 3701 +58 Files 959 959 Lines 2369523722 +27 Branches 2325 2322 -3 + Hits 1240812567 +159 + Misses1018910055 -134 - Partials 1098 1100 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.25%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 52.62% +0.25% - Complexity 3643 3679 +36 Files 959 959 Lines 2369523722 +27 Branches 2325 2322 -3 + Hits 1240812483 +75 + Misses1018910152 -37 + Partials 1098 1087 -11 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.22%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 52.59% +0.22% - Complexity 3643 3678 +35 Files 959 959 Lines 2369523722 +27 Branches 2325 2322 -3 + Hits 1240812476 +68 + Misses1018910158 -31 + Partials 1098 1088 -10 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.41%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.94% -0.42% - Complexity 3643 3655 +12 Files 959 959 Lines 2369523712 +17 Branches 2325 2321 -4 - Hits 1240812318 -90 - Misses1018910323 +134 + Partials 1098 1071 -27 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.45%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.90% -0.46% - Complexity 3643 3652 +9 Files 959 959 Lines 2369523712 +17 Branches 2325 2321 -4 - Hits 1240812308 -100 - Misses1018910333 +144 + Partials 1098 1071 -27 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.29%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 52.06% -0.30% - Complexity 3643 3652 +9 Files 959 958 -1 Lines 2369523639 -56 Branches 2325 2304 -21 - Hits 1240812308 -100 - Misses1018910260 +71 + Partials 1098 1071 -27 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `9.53%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 42.83% -9.54% + Complexity 3643 2921 -722 Files 959 957 -2 Lines 2369523635 -60 Branches 2325 2304 -21 - Hits 1240810123-2285 - Misses1018912718+2529 + Partials 1098 794 -304 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%>
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `10.22%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 42.14% -10.23% + Complexity 3643 2886 -757 = Files 959 957-2 Lines 2369523635 -60 Branches 2325 2304 -21 = - Hits 12408 9960 -2448 - Misses1018912895 +2706 + Partials 1098 780 -318 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `10.41%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 41.95% -10.42% + Complexity 3643 2878 -765 = Files 959 957-2 Lines 2369523635 -60 Branches 2325 2304 -21 = - Hits 12408 9915 -2493 - Misses1018912942 +2753 + Partials 1098 778 -320 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `11.95%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 40.40% -11.96% + Complexity 3643 2756 -887 = Files 959 957-2 Lines 2369523617 -78 Branches 2325 2303 -22 = - Hits 12408 9543 -2865 - Misses1018913348 +3159 + Partials 1098 726 -372 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `12.66%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 39.70% -12.67% + Complexity 3643 2717 -926 = Files 959 957-2 Lines 2369523614 -81 Branches 2325 2303 -22 = - Hits 12408 9376 -3032 - Misses1018913511 +3322 + Partials 1098 727 -371 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `13.85%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 38.51% -13.86% + Complexity 3643 2635 -1008 = Files 959 957-2 Lines 2369523586 -109 Branches 2325 2298 -27 = - Hits 12408 9084 -3324 - Misses1018913796 +3607 + Partials 1098 706 -392 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `17.66%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 34.69% -17.67% + Complexity 3643 2415 -1228 = Files 959 957-2 Lines 2369523567 -128 Branches 2325 2298 -27 = - Hits 12408 8177 -4231 - Misses1018914774 +4585 + Partials 1098 616 -482 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `17.65%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 34.71% -17.66% + Complexity 3643 2415 -1228 = Files 959 955-4 Lines 2369523556 -139 Branches 2325 2298 -27 = - Hits 12408 8177 -4231 - Misses1018914763 +4574 + Partials 1098 616 -482 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `17.63%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 34.72% -17.64% + Complexity 3643 2415 -1228 = Files 959 955-4 Lines 2369523547 -148 Branches 2325 2283 -42 = - Hits 12408 8177 -4231 - Misses1018914754 +4565 + Partials 1098 616 -482 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `17.65%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 34.70% -17.66% + Complexity 3643 2413 -1230 = Files 959 955-4 Lines 2369523547 -148 Branches 2325 2283 -42 = - Hits 12408 8173 -4235 - Misses1018914758 +4569 + Partials 1098 616 -482 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `17.92%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 34.43% -17.93% + Complexity 3643 2396 -1247 = Files 959 955-4 Lines 2369523547 -148 Branches 2325 2283 -42 = - Hits 12408 8109 -4299 - Misses1018914824 +4635 + Partials 1098 614 -484 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `19.61%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 32.74% -19.62% + Complexity 3643 2304 -1339 = Files 959 955-4 Lines 2369523538 -157 Branches 2325 2283 -42 = - Hits 12408 7708 -4700 - Misses1018915259 +5070 + Partials 1098 571 -527 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `19.61%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 32.74% -19.62% + Complexity 3643 2304 -1339 = Files 959 955-4 Lines 2369523538 -157 Branches 2325 2283 -42 = - Hits 12408 7708 -4700 - Misses1018915259 +5070 + Partials 1098 571 -527 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `19.56%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 32.80% -19.57% + Complexity 3643 2304 -1339 = Files 959 954-5 Lines 2369523499 -196 Branches 2325 2282 -43 = - Hits 12408 7708 -4700 - Misses1018915220 +5031 + Partials 1098 571 -527 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (b237fbc) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `21.85%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 30.51% -21.86% + Complexity 3643 2088 -1555 = Files 959 925 -34 Lines 2369522658 -1037 Branches 2325 2186 -139 = - Hits 12408 6913 -5495 - Misses1018915216 +5027 + Partials 1098 529 -569 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `4.90%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 47.46% -4.91% + Complexity 3643 3376 -267 Files 959 978 +19 Lines 2369524047 +352 Branches 2325 2363 +38 - Hits 1240811414 -994 - Misses1018911680+1491 + Partials 1098 953 -145 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `5.54%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 46.81% -5.55% + Complexity 3643 3348 -295 Files 959 978 +19 Lines 2369524047 +352 Branches 2325 2363 +38 - Hits 1240811258-1150 - Misses1018911854+1665 + Partials 1098 935 -163 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `5.43%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 46.93% -5.44% + Complexity 3643 3348 -295 Files 959 976 +17 Lines 2369523988 +293 Branches 2325 2356 +31 - Hits 1240811258-1150 - Misses1018911795+1606 + Partials 1098 935 -163 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `5.35%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 47.01% -5.36% + Complexity 3643 3348 -295 Files 959 975 +16 Lines 2369523948 +253 Branches 2325 2352 +27 - Hits 1240811258-1150 - Misses1018911755+1566 + Partials 1098 935 -163 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `6.08%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 46.28% -6.09% + Complexity 3643 3317 -326 Files 959 975 +16 Lines 2369523948 +253 Branches 2325 2352 +27 - Hits 1240811084-1324 - Misses1018911932+1743 + Partials 1098 932 -166 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `5.40%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 46.96% -5.41% + Complexity 3643 3317 -326 Files 959 958 -1 Lines 2369523601 -94 Branches 2325 2302 -23 - Hits 1240811084-1324 - Misses1018911585+1396 + Partials 1098 932 -166 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `6.13%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 46.23% -6.14% + Complexity 3643 3280 -363 Files 959 958 -1 Lines 2369523601 -94 Branches 2325 2302 -23 - Hits 1240810911-1497 - Misses1018911775+1586 + Partials 1098 915 -183 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `8.04%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 44.32% -8.05% + Complexity 3643 3101 -542 Files 959 941 -18 Lines 2369523071 -624 Branches 2325 2246 -79 - Hits 1240810226-2182 - Misses1018911974+1785 + Partials 1098 871 -227 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `20.67%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 31.69% -20.68% + Complexity 3643 2143 -1500 = Files 959 940 -19 Lines 2369522879 -816 Branches 2325 2197 -128 = - Hits 12408 7251 -5157 - Misses1018915101 +4912 + Partials 1098 527 -571 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `20.96%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 31.40% -20.97% + Complexity 3643 2130 -1513 = Files 959 940 -19 Lines 2369522879 -816 Branches 2325 2197 -128 = - Hits 12408 7185 -5223 - Misses1018915168 +4979 + Partials 1098 526 -572 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `24.28%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 28.08% -24.29% + Complexity 3643 1945 -1698 = Files 959 940 -19 Lines 2369522870 -825 Branches 2325 2197 -128 = - Hits 12408 6422 -5986 - Misses1018915966 +5777 + Partials 1098 482 -616 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `50.00% <ø> (+50.00%)` | `3.00 <0.00> (+3.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `52.36%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #6232 +/- ## - Coverage 52.36% 0.00% -52.37% Files 959 181 -778 Lines 236954303-19392 Branches 2325 495 -1830 - Hits 12408 0-12408 + Misses101894303 -5886 + Partials 1098 0 -1098 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | ... and [932 more](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree-more) | | -- [Continue to review full report
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `52.36%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #6232 +/- ## - Coverage 52.36% 0.00% -52.37% Files 959 180 -779 Lines 236954298-19397 Branches 2325 495 -1830 - Hits 12408 0-12408 + Misses101894298 -5891 + Partials 1098 0 -1098 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | ... and [933 more](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree-more) | | -- [Continue to review full report
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (3900be1) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `52.36%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #6232 +/- ## - Coverage 52.36% 0.00% -52.37% Files 959 178 -781 Lines 236954286-19409 Branches 2325 495 -1830 - Hits 12408 0-12408 + Misses101894286 -5903 + Partials 1098 0 -1098 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | ... and [933 more](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree-more) | | -- [Continue to review full report
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.73%`. > The diff coverage is `56.83%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.62% -0.74% - Complexity 3643 3725 +82 Files 959 1747 +788 Lines 2369537025 +13330 Branches 2325 4081+1756 + Hits 1240819116+6708 - Misses1018916947+6758 + Partials 1098 962 -136 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `76.92% <70.00%> (+46.92%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <83.33%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.73%`. > The diff coverage is `56.83%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.62% -0.74% - Complexity 3643 3725 +82 Files 959 1747 +788 Lines 2369537025 +13330 Branches 2325 4081+1756 + Hits 1240819116+6708 - Misses1018916947+6758 + Partials 1098 962 -136 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `76.92% <70.00%> (+46.92%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <83.33%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.74%`. > The diff coverage is `56.83%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.62% -0.75% - Complexity 3643 3724 +81 Files 959 1747 +788 Lines 2369537025 +13330 Branches 2325 4081+1756 + Hits 1240819114+6706 - Misses1018916949+6760 + Partials 1098 962 -136 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `76.92% <70.00%> (+46.92%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <83.33%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.74%`. > The diff coverage is `56.83%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.62% -0.75% - Complexity 3643 3724 +81 Files 959 1747 +788 Lines 2369537025 +13330 Branches 2325 4081+1756 + Hits 1240819113+6705 - Misses1018916950+6761 + Partials 1098 962 -136 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `76.92% <70.00%> (+46.92%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `83.33% <83.33%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `6.59%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 45.77% -6.60% + Complexity 3643 3322 -321 Files 959 979 +20 Lines 2369524043 +348 Branches 2325 2363 +38 - Hits 1240811005-1403 - Misses1018912097+1908 + Partials 1098 941 -157 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `1.51%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 53.88% +1.51% - Complexity 3643 3724 +81 Files 959 958 -1 Lines 2369523667 -28 Branches 2325 2309 -16 + Hits 1240812752 +344 + Misses10189 9811 -378 - Partials 1098 1104 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `1.19%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 53.55% +1.19% - Complexity 3643 3707 +64 Files 959 958 -1 Lines 2369523667 -28 Branches 2325 2309 -16 + Hits 1240812676 +268 + Misses10189 9897 -292 + Partials 1098 1094 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `1.18%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 53.54% +1.18% - Complexity 3643 3705 +62 Files 959 957 -2 Lines 2369523663 -32 Branches 2325 2309 -16 + Hits 1240812671 +263 + Misses10189 9897 -292 + Partials 1098 1095 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.40%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 52.77% +0.40% - Complexity 3643 3658 +15 Files 959 957 -2 Lines 2369523663 -32 Branches 2325 2309 -16 + Hits 1240812488 +80 + Misses1018910102 -87 + Partials 1098 1073 -25 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **increase** coverage by `0.08%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## + Coverage 52.36% 52.45% +0.08% + Complexity 3643 3639 -4 Files 959 957 -2 Lines 2369523663 -32 Branches 2325 2309 -16 + Hits 1240812412 +4 + Misses1018910175 -14 + Partials 1098 1076 -22 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.14%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 52.22% -0.15% + Complexity 3643 3625 -18 Files 959 957 -2 Lines 2369523663 -32 Branches 2325 2309 -16 - Hits 1240812357 -51 - Misses1018910238 +49 + Partials 1098 1068 -30 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `0.71%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 51.64% -0.72% + Complexity 3643 3588 -55 Files 959 957 -2 Lines 2369523635 -60 Branches 2325 2304 -21 - Hits 1240812207 -201 - Misses1018910380 +191 + Partials 1098 1048 -50 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `2.14%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 50.22% -2.15% + Complexity 3643 3470 -173 Files 959 956 -3 Lines 2369523612 -83 Branches 2325 2303 -22 - Hits 1240811859 -549 - Misses1018910751 +562 + Partials 1098 1002 -96 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `2.55%`. > The diff coverage is `42.64%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 49.81% -2.56% + Complexity 3643 3449 -194 Files 959 956 -3 Lines 2369523609 -86 Branches 2325 2303 -22 - Hits 1240811760 -648 - Misses1018910851 +662 + Partials 1098 998 -100 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `48.14% <48.14%> (ø)` | `10.00 <10.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `50.00% <100.00%> (-3.85%)` | `4.00 <0.00> (-1.00)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `11.45%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 40.91% -11.46% + Complexity 3643 2731 -912 = Files 959 954-5 Lines 2369523598 -97 Branches 2325 2303 -22 = - Hits 12408 9655 -2753 - Misses1018913204 +3015 + Partials 1098 739 -359 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `11.64%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 40.72% -11.65% + Complexity 3643 2723 -920 = Files 959 954-5 Lines 2369523598 -97 Branches 2325 2303 -22 = - Hits 12408 9610 -2798 - Misses1018913251 +3062 + Partials 1098 737 -361 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `12.06%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 40.30% -12.07% + Complexity 3643 2706 -937 = Files 959 954-5 Lines 2369523582 -113 Branches 2325 2288 -37 = - Hits 12408 9504 -2904 - Misses1018913341 +3152 + Partials 1098 737 -361 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `12.24%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 40.12% -12.25% + Complexity 3643 2697 -946 = Files 959 954-5 Lines 2369523582 -113 Branches 2325 2288 -37 = - Hits 12408 9462 -2946 - Misses1018913392 +3203 + Partials 1098 728 -370 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `13.18%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 39.18% -13.19% + Complexity 3643 2666 -977 = Files 959 954-5 Lines 2369523582 -113 Branches 2325 2288 -37 = - Hits 12408 9240 -3168 - Misses1018913628 +3439 + Partials 1098 714 -384 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `14.75%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 37.60% -14.76% + Complexity 3643 2586 -1057 = Files 959 954-5 Lines 2369523526 -169 Branches 2325 2285 -40 = - Hits 12408 8848 -3560 - Misses1018913978 +3789 + Partials 1098 700 -398 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `20.54%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 52.36% 31.82% -20.55% + Complexity 3643 2282 -1361 = Files 959 953-6 Lines 2369523503 -192 Branches 2325 2285 -40 = - Hits 12408 7479 -4929 - Misses1018915437 +5248 + Partials 1098 587 -511 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `6.59%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 45.77% -6.60% + Complexity 3643 3322 -321 Files 959 979 +20 Lines 2369524043 +348 Branches 2325 2363 +38 - Hits 1240811005-1403 - Misses1018912097+1908 + Partials 1098 941 -157 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `6.69%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 45.66% -6.70% + Complexity 3643 3306 -337 Files 959 979 +20 Lines 2369524034 +339 Branches 2325 2363 +38 - Hits 1240810976-1432 - Misses1018912117+1928 + Partials 1098 941 -157 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `7.52%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 44.84% -7.53% + Complexity 3643 3251 -392 Files 959 979 +20 Lines 2369524034 +339 Branches 2325 2363 +38 - Hits 1240810777-1631 - Misses1018912329+2140 + Partials 1098 928 -170 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `7.52%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 44.84% -7.53% + Complexity 3643 3251 -392 Files 959 979 +20 Lines 2369524033 +338 Branches 2325 2363 +38 - Hits 1240810777-1631 - Misses1018912328+2139 + Partials 1098 928 -170 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `7.52%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 44.84% -7.53% + Complexity 3643 3251 -392 Files 959 979 +20 Lines 2369524033 +338 Branches 2325 2363 +38 - Hits 1240810777-1631 - Misses1018912328+2139 + Partials 1098 928 -170 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `7.45%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.36% 44.91% -7.46% + Complexity 3643 3251 -392 Files 959 978 +19 Lines 2369523994 +299 Branches 2325 2362 +37 - Hits 1240810777-1631 - Misses1018912289+2100 + Partials 1098 928 -170 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `7.42%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.34% 44.91% -7.43% + Complexity 3642 3251 -391 Files 959 978 +19 Lines 2369523994 +299 Branches 2325 2362 +37 - Hits 1240210777-1625 - Misses1019512289+2094 + Partials 1098 928 -170 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `7.31%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.22% 44.91% -7.32% + Complexity 3636 3251 -385 Files 959 978 +19 Lines 2369523994 +299 Branches 2325 2362 +37 - Hits 1237510777-1598 - Misses1022512289+2064 + Partials 1095 928 -167 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `7.29%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.21% 44.91% -7.30% + Complexity 3633 3251 -382 Files 959 978 +19 Lines 2369523994 +299 Branches 2325 2362 +37 - Hits 1237210777-1595 - Misses1022512289+2064 + Partials 1098 928 -170 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `7.02%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 52.11% 45.08% -7.03% + Complexity 3627 3251 -376 Files 959 975 +16 Lines 2369523903 +208 Branches 2325 2351 +26 - Hits 1234810777-1571 - Misses1025012198+1948 + Partials 1097 928 -169 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `6.07%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 51.15% 45.08% -6.08% + Complexity 3589 3251 -338 Files 959 975 +16 Lines 2368223903 +221 Branches 2324 2351 +27 - Hits 1211510777-1338 - Misses1048712198+1711 + Partials 1080 928 -152 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `21.35%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 29.79% -21.36% + Complexity 3589 2181 -1408 = Files 959 953-6 Lines 2368223499 -183 Branches 2324 2284 -40 = - Hits 12115 7002 -5113 - Misses1048715960 +5473 + Partials 1080 537 -543 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `21.30%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 29.84% -21.31% + Complexity 3589 2181 -1408 = Files 959 952-7 Lines 2368223459 -223 Branches 2324 2280 -44 = - Hits 12115 7002 -5113 - Misses1048715920 +5433 + Partials 1080 537 -543 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `21.30%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 29.84% -21.31% + Complexity 3589 2181 -1408 = Files 959 952-7 Lines 2368223459 -223 Branches 2324 2280 -44 = - Hits 12115 7002 -5113 - Misses1048715920 +5433 + Partials 1080 537 -543 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `21.30%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 29.84% -21.31% + Complexity 3589 2181 -1408 = Files 959 952-7 Lines 2368223459 -223 Branches 2324 2280 -44 = - Hits 12115 7002 -5113 - Misses1048715920 +5433 + Partials 1080 537 -543 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `21.22%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 29.93% -21.23% + Complexity 3589 2181 -1408 = Files 959 948 -11 Lines 2368223394 -288 Branches 2324 2272 -52 = - Hits 12115 7002 -5113 - Misses1048715855 +5368 + Partials 1080 537 -543 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `21.21%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 29.94% -21.22% + Complexity 3589 2181 -1408 = Files 959 946 -13 Lines 2368223382 -300 Branches 2324 2272 -52 = - Hits 12115 7002 -5113 - Misses1048715843 +5356 + Partials 1080 537 -543 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `21.19%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 29.95% -21.20% + Complexity 3589 2181 -1408 = Files 959 945 -14 Lines 2368223373 -309 Branches 2324 2271 -53 = - Hits 12115 7002 -5113 - Misses1048715834 +5347 + Partials 1080 537 -543 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `6.07%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 51.15% 45.08% -6.08% + Complexity 3589 3251 -338 Files 959 975 +16 Lines 2368223903 +221 Branches 2324 2351 +27 - Hits 1211510777-1338 - Misses1048712198+1711 + Partials 1080 928 -152 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <25.00%> (+5.89%)` | `9.00 <3.00> (+1.00)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `6.10%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 51.15% 45.05% -6.11% + Complexity 3589 3249 -340 Files 959 975 +16 Lines 2368223903 +221 Branches 2324 2351 +27 - Hits 1211510769-1346 - Misses1048712207+1720 + Partials 1080 927 -153 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `6.40%`. > The diff coverage is `41.17%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## - Coverage 51.15% 44.75% -6.41% + Complexity 3589 3230 -359 Files 959 975 +16 Lines 2368223894 +212 Branches 2324 2336 +12 - Hits 1211510693-1422 - Misses1048712275+1788 + Partials 1080 926 -154 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `22.22% <22.22%> (ø)` | `2.00 <2.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <25.00%> (+3.33%)` | `8.00 <3.00> (ø)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `35.00% <35.00%> (ø)` | `4.00 <4.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `45.67% <45.67%> (ø)` | `9.00 <9.00> (?)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `57.14% <100.00%> (+3.29%)` | `5.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `80.95% <100.00%> (+0.30%)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `15.61%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 35.54% -15.62% + Complexity 3589 2486 -1103 = Files 959 975 +16 Lines 2368223894 +212 Branches 2324 2336 +12 = - Hits 12115 8492 -3623 - Misses1048714747 +4260 + Partials 1080 655 -425 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `15.09%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 36.06% -15.10% + Complexity 3589 2486 -1103 = Files 959 958-1 Lines 2368223547 -135 Branches 2324 2286 -38 = - Hits 12115 8492 -3623 - Misses1048714400 +3913 + Partials 1080 655 -425 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `15.08%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 36.07% -15.09% + Complexity 3589 2486 -1103 = Files 959 957-2 Lines 2368223542 -140 Branches 2324 2286 -38 = - Hits 12115 8492 -3623 - Misses1048714395 +3908 + Partials 1080 655 -425 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `15.08%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 36.07% -15.09% + Complexity 3589 2486 -1103 = Files 959 957-2 Lines 2368223542 -140 Branches 2324 2286 -38 = - Hits 12115 8492 -3623 - Misses1048714395 +3908 + Partials 1080 655 -425 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `15.06%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 36.09% -15.07% + Complexity 3589 2486 -1103 = Files 959 955-4 Lines 2368223530 -152 Branches 2324 2286 -38 = - Hits 12115 8492 -3623 - Misses1048714383 +3896 + Partials 1080 655 -425 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `15.27%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 35.87% -15.28% + Complexity 3589 2478 - = Files 959 955-4 Lines 2368223530 -152 Branches 2324 2286 -38 = - Hits 12115 8442 -3673 - Misses1048714432 +3945 + Partials 1080 656 -424 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `18.41%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 32.73% -18.42% + Complexity 3589 2287 -1302 = Files 959 954-5 Lines 2368223505 -177 Branches 2324 2282 -42 = - Hits 12115 7695 -4420 - Misses1048715198 +4711 + Partials 1080 612 -468 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `18.32%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 32.83% -18.33% + Complexity 3589 2287 -1302 = Files 959 950-9 Lines 2368223436 -246 Branches 2324 2281 -43 = - Hits 12115 7695 -4420 - Misses1048715129 +4642 + Partials 1080 612 -468 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `18.46%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 32.68% -18.47% + Complexity 3589 2236 -1353 = Files 959 933 -26 Lines 2368222926 -756 Branches 2324 2227 -97 = - Hits 12115 7494 -4621 - Misses1048714834 +4347 + Partials 1080 598 -482 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (c0bac6e) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `12.21%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 38.94% -12.22% + Complexity 3589 2236 -1353 = Files 959 777 -182 Lines 2368219243 -4439 Branches 2324 1807 -517 = - Hits 12115 7494 -4621 - Misses1048711151 +664 + Partials 1080 598 -482 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | | | [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...erver/storage/plugin/jdbc/h2/dao/H2MetricsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `26.95%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 24.20% -26.96% + Complexity 3589 1762 -1827 = Files 959 942 -17 Lines 2368223163 -519 Branches 2324 2237 -87 = - Hits 12115 5606 -6509 - Misses1048717141 +6654 + Partials 1080 416 -664 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `0.00% <0.00%> (-53.85%)` | `0.00 <0.00> (-5.00)` | | | [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-80.65%)` | `0.00 <0.00> (ø)` | | | [...nt/core/conf/dynamic/AgentConfigChangeWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0FnZW50Q29uZmlnQ2hhbmdlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...g/apm/agent/core/sampling/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-30.00%)` | `0.00 <0.00> (-8.00)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `22.52%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 28.63% -22.53% + Complexity 3589 1762 -1827 = Files 959 793 -166 Lines 2368219577 -4105 Branches 2324 1829 -495 = - Hits 12115 5606 -6509 - Misses1048713555 +3068 + Partials 1080 416 -664 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%>
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `22.62%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 28.53% -22.63% + Complexity 3589 1718 -1871 = Files 959 776 -183 Lines 2368219067 -4615 Branches 2324 1775 -549 = - Hits 12115 5441 -6674 - Misses1048713214 +2727 + Partials 1080 412 -668 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%>
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6232: Support dynamic change SAMPLE_N_PER_3_SECS on java agent
codecov[bot] edited a comment on pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#issuecomment-762898302 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=h1) Report > Merging [#6232](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=desc) (ca3f56b) into [master](https://codecov.io/gh/apache/skywalking/commit/15204781fa14050455c3733c4ff9659f63c50160?el=desc) (1520478) will **decrease** coverage by `24.97%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6232 +/- ## = - Coverage 51.15% 26.18% -24.98% + Complexity 3589 1576 -2013 = Files 959 776 -183 Lines 2368219067 -4615 Branches 2324 1775 -549 = - Hits 12115 4992 -7123 - Misses1048713693 +3206 + Partials 1080 382 -698 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6232?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...ler/grpc/ConfigurationDiscoveryServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2NvbmZpZ3VyYXRpb24tZGlzY292ZXJ5LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2NvbmZpZ3VyYXRpb24vZGlzY292ZXJ5L2hhbmRsZXIvZ3JwYy9Db25maWd1cmF0aW9uRGlzY292ZXJ5U2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6232/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%>
