[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-566030836 > Hi @cyejing, there are [update submodule](https://github.com/apache/skywalking/pull/3945/files#diff-8693f16a05265e9581e98cb7f3ff817a) in this PR, please recheck. @arugal I have revert This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-565983869 ok, I adjust the code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-565708027 revert old test case, and revert test case . please recheck @wu-sheng This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-565410399 ``OperationName`` use url pattern, and use OkHttpClient add webflux exitSpan test case This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-562415729 ok, understand, Then I stop this PR first. submit next time This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-562413745 Yes, Currently, I need ``setOperationNameInAsync `` to set ``urlPattern`` . if so can I add ``setOperationNameInAsync `` on this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-562406509 > > How to modify operationName in another thread . setOperationName failed. > > Could you share how fail? like my code shown ``stackDepth`` is reduced because ``ContextManager.stopSpan`` . ``ContextManager.stopSpan`` is executed to clean up the context of the current thread This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-562405260  I see no changes allowed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-562404866 @wu-sheng @zhaoyuguang I try do it I would like to know ， Execute in one thread `` span.prepareForAsync(); ContextManager.stopSpan(span);`` , How to modify operationName in another thread . ``setOperationName`` failed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-561054155 ok, I keep old operationName "WEBFLUX.handle", and set Span to ``SkyWalkingDynamicField``, so no need to modify the gateway . then use ``2. Create an async span to finish in another thread`` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-560296989 > 1. Create a snapshot to propagate. Or 2. Create an async span to finish in another thread. I tried this way, If two threads switch, will produce two spans with very short time spans, but the entire request time is very long. My approach is to let the ``Context`` manage the full request. The requested time span is also displayed normally. at reactive programming, If you want to rely on ThreadLocal to pass parameters, you will often encounter obstacles. so I think we should define a set of APIs suitable for reactive programming This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
