[GitHub] [skywalking] kezhenxu94 commented on pull request #4805: Check http protocol in Python agent as well

2020-05-23 Thread GitBox 


kezhenxu94 commented on pull request #4805:
URL: https://github.com/apache/skywalking/pull/4805#issuecomment-633000728


   Should be good to go



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on pull request #4805: Check http protocol in Python agent as well

2020-05-20 Thread GitBox 


kezhenxu94 commented on pull request #4805:
URL: https://github.com/apache/skywalking/pull/4805#issuecomment-631528297


   > I think you should set up 2 test cases? One for HTTP, the other for gRPC.
   
   There're two services, provider and consumer, they use grpc and http 
respectively, I think it's enough, no?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org