[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-662838213 https://github.com/apache/skywalking/pull/5161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-662832272 > > [apache/skywalking-data-collect-protocol#28](https://github.com/apache/skywalking-data-collect-protocol/pull/28) @mrproliu > > Thanks, have merged. Please update the protocol submodule in the [main repo](https://github.com/apache/skywalking). prevent errors when others download the Skywalking project. ok This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-662817578 https://github.com/apache/skywalking-data-collect-protocol/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-661982334   Above are my local test results This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-661940278 > @stalary Every time you submit pull request, it should and must be tested locally. I'm very sorry. I will pay attention to it next time This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-661917604 Sorry, I was running a local test this morning, but I haven't finished it yet This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-661916589 > How do you test this in the first place? Your questions are confusing me. I used `./mvnw package -DskipTests` in my code branch, then run oap-server and test it with the service configuration -javaagent This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-661913168 I encountered this error, but I have no idea. Could you give me some help？ ` ERROR 2020-07-21 22:50:03:037 SkywalkingAgent-7-JVMService-consume-0 JVMService : send JVM metrics to Collector fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNKNOWN at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:240) at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:221) at org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:140) at org.apache.skywalking.apm.network.language.agent.v3.JVMMetricReportServiceGrpc$JVMMetricReportServiceBlockingStub.collect(JVMMetricReportServiceGrpc.java:158) at org.apache.skywalking.apm.agent.core.jvm.JVMService$Sender.run(JVMService.java:155) at org.apache.skywalking.apm.util.RunnableWithExceptionProtection.run(RunnableWithExceptionProtection.java:33) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) ` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-661896439 I use `./mvnw clean package -DskipTests` It seems that The proto I modified has not been updated. Is my operation wrong? @wu-sheng This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-661891433 ` ERROR 2020-07-21 22:21:06:778 SkywalkingAgent-6-JVMService-produce-0 JVMService : JVMService produces metrics failure. java.lang.NoSuchMethodError: org.apache.skywalking.apm.network.language.agent.v3.Thread$Builder.setLiveCount(I)Lorg/apache/skywalking/apm/network/language/agent/v3/Thread$Builder; at org.apache.skywalking.apm.agent.core.jvm.thread.ThreadProvider.getThreadMetrics(ThreadProvider.java:37) at org.apache.skywalking.apm.agent.core.jvm.JVMService.run(JVMService.java:125) at org.apache.skywalking.apm.util.RunnableWithExceptionProtection.run(RunnableWithExceptionProtection.java:33) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) ` There's a problem. Let me see why This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-661890078 Wait a minute. I found a problem with my local tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-661887761 https://user-images.githubusercontent.com/24592373/88065730-8fbd2e00-cb9f-11ea-8902-432dadc42297.png;> When will JVM data be triggered? I called the service, but none of the JVM data is available This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-661884486 > Where are the metrics? Just a moment, I haven't started my service yet This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-661882703 https://user-images.githubusercontent.com/24592373/88064823-6059f180-cb9e-11ea-8b2e-39ddd219eb7c.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-661025036 thanks @kezhenxu94 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660990396 I'm not expected/simple/serviceInstanceTopo yml found related to the JVM configuration, how should I go to modify? @arugal This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660984928 > Can you add tests related to JVM metrics in E2E? In this [position](https://github.com/apache/skywalking/blob/e0325a44070cf94c73624a2c4c81819bc14ee09d/test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/simple/SimpleE2E.java#L181). FYI @kezhenxu94 Ok, let me see here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] stalary commented on pull request #5129: Add jvm_thread metrics
stalary commented on pull request #5129: URL: https://github.com/apache/skywalking/pull/5129#issuecomment-660784673 > [OALLexer.g4](https://github.com/apache/skywalking/blob/master/oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4) and [OALParser.g4](https://github.com/apache/skywalking/blob/master/oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALParser.g4) are missing, Please follow [scope-definitions.md](https://github.com/apache/skywalking/blob/master/docs/en/concepts-and-designs/scope-definitions.md). Thanks. I will correct it later This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
