[GitHub] [skywalking] viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration

[GitBox]

viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration
URL: https://github.com/apache/skywalking/pull/3788#issuecomment-552946737
 
 
   I am away from my computer for couple of days. If someone can take that
   final comment and fix, they can. Or I will send update in two days.
   
   On Tue, Nov 12, 2019, 10:01 AM 吴晟 Wu Sheng  wrote:
   
   > @viswaramamoorthy  Code frozen is
   > over. Please keep the update, after all checked, this could be merged.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration

[GitBox]

viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration
URL: https://github.com/apache/skywalking/pull/3788#issuecomment-552108060
 
 
   @arugal @wu-sheng I have pushed commit with code review comment changes. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration

[GitBox]

viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration
URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551240065
 
 
   Few fixes added and all RabbitMQ tests are running successfully in local env


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration

[GitBox]

viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration
URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551128788
 
 
   @arugal That is the issue. run,sh is an issue. build_id has to be defaulted 
to latest so the built docker image can be run. It is defaulted to "local" 
because of this, docker compose generated looks for " 
skywalking/agent-test-jvm:local" that never exists and hence container not 
starting
   
   I have shown the problem in bold below. check
   
   build_id="**local**"
   ..
   print_help() {
   echo  "Usage: run.sh [OPTION] SCENARIO_NAME"
   echo -e "\t-f, --force_build \t\t do force to build Plugin-Test tools 
and images"
   echo -e "\t--build_id, \t\t\t specify Plugin_Test's image tag. Defalt: 
**latest**"


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration

[GitBox]

viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration
URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551104362
 
 
   Local error is not due to health check, it is complaining about missing or 
docker image permission. see below. 
   
   Pulling rabbitmq-scenario-5.5.1-local (skywalking/agent-test-jvm:local)...
   ERROR: The image for the service you're trying to recreate has been removed. 
If you continue, volume data could be lost. Consider backing up your data 
before continuing.
   
   Anyway, I have added healthcheck and made changes to log messages. check


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration

[GitBox]

viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration
URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551088082
 
 
   I ran rabbitmq-scenario locally using run.sh. I saw few basic errors. 
   
   is run.sh expected work locally for e.g. my laptop? I have docker installed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration

[GitBox]

viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration
URL: https://github.com/apache/skywalking/pull/3788#issuecomment-550314230
 
 
   I am not familiar with this framework. one of you can take over this PR. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services