[GitHub] [skywalking] wu-sheng commented on a change in pull request #3820: [agent/plugin] Move FILTER_LENGTH_LIMIT to config.plugin.mongodb

2019-11-09 Thread GitBox 
wu-sheng commented on a change in pull request #3820: [agent/plugin] Move 
FILTER_LENGTH_LIMIT to config.plugin.mongodb
URL: https://github.com/apache/skywalking/pull/3820#discussion_r344475635
 
 

 ##
 File path: 
apm-sniffer/apm-sdk-plugin/mongodb-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mongodb/v3/support/MongoOperationHelper.java
 ##
 @@ -111,7 +128,8 @@ private static String getFilter(List writeRequestList) {
 } else if (request instanceof UpdateRequest) {
 params.append(((UpdateRequest) 
request).getFilter()).append(",");
 }
-if (params.length() > MongoConstants.FILTER_LENGTH_LIMIT) {
+final int filterLengthLimit = 
Config.Plugin.MongoDB.FILTER_LENGTH_LIMIT;
+if (filterLengthLimit > 0 && params.length() > filterLengthLimit) {
 
 Review comment:
   Negative value means all?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3820: [agent/plugin] Move FILTER_LENGTH_LIMIT to config.plugin.mongodb

2019-11-09 Thread GitBox 
wu-sheng commented on a change in pull request #3820: [agent/plugin] Move 
FILTER_LENGTH_LIMIT to config.plugin.mongodb
URL: https://github.com/apache/skywalking/pull/3820#discussion_r344475635
 
 

 ##
 File path: 
apm-sniffer/apm-sdk-plugin/mongodb-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mongodb/v3/support/MongoOperationHelper.java
 ##
 @@ -111,7 +128,8 @@ private static String getFilter(List writeRequestList) {
 } else if (request instanceof UpdateRequest) {
 params.append(((UpdateRequest) 
request).getFilter()).append(",");
 }
-if (params.length() > MongoConstants.FILTER_LENGTH_LIMIT) {
+final int filterLengthLimit = 
Config.Plugin.MongoDB.FILTER_LENGTH_LIMIT;
+if (filterLengthLimit > 0 && params.length() > filterLengthLimit) {
 
 Review comment:
   Negative value means all?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services