[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10801: Filter out unknown_cluster metric data in `elasticsearch-monitoring`
wu-sheng commented on code in PR #10801:
URL: https://github.com/apache/skywalking/pull/10801#discussion_r1193283888
##
oap-server/server-starter/src/main/resources/otel-rules/elasticsearch/elasticsearch-cluster.yaml:
##
@@ -34,39 +34,39 @@ metricPrefix: meter_elasticsearch_cluster
metricsRules:
# cluster health
- name: health_status
-exp: elasticsearch_cluster_health_status.valueEqual(1).sum(['cluster' ,
'color'])
+exp:
elasticsearch_cluster_health_status.tagNotEqual('cluster','unknown_cluster').valueEqual(1).sum(['cluster'
, 'color'])
Review Comment:
This `shouldn't` thing keeps happening in our demo env. We have reasons to
believe this is still a case.
Adding this to remove illegal data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10801: Filter out unknown_cluster metric data in `elasticsearch-monitoring`
wu-sheng commented on code in PR #10801:
URL: https://github.com/apache/skywalking/pull/10801#discussion_r1193281821
##
oap-server/server-starter/src/main/resources/otel-rules/elasticsearch/elasticsearch-cluster.yaml:
##
@@ -34,39 +34,39 @@ metricPrefix: meter_elasticsearch_cluster
metricsRules:
# cluster health
- name: health_status
-exp: elasticsearch_cluster_health_status.valueEqual(1).sum(['cluster' ,
'color'])
+exp:
elasticsearch_cluster_health_status.tagNotEqual('cluster','unknown_cluster').valueEqual(1).sum(['cluster'
, 'color'])
Review Comment:
Attaching the source codes of the exporter, just FYI to others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
