[GitHub] [skywalking] wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework
wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework URL: https://github.com/apache/skywalking/pull/3152#issuecomment-515032452 From the test report, it is same as before. After CI pass, I will merge this to the core. The new plugin is welcome, especially for HttpUrlConnection. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework
wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework URL: https://github.com/apache/skywalking/pull/3152#issuecomment-515031280 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework
wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework URL: https://github.com/apache/skywalking/pull/3152#issuecomment-515022762 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework
wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework URL: https://github.com/apache/skywalking/pull/3152#issuecomment-514904170 @ascrutae Please run our autotests, let's see whether this breaks anything. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework
wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework URL: https://github.com/apache/skywalking/pull/3152#issuecomment-514899637 @candyleer Updated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework
wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework URL: https://github.com/apache/skywalking/pull/3152#issuecomment-514868520 Look like javassist has an error. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework
wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework URL: https://github.com/apache/skywalking/pull/3152#issuecomment-514667356 /run ci This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework
wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework URL: https://github.com/apache/skywalking/pull/3152#issuecomment-514627067 @candyleer Have you tested Tomcat? And JDK 6? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework
wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework URL: https://github.com/apache/skywalking/pull/3152#issuecomment-514622739 > is this file (debug/org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.bootstrap.Interceptor_internal.class) committed by mistake? Yes. Removing it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework
wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework URL: https://github.com/apache/skywalking/pull/3152#issuecomment-514616127 > I have tested in bootstrap class and 3rd part class,both work well. I have a question,the classes in HIGH_PRIORITY_CLASSES still will be loaded by two classloader,right? but I debug found, eg.EnhancedInstance is loaded by bootstrap classloader in bootstrap interceptor (generated by InstanceMethodInterTemplate),and in normal InstMethodsInter it is loaded by application classloader .is it right? I think EnhancedInstance will be find in bootstrap classloader first . You do the tests quickly :) Thanks. To your question, from my understanding, when bootstrap instrumentation actived, EnhancedInstance should only be loaded in Bootstrap classloader. Otherwise, you will face `Class Cast Exception`, because you can't cat Bootstrap's EnhancedInstance to ApplicationClassLoader's EnhancedInstance. Load the generated class to class loader w/o initialization should be safe. That is why I use `#injectRaw` rather than `#inject`. This is my guess and understanding from test results, I used to try `#inject`, which cause that cast exception. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework
wu-sheng commented on issue #3152: Set up the bootstrap instrumentation plugin framework URL: https://github.com/apache/skywalking/pull/3152#issuecomment-514555323 This PR is ready to review and test. I have used it to instrument URL and HttpURLConnection successfully. But just a demo code, of course. Part of my test codes are posted here, https://gist.github.com/wu-sheng/25a8877971db089e196ada0fe4395813 In this PR, there is no real plugin. But further pull request is welcome. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
