[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-554243080 /run agent-plugin-test-2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-554136959 @viswaramamoorthy you need to solve the conflict. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-553914227 @viswaramamoorthy Please solve the conflicts and update to the master branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-552954726 >I am away from my computer for couple of days. If someone can take that final comment and fix, they can. Or I will send update in two days. Got it, we will wait. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-552930391 @viswaramamoorthy Code frozen is over. Please keep the update, after all checked, this could be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-552702534 @viswaramamoorthy Please follow the review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-552156046 /run agent-plugin-test-2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551339551 Please follow this, https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md#the-elapsed-time-list-of-plugins. And add your task into the fastest one when it is ready to be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551331107 Related to #3583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-550567372 @viswaramamoorthy The test is not hard, it is just demo codes with the real agent, and check the segments sent by the agent. You should understand it, it will help you to make sure the plugin is right. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
