[GitHub] [skywalking] wu-sheng commented on issue #3822: Add "Apdex" to OAL

2019-11-13 Thread GitBox 
wu-sheng commented on issue #3822: Add "Apdex" to OAL
URL: https://github.com/apache/skywalking/issues/3822#issuecomment-553687674
 
 
   Correct.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #3822: Add "Apdex" to OAL

2019-11-13 Thread GitBox 
wu-sheng commented on issue #3822: Add "Apdex" to OAL
URL: https://github.com/apache/skywalking/issues/3822#issuecomment-553435197
 
 
   Don't set 500 in the OAL, read the value from `apdex` function. Then you 
could read from CoreModuleConfig and using `DynamicConfigurationService` in 
`ConfigurationModule` by providing dynamic configuration. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #3822: Add "Apdex" to OAL

2019-11-09 Thread GitBox 
wu-sheng commented on issue #3822: Add "Apdex" to OAL
URL: https://github.com/apache/skywalking/issues/3822#issuecomment-552164590
 
 
   Notice, the appdex threshold should based on dynamic configuration and using 
JSON to provide default or service name based config.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services