[GitHub] [skywalking] wu-sheng commented on pull request #5156: Support alarm labels
wu-sheng commented on pull request #5156: URL: https://github.com/apache/skywalking/pull/5156#issuecomment-703231841 No update for a long time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5156: Support alarm labels
wu-sheng commented on pull request #5156: URL: https://github.com/apache/skywalking/pull/5156#issuecomment-664082342 For finishing this PR, you at least need to query-protocol PR merged and implement here. Also, considering you have enough time, please add an e2e check for the alarm case. You could take a reference from the e2e TTL, which is using the mesh telemetry to mock data, you could use the same way to mock the data which could trigger the alarm. Then you have everything you need to check. Related to #4530 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5156: Support alarm labels
wu-sheng commented on pull request #5156: URL: https://github.com/apache/skywalking/pull/5156#issuecomment-663985681 Please make sure CI passed first, then you need a query protocol PR and UI related PR. Right? FYI, we are closing the 8.1.0 release, so this PR will be blocked until we are ready to tagging the v8.1.0. So, make your time well planned, you have much time for query protocol and UI PRs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5156: Support alarm labels
wu-sheng commented on pull request #5156: URL: https://github.com/apache/skywalking/pull/5156#issuecomment-663949792 I know, you set label-values(s) in the entity. But my point is, this can't show up, unless the page changed, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5156: Support alarm labels
wu-sheng commented on pull request #5156: URL: https://github.com/apache/skywalking/pull/5156#issuecomment-663851152 > Invite you or an org to my fork repository ? or others way I am not asking for that, I am just speaking a status. You could update the branch by yourself. The point is, unless. you update the branch with master, we can't merge your PR. This is what I saw.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5156: Support alarm labels
wu-sheng commented on pull request #5156: URL: https://github.com/apache/skywalking/pull/5156#issuecomment-663831718 And your branch has not been sync from the master, and you don't allow us to sync. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
