[GitHub] [skywalking-cli] arugal commented on issue #10: [Feature] Support instance list command

2019-11-10 Thread GitBox 
arugal commented on issue #10: [Feature] Support instance  list command
URL: https://github.com/apache/skywalking-cli/pull/10#issuecomment-552208178
 
 
   I will submit a new PR to resolve conflicts.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking-cli] arugal commented on issue #10: [Feature] Support instance list command

2019-11-10 Thread GitBox 
arugal commented on issue #10: [Feature] Support instance  list command
URL: https://github.com/apache/skywalking-cli/pull/10#issuecomment-552196632
 
 
   @wu-sheng @kezhenxu94  please review


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking-cli] arugal commented on issue #10: [Feature] Support instance list command

2019-11-10 Thread GitBox 
arugal commented on issue #10: [Feature] Support instance  list command
URL: https://github.com/apache/skywalking-cli/pull/10#issuecomment-552191971
 
 
   > > First through the --service value search services. If the query result 
is not empty, get serviceId from the query result, or else take the --service 
value as the serviceId
   > 
   > If a service name is an integer, then you may face ambiguity issue.
   > Such as `swctl instance --service 123` meaning `service name = 123` or 
service id = `123`?
   > 
   > I would say `swctl instance --service 123` must be `service name = 123`. 
If id is expected to be supported, choose maybe `swctl instance --service-id 
123` or something we could discuss later.
   > 
   > CLI is a command line tool, I want it has clear meaning.
   
   Agree to provide ```--service-name``` and ```--service-id```.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking-cli] arugal commented on issue #10: [Feature] Support instance list command

2019-11-10 Thread GitBox 
arugal commented on issue #10: [Feature] Support instance  list command
URL: https://github.com/apache/skywalking-cli/pull/10#issuecomment-552189811
 
 
   > How do you know it is ID? Try to parse int?
   
   First through the name search services. If the query result is not empty, 
get serviceId from the query result, or else take the ```--service value``` as 
the serviceId


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking-cli] arugal commented on issue #10: [Feature] Support instance list command

2019-11-10 Thread GitBox 
arugal commented on issue #10: [Feature] Support instance  list command
URL: https://github.com/apache/skywalking-cli/pull/10#issuecomment-552186966
 
 
   @wu-sheng  Support both Name and ID in the latest code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking-cli] arugal commented on issue #10: [Feature] Support instance list command

2019-11-09 Thread GitBox 
arugal commented on issue #10: [Feature] Support instance  list command
URL: https://github.com/apache/skywalking-cli/pull/10#issuecomment-552167518
 
 
   help works like this:
   ```bash
   ./bin/swctl i ls -h 
   
   NAME:
  swctl instance list - List all available instance by given --service 
parameter
   
   USAGE:
  swctl instance list [command options] [arguments...]
   
   OPTIONS:
  --start TIME  query start TIME
  --end TIMEquery end TIME
  --service ID  query service ID
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services