[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #35: Add logging collect protocol
kezhenxu94 commented on a change in pull request #35:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/35#discussion_r533064756
##
File path: logging/Logging.proto
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.logging.v3";
+option csharp_namespace = "SkyWalking.NetworkProtocol.V3";
+option go_package = "skywalking/network/language/agent/v3";
+
+import "common/Common.proto";
+
+// Report collected logs into the OAP backend
+service LogReportService {
+// Recommend to report log data in a stream mode.
+// The service/instance/endpoint of the log could share the previous value
if they are not set.
+// Reporting the logs of same service in the batch mode could reduce the
network cost.
+rpc collect (stream LogData) returns (Commands) {
+}
+}
+
+// Log data is collected through file scratcher of agent.
+// Natively, Satellite provides various ways to collect logs.
+message LogData {
Review comment:
And, this timestamp is not the timestamp when they were generated,
instead, it’s when the logs are sent, which I don’t think is useful
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #35: Add logging collect protocol
kezhenxu94 commented on a change in pull request #35:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/35#discussion_r533064756
##
File path: logging/Logging.proto
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.logging.v3";
+option csharp_namespace = "SkyWalking.NetworkProtocol.V3";
+option go_package = "skywalking/network/language/agent/v3";
+
+import "common/Common.proto";
+
+// Report collected logs into the OAP backend
+service LogReportService {
+// Recommend to report log data in a stream mode.
+// The service/instance/endpoint of the log could share the previous value
if they are not set.
+// Reporting the logs of same service in the batch mode could reduce the
network cost.
+rpc collect (stream LogData) returns (Commands) {
+}
+}
+
+// Log data is collected through file scratcher of agent.
+// Natively, Satellite provides various ways to collect logs.
+message LogData {
Review comment:
And, this timestamp is not the timestamp when they were generated,
instead, it’s when the logs are sent, which I don’t think is useless
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #35: Add logging collect protocol
kezhenxu94 commented on a change in pull request #35:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/35#discussion_r533064756
##
File path: logging/Logging.proto
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.logging.v3";
+option csharp_namespace = "SkyWalking.NetworkProtocol.V3";
+option go_package = "skywalking/network/language/agent/v3";
+
+import "common/Common.proto";
+
+// Report collected logs into the OAP backend
+service LogReportService {
+// Recommend to report log data in a stream mode.
+// The service/instance/endpoint of the log could share the previous value
if they are not set.
+// Reporting the logs of same service in the batch mode could reduce the
network cost.
+rpc collect (stream LogData) returns (Commands) {
+}
+}
+
+// Log data is collected through file scratcher of agent.
+// Natively, Satellite provides various ways to collect logs.
+message LogData {
Review comment:
And, this timestamps is not the timestamp when they were generated,
instead, it’s when the logs are sent, which I don’t think is useless
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #35: Add logging collect protocol
kezhenxu94 commented on a change in pull request #35:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/35#discussion_r533063867
##
File path: logging/Logging.proto
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.logging.v3";
+option csharp_namespace = "SkyWalking.NetworkProtocol.V3";
+option go_package = "skywalking/network/language/agent/v3";
+
+import "common/Common.proto";
+
+// Report collected logs into the OAP backend
+service LogReportService {
+// Recommend to report log data in a stream mode.
+// The service/instance/endpoint of the log could share the previous value
if they are not set.
+// Reporting the logs of same service in the batch mode could reduce the
network cost.
+rpc collect (stream LogData) returns (Commands) {
+}
+}
+
+// Log data is collected through file scratcher of agent.
+// Natively, Satellite provides various ways to collect logs.
+message LogData {
Review comment:
Is it necessary? IMO most logs in reality already contain a timestamp.
Especially in JSON/YAML format, it’s rather easy to get the timestamp
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #35: Add logging collect protocol
kezhenxu94 commented on a change in pull request #35:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/35#discussion_r533063867
##
File path: logging/Logging.proto
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.logging.v3";
+option csharp_namespace = "SkyWalking.NetworkProtocol.V3";
+option go_package = "skywalking/network/language/agent/v3";
+
+import "common/Common.proto";
+
+// Report collected logs into the OAP backend
+service LogReportService {
+// Recommend to report log data in a stream mode.
+// The service/instance/endpoint of the log could share the previous value
if they are not set.
+// Reporting the logs of same service in the batch mode could reduce the
network cost.
+rpc collect (stream LogData) returns (Commands) {
+}
+}
+
+// Log data is collected through file scratcher of agent.
+// Natively, Satellite provides various ways to collect logs.
+message LogData {
Review comment:
Is it necessary? IMO most logs in reality already contain a timestamp
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #35: Add logging collect protocol
kezhenxu94 commented on a change in pull request #35:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/35#discussion_r533036195
##
File path: logging/Logging.proto
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.logging.v3";
+option csharp_namespace = "SkyWalking.NetworkProtocol.V3";
+option go_package = "skywalking/network/language/agent/v3";
+
+import "common/Common.proto";
+
+// Report collected logs into the OAP backend
+service LogReportService {
+// Recommend to report log data in a stream mode.
+// The service/instance/endpoint of the log could share the previous value
if they are not set.
+// Reporting the logs of same service in the batch mode could reduce the
network cost.
+rpc collect (stream LogData) returns (Commands) {
+}
+}
+
+// Log data is collected through file scratcher of agent.
+// Natively, Satellite provides various ways to collect logs.
+message LogData {
+// [Required] **Service**. Represents a set/group of workloads which
provide the same behaviours for incoming requests.
+//
+// The logic name represents the service. This would show as a separate
node in the topology.
+// The metrics analyzed from the spans, would be aggregated for this
entity as the service level.
+//
+// If this is not the first element of the streaming, use the previous
not-null name as the service name.
+string service = 1;
Review comment:
So that means `service` is always present? What's the point of "If this
is not the first element of the streaming, use the previous not-null name as
the service name.",
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a change in pull request #35: Add logging collect protocol
kezhenxu94 commented on a change in pull request #35:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/35#discussion_r533034878
##
File path: logging/Logging.proto
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+option java_package = "org.apache.skywalking.apm.network.logging.v3";
+option csharp_namespace = "SkyWalking.NetworkProtocol.V3";
+option go_package = "skywalking/network/language/agent/v3";
+
+import "common/Common.proto";
+
+// Report collected logs into the OAP backend
+service LogReportService {
+// Recommend to report log data in a stream mode.
+// The service/instance/endpoint of the log could share the previous value
if they are not set.
+// Reporting the logs of same service in the batch mode could reduce the
network cost.
+rpc collect (stream LogData) returns (Commands) {
+}
+}
+
+// Log data is collected through file scratcher of agent.
+// Natively, Satellite provides various ways to collect logs.
+message LogData {
+// [Required] **Service**. Represents a set/group of workloads which
provide the same behaviours for incoming requests.
+//
+// The logic name represents the service. This would show as a separate
node in the topology.
+// The metrics analyzed from the spans, would be aggregated for this
entity as the service level.
+//
+// If this is not the first element of the streaming, use the previous
not-null name as the service name.
+string service = 1;
Review comment:
Is this required? I think you meant only the first element of the stream
is non-null, otherwise it's null?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
