[GitHub] [skywalking-kubernetes] hanahmily commented on issue #21: modify role to clusterrole

2019-10-21 Thread GitBox 
hanahmily commented on issue #21: modify role to clusterrole
URL: 
https://github.com/apache/skywalking-kubernetes/pull/21#issuecomment-544811125
 
 
   @innerpeacez after some typo is fixed I think it's fine to merge it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking-kubernetes] hanahmily commented on issue #21: modify role to clusterrole

2019-10-19 Thread GitBox 
hanahmily commented on issue #21: modify role to clusterrole
URL: 
https://github.com/apache/skywalking-kubernetes/pull/21#issuecomment-544210430
 
 
   Most of it looks great. Thanks @innerpeacez. We leverage oap permission here 
is because envoy recevier intends to access API server get information across 
the entire cluster. So a more fine grain method is to identify whether user 
opens this receiver then grant oap a appropriate permission. Well, this way is 
much simpler for our user. Can you document it in README. md


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services