[GitHub] [skywalking-python] alonelaval commented on pull request #9: Add requests plugin

2020-06-09 Thread GitBox


alonelaval commented on pull request #9:
URL: https://github.com/apache/skywalking-python/pull/9#issuecomment-641136956


   > @alonelaval I've fixed the test for you, although the `refs` verification 
is missing, it's missed from the first place so I'll add it in another PR, 
thanks for the plugin :)
   
   thanks。。。My network is sososo bad..docker testCase cann‘t run..



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking-python] alonelaval commented on pull request #9: Add requests plugin

2020-06-07 Thread GitBox


alonelaval commented on pull request #9:
URL: https://github.com/apache/skywalking-python/pull/9#issuecomment-640236700


   ok, what can i do?
   
   > Hi @alonelaval , we plan to release the first version of 
SkyWalking-Python, if you hope this plugin to be included in the first version, 
please let me know and let's review to make it possible to be included in the 
first version, thanks :)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking-python] alonelaval commented on pull request #9: add requests plugin

2020-06-04 Thread GitBox


alonelaval commented on pull request #9:
URL: https://github.com/apache/skywalking-python/pull/9#issuecomment-638895695


   > @alonelaval thanks for contributing, I'll review this PR by this weekend
   
   ok



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org