[GitHub] wu-sheng commented on issue #1200: [New concept] Proposal for Manual Span

2018-05-29 Thread GitBox
wu-sheng commented on issue #1200: [New concept] Proposal for Manual Span
URL: 
https://github.com/apache/incubator-skywalking/issues/1200#issuecomment-393035168
 
 
   Closing this, try to use #1284


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1200: [New concept] Proposal for Manual Span

2018-05-21 Thread GitBox
wu-sheng commented on issue #1200: [New concept] Proposal for Manual Span
URL: 
https://github.com/apache/incubator-skywalking/issues/1200#issuecomment-390591290
 
 
   I will remove the milestone, I have finish some prototype codes of 
this(branch manual-span), also make context-switchable(branch 
context-switchable)
   
   Manual span APIs looks like every complex to use, and cost a lot to wait for 
the segment finish status.
   
   So I have some doubts whether we should provide this. I will wait for more 
explicit requirements for both of them.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1200: [New concept] Proposal for Manual Span

2018-05-18 Thread GitBox
wu-sheng commented on issue #1200: [New concept] Proposal for Manual Span
URL: 
https://github.com/apache/incubator-skywalking/issues/1200#issuecomment-390372823
 
 
   @ascrutae You should know, RuntimeContext is for the same thread too. Why 
does this help you? Also, I think that should be discussed in a separated issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1200: [New concept] Proposal for Manual Span

2018-05-18 Thread GitBox
wu-sheng commented on issue #1200: [New concept] Proposal for Manual Span
URL: 
https://github.com/apache/incubator-skywalking/issues/1200#issuecomment-390371383
 
 
   hi, @liuhaoyang @ascrutae @candyleer @peng-yongsheng @hanahmily I will 
finish this concept in beta2 for making the Java API can support more scenarios 
in async module library.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services