[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-391629031 @SevenPointOld I think you miss add your README to incubating features menu.  Also, you should consider to add a section in Chinese document: https://github.com/apache/incubator-skywalking/blob/master/docs/README_ZH.md The title should be `孵化特性`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-391550932 Merged, hope you could provide a blog to tell people to use it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-391399804 @SevenPointOld I will merge this soon. Do you consider to provide a blog about this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-391246857 @ascrutae Do you have any suggestion for this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-390821301 @SevenPointOld Could you finish this PR soon? I look forward to merge this pr into beta2 release. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389747821 > It's hard to transfer the only one, because of the Spring AntPathMatcher import some util class, the other util class also import others, but they all belong to a same package, can I transfer the whole package org.springframework.util? exclude child package of course @SevenPointOld You can do a full package transfer, or rewrite the match logic. That is your decision. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389747694 > @SevenPointOld 您的 classpath 里并没有 skywalking-plugin.def，请问 TraceIgnoreExtendService 是如何被 SkyWalking 加载的呢？ @brucewu-fly plugin.def is for plugin definition, such as: dubbo, sofa plugin. Service initialization is based on other mechanism. See `org.apache.skywalking.apm.agent.core.boot.BootService` file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389537884 Master codes version updated. Please follow. And resolve the License issue ASAP. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389450553 @SevenPointOld I think should add in this plugin module. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389426446 @SevenPointOld please use shade plugin to transfer this class from spring denpendency, rather then use code copy. like this https://maven.apache.org/plugins/maven-shade-plugin/examples/class-relocation.html Please notice, only transfer the only one you need. Based on this, I can trust on License. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
