[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring
wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-391632726 Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring
wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-390590807 @candyleer @ascrutae I have just understood Hytrix 's way. Look like the only way to support is, providing three segments for incoming request, request process and callback. The disadvantage is the service dependency map doesn't work, because multiple threads means haven't direct dependencies, anything else should be OK. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring
wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-390457611 @candyleer Yes, I used to want to fo this. But it is too complex, hard to explain the APIs. Try to have some new idea. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring
wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-390457285 I got into some trouble to implement manual span. Have to reconsider it. API is hard to review and make sure it works as expected. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring
wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-390378766 @candyleer I want to be clear, Xin mentioned about current module can't support, right expression is can't use current module to build right trace segments, which match backend analysis. It supports to build trace, but will limit backend capabilities. So that is why manual span is required. If you need more explanation, please let me know. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring
wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-390371434 @ascrutae I will finish #1200 in these days, hope can help you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring
wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-389852363 Then @ascrutae , please consider to refactor this plugin, as we just did for gRPC in beta. I think the old interceptor points have same issue. Some time, they are running in different thread by schedule mechanism. Also include #1236 , I guess they are same. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring
wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-389849692 @candyleer Do you need me to ping Xin for help? Or you want to try by yourself? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services