[GitHub] wu-sheng commented on issue #1708: Design for web performance's data structure.

2018-12-12 Thread GitBox
wu-sheng commented on issue #1708: Design for web performance's data structure.
URL: 
https://github.com/apache/incubator-skywalking/issues/1708#issuecomment-446839175
 
 
   Any update for this? @kkroy-zs If still don't have an update in next two 
weeks, I will remove the milestone.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1708: Design for web performance's data structure.

2018-09-30 Thread GitBox
wu-sheng commented on issue #1708: Design for web performance's data structure.
URL: 
https://github.com/apache/incubator-skywalking/issues/1708#issuecomment-425723487
 
 
   We definitely welcome all kinds of contributions. Consider priority and 
workloads. Let's make this work step by step.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1708: Design for web performance's data structure.

2018-09-27 Thread GitBox
wu-sheng commented on issue #1708: Design for web performance's data structure.
URL: 
https://github.com/apache/incubator-skywalking/issues/1708#issuecomment-425119621
 
 
   > Great work! In my own opinion, @kkroy-zs 's work is going to open up a new 
and important area for skywalking.
   I have to say the data of the webpage is much more complicated than backend. 
The resource request, such as ajax request, is similar to backend service and 
could be easily handled by oap-server. But the page performance data, such as 
page loading time, is a very new world for skywallking. We should make some 
major changes to receive such data.
   
   @hanahmily Yes. Changes are definitely required. But I think core is easy to 
extend to support new source/scope. But I totally agree with you, design those 
source/scope is a challenge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1708: Design for web performance's data structure.

2018-09-27 Thread GitBox
wu-sheng commented on issue #1708: Design for web performance's data structure.
URL: 
https://github.com/apache/incubator-skywalking/issues/1708#issuecomment-424977824
 
 
   When you are ready, post the draft here. Thanks. Interesting proposal.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1708: Design for web performance's data structure.

2018-09-26 Thread GitBox
wu-sheng commented on issue #1708: Design for web performance's data structure.
URL: 
https://github.com/apache/incubator-skywalking/issues/1708#issuecomment-424756265
 
 
   @liuhaoyang Do you have any metric suggestion? I have known you have some 
experiences about this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1708: Design for web performance's data structure.

2018-09-26 Thread GitBox
wu-sheng commented on issue #1708: Design for web performance's data structure.
URL: 
https://github.com/apache/incubator-skywalking/issues/1708#issuecomment-424708373
 
 
   > I have reservations about using gRPC in javascript. We have done this 
before, but we have encountered compatibility issues with gRPC. In our 
practice, the performance of http is enough.
   
   @liuhaoyang Sorry, I don't mean using gRPC as service. I am OK with HTTP, 
and think it is good enough too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1708: Design for web performance's data structure.

2018-09-26 Thread GitBox
wu-sheng commented on issue #1708: Design for web performance's data structure.
URL: 
https://github.com/apache/incubator-skywalking/issues/1708#issuecomment-424707858
 
 
   For backend performance, read our document to get some idea
   1. Our backend analysis based on OAL, 
https://github.com/apache/incubator-skywalking/blob/master/docs/en/concepts-and-designs/oal.md
 @kkroy-zs It is easy to understand, I think.
   1. For the browser side, I recommend you to read the scope definition doc, 
https://github.com/apache/incubator-skywalking/blob/master/docs/en/concepts-and-designs/scope-definitions.md
 . We need to define the browser scopes first.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1708: Design for web performance's data structure.

2018-09-26 Thread GitBox
wu-sheng commented on issue #1708: Design for web performance's data structure.
URL: 
https://github.com/apache/incubator-skywalking/issues/1708#issuecomment-424702752
 
 
   FYI @liuhaoyang @terrymanu @terrymanu You may begin to think about database 
**Source** and **Metric Service** too. Count on you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1708: Design for web performance's data structure.

2018-09-26 Thread GitBox
wu-sheng commented on issue #1708: Design for web performance's data structure.
URL: 
https://github.com/apache/incubator-skywalking/issues/1708#issuecomment-424702048
 
 
   The first step, we need to design the **source** and **gRPC service** for 
browser side. @kkroy-zs Do you have something in mind about which services 
backend provided to receive your metric? That relates to which kinds of data 
you could uplink in single one request, and which kinds of data should be in a 
group? I am looking forward to your proposal and idea.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wu-sheng commented on issue #1708: Design for web performance's data structure.

2018-09-26 Thread GitBox
wu-sheng commented on issue #1708: Design for web performance's data structure.
URL: 
https://github.com/apache/incubator-skywalking/issues/1708#issuecomment-424701318
 
 
   Wow!! This is a very big forward step for SkyWalking. @peng-yongsheng 
@hanahmily @liuhaoyang @ascrutae I invite all of you into this ticket. Let's 
find out which source and what kind of protocol we can provide for the browser 
side.
   
   This fits version6 design core very much. We finally meet the extension at 
Browser.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services