Re: [I] [Bug] skywalking agent [skywalking]
wu-sheng commented on issue #11675: URL: https://github.com/apache/skywalking/issues/11675#issuecomment-1867507853 That is why your codes could be traced and monitored. Your codes are changed by the agent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
wangkang4 commented on issue #11675: URL: https://github.com/apache/skywalking/issues/11675#issuecomment-1867478079 > > > > Hello, does skywalking support arthas' retransform command? After the configuration of agent.is_cache_enhanced_class and agent.class_cache_mode is enabled, the redefine command is successfully executed, but the retransform command fails. Using the jad command, you found that skywalking added properties and methods to the class. > > > > > > > > > IIRC, IS_CACHE_ENHANCED_CLASS flag has been removed since SkyWalking Agent 9.0 > > > > > > How to modify skywalking javaagent to support arthas hot load class command, is there a case code? > > As you may notice in [apache/skywalking-java#659](https://github.com/apache/skywalking-java/pull/659), we are still working on this topic. I suppose after that PR, we may stabilize this feature. > > Feel free to test [this PR](https://github.com/apache/skywalking-java/pull/659) for your use cases. Feedback is welcome. 为什么使用skywalking的javaagent会生成很多带有$的类？使用arthas的trace命令查看调用链，发现执行的都是那些生成的代理类.   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
wangkang4 commented on issue #11675: URL: https://github.com/apache/skywalking/issues/11675#issuecomment-1867201628 Is arthas' redefine and retransform commands not currently supported for modifying the target class? Because skywalking's javaagent adds a few new methods to the target class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
lujiajing1126 commented on issue #11675: URL: https://github.com/apache/skywalking/issues/11675#issuecomment-1867181760 > > > Hello, does skywalking support arthas' retransform command? After the configuration of agent.is_cache_enhanced_class and agent.class_cache_mode is enabled, the redefine command is successfully executed, but the retransform command fails. Using the jad command, you found that skywalking added properties and methods to the class. > > > > > > IIRC, IS_CACHE_ENHANCED_CLASS flag has been removed since SkyWalking Agent 9.0 > > How to modify skywalking javaagent to support arthas hot load class command, is there a case code? As you may notice in https://github.com/apache/skywalking-java/pull/659, we are still working on this topic. I suppose after that PR, we may stabilize this feature. Feel free to test [this PR](https://github.com/apache/skywalking-java/pull/659) for your use cases. Feedback is welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
wangkang4 commented on issue #11675: URL: https://github.com/apache/skywalking/issues/11675#issuecomment-1867171301 > > Hello, does skywalking support arthas' retransform command? After the configuration of agent.is_cache_enhanced_class and agent.class_cache_mode is enabled, the redefine command is successfully executed, but the retransform command fails. Using the jad command, you found that skywalking added properties and methods to the class. > > IIRC, IS_CACHE_ENHANCED_CLASS flag has been removed since SkyWalking Agent 9.0 How to modify skywalking javaagent to support arthas hot load class command, is there a case code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
wangkang4 commented on issue #11675: URL: https://github.com/apache/skywalking/issues/11675#issuecomment-1867168028 arthas' hot-load class file commands, such as redefine and retransform, are not currently supported by the services monitored by skywalking, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
lujiajing1126 commented on issue #11675: URL: https://github.com/apache/skywalking/issues/11675#issuecomment-1867152384 > Hello, does skywalking support arthas' retransform command? After the configuration of agent.is_cache_enhanced_class and agent.class_cache_mode is enabled, the redefine command is successfully executed, but the retransform command fails. Using the jad command, you found that skywalking added properties and methods to the class. IIRC, IS_CACHE_ENHANCED_CLASS flag has been removed since SkyWalking Agent 9.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
wu-sheng commented on issue #11675: URL: https://github.com/apache/skywalking/issues/11675#issuecomment-1867143098 We don't support it officially. As you can see on https://github.com/apache/skywalking/issues/11651, someone may have an interest in doing as best as they can. You could try that PR version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
wangkang4 commented on issue #11675: URL: https://github.com/apache/skywalking/issues/11675#issuecomment-1867128804 Hello, does skywalking support arthas' retransform command? After the configuration of agent.is_cache_enhanced_class and agent.class_cache_mode is enabled, the redefine command is successfully executed, but the retransform command fails. Using the jad command, you found that skywalking added properties and methods to the class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
wu-sheng commented on issue #11675: URL: https://github.com/apache/skywalking/issues/11675#issuecomment-1862314209 follow https://github.com/apache/skywalking/issues/11651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
wu-sheng closed issue #11675: [Bug] skywalking agent URL: https://github.com/apache/skywalking/issues/11675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
wu-sheng commented on issue #11675: URL: https://github.com/apache/skywalking/issues/11675#issuecomment-1862313280 duplicated reported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] skywalking agent [skywalking]
wangkang4 opened a new issue, #11675: URL: https://github.com/apache/skywalking/issues/11675 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component Java Agent (apache/skywalking-java) ### What happened java agent version：9.0.0 arthas：3.7.1 The arthas retransform command is used to hot-load the class file. A retransform error message is displayed. java.lang.UnsupportedOperationException: class redefinition failed: attempted to change superclass or interfaces ### What you expected to happen The arthas hot-load class file function is not affected. ### How to reproduce  ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
