Re: [PR] Add support for amqp [skywalking-go]
CodePrometheus commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1952947913 > Are you using a HTTP handler to trigger consumer? I think you can't create another entry span when the first one not finished. You will need a local span in the middle, or use a timer to trigger consuming periodically. Thanks, after several attempts, I think it should be able to meet our expectations. https://github.com/apache/skywalking-go/assets/66550292/fed391a3-f73e-4288-ab3e-10557d6d1574;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for amqp [skywalking-go]
wu-sheng commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1935577697 Are you using a HTTP handler to trigger consumer? I think you can't create another entry span when the first one not finished. You will need a local span in the middle, or use a timer to trigger consuming periodically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for amqp [skywalking-go]
CodePrometheus commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1935516907 Thank you for the reminder, Teacher Wu. I checked that the context between the producer and consumer is connected, as shown in Figure 1. However, when I introduce an HTTP trigger, as shown in Figure 2, it appears that the amqp entrySpan `Amqp/...` is overriding the `GET:/consumer ` http entrySpan, I'm still trying to figure it out https://github.com/apache/skywalking-go/assets/66550292/ac7f4f98-4542-43c0-8858-f5c4d5058203;> https://github.com/apache/skywalking-go/assets/66550292/b7a62653-e5b1-4832-9523-9793b22bff69;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for amqp [skywalking-go]
wu-sheng commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1930786342 This is trace broken due to lack od reference of span for the entry(consumer) span. Did you check context carrier injected into message header/metadata, and successfully extracted from it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for amqp [skywalking-go]
CodePrometheus commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1930127661 terribly sorry, I've been stuck on a problem for a while, When I was dealing with consumer span, something didn't look right and there was no connection. I'm still trying to figure it out https://github.com/apache/skywalking-go/assets/66550292/a39c9c51-1589-4844-a2ee-571787f7101a;> https://github.com/apache/skywalking-go/assets/66550292/c8dc9e60-7211-488c-9cec-c588caa9b01c;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for amqp [skywalking-go]
mrproliu commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1926857460 Please help to fix the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for amqp [skywalking-go]
CodePrometheus commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1917682818 I used `SkyWalkingDynamicField` to deal with the peer value problem, and my locally env has passed the ./run.sh amqp test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for amqp [skywalking-go]
CodePrometheus commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1913632299 copy that, I'll try again locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for amqp [skywalking-go]
wu-sheng commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1913624608 I think that depends on the codes. `amqp` is a DNS name, if the codes have resolved it, and you use it as peer, then, it is an IP as always. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for amqp [skywalking-go]
CodePrometheus commented on PR #165:
URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1913623178
Ok, I'll update the dos.
Since a new service was added to docker-composer this time, I found out
through CI
`reason: [peer]: expected=>{amqp:5672}, actual=>{172.18.0.3:5672}`
My configuration is
```shell
amqp:
image: rabbitmq:3.11.14-management
hostname: amqp
...
```
Dear teachers, I would like to ask if I have any configuration errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add support for amqp [skywalking-go]
wu-sheng commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1913613023 @CodePrometheus Plugin docs should be updated. `support-plugins.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for amqp [skywalking-go]
wu-sheng commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1913612246 @mrproliu is on vacation, this PR will be reviewed after he is back. Please wait for next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for amqp [skywalking-go]
CodePrometheus commented on PR #165: URL: https://github.com/apache/skywalking-go/pull/165#issuecomment-1913609875 Ref https://github.com/apache/skywalking/pull/11838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
