[GitHub] SkyWalkingRobot commented on issue #2035: Support canal plugin
SkyWalkingRobot commented on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-446877875 Here is the [test report](http://github.com/SkywalkingTest/agent-integration-test-report/tree/master/2018/12/WithLin/testReport-master-2018-12-13-15-56.md) and [validate logs](http://35.227.88.23:49001/job/skywalking-agent-automated-testing/229/artifact/skywalking-agent-testcases/workspace/logs/validate-2018-12-13-15-56.log) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode
coveralls commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode URL: https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-446886229 [](https://coveralls.io/builds/20611094) Coverage decreased (-0.002%) to 14.321% when pulling **523a5d41a984b9c90c8c597ea0806a85c49e382a on ASCE1885:master** into **dfe2b08599d37f4f6fb0fdd53763565c9918ca2c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JaredTan95 opened a new pull request #2041: modify code style
JaredTan95 opened a new pull request #2041: modify code style URL: https://github.com/apache/incubator-skywalking/pull/2041 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bug fix - Bug description. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #2041: modify code style
coveralls commented on issue #2041: modify code style URL: https://github.com/apache/incubator-skywalking/pull/2041#issuecomment-446977097 [](https://coveralls.io/builds/20615817) Coverage remained the same at 14.323% when pulling **b0bc7c00c7c237601ad281c8bb2f7db9c9df200d on JaredTan95:modify-style** into **dfe2b08599d37f4f6fb0fdd53763565c9918ca2c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-skywalking] branch master updated: modify code style (#2041)
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 2f37158 modify code style (#2041)
2f37158 is described below
commit 2f37158e4112a081169a1f97e4afb3847633b262
Author: Jared Tan
AuthorDate: Thu Dec 13 21:59:17 2018 +0800
modify code style (#2041)
* modify code style
* ci
---
.../pom.xml | 4 ++--
.../plugin/consul/ClusterModuleConsulConfig.java | 0
.../plugin/consul/ClusterModuleConsulProvider.java | 20 +---
.../cluster/plugin/consul/ConsulCoordinator.java | 20 +---
...ywalking.oap.server.library.module.ModuleProvider | 0
oap-server/server-cluster-plugin/pom.xml | 4 ++--
oap-server/server-starter/pom.xml| 4 ++--
7 files changed, 32 insertions(+), 20 deletions(-)
diff --git a/oap-server/server-cluster-plugin/cluster_consul_plugin/pom.xml
b/oap-server/server-cluster-plugin/cluster-consul-plugin/pom.xml
similarity index 97%
rename from oap-server/server-cluster-plugin/cluster_consul_plugin/pom.xml
rename to oap-server/server-cluster-plugin/cluster-consul-plugin/pom.xml
index d9e6ed9..8718135 100644
--- a/oap-server/server-cluster-plugin/cluster_consul_plugin/pom.xml
+++ b/oap-server/server-cluster-plugin/cluster-consul-plugin/pom.xml
@@ -27,7 +27,7 @@
4.0.0
-cluster_consul_plugin
+cluster-consul-plugin
jar
@@ -52,4 +52,4 @@
-
\ No newline at end of file
+
diff --git
a/oap-server/server-cluster-plugin/cluster_consul_plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulConfig.java
b/oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulConfig.java
similarity index 100%
rename from
oap-server/server-cluster-plugin/cluster_consul_plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulConfig.java
rename to
oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulConfig.java
diff --git
a/oap-server/server-cluster-plugin/cluster_consul_plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
b/oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
similarity index 78%
rename from
oap-server/server-cluster-plugin/cluster_consul_plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
rename to
oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
index cbafca7..65e407f 100644
---
a/oap-server/server-cluster-plugin/cluster_consul_plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
+++
b/oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
@@ -20,12 +20,20 @@ package
org.apache.skywalking.oap.server.cluster.plugin.consul;
import com.google.common.net.HostAndPort;
import com.orbitz.consul.Consul;
-import java.util.*;
import org.apache.skywalking.oap.server.core.CoreModule;
-import org.apache.skywalking.oap.server.core.cluster.*;
-import org.apache.skywalking.oap.server.library.module.*;
-import org.apache.skywalking.oap.server.library.util.*;
-import org.slf4j.*;
+import org.apache.skywalking.oap.server.core.cluster.ClusterModule;
+import org.apache.skywalking.oap.server.core.cluster.ClusterNodesQuery;
+import org.apache.skywalking.oap.server.core.cluster.ClusterRegister;
+import org.apache.skywalking.oap.server.library.module.ModuleConfig;
+import org.apache.skywalking.oap.server.library.module.ModuleProvider;
+import org.apache.skywalking.oap.server.library.module.ModuleStartException;
+import
org.apache.skywalking.oap.server.library.module.ServiceNotProvidedException;
+import org.apache.skywalking.oap.server.library.util.Address;
+import
org.apache.skywalking.oap.server.library.util.ConnectStringParseException;
+import org.apache.skywalking.oap.server.library.util.ConnectUtils;
+
+import java.util.ArrayList;
+import java.util.List;
/**
* Use consul to manage all service instances in SkyWalking cluster.
@@ -34,8 +42,6 @@ import org.slf4j.*;
*/
public class ClusterModuleConsulProvider extends ModuleProvider {
-private static final Logger logger =
LoggerFactory.getLogger(ClusterModuleConsulProvider.class);
-
private final ClusterModuleConsulC
[GitHub] JaredTan95 closed pull request #2041: modify code style
JaredTan95 closed pull request #2041: modify code style
URL: https://github.com/apache/incubator-skywalking/pull/2041
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/oap-server/server-cluster-plugin/cluster_consul_plugin/pom.xml
b/oap-server/server-cluster-plugin/cluster-consul-plugin/pom.xml
similarity index 97%
rename from oap-server/server-cluster-plugin/cluster_consul_plugin/pom.xml
rename to oap-server/server-cluster-plugin/cluster-consul-plugin/pom.xml
index d9e6ed9a54..8718135710 100644
--- a/oap-server/server-cluster-plugin/cluster_consul_plugin/pom.xml
+++ b/oap-server/server-cluster-plugin/cluster-consul-plugin/pom.xml
@@ -27,7 +27,7 @@
4.0.0
-cluster_consul_plugin
+cluster-consul-plugin
jar
@@ -52,4 +52,4 @@
-
\ No newline at end of file
+
diff --git
a/oap-server/server-cluster-plugin/cluster_consul_plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulConfig.java
b/oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulConfig.java
similarity index 100%
rename from
oap-server/server-cluster-plugin/cluster_consul_plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulConfig.java
rename to
oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulConfig.java
diff --git
a/oap-server/server-cluster-plugin/cluster_consul_plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
b/oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
similarity index 78%
rename from
oap-server/server-cluster-plugin/cluster_consul_plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
rename to
oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
index cbafca76a1..65e407f490 100644
---
a/oap-server/server-cluster-plugin/cluster_consul_plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
+++
b/oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
@@ -20,12 +20,20 @@
import com.google.common.net.HostAndPort;
import com.orbitz.consul.Consul;
-import java.util.*;
import org.apache.skywalking.oap.server.core.CoreModule;
-import org.apache.skywalking.oap.server.core.cluster.*;
-import org.apache.skywalking.oap.server.library.module.*;
-import org.apache.skywalking.oap.server.library.util.*;
-import org.slf4j.*;
+import org.apache.skywalking.oap.server.core.cluster.ClusterModule;
+import org.apache.skywalking.oap.server.core.cluster.ClusterNodesQuery;
+import org.apache.skywalking.oap.server.core.cluster.ClusterRegister;
+import org.apache.skywalking.oap.server.library.module.ModuleConfig;
+import org.apache.skywalking.oap.server.library.module.ModuleProvider;
+import org.apache.skywalking.oap.server.library.module.ModuleStartException;
+import
org.apache.skywalking.oap.server.library.module.ServiceNotProvidedException;
+import org.apache.skywalking.oap.server.library.util.Address;
+import
org.apache.skywalking.oap.server.library.util.ConnectStringParseException;
+import org.apache.skywalking.oap.server.library.util.ConnectUtils;
+
+import java.util.ArrayList;
+import java.util.List;
/**
* Use consul to manage all service instances in SkyWalking cluster.
@@ -34,8 +42,6 @@
*/
public class ClusterModuleConsulProvider extends ModuleProvider {
-private static final Logger logger =
LoggerFactory.getLogger(ClusterModuleConsulProvider.class);
-
private final ClusterModuleConsulConfig config;
private Consul client;
diff --git
a/oap-server/server-cluster-plugin/cluster_consul_plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ConsulCoordinator.java
b/oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ConsulCoordinator.java
similarity index 85%
rename from
oap-server/server-cluster-plugin/cluster_consul_plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ConsulCoordinator.java
rename to
oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ConsulCoordinator.java
index bff8f24682..7cf73
[GitHub] wu-sheng commented on issue #2041: modify code style
wu-sheng commented on issue #2041: modify code style URL: https://github.com/apache/incubator-skywalking/pull/2041#issuecomment-446994227 @JaredTan95 Please set the milestone for every pull request, especially the one got merged. Otherwise, it will be lost in the change log. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2041: modify code style
wu-sheng commented on issue #2041: modify code style URL: https://github.com/apache/incubator-skywalking/pull/2041#issuecomment-446994452 I am moving this into 6.0.0-beta release since it will happen soon in branch `6-beta-release`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-skywalking] branch 6-beta-release updated (dfe2b08 -> 2f37158)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch 6-beta-release
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git.
from dfe2b08 [OAP Server][Cluster Plugin] Provide consul cluster plugin
(#2036)
add 2f37158 modify code style (#2041)
No new revisions were added by this update.
Summary of changes:
.../pom.xml | 4 ++--
.../plugin/consul/ClusterModuleConsulConfig.java | 0
.../plugin/consul/ClusterModuleConsulProvider.java | 20 +---
.../cluster/plugin/consul/ConsulCoordinator.java | 20 +---
...ywalking.oap.server.library.module.ModuleProvider | 0
oap-server/server-cluster-plugin/pom.xml | 4 ++--
oap-server/server-starter/pom.xml| 4 ++--
7 files changed, 32 insertions(+), 20 deletions(-)
rename oap-server/server-cluster-plugin/{cluster_consul_plugin =>
cluster-consul-plugin}/pom.xml (97%)
rename oap-server/server-cluster-plugin/{cluster_consul_plugin =>
cluster-consul-plugin}/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulConfig.java
(100%)
rename oap-server/server-cluster-plugin/{cluster_consul_plugin =>
cluster-consul-plugin}/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
(78%)
rename oap-server/server-cluster-plugin/{cluster_consul_plugin =>
cluster-consul-plugin}/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ConsulCoordinator.java
(85%)
rename oap-server/server-cluster-plugin/{cluster_consul_plugin =>
cluster-consul-plugin}/src/main/resources/META-INF/services/org.apache.skywalking.oap.server.library.module.ModuleProvider
(100%)
[GitHub] ZhHong opened a new pull request #2042: osName and hostName values are reversed
ZhHong opened a new pull request #2042: osName and hostName values are reversed URL: https://github.com/apache/incubator-skywalking/pull/2042 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bug fix - Bug description. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2042: osName and hostName values are reversed
wu-sheng commented on issue #2042: osName and hostName values are reversed URL: https://github.com/apache/incubator-skywalking/pull/2042#issuecomment-447001642 FYI @peng-yongsheng This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2042: osName and hostName values are reversed
wu-sheng commented on issue #2042: osName and hostName values are reversed URL: https://github.com/apache/incubator-skywalking/pull/2042#issuecomment-447002265 I am moving this to beta release too, to avoid protocol issue. @ZhHong Thanks very much to point this out. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JaredTan95 commented on issue #2041: modify code style
JaredTan95 commented on issue #2041: modify code style URL: https://github.com/apache/incubator-skywalking/pull/2041#issuecomment-447004020 > I am moving this into 6.0.0-beta release since it will happen soon in branch `6-beta-release`. OK,Got it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] admln opened a new issue #2043: doubt about grpc agent
admln opened a new issue #2043: doubt about grpc agent URL: https://github.com/apache/incubator-skywalking/issues/2043 Hello, I used the Grpc framework，client connect server, The IP, namespace, proto interface are the same, ideally should be a client to the server, why it is divided into the two lines? ? ?  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #2042: osName and hostName values are reversed
coveralls commented on issue #2042: osName and hostName values are reversed URL: https://github.com/apache/incubator-skywalking/pull/2042#issuecomment-447016760 [](https://coveralls.io/builds/20617804) Coverage decreased (-0.002%) to 14.321% when pulling **1a3fa72d6037d5ed318c9a444c95efde38f20f81 on ZhHong:master** into **2f37158e4112a081169a1f97e4afb3847633b262 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #2042: osName and hostName values are reversed
wu-sheng closed pull request #2042: osName and hostName values are reversed
URL: https://github.com/apache/incubator-skywalking/pull/2042
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/oap-server/server-receiver-plugin/skywalking-register-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/register/provider/handler/v5/rest/InstanceDiscoveryServletHandler.java
b/oap-server/server-receiver-plugin/skywalking-register-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/register/provider/handler/v5/rest/InstanceDiscoveryServletHandler.java
index e000a33851..d21b6f4ac6 100644
---
a/oap-server/server-receiver-plugin/skywalking-register-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/register/provider/handler/v5/rest/InstanceDiscoveryServletHandler.java
+++
b/oap-server/server-receiver-plugin/skywalking-register-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/register/provider/handler/v5/rest/InstanceDiscoveryServletHandler.java
@@ -70,8 +70,8 @@ public InstanceDiscoveryServletHandler(ModuleManager
moduleManager) {
JsonObject osInfoJson = instance.get(OS_INFO).getAsJsonObject();
ServiceInstanceInventory.AgentOsInfo agentOsInfo = new
ServiceInstanceInventory.AgentOsInfo();
-agentOsInfo.setHostname(osInfoJson.get("osName").getAsString());
-agentOsInfo.setOsName(osInfoJson.get("hostName").getAsString());
+agentOsInfo.setHostname(osInfoJson.get("hostName").getAsString());
+agentOsInfo.setOsName(osInfoJson.get("osName").getAsString());
agentOsInfo.setProcessNo(osInfoJson.get("processId").getAsInt());
JsonArray ipv4s = osInfoJson.get("ipv4s").getAsJsonArray();
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[incubator-skywalking] branch master updated: /instance/register osName, hostName (#2042)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 0284293 /instance/register osName, hostName (#2042)
0284293 is described below
commit 028429345838b277a7b1be3c05d4cb1db2f9b194
Author: ZhHong <371816...@qq.com>
AuthorDate: Thu Dec 13 23:58:02 2018 +0800
/instance/register osName, hostName (#2042)
osName and hostName values are reversed。
---
.../provider/handler/v5/rest/InstanceDiscoveryServletHandler.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/oap-server/server-receiver-plugin/skywalking-register-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/register/provider/handler/v5/rest/InstanceDiscoveryServletHandler.java
b/oap-server/server-receiver-plugin/skywalking-register-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/register/provider/handler/v5/rest/InstanceDiscoveryServletHandler.java
index e000a33..d21b6f4 100644
---
a/oap-server/server-receiver-plugin/skywalking-register-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/register/provider/handler/v5/rest/InstanceDiscoveryServletHandler.java
+++
b/oap-server/server-receiver-plugin/skywalking-register-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/register/provider/handler/v5/rest/InstanceDiscoveryServletHandler.java
@@ -70,8 +70,8 @@ public class InstanceDiscoveryServletHandler extends
JettyJsonHandler {
JsonObject osInfoJson = instance.get(OS_INFO).getAsJsonObject();
ServiceInstanceInventory.AgentOsInfo agentOsInfo = new
ServiceInstanceInventory.AgentOsInfo();
-agentOsInfo.setHostname(osInfoJson.get("osName").getAsString());
-agentOsInfo.setOsName(osInfoJson.get("hostName").getAsString());
+agentOsInfo.setHostname(osInfoJson.get("hostName").getAsString());
+agentOsInfo.setOsName(osInfoJson.get("osName").getAsString());
agentOsInfo.setProcessNo(osInfoJson.get("processId").getAsInt());
JsonArray ipv4s = osInfoJson.get("ipv4s").getAsJsonArray();
[incubator-skywalking] branch 6-beta-release updated (2f37158 -> 0284293)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch 6-beta-release in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from 2f37158 modify code style (#2041) add 0284293 /instance/register osName, hostName (#2042) No new revisions were added by this update. Summary of changes: .../provider/handler/v5/rest/InstanceDiscoveryServletHandler.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[GitHub] coveralls edited a comment on issue #2035: Support canal plugin
coveralls edited a comment on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-446514058 [](https://coveralls.io/builds/20619244) Coverage increased (+0.04%) to 14.356% when pulling **9ee8222dff95df06c8ce78c3193f2f9e978119df on WithLin:master** into **028429345838b277a7b1be3c05d4cb1db2f9b194 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2035: Support canal plugin
wu-sheng commented on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447061196 Also, you need to add lib and versions into the supported list after we could be sure about the purpose of this plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2035: Support canal plugin
wu-sheng commented on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447061993 For my understanding of canal, I assume, we at least need source and destination of canal data sync. Am I right? Where is the entry span? And the trace will continue between source and destination? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2043: doubt about grpc agent
wu-sheng commented on issue #2043: doubt about grpc agent URL: https://github.com/apache/incubator-skywalking/issues/2043#issuecomment-447088431 Version os gRPC, or demo? I think this will help This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
wu-sheng opened a new issue #2044: [Proposal] Make Zipkin and Jaeger formats
analysis product available
URL: https://github.com/apache/incubator-skywalking/issues/2044
Now we have a Zipkin receiver(experimental), which could process data and
reformat it to SkyWalking native format. The reason I called it experimental
because really it is not available in cluster mode, and not in high performance.
Thanks to @peng-yongsheng and other committers deliver the new core of
SkyWalking v6, I have some new solutions.
The basic principle is
1. Deliver trace and span storage based on native implementation of Zipkin
or Jaeger.
1. Metric of service, service instance, endpoint scope come from span
directly, no need to wait.
1. Relationship of service based on the span with RPC info, keep in Redis(or
other) cache, set a timer to read and try match. Dispatcher as relation scope
when both sides are ready.
Thank modulization and scan based extension mechanism, I could provide
1. A new storage implementation for all metric and alarm
1. A `storage-ext` module and implementations for Zipkin or Jaeger. They
take charge of span based trace persistence
1. New query implementations for Zipkin or Jaeger.
The benefits of doing these are
1. Cluster mode easier to support. (Important for production ready)
1. Lower cache requirements in backend and reids. (Important for production
ready)
1. We don't need to depend on SkyWalking native span/segment data structure
to run the analysis for Zipkin and Jaeger. (Reduce the chances to face bugs of
formats adaptor)
1. Storage of traces could follow the native Zipkin and Jaeger.
1. Storage still switchable, old codes of metric, alarm and record still
useful.
The ideal result of this could be shown in `application.yml`, which should
like this
```yaml
storage:
elasticsearch:
nameSpace: ${SW_NAMESPACE:""}
clusterNodes: ${SW_STORAGE_ES_CLUSTER_NODES:localhost:9200}
indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
indexReplicasNumber: ${SW_STORAGE_ES_INDEX_REPLICAS_NUMBER:0}
# Batch process setting, refer to
https://www.elastic.co/guide/en/elasticsearch/client/java-api/5.5/java-docs-bulk-processor.html
bulkActions: ${SW_STORAGE_ES_BULK_ACTIONS:2000} # Execute the bulk every
2000 requests
bulkSize: ${SW_STORAGE_ES_BULK_SIZE:20} # flush the bulk every 20mb
flushInterval: ${SW_STORAGE_ES_FLUSH_INTERVAL:10} # flush the bulk every
10 seconds whatever the number of requests
concurrentRequests: ${SW_STORAGE_ES_CONCURRENT_REQUESTS:2} # the number
of concurrent requests
storage-jaeger-ext:
default:
receiver_jeager:
default:
parameters:
query:
graphql-jaeger:
path: ${SW_QUERY_GRAPHQL_PATH:/graphql}
```
Hope I haven't missed anything in high level. @peng-yongsheng @JaredTan95
@YunaiV @candyleer Welcome to join the discussion.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng closed issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin
wu-sheng closed issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-447109667 Move to #2044 . A more reliable and high-performance way to do this, and make them production ready. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447112064 For sure, Zipkin will come first, because we have the old one, need to replace it with the new proposal. Don't get it wrong by the demo yaml above. I just try to avoid confusing with the existing Zipkin receiver settings. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447182267 > Deliver trace and span storage based on native implementation of Zipkin or Jaeger. @wu-sheng What means `native implementation`? Copy their implementation into our project or users deployment both SkyWalking and Zipkin or Jaeger' server? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WithLin commented on issue #2035: Support canal plugin
WithLin commented on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447186071 >Could you describe the use of this plugin? Of course, because the canal client needs to pull data from the canal-server, the canal client is just a pull operation. This plugin can record the current time, batchSize, and destination. >In the codes, the only thing it did, is creating an exit span, but no header related works. So this plugin would't deal with propagation. As the result, the only thing people will get the target nodes in topology. Then, my questions is, who will take the responsibilities to build parent span? Or is there anyone? In my view,I also thought about this problem at the time. In our project that we have a lot of canal-server nodes. I need to see their dependencies in the topology diagram. I also thought about using the LocalSpan form to write this plugin, but Should this not show topology dependencies? The previous one said that canal-client is just an operation to pull data. So I don't think it needs to handle propagation, but do you think LocalSpan is more suitable? If you think it is, then I will change codes. >Also, you need to add lib and versions into the supported list after we could be sure about the purpose of this plugin. i will chage it. >For my understanding of canal, I assume, we at least need source and destination of canal data sync. Am I right? Where is the entry span? And the trace will continue between source and destination? No, canal-client is only for the convenience of operation and maintenance canal-server, canal-client needs to synchronize data from canal-server, canal-server supports multi-database synchronization, each database is a destination for canal-client.canal-server has a multi-instance concept, This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447187767 Maybe, maybe not. The point is I intend don't use our segment table to save this for sure This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2035: Support canal plugin
wu-sheng commented on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447188161 From your description, if client runs in pull mode, it should use entry span, with peer tag in it. And then we need a server side adjustment to support this in topology. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WithLin commented on issue #2035: Support canal plugin
WithLin commented on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447191428 Ok，i will fix the codes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode
candyleer commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode URL: https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-447198299 Does the threadlocal should been removed finally? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447203274 https://ignite.apache.org This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng removed a comment on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
peng-yongsheng removed a comment on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447203274 https://ignite.apache.org This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447203425 > Relationship of service based on the span with RPC info, keep in Redis(or other) cache, set a timer to read and try match. Dispatcher as relation scope when both sides are ready. [Ignite™ is a memory-centric distributed database, caching, and processing platform for transactional, analytical, and streaming workloads delivering in-memory speeds at petabyte scale](https://ignite.apache.org) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447203794 > Ignite™ is a memory-centric distributed database, caching, and processing platform for transactional, analytical, and streaming workloads delivering in-memory speeds at petabyte scale Yes. Known this, several people have sent this to me several months ago. Maybe it is useful, maybe not. I don't know yet. Especially for this case. Are you proposing to use this as cache? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447204113 > Yes. Known this, several people have sent this to me several months ago. Maybe it is useful, maybe not. I don't know yet. Especially for this case. Are you proposing to use this as cache? This is a native memory distributed database and it's an apache project. I prefer to use it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447205135 How many RPC info need to cache is unknown. So, a distributed memory database is a best choice. As far as I know, the solution of Redis cluster is not standby. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447205347 Right now, I am focusing on how to make the span analysis ready in production env. Here are the highlights 1. Don't wait for the whole traces ready before analysis. Then need to support new trace storage module and query implementation. 1. Span for client/server side match to build relation scope. Then a timeout mechanism required in backend and cache layer. I guess you are saying, this part could be done by Ignite? If so, maybe YES. But back to the topic, I have more concerns about other parts. such as, 1. Do I miss any other thing to make things work? 1. Do our modulization and switch mechanism cover all requirements? 1. How to process multiple instrumentations for a single RPC call. etc. This biggest proposal here is don't wait for the whole trace. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2035: Support canal plugin
wu-sheng commented on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-447206701 @ascrutae From discussion, this related to #1805 somehow. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
peng-yongsheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447206658 @wu-sheng Show us some sample Zipkin trace. How to design a no wait analysis system must be base on that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
wu-sheng commented on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447207811 > Show us some sample Zipkin trace. How to design a no wait analysis system must be base on that. No, I just say wait for the whole trace. I think you misunderstand. Let's say right now, the whole trace is buffer and waiting, then do the reformat to SkyWalking native trace format, right? Because we want to reuse the process of trace parse codes. But, actually, we don't really need that based on the new core. We have scope dispatcher now. The only thing needs to wait is RPC related spans, we need the client and server span match to build the relation scopes, right? This part is still waiting, no change and no chance to improve. In this proposal, other local spans could be passed and saved. Only some RPC related trace id and span id need to buffer in local and do timeout/match (Span info saved in cache for sure, no matter what it is). Also, no need to wait for the whole trace ready, just a pair of RPC spans is ready, the analysis is good to go for this part. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng edited a comment on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available
wu-sheng edited a comment on issue #2044: [Proposal] Make Zipkin and Jaeger formats analysis product available URL: https://github.com/apache/incubator-skywalking/issues/2044#issuecomment-447207811 > Show us some sample Zipkin trace. How to design a no wait analysis system must be base on that. No, I just say don't wait for the whole trace. I think you misunderstand. Let's say right now, the whole trace is buffer and waiting, then do the reformat to SkyWalking native trace format, right? Because we want to reuse the process of trace parse codes. But, actually, we don't really need that based on the new core. We have scope dispatcher now. The only thing needs to wait is RPC related spans, we need the client and server span match to build the relation scopes, right? This part is still waiting, no change and no chance to improve. In this proposal, other local spans could be passed and saved. Only some RPC related trace id and span id need to buffer in local and do timeout/match (Span info saved in cache for sure, no matter what it is). Also, no need to wait for the whole trace ready, just a pair of RPC spans is ready, the analysis is good to go for this part. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #2039: [OAP Server][Storage] A new Elasticsearch client supports 2.x, 5.x and 6.x version families.
peng-yongsheng commented on issue #2039: [OAP Server][Storage] A new Elasticsearch client supports 2.x, 5.x and 6.x version families. URL: https://github.com/apache/incubator-skywalking/issues/2039#issuecomment-447210833 ### Step 1. Comparison of the differences from the request and response of the Elasticsearch API. 1. Design the Elasticsearch client API. 1. Develop and test. ### Which API our project used now. 1. Indices APIs: Create, Delete, Exists 1. Document APIs: Index, Get, Delete, Delete by query, Update, Bulk 1. Search APIs: Query, From/Size, Count 1. Metrics Aggregations: Avg, Max, Min, Sum Elasticsearch have so many version. So, we can't comparison all of them one by one. First of all, we just comparison the differences from the last release of the 2.x, 5.x, 6.x. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaoni157 opened a new issue #2045: agent and collector connect error
xiaoni157 opened a new issue #2045: agent and collector connect error URL: https://github.com/apache/incubator-skywalking/issues/2045 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? ___ ### Bug - Which version of SkyWalking, OS and JRE? - Which company or project? - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. ___ ### Requirement or improvement - Please describe about your requirements or improvement suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #2045: agent and collector connect error
wu-sheng closed issue #2045: agent and collector connect error URL: https://github.com/apache/incubator-skywalking/issues/2045 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2045: agent and collector connect error
wu-sheng commented on issue #2045: agent and collector connect error URL: https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447232996 Why do you submit an issue without any info? How could we help you? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaoni157 opened a new issue #2045: agent and collector connect error
xiaoni157 opened a new issue #2045: agent and collector connect error URL: https://github.com/apache/incubator-skywalking/issues/2045 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? Why is the connection abnormal ___ ### Bug - Which version of SkyWalking, OS and JRE? skywalking ：5.0.0-GA aliyun ecs. ip:172.16.12.193 jar : aliyun ecs. ip:172.16.12.192 ElasticSearch version: 5.5 aliyun es server jdk :1.8.0_171 OS:linux aliyun Ecs server - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. Here is my skywalking configuration file application.yml:   Here is my skywalking agent file agent.config:  And here is my error： agent skywalking-api.log  ___ ### Requirement or improvement - Please describe about your requirements or improvement suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaoni157 commented on issue #2045: agent and collector connect error
xiaoni157 commented on issue #2045: agent and collector connect error URL: https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447233263 sorry, i commit so fast, now it has. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #2045: agent and collector connect error
peng-yongsheng commented on issue #2045: agent and collector connect error URL: https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-44722 @wu-sheng Seems he comment many info. I open it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #2045: agent and collector connect error
peng-yongsheng commented on issue #2045: agent and collector connect error URL: https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447233816 @xiaoni157 But, I also suggest you give priority to ask such a question in QQ. It just a question about how to use, no need to commit issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-skywalking] branch 5.x updated: Update README.md
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch 5.x in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/5.x by this push: new 2f3642c Update README.md 2f3642c is described below commit 2f3642cfff46782a5ac249ced6012115239741a8 Author: 吴晟 Wu Sheng AuthorDate: Thu Dec 13 22:59:04 2018 -0800 Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index f56c908..9b6785b 100644 --- a/README.md +++ b/README.md @@ -45,7 +45,7 @@ including: - Jaeger in [Zipkin Thrift or JSON v1/v2 formats](https://github.com/jaegertracing/jaeger#backwards-compatibility-with-zipkin) # Announcement -After SkyWalking 5.0.0-beta2 released, all core features have been provided. For 5 series, we are trying to make them stable from now. At the same time, we have already begun our works for 6 series, in branch `6.0`. It will be a long way to have the first alpha release for it. So if you want to take part in the challengeable works, welcome, but don't consider to use that. Please read the [6.0 documents](https://github.com/apache/incubator-skywalking/blob/6.0/docs/README.md) first. +Most of project committers are working on 6.x development iteration in master branch now. See [6.x documents](https://github.com/apache/incubator-skywalking/tree/master/docs) to understand more. # Document - [Documents in English](docs/README.md)
[GitHub] wu-sheng commented on issue #2045: agent and collector connect error
wu-sheng commented on issue #2045: agent and collector connect error URL: https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447234371 Do you deploy agent and collector in the same machine? Please follow this document to understand how the connection works, https://github.com/apache/incubator-skywalking/blob/5.x/docs/en/Architecture.md#multiple-connection-ways @peng-yongsheng Please don't assign the issue to the closed milestone, it will break the changelog. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaoni157 commented on issue #2045: agent and collector connect error
xiaoni157 commented on issue #2045: agent and collector connect error URL: https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447234853 In the same machine, it works well. i see document first. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #2045: agent and collector connect error
peng-yongsheng commented on issue #2045: agent and collector connect error URL: https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447234847 @wu-sheng It just a question, fixed nothing, why assign to the other version which is not he use? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #2045: agent and collector connect error
wu-sheng closed issue #2045: agent and collector connect error URL: https://github.com/apache/incubator-skywalking/issues/2045 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2045: agent and collector connect error
wu-sheng commented on issue #2045: agent and collector connect error URL: https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447235229 If you are using 0.0.0.0 for grpc, it only works in single node and in the same machine. You have several choices, such as use real IP, or try the direct link. Before you move to cluster mode, IP must not 0.0.0.0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #2045: agent and collector connect error
wu-sheng commented on issue #2045: agent and collector connect error URL: https://github.com/apache/incubator-skywalking/issues/2045#issuecomment-447238121 > It just a question, fixed nothing, why assign to the other version which is not he use? @peng-yongsheng two major reasons 1. [Change log](https://github.com/apache/incubator-skywalking/blob/master/CHANGES.md) includes the issues(question tag) , so you shouldn't change it after this version had been released. Otherwise, no point to provide change log and milestone. 1. When you do Apache reports, you will need these numbers. Such as. ``` How has the project developed since the last report? The project has a diverse community, many users, contributors are from different companies. There has been over 100 commits by more than 22 contributors in the three months. In 5.0.0-RC2 release milestones, there are 130 issues and pull requests solved. In 5.0.0-GA release milestones, there are 32 issues and pull requests solved. In 6.0.0-alpha release milestones, there are 202 issues and pull requests solved. ``` This is exact why we need this `question` label. Archive those issues in milestone, also keep the issues clear enough. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
