[GitHub] [skywalking] kezhenxu94 merged pull request #5846: fix flaky test in comsumerTest
kezhenxu94 merged pull request #5846: URL: https://github.com/apache/skywalking/pull/5846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch tidb_provider updated (774d9f6 -> c211afd)
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a change to branch tidb_provider
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 774d9f6 Merge remote-tracking branch 'origin/master' into
tidb_provider
add 7220643 Add the plugin for mssql-jtds 1.x plugin. (#5842)
add 8325824 Fix the default ignore mechanism isn't accurate enough bug
(#5839)
add 48479b7 test: fix flaky test in comsumerTest (#5846)
add c211afd Merge branch 'master' into tidb_provider
No new revisions were added by this update.
Summary of changes:
.github/workflows/plugins-test.1.yaml | 1 +
CHANGES.md | 2 +
.../commons/datacarrier/consumer/ConsumerTest.java | 2 +
.../network/trace/component/ComponentsDefine.java | 2 +
.../core/context/ContextManagerExtendService.java | 9 +-
...t.java => ContextManagerExtendServiceTest.java} | 43 +++--
...MysqlURLParser.java => MssqlJtdsURLParser.java} | 73 --
.../jdbc/connectionurl/parser/URLParser.java | 3 +
.../pom.xml| 18 ++--
.../define/AbstractConnectionInstrumentation.java | 10 +-
.../jtds/v1/define/ConnectionInstrumentation.java} | 15 ++-
.../jtds/v1}/define/DriverInstrumentation.java | 6 +-
.../src/main/resources/skywalking-plugin.def | 4 +-
apm-sniffer/apm-sdk-plugin/pom.xml | 1 +
.../setup/service-agent/java-agent/Plugin-list.md | 1 +
.../service-agent/java-agent/Supported-list.md | 1 +
.../src/main/resources/component-libraries.yml | 8 +-
.../bin/startup.sh | 2 +-
.../mssql-jtds-scenario/config/expectedData.yaml | 106 +
.../configuration.yml | 18 ++--
.../pom.xml| 12 +--
.../src/main/assembly/assembly.xml | 2 +-
.../apm/testcase/mssql}/Application.java | 2 +-
.../apm/testcase/mssql/MssqlConfig.java} | 14 +--
.../apm/testcase/mssql}/SQLExecutor.java | 8 +-
.../testcase/mssql}/controller/CaseController.java | 16 +---
.../src/main/resources/application.yaml| 2 +-
.../src/main/resources/jdbc.properties | 6 +-
.../src/main/resources/log4j2.xml | 0
.../support-version.list | 9 +-
30 files changed, 256 insertions(+), 140 deletions(-)
copy
apm-sniffer/apm-agent-core/src/test/java/org/apache/skywalking/apm/agent/core/context/{TracingContextTest.java
=> ContextManagerExtendServiceTest.java} (54%)
copy
apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/connectionurl/parser/{MysqlURLParser.java
=> MssqlJtdsURLParser.java} (51%)
copy apm-sniffer/apm-sdk-plugin/{kafka-plugin =>
mssql-jtds-1.x-plugin}/pom.xml (78%)
copy
apm-sniffer/apm-sdk-plugin/{h2-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/h2
=>
mssql-jtds-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mssql/jtds/v1}/define/AbstractConnectionInstrumentation.java
(95%)
copy
apm-sniffer/apm-sdk-plugin/{mariadb-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mariadb/v2/define/DriverInstrumentation.java
=>
mssql-jtds-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mssql/jtds/v1/define/ConnectionInstrumentation.java}
(60%)
copy
apm-sniffer/apm-sdk-plugin/{mariadb-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mariadb/v2
=>
mssql-jtds-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mssql/jtds/v1}/define/DriverInstrumentation.java
(86%)
copy apm-sniffer/apm-sdk-plugin/{canal-1.x-plugin =>
mssql-jtds-1.x-plugin}/src/main/resources/skywalking-plugin.def (80%)
copy test/plugin/scenarios/{baidu-brpc-scenario =>
mssql-jtds-scenario}/bin/startup.sh (92%)
create mode 100644
test/plugin/scenarios/mssql-jtds-scenario/config/expectedData.yaml
copy test/plugin/scenarios/{dbcp-2.x-scenario =>
mssql-jtds-scenario}/configuration.yml (72%)
mode change 100755 => 100644
copy test/plugin/scenarios/{mysql-scenario => mssql-jtds-scenario}/pom.xml
(93%)
copy test/plugin/scenarios/{postgresql-scenario =>
mssql-jtds-scenario}/src/main/assembly/assembly.xml (96%)
copy
test/plugin/scenarios/{avro-scenario/avro-client/src/main/java/org/apache/skywalking/apm/testcase/avro
=>
mssql-jtds-scenario/src/main/java/org/apache/skywalking/apm/testcase/mssql}/Application.java
(95%)
copy
test/plugin/scenarios/{mysql-scenario/src/main/java/org/apache/skywalking/apm/testcase/mysql/MysqlConfig.java
=>
mssql-jtds-scenario/src/main/java/org/apache/skywalking/apm/testcase/mssql/MssqlConfig.java}
(78%)
copy
test/plugin/scenarios/{mysql-scenario/src/main/java/org/apache/skywalking/apm/testcase/mysql
=>
mssql-jtds-scenario/src/main/java/org/apache/skywalking/apm/testcase/mssql}/SQLExecutor
[skywalking] branch master updated (8325824 -> 48479b7)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 8325824 Fix the default ignore mechanism isn't accurate enough bug (#5839) add 48479b7 test: fix flaky test in comsumerTest (#5846) No new revisions were added by this update. Summary of changes: .../skywalking/apm/commons/datacarrier/consumer/ConsumerTest.java | 2 ++ 1 file changed, 2 insertions(+)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (774d9f6) into [master](https://codecov.io/gh/apache/skywalking/commit/832582427a50c7db29f2a7ef9d81834098361e8d?el=desc) (8325824) will **decrease** coverage by `0.00%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 51.22% 51.21% -0.01% - Complexity 3461 3468 +7 Files 1654 1656 +2 Lines 3543635452 +16 Branches 3861 3857 -4 + Hits 1815118156 +5 - Misses1638716394 +7 - Partials898 902 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | | | [...server/analyzer/provider/meter/process/Window.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvV2luZG93LmphdmE=) | `61.76% <0.00%> (-2.95%)` | `7.00% <0.00%> (-1.00%)` | | | [...g/apm/agent/core/context/IgnoredTracerContext.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9JZ25vcmVkVHJhY2VyQ29udGV4dC5qYXZh) | `72.22% <0.00%> (-2.78%)` | `0.00% <0.00%> (ø%)` | | | [...gent/core/context/ContextManagerExtendServi
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (9efded1) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `2.98%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 38.41% 35.43% -2.99% + Complexity 2218 2016 -202 Files 754 740 -14 Lines 1904818585 -463 Branches 1763 1704 -59 - Hits 7318 6586 -732 - Misses1118411503 +319 + Partials546 496 -50 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...e/plugin/elasticsearch/base/MatchCNameBuilder.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NYXRjaENOYW1lQnVpbGRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (9efded1) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `4.57%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 40.53% 35.96% -4.58% + Complexity 2327 2049 -278 Files 754 740 -14 Lines 1907618613 -463 Branches 1768 1709 -59 - Hits 7733 6694-1039 - Misses1077111420 +649 + Partials572 499 -73 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (9efded1) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `2.00%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 41.40% 39.40% -2.01% + Complexity 2367 2199 -168 Files 754 740 -14 Lines 1907918613 -466 Branches 1768 1709 -59 - Hits 7900 7334 -566 - Misses1060710717 +110 + Partials572 562 -10 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` |
[GitHub] [skywalking] killGC commented on issue #5848: rocketmq consume message thread no print tid
killGC commented on issue #5848:
URL: https://github.com/apache/skywalking/issues/5848#issuecomment-727825895
i debug skywaling-agent，i found class
'org.apache.skywalking.apm.plugin.rocketMQ.v4.define.ConsumeMessageOrderlyInstrumentation'
method enhanceClass executed,but method getConstructorsInterceptPoints and
getInstanceMethodsInterceptPoints not execute.
finally when consume thread execute,class
MessageConcurrentlyConsumeInterceptor's afterMethod method not execute
MessageListenerConcurrently ,i definde anonymous MessageListenerConcurrently
subclass，maybe here is this reason？
```java
DefaultMQPushConsumer consumer = new
DefaultMQPushConsumer(consumerGroup);
consumer.setNamesrvAddr(rocketMQProperties.getNamesrvAddr());
consumer.setMessageModel(MessageModel.valueOf(mqConsumer.messageMode()));
consumer.subscribe(topic, tags);
consumer.setInstanceName(UUID.randomUUID().toString());
AbstractRocketMQPushConsumer abstractMQPushConsumer =
(AbstractRocketMQPushConsumer) bean;
if
(MessageExtConst.CONSUME_MODE_CONCURRENTLY.equals(mqConsumer.consumeMode())) {
consumer.registerMessageListener((List list,
ConsumeConcurrentlyContext consumeConcurrentlyContext) ->
abstractMQPushConsumer.dealMessage(list,
consumeConcurrentlyContext,maxRetries));
} else if
(MessageExtConst.CONSUME_MODE_ORDERLY.equals(mqConsumer.consumeMode())) {
consumer.registerMessageListener((List list,
ConsumeOrderlyContext consumeOrderlyContext) ->
abstractMQPushConsumer.dealMessage(list,
consumeOrderlyContext,maxRetries));
} else {
throw new RuntimeException("unknown consume mode ! only support
CONCURRENTLY and ORDERLY");
}
abstractMQPushConsumer.setConsumer(consumer);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (9efded1) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.82%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 47.78% 39.96% -7.83% + Complexity 2642 2243 -399 Files 754 740 -14 Lines 1912918646 -483 Branches 1770 1710 -60 - Hits 9140 7451-1689 - Misses 931210625+1313 + Partials677 570 -107 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ient/elasticsearch/ElasticSearchUpdateRequest.ja
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (9efded1) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.66%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 51.11% 43.44% -7.67% + Complexity 3399 2474 -925 Files 897 757 -140 Lines 2247819145- Branches 2149 1758 -391 - Hits 11489 8318-3171 - Misses1005410207 +153 + Partials935 620 -315 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (9efded1) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `9.93%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 50.81% 40.88% -9.94% + Complexity 3381 2293-1088 Files 897 740 -157 Lines 2247818646-3832 Branches 2149 1710 -439 - Hits 11423 7623-3800 - Misses1013010451 +321 + Partials925 572 -353 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ient/elasticsearch/ElasticSearchUpdateRequest.ja
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `15.27%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## = - Coverage 51.12% 35.85% -15.28% + Complexity 3400 2031 -1369 = Files 897 740 -157 Lines 2247818596 -3882 Branches 2149 1706 -443 = - Hits 11492 6667 -4825 - Misses1005011425 +1375 + Partials936 504 -432 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-50.71%)` | `0.00 <0.00> (-12.00)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-14.29%)` | `0.00 <0.00> (-1.00)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `15.12%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## = - Coverage 51.12% 36.00% -15.13% + Complexity 3400 2083 -1317 = Files 897 757 -140 Lines 2247819075 -3403 Branches 2149 1752 -397 = - Hits 11492 6868 -4624 - Misses1005011690 +1640 + Partials936 517 -419 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-50.71%)` | `0.00 <0.00> (-12.00)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-14.29%)` | `0.00 <0.00> (-1.00)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `14.17%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## = - Coverage 51.12% 36.94% -14.18% + Complexity 3400 2117 -1283 = Files 897 757 -140 Lines 2247819094 -3384 Branches 2149 1753 -396 = - Hits 11492 7055 -4437 - Misses1005011505 +1455 + Partials936 534 -402 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-50.71%)` | `0.00 <0.00> (-12.00)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-14.29%)` | `0.00 <0.00> (-1.00)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `12.34%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## = - Coverage 51.12% 38.78% -12.35% + Complexity 3400 2226 -1174 = Files 897 757 -140 Lines 2247819094 -3384 Branches 2149 1753 -396 = - Hits 11492 7405 -4087 - Misses1005011125 +1075 + Partials936 564 -372 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-50.71%)` | `0.00 <0.00> (-12.00)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-14.29%)` | `0.00 <0.00> (-1.00)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...erver/storage/plugin/jdbc/h2/dao/H2MetricsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc0RBTy5qYXZh) | `0.00% <0.00%> (
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `12.37%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## = - Coverage 51.12% 38.75% -12.38% + Complexity 3400 2225 -1175 = Files 897 757 -140 Lines 2247819094 -3384 Branches 2149 1753 -396 = - Hits 11492 7399 -4093 - Misses1005011131 +1081 + Partials936 564 -372 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-50.71%)` | `0.00 <0.00> (-12.00)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-14.29%)` | `0.00 <0.00> (-1.00)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...erver/storage/plugin/jdbc/h2/dao/H2MetricsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc0RBTy5qYXZh) | `0.00% <0.00%> (
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `9.24%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 51.12% 41.88% -9.25% + Complexity 3400 2902 -498 Files 897 900 +3 Lines 2247822443 -35 Branches 2149 2132 -17 - Hits 11492 9400-2092 - Misses1005012235+2185 + Partials936 808 -128 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-50.71%)` | `0.00 <0.00> (-12.00)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-14.29%)` | `0.00 <0.00> (-1.00)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...erver/storage/plugin/jdbc/h2/dao/H2MetricsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.96%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 51.12% 45.15% -5.97% + Complexity 3400 3115 -285 Files 897 900 +3 Lines 2247822476 -2 Branches 2149 2133 -16 - Hits 1149210150-1342 - Misses1005011473+1423 + Partials936 853 -83 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.88%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 51.12% 45.23% -5.89% + Complexity 3400 3121 -279 Files 897 900 +3 Lines 2247822476 -2 Branches 2149 2133 -16 - Hits 1149210168-1324 - Misses1005011454+1404 + Partials936 854 -82 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `3.30%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 51.12% 47.82% -3.31% + Complexity 3400 3237 -163 Files 897 900 +3 Lines 2247822512 +34 Branches 2149 2134 -15 - Hits 1149210766 -726 - Misses1005010831 +781 + Partials936 915 -21 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `2.56%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 51.12% 48.55% -2.57% + Complexity 3400 3269 -131 Files 897 900 +3 Lines 2247822512 +34 Branches 2149 2134 -15 - Hits 1149210931 -561 - Misses1005010652 +602 + Partials936 929 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `1.91%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 51.12% 49.21% -1.92% + Complexity 3400 3290 -110 Files 897 900 +3 Lines 2247822512 +34 Branches 2149 2134 -15 - Hits 1149211079 -413 - Misses1005010501 +451 + Partials936 932 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] TinyAllen commented on issue #371: Magic strings from selecting date to constants
TinyAllen commented on issue #371: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/371#issuecomment-727833470 @masterxxo just do it 😊 l agree that using the constat.ts file, and move it to the main directory path. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `2.02%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 52.51% 50.48% -2.03% + Complexity 3455 3357 -98 Files 897 900 +3 Lines 2247822512 +34 Branches 2149 2134 -15 - Hits 1180511366 -439 - Misses 972110215 +494 + Partials952 931 -21 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | | | [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `2.00%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 52.54% 50.53% -2.01% + Complexity 3456 3358 -98 Files 897 900 +3 Lines 2247822512 +34 Branches 2149 2134 -15 - Hits 1181111377 -434 - Misses 971510203 +488 + Partials952 932 -20 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | | | [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%
[GitHub] [skywalking] wu-sheng commented on issue #5848: rocketmq consume message thread no print tid
wu-sheng commented on issue #5848: URL: https://github.com/apache/skywalking/issues/5848#issuecomment-727839188 I don't have many details to share. Plugins are contributed by many people. If there is no interceptor executed, maybe. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng opened a new pull request #5849: Support `sideCar.internalErrorCode` in the sources
wu-sheng opened a new pull request #5849: URL: https://github.com/apache/skywalking/pull/5849 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md). The sidecar is a common concept today, as the service mesh has been the next-generation infrastructure, no matter in k8s or out. I found we need to support this in the mesh telemetry internal format to support defining metrics in the mesh case. There are 2 major changes in the PR 1. Nested classes definition is not supported in the previous OAL core, so I added them. It should support any nested class. 2. Support `sideCar.internalErrorCode` in the Service, ServiceInstance, Endpoint, ServiceRelation, and ServiceInstanceRelation sources, then you could have OAL scripts like this ``` service_cpm_sidecar = from(Service.*).filter(sideCar.internalErrorCode != "").cpm(); service_sla_sidecar = from(Service.*).percent(sideCar.internalErrorCode != ""); ``` The current Istio+Envoy mesh telemetry's `sideCar.internalErrorCode` is mapping to envoy's v2 ALS definition, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags. At last, I didn't change anything in the default OAL, all these two features are open to the users. If they want to this, they could add new OAL scripts, and set up the UI. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (9efded1) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.55%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 51.20% 45.64% -5.56% + Complexity 3456 2474 -982 Files 1654 1647 -7 Lines 3543635242 -194 Branches 3861 4023 +162 - Hits 1814416086-2058 - Misses1639318242+1849 - Partials899 914 +15 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/584
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5844: add Tidb provider module.
codecov[bot] edited a comment on pull request #5844: URL: https://github.com/apache/skywalking/pull/5844#issuecomment-727203629 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=h1) Report > Merging [#5844](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=desc) (c211afd) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `0.66%`. > The diff coverage is `9.21%`. [](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5844 +/- ## - Coverage 51.20% 50.53% -0.67% + Complexity 3456 3358 -98 Files 1654 900 -754 Lines 3543622512 -12924 Branches 3861 2134-1727 - Hits 1814411377-6767 + Misses1639310203-6190 - Partials899 932 +33 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5844?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=) | `50.70% <0.00%> (ø)` | `12.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gySGlzdG9yeURlbGV0ZURBTy5qYXZh) | `14.28% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `10.00% <10.00%> (ø)` | `3.00 <3.00> (?)` | | | [.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (ø)` | | | [...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZUNvbmZpZy5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | | | [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5844/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | | | [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/
[GitHub] [skywalking] huangcanhui2018 opened a new issue #5850: Does skywalking 8.x support spring cloud gateway version 2.2.x ?
huangcanhui2018 opened a new issue #5850: URL: https://github.com/apache/skywalking/issues/5850 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [Y ] Bug - [ ] Requirement - [ ] Feature or performance improvement Hi,wusheng! Does skywalking 8.x support spring cloud gateway version 2.2.x ? At present, it is found that the tracking information cannot be obtained normally. However, skywalking 8.1.0 can obtain the tracking information of spring cloud gateway version 2.0.0. At present, the only plug-ins available for spring cloud gateway are apm-spring-cloud-gateway-2.0.x-plugin-8.1.0.jar and apm-spring-cloud-gateway-2.1.x-plugin-8.1.0.jar. SkyWalking：8.1.0 or 8.2.0 OS：win7 JRE：1.8.x This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch mesh-internal-error created (now 44794b1)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch mesh-internal-error in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 44794b1 Support nested sidecar object in the scope. No new revisions were added by this update.
[skywalking] branch mesh-internal-error updated (44794b1 -> 93e83d0)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch mesh-internal-error in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 44794b1 Support nested sidecar object in the scope. add 93e83d0 Update the changelog. No new revisions were added by this update. Summary of changes: CHANGES.md | 2 ++ 1 file changed, 2 insertions(+)
[skywalking] branch mesh-internal-error created (now 44794b1)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch mesh-internal-error in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 44794b1 Support nested sidecar object in the scope. No new revisions were added by this update.
[GitHub] [skywalking] wu-sheng closed issue #5850: Does skywalking 8.x support spring cloud gateway version 2.2.x ?
wu-sheng closed issue #5850: URL: https://github.com/apache/skywalking/issues/5850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5850: Does skywalking 8.x support spring cloud gateway version 2.2.x ?
wu-sheng commented on issue #5850: URL: https://github.com/apache/skywalking/issues/5850#issuecomment-727856465 We have 2.2.3 tested. https://github.com/apache/skywalking/blob/master/test/plugin/scenarios/gateway-2.1.x-scenario/support-version.list This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch mesh-internal-error created (now 44794b1)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch mesh-internal-error in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 44794b1 Support nested sidecar object in the scope. No new revisions were added by this update.
[skywalking] branch mesh-internal-error updated (44794b1 -> 93e83d0)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch mesh-internal-error in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 44794b1 Support nested sidecar object in the scope. add 93e83d0 Update the changelog. No new revisions were added by this update. Summary of changes: CHANGES.md | 2 ++ 1 file changed, 2 insertions(+)
[GitHub] [skywalking] codecov[bot] commented on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] commented on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `15.31%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## = - Coverage 51.20% 35.88% -15.32% + Complexity 3456 2032 -1424 = Files 1654 738 -916 Lines 3543618597-16839 Branches 3861 1726 -2135 = - Hits 18144 6674-11470 + Misses1639311414 -4979 + Partials899 509 -390 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1291 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=t
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `15.17%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## = - Coverage 51.20% 36.02% -15.18% + Complexity 3456 2084 -1372 = Files 1654 755 -899 Lines 3543619076-16360 Branches 3861 1772 -2089 = - Hits 18144 6873-11271 + Misses1639311680 -4713 + Partials899 523 -376 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1280 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `12.00%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## = - Coverage 51.20% 39.19% -12.01% + Complexity 3456 2230 -1226 = Files 1654 755 -899 Lines 3543619076-16360 Branches 3861 1772 -2089 = - Hits 18144 7477-10667 + Misses1639311014 -5379 + Partials899 585 -314 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1271 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources
wu-sheng commented on a change in pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#discussion_r524029956
##
File path:
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java
##
@@ -164,4 +169,52 @@ protected static String parseTLS(final TLSProperties
properties) {
return M_TLS;
}
+/**
+ * Refer to
https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
+ *
+ * @param responseFlags in the ALS v2
+ * @return empty string if no internal error code, or literal string
representing the code.
+ */
+protected static String parseInternalErrorCode(final ResponseFlags
responseFlags) {
+if (responseFlags != null) {
+if (responseFlags.getFailedLocalHealthcheck()) {
+return "failed_local_healthcheck";
+} else if (responseFlags.getNoHealthyUpstream()) {
+return "no_healthy_upstream";
+} else if (responseFlags.getUpstreamRequestTimeout()) {
+return "upstream_request_timeout";
+} else if (responseFlags.getLocalReset()) {
+return "local_reset";
+} else if (responseFlags.getUpstreamConnectionFailure()) {
+return "upstream_connection_failure";
+} else if (responseFlags.getUpstreamConnectionTermination()) {
+return "upstream_connection_termination";
+} else if (responseFlags.getUpstreamOverflow()) {
+return "upstream_overflow";
+} else if (responseFlags.getNoRouteFound()) {
+return "no_route_found";
+} else if (responseFlags.getDelayInjected()) {
+return "delay_injected";
+} else if (responseFlags.getFaultInjected()) {
+return "fault_injected";
+} else if (responseFlags.getRateLimited()) {
+return "rate_limited";
+} else if (responseFlags.getUnauthorizedDetails() != null) {
+return "unauthorized_details";
+} else if (responseFlags.getRateLimitServiceError()) {
+return "rate_limit_service_error";
+} else if (responseFlags.getDownstreamConnectionTermination()) {
+return "downstream_connection_termination";
+} else if (responseFlags.getUpstreamRetryLimitExceeded()) {
+return "upstream_retry_limit_exceeded";
+} else if (responseFlags.getStreamIdleTimeout()) {
+return "stream_idle_timeout";
+} else if (responseFlags.getInvalidEnvoyRequestHeaders()) {
+return "invalid_envoy_request_headers";
+} else if (responseFlags.getDownstreamProtocolError()) {
+return "downstream_protocol_error";
+}
Review comment:
@lizan Does this kind of conversion make sense? Is there any chance of
having multiple error codes? Even if so, doesn't it matter or have priority?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `8.21%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 42.98% -8.22% + Complexity 3456 2418-1038 Files 1654 755 -899 Lines 3543619085 -16351 Branches 3861 1772-2089 - Hits 18144 8204-9940 + Misses1639310255-6138 + Partials899 626 -273 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1257 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.78%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 43.42% -7.79% + Complexity 3456 2439-1017 Files 1654 755 -899 Lines 3543619085 -16351 Branches 3861 1772-2089 - Hits 18144 8287-9857 + Misses1639310171-6222 + Partials899 627 -272 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1256 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources
wu-sheng commented on a change in pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#discussion_r524031233
##
File path:
oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java
##
@@ -164,4 +169,52 @@ protected static String parseTLS(final TLSProperties
properties) {
return M_TLS;
}
+/**
+ * Refer to
https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
+ *
+ * @param responseFlags in the ALS v2
+ * @return empty string if no internal error code, or literal string
representing the code.
+ */
+protected static String parseInternalErrorCode(final ResponseFlags
responseFlags) {
+if (responseFlags != null) {
+if (responseFlags.getFailedLocalHealthcheck()) {
+return "failed_local_healthcheck";
+} else if (responseFlags.getNoHealthyUpstream()) {
+return "no_healthy_upstream";
+} else if (responseFlags.getUpstreamRequestTimeout()) {
+return "upstream_request_timeout";
+} else if (responseFlags.getLocalReset()) {
+return "local_reset";
+} else if (responseFlags.getUpstreamConnectionFailure()) {
+return "upstream_connection_failure";
+} else if (responseFlags.getUpstreamConnectionTermination()) {
+return "upstream_connection_termination";
+} else if (responseFlags.getUpstreamOverflow()) {
+return "upstream_overflow";
+} else if (responseFlags.getNoRouteFound()) {
+return "no_route_found";
+} else if (responseFlags.getDelayInjected()) {
+return "delay_injected";
+} else if (responseFlags.getFaultInjected()) {
+return "fault_injected";
+} else if (responseFlags.getRateLimited()) {
+return "rate_limited";
+} else if (responseFlags.getUnauthorizedDetails() != null) {
+return "unauthorized_details";
+} else if (responseFlags.getRateLimitServiceError()) {
+return "rate_limit_service_error";
+} else if (responseFlags.getDownstreamConnectionTermination()) {
+return "downstream_connection_termination";
+} else if (responseFlags.getUpstreamRetryLimitExceeded()) {
+return "upstream_retry_limit_exceeded";
+} else if (responseFlags.getStreamIdleTimeout()) {
+return "stream_idle_timeout";
+} else if (responseFlags.getInvalidEnvoyRequestHeaders()) {
+return "invalid_envoy_request_headers";
+} else if (responseFlags.getDownstreamProtocolError()) {
+return "downstream_protocol_error";
+}
Review comment:
To @ZackButcher too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `14.06%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## = - Coverage 51.20% 37.13% -14.07% + Complexity 3456 2469 -987 = Files 1654 900 -754 Lines 3543622590-12846 Branches 3861 2182 -1679 = - Hits 18144 8389 -9755 + Misses1639313569 -2824 + Partials899 632 -267 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1244 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.31%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 43.89% -7.32% + Complexity 3456 2469 -987 Files 1654 755 -899 Lines 3543619113 -16323 Branches 3861 1777-2084 - Hits 18144 8389-9755 + Misses1639310092-6301 + Partials899 632 -267 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1254 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `13.26%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## = - Coverage 51.20% 37.93% -13.27% + Complexity 3456 2517 -939 = Files 1654 900 -754 Lines 3543622602-12834 Branches 3861 2182 -1679 = - Hits 18144 8575 -9569 + Misses1639313395 -2998 + Partials899 632 -267 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `20.58%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## = - Coverage 51.20% 30.61% -20.59% + Complexity 3456 1768 -1688 = Files 1654 738 -916 Lines 3543618459-16977 Branches 3861 1692 -2169 = - Hits 18144 5651-12493 + Misses1639312413 -3980 + Partials899 395 -504 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1319 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `10.82%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## = - Coverage 51.20% 40.37% -10.83% + Complexity 3456 2789 -667 = Files 1654 881 -773 Lines 3543621968-13468 Branches 3861 2104 -1757 = - Hits 18144 8870 -9274 + Misses1639312336 -4057 + Partials899 762 -137 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1229 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.62%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.57% -6.63% + Complexity 3456 3005 -451 Files 1654 881 -773 Lines 3543621987 -13449 Branches 3861 2104-1757 - Hits 18144 9801-8343 + Misses1639311341-5052 + Partials899 845 -54 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1211 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.55%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.64% -6.56% + Complexity 3456 3006 -450 Files 1654 881 -773 Lines 3543621989 -13447 Branches 3861 2106-1755 - Hits 18144 9818-8326 + Misses1639311326-5067 + Partials899 845 -54 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1210 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.55%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.64% -6.56% + Complexity 3456 3007 -449 Files 1654 881 -773 Lines 3543621995 -13441 Branches 3861 2119-1742 - Hits 18144 9820-8324 + Misses1639311331-5062 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1208 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.55%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.65% -6.56% + Complexity 3456 3008 -448 Files 1654 881 -773 Lines 3543621995 -13441 Branches 3861 2119-1742 - Hits 18144 9821-8323 + Misses1639311330-5063 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1208 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.81%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.38% -6.82% + Complexity 3456 3008 -448 Files 1654 885 -769 Lines 3543622127 -13309 Branches 3861 2131-1730 - Hits 18144 9821-8323 + Misses1639311462-4931 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.96%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.23% -6.97% + Complexity 3456 3008 -448 Files 1654 890 -764 Lines 3543622201 -13235 Branches 3861 2140-1721 - Hits 18144 9821-8323 + Misses1639311536-4857 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] huangcanhui2018 commented on issue #5850: Does skywalking 8.x support spring cloud gateway version 2.2.x ?
huangcanhui2018 commented on issue #5850: URL: https://github.com/apache/skywalking/issues/5850#issuecomment-727869069 @wusheng But the version we are using is spring cloud gateway 2.2.2.RELEASE. When skywalking 8.1.0 / 8.2.0 is used, the tracking information cannot be obtained normally, and the span cannot be connected in series according to traceId. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5850: Does skywalking 8.x support spring cloud gateway version 2.2.x ?
wu-sheng commented on issue #5850: URL: https://github.com/apache/skywalking/issues/5850#issuecomment-727870013 I just gave you the fact of testing. Our test codes are verifying the plugin, and also for you to compare what is the difference. Because, in the reality, we can't test every version and every usage you could do. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.98%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.21% -6.99% + Complexity 3456 3008 -448 Files 1654 891 -763 Lines 3543622212 -13224 Branches 3861 2140-1721 - Hits 18144 9821-8323 + Misses1639311547-4846 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.96%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.23% -6.97% + Complexity 3456 3008 -448 Files 1654 890 -764 Lines 3543622201 -13235 Branches 3861 2140-1721 - Hits 18144 9821-8323 + Misses1639311536-4857 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] wu-sheng commented on issue #5850: Does skywalking 8.x support spring cloud gateway version 2.2.x ?
wu-sheng commented on issue #5850: URL: https://github.com/apache/skywalking/issues/5850#issuecomment-727870940 In the plugin case, we always prefer you could find the issue first, even send a pull request to fix. The libraries with versions are countless. This is not a job for one man or a limited group of people. We are looking forward to the whole community including the end-users to maintain the plugin system. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.98%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.21% -6.99% + Complexity 3456 3008 -448 Files 1654 891 -763 Lines 3543622212 -13224 Branches 3861 2140-1721 - Hits 18144 9821-8323 + Misses1639311547-4846 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.99%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.20% -7.00% + Complexity 3456 3008 -448 Files 1654 892 -762 Lines 3543622218 -13218 Branches 3861 2140-1721 - Hits 18144 9821-8323 + Misses1639311553-4840 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.08%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.11% -7.09% + Complexity 3456 3008 -448 Files 1654 894 -760 Lines 3543622260 -13176 Branches 3861 2144-1717 - Hits 18144 9821-8323 + Misses1639311595-4798 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1205 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.09%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.10% -7.10% + Complexity 3456 3008 -448 Files 1654 896 -758 Lines 3543622266 -13170 Branches 3861 2144-1717 - Hits 18144 9821-8323 + Misses1639311601-4792 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1205 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.09%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.10% -7.10% + Complexity 3456 3008 -448 Files 1654 896 -758 Lines 3543622266 -13170 Branches 3861 2144-1717 - Hits 18144 9821-8323 + Misses1639311601-4792 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1205 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.10%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 44.09% -7.11% + Complexity 3456 3008 -448 Files 1654 897 -757 Lines 3543622271 -13165 Branches 3861 2144-1717 - Hits 18144 9821-8323 + Misses1639311606-4787 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1205 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.78%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 43.42% -7.79% + Complexity 3456 3008 -448 Files 1654 914 -740 Lines 3543622618 -12818 Branches 3861 2194-1667 - Hits 18144 9821-8323 + Misses1639311953-4440 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1206 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `13.46%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## = - Coverage 51.20% 37.74% -13.47% + Complexity 3456 2517 -939 = Files 1654 907 -747 Lines 3543622721-12715 Branches 3861 2188 -1673 = - Hits 18144 8575 -9569 + Misses1639313514 -2879 + Partials899 632 -267 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `13.38%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## = - Coverage 51.20% 37.82% -13.39% + Complexity 3456 2517 -939 = Files 1654 905 -749 Lines 3543622672-12764 Branches 3861 2184 -1677 = - Hits 18144 8575 -9569 + Misses1639313465 -2928 + Partials899 632 -267 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `4.94%`. > The diff coverage is `44.82%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 46.26% -4.95% + Complexity 3456 2517 -939 Files 1654 1655 +1 Lines 3543635514 +78 Branches 3861 3874 +13 - Hits 1814416429-1715 - Misses1639318161+1768 - Partials899 924 +25 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.41% <0.00%> (-80.84%)` | `2.00 <0.00> (-12.00)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `51.92% <15.90%> (-27.11%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `75.00% <75.00%> (ø)` | `7.00 <4.00> (+4.00)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `100.00% <100.00%> (+38.46%)` | `4.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `93.10% <100.00%> (ø)` | `30.00 <2.00> (ø)` | | | ... and [173 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | | --
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `4.94%`. > The diff coverage is `44.82%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 46.25% -4.95% + Complexity 3456 2517 -939 Files 1654 1655 +1 Lines 3543635515 +79 Branches 3861 3874 +13 - Hits 1814416429-1715 - Misses1639318162+1769 - Partials899 924 +25 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.41% <0.00%> (-80.84%)` | `2.00 <0.00> (-12.00)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `51.92% <15.90%> (-27.11%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `75.00% <75.00%> (ø)` | `7.00 <4.00> (+4.00)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `100.00% <100.00%> (+38.46%)` | `4.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `93.10% <100.00%> (ø)` | `30.00 <2.00> (ø)` | | | ... and [174 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | | --
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `4.94%`. > The diff coverage is `44.82%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 46.25% -4.95% + Complexity 3456 2517 -939 Files 1654 1655 +1 Lines 3543635515 +79 Branches 3861 3874 +13 - Hits 1814416429-1715 - Misses1639318162+1769 - Partials899 924 +25 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.41% <0.00%> (-80.84%)` | `2.00 <0.00> (-12.00)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `51.92% <15.90%> (-27.11%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `75.00% <75.00%> (ø)` | `7.00 <4.00> (+4.00)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `100.00% <100.00%> (+38.46%)` | `4.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `93.10% <100.00%> (ø)` | `30.00 <2.00> (ø)` | | | ... and [174 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | | --
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `3.18%`. > The diff coverage is `44.82%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 48.01% -3.19% + Complexity 3456 2661 -795 Files 1654 1655 +1 Lines 3543635527 +91 Branches 3861 3874 +13 - Hits 1814417058-1086 - Misses1639317548+1155 - Partials899 921 +22 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.41% <0.00%> (-80.84%)` | `2.00 <0.00> (-12.00)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `51.92% <15.90%> (-27.11%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `75.00% <75.00%> (ø)` | `7.00 <4.00> (+4.00)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `100.00% <100.00%> (+38.46%)` | `4.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `93.10% <100.00%> (ø)` | `30.00 <2.00> (ø)` | | | ... and [145 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | | --
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `3.63%`. > The diff coverage is `44.82%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 47.56% -3.64% + Complexity 3456 2636 -820 Files 1654 1655 +1 Lines 3543635527 +91 Branches 3861 3874 +13 - Hits 1814416898-1246 - Misses1639317708+1315 - Partials899 921 +22 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.41% <0.00%> (-80.84%)` | `2.00 <0.00> (-12.00)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `51.92% <15.90%> (-27.11%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `75.00% <75.00%> (ø)` | `7.00 <4.00> (+4.00)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `100.00% <100.00%> (+38.46%)` | `4.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `93.10% <100.00%> (ø)` | `30.00 <2.00> (ø)` | | | ... and [150 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | | --
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.78%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 43.42% -7.79% + Complexity 3456 3008 -448 Files 1654 914 -740 Lines 3543622618 -12818 Branches 3861 2194-1667 - Hits 18144 9821-8323 + Misses1639311953-4440 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1206 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.78%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 43.42% -7.79% + Complexity 3456 3008 -448 Files 1654 914 -740 Lines 3543622618 -12818 Branches 3861 2194-1667 - Hits 18144 9821-8323 + Misses1639311953-4440 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1206 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.85%`. > The diff coverage is `28.73%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 43.34% -7.86% + Complexity 3456 3008 -448 Files 1654 915 -739 Lines 3543622658 -12778 Branches 3861 2198-1663 - Hits 18144 9821-8323 + Misses1639311993-4400 + Partials899 844 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1206 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-mor
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.26%`. > The diff coverage is `34.48%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 45.93% -5.27% + Complexity 3456 3151 -305 Files 1654 915 -739 Lines 3543622674 -12762 Branches 3861 2200-1661 - Hits 1814410416-7728 + Misses1639311362-5031 + Partials899 896 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1197 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.24%`. > The diff coverage is `34.48%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 45.95% -5.25% + Complexity 3456 3159 -297 Files 1654 917 -737 Lines 3543622733 -12703 Branches 3861 2207-1654 - Hits 1814410447-7697 + Misses1639311383-5010 - Partials899 903 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1197 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.12%`. > The diff coverage is `34.48%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 46.07% -5.13% + Complexity 3456 3159 -297 Files 1654 915 -739 Lines 3543622674 -12762 Branches 3861 2200-1661 - Hits 1814410447-7697 + Misses1639311324-5069 - Partials899 903 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1197 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.43%`. > The diff coverage is `34.48%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 45.76% -5.44% + Complexity 3456 3211 -245 Files 1654 934 -720 Lines 3543623212 -12224 Branches 3861 2253-1608 - Hits 1814410624-7520 + Misses1639311682-4711 - Partials899 906 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1187 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.50%`. > The diff coverage is `34.48%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 45.69% -5.51% + Complexity 3456 3203 -253 Files 1654 934 -720 Lines 3543623212 -12224 Branches 3861 2253-1608 - Hits 1814410607-7537 + Misses1639311698-4695 - Partials899 907 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1187 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.41%`. > The diff coverage is `34.48%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 45.78% -5.42% + Complexity 3456 3212 -244 Files 1654 934 -720 Lines 3543623212 -12224 Branches 3861 2253-1608 - Hits 1814410628-7516 + Misses1639311677-4716 - Partials899 907 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1187 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.49%`. > The diff coverage is `34.48%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 45.70% -5.50% + Complexity 3456 3212 -244 Files 1654 935 -719 Lines 3543623251 -12185 Branches 3861 2254-1607 - Hits 1814410628-7516 + Misses1639311716-4677 - Partials899 907 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1188 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.49%`. > The diff coverage is `34.48%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 45.70% -5.50% + Complexity 3456 3212 -244 Files 1654 935 -719 Lines 3543623251 -12185 Branches 3861 2254-1607 - Hits 1814410628-7516 + Misses1639311716-4677 - Partials899 907 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1188 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more)
[skywalking-website] 01/01: Add swck 0.1.0 release
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch release-swck
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
commit c607754d5a2a0c1ba69c17277279959d8c038621
Author: Gao Hongtao
AuthorDate: Mon Nov 16 21:55:20 2020 +0800
Add swck 0.1.0 release
Signed-off-by: Gao Hongtao
---
docs/.vuepress/config.js| 6 --
docs/README.md | 3 +++
docs/downloads/README.md| 5 +
docs/events/README.md | 5 +
docs/zh/README.md | 6 +++---
docs/zh/downloads/README.md | 5 +
docs/zh/events/README.md| 6 ++
7 files changed, 31 insertions(+), 5 deletions(-)
diff --git a/docs/.vuepress/config.js b/docs/.vuepress/config.js
index 7bc137c..4c22947 100755
--- a/docs/.vuepress/config.js
+++ b/docs/.vuepress/config.js
@@ -34,6 +34,7 @@ module.exports = {
{ text: 'Kubernetes helm 4.0.0', link:
"https://github.com/apache/skywalking-kubernetes/tree/v4.0.0"},
{ text: 'Python Agent 0.3.0', link:
"https://github.com/apache/skywalking-python/tree/v0.3.0"},
{ text: 'Client JS 0.1.0', link:
"https://github.com/apache/skywalking-client-js/tree/v0.1.0"},
+{ text: 'Cloud on Kubernetes 0.1.0', link:
"https://github.com/apache/skywalking-swck/tree/0.1.0"},
], },
{ text: "GitHub", items: [
{ text: 'Main Repo, Javaagent and Backend', link:
"https://github.com/apache/skywalking/"; },
@@ -44,7 +45,7 @@ module.exports = {
{ text: 'Data Query Protocol', link:
"https://github.com/apache/skywalking-query-protocol"},
{ text: 'Docker', link:
"https://github.com/apache/skywalking-docker"},
{ text: 'Kubernetes helm', link:
"https://github.com/apache/skywalking-kubernetes/"},
-{ text: 'K8s Operator', link:
"https://github.com/apache/skywalking-swck"},
+{ text: 'Cloud on Kubernetes', link:
"https://github.com/apache/skywalking-swck"},
{ text: 'Website', link:
"https://github.com/apache/skywalking-website"},
{ text: 'Python Agent', link:
"https://github.com/apache/skywalking-python"},
{ text: 'Client JS', link:
"https://github.com/apache/skywalking-client-js"},
@@ -84,6 +85,7 @@ module.exports = {
{ text: 'Kubernetes helm 4.0.0', link:
"https://github.com/apache/skywalking-kubernetes/tree/v4.0.0"},
{ text: 'Python Agent 0.3.0', link:
"https://github.com/apache/skywalking-python/tree/v0.3.0"},
{ text: 'Client JS 0.1.0', link:
"https://github.com/apache/skywalking-client-js/tree/v0.1.0"},
+ { text: 'Cloud on Kubernetes 0.1.0', link:
"https://github.com/apache/skywalking-swck/tree/0.1.0"},
],
},
{ text: "GitHub", items: [
@@ -95,7 +97,7 @@ module.exports = {
{ text: 'Data Query Protocol', link:
"https://github.com/apache/skywalking-query-protocol"},
{ text: 'Docker', link:
"https://github.com/apache/skywalking-docker"},
{ text: 'Kubernetes helm', link:
"https://github.com/apache/skywalking-kubernetes/"},
-{ text: 'K8s Operator', link:
"https://github.com/apache/skywalking-swck"},
+{ text: 'Cloud on Kubernetes', link:
"https://github.com/apache/skywalking-swck"},
{ text: 'Website', link:
"https://github.com/apache/skywalking-website"},
{ text: 'Python Agent', link:
"https://github.com/apache/skywalking-python"},
{ text: 'Client JS', link:
"https://github.com/apache/skywalking-client-js"},
diff --git a/docs/README.md b/docs/README.md
index fccc1d4..64f21cb 100755
--- a/docs/README.md
+++ b/docs/README.md
@@ -27,6 +27,9 @@ user:
news:
title: Events & News
content:
+ - header: SkyWalking Cloud on Kubernetes 0.1.0 is released
+content: OAPServer CRDs and controller
+time: Nov. 16th, 2020
- header: Welcome Jiapeng Liu as new committer
content: Based on his continuous contributions, Jiapeng Liu (a.k.a
[evanljp](https://github.com/evanljp)) has been voted as a new committer.
time: Nov. 5th, 2020
diff --git a/docs/downloads/README.md b/docs/downloads/README.md
index 1f8a422..348eee1 100755
--- a/docs/downloads/README.md
+++ b/docs/downloads/README.md
@@ -41,6 +41,11 @@ Use the links below to download the Apache SkyWalking from
one of our mirrors.
|:---:|:--:|:--:|:--:|
| Nov. 3rd, 2020 | 4.0.0 | Source code|
[[src]](https://www.apache.org/dyn/closer.cgi/skywalking/kubernetes/4.0.0/skywalking-kubernetes-4.0.0-src.tgz)
[[asc]](https://downloads.apache.org/skywalking/kubernetes/4.0.0/skywalking-kubernetes-4.0.0-src.tgz.asc)
[[sha512]](https://downloads.apache.org/skywalking/kubernetes/4.0.0/skywalking-kubernetes-4.0.0-src.tgz.sha512)|
+### SkyWalking Cloud on Kubernetes
+| Date | Version| | Downloads |
+|:---:|:--:|:--:|:--:|
+| Nov. 16th, 2020 | 0.1.0 | Source code|
[[src]](https:
[skywalking-website] branch release-swck created (now c607754)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch release-swck in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. at c607754 Add swck 0.1.0 release This branch includes the following new commits: new c607754 Add swck 0.1.0 release The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [skywalking-website] hanahmily opened a new pull request #130: Add swck 0.1.0 release
hanahmily opened a new pull request #130: URL: https://github.com/apache/skywalking-website/pull/130 As the title indicates, add swck 0.1.0 relevant events and links to the website. Signed-off-by: Gao Hongtao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-website] branch asf-site updated (dcea2ca -> 00f074f)
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git.
discard dcea2ca Update asf-site
new 00f074f Update asf-site
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (dcea2ca)
\
N -- N -- N refs/heads/asf-site (00f074f)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
404.html | 6 +-
assets/js/{27.4d981909.js => 27.3616d1ff.js} | 2 +-
assets/js/28.26f5d2e5.js | 1 +
assets/js/28.324f5dc8.js | 1 -
assets/js/38.865df0fa.js | 1 -
assets/js/38.eab7165c.js | 1 +
assets/js/{43.f40a53df.js => 43.026a40af.js} | 2 +-
assets/js/44.a5de7fb0.js | 1 -
assets/js/44.b3e93688.js | 1 +
assets/js/{app.bf419c0a.js => app.c5d2f1d2.js} | 6 +-
blog/2018-05-24-skywalking-net.html| 12 ++--
blog/2018-12-12-skywalking-service-mesh-ready.html | 12 ++--
blog/2019-01-01-Understand-Trace.html | 12 ++--
blog/2019-01-25-mesh-loadtest.html | 12 ++--
blog/2019-09-25-alarm-webhook-share.html | 12 ++--
blog/2020-01-20-celebrate-200th-contributor.html | 12 ++--
blog/2020-07-26-apdex-and-skywalking.html | 12 ++--
blog/2020-08-03-skywalking8-1-release.html | 12 ++--
blog/2020-08-11-observability-at-scale.html| 12 ++--
blog/2020-10-29-skywalking8-2-release.html | 12 ++--
blog/index.html| 12 ++--
downloads/index.html | 14 +++--
events/index.html | 14 +++--
index.html | 14 +++--
team/index.html| 12 ++--
zh/blog/2018-05-24-skywalking-net.html | 12 ++--
...2018-12-18-Apache-SkyWalking-5-0-UserGuide.html | 12 ++--
...018-12-21-SkyWalking-apm-sniffer-beginning.html | 12 ++--
.../2018-12-21-SkyWalking-source-code-read.html| 12 ++--
zh/blog/2019-01-02-Understand-trace-trans2cn.html | 12 ++--
.../2019-01-02-skywalking-elasticsearch-basic.html | 12 ++--
zh/blog/2019-01-03-monitor-microservice.html | 12 ++--
zh/blog/2019-01-21-agent-plugin-practice.html | 12 ++--
zh/blog/2019-01-24-skywalking-remote-debug.html| 12 ++--
zh/blog/2019-02-24-skywalking-pk-pinpoint.html | 12 ++--
zh/blog/2019-03-01-skywalking-troubleshoot.html| 12 ++--
...oduction-of-skywalking-and-simple-practice.html | 12 ++--
.../2019-08-30-how-to-use-Skywalking-Agent.html| 12 ++--
...-apache-skyWalking-committer-apply-process.html | 12 ++--
zh/blog/2019-10-08-how-to-use-sw-chart.html| 12 ++--
...walking-elasticsearch-storage-optimization.html | 12 ++--
...-fix-the-blind-spot-of-distributed-tracing.html | 12 ++--
zh/blog/2020-04-19-skywalking-quick-start.html | 70 --
zh/blog/2020-04-28-skywalking-and-mosn.html| 12 ++--
zh/blog/2020-07-26-apdex-and-skywalking.html | 12 ++--
...11-observability-at-scale-skywalking-it-is.html | 12 ++--
zh/blog/2020-10-29-skywalking8-2-release.html | 12 ++--
zh/blog/index.html | 12 ++--
zh/doc/index.html | 12 ++--
zh/downloads/index.html| 14 +++--
zh/events/index.html | 14 +++--
zh/index.html | 14 +++--
zh/team/index.html | 12 ++--
53 files changed, 390 insertions(+), 218 deletions(-)
rename assets/js/{27.4d981909.js => 27.3616d1ff.js} (60%)
create mode 100644 assets/js/28.26f5d2e5.js
delete mode 100644 assets/js/28.324f5dc8.js
delete mode 100644 assets/js/38.865df0fa.js
create mode 100644 assets/js/38.eab7165c.js
rename assets/js/{43.f40a53df.js => 43.026a40af.js} (62%)
delete mode 100644 assets/js/44.a5de7fb0.js
create mode 100644 assets/js/44.b3e93688.js
rename assets/js/{app.bf419c0a.js => app.c5d2f1d2.js} (70%)
[GitHub] [skywalking-website] arugal commented on a change in pull request #130: Add swck 0.1.0 release
arugal commented on a change in pull request #130: URL: https://github.com/apache/skywalking-website/pull/130#discussion_r524295250 ## File path: docs/README.md ## @@ -27,6 +27,9 @@ user: news: title: Events & News content: + - header: SkyWalking Cloud on Kubernetes 0.1.0 is released +content: OAPServer CRDs and controller +time: Nov. 16th, 2020 Review comment: Seems to have missed remove expired event :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources
hanahmily commented on a change in pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#discussion_r524327605 ## File path: docs/en/concepts-and-designs/scope-definitions.md ## @@ -29,6 +29,7 @@ Calculate the metrics data from each request of the service. | responseCode | Represent the response code of HTTP response, if this request is the HTTP call | | int| | type | Represent the type of each request. Such as: Database, HTTP, RPC, gRPC. | | enum | | tags | Represent the labels of each request and each value is made up with the `TagKey:TagValue` in the segment. | | `List` | +| sideCar.internalErrorCode | Represent the sidecar/proxy internal error code, the value bases on the implementation. | | string| Review comment: FWIK, "proxy" is a more general name than `sidecar`. The latter one is often put together with "gateway" as Istio does, and therefore I prefer to use "proxy.internalErrorCode" instead of "sidecar.internalErrorCode". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources
wu-sheng commented on a change in pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#discussion_r524329616 ## File path: docs/en/concepts-and-designs/scope-definitions.md ## @@ -29,6 +29,7 @@ Calculate the metrics data from each request of the service. | responseCode | Represent the response code of HTTP response, if this request is the HTTP call | | int| | type | Represent the type of each request. Such as: Database, HTTP, RPC, gRPC. | | enum | | tags | Represent the labels of each request and each value is made up with the `TagKey:TagValue` in the segment. | | `List` | +| sideCar.internalErrorCode | Represent the sidecar/proxy internal error code, the value bases on the implementation. | | string| Review comment: In the Istio concept, yes, I agree. But note here, we are adding a description for a service. If this is a gateway, as you mentioned, the service itself is the gateway, rather than this. Also, for the gateway case, actually, there is no point to indicate whether sidecar issue or not, all errors are gateway's issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources
wu-sheng commented on a change in pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#discussion_r524329962 ## File path: docs/en/concepts-and-designs/scope-definitions.md ## @@ -29,6 +29,7 @@ Calculate the metrics data from each request of the service. | responseCode | Represent the response code of HTTP response, if this request is the HTTP call | | int| | type | Represent the type of each request. Such as: Database, HTTP, RPC, gRPC. | | enum | | tags | Represent the labels of each request and each value is made up with the `TagKey:TagValue` in the segment. | | `List` | +| sideCar.internalErrorCode | Represent the sidecar/proxy internal error code, the value bases on the implementation. | | string| Review comment: As the attachment, I don't want it to be a `proxy`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] huangcanhui2018 commented on issue #5850: Does skywalking 8.x support spring cloud gateway version 2.2.x ?
huangcanhui2018 commented on issue #5850: URL: https://github.com/apache/skywalking/issues/5850#issuecomment-728124063 Referring to the test example given above, I also tested it with the following version: 1) spring boot 2.2.10.RELEASE 2) spring cloud Hoxton.SR5 3) spring cloud gateway 2.2.3.RELEASE The results as follows: The traceId obtained by spring cloud gateway, sc-consumer and sc-provider is still independent. The traceId obtained by spring cloud gateway is "A", and traceId obtained by sc-consumer and sc-provider is "B". So the whole request trace cannot be connected in series by traceId . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5850: Does skywalking 8.x support spring cloud gateway version 2.2.x ?
wu-sheng commented on issue #5850: URL: https://github.com/apache/skywalking/issues/5850#issuecomment-728125522 I don't know how you test. We don't test manually, SkyWalking check this case with the expected trace data automatically, https://github.com/apache/skywalking/blob/master/test/plugin/scenarios/gateway-2.1.x-scenario/config/expectedData.yaml. Read the test scenario deeper. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources
hanahmily commented on a change in pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#discussion_r524350904 ## File path: docs/en/concepts-and-designs/scope-definitions.md ## @@ -29,6 +29,7 @@ Calculate the metrics data from each request of the service. | responseCode | Represent the response code of HTTP response, if this request is the HTTP call | | int| | type | Represent the type of each request. Such as: Database, HTTP, RPC, gRPC. | | enum | | tags | Represent the labels of each request and each value is made up with the `TagKey:TagValue` in the segment. | | `List` | +| sideCar.internalErrorCode | Represent the sidecar/proxy internal error code, the value bases on the implementation. | | string| Review comment: > Also, for the gateway case, actually, there is no point to indicate whether sidecar issue or not, all errors are gateway's issue. Definitely, a gateway is abstracted to service, but it still needs `sidecar.` to represent this dimension. It looks a little tricky, especially, the remarks emphasize `the sidecar/proxy internal error code`. if that, `the sidecar/gateway proxy internal error code` makes more sense to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
codecov[bot] edited a comment on pull request #5849: URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report > Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.49%`. > The diff coverage is `34.48%`. [](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5849 +/- ## - Coverage 51.20% 45.70% -5.50% + Complexity 3456 3212 -244 Files 1654 935 -719 Lines 3543623251 -12185 Branches 3861 2254-1607 - Hits 1814410628-7516 + Misses1639311716-4677 - Partials899 907 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | | | [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | | | [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | | | [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | | | [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: | | [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | | | [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | | | [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | | | ... and [1188 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more)
