[GitHub] [incubator-superset] stale[bot] closed pull request #7298: Update packages for Debian and RHEL derivatives
stale[bot] closed pull request #7298: Update packages for Debian and RHEL derivatives URL: https://github.com/apache/incubator-superset/pull/7298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8115: feat: bump superset-ui dependencies to v0.12 and plugins to v0.11
villebro commented on issue #8115: feat: bump superset-ui dependencies to v0.12 and plugins to v0.11 URL: https://github.com/apache/incubator-superset/pull/8115#issuecomment-525133841 Thanks @kristw , will implement `durationFormatter` once this is merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #8109: Moving towards a whitelist approach for MANIFEST.in
craig-rueda commented on a change in pull request #8109: Moving towards a whitelist approach for MANIFEST.in URL: https://github.com/apache/incubator-superset/pull/8109#discussion_r317879421 ## File path: MANIFEST.in ## @@ -20,15 +20,15 @@ graft licenses/ include README.md recursive-include superset/examples * recursive-include superset/migrations * -recursive-include superset/static * -recursive-exclude superset/static/assets/docs * -recursive-exclude superset/static/assets/images/viz_thumbnails_large * -recursive-exclude superset/static/docs * -recursive-exclude superset/static/spec * -recursive-exclude superset/static/assets/src * -recursive-include superset/static/assets/src/visualizations/CountryMap/ * + +# Whitelist anything that needs to be added to the static bundle +recursive-exclude superset/static * +recursive-include superset/static/assets/branding * +recursive-include superset/static/assets/dist * +recursive-include superset/static/assets/images * recursive-exclude superset/static/images/viz_thumbnails_large * -recursive-exclude superset/static/assets/node_modules * +recursive-include superset/static/assets/stylesheets * Review comment: Not sure I'm clear here. You want me to just exclude the `stylesheets` folder? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #8109: Moving towards a whitelist approach for MANIFEST.in
craig-rueda commented on a change in pull request #8109: Moving towards a whitelist approach for MANIFEST.in URL: https://github.com/apache/incubator-superset/pull/8109#discussion_r317879170 ## File path: superset/config.py ## @@ -48,9 +48,22 @@ # Superset specific config # - PACKAGE_DIR = os.path.join(BASE_DIR, "static", "assets") -PACKAGE_FILE = os.path.join(PACKAGE_DIR, "package.json") -with open(PACKAGE_FILE) as package_file: -VERSION_STRING = json.load(package_file)["version"] +VERSION_INFO_FILE = os.path.join(PACKAGE_DIR, "version_info.json") Review comment: Need to leave both, as mentioned in the comment above -- ``` # Depending on the context in which this config is loaded, the version_info.json file # may or may not be available, as it is generated on install via setup.py. In the event # that we're actually running Superset, we will have already installed, therefore it WILL # exist. When unit tests are running, however, it WILL NOT exist, so we fall # back to reading package.json ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #8109: Moving towards a whitelist approach for MANIFEST.in
craig-rueda commented on a change in pull request #8109: Moving towards a whitelist approach for MANIFEST.in URL: https://github.com/apache/incubator-superset/pull/8109#discussion_r317879170 ## File path: superset/config.py ## @@ -48,9 +48,22 @@ # Superset specific config # - PACKAGE_DIR = os.path.join(BASE_DIR, "static", "assets") -PACKAGE_FILE = os.path.join(PACKAGE_DIR, "package.json") -with open(PACKAGE_FILE) as package_file: -VERSION_STRING = json.load(package_file)["version"] +VERSION_INFO_FILE = os.path.join(PACKAGE_DIR, "version_info.json") Review comment: Need to leave both, as mentioned in the comment above -- ```# Depending on the context in which this config is loaded, the version_info.json file # may or may not be available, as it is generated on install via setup.py. In the event # that we're actually running Superset, we will have already installed, therefore it WILL # exist. When unit tests are running, however, it WILL NOT exist, so we fall # back to reading package.json``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on a change in pull request #8117: Fix to werkzeug proxy; expose additional configuration items
ericandrewmeadows commented on a change in pull request #8117: Fix to werkzeug
proxy; expose additional configuration items
URL:
https://github.com/apache/incubator-superset/pull/8117#discussion_r317851662
##
File path: superset/config.py
##
@@ -111,6 +111,13 @@
# Extract and use X-Forwarded-For/X-Forwarded-Proto headers?
ENABLE_PROXY_FIX = False
+PROXY_FIX_CONFIG = {
Review comment:
This was validated to fix the issue with CSM, when `ENABLE_PROXY_FIX` is set
to `True`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on a change in pull request #8117: Fix to werkzeug proxy; expose additional configuration items
ericandrewmeadows commented on a change in pull request #8117: Fix to werkzeug proxy; expose additional configuration items URL: https://github.com/apache/incubator-superset/pull/8117#discussion_r317851558 ## File path: superset/__init__.py ## @@ -29,7 +29,6 @@ from flask_migrate import Migrate from flask_talisman import Talisman from flask_wtf.csrf import CSRFProtect -from werkzeug.contrib.fixers import ProxyFix Review comment: I felt like this should only be imported if it was configured to be `True`, inline with import strategy below. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on a change in pull request #8117: Fix to werkzeug proxy; expose additional configuration items
ericandrewmeadows commented on a change in pull request #8117: Fix to werkzeug proxy; expose additional configuration items URL: https://github.com/apache/incubator-superset/pull/8117#discussion_r317851459 ## File path: setup.py ## @@ -72,7 +72,7 @@ def get_git_sha(): "contextlib2", "croniter>=0.3.28", "cryptography>=2.4.2", -"flask>=1.0.0, <2.0.0", +"flask>=1.1.0, <2.0.0", Review comment: This follows https://github.com/apache/airflow/pull/5571 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows opened a new pull request #8117: Fix to werkzeug proxy; expose additional configuration items
ericandrewmeadows opened a new pull request #8117: Fix to werkzeug proxy; expose additional configuration items URL: https://github.com/apache/incubator-superset/pull/8117 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Custom Security Manager appeared to be broken when behind an AWS ALB, but when I dug further, the Werkzeug version was bumped. This caused an invalid configuration for the proxy in that the host was not passed on. Because of this, along with the change of the library path, and the inclusion of the additional library bump in accordance with https://github.com/apache/airflow/pull/5571, I have validated that the regression that prevented CSM from working in v0.33.0rc1 -> v0.34.0rc [1 & 2] has been resolved. ### TEST PLAN I deployed internally the fix, and validated that the port is not being returned in the header for the destination after hitting the root IP of the Superset instance. ### ADDITIONAL INFORMATION - [x] Has associated issue: - Fixes #8062 - Fixes #8110 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] michellethomas opened a new pull request #8116: Testing a fix to cypress build
michellethomas opened a new pull request #8116: Testing a fix to cypress build URL: https://github.com/apache/incubator-superset/pull/8116 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [x] Build / Development Environment - [ ] Documentation ### SUMMARY There's an issue with travis where npm errors with `zlib: unexpected end of file`. When I google this, the suggestion is to clean the cache. Testing to see if it works. ### TEST PLAN CI ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8101: Add limit as filter option
mistercrunch commented on a change in pull request #8101: Add limit as filter
option
URL:
https://github.com/apache/incubator-superset/pull/8101#discussion_r317838264
##
File path:
superset/assets/src/explore/components/controls/FilterBoxItemControl.jsx
##
@@ -159,6 +161,17 @@ export default class FilterBoxItemControl extends
React.Component {
/>
}
/>
+
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8101: Add limit as filter option
mistercrunch commented on a change in pull request #8101: Add limit as filter
option
URL:
https://github.com/apache/incubator-superset/pull/8101#discussion_r317838264
##
File path:
superset/assets/src/explore/components/controls/FilterBoxItemControl.jsx
##
@@ -159,6 +161,17 @@ export default class FilterBoxItemControl extends
React.Component {
/>
}
/>
+
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8101: Add limit as filter option
mistercrunch commented on a change in pull request #8101: Add limit as filter
option
URL:
https://github.com/apache/incubator-superset/pull/8101#discussion_r317838264
##
File path:
superset/assets/src/explore/components/controls/FilterBoxItemControl.jsx
##
@@ -159,6 +161,17 @@ export default class FilterBoxItemControl extends
React.Component {
/>
}
/>
+
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8115: feat: bump superset-ui dependencies to v0.12 and plugins to v0.11
mistercrunch commented on a change in pull request #8115: feat: bump
superset-ui dependencies to v0.12 and plugins to v0.11
URL:
https://github.com/apache/incubator-superset/pull/8115#discussion_r317836663
##
File path: superset/assets/package.json
##
@@ -46,42 +46,44 @@
},
"homepage": "https://superset.apache.org/;,
"dependencies": {
+"@airbnb/lunar": "~2.23.0",
Review comment:
How is this used / referenced?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #8111: removed database deps from reqs-dev.txt and typo.
mistercrunch merged pull request #8111: removed database deps from reqs-dev.txt and typo. URL: https://github.com/apache/incubator-superset/pull/8111 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8109: Moving towards a whitelist approach for MANIFEST.in
mistercrunch commented on a change in pull request #8109: Moving towards a whitelist approach for MANIFEST.in URL: https://github.com/apache/incubator-superset/pull/8109#discussion_r317798033 ## File path: MANIFEST.in ## @@ -20,15 +20,15 @@ graft licenses/ include README.md recursive-include superset/examples * recursive-include superset/migrations * -recursive-include superset/static * -recursive-exclude superset/static/assets/docs * -recursive-exclude superset/static/assets/images/viz_thumbnails_large * -recursive-exclude superset/static/docs * -recursive-exclude superset/static/spec * -recursive-exclude superset/static/assets/src * -recursive-include superset/static/assets/src/visualizations/CountryMap/ * + +# Whitelist anything that needs to be added to the static bundle +recursive-exclude superset/static * +recursive-include superset/static/assets/branding * +recursive-include superset/static/assets/dist * +recursive-include superset/static/assets/images * recursive-exclude superset/static/images/viz_thumbnails_large * -recursive-exclude superset/static/assets/node_modules * +recursive-include superset/static/assets/stylesheets * Review comment: Looks like `cosmoTheme.js` is the only file needed, but just to serve `/superset/theme` which is a test page while tweaking the CSS theme. The folder weighs `236K`, so I vote to remove it while at it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on issue #8062: CUSTOM_SECURITY_MANAGER not working in 0.34.0rc1
ericandrewmeadows commented on issue #8062: CUSTOM_SECURITY_MANAGER not working in 0.34.0rc1 URL: https://github.com/apache/incubator-superset/issues/8062#issuecomment-525030571 Testing a proposed fix for this and will put up a PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kristw opened a new pull request #8115: feat: bump superset-ui dependencies to v0.12 and plugins to v0.11
kristw opened a new pull request #8115: feat: bump superset-ui dependencies to v0.12 and plugins to v0.11 URL: https://github.com/apache/incubator-superset/pull/8115 ### CATEGORY Choose one - [X] Enhancement (new features, refinement) - [X] Refactor ### SUMMARY * Upgrade `@superset-ui` packages to `0.12` * Upgrade `@superset-ui-plugins` packages to `0.11` * Make changes to `filter_box`, `time_table` and `deck.gl` plugins that reside in this main repo to conform to the new APIs. (See migration guide from [this PR](https://github.com/apache-superset/superset-ui-plugins/pull/183)) ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF  ### TEST PLAN * Verify that all charts are working like before * Try setting table filter ### REVIEWERS @etr2460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on issue #8062: CUSTOM_SECURITY_MANAGER not working in 0.34.0rc1
ericandrewmeadows commented on issue #8062: CUSTOM_SECURITY_MANAGER not working in 0.34.0rc1 URL: https://github.com/apache/incubator-superset/issues/8062#issuecomment-525021202 The symptom is very direct, now that I was able to trace it out even more: `ENABLE_PROXY_FIX` is the piece which is wrong. The port is bring appended to requests in the header, which is causing routing issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8109: Moving towards a whitelist approach for MANIFEST.in
mistercrunch commented on a change in pull request #8109: Moving towards a whitelist approach for MANIFEST.in URL: https://github.com/apache/incubator-superset/pull/8109#discussion_r317782307 ## File path: superset/config.py ## @@ -48,9 +48,22 @@ # Superset specific config # - PACKAGE_DIR = os.path.join(BASE_DIR, "static", "assets") -PACKAGE_FILE = os.path.join(PACKAGE_DIR, "package.json") -with open(PACKAGE_FILE) as package_file: -VERSION_STRING = json.load(package_file)["version"] +VERSION_INFO_FILE = os.path.join(PACKAGE_DIR, "version_info.json") Review comment: I think this belongs in another PR... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8109: Moving towards a whitelist approach for MANIFEST.in
mistercrunch commented on a change in pull request #8109: Moving towards a whitelist approach for MANIFEST.in URL: https://github.com/apache/incubator-superset/pull/8109#discussion_r317781874 ## File path: MANIFEST.in ## @@ -20,15 +20,15 @@ graft licenses/ include README.md recursive-include superset/examples * recursive-include superset/migrations * -recursive-include superset/static * -recursive-exclude superset/static/assets/docs * -recursive-exclude superset/static/assets/images/viz_thumbnails_large * -recursive-exclude superset/static/docs * -recursive-exclude superset/static/spec * -recursive-exclude superset/static/assets/src * -recursive-include superset/static/assets/src/visualizations/CountryMap/ * + +# Whitelist anything that needs to be added to the static bundle +recursive-exclude superset/static * +recursive-include superset/static/assets/branding * +recursive-include superset/static/assets/dist * +recursive-include superset/static/assets/images * recursive-exclude superset/static/images/viz_thumbnails_large * -recursive-exclude superset/static/assets/node_modules * +recursive-include superset/static/assets/stylesheets * Review comment: I don't think this is required as it should make it into the `dist/` folder (webpack), though this may be an expection: `superset/templates/superset/theme.html: ` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ali-bahjati commented on issue #8103: UI styles don't load (silently, without any error)
ali-bahjati commented on issue #8103: UI styles don't load (silently, without any error) URL: https://github.com/apache/incubator-superset/issues/8103#issuecomment-525007720 I got it working with 0.34rc2 but I did a clean reinstallation. (Removed everything and reinstalled, though I kept the DB intact) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on issue #8113: Infinite Redirect loop when using JWT Token based CustomAuth
ericandrewmeadows commented on issue #8113: Infinite Redirect loop when using JWT Token based CustomAuth URL: https://github.com/apache/incubator-superset/issues/8113#issuecomment-524997873 @durchgedreht - can you verify this on v0.33.0rc1? I think there is a lot of stuff happening with redirects on v0.34.0rc1, and v0.34.0rc2 with respect to Custom Security Managers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on issue #8062: CUSTOM_SECURITY_MANAGER not working in 0.34.0rc1
ericandrewmeadows commented on issue #8062: CUSTOM_SECURITY_MANAGER not working in 0.34.0rc1 URL: https://github.com/apache/incubator-superset/issues/8062#issuecomment-524997062 @dpgaspar - no go on that. There is something in the routes which is circumventing the security manager with v0.34.0rc (1, and 2). Relevant settings from above, tested just now: ``` ENABLE_PROXY_FIX = True TALISMAN_ENABLED = False ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] notatallshaw commented on issue #8103: UI styles don't load (silently, without any error)
notatallshaw commented on issue #8103: UI styles don't load (silently, without any error) URL: https://github.com/apache/incubator-superset/issues/8103#issuecomment-524991598 I seem to be getting this same problem, I tried 0.34 and 0.34rc2. Which version did you get working? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed issue #7742: Error while trying Horizon Visualization
stale[bot] closed issue #7742: Error while trying Horizon Visualization URL: https://github.com/apache/incubator-superset/issues/7742 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #7765: When connecting to the oracle database, an error is reported when making a line chart
villebro commented on issue #7765: When connecting to the oracle database, an error is reported when making a line chart URL: https://github.com/apache/incubator-superset/issues/7765#issuecomment-524956576 I think service_name should be equal to the TNS name. This is how the URI on my dev rig looks like (running Oracle locally on docker): `oracle+cx_oracle://system:XX@localhost:49161/?service_name=xe` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] michellethomas merged pull request #8104: [logging] add query id to SQL Lab logs
michellethomas merged pull request #8104: [logging] add query id to SQL Lab logs URL: https://github.com/apache/incubator-superset/pull/8104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] michellethomas merged pull request #8098: [Hive Engine Spec] Fix latest partition logic
michellethomas merged pull request #8098: [Hive Engine Spec] Fix latest partition logic URL: https://github.com/apache/incubator-superset/pull/8098 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed pull request #7740: Favicon as config setting
stale[bot] closed pull request #7740: Favicon as config setting URL: https://github.com/apache/incubator-superset/pull/7740 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #8099: Allow resizing width of SQL Lab left bar / editor
betodealmeida merged pull request #8099: Allow resizing width of SQL Lab left bar / editor URL: https://github.com/apache/incubator-superset/pull/8099 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8109: Moving towards a whitelist approach for MANIFEST.in
codecov-io edited a comment on issue #8109: Moving towards a whitelist approach for MANIFEST.in URL: https://github.com/apache/incubator-superset/pull/8109#issuecomment-524563933 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=h1) Report > Merging [#8109](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ee75d03df47039e9855b801e5926a7cdb8dc9826?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `87.5%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=tree) ```diff @@Coverage Diff@@ ## master #8109 +/- ## = + Coverage 65.89% 65.9% +<.01% = Files 485 485 Lines 22917 22922 +5 Branches 25372537 = + Hits15102 15106 +4 - Misses 76837684 +1 Partials 132 132 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/8109/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `88.46% <87.5%> (-0.24%)` | :arrow_down: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/8109/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.27% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=footer). Last update [ee75d03...6936c1c](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8109: Moving towards a whitelist approach for MANIFEST.in
codecov-io edited a comment on issue #8109: Moving towards a whitelist approach for MANIFEST.in URL: https://github.com/apache/incubator-superset/pull/8109#issuecomment-524563933 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=h1) Report > Merging [#8109](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ee75d03df47039e9855b801e5926a7cdb8dc9826?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `87.5%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=tree) ```diff @@Coverage Diff@@ ## master #8109 +/- ## = + Coverage 65.89% 65.9% +<.01% = Files 485 485 Lines 22917 22922 +5 Branches 25372537 = + Hits15102 15106 +4 - Misses 76837684 +1 Partials 132 132 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/8109/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `88.46% <87.5%> (-0.24%)` | :arrow_down: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/8109/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.27% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=footer). Last update [ee75d03...6936c1c](https://codecov.io/gh/apache/incubator-superset/pull/8109?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] smokemonster99 commented on issue #8102: Dashboard filters do not persist on page refresh
smokemonster99 commented on issue #8102: Dashboard filters do not persist on page refresh URL: https://github.com/apache/incubator-superset/issues/8102#issuecomment-524885724 @kaspergaj Thanks for the reply but that is not going to solve my issue as I do not want the dashboard to permanently change. If the browser url would change when I apply the filters, then I would not lose my filters (and have to reapply them) if I refresh the page. It also helps in being able to share filtered dashboard links using browser url. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] shahamit commented on issue #7765: When connecting to the oracle database, an error is reported when making a line chart
shahamit commented on issue #7765: When connecting to the oracle database, an
error is reported when making a line chart
URL:
https://github.com/apache/incubator-superset/issues/7765#issuecomment-524871607
What is the 'SQLAlchemy URI' that we should give when adding a new oracle
database? Specifying the below string with valid values isn't working out
`engine = create_engine('oracle://scott:tiger@127.0.0.1:1521/service_name')`
I am struggling to form the uri string for oracle. Kindly suggest.
Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] felexkemboi commented on issue #3271: date type field display error
felexkemboi commented on issue #3271: date type field display error URL: https://github.com/apache/incubator-superset/issues/3271#issuecomment-524862549 >  > Getting the same error for 0.20.6 > Database - Clickhouse, column type: Date > Date comes properly when in Pivot Table view. Is messed up with Table View and in Time Dashboard Filter, when using the date column in Filter Column. Any solution to this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] felexkemboi commented on issue #3271: date type field display error
felexkemboi commented on issue #3271: date type field display error URL: https://github.com/apache/incubator-superset/issues/3271#issuecomment-524862275 Actually this is the exact problem i am facing.How am i suppose to get out of it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kaspergaj commented on issue #8102: Dashboard filters do not persist on page refresh
kaspergaj commented on issue #8102: Dashboard filters do not persist on page refresh URL: https://github.com/apache/incubator-superset/issues/8102#issuecomment-524846643 After applying filters: Press the arrow next to "Edit dashboard". "Save as" That should do it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7786: deck.gl Multiple Layer no field for geospatial data
stale[bot] commented on issue #7786: deck.gl Multiple Layer no field for geospatial data URL: https://github.com/apache/incubator-superset/issues/7786#issuecomment-524841113 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7785: deck.gl GeoJson no response to GeoJson data
stale[bot] commented on issue #7785: deck.gl GeoJson no response to GeoJson data URL: https://github.com/apache/incubator-superset/issues/7785#issuecomment-524841117 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7780: Need to embed superset dashboard in iframe..
stale[bot] commented on issue #7780: Need to embed superset dashboard in iframe.. URL: https://github.com/apache/incubator-superset/issues/7780#issuecomment-524824486 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] jcoelho-pt commented on issue #7362: Pivot Table Field alias display problem
jcoelho-pt commented on issue #7362: Pivot Table Field alias display problem URL: https://github.com/apache/incubator-superset/issues/7362#issuecomment-524821511 @wushenchao Thanks! I am going to test it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8114: superset conn hive faied
issue-label-bot[bot] commented on issue #8114: superset conn hive faied URL: https://github.com/apache/incubator-superset/issues/8114#issuecomment-524788570 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.72. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] celestewang1026 opened a new issue #8114: superset conn hive faied
celestewang1026 opened a new issue #8114: superset conn hive faied
URL: https://github.com/apache/incubator-superset/issues/8114
A clear and concise description of what the bug is.
### Expected results
what you expected to happen.
### Actual results
what actually happens.
Screenshots
If applicable, add screenshots to help explain your problem.
How to reproduce the bug
1. Go to '...'
2. Click on ''
3. Scroll down to ''
4. See error
### Environment
(please complete the following information):
- superset version: `superset version`
- python version: `python --version`
- node.js version: `node -v`
- npm version: `npm -v`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version
of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't
found one similar.
### Additional context
python -- 3.7.2
PyHive 0.6.1
impyla 0.14.1
superset conn impala is good,but when conn is wrong ,have the below quetsion
the question is TCLIService confict,but how to fix it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] squalou commented on issue #7739: Custom OAuth issue
squalou commented on issue #7739: Custom OAuth issue URL: https://github.com/apache/incubator-superset/issues/7739#issuecomment-524786736 Note : I did a quick and really dirty as I'm running all this in a docker container. I changed /usr/local/lib/python3.6/site-packages/flask_appbuilder/security/views.py around line 677 - hardcoded 'provider' to 'google' (its value is 'login' which is what causes the KeyError) - hardcoded next_url to "/superset/welcome" Does the job until something better fixes it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] cycy9999 commented on issue #6389: Superset Database is locked
cycy commented on issue #6389: Superset Database is locked URL: https://github.com/apache/incubator-superset/issues/6389#issuecomment-524774144 unfortunately, no :-( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] starsunny commented on issue #6389: Superset Database is locked
starsunny commented on issue #6389: Superset Database is locked URL: https://github.com/apache/incubator-superset/issues/6389#issuecomment-524772438 @cycy Did you get any solution? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
