[GitHub] [incubator-superset] als-sdin commented on issue #6215: __init__() got an unexpected keyword argument 'ignore_nan'
als-sdin commented on issue #6215: __init__() got an unexpected keyword argument 'ignore_nan' URL: https://github.com/apache/incubator-superset/issues/6215#issuecomment-525592187 Please re-open. I just built the latest superset from scratch following CONTRIBUTING.md and this bug appeared.  I have done some investigating and found the culprit. Within _superset/viz.py_ the method `json_dumps` of class `BaseViz` calls `json.dumps` with the keyword argument `ignore_nan`. It should resolve to the **simplejson** package which accepts that keyword argument. Only `json.dumps` points to the builtin **json** library not **simplejson**. Removing the alias for **simplejson** rectifies the problem. I'm having a hard time understanding why the error occurs at all?? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] bohlian edited a comment on issue #7588: Not getting scheduled chat/dashboard emails
bohlian edited a comment on issue #7588: Not getting scheduled chat/dashboard emails URL: https://github.com/apache/incubator-superset/issues/7588#issuecomment-525588248 Hi guys, I am having troubles getting the menu options to show. I am using the docker version and I have set the following in config.py: `ENABLE_SCHEDULED_EMAIL_REPORTS = True EMAIL_NOTIFICATIONS = True SMTP_HOST = "somehost" SMTP_STARTTLS = True SMTP_SSL = True SMTP_USER = "someemail" SMTP_PORT = 25 SMTP_PASSWORD = "somepassword" SMTP_MAIL_FROM = "somemailfrom"` Is there something that I am missing? I see the separator in the Manage menu but not the options. Apologies for any ignorance, I am quite new to this. Thanks guys This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] bohlian edited a comment on issue #7588: Not getting scheduled chat/dashboard emails
bohlian edited a comment on issue #7588: Not getting scheduled chat/dashboard emails URL: https://github.com/apache/incubator-superset/issues/7588#issuecomment-525588248 Hi guys, I am having troubles getting the menu options to show. I am using the docker version and I have set the following in config.py: `ENABLE_SCHEDULED_EMAIL_REPORTS = True EMAIL_NOTIFICATIONS = True SMTP_HOST = "somehost" SMTP_STARTTLS = True SMTP_SSL = True SMTP_USER = "someemail" SMTP_PORT = 25 SMTP_PASSWORD = "somepassword" SMTP_MAIL_FROM = "somemailfrom"` Is there something that I am missing? Apologies for any ignorance, I am quite new to this. Thanks guys This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] bohlian commented on issue #7588: Not getting scheduled chat/dashboard emails
bohlian commented on issue #7588: Not getting scheduled chat/dashboard emails URL: https://github.com/apache/incubator-superset/issues/7588#issuecomment-525588248 Hi guys, I am having troubles getting the menu options to show. I am using the docker version and I have set the following in config.py: `ENABLE_SCHEDULED_EMAIL_REPORTS = True EMAIL_NOTIFICATIONS = True SMTP_HOST = "somehost" SMTP_STARTTLS = True SMTP_SSL = True SMTP_USER = "someemail" SMTP_PORT = 25 SMTP_PASSWORD = "somepassword" SMTP_MAIL_FROM = "somemailfrom"` Is there something that I am missing? Thanks guys This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] sandy-ha commented on issue #8122: Export as filter_box as CSV
sandy-ha commented on issue #8122: Export as filter_box as CSV URL: https://github.com/apache/incubator-superset/issues/8122#issuecomment-525580308 It is the original filter box of the World Bank Demo.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] DiggidyDave closed pull request #8096: increase node memory in tox testenv
DiggidyDave closed pull request #8096: increase node memory in tox testenv URL: https://github.com/apache/incubator-superset/pull/8096 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8131: Pivote Table Time Column Time Grain not working
issue-label-bot[bot] commented on issue #8131: Pivote Table Time Column Time Grain not working URL: https://github.com/apache/incubator-superset/issues/8131#issuecomment-525568130 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.72. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] 77creating opened a new issue #8131: Pivote Table Time Column Time Grain not working
77creating opened a new issue #8131: Pivote Table Time Column Time Grain not working URL: https://github.com/apache/incubator-superset/issues/8131 Version: 0.28.1 DB :Oracle hi all i meet a problem is the Time Grain not working on Visualization Type Pivot Table ,but on Type Time Seriese is working. https://user-images.githubusercontent.com/3654679/63822960-af92a480-c984-11e9-962d-c3356a9496cc.png;> I found that the pivot table is different from the SQL of the Time Series on time column. the pivote table is create_time the Time Series is trunc(create_time,'DD') This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] shadowera closed issue #8027: hive/impala can't show table schema
shadowera closed issue #8027: hive/impala can't show table schema URL: https://github.com/apache/incubator-superset/issues/8027 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] shadowera commented on issue #8027: hive/impala can't show table schema
shadowera commented on issue #8027: hive/impala can't show table schema URL: https://github.com/apache/incubator-superset/issues/8027#issuecomment-525553392 well, it's a matter about sparksql . it's finally solved by edit site-packages/impala/sqlalchemy.py from ``` def get_table_names(self, connection, schema=None, **kw): query = 'SHOW TABLES' if schema is not None: query += ' IN %s' % schema rreturn [tup[0] for tup in connection.execute(query).fetchall()] ``` to ``` def get_table_names(self, connection, schema=None, **kw): query = 'SHOW TABLES' if schema is not None: query += ' IN %s' % schema return [t[1] if len(t) >1 else t[0] for t in connection.execute(query).fetchall()] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8115: feat: bump superset-ui dependencies to v0.12 and plugins to v0.11
codecov-io commented on issue #8115: feat: bump superset-ui dependencies to v0.12 and plugins to v0.11 URL: https://github.com/apache/incubator-superset/pull/8115#issuecomment-525539552 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8115?src=pr=h1) Report > Merging [#8115](https://codecov.io/gh/apache/incubator-superset/pull/8115?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2085e897f53afbc2ee9c38f4be5b9f5f5ef8713c?src=pr=desc) will **decrease** coverage by `7.75%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8115?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8115 +/- ## == - Coverage 73.61% 65.86% -7.76% == Files 114 485 +371 Lines 1197222943 +10971 Branches0 2541+2541 == + Hits 881315111+6298 - Misses 3159 7698+4539 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8115?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/assets/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8115/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydC5qc3g=) | `11.11% <ø> (ø)` | | | [...et/assets/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/8115/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9wcmVzZXRzL01haW5QcmVzZXQuanM=) | `0% <ø> (ø)` | | | [...ets/src/visualizations/FilterBox/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/8115/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9GaWx0ZXJCb3gvdHJhbnNmb3JtUHJvcHMuanM=) | `0% <0%> (ø)` | | | [superset/assets/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8115/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydFJlbmRlcmVyLmpzeA==) | `7.35% <0%> (ø)` | | | [...assets/src/visualizations/deckgl/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/8115/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvdHJhbnNmb3JtUHJvcHMuanM=) | `0% <0%> (ø)` | | | [...ets/src/visualizations/TimeTable/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/8115/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9UaW1lVGFibGUvdHJhbnNmb3JtUHJvcHMuanM=) | `0% <0%> (ø)` | | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8115/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8115/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8115/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8115/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | | | ... and [367 more](https://codecov.io/gh/apache/incubator-superset/pull/8115/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8115?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8115?src=pr=footer). Last update [2085e89...5abe936](https://codecov.io/gh/apache/incubator-superset/pull/8115?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-superset] mistercrunch edited a comment on issue #7414: Missing release tags
mistercrunch edited a comment on issue #7414: Missing release tags URL: https://github.com/apache/incubator-superset/issues/7414#issuecomment-525527263 `0.34.0` is out, now we need to figure out "convenience releases" (pypi / docker/ . ...) Some instructions to build the source release, with a reference docker file to build from source https://github.com/apache/incubator-superset/tree/master/RELEASING [From my understanding,] While releasing binaries (anything that would have our minified JS bundles) in the name of the ASF forces us to have a LICENSE file detailing everything that's in that release (700+ libs in the dep tree) and may be tricky to maintain, we can easily share reference dockerfiles (as opposed to images that contain the minified bundles). The Dockerfile provided in `RELEASING/` are not optimized in any way for either build times, image size, or flexibility, but could be modified to take this into account. From my experience it can be difficult to achieve these optimizations and provide something that suits everyone. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #7414: Missing release tags
mistercrunch commented on issue #7414: Missing release tags URL: https://github.com/apache/incubator-superset/issues/7414#issuecomment-525527263 `0.34.0` is out, now we need to figure out "convenience releases" (pypi / docker/ . ...) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] micimize commented on issue #7414: Missing release tags
micimize commented on issue #7414: Missing release tags URL: https://github.com/apache/incubator-superset/issues/7414#issuecomment-525519480 @brylie [`amancevice/superset`](https://hub.docker.com/r/amancevice/superset/tags) has started [maintaining non-pypi and `edge` builds](https://github.com/amancevice/docker-superset/issues/128#issuecomment-520444298). Plenty of ASF projects have [official images](https://hub.docker.com/u/apache), so it is not precluded and will likely happen, IMO This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed issue #7754: Creating a new dashboard is not very discoverable
stale[bot] closed issue #7754: Creating a new dashboard is not very discoverable URL: https://github.com/apache/incubator-superset/issues/7754 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] micimize commented on issue #8120: pypi repo is outdated
micimize commented on issue #8120: pypi repo is outdated URL: https://github.com/apache/incubator-superset/issues/8120#issuecomment-525516342 PyPI is outdated [due to ASF-compliance process](https://github.com/apache/incubator-superset/issues/7414#issuecomment-522414927). There is an up-to-date [`unofficial-superset`](https://pypi.org/project/unofficial-superset/) maintained by [@verdan](https://github.com/verdan), which you could depend on in the meantime. > The ASF told us to not push non-ASF releases to Pypi or as Github tags until we sort out the ASF-compliant release process This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8130: removes unused state values and redundant presence checks
codecov-io commented on issue #8130: removes unused state values and redundant presence checks URL: https://github.com/apache/incubator-superset/pull/8130#issuecomment-525512108 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8130?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@7595d9e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `38.46%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8130?src=pr=tree) ```diff @@Coverage Diff@@ ## master#8130 +/- ## = Coverage ? 65.96% = Files ? 486 Lines ?23027 Branches ? 2539 = Hits ?15190 Misses? 7703 Partials ? 134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8130?src=pr=tree) | Coverage Δ | | |---|---|---| | [...sets/src/SqlLab/components/ScheduleQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8130/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TY2hlZHVsZVF1ZXJ5QnV0dG9uLmpzeA==) | `8.62% <0%> (ø)` | | | [superset/assets/src/components/ErrorBoundary.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8130/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0Vycm9yQm91bmRhcnkuanN4) | `18.18% <0%> (ø)` | | | [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8130/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9DaGFydC5qc3g=) | `70% <100%> (ø)` | | | [.../assets/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8130/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TaGFyZVNxbExhYlF1ZXJ5LmpzeA==) | `100% <100%> (ø)` | | | [.../assets/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8130/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3JMZWZ0QmFyLmpzeA==) | `40% <50%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8130?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8130?src=pr=footer). Last update [7595d9e...8c29818](https://codecov.io/gh/apache/incubator-superset/pull/8130?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch closed issue #8107: Be more restrictive around `assets/static` in MANIFEST.in
mistercrunch closed issue #8107: Be more restrictive around `assets/static` in MANIFEST.in URL: https://github.com/apache/incubator-superset/issues/8107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #8109: Moving towards a whitelist approach for MANIFEST.in
mistercrunch merged pull request #8109: Moving towards a whitelist approach for MANIFEST.in URL: https://github.com/apache/incubator-superset/pull/8109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] nytai opened a new pull request #8130: removes unused state values and redundant presence checks
nytai opened a new pull request #8130: removes unused state values and redundant presence checks URL: https://github.com/apache/incubator-superset/pull/8130 ### CATEGORY Choose one - [ ] Bug Fix - [X] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Removing used sate values Removing redundant presence checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-525491749 I'm fixing the unit tests and adding integration tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #7611: [sqllab] Cancel database query on stop
mistercrunch commented on issue #7611: [sqllab] Cancel database query on stop URL: https://github.com/apache/incubator-superset/pull/7611#issuecomment-525489870 Superseeded by #8097 (?) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #8069: [SQL Lab] Async query results serialization with MessagePack and PyArrow
mistercrunch merged pull request #8069: [SQL Lab] Async query results serialization with MessagePack and PyArrow URL: https://github.com/apache/incubator-superset/pull/8069 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #8069: [SQL Lab] Async query results serialization with MessagePack and PyArrow
mistercrunch commented on a change in pull request #8069: [SQL Lab] Async query
results serialization with MessagePack and PyArrow
URL:
https://github.com/apache/incubator-superset/pull/8069#discussion_r318303155
##
File path: superset/sql_lab.py
##
@@ -322,13 +362,22 @@ def execute_sql_statements(
key = str(uuid.uuid4())
logging.info(f"Storing results in results backend, key: {key}")
with stats_timing("sqllab.query.results_backend_write", stats_logger):
-json_payload = json.dumps(
-payload, default=json_iso_dttm_ser, ignore_nan=True
-)
+with stats_timing(
+"sqllab.query.results_backend_write_serialization",
stats_logger
+):
+serialized_payload = _serialize_payload(
+payload, results_backend_use_msgpack
+)
cache_timeout = database.cache_timeout
if cache_timeout is None:
cache_timeout = config.get("CACHE_DEFAULT_TIMEOUT", 0)
-results_backend.set(key, zlib_compress(json_payload),
cache_timeout)
+
+compressed = zlib_compress(serialized_payload)
+logging.debug(
+f"*** serialized payload size: {getsizeof(serialized_payload)}"
Review comment:
tested that
```
In [3]: import sys
In [4]: l = range(1000)
In [5]: %timeit sys.getsizeof(l)
163 ns ± 2.49 ns per loop (mean ± std. dev. of 7 runs, 1000 loops each)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #8123: Master code base table visulation Issue
etr2460 commented on issue #8123: Master code base table visulation Issue URL: https://github.com/apache/incubator-superset/issues/8123#issuecomment-525482732 We reverted the change in master, this should be resolved now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kristw merged pull request #8115: feat: bump superset-ui dependencies to v0.12 and plugins to v0.11
kristw merged pull request #8115: feat: bump superset-ui dependencies to v0.12 and plugins to v0.11 URL: https://github.com/apache/incubator-superset/pull/8115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat merged pull request #8128: Add check for calls to cache_key_wrapper
graceguo-supercat merged pull request #8128: Add check for calls to cache_key_wrapper URL: https://github.com/apache/incubator-superset/pull/8128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] xtinec commented on a change in pull request #8085: Add LogConfigurator, and add logging for CSV export
xtinec commented on a change in pull request #8085: Add LogConfigurator, and
add logging for CSV export
URL:
https://github.com/apache/incubator-superset/pull/8085#discussion_r318279522
##
File path: superset/views/core.py
##
@@ -2685,7 +2685,17 @@ def csv(self, client_id):
response.headers[
"Content-Disposition"
] = f"attachment; filename={query.name}.csv"
-logging.info("Ready to return response")
+event_info = {
Review comment:
ah, I see. I like the later approach, which is more flexible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on issue #8085: Add LogConfigurator, and add logging for CSV export
betodealmeida commented on issue #8085: Add LogConfigurator, and add logging for CSV export URL: https://github.com/apache/incubator-superset/pull/8085#issuecomment-525467275 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #8085: Add LogConfigurator, and add logging for CSV export
betodealmeida merged pull request #8085: Add LogConfigurator, and add logging for CSV export URL: https://github.com/apache/incubator-superset/pull/8085 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] DiggidyDave commented on a change in pull request #8085: Add LogConfigurator, and add logging for CSV export
DiggidyDave commented on a change in pull request #8085: Add LogConfigurator,
and add logging for CSV export
URL:
https://github.com/apache/incubator-superset/pull/8085#discussion_r318273900
##
File path: superset/views/core.py
##
@@ -2685,7 +2685,17 @@ def csv(self, client_id):
response.headers[
"Content-Disposition"
] = f"attachment; filename={query.name}.csv"
-logging.info("Ready to return response")
+event_info = {
Review comment:
The log handler will have access to the broader superset context and the
utils it provides (in this case `superset.utils.core.get_username()`). It
depends on the philosophical approach here... we could either include
everything anyone might want for auditing, or we can provide only the info
unique to the event and let the handler grab whatever else it wants. I went
with the later here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] xtinec commented on a change in pull request #8085: Add LogConfigurator, and add logging for CSV export
xtinec commented on a change in pull request #8085: Add LogConfigurator, and
add logging for CSV export
URL:
https://github.com/apache/incubator-superset/pull/8085#discussion_r318266618
##
File path: superset/views/core.py
##
@@ -2685,7 +2685,17 @@ def csv(self, client_id):
response.headers[
"Content-Disposition"
] = f"attachment; filename={query.name}.csv"
-logging.info("Ready to return response")
+event_info = {
Review comment:
Do we care to log the user who performed the csv export for auditing
purposes?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ziusware opened a new issue #8129: LDAP CONNECTION ON SUPERSET
ziusware opened a new issue #8129: LDAP CONNECTION ON SUPERSET URL: https://github.com/apache/incubator-superset/issues/8129 **Is your feature request related to a problem? Please describe.** I was trying to connect more than one domain on my Superset, but I think Superset does not permit that. When I try to connect more than one LDAP SERVER the Superset doesn't accept because on his source code he just accept one parameter. **Describe the solution you'd like** Ask for a option to add more than one domain on Superset. **Describe alternatives you've considered** Superset just permit us to connect just one LDAP connection with the parameters below: AUTH_LDAP_SERVER = "" AUTH_LDAP_USE_TLS = False AUTH_LDAP_BIND_USER = "" AUTH_LDAP_BIND_PASSWORD = "" AUTH_LDAP_SEARCH = "" AUTH_LDAP_UID_FIELD = "" AUTH_LDAP_FIRSTNAME_FIELD = "" AUTH_LDAP_LASTNAME_FIELD = "" If we can use a separition to connect one more domain, ou many others, separating them with a space or a comma it would be very useful. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8129: LDAP CONNECTION ON SUPERSET
issue-label-bot[bot] commented on issue #8129: LDAP CONNECTION ON SUPERSET URL: https://github.com/apache/incubator-superset/issues/8129#issuecomment-525444631 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.74. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #8128: Add check for calls to cache_key_wrapper
villebro commented on a change in pull request #8128: Add check for calls to
cache_key_wrapper
URL:
https://github.com/apache/incubator-superset/pull/8128#discussion_r318247117
##
File path: superset/connectors/sqla/models.py
##
@@ -1064,9 +1065,31 @@ def query_datasources_by_name(cls, session, database,
datasource_name, schema=No
def default_query(qry):
return qry.filter_by(is_sqllab_view=False)
+def has_extra_cache_keys(self, query_obj: Dict) -> bool:
+"""
+Detects the presence of calls to cache_key_wrapper in items in
query_obj that can
+be templated.
+
+:param query_obj: query object to analyze
+:return: True if at least one item calls cache_key_wrapper, otherwise
False
+"""
+regex = re.compile(r"\{\{.*cache_key_wrapper\(.*\).*\}\}")
+templatable_statements: List[str] = []
+templatable_statements.append(self.sql)
+extras = query_obj.get("extras", {})
Review comment:
No, for now just these four (you can search for
`template_processor.process_template`). Will try to think about a more elegant
solution.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8128: Add check for calls to cache_key_wrapper
etr2460 commented on a change in pull request #8128: Add check for calls to
cache_key_wrapper
URL:
https://github.com/apache/incubator-superset/pull/8128#discussion_r318244262
##
File path: superset/connectors/sqla/models.py
##
@@ -1064,9 +1065,31 @@ def query_datasources_by_name(cls, session, database,
datasource_name, schema=No
def default_query(qry):
return qry.filter_by(is_sqllab_view=False)
+def has_extra_cache_keys(self, query_obj: Dict) -> bool:
+"""
+Detects the presence of calls to cache_key_wrapper in items in
query_obj that can
+be templated.
+
+:param query_obj: query object to analyze
+:return: True if at least one item calls cache_key_wrapper, otherwise
False
+"""
+regex = re.compile(r"\{\{.*cache_key_wrapper\(.*\).*\}\}")
+templatable_statements: List[str] = []
+templatable_statements.append(self.sql)
+extras = query_obj.get("extras", {})
Review comment:
is there anyplace else in `query_obj` that might have these templates? Maybe
`filter` or `groupby`? Not sure if that's already included in `self.sql`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8128: Add check for calls to cache_key_wrapper
etr2460 commented on a change in pull request #8128: Add check for calls to
cache_key_wrapper
URL:
https://github.com/apache/incubator-superset/pull/8128#discussion_r318244861
##
File path: superset/connectors/sqla/models.py
##
@@ -1064,9 +1065,31 @@ def query_datasources_by_name(cls, session, database,
datasource_name, schema=No
def default_query(qry):
return qry.filter_by(is_sqllab_view=False)
+def has_extra_cache_keys(self, query_obj: Dict) -> bool:
+"""
+Detects the presence of calls to cache_key_wrapper in items in
query_obj that can
+be templated.
+
+:param query_obj: query object to analyze
+:return: True if at least one item calls cache_key_wrapper, otherwise
False
+"""
+regex = re.compile(r"\{\{.*cache_key_wrapper\(.*\).*\}\}")
+templatable_statements: List[str] = []
+templatable_statements.append(self.sql)
+extras = query_obj.get("extras", {})
+templatable_statements.append(extras.get("where", ""))
+templatable_statements.append(extras.get("having", ""))
+for statement in templatable_statements:
+if regex.search(statement):
+return True
+return False
+
def get_extra_cache_keys(self, query_obj: Dict) -> List[Any]:
-sqla_query = self.get_sqla_query(**query_obj)
-return sqla_query.extra_cache_keys
+extra_cache_keys = []
+if self.has_extra_cache_keys(query_obj):
+sqla_query = self.get_sqla_query(**query_obj)
+extra_cache_keys = sqla_query.extra_cache_keys
Review comment:
a nit, but i think the function is cleaner as:
```
def get_extra_cache_keys(self, query_obj: Dict) -> List[Any]:
if self.has_extra_cache_keys(query_obj):
sqla_query = self.get_sqla_query(**query_obj)
return sqla_query.extra_cache_keys
return []
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro opened a new pull request #8128: Add check for calls to cache_key_wrapper
villebro opened a new pull request #8128: Add check for calls to cache_key_wrapper URL: https://github.com/apache/incubator-superset/pull/8128 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [x] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY This PR adds a check to see if any component of `query_obj` contains calls to `cache_key_wrapper()`. If not, the query is not compiled if it is already cached. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN CI ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @etr2460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #8086: [SIP] Step/Funnel Step Visualization (American Express)
etr2460 commented on issue #8086: [SIP] Step/Funnel Step Visualization (American Express) URL: https://github.com/apache/incubator-superset/pull/8086#issuecomment-525429598 It looks like you didn't run any of the auto formatters, you should take a look at `CONTRIBUTING.md` for instructions. You can also see what's failing in your build here: https://travis-ci.org/apache/incubator-superset/builds/575439543?utm_source=github_status_medium=notification This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] michellethomas closed pull request #8116: Testing a fix to cypress build
michellethomas closed pull request #8116: Testing a fix to cypress build URL: https://github.com/apache/incubator-superset/pull/8116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7611: [sqllab] Cancel database query on stop
stale[bot] commented on issue #7611: [sqllab] Cancel database query on stop URL: https://github.com/apache/incubator-superset/pull/7611#issuecomment-525418333 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #7816: Add cache_key_wrapper to Jinja template processor
villebro commented on issue #7816: Add cache_key_wrapper to Jinja template
processor
URL:
https://github.com/apache/incubator-superset/pull/7816#issuecomment-525407130
I propose introducing a method `uses_jinja_templates()` which checks the
query and filters for `{{.*cache_key_wrapper(.*}}` or similar, and if none are
present, doesn't do the double compilation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #7816: Add cache_key_wrapper to Jinja template processor
etr2460 commented on issue #7816: Add cache_key_wrapper to Jinja template processor URL: https://github.com/apache/incubator-superset/pull/7816#issuecomment-525403232 @villebro: We’re running into an issue where charts and dashboards are significantly slower after your change. This seems to be because we’re “compiling” the query every time before checking the cache for it, which results in several requests to our Presto/Hive backend (show partitions, show columns, etc.) to resolve the templates. When we load a dashboard with 20 charts, all with a use of latest partition, it significantly slows down and reduces the usefulness of caching. I had a couple possible solutions to this: 1. Only compile the jinja templates that relate to the current user. Your fix was aimed at fixing uses of current_username, maybe we can just special case this here? 2. Cache the results of the queries that compile the jinja templates. That way we wouldn’t need to repeatedly ping Presto/Hive for the partitions/columns in the table. What do you think? cc @graceguo-supercat @michellethomas This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-525387003 @villebro - you're welcome. I just happened to come across the Airflow item after I solved it. I updated the docs - thanks again! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-525386618 - fair to enforce all on since the side effect is minimal. An aside: why don't we force line length to 79 max? I know it's an outdated standard set by punch cards...but most linters complain. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8126: adding spaces missing from string concatenations
codecov-io edited a comment on issue #8126: adding spaces missing from string concatenations URL: https://github.com/apache/incubator-superset/pull/8126#issuecomment-525384108 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=h1) Report > Merging [#8126](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b1269c31f730a4ee6fe5c72ae5e7394d27db3873?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#8126 +/- ## === Coverage 65.89% 65.89% === Files 485 485 Lines 2293322933 Branches 2538 2538 === Hits1511115111 Misses 7690 7690 Partials 132 132 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8126/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `42.85% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=footer). Last update [b1269c3...e0200c3](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8126: adding spaces missing from string concatenations
codecov-io commented on issue #8126: adding spaces missing from string concatenations URL: https://github.com/apache/incubator-superset/pull/8126#issuecomment-525384108 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=h1) Report > Merging [#8126](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b1269c31f730a4ee6fe5c72ae5e7394d27db3873?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#8126 +/- ## === Coverage 65.89% 65.89% === Files 485 485 Lines 2293322933 Branches 2538 2538 === Hits1511115111 Misses 7690 7690 Partials 132 132 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8126/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `42.85% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=footer). Last update [b1269c3...e0200c3](https://codecov.io/gh/apache/incubator-superset/pull/8126?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
villebro commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-525380071 Thanks for putting in the work to fix this @ericandrewmeadows . Once this gets merged I think we can start picking cherries for a `0.34.1`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] klazaj opened a new issue #8127: Frontend not built after installing Superset with Docker
klazaj opened a new issue #8127: Frontend not built after installing Superset with Docker URL: https://github.com/apache/incubator-superset/issues/8127 After building superset from sources in order to modify some visualizations, I attempted to run superset with Docker. After following the instructions here: https://superset.incubator.apache.org/installation.html#start-with-docker, superset runs but the frontend assets like CSS are not shown. I tried to build the frontend with `npm run dev`, but CSS is still not shown. What can be the cause of this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8127: Frontend not built after installing Superset with Docker
issue-label-bot[bot] commented on issue #8127: Frontend not built after installing Superset with Docker URL: https://github.com/apache/incubator-superset/issues/8127#issuecomment-525377310 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.73. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] rusackas opened a new pull request #8126: adding spaces missing from string concatenations
rusackas opened a new pull request #8126: adding spaces missing from string concatenations URL: https://github.com/apache/incubator-superset/pull/8126 ### CATEGORY Choose one - [ ] Bug Fix - [x] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Just a couple of missing spaces from string concatenations that cropped up. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] paulvic edited a comment on issue #7739: Custom OAuth issue
paulvic edited a comment on issue #7739: Custom OAuth issue URL: https://github.com/apache/incubator-superset/issues/7739#issuecomment-525370438 I'm seeing this too on 0.33.0rc1. I did a little digging today and found this PR https://github.com/dpgaspar/Flask-AppBuilder/pull/910 which introduced redirects after login. I noticed that the `next` value on the login screen is set as follows:  Clicking on login, then redirects to `/oauth-authorized/login`. If I logout and go back to the login screen and then manually set the `next` value in the console as follows:  ...then I can login successfully. Not sure if this is a `superset` or `flask_appbuilder` issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] paulvic commented on issue #7739: Custom OAuth issue
paulvic commented on issue #7739: Custom OAuth issue URL: https://github.com/apache/incubator-superset/issues/7739#issuecomment-525370438 I'm seeing this too on 0.33.0rc1. I did a little digging today and found this PR https://github.com/dpgaspar/Flask-AppBuilder/pull/910 which introduced redirects after login. I noticed that the `next` value on the login screen is set as follows: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] AntonyLeons opened a new pull request #8125: update docker installation (docs)
AntonyLeons opened a new pull request #8125: update docker installation (docs) URL: https://github.com/apache/incubator-superset/pull/8125 - [x ] Documentation ### SUMMARY Current installation method does not build JS and so UI will not load if you simply pasted into terminal, this is simplifying the process. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kuckjwi0928 commented on issue #8124: Korean translation function does not work.
kuckjwi0928 commented on issue #8124: Korean translation function does not work. URL: https://github.com/apache/incubator-superset/issues/8124#issuecomment-525348765 I will fix this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8124: Korean translation function does not work.
issue-label-bot[bot] commented on issue #8124: Korean translation function does not work. URL: https://github.com/apache/incubator-superset/issues/8124#issuecomment-525347802 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.98. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kuckjwi0928 opened a new issue #8124: Korean translation function does not work.
kuckjwi0928 opened a new issue #8124: Korean translation function does not work.
URL: https://github.com/apache/incubator-superset/issues/8124
Korean translation function does not work.
### Expected results
translation to Korean
### Actual results
Maintaining in English
Screenshots
How to reproduce the bug
1. Go to menubar
2. Click the korean drop-down
### Environment
- superset version: `master`
- python version: `Python 3.7.4`
- node.js version: `v11.5.0`
- npm version: `6.9.0`
### Checklist
- [ ] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version
of superset.
- [x] I have checked the issue tracker for the same issue and I haven't
found one similar.
### Additional context
No
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kuckjwi0928 commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard
kuckjwi0928 commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard URL: https://github.com/apache/incubator-superset/issues/8121#issuecomment-525335399 Did you run the superset init command? If you do not, you must execute the following command before running `superset init` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] WChCh commented on issue #7074: Filter-box charts broken with 0.31 with Druid datasources
WChCh commented on issue #7074: Filter-box charts broken with 0.31 with Druid
datasources
URL:
https://github.com/apache/incubator-superset/issues/7074#issuecomment-525316831
> Another regression that I have noticed in Filter Box is that now (in
0.31.0) instead of returning "No data", like it happens on 0.26, I get the
following:
>
> ```
> Traceback (most recent call last):
> File
"/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/views/base.py",
line 114, in wraps
> return f(self, *args, **kwargs)
> File
"/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/views/core.py",
line 1229, in explore_json
> samples=samples,
> File
"/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/views/core.py",
line 1160, in generate_json
> payload = viz_obj.get_payload()
> File
"/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/viz.py",
line 375, in get_payload
> payload['data'] = self.get_data(df)
> File
"/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/superset/viz.py",
line 1821, in get_data
> df = df.sort_values(metric, ascending=flt.get('asc'))
> File
"/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/pandas/core/frame.py",
line 4421, in sort_values
> stacklevel=stacklevel)
> File
"/srv/deployment/analytics/superset/venv/lib/python3.7/site-packages/pandas/core/generic.py",
line 1382, in _get_label_or_level_values
> raise KeyError(key)
> KeyError: 'count'
> ```
>
> Count in this case is the sort metric of the first filter added.
>
> EDIT: might be related to #7019 ?
hi, elukey
I got the same problem! how to solve it!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] felexkemboi closed issue #8119: Date Time Format in Filter Control
felexkemboi closed issue #8119: Date Time Format in Filter Control URL: https://github.com/apache/incubator-superset/issues/8119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] felexkemboi commented on issue #3271: date type field display error
felexkemboi commented on issue #3271: date type field display error URL: https://github.com/apache/incubator-superset/issues/3271#issuecomment-525304495 Anybody` still facing this challenge,i solved it by `DATE_FORMAT(pay.created_at, '%Y-%m-%d %H:%m:%s' ) 'DateCreated',` in my date column.Basically you change the format of your column during querying the database, that is if you are using mysql like for my case This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] srikanth-reddy-m commented on issue #8123: Master code base table visulation Issue
srikanth-reddy-m commented on issue #8123: Master code base table visulation Issue URL: https://github.com/apache/incubator-superset/issues/8123#issuecomment-525293357 I have checked on all bugs didn't find anything related to this. i am stuck at above issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8123: Master code base table visulation Issue
issue-label-bot[bot] commented on issue #8123: Master code base table visulation Issue URL: https://github.com/apache/incubator-superset/issues/8123#issuecomment-525292724 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.88. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] srikanth-reddy-m opened a new issue #8123: Master code base table visulation Issue
srikanth-reddy-m opened a new issue #8123: Master code base table visulation
Issue
URL: https://github.com/apache/incubator-superset/issues/8123
After upgrading the superset with the master code base table visualization
becomes unusable and its font is getting too large.
Looks like some style issues or table visualization is modified to some new
params
### Expected results
Table should be able to get scroll bar and display results as readable.
what you expected to happen.
### Actual results
Table is broken, there is no horizontal scroll bar, unusable.
what actually happens.
Screenshots
Latest Master Code
Previous Version
If applicable, add screenshots to help explain your problem.
How to reproduce the bug
1. Go to '...'
2. Click on ''
3. Scroll down to ''
4. See error
### Environment
(please complete the following information):
- superset version: `superset version`
- python version: `python --version`
- node.js version: `node -v`
- npm version: `npm -v`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version
of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't
found one similar.
### Additional context
Add any other context about the problem here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] starsunny edited a comment on issue #1799: dashboard permission
starsunny edited a comment on issue #1799: dashboard permission URL: https://github.com/apache/incubator-superset/issues/1799#issuecomment-525247934 @ujhujuh I can't see this feature, Can you tell me the file path? I have 100+ dashboards in the superset, and what I want is to hide a few specific dashboards from all users. Or you can give me the pull request. and you have mentioned that superset version in 14.1, but I don't think superset have such a version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7794: How to auto refresh a chart without flashing?
stale[bot] commented on issue #7794: How to auto refresh a chart without flashing? URL: https://github.com/apache/incubator-superset/issues/7794#issuecomment-525271385 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] starsunny edited a comment on issue #1799: dashboard permission
starsunny edited a comment on issue #1799: dashboard permission URL: https://github.com/apache/incubator-superset/issues/1799#issuecomment-525247934 @ujhujuh I can't see this feature, Can you tell me the file path? I have 100+ dashboards in superset, and what I want is to hide few specific dashboard from all users. Or you can give me the pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] felexkemboi commented on issue #8122: Export as filter_box as CSV
felexkemboi commented on issue #8122: Export as filter_box as CSV URL: https://github.com/apache/incubator-superset/issues/8122#issuecomment-525264508 Have you managed to implement time date filter in filter box? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar edited a comment on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
dpgaspar edited a comment on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-525253717 `black` config.py FYI Airflow followup fix on: apache/airflow#5563 Docs: https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/?highlight=proxyfix#werkzeug.middleware.proxy_fix.ProxyFix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar edited a comment on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
dpgaspar edited a comment on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-525253717 `black` config.py FYI Airflow followup fix on: apache/airflow#5563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed pull request #7702: [sqla] Enforcing ISO 8601 date/timestamp formats
stale[bot] closed pull request #7702: [sqla] Enforcing ISO 8601 date/timestamp formats URL: https://github.com/apache/incubator-superset/pull/7702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
dpgaspar commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-525253717 `black` config.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] starsunny commented on issue #2914: How to create a customized dashboard-based permission?
starsunny commented on issue #2914: How to create a customized dashboard-based permission? URL: https://github.com/apache/incubator-superset/issues/2914#issuecomment-525253370 @fufjvnvnf Can you please tell me the changes and the file path where it needs to be done? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] starsunny commented on issue #1799: dashboard permission
starsunny commented on issue #1799: dashboard permission URL: https://github.com/apache/incubator-superset/issues/1799#issuecomment-525247934 @ujhujuh I can't see this feature, Can you tell me the file path? I have 100+ dashboards in superset, and what I want is to hide few specific dashboard from all users. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8122: Export as filter_box as CSV
issue-label-bot[bot] commented on issue #8122: Export as filter_box as CSV URL: https://github.com/apache/incubator-superset/issues/8122#issuecomment-525245112 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.60. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] sandy-ha opened a new issue #8122: Export as filter_box as CSV
sandy-ha opened a new issue #8122: Export as filter_box as CSV
URL: https://github.com/apache/incubator-superset/issues/8122
A clear and concise description of what the bug is.
### Expected results
an Export of corrent Filters as csv
### Actual results
I get the follow messeges
Sorry, something went wrong
500 - Internal Server Error
Stacktrace
Traceback (most recent call last):
File "/home/hgs/venv/lib/python3.6/site-packages/flask/app.py", line 1982,
in wsgi_app
response = self.full_dispatch_request()
File "/home/hgs/venv/lib/python3.6/site-packages/flask/app.py", line 1614,
in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/hgs/venv/lib/python3.6/site-packages/flask/app.py", line 1517,
in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/hgs/venv/lib/python3.6/site-packages/flask/_compat.py", line
33, in reraise
raise value
File "/home/hgs/venv/lib/python3.6/site-packages/flask/app.py", line 1612,
in full_dispatch_request
rv = self.dispatch_request()
File "/home/hgs/venv/lib/python3.6/site-packages/flask/app.py", line 1598,
in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/home/hgs/venv/lib/python3.6/site-packages/superset/models/core.py",
line 1017, in wrapper
value = f(*args, **kwargs)
File
"/home/hgs/venv/lib/python3.6/site-packages/flask_appbuilder/security/decorators.py",
line 168, in wraps
return f(self, *args, **kwargs)
File "/home/hgs/venv/lib/python3.6/site-packages/superset/views/core.py",
line 1246, in explore_json
samples=samples,
File "/home/hgs/venv/lib/python3.6/site-packages/superset/views/core.py",
line 1134, in generate_json
viz_obj.get_csv(),
File "/home/hgs/venv/lib/python3.6/site-packages/superset/viz.py", line
481, in get_csv
include_index = not isinstance(df.index, pd.RangeIndex)
AttributeError: 'NoneType' object has no attribute 'index'
Screenshots
If applicable, add screenshots to help explain your problem.
How to reproduce the bug
1. Go to a Dashboard with filter_box
2. Click on expoart as csv
### Environment
(please complete the following information):
- superset version: `0.28.1`
- python version: ` 3.6.8`
- node.js version: `v8.10.0`
- npm version: `3.5.2`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version
of superset.
- [x] I have checked the issue tracker for the same issue and I have found
one closed similar.
### Additional context
Add any other context about the problem here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ujhujuh commented on issue #1799: dashboard permission
ujhujuh commented on issue #1799: dashboard permission URL: https://github.com/apache/incubator-superset/issues/1799#issuecomment-525241405 from this version，the permission seems to have been added -- 原始邮件 -- 发件人: "Sunny kalal"; 发送时间: 2019年8月27日(星期二) 晚上6:06 收件人: "apache/incubator-superset"; 抄送: "Fantasy"<643240...@qq.com>;"Mention"; 主题: Re: [apache/incubator-superset] dashboard permission (#1799) @ujhujuh @nihalbtq8 @yamyamyuo Guys can you please tell me the file path where I need to make these changes, I am using release--0.32 version. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] squalou opened a new issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard
squalou opened a new issue #8121: Error 401 : There was an issue fetching the
favorite status of this dashboard
URL: https://github.com/apache/incubator-superset/issues/8121
A clear and concise description of what the bug is.
When opening a dashboard, "There was an issue fetching the favorite status
of this dashboard" appears at the bottom.
Looks like issue #6824 : same message displayed, but different "cause" : web
console shows a 401 error (unauthorized), whereas in 6824 there was a
https->http redirect which is now fixed.
### Expected results
No warning message when opening a dashboard, favorite status managed without
issue
### Actual results
"There was an issue fetching the favorite status of this dashboard" appears
at the bottom.
Error 401 in console.
Screenshots
How to reproduce the bug
1. Go to Dashoboard page
2. Click on any dashboard
3. See error
### Environment
- superset version: master branch as of 2019 08 27 9 AM GMT
- python version: 3.6
- node.js version: 12.9.0
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [X ] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [X ] I have reproduced the issue with at least the latest released version
of superset.
- [X ] I have checked the issue tracker for the same issue and I haven't
found one similar.
### Additional context
Running from a docker container, built using Dockerfile essentially
identical to amancevice:superset one.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard
issue-label-bot[bot] commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard URL: https://github.com/apache/incubator-superset/issues/8121#issuecomment-525234579 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.94. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8120: pypi repo is outdated
issue-label-bot[bot] commented on issue #8120: pypi repo is outdated URL: https://github.com/apache/incubator-superset/issues/8120#issuecomment-525234455 Issue Label Bot is not confident enough to auto-label this issue. See [dashboard](https://mlbot.net/data/apache/incubator-superset) for more details. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] AntonyLeons opened a new issue #8120: pypi repo is outdated
AntonyLeons opened a new issue #8120: pypi repo is outdated URL: https://github.com/apache/incubator-superset/issues/8120 ## [SIP] Proposal for Pypi repo release ### Motivation pip currently installs superset 28.1 which is outdated, https://pypi.org/project/superset/#history with the last update being a pre-release in 2018 The older version has bugs which have been fixed in newer releases, this causes issues as you would expect the pypi repo to be maintained as it is part of the documentation. ### Proposed Change update the pypi repo to the latest release or update documentation to reflect that pip installs version 28.1. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] starsunny commented on issue #1799: dashboard permission
starsunny commented on issue #1799: dashboard permission URL: https://github.com/apache/incubator-superset/issues/1799#issuecomment-525234164 @ujhujuh @nihalbtq8 @yamyamyuo Guys can you please tell me the file path where I need to make these changes, I am using release--0.32 version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] KKcorps commented on issue #8009: time grain missing in filter
KKcorps commented on issue #8009: time grain missing in filter URL: https://github.com/apache/incubator-superset/issues/8009#issuecomment-525220771 Hi, Can you give the steps to reproduce the issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] felexkemboi opened a new issue #8119: Date Time Format in Filter Control
felexkemboi opened a new issue #8119: Date Time Format in Filter Control
URL: https://github.com/apache/incubator-superset/issues/8119
I have written my query well,the table is generated and one of its columns
contains a date time format.It works well.When i explore the table,using a
filter box,one of my filters is that column of time and date,when i try to pick
a date,its a long integer
### Expected results
### Actual results
what actually happens.
Screenshots
If applicable, add screenshots to help explain your problem.
How to reproduce the bug
1. Go to '...'
2. Click on ''
3. Scroll down to ''
4. See error
### Environment
(please complete the following information):
- superset version: `superset version`
- python version: `python --version`
- node.js version: `node -v`
- npm version: `npm -v`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version
of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't
found one similar.
### Additional context
Add any other context about the problem here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8119: Date Time Format in Filter Control
issue-label-bot[bot] commented on issue #8119: Date Time Format in Filter Control URL: https://github.com/apache/incubator-superset/issues/8119#issuecomment-525218992 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.71. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] sandy-ha removed a comment on issue #7734: Export csv AttributeError: 'NoneType' object has no attribute 'index'
sandy-ha removed a comment on issue #7734: Export csv AttributeError: 'NoneType' object has no attribute 'index' URL: https://github.com/apache/incubator-superset/issues/7734#issuecomment-525198755 I have the same Problem. Superset 0.28.1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] sandy-ha edited a comment on issue #7734: Export csv AttributeError: 'NoneType' object has no attribute 'index'
sandy-ha edited a comment on issue #7734: Export csv AttributeError: 'NoneType' object has no attribute 'index' URL: https://github.com/apache/incubator-superset/issues/7734#issuecomment-525198755 I have the same Problem. Superset 0.28.1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] sandy-ha commented on issue #7734: Export csv AttributeError: 'NoneType' object has no attribute 'index'
sandy-ha commented on issue #7734: Export csv AttributeError: 'NoneType' object has no attribute 'index' URL: https://github.com/apache/incubator-superset/issues/7734#issuecomment-525198755 I have the same Problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8118: Bar Chart can not show the correct Bar value when i choose single item，
issue-label-bot[bot] commented on issue #8118: Bar Chart can not show the correct Bar value when i choose single item， URL: https://github.com/apache/incubator-superset/issues/8118#issuecomment-525194798 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.89. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dingsheng999888 opened a new issue #8118: Bar Chart can not show the correct Bar value when i choose single item，
dingsheng999888 opened a new issue #8118: Bar Chart can not show the correct Bar value when i choose single item， URL: https://github.com/apache/incubator-superset/issues/8118 Bar Chart can not show the correct Bar value when i choose single item，It can only display the sum of all the entries. ### Expected results When i choose single item ,the value of the single item will be shown on the bar. ### Actual results When i choose single item ,It can only display the sum of all the entries. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] Avocadososemix commented on issue #7017: Transfer all settings from local version to server
Avocadososemix commented on issue #7017: Transfer all settings from local version to server URL: https://github.com/apache/incubator-superset/issues/7017#issuecomment-525193018 This is something I have been wondering about as well. We ended up using Superset (pip install 0.29.0rc7) for a while with the default sqlite superset.db, but now that I am setting up a proper production server for Superset, I'm having trouble importing created roles/users/new permissions of the development server version of our Superset installation. When I look at our sqlite database it only contains the first two admin accouts created with fabmanager, but none of the other users/etc that were created within the superset application show up there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kaspergaj commented on issue #8102: Dashboard filters do not persist on page refresh
kaspergaj commented on issue #8102: Dashboard filters do not persist on page refresh URL: https://github.com/apache/incubator-superset/issues/8102#issuecomment-525184872 How about the _share dashboard_ button under _save as_? That should give you a link. When I follow that link it keeps the selected filters. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] felexkemboi commented on issue #2579: Date Filter is possible to add datepicker calendar?
felexkemboi commented on issue #2579: Date Filter is possible to add datepicker calendar? URL: https://github.com/apache/incubator-superset/issues/2579#issuecomment-525175295 > Thanks all for Apache superset contribution and s/w. > > My question is. Are there any sample dashboard reports available with date filters? My team is especially looking for having ability to switc/refresh the view based on reporting date change. Am interested in this too This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kristw commented on a change in pull request #8115: feat: bump superset-ui dependencies to v0.12 and plugins to v0.11
kristw commented on a change in pull request #8115: feat: bump superset-ui
dependencies to v0.12 and plugins to v0.11
URL:
https://github.com/apache/incubator-superset/pull/8115#discussion_r317924000
##
File path: superset/assets/package.json
##
@@ -46,42 +46,44 @@
},
"homepage": "https://superset.apache.org/;,
"dependencies": {
+"@airbnb/lunar": "~2.23.0",
Review comment:
This is used by the `plugin-chart-table`. There was an issue with the newest
version of `lunar` (`2.24`) so I have to pin this until it is resolved.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] SonaliSihra commented on issue #4127: How can I only authorize users to dashboards?
SonaliSihra commented on issue #4127: How can I only authorize users to dashboards? URL: https://github.com/apache/incubator-superset/issues/4127#issuecomment-525163641 is this feature is implemented? or anyone is working on it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
