Re: [I] Dashboard without a chart fails when generating thumbnail at screenshot step by celery worker [superset]
amolsr commented on issue #25237: URL: https://github.com/apache/superset/issues/25237#issuecomment-2048967516 Hi, we are facing similar issue. caching the dashboard before the report is generated should help in these type of scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[I] there is a bug about mixed chart [superset]
sandbury opened a new issue, #27984: URL: https://github.com/apache/superset/issues/27984 ### Bug description use mixed chat ,when the X-axis is number ,The histogram goes beyond the end of the x-axis like  I can solve it with string X-aix，but I still like that it would be a little better to use numbers as the x-axis ### How to reproduce the bug 1 ### Screenshots/recordings  ### Superset version 4.0.0 ### Python version 3.9 ### Node version 16 ### Browser Chrome ### Additional context 1 ### Checklist - [X] I have searched Superset docs and Slack and didn't find a solution to my problem. - [X] I have searched the GitHub issue tracker and didn't find a similar bug report. - [X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: add option to disable rendering of html in sql lab and table chart [superset]
soniagtm commented on code in PR #27969:
URL: https://github.com/apache/superset/pull/27969#discussion_r1560407047
##
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##
@@ -579,6 +580,10 @@ const ResultSet = ({
const expandedColumns = results.expanded_columns
? results.expanded_columns.map(col => col.column_name)
: [];
+ const allowHTML = getItem(
+LocalStorageKeys.SqllabIsRenderHtmlEnabled,
+true,
Review Comment:
I thought that we wouldn't want to change the current behavior of the result
table (FilterableTable), as it currently always renders results in HTML if
applicable. That's why I set the default value to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Error on embedded dashboard after upgrading to 3.1.1: "Guest user cannot modify chart payload" [superset]
Attachai77 commented on issue #27177: URL: https://github.com/apache/superset/issues/27177#issuecomment-2048878760 Hello @enzo-dechaene , Thank you for your reply, the below is my permissions which no any "datasource access on table..." , Could you please show me your guest permissions for work or tell me my some permission wrong , Thanks. https://github.com/apache/superset/assets/15119618/28948df5-1881-46c4-b431-d39cfbe8b43e;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(ci): make pre-commit step faster by skipping superset install [superset]
mistercrunch merged PR #27979: URL: https://github.com/apache/superset/pull/27979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Superset API return 401 Access Denied: Invalid Credential even when using admin account [superset]
EuphoriaCelestial commented on issue #27961: URL: https://github.com/apache/superset/issues/27961#issuecomment-2048797879 > A few diagnostic questions: > > 1. Does it work via the UI, or is it throwing errors there, too? > > 2. Are _all_ POST endpoints not working, or is it just this one? 1. No, the UI is not working to, throwing the same error 2. I am working with db create api and login only, so I can't test other endpoint, but login is also POST and its fine > I'm not sure, but it looks like maybe the db connection is throwing the error, not the API... this makes me ask the two questions above, and I wonder if the URI indeed contains the right credentials for the db. You mean the credentials and DB for login Superset? or credential and DB for the connection that I am creating? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] chore: remove no-op.yml as it's not needed anymore [superset]
mistercrunch opened a new pull request, #27980: URL: https://github.com/apache/superset/pull/27980 ### SUMMARY After merging https://github.com/apache/superset/pull/27906, we shouldn't need this no-op file that was a bit of a hack in the first place. For more information as to why we needed this originally, view the comments/docs in the file I'm deleting in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] docs: deploy docs when merging to master [superset]
mistercrunch merged PR #27956: URL: https://github.com/apache/superset/pull/27956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: disable chromium downloads by default in docker-compose [superset]
mistercrunch commented on PR #27953: URL: https://github.com/apache/superset/pull/27953#issuecomment-2048593853 @supersetbot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: disable chromium downloads by default in docker-compose [superset]
mistercrunch commented on PR #27953: URL: https://github.com/apache/superset/pull/27953#issuecomment-2048589684 @supersetbot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: disable chromium downloads by default in docker-compose [superset]
mistercrunch commented on PR #27953: URL: https://github.com/apache/superset/pull/27953#issuecomment-2048582776 @supersetbot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: disable chromium downloads by default in docker-compose [superset]
mistercrunch commented on PR #27953: URL: https://github.com/apache/superset/pull/27953#issuecomment-2048579948 @supersetbot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix(models.core:Database): Allocate a SQLA engine once per process per URL. [superset]
eschutho commented on PR #27899: URL: https://github.com/apache/superset/pull/27899#issuecomment-2048563314 @pedro-r-marques I restarted CI and fixed the formatting issue. We'll see if it passes now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix(models.core:Database): Allocate a SQLA engine once per process per URL. [superset]
eschutho commented on code in PR #27899: URL: https://github.com/apache/superset/pull/27899#discussion_r1560137955 ## superset/models/core.py: ## @@ -376,9 +407,7 @@ def get_effective_user(self, object_url: URL) -> str | None: return ( username if (username := get_username()) -else object_url.username -if self.impersonate_user -else None +else object_url.username if self.impersonate_user else None Review Comment: Testing to see if this will pass CI ## superset/models/core.py: ## @@ -376,9 +407,7 @@ def get_effective_user(self, object_url: URL) -> str | None: return ( username if (username := get_username()) -else object_url.username -if self.impersonate_user -else None +else object_url.username if self.impersonate_user else None Review Comment: Testing to see if this will fix CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix(models.core:Database): Allocate a SQLA engine once per process per URL. [superset]
eschutho commented on code in PR #27899: URL: https://github.com/apache/superset/pull/27899#discussion_r1560137869 ## superset/models/core.py: ## @@ -376,9 +407,7 @@ def get_effective_user(self, object_url: URL) -> str | None: return ( username if (username := get_username()) -else object_url.username -if self.impersonate_user -else None +else object_url.username if self.impersonate_user else None Review Comment: ```suggestion else object_url.username if self.impersonate_user else None ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] chore(ASF): adds DOAP file [superset]
rusackas opened a new pull request, #27978: URL: https://github.com/apache/superset/pull/27978 ### SUMMARY ASF has requested we add this DOAP (Definition of a Project) file that they include in various platforms. Instructions/tooling to create and update these are available here: https://projects.apache.org/create.html Once this is merged, I'll edit their SVN repo and link to this file from there. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: new CSV upload form and API [superset]
github-actions[bot] commented on PR #27840: URL: https://github.com/apache/superset/pull/27840#issuecomment-2048542268 @eschutho Ephemeral environment spinning up at http://54.214.102.139:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: new CSV upload form and API [superset]
eschutho commented on PR #27840: URL: https://github.com/apache/superset/pull/27840#issuecomment-2048531023 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: add option to disable rendering of html in sql lab and table chart [superset]
justinpark commented on code in PR #27969:
URL: https://github.com/apache/superset/pull/27969#discussion_r1560110186
##
superset-frontend/src/SqlLab/components/SqlEditor/index.tsx:
##
@@ -284,6 +284,9 @@ const SqlEditor: React.FC = ({
const [autocompleteEnabled, setAutocompleteEnabled] = useState(
getItem(LocalStorageKeys.SqllabIsAutocompleteEnabled, true),
);
+ const [renderHTMLEnabled, setRenderHTMLEnabled] = useState(
+getItem(LocalStorageKeys.SqllabIsRenderHtmlEnabled, true),
Review Comment:
same here. Please set `false` for fallback case.
```suggestion
getItem(LocalStorageKeys.SqllabIsRenderHtmlEnabled, false),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: add option to disable rendering of html in sql lab and table chart [superset]
justinpark commented on code in PR #27969:
URL: https://github.com/apache/superset/pull/27969#discussion_r1560109576
##
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##
@@ -579,6 +580,10 @@ const ResultSet = ({
const expandedColumns = results.expanded_columns
? results.expanded_columns.map(col => col.column_name)
: [];
+ const allowHTML = getItem(
+LocalStorageKeys.SqllabIsRenderHtmlEnabled,
+true,
Review Comment:
@soniagtm The default fallback value for this option should be `false` since
it's an optional allowance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: [proposal] de-matrix python-version in GHAs [superset]
mistercrunch merged PR #27906: URL: https://github.com/apache/superset/pull/27906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: [proposal] de-matrix python-version in GHAs [superset]
mistercrunch commented on code in PR #27906:
URL: https://github.com/apache/superset/pull/27906#discussion_r1560082354
##
.github/actions/setup-backend/action.yml:
##
@@ -13,22 +13,39 @@ inputs:
description: 'Type of requirements to install. Options: base, development,
default'
required: false
default: 'dev'
+ install-superset:
+description: 'Whether to install Superset itself. If false, only python is
installed'
+required: false
+default: 'true'
runs:
using: 'composite'
steps:
-- name: Set up Python ${{ inputs.python-version }}
+- name: Interpret Python Version
+ id: set-python-version
+ shell: bash
+ run: |
+if [ "${{ inputs.python-version }}" = "current" ]; then
+ echo "PYTHON_VERSION=3.10" >> $GITHUB_ENV
Review Comment:
OMG YES! But GHA doesn't play nicely with that kind of parameter injection.
Composition through the "reusable action" approach that we have here is the
best we can do with basic actions (calling a reusable action that hard-codes
the values).
If we wanted more flexibility I'd suggest a Jinja2-based approach, where
we'd have the source templates in say a `.github/jinja` folder, and render that
into `.github/` via a commit hook or similar. Seemed overkill for now, but I'd
be supportive to move in that direction.
Now comparing to where we were a few months back, we're at a much better
place with this setup-backend and setup-supersetbot approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: [proposal] de-matrix python-version in GHAs [superset]
rusackas commented on code in PR #27906: URL: https://github.com/apache/superset/pull/27906#discussion_r1560036976 ## .github/workflows/no-op.yml: ## @@ -0,0 +1,96 @@ +# no-op.yml +# +# Purpose: +# This workflow provides a workaround for the "required status checks" feature in GitHub Actions +# when using path-specific conditions in other workflows. Required checks might remain in a "Pending" +# state if the conditions are not met, thus blocking pull requests from being merged. +# This no-op (no operation) workflow provides dummy success statuses for these required jobs when +# the real jobs do not run due to path-specific conditions. +# +# How it works: +# - It defines jobs with the same names as the required jobs in the main workflows. +# - These jobs simply execute a command (`exit 0`) to succeed immediately. +# - When a pull request is created or updated, both this no-op workflow and the main workflows are triggered. +# - If the main workflows' jobs don't run (due to path conditions), these no-op jobs provide successful statuses. +# - If the main workflows' jobs do run and fail, their failure statuses take precedence, +# ensuring that pull requests are not merged with failing checks. +# +# Usage: +# - Ensure that the job names in this workflow match exactly the names of the corresponding jobs in the main workflows. +# - This workflow should be kept as-is, without path-specific conditions. + +name: no-op Checks +on: pull_request + +jobs: + frontend-build: +runs-on: ubuntu-latest +steps: + - name: No-op for frontend-build +run: exit 0 + Review Comment: There are some inconsistent breaks between blocks if we want to get all OCD here. I wonder: would it be a problem to add ALL required checks here? If so, I wonder if we could ingest and iterate through the list from asf.yaml rather than having to maintain this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(docs): remove seemingly unused unpkg domain from CSPs [superset]
rusackas merged PR #27976: URL: https://github.com/apache/superset/pull/27976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: [proposal] de-matrix python-version in GHAs [superset]
rusackas commented on code in PR #27906:
URL: https://github.com/apache/superset/pull/27906#discussion_r1560023314
##
.github/actions/setup-backend/action.yml:
##
@@ -13,22 +13,39 @@ inputs:
description: 'Type of requirements to install. Options: base, development,
default'
required: false
default: 'dev'
+ install-superset:
+description: 'Whether to install Superset itself. If false, only python is
installed'
+required: false
+default: 'true'
runs:
using: 'composite'
steps:
-- name: Set up Python ${{ inputs.python-version }}
+- name: Interpret Python Version
+ id: set-python-version
+ shell: bash
+ run: |
+if [ "${{ inputs.python-version }}" = "current" ]; then
+ echo "PYTHON_VERSION=3.10" >> $GITHUB_ENV
Review Comment:
No problem for this PR, but I'm thinking at some point we might want to keep
our npm/node/python/whatever version numbers in a JSON file at the repo's root,
so they can be pulled into scripts, documentation, etc. as needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: [proposal] de-matrix python-version in GHAs [superset]
mistercrunch commented on code in PR #27906: URL: https://github.com/apache/superset/pull/27906#discussion_r1560016912 ## .github/workflows/no-op.yml: ## @@ -0,0 +1,96 @@ +# no-op.yml Review Comment: I'll be able to delete this file after we merge this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(docs): removing Superset Community Newsletter archive [superset]
rusackas merged PR #27977: URL: https://github.com/apache/superset/pull/27977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix(alerts/reports): removing duplicate notification method options [superset]
rusackas merged PR #27239: URL: https://github.com/apache/superset/pull/27239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] chore(docs): removing Superset Community Newsletter archive [superset]
rusackas opened a new pull request, #27977: URL: https://github.com/apache/superset/pull/27977 ### SUMMARY Removing the iframe hosting archives of the Superset Community Newsletter, and the corresponding CSP entry. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] chore(docs): remove seemingly unused unpkg domain from CSPs [superset]
rusackas opened a new pull request, #27976: URL: https://github.com/apache/superset/pull/27976 ### SUMMARY ASF isn't happy with this being in here, and I can't figure out if/where unpkg is even being referenced, so I'll scrap it here. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(docs): adding ASF Privacy Link. [superset]
rusackas merged PR #27975: URL: https://github.com/apache/superset/pull/27975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Installing latest superset via helm, cant connect to azure redis service via ssl [superset]
simaolucio commented on issue #25375: URL: https://github.com/apache/superset/issues/25375#issuecomment-2048236099 I'm having an issue similar to @manneym. I'm upgrading to 3.1.1, from 2.1.0. Deploy through Helm chart version 0.12.7. Connection to Azure Cache for Redis now fails with error: **Invalid SSL Certificate Requirements Flag: CERT_NONE** Optional CERT flag also fails -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] chore(docs): adding ASF Privacy Link. [superset]
rusackas opened a new pull request, #27975: URL: https://github.com/apache/superset/pull/27975 ### SUMMARY The ASF requests that all project sites have this link, so I'm adding it to the footer here. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix(node): bump node version in nvmrc files [superset]
rusackas merged PR #27974: URL: https://github.com/apache/superset/pull/27974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: [proposal] de-matrix python-version in GHAs [superset]
mistercrunch commented on PR #27906: URL: https://github.com/apache/superset/pull/27906#issuecomment-2048103643 Capturing the conversation from the **Release Strategy Group** this morning: - let's support a single python version officially per release, and run CI against that one mainly - let's keep preventing "future regressions" on future python version by running some minimal CI against the future version of python (currently test-postgres against 3.11). For now this is the only place where we need a proper matrix. I might try to rename to "current" and "future" to address the required check issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python flask-caching subpackage(s) [superset]
mistercrunch closed pull request #27958: chore(料): bump python flask-caching subpackage(s) URL: https://github.com/apache/superset/pull/27958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python flask-wtf subpackage(s) [superset]
mistercrunch closed pull request #27971: chore(料): bump python flask-wtf subpackage(s) URL: https://github.com/apache/superset/pull/27971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python paramiko subpackage(s) [superset]
mistercrunch closed pull request #27972: chore(料): bump python paramiko subpackage(s) URL: https://github.com/apache/superset/pull/27972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] fix(node): bump node version in nvmrc files [superset]
rusackas opened a new pull request, #27974: URL: https://github.com/apache/superset/pull/27974 ### SUMMARY @geido noticed I missed the `.nvmrc` files in [this PR](https://github.com/apache/superset/pull/27198). This corrects that! ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS I did npm install on all three pieces of software and started them all as well. Looks good at first glance. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[I] Alias Not Applying for Simple Column on Raw Records Table [superset]
mtrentz opened a new issue, #27973: URL: https://github.com/apache/superset/issues/27973 ### Bug description When I edit a column name/alias that is just a "simple column" on the `CUSTOM SQL` tab the alias will not apply to the visualization. If I add a custom sql that is `album_name || ''` (postgres concatenation) then the alias will apply. I am aware that I could just add a label at the dataset level but I have two problems with this: - We lock datasets because they are managed by dbt - Sometimes, depending for what you're doing, you want to change the name of a column to better express it's meaning. - For example: filtering an employee table to only show managers and then rename the column to `Manager` instead of the dataset label of `Employee Name`. This seems to happen only for tables with Raw Records. Tried both on versions 4.0.0 and 3.1.1   ### How to reproduce the bug 1. Create a Table 2. Select Raw Records and select a column from the data set 3. Click on `Custom SQL` and then click the pencil to edit 4. Change name to something else 5. Update Chart 6. Notice how the new name won't appear in the visualization ### Screenshots/recordings _No response_ ### Superset version master / latest-dev ### Python version 3.9 ### Node version 16 ### Browser Chrome ### Additional context _No response_ ### Checklist - [X] I have searched Superset docs and Slack and didn't find a solution to my problem. - [X] I have searched the GitHub issue tracker and didn't find a similar bug report. - [X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Calendar Heatmap - Shows unexpected null dates [superset]
vankeer commented on issue #21870: URL: https://github.com/apache/superset/issues/21870#issuecomment-2047950984 I just stumbled upon this when installing & using the latest version from master. This is still an issue. > It is working as expected please recheck the issue and close this bug You have to enable "Show values" under the "Customize" tab. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python paramiko subpackage(s) [superset]
mistercrunch closed pull request #27972: chore(料): bump python paramiko subpackage(s) URL: https://github.com/apache/superset/pull/27972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] build(deps): bump deck.gl from 8.8.27 to 9.0.6 in /superset-frontend/plugins/legacy-preset-chart-deckgl [superset]
mistercrunch commented on PR #27965: URL: https://github.com/apache/superset/pull/27965#issuecomment-2047937370 Putting a hold label here as deck.gl has been tricky to upgrade in the past and requires special care. This is also a major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python flask-wtf subpackage(s) [superset]
mistercrunch closed pull request #27971: chore(料): bump python flask-wtf subpackage(s) URL: https://github.com/apache/superset/pull/27971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] [SIP-123] Proposal replacement of data table components with ag-grid [superset]
rusackas commented on issue #27645: URL: https://github.com/apache/superset/issues/27645#issuecomment-2047926942 > We've also received confirmation from the ag-Grid team regarding the use of the community version in Superset. Indeed. It looks like I forgot to mention that here, so thank you. Specifically, they stated in an email: > AG Grid community is free to download and use without the need to notify us. > As long as you are not using any of the features of AG Grid enterprise these will be no issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Superset API return 401 Access Denied: Invalid Credential even when using admin account [superset]
rusackas commented on issue #27961: URL: https://github.com/apache/superset/issues/27961#issuecomment-2047874630 A few diagnostic questions: 1) Does it work via the UI, or is it throwing errors there, too? 2) Are _all_ POST endpoints not working, or is it just this one? I'm not sure, but it looks like maybe the db connection is throwing the error, not the API... this makes me ask the two questions above, and I wonder if the URI indeed contains the right credentials for the db. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python paramiko subpackage(s) [superset]
github-actions[bot] closed pull request #27972: chore(料): bump python paramiko subpackage(s) URL: https://github.com/apache/superset/pull/27972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] chore(料): bump python flask-wtf subpackage(s) [superset]
github-actions[bot] opened a new pull request, #27971: URL: https://github.com/apache/superset/pull/27971 Updates the python "flask-wtf" library version from null to null. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] chore(料): bump python paramiko subpackage(s) [superset]
github-actions[bot] opened a new pull request, #27972: URL: https://github.com/apache/superset/pull/27972 Updates the python "paramiko" library version from null to null. Generated by @supersetbot 料 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python flask-wtf subpackage(s) [superset]
github-actions[bot] closed pull request #27971: chore(料): bump python flask-wtf subpackage(s) URL: https://github.com/apache/superset/pull/27971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: custom refresh frequency [superset]
rusackas commented on PR #24449: URL: https://github.com/apache/superset/pull/24449#issuecomment-2047857845 @geido can you check your requested changes to (potentially) unblock the merge when you have a chance, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] build(deps): bump deck.gl from 8.8.27 to 9.0.6 in /superset-frontend/plugins/legacy-preset-chart-deckgl [superset]
rusackas closed pull request #27965: build(deps): bump deck.gl from 8.8.27 to 9.0.6 in /superset-frontend/plugins/legacy-preset-chart-deckgl URL: https://github.com/apache/superset/pull/27965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] build(deps): bump deck.gl from 8.8.27 to 9.0.6 in /superset-frontend/plugins/legacy-preset-chart-deckgl [superset]
dependabot[bot] commented on PR #27965: URL: https://github.com/apache/superset/pull/27965#issuecomment-2047853470 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: new CSV upload form and API [superset]
dpgaspar commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1559608941
##
superset/migrations/versions/2024-04-08_15-43_5ad7321c2169_mig_new_csv_upload_perm.py:
##
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""mig new csv upload perm
+
+Revision ID: 5ad7321c2169
+Revises: 678eefb4ab44
+Create Date: 2024-04-08 15:43:29.682687
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "5ad7321c2169"
+down_revision = "678eefb4ab44"
+
+from alembic import op
+from sqlalchemy.exc import SQLAlchemyError
+from sqlalchemy.orm import Session
+
+from superset.migrations.shared.security_converge import (
+add_pvms,
+get_reversed_new_pvms,
+get_reversed_pvm_map,
+migrate_roles,
+Pvm,
+)
+
+NEW_PVMS = {"Database": ("can_csv_upload",)}
+
+PVM_MAP = {
+Pvm("CsvToDatabaseView", "can_this_form_post"): (
+Pvm("Database", "can_csv_upload"),
+),
+Pvm("CsvToDatabaseView", "can_this_form_get"): (Pvm("Database",
"can_csv_upload"),),
+}
+
+
+def do_upgrade(session: Session) -> None:
+add_pvms(session, NEW_PVMS)
Review Comment:
I don't think their breaking, since users don't have to act, the old
permissions are migrated to the new ones on all existing roles, including
custom ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] api login with ldap account ,returns error [superset]
schoenbl-plwr commented on issue #27964:
URL: https://github.com/apache/superset/issues/27964#issuecomment-2047791181
I'm receiving the same error.
I'm cloning the repo.
I'm adding to the default my superset_config.py:
```
TALISMAN_ENABLED = False
ENABLE_CORS = True
HTTP_HEADERS={"X-Frame-Options":"ALLOWALL"}
SESSION_COOKIE_SAMESITE = None
ENABLE_PROXY_FIX = True
PUBLIC_ROLE_LIKE_GAMMA = True
FEATURE_FLAGS = {
"EMBEDDED_SUPERSET": True
}
CORS_OPTIONS = {
'supports_credentials': True,
'allow_headers': ['*'],
'resources':['*'],
'origins': ['*']
}
```
I'm running `sudo docker-compose -f docker-compose-non-dev.yml up -d`
From postman requesting: `http://domain/api/v1/security/login`
This is the payload:
```
{
"password": "admin",
"provider": "db",
"refresh": true,
"username": "admin"
}
```
This is the response:
```
{
"message": "Fatal error"
}
```
When looking at the logs:
```
2024-04-10 14:58:51,257:ERROR:flask_appbuilder.api:'SupersetApp' object has
no attribute 'json_encoder'
superset_app | Traceback (most recent call last):
superset_app | File
"/usr/local/lib/python3.10/site-packages/flask_appbuilder/api/__init__.py",
line 110, in wraps
superset_app | return f(self, *args, **kwargs)
superset_app | File
"/usr/local/lib/python3.10/site-packages/flask_appbuilder/security/api.py",
line 107, in login
superset_app | resp[API_SECURITY_ACCESS_TOKEN_KEY] =
create_access_token(
superset_app | File
"/usr/local/lib/python3.10/site-packages/flask_jwt_extended/utils.py", line
169, in create_access_token
superset_app | return jwt_manager._encode_jwt_from_config(
superset_app | File
"/usr/local/lib/python3.10/site-packages/flask_jwt_extended/jwt_manager.py",
line 506, in _encode_jwt_from_config
superset_app | json_encoder=config.json_encoder,
superset_app | File
"/usr/local/lib/python3.10/site-packages/flask_jwt_extended/config.py", line
276, in json_encoder
superset_app | return current_app.json_encoder
superset_app | AttributeError: 'SupersetApp' object has no
attribute 'json_encoder'
superset_app | 76.88.39.186 - - [10/Apr/2024:14:58:51 +] "POST
/api/v1/security/login HTTP/1.1" 500 31 "-" "PostmanRuntime/7.36.0"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
rusackas commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2047774826 The main thing I'm wondering about this PR now that I look more closely at the code, is if there's a better place to store this information. I'm a little nervous about storing bootstrap data on the window object, which opens up a new "junk drawer" pattern where people might store anything there. I'm not sure if we should have the Feature Flags there either, really. Is it possible to access this via the `getBootstrapData()` like we do so many other things in the codebase already. It looks like the role is indeed in there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] docs(k8s): making it clear users MUST update secrets for prod instances. [superset]
rusackas merged PR #27954: URL: https://github.com/apache/superset/pull/27954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Error when using "TIME COLUMN" along with "X-AXIS" for same value for Clickhouse [superset]
rusackas commented on issue #23384: URL: https://github.com/apache/superset/issues/23384#issuecomment-2047699347 Thanks @kovitals - if anyone else on this thread finds this to be a sufficient answer (or even a sufficient workaround), this would be a great documentation update on the [Clickhouse docs page](https://superset.apache.org/docs/databases/clickhouse/). A PR from anyone would be helpful on that point to close this out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix(asf): removing google hosted analytics and fonts [superset]
rusackas merged PR #27963: URL: https://github.com/apache/superset/pull/27963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: new CSV upload form and API [superset]
michael-s-molina commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1559499209
##
superset/migrations/versions/2024-04-08_15-43_5ad7321c2169_mig_new_csv_upload_perm.py:
##
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""mig new csv upload perm
+
+Revision ID: 5ad7321c2169
+Revises: 678eefb4ab44
+Create Date: 2024-04-08 15:43:29.682687
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "5ad7321c2169"
+down_revision = "678eefb4ab44"
+
+from alembic import op
+from sqlalchemy.exc import SQLAlchemyError
+from sqlalchemy.orm import Session
+
+from superset.migrations.shared.security_converge import (
+add_pvms,
+get_reversed_new_pvms,
+get_reversed_pvm_map,
+migrate_roles,
+Pvm,
+)
+
+NEW_PVMS = {"Database": ("can_csv_upload",)}
+
+PVM_MAP = {
+Pvm("CsvToDatabaseView", "can_this_form_post"): (
+Pvm("Database", "can_csv_upload"),
+),
+Pvm("CsvToDatabaseView", "can_this_form_get"): (Pvm("Database",
"can_csv_upload"),),
+}
+
+
+def do_upgrade(session: Session) -> None:
+add_pvms(session, NEW_PVMS)
Review Comment:
The problem is that if this PR contains breaking changes, it will be blocked
until the next breaking window. There are two ways to avoid this:
- Make it backward compatible
- Remove the permission changes from this PR and do them during the breaking
window
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: new CSV upload form and API [superset]
dpgaspar commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1559489636
##
superset/migrations/versions/2024-04-08_15-43_5ad7321c2169_mig_new_csv_upload_perm.py:
##
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""mig new csv upload perm
+
+Revision ID: 5ad7321c2169
+Revises: 678eefb4ab44
+Create Date: 2024-04-08 15:43:29.682687
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "5ad7321c2169"
+down_revision = "678eefb4ab44"
+
+from alembic import op
+from sqlalchemy.exc import SQLAlchemyError
+from sqlalchemy.orm import Session
+
+from superset.migrations.shared.security_converge import (
+add_pvms,
+get_reversed_new_pvms,
+get_reversed_pvm_map,
+migrate_roles,
+Pvm,
+)
+
+NEW_PVMS = {"Database": ("can_csv_upload",)}
+
+PVM_MAP = {
+Pvm("CsvToDatabaseView", "can_this_form_post"): (
+Pvm("Database", "can_csv_upload"),
+),
+Pvm("CsvToDatabaseView", "can_this_form_get"): (Pvm("Database",
"can_csv_upload"),),
+}
+
+
+def do_upgrade(session: Session) -> None:
+add_pvms(session, NEW_PVMS)
Review Comment:
I guess you could say it's a breaking change, on `UPDATING.md` should I add
a note to `## Next` or `### Breaking changes` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: new CSV upload form and API [superset]
dpgaspar commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1559476034
##
superset-frontend/src/pages/DatabaseList/index.tsx:
##
@@ -230,6 +233,16 @@ function DatabaseList({
{
label: t('Upload file to database'),
childs: [
+{
+ label: t('New Upload CSV'),
+ name: 'Upload CSV file',
+ url: '#',
+ onClick: () => {
+setCsvUploadModalOpen(true);
+ },
Review Comment:
could not find an easy way without refactoring the component
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: new CSV upload form and API [superset]
dpgaspar commented on code in PR #27840:
URL: https://github.com/apache/superset/pull/27840#discussion_r1559474828
##
superset-frontend/src/features/home/SubMenu.tsx:
##
@@ -162,6 +162,7 @@ const StyledHeader = styled.div`
const styledDisabled = (theme: SupersetTheme) => css`
color: ${theme.colors.grayscale.light1};
+ cursor: not-allowed;
Review Comment:
@michael-s-molina Disabling the cursor on a menu disabled item
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: new CSV upload form and API [superset]
dpgaspar commented on PR #27840: URL: https://github.com/apache/superset/pull/27840#issuecomment-2047587867 @michael-s-molina @kasiazjc I've addressed basically all your comments: @michael-s-molina 1 - Fixed the display disabled at the component level 2 - fixed the width, did not fix the dropdown icons etc because I want to avoid customizing the colapse panels (so it follows database modal) 3 - done 4 - done 5 - Followed @kasiazjc comment  6 - Agree removed the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Horizontal bar chart: too much space above the chart [superset]
michael-s-molina closed issue #27966: Horizontal bar chart: too much space above the chart URL: https://github.com/apache/superset/issues/27966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Horizontal bar chart: too much space above the chart [superset]
visharavana commented on issue #27966: URL: https://github.com/apache/superset/issues/27966#issuecomment-2047511167 @michael-s-molina Sorry, it's my mistake. I didn't see the margin. Now it's working well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: Tooltip renderer [superset]
michael-s-molina commented on PR #27950: URL: https://github.com/apache/superset/pull/27950#issuecomment-2047454607 @justinpark @villebro @rusackas Thank you for the comments. I'm still working on the component's API and implementation as I continue to iterate on each plugin. I'm still not sure what will be the final API and implementation because each plugin has a unique set of requirements. For that reason, I'll first first make sure all ECharts plugins are using the renderer, to have a clear view of all the requirements, and then work on optimizations. Feel free to review this PR while it evolves or wait for when it leaves the draft state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Error on embedded dashboard after upgrading to 3.1.1: "Guest user cannot modify chart payload" [superset]
enzo-dechaene commented on issue #27177: URL: https://github.com/apache/superset/issues/27177#issuecomment-2047453303 Hi @Attachai77, I don't know if this is a solution but I solved the problem by removing the "datasource access on table..." right on my specific role. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Error when using "TIME COLUMN" along with "X-AXIS" for same value for Clickhouse [superset]
kovitals commented on issue #23384: URL: https://github.com/apache/superset/issues/23384#issuecomment-2047447780 Can be fixed on ClickHouse side, with user setting for default profile ``` **1** ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] [value-filter] After text search only showing values corresponding to the search before [superset]
michael-s-molina commented on issue #27949: URL: https://github.com/apache/superset/issues/27949#issuecomment-2047421561 Hi @PowerDinosaur. I was not able to reproduce the error in 3.1.2 and 4.0.0. Am I missing any step? https://github.com/apache/superset/assets/70410625/7b7411cd-59c8-4ec8-99d0-3d5d65aefd28 Are you able to reproduce the error using the [test environment for 4.0.0](http://18.246.209.142:8080/)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Horizontal bar chart: too much space above the chart [superset]
michael-s-molina commented on issue #27966: URL: https://github.com/apache/superset/issues/27966#issuecomment-2047371102 Hi @visharavana. Do you have a margin configured? Using the [4.0.0 test environment](http://18.246.209.142:8080/), I'm not able to reproduce this issue. https://github.com/apache/superset/assets/70410625/9333ba6e-b9d4-4e36-85d3-33774c428b5c Are you able to reproduce using the test environment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix: docker-release GHA fails with pathspec error [superset]
michael-s-molina commented on PR #27925: URL: https://github.com/apache/superset/pull/27925#issuecomment-2047355046 @mistercrunch I was able to successfully run [Docker Publish Release](https://github.com/apache/superset/actions/runs/8603829061) after merging this PR but for some reason it didn't update [Docker Hub](https://hub.docker.com/r/apache/superset/tags?page=1_size===3.1.2) with the ARM version. Am I missing any step? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] [SIP-123] Proposal replacement of data table components with ag-grid [superset]
michael-s-molina commented on issue #27645: URL: https://github.com/apache/superset/issues/27645#issuecomment-2047276381 > We've also received confirmation from the ag-Grid team regarding the use of the community version in Superset. In light of this, this proposal suggests replacing all tables with ag-Grid. Woooh! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] docs(k8s): making it clear users MUST update secrets for prod instances. [superset]
margorczynski commented on PR #27954: URL: https://github.com/apache/superset/pull/27954#issuecomment-2047214372 Hey @rusackas, yep, I think this more stronly suggests that the config needs to be overwritten for this to work, thank you for the update :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix(Dashboard): Add aria-label to filters and search forms [superset]
geido merged PR #27968: URL: https://github.com/apache/superset/pull/27968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: Fix/remove hardcode of admin role [superset]
Always-prog commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2046954495 @rusackas Test cases has beed passed without rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] feat: add option to disable rendering of html in sql lab and table chart [superset]
soniagtm opened a new pull request, #27969: URL: https://github.com/apache/superset/pull/27969 ### SUMMARY Currently, the platform renders any HTML command in the result table, which can sometimes obscure the full HTML in the request body. To address this, an option button that enables users to control the rendering of HTML in the result table is added. This option would provide users with more flexibility and clarity when viewing HTML content within SQLLab, as well as in table chart. This addition is also discussed in [this lazy consensus](https://lists.apache.org/thread/1y4rxnply1m7xonnwro2b12f276vc2hm). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before** _**SQL Lab**_ https://github.com/apache/superset/assets/96282005/e8cccbb6-4ec3-4707-9be1-5bef8a1be720;> _**Table Chart**_ https://github.com/apache/superset/assets/96282005/a5a0ac1a-cf23-42e1-afa6-f3e28b2a8c18;> **After** _**SQL Lab**_ https://github.com/apache/superset/assets/96282005/b8e5161c-c7bb-4c72-b977-277cf52de259 _**Table Chart**_ https://github.com/apache/superset/assets/96282005/24c58851-c461-4b7d-bd47-49b9436b576b ### TESTING INSTRUCTIONS **SQL Lab** 1. Enter a query that contains an HTML string. 2. Press the "Run" button. 3. The result should be rendered as HTML. 4. Try disabling the "Render HTML" option. 5. Run the query again. 6. The result should be rendered as a normal string. **Table Chart** 1. Create a table chart with the column that contains HTML strings. 2. The result should be rendered as HTML. 3. Uncheck the "Render columns in HTML format" option in Customize panel. 4. Update the chart. 5. The result should be rendered as a normal string. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [X] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] fix(Dashboard): Add aria-label to filters and search forms [superset]
geido opened a new pull request, #27968: URL: https://github.com/apache/superset/pull/27968 ### SUMMARY This PR improves accessibility of the Dashboard by adding aria-label to filters' forms and table search. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N.A. ### TESTING INSTRUCTIONS 1. Use a screen reader 2. Make sure filter forms are correctly labeled 3. Make sure the search box of a Table chart is correctly labeled ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Error on embedded dashboard after upgrading to 3.1.1: "Guest user cannot modify chart payload" [superset]
Attachai77 commented on issue #27177: URL: https://github.com/apache/superset/issues/27177#issuecomment-2046856658 I got same issue https://github.com/apache/superset/assets/15119618/4797bbcb-a5d9-491d-8bd3-e70e53c07847;> https://github.com/apache/superset/assets/15119618/8967f3e2-f5d5-4e9b-ab8e-0f354ade707d;> https://github.com/apache/superset/assets/15119618/6b6ff969-0ecf-400a-8b70-7e071c0a039e;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[I] Horizontal bar chart: too much space above the chart [superset]
visharavana opened a new issue, #27966: URL: https://github.com/apache/superset/issues/27966 ### Bug description When I use the horizontal bar chart, it shows correctly, but when I enable the legend option, it does not show correctly, like there is too much space between the legend and chart. Chrome itself works well. Without legend:  with legend:  ### How to reproduce the bug 1. Create horizontal bar chart 2. Enable Legend option ### Screenshots/recordings _No response_ ### Superset version 4.0.0 ### Python version 3.9 ### Node version 18 or greater ### Browser Firefox ### Additional context _No response_ ### Checklist - [X] I have searched Superset docs and Slack and didn't find a solution to my problem. - [X] I have searched the GitHub issue tracker and didn't find a similar bug report. - [X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix: Data zoom with horizontal orientation [superset]
visharavana commented on PR #27291: URL: https://github.com/apache/superset/pull/27291#issuecomment-2046614658 @michael-s-molina when you use this code to align the Data Zoom slide perfectly. yAxisIndex: isHorizontal ? 60 : undefined,  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] refactor: add "button" role to clickable UI elements for improved accessibility [superset]
eulloa10 commented on code in PR #26602:
URL: https://github.com/apache/superset/pull/26602#discussion_r1558772499
##
superset-frontend/src/explore/components/controls/FixedOrMetricControl/index.jsx:
##
@@ -127,7 +127,7 @@ export default class FixedOrMetricControl extends
React.Component {
undefined}>
Review Comment:
This was introduced as part of a migration from Bootstrap to AntD components
in this
[PR](https://github.com/apache/superset/pull/12920/files#diff-a7be32a17ea0cae5c0409a1c8ef7abd669132a56052f97a24aac78570f074cef).
However, there doesn't seem to be additional context as to why this `onClick`
is returning `undefined`. Should we leave it as is and not remove the `onClick`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
