Re: [PR] chore(料): bump python googleapis-common-protos 1.59.0 -> 1.63.0 [superset]
mistercrunch merged PR #28663: URL: https://github.com/apache/superset/pull/28663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python stack-data 0.6.2 -> 0.6.3 [superset]
mistercrunch merged PR #28661: URL: https://github.com/apache/superset/pull/28661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python matplotlib 3.7.1 -> 3.9.0 [superset]
mistercrunch merged PR #28674: URL: https://github.com/apache/superset/pull/28674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python ruff 0.4.4 -> 0.4.5 [superset]
mistercrunch merged PR #28669: URL: https://github.com/apache/superset/pull/28669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix: Chart cache-warmup task fails on Superset 4.0 [superset]
rmasters commented on code in PR #28706:
URL: https://github.com/apache/superset/pull/28706#discussion_r1614232617
##
tests/integration_tests/tasks/test_cache.py:
##
@@ -40,18 +81,22 @@ def test_fetch_url(mock_urlopen, mock_request_cls,
base_url):
mock_urlopen.return_value = mock.MagicMock()
mock_urlopen.return_value.code = 200
+initial_headers = {"Cookie": "cookie", "key": "value"}
+csrf_headers = initial_headers | {"X-CSRF-Token": "csrf_token"}
Review Comment:
Will need to be changed if Python 3.8 is still supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix: Chart cache-warmup task fails on Superset 4.0 [superset]
rmasters commented on code in PR #28706: URL: https://github.com/apache/superset/pull/28706#discussion_r1614232355 ## superset/tasks/cache.py: ## @@ -212,14 +212,38 @@ def get_payloads(self) -> list[dict[str, int]]: strategies = [DummyStrategy, TopNDashboardsStrategy, DashboardTagsStrategy] +def fetch_csrf_token(headers: dict[str, str]) -> dict[str, str]: Review Comment: This isn't specific to caching - WDYT about superset.tasks.utils? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Chart cache warmup fails with 405 Method Not Allowed [superset]
dosubot[bot] commented on issue #28705:
URL: https://github.com/apache/superset/issues/28705#issuecomment-2130602586
Hey there, @rmasters! I'm a bot designed to help you out with bugs,
questions, and becoming a contributor. I'm here to assist you with the issue
you've encountered while waiting for a human maintainer. Let's tackle this
together!
To fix the "405 Method Not Allowed" error in the chart cache warm-up task
for Superset version 4.0.1, ensure that the HTTP method used for the
`/warm_up_cache` endpoint is `PUT`. The endpoint is defined to accept only
`PUT` requests.
Here is the relevant code snippet from `superset/charts/api.py`:
```python
@expose("/warm_up_cache", methods=("PUT",))
@protect()
@safe
@statsd_metrics
@event_logger.log_this_with_context(
action=lambda self, *args, **kwargs: f"{self.__class__.__name__}"
f".warm_up_cache",
log_to_statsd=False,
)
def warm_up_cache(self) -> Response:
"""Warm up the cache for the chart.
---
put:
summary: Warm up the cache for the chart
description: >-
Warms up the cache for the chart.
Note for slices a force refresh occurs.
In terms of the `extra_filters` these can be obtained from records
in the JSON
encoded `logs.json` column associated with the `explore_json` action.
requestBody:
description: >-
Identifies the chart to warm up cache for, and any additional
dashboard or
filter context to use.
required: true
content:
application/json:
schema:
$ref: "#/components/schemas/ChartCacheWarmUpRequestSchema"
responses:
200:
description: Each chart's warmup status
content:
application/json:
schema:
$ref: "#/components/schemas/ChartCacheWarmUpResponseSchema"
400:
$ref: '#/components/responses/400'
404:
$ref: '#/components/responses/404'
500:
$ref: '#/components/responses/500'
"""
try:
body = ChartCacheWarmUpRequestSchema().load(request.json)
except ValidationError as error:
return self.response_400(message=error.messages)
try:
result = ChartWarmUpCacheCommand(
body["chart_id"],
body.get("dashboard_id"),
body.get("extra_filters"),
).run()
return self.response(200, result=[result])
except CommandException as ex:
return self.response(ex.status, message=ex.message)
```
Ensure that your request to warm up the cache uses the `PUT` method. For
example, using `curl`:
```sh
curl -X PUT -H "Content-Type: application/json" -d '{"chart_id": 1,
"dashboard_id": 2, "extra_filters": []}'
http://your-superset-url/api/v1/chart/warm_up_cache
```
Or using Python's `requests` library:
```python
import requests
url = "http://your-superset-url/api/v1/chart/warm_up_cache;
data = {
"chart_id": 1,
"dashboard_id": 2,
"extra_filters": []
}
headers = {
"Content-Type": "application/json"
}
response = requests.put(url, json=data, headers=headers)
print(response.status_code, response.json())
```
Additionally, ensure that the cache warm-up task is correctly configured in
`superset/tasks/cache.py`. The `fetch_url` function should use the `PUT` method
when making the request:
```python
@celery_app.task(name="fetch_url")
def fetch_url(data: str, headers: dict[str, str]) -> dict[str, str]:
"""
Celery job to fetch url
"""
result = {}
try:
url = get_url_path("Superset.warm_up_cache")
logger.info("Fetching %s with payload %s", url, data)
req = request.Request(
url, data=bytes(data, "utf-8"), headers=headers, method="PUT"
)
response = request.urlopen( # pylint: disable=consider-using-with
req, timeout=600
)
logger.info(
"Fetched %s with payload %s, status code: %s", url, data,
response.code
)
if response.code == 200:
result = {"success": data, "response":
response.read().decode("utf-8")}
else:
result = {"error": data, "status_code": response.code}
logger.error(
"Error fetching %s with payload %s, status code: %s",
url,
data,
response.code,
)
except URLError as err:
logger.exception("Error warming up cache!")
result = {"error": data, "exception": str(err)}
return result
```
Make sure the request method is `PUT` to avoid the "405
[PR] fix: cache-warmup task fails on Superset 4.0 [superset]
rmasters opened a new pull request, #28706:
URL: https://github.com/apache/superset/pull/28706
### SUMMARY
Fixes #28705
We found our chart cache warm-up task (as in [the example in the Kubernetes
docs](https://superset.apache.org/docs/installation/kubernetes#configure-the-appropriate-celery-jobs-and-smtpslack-settings))
was failing with this error:
```
[2024-05-24 22:30:00,045: INFO/ForkPoolWorker-1]
cache-warmup[ae85f28c-acfa-4bb1-a885-e7f0121610b9]: Loading strategy
[2024-05-24 22:30:00,045: INFO/ForkPoolWorker-1]
cache-warmup[ae85f28c-acfa-4bb1-a885-e7f0121610b9]: Loading
TopNDashboardsStrategy
[2024-05-24 22:30:00,046: INFO/ForkPoolWorker-1]
cache-warmup[ae85f28c-acfa-4bb1-a885-e7f0121610b9]: Success!
HTTPException
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1823, in
full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1788, in
dispatch_request
self.raise_routing_exception(req)
File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1770, in
raise_routing_exception
raise request.routing_exception # type: ignore
File "/usr/local/lib/python3.10/site-packages/flask/ctx.py", line 351, in
match_request
result = self.url_adapter.match(return_rule=True) # type: ignore
File "/usr/local/lib/python3.10/site-packages/werkzeug/routing/map.py", line
619, in match
raise MethodNotAllowed(valid_methods=list(e.have_match_for)) from None
werkzeug.exceptions.MethodNotAllowed: 405 Method Not Allowed: The method is
not allowed for the requested URL.
[repeated]
```
On investigation I found that:
- The `cache-warmup` task calls `PUT /superset/warm_up_caches/` (via the
`fetch_url` task)
- `/superset/warm_up_caches/` (`Superset.warm_up_caches`) exists but is a
GET request
- That endpoint is deprecated by `/api/v1/chart/warm_up_caches`
(`ChartRestApi.warm_up_cache`) (scheduled for 4.0 but I couldn't find
discussions around that)
This PR changes the task to call the newer endpoint (accidentally reverted
in 56069b05f9cf4d0c725d1b4b0ad6038b50837cd4).
I also ran into CSRF issues (similar to discussion in #27160), so added a
method to fetch this (thanks to Will Gan on slack for the hint). Perhaps this
can be placed more centrally? This appears to work on installations with CSRF
disabled (I've tested with `WTF_CSRF_ENABLED = False`).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
1. Ensure you have a scheduled job to warmup caches, e.g. by adding to
CeleryConfig:
```diff
class CeleryConfig:
broker_url = f"redis://{REDIS_HOST}:{REDIS_PORT}/{REDIS_CELERY_DB}"
-imports = ("superset.sql_lab",)
+imports = (
+"superset.sql_lab",
+"superset.tasks.cache",
+)
result_backend =
f"redis://{REDIS_HOST}:{REDIS_PORT}/{REDIS_RESULTS_DB}"
worker_prefetch_multiplier = 1
task_acks_late = False
@@ -87,6 +90,13 @@ class CeleryConfig:
"task": "reports.prune_log",
"schedule": crontab(minute=10, hour=0),
},
+"cache-warmup-dummy": {
+"task": "cache-warmup",
+"schedule": crontab(minute="*/1", hour="*"),
+"kwargs": {
+"strategy_name": "dummy",
+},
+},
}
```
2. If starting from an empty installation, create a dashboard, with at
least one data-backed chart, and publish it
3. Each minute you should see log lines like:
```
superset_worker| [2024-05-25 00:18:03,203:
INFO/ForkPoolWorker-1] fetch_url[b9a9c5c6-41e0-491f-a8cb-d49c0b9ab396]:
Fetching http://superset_app:8088/api/v1/security/csrf_token/
superset_app | 2024-05-25
00:18:03,198:DEBUG:superset.stats_logger:[stats_logger] (timing)
ChartRestApi.warm_up_cache.time | 176.14193800545763
superset_app | 2024-05-25
00:18:03,200:INFO:werkzeug:192.168.165.7 - - [25/May/2024 00:18:03] "PUT
/api/v1/chart/warm_up_cache HTTP/1.1" 200 -
```
as compared to this on master:
```
superset_worker| [2024-05-25 00:26:00,162: INFO/MainProcess]
Task fetch_url[a488cfb6-1d63-42bb-be00-a3e6af3e2c4a] received
superset_worker| [2024-05-25 00:26:00,165:
INFO/ForkPoolWorker-1] fetch_url[9a054a67-acf0-4fd8-b0dd-42ab28da886b]:
Fetching http://superset_app:8088/superset/warm_up_cache/ with payload
{"chart_id": 156}
superset_app | 2024-05-25
00:26:00,168:WARNING:superset.views.base:HTTPException
superset_app | Traceback (most recent call last):
superset_app | File
[I] Chart cache warmup fails with 405 Method Not Allowed [superset]
rmasters opened a new issue, #28705:
URL: https://github.com/apache/superset/issues/28705
### Bug description
We found our chart cache warm-up task (as in [the example in the Kubernetes
docs](https://superset.apache.org/docs/installation/kubernetes#configure-the-appropriate-celery-jobs-and-smtpslack-settings))
was failing with `werkzeug.exceptions.MethodNotAllowed: 405 Method Not
Allowed`.
I found a similar mention of this problem on Slack:
https://apache-superset.slack.com/archives/C01SS4DNYG5/p1715183775388149
The root cause is that 56069b05f9cf4d0c725d1b4b0ad6038b50837cd4 accidentally
partially-reverted the warm-caches URL, so we have a PUT to the deprecated GET
endpoint.
I have a fix for this, which I will PR shortly.
### How to reproduce the bug
1. Ensure you have a cache-warmup task scheduled as above
2. Ensure you have at least one dashboard with a data-backed chart
3. Monitor the celery worker logs
### Screenshots/recordings
_No response_
### Superset version
4.0.1
### Python version
3.10
### Node version
Not applicable
### Browser
Not applicable
### Additional context
Logs/stacktrace:
```
[2024-05-24 22:30:00,045: INFO/ForkPoolWorker-1]
cache-warmup[ae85f28c-acfa-4bb1-a885-e7f0121610b9]: Loading strategy
[2024-05-24 22:30:00,045: INFO/ForkPoolWorker-1]
cache-warmup[ae85f28c-acfa-4bb1-a885-e7f0121610b9]: Loading
TopNDashboardsStrategy
[2024-05-24 22:30:00,046: INFO/ForkPoolWorker-1]
cache-warmup[ae85f28c-acfa-4bb1-a885-e7f0121610b9]: Success!
HTTPException
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1823, in
full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1788, in
dispatch_request
self.raise_routing_exception(req)
File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1770, in
raise_routing_exception
raise request.routing_exception # type: ignore
File "/usr/local/lib/python3.10/site-packages/flask/ctx.py", line 351, in
match_request
result = self.url_adapter.match(return_rule=True) # type: ignore
File "/usr/local/lib/python3.10/site-packages/werkzeug/routing/map.py", line
619, in match
raise MethodNotAllowed(valid_methods=list(e.have_match_for)) from None
werkzeug.exceptions.MethodNotAllowed: 405 Method Not Allowed: The method is
not allowed for the requested URL.
[repeated]
```
We run with the following CeleryConfig:
```python
class CeleryConfig(object):
broker_url = celery_redis_broker_url
imports = (
"superset.sql_lab",
"superset.tasks.scheduler",
)
result_backend = celery_redis_result_url
worker_prefetch_multiplier = 10
task_acks_late = True
task_annotations = {
"sql_lab.get_sql_results": {
"rate_limit": "100/s",
},
}
beat_schedule = {
[snip]
"cache-warmup-hourly": {
"task": "cache-warmup",
"schedule": crontab(minute="*/30", hour="*"),
"kwargs": {
"strategy_name": "top_n_dashboards",
"top_n": 10,
"since": "7 days ago",
},
},
}
```
### Checklist
- [X] I have searched Superset docs and Slack and didn't find a solution to
my problem.
- [X] I have searched the GitHub issue tracker and didn't find a similar bug
report.
- [X] I have checked Superset's logs for errors and if I found a relevant
Python stacktrace, I included it here as text in the "additional context"
section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Superset Unable to Save Database Configurations in Database [superset]
dosubot[bot] commented on issue #28044:
URL: https://github.com/apache/superset/issues/28044#issuecomment-2130391576
Hi @bmschow! I'm a bot designed to help you with bugs, questions, and
contributions. I'm here to assist you while waiting for a human maintainer.
The "Fatal Error" you're encountering when clicking "Connect" in Superset's
UI is likely related to the encryption and decryption of database connection
parameters. The stack trace indicates an issue with the
`sqlalchemy_utils.types.encrypted.encrypted_type` module, specifically a
`TypeError` stating that a bytes-like object is required, not a tuple.
Here are the steps to resolve this issue:
1. **Check the Encryption Key**:
Ensure that the encryption key used for the `encrypted_extra` field is
correctly configured and is a bytes-like object. The error suggests that a
tuple might be passed instead of a bytes-like object.
2. **Validate `masked_encrypted_extra` Field**:
Make sure that the `masked_encrypted_extra` field is a valid JSON string.
If it contains masked credentials (e.g., `PASSWORD_MASK`), ensure that the
actual credentials are provided.
3. **Update Superset Configuration**:
Ensure that your Superset configuration is correctly handling the
encryption and decryption of sensitive information. Here is a relevant code
snippet for handling the `masked_encrypted_extra` field:
```python
def rename_encrypted_extra(self: Schema, data: dict[str, Any], **kwargs:
Any) -> dict[str, Any]:
if "encrypted_extra" in data:
data["masked_encrypted_extra"] = data.pop("encrypted_extra")
return data
def encrypted_extra_validator(value: str) -> str:
if value:
try:
json.loads(value)
except json.JSONDecodeError as ex:
raise ValidationError([_("Field cannot be decoded by JSON.
%(msg)s", msg=str(ex))]) from ex
return value
```
4. **Check Database Model**:
Ensure that the `sqlalchemy_uri` and `encrypted_extra` fields in the
`Database` model are correctly handled. The `sqlalchemy_uri_decrypted` property
should ensure that the URI is decrypted and the password is correctly set:
```python
@property
def sqlalchemy_uri_decrypted(self) -> str:
try:
conn = make_url_safe(self.sqlalchemy_uri)
except DatabaseInvalidError:
return "dialect://invalid_uri"
if custom_password_store:
conn = conn.set(password=custom_password_store(conn))
else:
conn = conn.set(password=self.password)
return str(conn)
```
5. **Review Helm Chart Configuration**:
Ensure that your Helm chart configuration is correctly set up to handle
database connections. Here is an example configuration for database connections:
```yaml
supersetNode:
connections:
db_host: '{{ .Release.Name }}-postgresql'
db_port: "5432"
db_user: superset
db_pass: superset
db_name: superset
```
By following these steps, you should be able to resolve the "Fatal Error"
encountered when saving database configurations in Superset
[[1]](https://github.com/apache/superset/blob/master/superset/databases/schemas.py)[[2]](https://github.com/apache/superset/blob/master/superset/models/core.py)[[3]](https://github.com/apache/superset/blob/master/helm/superset/values.yaml).
Details
**About Dosu**
This response is meant to be useful and save you time. It is **not meant to
be a precise solution**, but rather a starting point for your own research.
Help me be more useful! Please leave a if this is helpful and if it is
irrelevant.
*To continue the conversation, mention @dosu.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] refactor: Unify all json.(loads|dumps) usage to utils.json [superset]
eyalezer commented on PR #28702: URL: https://github.com/apache/superset/pull/28702#issuecomment-2130381794 @mistercrunch - here's the second part of the refactor, as expected this is a huge PR: 232 files changed but at least now all json usage is unified to use the utils.json -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(docs): address common docker compose error message in Quickstart [superset]
sfirke merged PR #28696: URL: https://github.com/apache/superset/pull/28696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python requests-oauthlib 1.3.1 -> 2.0.0 [superset]
mistercrunch merged PR #28681: URL: https://github.com/apache/superset/pull/28681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python flask-limiter 3.3.1 -> 3.7.0 [superset]
mistercrunch merged PR #28670: URL: https://github.com/apache/superset/pull/28670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore: remove ipython from development dependencies [superset]
mistercrunch closed pull request #28703: chore: remove ipython from development dependencies URL: https://github.com/apache/superset/pull/28703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python marshmallow 3.19.0 -> 3.21.2 [superset]
mistercrunch merged PR #28655: URL: https://github.com/apache/superset/pull/28655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python bcrypt 4.0.1 -> 4.1.3 [superset]
mistercrunch merged PR #28590: URL: https://github.com/apache/superset/pull/28590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python bottleneck 1.3.7 -> 1.3.8 [superset]
mistercrunch merged PR #28657: URL: https://github.com/apache/superset/pull/28657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python cattrs 23.2.1 -> 23.2.3 [superset]
mistercrunch merged PR #28658: URL: https://github.com/apache/superset/pull/28658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python typing-extensions 4.11.0 -> 4.12.0 [superset]
mistercrunch merged PR #28659: URL: https://github.com/apache/superset/pull/28659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python wheel 0.40.0 -> 0.43.0 [superset]
mistercrunch merged PR #28660: URL: https://github.com/apache/superset/pull/28660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python pexpect 4.8.0 -> 4.9.0 [superset]
mistercrunch merged PR #28662: URL: https://github.com/apache/superset/pull/28662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python traitlets 5.9.0 -> 5.14.3 [superset]
mistercrunch merged PR #28665: URL: https://github.com/apache/superset/pull/28665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python freezegun 1.4.0 -> 1.5.1 [superset]
mistercrunch merged PR #28666: URL: https://github.com/apache/superset/pull/28666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python babel 2.9.1 -> 2.15.0 [superset]
mistercrunch merged PR #28668: URL: https://github.com/apache/superset/pull/28668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python pyproject-api 1.5.2 -> 1.6.1 [superset]
mistercrunch merged PR #28672: URL: https://github.com/apache/superset/pull/28672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python click-repl 0.2.0 -> 0.3.0 [superset]
mistercrunch merged PR #28671: URL: https://github.com/apache/superset/pull/28671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python kombu 5.3.4 -> 5.3.7 [superset]
mistercrunch merged PR #28675: URL: https://github.com/apache/superset/pull/28675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python click-didyoumean 0.3.0 -> 0.3.1 [superset]
mistercrunch merged PR #28677: URL: https://github.com/apache/superset/pull/28677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python cffi 1.15.1 -> 1.16.0 [superset]
mistercrunch merged PR #28676: URL: https://github.com/apache/superset/pull/28676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python identify 2.5.24 -> 2.5.36 [superset]
mistercrunch merged PR #28680: URL: https://github.com/apache/superset/pull/28680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python pydruid 0.6.6 -> 0.6.9 [superset]
mistercrunch merged PR #28682: URL: https://github.com/apache/superset/pull/28682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python kiwisolver 1.4.4 -> 1.4.5 [superset]
mistercrunch merged PR #28683: URL: https://github.com/apache/superset/pull/28683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python requests 2.31.0 -> 2.32.2 [superset]
mistercrunch merged PR #28684: URL: https://github.com/apache/superset/pull/28684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] chore: remove sl_ tables [superset]
mistercrunch opened a new pull request, #28704: URL: https://github.com/apache/superset/pull/28704 ### SUMMARY Removing unused models sl_.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] chore: remove ipython from development dependencies [superset]
mistercrunch opened a new pull request, #28703: URL: https://github.com/apache/superset/pull/28703 # Summary removing ipython as it's simply a nice-to-have, but not required for Superset development -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python dnspython 2.1.0 -> 2.6.1 [superset]
mistercrunch merged PR #28574: URL: https://github.com/apache/superset/pull/28574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python rich 13.3.4 -> 13.7.1 [superset]
mistercrunch merged PR #28573: URL: https://github.com/apache/superset/pull/28573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python pygments 2.15.0 -> 2.18.0 [superset]
mistercrunch merged PR #28535: URL: https://github.com/apache/superset/pull/28535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python deprecated 1.2.13 -> 1.2.14 [superset]
mistercrunch merged PR #28580: URL: https://github.com/apache/superset/pull/28580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python tzlocal 4.3 -> 5.2 [superset]
mistercrunch merged PR #28526: URL: https://github.com/apache/superset/pull/28526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python lazy-object-proxy 1.9.0 -> 1.10.0 [superset]
mistercrunch merged PR #28533: URL: https://github.com/apache/superset/pull/28533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python typing-extensions 4.11.0 -> 4.12.0 [superset]
mistercrunch closed pull request #28659: chore(料): bump python typing-extensions 4.11.0 -> 4.12.0 URL: https://github.com/apache/superset/pull/28659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python cattrs 23.2.1 -> 23.2.3 [superset]
mistercrunch closed pull request #28658: chore(料): bump python cattrs 23.2.1 -> 23.2.3 URL: https://github.com/apache/superset/pull/28658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python bottleneck 1.3.7 -> 1.3.8 [superset]
mistercrunch closed pull request #28657: chore(料): bump python bottleneck 1.3.7 -> 1.3.8 URL: https://github.com/apache/superset/pull/28657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python virtualenv 20.23.1 -> 20.26.2 [superset]
mistercrunch closed pull request #28656: chore(料): bump python virtualenv 20.23.1 -> 20.26.2 URL: https://github.com/apache/superset/pull/28656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python bcrypt 4.0.1 -> 4.1.3 [superset]
Re: [PR] chore(料): bump python marshmallow 3.19.0 -> 3.21.2 [superset]
mistercrunch closed pull request #28655: chore(料): bump python marshmallow 3.19.0 -> 3.21.2 URL: https://github.com/apache/superset/pull/28655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python requests 2.31.0 -> 2.32.2 [superset]
mistercrunch closed pull request #28684: chore(料): bump python requests 2.31.0 -> 2.32.2 URL: https://github.com/apache/superset/pull/28684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python kiwisolver 1.4.4 -> 1.4.5 [superset]
mistercrunch closed pull request #28683: chore(料): bump python kiwisolver 1.4.4 -> 1.4.5 URL: https://github.com/apache/superset/pull/28683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python pydruid 0.6.6 -> 0.6.9 [superset]
mistercrunch closed pull request #28682: chore(料): bump python pydruid 0.6.6 -> 0.6.9 URL: https://github.com/apache/superset/pull/28682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python identify 2.5.24 -> 2.5.36 [superset]
mistercrunch closed pull request #28680: chore(料): bump python identify 2.5.24 -> 2.5.36 URL: https://github.com/apache/superset/pull/28680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python boto3 1.26.130 -> 1.34.112 [superset]
mistercrunch closed pull request #28679: chore(料): bump python boto3 1.26.130 -> 1.34.112 URL: https://github.com/apache/superset/pull/28679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python requests-oauthlib 1.3.1 -> 2.0.0 [superset]
mistercrunch closed pull request #28681: chore(料): bump python requests-oauthlib 1.3.1 -> 2.0.0 URL: https://github.com/apache/superset/pull/28681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python click-didyoumean 0.3.0 -> 0.3.1 [superset]
mistercrunch closed pull request #28677: chore(料): bump python click-didyoumean 0.3.0 -> 0.3.1 URL: https://github.com/apache/superset/pull/28677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python matplotlib-inline 0.1.6 -> 0.1.7 [superset]
mistercrunch closed pull request #28678: chore(料): bump python matplotlib-inline 0.1.6 -> 0.1.7 URL: https://github.com/apache/superset/pull/28678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python matplotlib 3.7.1 -> 3.9.0 [superset]
mistercrunch closed pull request #28674: chore(料): bump python matplotlib 3.7.1 -> 3.9.0 URL: https://github.com/apache/superset/pull/28674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python kombu 5.3.4 -> 5.3.7 [superset]
mistercrunch closed pull request #28675: chore(料): bump python kombu 5.3.4 -> 5.3.7 URL: https://github.com/apache/superset/pull/28675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python cffi 1.15.1 -> 1.16.0 [superset]
mistercrunch closed pull request #28676: chore(料): bump python cffi 1.15.1 -> 1.16.0 URL: https://github.com/apache/superset/pull/28676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python urllib3 1.26.18 -> 2.2.1 [superset]
mistercrunch closed pull request #28673: chore(料): bump python urllib3 1.26.18 -> 2.2.1 URL: https://github.com/apache/superset/pull/28673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python pyproject-api 1.5.2 -> 1.6.1 [superset]
mistercrunch closed pull request #28672: chore(料): bump python pyproject-api 1.5.2 -> 1.6.1 URL: https://github.com/apache/superset/pull/28672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python ruff 0.4.4 -> 0.4.5 [superset]
mistercrunch closed pull request #28669: chore(料): bump python ruff 0.4.4 -> 0.4.5 URL: https://github.com/apache/superset/pull/28669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python flask-limiter 3.3.1 -> 3.7.0 [superset]
mistercrunch closed pull request #28670: chore(料): bump python flask-limiter 3.3.1 -> 3.7.0 URL: https://github.com/apache/superset/pull/28670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python click-repl 0.2.0 -> 0.3.0 [superset]
mistercrunch closed pull request #28671: chore(料): bump python click-repl 0.2.0 -> 0.3.0 URL: https://github.com/apache/superset/pull/28671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python certifi 2023.7.22 -> 2024.2.2 [superset]
mistercrunch closed pull request #28667: chore(料): bump python certifi 2023.7.22 -> 2024.2.2 URL: https://github.com/apache/superset/pull/28667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python babel 2.9.1 -> 2.15.0 [superset]
mistercrunch closed pull request #28668: chore(料): bump python babel 2.9.1 -> 2.15.0 URL: https://github.com/apache/superset/pull/28668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python platformdirs 3.8.1 -> 4.2.2 [superset]
mistercrunch closed pull request #28664: chore(料): bump python platformdirs 3.8.1 -> 4.2.2 URL: https://github.com/apache/superset/pull/28664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python traitlets 5.9.0 -> 5.14.3 [superset]
mistercrunch closed pull request #28665: chore(料): bump python traitlets 5.9.0 -> 5.14.3 URL: https://github.com/apache/superset/pull/28665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python freezegun 1.4.0 -> 1.5.1 [superset]
mistercrunch closed pull request #28666: chore(料): bump python freezegun 1.4.0 -> 1.5.1 URL: https://github.com/apache/superset/pull/28666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python stack-data 0.6.2 -> 0.6.3 [superset]
mistercrunch closed pull request #28661: chore(料): bump python stack-data 0.6.2 -> 0.6.3 URL: https://github.com/apache/superset/pull/28661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python pexpect 4.8.0 -> 4.9.0 [superset]
mistercrunch closed pull request #28662: chore(料): bump python pexpect 4.8.0 -> 4.9.0 URL: https://github.com/apache/superset/pull/28662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python wheel 0.40.0 -> 0.43.0 [superset]
mistercrunch closed pull request #28660: chore(料): bump python wheel 0.40.0 -> 0.43.0 URL: https://github.com/apache/superset/pull/28660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(料): bump python googleapis-common-protos 1.59.0 -> 1.63.0 [superset]
mistercrunch closed pull request #28663: chore(料): bump python googleapis-common-protos 1.59.0 -> 1.63.0 URL: https://github.com/apache/superset/pull/28663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] refactor: Unify all json.(loads|dumps) usage to utils.json [superset]
codecov[bot] commented on PR #28702: URL: https://github.com/apache/superset/pull/28702#issuecomment-2129937137 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/28702?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `69.86301%` with `44 lines` in your changes are missing coverage. Please review. > Project coverage is 64.54%. Comparing base [(`76d897e`)](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`68b6267`)](https://app.codecov.io/gh/apache/superset/commit/68b626739b25220aa8c8b1b636947e352da20d87?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 176 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/superset/pull/28702?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [superset/commands/dataset/export.py](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree=superset%2Fcommands%2Fdataset%2Fexport.py_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvZGF0YXNldC9leHBvcnQucHk=) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [superset/dashboards/schemas.py](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree=superset%2Fdashboards%2Fschemas.py_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [superset/commands/dashboard/export.py](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree=superset%2Fcommands%2Fdashboard%2Fexport.py_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvZGFzaGJvYXJkL2V4cG9ydC5weQ==) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [superset/models/core.py](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree=superset%2Fmodels%2Fcore.py_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [superset/sql\_lab.py](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree=superset%2Fsql_lab.py_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [superset/utils/schema.py](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree=superset%2Futils%2Fschema.py_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQvdXRpbHMvc2NoZW1hLnB5) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [superset/views/chart/views.py](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree=superset%2Fviews%2Fchart%2Fviews.py_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvdmlld3MucHk=) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [superset/viz.py](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree=superset%2Fviz.py_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQvdml6LnB5) | 33.33% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [superset/charts/data/api.py](https://app.codecov.io/gh/apache/superset/pull/28702?src=pr=tree=superset%2Fcharts%2Fdata%2Fapi.py_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c3VwZXJzZXQvY2hhcnRzL2RhdGEvYXBpLnB5) | 75.00% | [1 Missing :warning:
Re: [PR] refactor: Unify all json.(loads|dumps) usage to utils.json [superset]
github-advanced-security[bot] commented on code in PR #28702:
URL: https://github.com/apache/superset/pull/28702#discussion_r1613727457
##
superset/views/base.py:
##
@@ -153,9 +153,7 @@
payload = payload or {"error": f"{msg}"}
return Response(
-json_utils.dumps(
-payload, default=json_utils.json_iso_dttm_ser, ignore_nan=True
-),
+json.dumps(payload, default=json.json_iso_dttm_ser, ignore_nan=True),
Review Comment:
## Information exposure through an exception
[Stack trace information](1) flows to this location and may be exposed to an
external user.
[Stack trace information](2) flows to this location and may be exposed to an
external user.
[Stack trace information](3) flows to this location and may be exposed to an
external user.
[Stack trace information](4) flows to this location and may be exposed to an
external user.
[Stack trace information](5) flows to this location and may be exposed to an
external user.
[Stack trace information](6) flows to this location and may be exposed to an
external user.
[Stack trace information](7) flows to this location and may be exposed to an
external user.
[Stack trace information](8) flows to this location and may be exposed to an
external user.
[Stack trace information](9) flows to this location and may be exposed to an
external user.
[Stack trace information](10) flows to this location and may be exposed to
an external user.
[Stack trace information](11) flows to this location and may be exposed to
an external user.
[Stack trace information](12) flows to this location and may be exposed to
an external user.
[Show more
details](https://github.com/apache/superset/security/code-scanning/1224)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] refactor: Unify all json.(loads|dumps) usage to utils.json [superset]
eyalezer opened a new pull request, #28702:
URL: https://github.com/apache/superset/pull/28702
### SUMMARY
Second phase of the json migration to use the new utils.json module
After completing the initial phase of creating the utils.json module as
mentioned in the following link: https://github.com/apache/superset/pull/28522,
we are now moving on to the second phase. This phase involves consolidating all
json usage and transitioning to the utilization of the newly created module.
During this phase:
- Refactored all instances where json was being used and updated the
references to utilize the json utils module.
- Made necessary additions and fixes to the tests to ensure their
compatibility with the changes made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] Plugins updates [superset]
grbneoxia closed pull request #28700: Plugins updates URL: https://github.com/apache/superset/pull/28700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] Plugins updates [superset]
grbneoxia opened a new pull request, #28700: URL: https://github.com/apache/superset/pull/28700 Updated plugins in package.json and modified CSP for iframe plugin testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Problems creating rows and columns in the superset. [superset]
dosubot[bot] commented on issue #28699:
URL: https://github.com/apache/superset/issues/28699#issuecomment-2129733407
Hello @LucasSantosGuedes! I'm here to help you with your Superset issue. I'm
a bot designed to assist with bug solving, answering questions, and guiding
contributors. Let's tackle this together!
To create rows and columns in Apache Superset without encountering layout
issues when adding elements and their divisions, you can follow these key
practices:
1. **Use Flexbox for Layout**: Utilize the `GridContent` and `GridRow`
components, which use flexbox to manage the layout of rows and columns. This
ensures proper alignment and spacing of elements.
2. **Handle Component Drop Properly**: Implement the `handleComponentDrop`
function correctly to manage the addition of new components without breaking
the layout.
3. **Use Droppable Areas**: Define areas where new components can be dropped
using the `Droppable` component. This helps maintain the layout structure.
4. **Use Resizable Containers**: Ensure elements can be resized without
breaking the layout by using the `ResizableContainer` component.
5. **Implement Row and Column Components Properly**: Handle the layout of
children in `Row` and `Column` components, including managing empty states and
drop targets.
Here are some code snippets to illustrate these practices:
```jsx
const GridContent = styled.div`
display: flex;
flex-direction: column;
/* Additional styles */
`;
const GridRow = styled.div`
display: flex;
flex-direction: row;
/* Additional styles */
`;
handleTopDropTargetDrop(dropResult) {
if (dropResult) {
this.props.handleComponentDrop({
...dropResult,
destination: {
...dropResult.destination,
index: 0,
},
});
}
}
```
By following these practices, you can create stable rows and columns in
Apache Superset without encountering layout issues
[[1]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/components/DashboardGrid.jsx)[[2]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx)[[3]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/components/gridComponents/Row.jsx)[[4]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/components/gridComponents/Column.jsx).
Details
**About Dosu**
This response is meant to be useful and save you time. It is **not meant to
be a precise solution**, but rather a starting point for your own research.
Help me be more useful! Please leave a if this is helpful and if it is
irrelevant.
*To continue the conversation, mention @dosu.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[I] Problems creating rows and columns in the superset. [superset]
LucasSantosGuedes opened a new issue, #28699: URL: https://github.com/apache/superset/issues/28699 ### Bug description I'm having trouble trying to create divisions on the screen. The superset appears to have limitations in this regard. I can't, for example, create a column and add the number of elements and their divisions. It always breaks. can you help me? ### How to reproduce the bug jj ### Screenshots/recordings jjj ### Superset version master / latest-dev ### Python version 3.9 ### Node version 16 ### Browser Chrome ### Additional context _No response_ ### Checklist - [ ] I have searched Superset docs and Slack and didn't find a solution to my problem. - [ ] I have searched the GitHub issue tracker and didn't find a similar bug report. - [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix: Handling of column types for Presto, Trino, et al. [superset]
john-bodley commented on code in PR #28653:
URL: https://github.com/apache/superset/pull/28653#discussion_r1613590625
##
tests/unit_tests/db_engine_specs/test_presto.py:
##
@@ -116,46 +115,44 @@ def test_get_schema_from_engine_params() -> None:
@pytest.mark.parametrize(
["column_type", "column_value", "expected_value"],
[
-(types.DATE(), "2023-05-01", "DATE '2023-05-01'"),
-(types.TIMESTAMP(), "2023-05-01", "TIMESTAMP '2023-05-01'"),
-(types.VARCHAR(), "2023-05-01", "'2023-05-01'"),
-(types.INT(), 1234, "1234"),
+("DATE", "2023-05-01", "DATE '2023-05-01'"),
+("TIMESTAMP", "2023-05-01", "TIMESTAMP '2023-05-01'"),
+("VARCHAR", "2023-05-01", "'2023-05-01'"),
+("INT", 1234, "1234"),
],
)
def test_where_latest_partition(
-mock_latest_partition, column_type, column_value: Any, expected_value: str
+mock_latest_partition,
+column_type: str,
+column_value: Any,
+expected_value: str,
) -> None:
-"""
-Test the ``where_latest_partition`` method
-"""
-from superset.db_engine_specs.presto import PrestoEngineSpec as spec
+from superset.db_engine_specs.presto import PrestoEngineSpec
mock_latest_partition.return_value = (["partition_key"], [column_value])
-query = sql.select(text("* FROM table"))
-columns: list[ResultSetColumnType] = [
-{
-"column_name": "partition_key",
-"name": "partition_key",
-"type": column_type,
-"is_dttm": False,
-}
-]
-
-expected = f"""SELECT * FROM table \nWHERE "partition_key" =
{expected_value}"""
-result = spec.where_latest_partition(
-mock.MagicMock(),
-Table("table"),
-query,
-columns,
-)
-assert result is not None
-actual = result.compile(
-dialect=PrestoDialect(), compile_kwargs={"literal_binds": True}
+assert (
Review Comment:
Same logic as before just condensed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Can't get ALERTS & REPORTS working. Error: Failed taking a screenshot Message: 'geckodriver' executable needs to be in PATH. [superset]
sfirke closed issue #28686: Can't get ALERTS & REPORTS working. Error: Failed taking a screenshot Message: 'geckodriver' executable needs to be in PATH. URL: https://github.com/apache/superset/issues/28686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Superset ALERT & REPORTS not working [superset]
sfirke commented on issue #28686: URL: https://github.com/apache/superset/issues/28686#issuecomment-2129588834 Yes please see the docs that @gaful linked. I'm going to convert this to a Discussion, as it is not a bug report of a problem with Superset but instead a request for help getting the configuration set up. Try searching GitHub Discussions and Issues for that error message, it has come up before, e.g. https://github.com/apache/superset/issues/23057. It has also been addressed in the Slack chat that is open to the public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] BUG: Can't flush None value found in collection Role.permissions [superset]
ne1r0n commented on issue #27896:
URL: https://github.com/apache/superset/issues/27896#issuecomment-2129523876
Faced the same problem, fixed by:
`NEW_PVMS = {"Dashboard": ("can_view_chart_as_table", "can_view_query",)}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: Add deck.gl Heatmap Visualization [superset]
salvatorecolori commented on PR #23551: URL: https://github.com/apache/superset/pull/23551#issuecomment-2129519788 Hi, does this plugin/chart have extraProps enabled for javascript tooltips generator? When I try to use js code to generate tooltpis, I receive a javascript Uncaught TypeError: Cannot read properties of undefined (reading 'extraProps')". Please check [https://github.com/apache/superset/issues/25871#issuecomment-2129426493](url) too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[PR] chore(docs): address common error message in Quickstart [superset]
sfirke opened a new pull request, #28696: URL: https://github.com/apache/superset/pull/28696 This was asked and answered several times recently in Slack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Javascript Tooltip Generator error in deck.gl Scatterplot in superset version 3.0.1 [superset]
salvatorecolori commented on issue #25871: URL: https://github.com/apache/superset/issues/25871#issuecomment-2129426493 Hi there, sorry for my support request. I'm trying to use javascript tooltips con deck.gl heatmap and other deck.gl chart, but it works only on scatterplot chart. Using js tooltips on deck.gl heatmap, produce an "javascript Uncaught TypeError: Cannot read properties of undefined (reading 'extraProps')". Extra fields are correctly filled in. If I copy-paste js tooltips code from Scatter to Heatmap, I receive the error. Talisman is set as FALSE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Superset ALERT & REPORTS not working [superset]
gaful commented on issue #28686: URL: https://github.com/apache/superset/issues/28686#issuecomment-2129180668 Hello, It seems that you have 2 issue : 1. issue with sending email : what does your system logs says ? they are usually quite usefull. 2. issue with capturing image : from the documentation https://superset.apache.org/docs/configuration/alerts-reports/ > You must install a headless browser, for taking screenshots of the charts and dashboards. Only Firefox and Chrome are currently supported. > If you choose Chrome, you must also change the value of WEBDRIVER_TYPE to "chrome" in your superset_config.py. > > Note: All the components required (Firefox headless browser, Redis, Postgres db, celery worker and celery beat) are present in the dev docker image if you are following [Installing Superset Locally](https://superset.apache.org/docs/installation/docker-compose/). All you need to do is add the required config variables described in this guide (See Detailed Config). By the way I would recommend to make it works for csv or txt first and then moove to image -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Can't import dashbaords with CLI [superset]
dosubot[bot] commented on issue #28692:
URL: https://github.com/apache/superset/issues/28692#issuecomment-2129124821
To resolve the `superset.commands.exceptions.CommandInvalidError: Error
importing dashboard` issue when trying to import dashboards using the CLI in
Apache Superset, follow these steps:
1. **Check User Permissions**:
Ensure the user has the necessary permissions to create or overwrite
dashboards. This is checked by `security_manager.can_access("can_write",
"Dashboard")`.
2. **Validate Configuration**:
Ensure the dashboard configuration (`config` dictionary) is correctly
formatted and includes all necessary fields. Pay special attention to the
`uuid`, `position`, and `metadata` fields.
3. **Handle UUIDs and IDs**:
Ensure that the UUIDs for charts and datasets are correctly mapped and
updated in the configuration. The `update_id_refs` function helps in updating
these references.
4. **Remove Deprecated Fields**:
Remove any deprecated fields from the configuration, such as
`show_native_filters` in the `metadata`.
Additionally, ensure that the CLI command for importing dashboards is
correctly used. Here is an example of how to use the `import_dashboards`
command from `superset/cli/importexport.py`:
```python
@click.command()
@with_appcontext
@click.option(
"--path",
"-p",
required=True,
help="Path to a single ZIP file",
)
@click.option(
"--username",
"-u",
required=True,
help="Specify the user name to assign dashboards to",
)
def import_dashboards(path: str, username: Optional[str]) -> None:
"""Import dashboards from ZIP file"""
from superset.commands.dashboard.importers.dispatcher import
ImportDashboardsCommand
from superset.commands.importers.v1.utils import get_contents_from_bundle
if username is not None:
g.user = security_manager.find_user(username=username)
if is_zipfile(path):
with ZipFile(path) as bundle:
contents = get_contents_from_bundle(bundle)
else:
with open(path) as file:
contents = {path: file.read()}
try:
ImportDashboardsCommand(contents, overwrite=True).run()
except Exception: # pylint: disable=broad-except
logger.exception(
"There was an error when importing the dashboards(s), please
check "
"the exception traceback in the log"
)
sys.exit(1)
```
By following these steps and ensuring the configuration and permissions are
correctly handled, you should be able to resolve the `CommandInvalidError` when
importing dashboards using the CLI in Apache Superset
[[1]](https://github.com/apache/superset/blob/master/superset/commands/dashboard/importers/v1/utils.py)[[2]](https://github.com/apache/superset/blob/master/superset/cli/importexport.py)[[3]](https://github.com/apache/superset/blob/master/superset/commands/dashboard/importers/v1/__init__.py).
Details
**About Dosu**
This response is meant to be useful and save you time. It is **not meant to
be a precise solution**, but rather a starting point for your own research.
Help me be more useful! Please leave a if this is helpful and if it is
irrelevant.
*To continue the conversation, mention @dosu.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[I] Can't import dashbaords with CLI [superset]
xavier-GitHub76 opened a new issue, #28692: URL: https://github.com/apache/superset/issues/28692 ### Bug description Hello, I try to export/import dashboard with cli but I have an error "superset.commands.exceptions.CommandInvalidError: Error importing dashboard" ### How to reproduce the bug I export my dashboards with CLI :  I delete all elements on my superset     I try import with cli superset import-dashboards -p myDashboards.zip -u xavier  I try also after a creation of database connexion :   Best regards ### Screenshots/recordings _No response_ ### Superset version master / latest-dev ### Python version 3.9 ### Node version 16 ### Browser Chrome ### Additional context _No response_ ### Checklist - [ ] I have searched Superset docs and Slack and didn't find a solution to my problem. - [ ] I have searched the GitHub issue tracker and didn't find a similar bug report. - [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] superset fab list-users return username, email, role but not firstname, lastname, active [superset]
dosubot[bot] commented on issue #28691:
URL: https://github.com/apache/superset/issues/28691#issuecomment-2129065622
The `superset fab list-users` command does not include the `firstname`,
`lastname`, and `active` columns in its output because these columns are not
specified in the `list_columns` attribute of the `UserModelView` class. The
`list_columns` attribute determines which columns are displayed when listing
users.
To include the `firstname`, `lastname`, and `active` columns in the output,
you need to modify the `UserModelView` class to specify these columns in the
`list_columns` attribute. Here is an example of how you can do this:
```python
from flask_appbuilder import ModelView
from flask_appbuilder.security.sqla.models import User
class CustomUserModelView(ModelView):
datamodel = SQLAInterface(User)
list_columns = ["id", "username", "firstname", "lastname", "active",
"email"]
appbuilder.add_view(
CustomUserModelView,
"List Users",
icon="fa-user",
label=_("List Users"),
category="Security",
category_icon="fa-cogs",
)
```
By adding the `firstname`, `lastname`, and `active` columns to the
`list_columns` attribute, they will be included in the output of the `superset
fab list-users` command
[[1]](https://github.com/apache/superset/blob/master/superset/security/manager.py).
Details
**About Dosu**
This response is meant to be useful and save you time. It is **not meant to
be a precise solution**, but rather a starting point for your own research.
Help me be more useful! Please leave a if this is helpful and if it is
irrelevant.
*To continue the conversation, mention @dosu.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[I] superset fab list-users return username, email, role but not firstname, lastname, active [superset]
xavier-GitHub76 opened a new issue, #28691: URL: https://github.com/apache/superset/issues/28691 ### Bug description Hello, superset fab list-users list all users on the database but all colums are not returned. username, email, role are listed but not firstname, lastname, active colums in database are :  Best regards ### How to reproduce the bug superset fab list-users ### Screenshots/recordings _No response_ ### Superset version master / latest-dev ### Python version 3.9 ### Node version 16 ### Browser Chrome ### Additional context _No response_ ### Checklist - [ ] I have searched Superset docs and Slack and didn't find a solution to my problem. - [ ] I have searched the GitHub issue tracker and didn't find a similar bug report. - [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[I] Option for file could be the same for superset export-dashboards / superset import-dashboards [superset]
xavier-GitHub76 opened a new issue, #28690: URL: https://github.com/apache/superset/issues/28690 ### Bug description Hello, Option for file could be the same for superset export-dashboards / superset import-dashboards Actually : - export-dashboards use : -f - import-dashboards use : -p In https://github.com/apache/superset/blob/master/superset/cli/importexport.py "-f" is used to define a file for : export_dashboards :  export_datasources :  (and 2 legacy : - legacy_export_dashboards - legacy_export_datasources ) "-p" is used to define a file for : import_dashboards  import_datasources  (and 4 legacy : - legacy_export_dashboards - legacy_export_datasources - legacy_import_dashboards - legacy_import_datasources ) "-p" should be used everywhere, like superset fab export-roles  Best regards ### How to reproduce the bug superset export-dashboards --help Usage: superset export-dashboards [OPTIONS] Export dashboards to ZIP file Options: -f, --dashboard-file TEXT Specify the file to export to --help Show this message and exit. superset import-dashboards --help Usage: superset import-dashboards [OPTIONS] Import dashboards from ZIP file Options: -p, --path TEXT Path to a single ZIP file [required] -u, --username TEXT Specify the user name to assign dashboards to [required] --help Show this message and exit. ### Screenshots/recordings _No response_ ### Superset version master / latest-dev ### Python version 3.9 ### Node version 16 ### Browser Chrome ### Additional context _No response_ ### Checklist - [ ] I have searched Superset docs and Slack and didn't find a solution to my problem. - [ ] I have searched the GitHub issue tracker and didn't find a similar bug report. - [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Admin can not overwrite chart from another owner [superset]
mtrentz commented on issue #24399: URL: https://github.com/apache/superset/issues/24399#issuecomment-2129004936 To contribute into the SQL solutions here this query adds all admins as owner into all existing charts: ``` INSERT INTO slice_user (user_id, slice_id) SELECT DISTINCT u.user_id, s.id FROM slices s JOIN ab_user_role u ON u.user_id NOT IN (SELECT user_id FROM slice_user WHERE slice_id = s.id) WHERE u.role_id = (SELECT id FROM ab_role WHERE name = 'Admin'); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Can't export dashboards with CLI if 'admin' user is not created [superset]
dosubot[bot] commented on issue #28689:
URL: https://github.com/apache/superset/issues/28689#issuecomment-2128954616
To address the issue of exporting dashboards using the CLI in Superset 3.1.1
when the 'admin' user is not created, you can modify the `export_dashboards`
function to include a `-u` option. This allows you to specify a different admin
account. Here is the updated function:
```python
@click.command()
@with_appcontext
@click.option(
"--dashboard-file",
"-f",
help="Specify the file to export to",
)
@click.option(
"--username",
"-u",
required=True,
help="Specify the user name to use for exporting dashboards",
)
def export_dashboards(dashboard_file: Optional[str] = None, username:
Optional[str] = None) -> None:
"""Export dashboards to ZIP file"""
from superset.commands.dashboard.export import ExportDashboardsCommand
from superset.models.dashboard import Dashboard
g.user = security_manager.find_user(username=username)
dashboard_ids = [id_ for (id_,) in db.session.query(Dashboard.id).all()]
timestamp = datetime.now().strftime("%Y%m%dT%H%M%S")
root = f"dashboard_export_{timestamp}"
dashboard_file = dashboard_file or f"{root}.zip"
try:
with ZipFile(dashboard_file, "w") as bundle:
for file_name, file_content in
ExportDashboardsCommand(dashboard_ids).run():
with bundle.open(f"{root}/{file_name}", "w") as fp:
fp.write(file_content().encode())
except Exception:
logger.exception(
"There was an error when exporting the dashboards, please check "
"the exception traceback in the log"
)
sys.exit(1)
```
This modification allows you to specify a different admin account using the
`-u` option when exporting dashboards
[[1]](https://github.com/apache/superset/blob/master/superset/cli/importexport.py).
Additionally, there are existing command-line options in the Superset CLI
that allow specifying a user for other commands, such as importing dashboards
and datasources. These options are implemented using the `--username` or `-u`
flag
[[1]](https://github.com/apache/superset/blob/master/superset/cli/importexport.py).
However, the current tests for the `export_dashboards` function do not cover
scenarios where the 'admin' user does not exist. All tests assume the existence
of the 'admin' user
[[2]](https://github.com/apache/superset/blob/master/tests/integration_tests/dashboards/commands_tests.py)[[3]](https://github.com/apache/superset/blob/master/tests/integration_tests/cli_tests.py).
Details
**About Dosu**
This response is meant to be useful and save you time. It is **not meant to
be a precise solution**, but rather a starting point for your own research.
Help me be more useful! Please leave a if this is helpful and if it is
irrelevant.
*To continue the conversation, mention @dosu.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[I] Can't export dashboards with CLI if 'admin' user is not created [superset]
xavier-GitHub76 opened a new issue, #28689: URL: https://github.com/apache/superset/issues/28689 ### Bug description Hello, with Superset 3.1.1, I can't export dashboards with CLI if 'admin' user is not created There should be a -u option to specify the admin account to use Actually, on all branchs, 'admin' is hard coded : https://github.com/apache/superset/blob/master/superset/cli/importexport.py  Best regards ### How to reproduce the bug I have an admin user 'xavier’ (user 'admin' is not created)  If I export / import from web app with user ‘xavier’, it's OK with CLI, I have an error "AttributeError: 'NoneType' object has no attribute 'is_anonymous'"  To succed, user 'admin' must exist   ### Screenshots/recordings _No response_ ### Superset version master / latest-dev ### Python version 3.9 ### Node version 16 ### Browser Chrome ### Additional context _No response_ ### Checklist - [ ] I have searched Superset docs and Slack and didn't find a solution to my problem. - [ ] I have searched the GitHub issue tracker and didn't find a similar bug report. - [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Admin can not overwrite chart from another owner [superset]
mtrentz commented on issue #24399: URL: https://github.com/apache/superset/issues/24399#issuecomment-2128904067 I'm on `4.0.1` and also have this issue. Really wish that admins had the power to edit any chart without having to add yourself as owner :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] BUG) Superset get wrong value of TIMESTAMP WITH TIME ZONE type field on Trino client [superset]
okayhooni closed issue #28685: BUG) Superset get wrong value of TIMESTAMP WITH TIME ZONE type field on Trino client URL: https://github.com/apache/superset/issues/28685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] BUG) Superset get wrong value of TIMESTAMP WITH TIME ZONE type field on Trino client [superset]
okayhooni commented on issue #28685: URL: https://github.com/apache/superset/issues/28685#issuecomment-2128744546 I found this issue was related to the bug on `trino-python-client` itself. this issue was fixed on `v0.324` of that library, so I solved this issue by updating this dependency from `v0.321` to `0.328` - related MR: https://github.com/trinodb/trino-python-client/pull/368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [I] Superset throws unexpected error while loading filters in a dashboard. [superset]
dosubot[bot] commented on issue #28687:
URL: https://github.com/apache/superset/issues/28687#issuecomment-2128706095
@Thoufiqkhan Hello there! I'm here to help you with any bugs, questions, or
becoming a contributor. Let's tackle this together!
To resolve the JavaScript runtime error "Cannot read properties of undefined
(reading 'filter')" that occurs while loading filters in an Apache Superset
dashboard, you need to ensure that the `dataMask` object is properly defined
and not `undefined` before calling the `filter` method on it.
In the provided code, the `useNativeFiltersDataMask` function is where the
`filter` method is used on `dataMask`. To prevent the error, you should add a
check to ensure `dataMask` is defined before attempting to use the `filter`
method.
Here is the modified `useNativeFiltersDataMask` function with the necessary
check:
```ts
export const useNativeFiltersDataMask = () => {
const dataMask = useSelector(
state => state.dataMask,
);
return useMemo(
() =>
dataMask
? Object.values(dataMask)
.filter((item: DataMaskWithId) =>
String(item.id).startsWith(NATIVE_FILTER_PREFIX),
)
.reduce(
(prev, next: DataMaskWithId) => ({ ...prev, [next.id]: next }),
{},
) as DataMaskStateWithId
: {},
[dataMask],
);
};
```
Additionally, ensure that the `dataMask` object is correctly initialized and
populated in the relevant parts of your codebase. For example, in the
`createHandleSave` function, make sure that the `defaultDataMask` is set
properly:
```ts
defaultDataMask: formInputs.defaultDataMask ?? getInitialDataMask(),
```
Moreover, you can refer to the
`superset-frontend/src/dashboard/components/nativeFilters/utils.ts` file for
additional context on how filters are managed and applied in Apache Superset.
This file includes functions like `getFormData`, `mergeExtraFormData`, and
`getExtraFormData` which handle the form data and extra form data for filters.
Ensuring these functions are correctly implemented and that `dataMask` and
other related objects are properly managed can help prevent such runtime errors
[[1]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/state.ts)[[2]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/utils.ts)[[3]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/util/activeDashboardFilters.js)[[4]](https://github.com/apache/superset/blob/master/superset-frontend/src/dash
board/components/nativeFilters/utils.ts).
Details
**About Dosu**
This response is meant to be useful and save you time. It is **not meant to
be a precise solution**, but rather a starting point for your own research.
Help me be more useful! Please leave a if this is helpful and if it is
irrelevant.
*To continue the conversation, mention @dosu.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
