[GitHub] [incubator-superset] codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint
codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#issuecomment-529036459 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=h1) Report > Merging [#8163](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6df74c6b8eb4ce502d3b582a56590fc3d9514517?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `67.79%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8163 +/- ## == - Coverage 65.66% 65.66% -0.01% == Files 481 481 Lines 2334623363 +17 Branches 2572 2572 == + Hits1533115341 +10 - Misses 7877 7884 +7 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.11% <67.79%> (-0.14%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=footer). Last update [6df74c6...89f1f4a](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint
codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#issuecomment-529036459 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=h1) Report > Merging [#8163](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c566141f251ab8b59449428bf92f21fc20e45858?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `69.49%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8163 +/- ## == + Coverage 65.95% 65.96% +0.01% == Files 479 479 Lines 2303723053 +16 Branches 2552 2552 == + Hits1519415208 +14 - Misses 7707 7709 +2 Partials 136 136 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.91% <69.49%> (-0.17%)` | :arrow_down: | | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.55% <0%> (+17.24%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=footer). Last update [c566141...619b962](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint
codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#issuecomment-529036459 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=h1) Report > Merging [#8163](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c566141f251ab8b59449428bf92f21fc20e45858?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `69.49%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8163 +/- ## == + Coverage 65.95% 65.96% +0.01% == Files 479 479 Lines 2303723053 +16 Branches 2552 2552 == + Hits1519415208 +14 - Misses 7707 7709 +2 Partials 136 136 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.91% <69.49%> (-0.17%)` | :arrow_down: | | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.55% <0%> (+17.24%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=footer). Last update [c566141...619b962](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint
codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#issuecomment-529036459 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=h1) Report > Merging [#8163](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c566141f251ab8b59449428bf92f21fc20e45858?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `69.49%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8163 +/- ## == + Coverage 65.95% 65.97% +0.01% == Files 479 479 Lines 2303723054 +17 Branches 2552 2552 == + Hits1519415209 +15 - Misses 7707 7709 +2 Partials 136 136 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.93% <69.49%> (-0.15%)` | :arrow_down: | | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.55% <0%> (+17.24%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=footer). Last update [c566141...619b962](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint
codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#issuecomment-529036459 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=h1) Report > Merging [#8163](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c566141f251ab8b59449428bf92f21fc20e45858?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `69.49%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8163 +/- ## == + Coverage 65.95% 65.97% +0.01% == Files 479 479 Lines 2303723054 +17 Branches 2552 2552 == + Hits1519415209 +15 - Misses 7707 7709 +2 Partials 136 136 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.93% <69.49%> (-0.15%)` | :arrow_down: | | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.55% <0%> (+17.24%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=footer). Last update [c566141...619b962](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint
codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#issuecomment-529036459 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=h1) Report > Merging [#8163](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c566141f251ab8b59449428bf92f21fc20e45858?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `69.49%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8163 +/- ## == + Coverage 65.95% 65.97% +0.01% == Files 479 479 Lines 2303723054 +17 Branches 2552 2552 == + Hits1519415209 +15 - Misses 7707 7709 +2 Partials 136 136 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.93% <69.49%> (-0.15%)` | :arrow_down: | | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.55% <0%> (+17.24%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=footer). Last update [c566141...619b962](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint
codecov-io edited a comment on issue #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#issuecomment-529036459 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=h1) Report > Merging [#8163](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ae0dc30c0a428e53d77bd00484aac5663a2856b5?src=pr=desc) will **decrease** coverage by `7.58%`. > The diff coverage is `71.23%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8163 +/- ## == - Coverage 73.75% 66.17% -7.59% == Files 115 479 +364 Lines 1205322952 +10899 Branches0 2524+2524 == + Hits 889015189+6299 - Misses 3163 7629+4466 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.43% <71.23%> (-0.1%)` | :arrow_down: | | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `55.17% <0%> (-17.25%)` | :arrow_down: | | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `87.88% <0%> (-0.18%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.26% <0%> (-0.12%)` | :arrow_down: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | | | [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | `0% <0%> (ø)` | | | ... and [360 more](https://codecov.io/gh/apache/incubator-superset/pull/8163/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=footer). Last update [ae0dc30...36bf58d](https://codecov.io/gh/apache/incubator-superset/pull/8163?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
