[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9831: [WIP] refactor: simplify getExploreUrl functions
codecov-io edited a comment on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=h1) Report > Merging [#9831](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b8eaa114eddc6a42e2b69b7ab88479c3128a52be=desc) will **decrease** coverage by `0.23%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=tree) ```diff @@Coverage Diff @@ ## master#9831 +/- ## == - Coverage 71.02% 70.79% -0.24% == Files 586 184 -402 Lines 3063517868 -12767 Branches 31510-3151 == - Hits2175912649-9110 + Misses 8765 5219-3546 + Partials 1110 -111 ``` | Flag | Coverage Δ | | |---|---|---| | #cypress | `?` | | | #javascript | `?` | | | #python | `70.79% <ø> (-0.48%)` | :arrow_down: | | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: | | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: | | [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: | | [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: | | [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `58.58% <0.00%> (-3.80%)` | :arrow_down: | | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: | | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: | | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.59% <0.00%> (-3.14%)` | :arrow_down: | | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: | | ... and [428 more](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=footer). Last update [b8eaa11...4e02f4e](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9831: [WIP] refactor: simplify getExploreUrl functions
codecov-io edited a comment on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=h1) Report > Merging [#9831](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b8eaa114eddc6a42e2b69b7ab88479c3128a52be=desc) will **increase** coverage by `0.24%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=tree) ```diff @@Coverage Diff @@ ## master#9831 +/- ## == + Coverage 71.02% 71.27% +0.24% == Files 586 184 -402 Lines 3063518051 -12584 Branches 31510-3151 == - Hits2175912865-8894 + Misses 8765 5186-3579 + Partials 1110 -111 ``` | Flag | Coverage Δ | | |---|---|---| | #cypress | `?` | | | #javascript | `?` | | | #python | `71.27% <ø> (ø)` | | | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=tree) | Coverage Δ | | |---|---|---| | [...t-frontend/src/explore/controlPanels/Partition.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9QYXJ0aXRpb24uanN4) | | | | [...ntend/src/dashboard/components/PublishedStatus.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy5qc3g=) | | | | [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | | | | [...-frontend/src/dashboard/util/isDashboardLoading.js](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzRGFzaGJvYXJkTG9hZGluZy5qcw==) | | | | [...perset-frontend/src/dashboard/util/isValidChild.js](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC5qcw==) | | | | [...tend/src/SqlLab/components/ScheduleQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24uanN4) | | | | [...et-frontend/src/explore/controlPanels/Separator.js](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TZXBhcmF0b3IuanM=) | | | | [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | | | | [...perset-frontend/src/messageToasts/actions/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvYWN0aW9ucy9pbmRleC5qcw==) | | | | [superset-frontend/src/components/RefreshLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaExhYmVsLmpzeA==) | | | | ... and [387 more](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=footer). Last update [b8eaa11...eeafad4](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9831: [WIP] refactor: simplify getExploreUrl functions
codecov-io edited a comment on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9831: [WIP] refactor: simplify getExploreUrl functions
codecov-io edited a comment on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=h1) Report > Merging [#9831](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b8eaa114eddc6a42e2b69b7ab88479c3128a52be=desc) will **increase** coverage by `0.24%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=tree) ```diff @@Coverage Diff @@ ## master#9831 +/- ## == + Coverage 71.02% 71.27% +0.24% == Files 586 184 -402 Lines 3063518051 -12584 Branches 31510-3151 == - Hits2175912865-8894 + Misses 8765 5186-3579 + Partials 1110 -111 ``` | Flag | Coverage Δ | | |---|---|---| | #cypress | `?` | | | #javascript | `?` | | | #python | `71.27% <ø> (ø)` | | | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=tree) | Coverage Δ | | |---|---|---| | [...d/util/logging/getLoadStatsPerTopLevelComponent.js](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZ2V0TG9hZFN0YXRzUGVyVG9wTGV2ZWxDb21wb25lbnQuanM=) | | | | [...t-frontend/src/dashboard/reducers/dashboardInfo.js](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRJbmZvLmpz) | | | | [...perset-frontend/src/utils/DebouncedMessageQueue.js](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL0RlYm91bmNlZE1lc3NhZ2VRdWV1ZS5qcw==) | | | | [superset-frontend/src/utils/parseCookie.ts](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3BhcnNlQ29va2llLnRz) | | | | [...nd/src/explore/components/controls/TextControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC5qc3g=) | | | | [.../src/dashboard/util/serializeActiveFilterValues.js](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUFjdGl2ZUZpbHRlclZhbHVlcy5qcw==) | | | | [...end/src/dashboard/util/getKeyForFilterScopeTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEtleUZvckZpbHRlclNjb3BlVHJlZS5qcw==) | | | | [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | | | | [superset-frontend/src/showSavedQuery/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Nob3dTYXZlZFF1ZXJ5L2luZGV4LmpzeA==) | | | | [...-frontend/src/explore/components/RowCountLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Sb3dDb3VudExhYmVsLmpzeA==) | | | | ... and [387 more](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=footer). Last update [b8eaa11...eeafad4](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail:
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9831: [WIP] refactor: simplify getExploreUrl functions
codecov-io edited a comment on pull request #9831: URL: https://github.com/apache/incubator-superset/pull/9831#issuecomment-630017035 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=h1) Report > Merging [#9831](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b8eaa114eddc6a42e2b69b7ab88479c3128a52be=desc) will **decrease** coverage by `0.23%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=tree) ```diff @@Coverage Diff @@ ## master#9831 +/- ## == - Coverage 71.02% 70.79% -0.24% == Files 586 184 -402 Lines 3063517868 -12767 Branches 31510-3151 == - Hits2175912649-9110 + Misses 8765 5219-3546 + Partials 1110 -111 ``` | Flag | Coverage Δ | | |---|---|---| | #cypress | `?` | | | #javascript | `?` | | | #python | `70.79% <ø> (-0.48%)` | :arrow_down: | | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: | | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: | | [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: | | [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: | | [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `58.58% <0.00%> (-3.80%)` | :arrow_down: | | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: | | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: | | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.59% <0.00%> (-3.14%)` | :arrow_down: | | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: | | ... and [428 more](https://codecov.io/gh/apache/incubator-superset/pull/9831/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=footer). Last update [b8eaa11...eeafad4](https://codecov.io/gh/apache/incubator-superset/pull/9831?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
