[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend
graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab
state in the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-533037917
@betodealmeida deleting tab is still **not** working for me, see 2 issues
below:
1. First, delete a few query tabs with history. When you open new tab, old
history will show up in the newly created tabs:
2. create new empty tab, reload page, delete empty tab => first query tab
became empty.
there is no JS error thrown, i guess there is something wrong in the
re-render logic.
I did downgrade the DB and upgrade again. actually i am using a new computer
and db is clean.
this is my local config:
```
CACHE_CONFIG = {
'CACHE_TYPE': 'redis',
'CACHE_REDIS_URL': 'redis://localhost:6379/0',
}
RESULTS_BACKEND = RedisCache(
host='localhost',
port=6379,
key_prefix='superset_results',
)
DEFAULT_FEATURE_FLAGS = {
"SQLLAB_BACKEND_PERSISTENCE": True,
}
```
Do i miss any config?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend
graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab
state in the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-533037917
@betodealmeida deleting tab is still **not** working for me, see 2 issues
below:
1. delete query tab with history:
2. create new empty tab, reload page, delete empty tab => first query tab
became empty.
there is no JS error thrown, i guess there is something wrong in the
re-render logic.
I did downgrade the DB and upgrade again. actually i am using a new computer
and db is cleaned.
this is my local config:
```
CACHE_CONFIG = {
'CACHE_TYPE': 'redis',
'CACHE_REDIS_URL': 'redis://localhost:6379/0',
}
RESULTS_BACKEND = RedisCache(
host='localhost',
port=6379,
key_prefix='superset_results',
)
DEFAULT_FEATURE_FLAGS = {
"SQLLAB_BACKEND_PERSISTENCE": True,
}
```
Do i miss any config?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend
graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-530622944 Report a few bugs: 1. if you have multiple queries in the same tab, select the 1st query and run, refresh browser, you will lost 2nd query in the tab. But select 2nd query and refresh browser is good.  2. REMOVE_QUERY and REMOVE_QUERY_EDITOR actions seems not working correct. When sql lab is reloaded, removed items in the query history tab are still showing up. Probably need to test all redux state change triggered data persist.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend
graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-530622944 Report a few bugs: 1. if you have multiple queries in the same tab, select the 1st query and run, refresh browser, you will lost 2nd query in the tab. But select 2nd query and refresh browser is good.  2. REMOVE_QUERY and REMOVE_QUERY_EDITOR actions seems not working correct. When sql lab is reloaded, removed items in the query history tab are still showing up. Probably need to check if any other actions need to trigger data persist.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend
graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-530622944 report another bug: if you have multiple queries in the same tab, select the 1st query and run, refresh browser, you will lost 2nd query in the tab. But select 2nd query and refresh browser is good.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend
graceguo-supercat edited a comment on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-527225040 1. when i open sql lab page, i always see `No stored results found, you need to re-run your query`. 2. I re-run query a couple of times, also see the error message flashing out. 3. after query results is returned and displayed, i reload sql lab, then old results won't show up. is it right behavior?  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
