[GitHub] [incubator-superset] kuckjwi0928 commented on issue #8028: histogram must be str not list

2019-08-21 Thread GitBox
kuckjwi0928 commented on issue #8028: histogram must be str not list
URL: 
https://github.com/apache/incubator-superset/issues/8028#issuecomment-523442300
 
 
   > > I think the HistogramViz class needs to be modified to the format below.
   > > 
[kuckjwi0928@c9b1c11](https://github.com/kuckjwi0928/incubator-superset/commit/c9b1c110a09873212a953299f798662eacbc4f44)
   > 
   > this retrieved the data, but caused another exception when rendering the 
chart:
   > 
   > 
![image](https://user-images.githubusercontent.com/13299109/63395885-d470a000-c3f7-11e9-8823-d23666f8e703.png)
   
   I've reviewed it, When visualization type change occurs after refresh, chart 
rendering is executed even though no query is set.
   
   From the second try, it will work normally.
   
   This requires checking not only the histogram but also other charts.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org



[GitHub] [incubator-superset] kuckjwi0928 commented on issue #8028: histogram must be str not list

2019-08-19 Thread GitBox
kuckjwi0928 commented on issue #8028: histogram must be str not list
URL: 
https://github.com/apache/incubator-superset/issues/8028#issuecomment-522854769
 
 
   I think the HistogramViz class needs to be modified to the format below.
   
   
https://github.com/kuckjwi0928/incubator-superset/commit/c9b1c110a09873212a953299f798662eacbc4f44


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org