[GitHub] GabeLoins commented on a change in pull request #4914: [WiP] make MetricsControl the standard across visualizations

[GitBox]

GabeLoins commented on a change in pull request #4914: [WiP] make 
MetricsControl the standard across visualizations
URL: 
https://github.com/apache/incubator-superset/pull/4914#discussion_r187758550
 
 

 ##
 File path: superset/viz.py
 ##
 @@ -202,7 +222,7 @@ def query_obj(self):
 """Building a query object"""
 form_data = self.form_data
 gb = form_data.get('groupby') or []
-metrics = form_data.get('metrics') or []
+metrics = self.all_metrics or []
 
 Review comment:
   cc @hug @mistercrunch ^


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

[GitHub] GabeLoins commented on a change in pull request #4914: [WiP] make MetricsControl the standard across visualizations

[GitBox]

GabeLoins commented on a change in pull request #4914: [WiP] make 
MetricsControl the standard across visualizations
URL: 
https://github.com/apache/incubator-superset/pull/4914#discussion_r186150357
 
 

 ##
 File path: superset/viz.py
 ##
 @@ -90,6 +88,28 @@ def __init__(self, datasource, form_data, force=False):
 self._any_cached_dttm = None
 self._extra_chart_data = None
 
+self.process_metrics()
+
+def process_metrics(self):
+self.metric_dict = {}
+fd = self.form_data
+for mkey in METRIC_KEYS:
+val = fd.get(mkey)
+if val:
+print(mkey, val)
 
 Review comment:
   zoops


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org