Re: [PR] chore(translations): fix translations order [superset]
rusackas merged PR #28031: URL: https://github.com/apache/superset/pull/28031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(translations): fix translations order [superset]
rusackas commented on PR #28031: URL: https://github.com/apache/superset/pull/28031#issuecomment-2067169093 Running Ci... then we'll merge it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(translations): fix translations order [superset]
lscheibel commented on PR #28031: URL: https://github.com/apache/superset/pull/28031#issuecomment-2066244030 Thanks for taking a look everyone. I fixed the line endings of the .po and .pot files, which were failing the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(translations): fix translations order [superset]
rusackas commented on PR #28031: URL: https://github.com/apache/superset/pull/28031#issuecomment-2064201114 Running CI 🤞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(translations): fix translations order [superset]
rusackas commented on code in PR #28031:
URL: https://github.com/apache/superset/pull/28031#discussion_r1570961303
##
superset/sql_parse.py:
##
@@ -765,8 +765,8 @@ def _extract_tables_from_sql(self) -> set[Table]:
SupersetError(
error_type=SupersetErrorType.QUERY_SECURITY_ACCESS_ERROR,
message=__(
-f"You may have an error in your SQL statement.
{message}"
-),
Review Comment:
Oh, could you point me to where those live, @john-bodley, and I'll try to
GPT us out of this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(translations): fix translations order [superset]
john-bodley commented on code in PR #28031:
URL: https://github.com/apache/superset/pull/28031#discussion_r1567715496
##
superset/sql_parse.py:
##
@@ -765,8 +765,8 @@ def _extract_tables_from_sql(self) -> set[Table]:
SupersetError(
error_type=SupersetErrorType.QUERY_SECURITY_ACCESS_ERROR,
message=__(
-f"You may have an error in your SQL statement.
{message}"
-),
Review Comment:
@rusackas we have custom (WIP) Pylint checkers. I guess one would need to
add one to check whether there's an f-string being used within a translation
`__(...)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] chore(translations): fix translations order [superset]
rusackas commented on code in PR #28031:
URL: https://github.com/apache/superset/pull/28031#discussion_r1566230444
##
superset/sql_parse.py:
##
@@ -765,8 +765,8 @@ def _extract_tables_from_sql(self) -> set[Table]:
SupersetError(
error_type=SupersetErrorType.QUERY_SECURITY_ACCESS_ERROR,
message=__(
-f"You may have an error in your SQL statement.
{message}"
-),
Review Comment:
I wonder if @john-bodley knows a good way to lint against this. According to
GPT, we can write a custom pylint checker, but it seems like that would be a
first for this codebase. Something off the shelf to prevent this would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
