Re: [PR] feat: setup a pyproject.toml [superset]
mistercrunch commented on PR #27859: URL: https://github.com/apache/superset/pull/27859#issuecomment-2035463982 https://github.com/apache/superset/pull/27884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: setup a pyproject.toml [superset]
mistercrunch commented on PR #27859: URL: https://github.com/apache/superset/pull/27859#issuecomment-2035422250 My main intent was to be able to parse the dependencies to support `supersetbot` acting as `dependabot` while moving to more modern means to store metadata. But I agree we should consolidate as much as possible, happy to follow up with a PR to try and kill setup.cfg is possible and update the docs where needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: setup a pyproject.toml [superset]
john-bodley commented on PR #27859: URL: https://github.com/apache/superset/pull/27859#issuecomment-2035190478 @mistercrunch is the intent to: 1. Remove `setup.py` and `setup.cfg`? I know we use the later for Mypy et al., but it seems that _most_ packages can use the `pyproject.toml` file for configuration ([example](https://mypy.readthedocs.io/en/stable/config_file.html))? 2. Update the [code and documentation](https://github.com/search?q=repo%3Aapache%2Fsuperset%20setup.py=code) to reference `pyproject.toml`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: setup a pyproject.toml [superset]
mistercrunch commented on code in PR #27859: URL: https://github.com/apache/superset/pull/27859#discussion_r1548877100 ## requirements/development.txt: ## @@ -241,20 +244,15 @@ s3transfer==0.6.1 sqlalchemy-bigquery==1.10.0 # via apache-superset sqloxide==0.1.33 -# via -r requirements/development.in +# via apache-superset stack-data==0.6.2 # via ipython statsd==4.0.1 -# via -r requirements/development.in +# via apache-superset tableschema==1.20.10 # via apache-superset -thrift==0.20.0 -# via -# apache-superset -# pyhive -# thrift-sasl -thrift-sasl==0.4.3 Review Comment: I think that was bad merge conflict resolution, but interestingly this PR brought it back - guessing through a `pip-compile-multi --no-upgrade` run -> https://github.com/apache/superset/pull/27631/files#diff-f449835486933e5cab23a8567940e46d53edd89923cf1a3a4fb83005b069a93fR260 Now I did another run here -> https://github.com/apache/superset/pull/27861/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: setup a pyproject.toml [superset]
john-bodley commented on code in PR #27859: URL: https://github.com/apache/superset/pull/27859#discussion_r1548845437 ## requirements/development.txt: ## @@ -241,20 +244,15 @@ s3transfer==0.6.1 sqlalchemy-bigquery==1.10.0 # via apache-superset sqloxide==0.1.33 -# via -r requirements/development.in +# via apache-superset stack-data==0.6.2 # via ipython statsd==4.0.1 -# via -r requirements/development.in +# via apache-superset tableschema==1.20.10 # via apache-superset -thrift==0.20.0 -# via -# apache-superset -# pyhive -# thrift-sasl -thrift-sasl==0.4.3 Review Comment: @mistercrunch the removal of `thrift-sasl` (which should be included via `pyhive[hive_pure_sasl]`) is breaking CI, i.e., for [test-postgres-hive](https://github.com/apache/superset/actions/runs/8532143694/job/23373369856?pr=27843#logs), I'm seeing, ``` > import thrift_sasl E ModuleNotFoundError: No module named 'thrift_sasl' ``` i.e., something seems amiss with the frozen requirements when using `pyproject.toml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: setup a pyproject.toml [superset]
john-bodley commented on code in PR #27859: URL: https://github.com/apache/superset/pull/27859#discussion_r1548845437 ## requirements/development.txt: ## @@ -241,20 +244,15 @@ s3transfer==0.6.1 sqlalchemy-bigquery==1.10.0 # via apache-superset sqloxide==0.1.33 -# via -r requirements/development.in +# via apache-superset stack-data==0.6.2 # via ipython statsd==4.0.1 -# via -r requirements/development.in +# via apache-superset tableschema==1.20.10 # via apache-superset -thrift==0.20.0 -# via -# apache-superset -# pyhive -# thrift-sasl -thrift-sasl==0.4.3 Review Comment: @mistercrunch the removal of `thrift-sasl` (which should be included via `pyhive[hive_pure_sasl]`) is breaking CI, i.e., for [test-postgres-hive](https://github.com/apache/superset/actions/runs/8532143694/job/23373369856?pr=27843#logs), I'm seeing: ``` > import thrift_sasl E ModuleNotFoundError: No module named 'thrift_sasl' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: setup a pyproject.toml [superset]
mistercrunch merged PR #27859: URL: https://github.com/apache/superset/pull/27859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: setup a pyproject.toml [superset]
mistercrunch commented on PR #27859: URL: https://github.com/apache/superset/pull/27859#issuecomment-2033295504 I don't think there's anything controversial here, just moving dep management to a new, parsable file that is becoming the standard. Mergin' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] feat: setup a pyproject.toml [superset]
mistercrunch commented on code in PR #27859: URL: https://github.com/apache/superset/pull/27859#discussion_r1548702503 ## requirements/development.in: ## @@ -17,26 +17,4 @@ # under the License. # -r base.in --e .[bigquery,cors,druid,gevent,gsheets,hive,mysql,playwright,postgres,presto,prophet,trino,thumbnails] - -docker -flask-testing -freezegun -greenlet>=2.0.2 -grpcio>=1.55.3 -ipython -openapi-spec-validator -parameterized -pip-compile-multi -pre-commit -progress>=1.5,<2 -pyfakefs -pyinstrument>=4.0.2,<5 -pylint -pytest -pytest-cov -pytest-mock -python-ldap>=3.4.4 -sqloxide -statsd -tox +-e .[development,bigquery,cors,druid,gevent,gsheets,hive,mysql,playwright,postgres,presto,prophet,trino,thumbnails] Review Comment: note that I added `development` here, which is referencing a group that contains the libs referenced in the file bellow, now in pyproject.toml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
